[ { "url": "https://api.github.com/repos/electron/electron/issues/9872", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9872/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9872/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9872/events", "html_url": "https://github.com/electron/electron/issues/9872", "id": 238696347, "number": 9872, "title": "Please add Notification usage example to main process documentation", "user": { "login": "naheller", "id": 18204925, "avatar_url": "https://avatars2.githubusercontent.com/u/18204925?v=3", "gravatar_id": "", "url": "https://api.github.com/users/naheller", "html_url": "https://github.com/naheller", "followers_url": "https://api.github.com/users/naheller/followers", "following_url": "https://api.github.com/users/naheller/following{/other_user}", "gists_url": "https://api.github.com/users/naheller/gists{/gist_id}", "starred_url": "https://api.github.com/users/naheller/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/naheller/subscriptions", "organizations_url": "https://api.github.com/users/naheller/orgs", "repos_url": "https://api.github.com/users/naheller/repos", "events_url": "https://api.github.com/users/naheller/events{/privacy}", "received_events_url": "https://api.github.com/users/naheller/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-26T23:20:56Z", "updated_at": "2017-06-26T23:31:48Z", "closed_at": "2017-06-26T23:28:56Z", "body": "The [renderer](https://github.com/electron/electron/blob/master/docs/tutorial/notifications.md) process documentation page contains some sample code that got me up and running, but the [main](https://github.com/electron/electron/blob/master/docs/api/notification.md) process documentation contains no such samples. \r\n\r\nAs a new developer, I can really benefit from examples, and the link to the NodeJS [Events](https://nodejs.org/api/events.html#events_class_events_eventemitter) documentation is quite verbose and I haven't been able to extract the information I need.\r\n\r\nI've attempted to use the syntax from the renderer process construction in my main process, as shown below:\r\n\r\n`const Notification = require('electron')`\r\n```\r\nlet myNotification = new Notification('Title', {\r\n body: 'Lorem Ipsum Dolor Sit Amet'\r\n })\r\nmyNotification.show()\r\n```\r\n\r\nHowever this causes the error: \r\n`Uncaught Exception: TypeError: Notification is not a constructor`\r\n\r\nWhat is the correct syntax for constructing a Notification in the main process? \r\nYour advice is appreciated!" }, { "url": "https://api.github.com/repos/electron/electron/issues/9871", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9871/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9871/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9871/events", "html_url": "https://github.com/electron/electron/issues/9871", "id": 238688878, "number": 9871, "title": "Component does not unmount on App Close/Before-Quit event.", "user": { "login": "akshaygore06", "id": 9061850, "avatar_url": "https://avatars1.githubusercontent.com/u/9061850?v=3", "gravatar_id": "", "url": "https://api.github.com/users/akshaygore06", "html_url": "https://github.com/akshaygore06", "followers_url": "https://api.github.com/users/akshaygore06/followers", "following_url": "https://api.github.com/users/akshaygore06/following{/other_user}", "gists_url": "https://api.github.com/users/akshaygore06/gists{/gist_id}", "starred_url": "https://api.github.com/users/akshaygore06/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akshaygore06/subscriptions", "organizations_url": "https://api.github.com/users/akshaygore06/orgs", "repos_url": "https://api.github.com/users/akshaygore06/repos", "events_url": "https://api.github.com/users/akshaygore06/events{/privacy}", "received_events_url": "https://api.github.com/users/akshaygore06/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-26T22:35:33Z", "updated_at": "2017-06-27T01:44:14Z", "closed_at": "2017-06-27T01:44:14Z", "body": "I am working on the video player app in the electron. I want to save the progress of the video. When the user quits the app using \"X\" button or the CMD + Q. App closes without unmounting Video Payer Component which does not allow to save the progress of the video. " }, { "url": "https://api.github.com/repos/electron/electron/issues/9870", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9870/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9870/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9870/events", "html_url": "https://github.com/electron/electron/pull/9870", "id": 238660198, "number": 9870, "title": "add IME to glossary", "user": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-26T20:29:33Z", "updated_at": "2017-06-26T20:31:48Z", "closed_at": "2017-06-26T20:31:46Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9870", "html_url": "https://github.com/electron/electron/pull/9870", "diff_url": "https://github.com/electron/electron/pull/9870.diff", "patch_url": "https://github.com/electron/electron/pull/9870.patch" }, "body": "I noticed the term \"IME\" in https://github.com/electron/electron/issues/9709 and didn't know what it was, so I added it to the glossary." }, { "url": "https://api.github.com/repos/electron/electron/issues/9869", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9869/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9869/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9869/events", "html_url": "https://github.com/electron/electron/pull/9869", "id": 238650303, "number": 9869, "title": "[WIP] Exposes more Handoff related APIs to Electron", "user": { "login": "rafaelnobrepd", "id": 20772372, "avatar_url": "https://avatars0.githubusercontent.com/u/20772372?v=3", "gravatar_id": "", "url": "https://api.github.com/users/rafaelnobrepd", "html_url": "https://github.com/rafaelnobrepd", "followers_url": "https://api.github.com/users/rafaelnobrepd/followers", "following_url": "https://api.github.com/users/rafaelnobrepd/following{/other_user}", "gists_url": "https://api.github.com/users/rafaelnobrepd/gists{/gist_id}", "starred_url": "https://api.github.com/users/rafaelnobrepd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rafaelnobrepd/subscriptions", "organizations_url": "https://api.github.com/users/rafaelnobrepd/orgs", "repos_url": "https://api.github.com/users/rafaelnobrepd/repos", "events_url": "https://api.github.com/users/rafaelnobrepd/events{/privacy}", "received_events_url": "https://api.github.com/users/rafaelnobrepd/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T19:50:40Z", "updated_at": "2017-06-26T19:50:40Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9869", "html_url": "https://github.com/electron/electron/pull/9869", "diff_url": "https://github.com/electron/electron/pull/9869.diff", "patch_url": "https://github.com/electron/electron/pull/9869.patch" }, "body": "Hi guys, thanks for the amazing project!\r\nI'm taking a stab at improving Handoff support as in #9622 \r\nMy C++ and Js skills are close to zero, so please bear with me!\r\nI attempted mimicking the change points of a few PRs and added what we needed: support for invalidating the current activity, updating the current activity user info and a few delegate callbacks as events.\r\nIt looks to work when running the app with command `electron ./electron-source`\r\n\r\n```javascript\r\n const electron = require('electron');\r\n const { app } = electron;\r\n\r\n [...]\r\n\r\n console.log(app.invalidateCurrentActivity);\r\n //output: function invalidateCurrentActivity() { [native code] }\r\n```\r\n\r\nHowever, Handoff will only work when the app is properly signed with the Team ID, and in this case my implementation doesn't seem to work:\r\nRunning App after package with `electron-packager`\r\n\r\n```javascript\r\n const electron = require('electron');\r\n const { app } = electron;\r\n\r\n [...]\r\n\r\n dialog.showMessageBox(mainWindow, {\r\n message: app.invalidateCurrentActivity.toString()\r\n });\r\n /**\r\n A JavaScript error occurred in the main process\r\n Uncaught Exception:\r\n TypeError: Cannot read property 'toString' of undefined\r\n at EventEmitter. (/Users/Shared/myApp/releases/mas-preview/MyApp-mas-x64/My App.app/Contents/Resources/app.asar/js/main.min.js:1:385981)\r\n at emitTwo (events.js:106:13)\r\n at EventEmitter.emit (events.js:191:7)\r\n at WebContents. (/Users/Shared/myApp/releases/mas-preview/My App-mas-x64/My App.app/Contents/Resources/electron.asar/browser/api/web-contents.js:247:37)\r\n at emitTwo (events.js:106:13)\r\n at WebContents.emit (events.js:191:7)\r\n */\r\n```\r\n\r\nIt would be awesome to get some feedback on what may be missing here to work. I downloaded libchromium-static and ran bootstrap with the -u option as it would never finish downloading within the script itself.\r\nI took the out/R/Electron.app and replaced the one in the dist folder when packaging." }, { "url": "https://api.github.com/repos/electron/electron/issues/9868", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9868/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9868/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9868/events", "html_url": "https://github.com/electron/electron/issues/9868", "id": 238633721, "number": 9868, "title": "Support printing in landscape from API", "user": { "login": "timfish", "id": 1150298, "avatar_url": "https://avatars1.githubusercontent.com/u/1150298?v=3", "gravatar_id": "", "url": "https://api.github.com/users/timfish", "html_url": "https://github.com/timfish", "followers_url": "https://api.github.com/users/timfish/followers", "following_url": "https://api.github.com/users/timfish/following{/other_user}", "gists_url": "https://api.github.com/users/timfish/gists{/gist_id}", "starred_url": "https://api.github.com/users/timfish/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/timfish/subscriptions", "organizations_url": "https://api.github.com/users/timfish/orgs", "repos_url": "https://api.github.com/users/timfish/repos", "events_url": "https://api.github.com/users/timfish/events{/privacy}", "received_events_url": "https://api.github.com/users/timfish/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-26T18:43:49Z", "updated_at": "2017-06-27T03:15:22Z", "closed_at": null, "body": "Currently there is no way to force printing into landscape. This means I have to offer my users portrait/landscape choice in the UI so I can render my print output for the correct size and then hope the user goes into their printer settings after printing has been triggered to choose landscape there too. " }, { "url": "https://api.github.com/repos/electron/electron/issues/9867", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9867/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9867/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9867/events", "html_url": "https://github.com/electron/electron/pull/9867", "id": 238617932, "number": 9867, "title": "Upgrade to electron/libchromiumcontent@cb972fbb8aa", "user": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T17:44:16Z", "updated_at": "2017-06-26T17:44:34Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9867", "html_url": "https://github.com/electron/electron/pull/9867", "diff_url": "https://github.com/electron/electron/pull/9867.diff", "patch_url": "https://github.com/electron/electron/pull/9867.patch" }, "body": "Pulls in https://github.com/electron/libchromiumcontent/pull/315\r\n\r\nRefs https://github.com/electron/electron/issues/9854\r\n\r\n/cc @alespergl " }, { "url": "https://api.github.com/repos/electron/electron/issues/9866", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9866/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9866/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9866/events", "html_url": "https://github.com/electron/electron/issues/9866", "id": 238614737, "number": 9866, "title": "iframe and webview not working properly", "user": { "login": "yoshifan509", "id": 8814123, "avatar_url": "https://avatars3.githubusercontent.com/u/8814123?v=3", "gravatar_id": "", "url": "https://api.github.com/users/yoshifan509", "html_url": "https://github.com/yoshifan509", "followers_url": "https://api.github.com/users/yoshifan509/followers", "following_url": "https://api.github.com/users/yoshifan509/following{/other_user}", "gists_url": "https://api.github.com/users/yoshifan509/gists{/gist_id}", "starred_url": "https://api.github.com/users/yoshifan509/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yoshifan509/subscriptions", "organizations_url": "https://api.github.com/users/yoshifan509/orgs", "repos_url": "https://api.github.com/users/yoshifan509/repos", "events_url": "https://api.github.com/users/yoshifan509/events{/privacy}", "received_events_url": "https://api.github.com/users/yoshifan509/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-26T17:32:19Z", "updated_at": "2017-06-27T01:46:04Z", "closed_at": "2017-06-27T01:46:04Z", "body": "\r\nHi. I am making an app using the latest (stable) version of electron and i need to use the tag\r\n* Electron version: 1.6.11\r\n* Operating system: macOS 10.12.5\r\n\r\n### Expected behavior\r\n\r\n\r\nThe webview should be taking up the right amount of space on the page. Basically the webview isnt taking up the specified px.\r\n### Actual behavior\r\nTakes up the whole width of the window.\r\n\r\n\r\n### How to reproduce\r\nhttps://github.com/yoshifan509/Roblox-Desktop-Launcher\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9865", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9865/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9865/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9865/events", "html_url": "https://github.com/electron/electron/issues/9865", "id": 238607197, "number": 9865, "title": "Windows builds fail to run because 'Entry Point Not Found'", "user": { "login": "poiru", "id": 1319028, "avatar_url": "https://avatars1.githubusercontent.com/u/1319028?v=3", "gravatar_id": "", "url": "https://api.github.com/users/poiru", "html_url": "https://github.com/poiru", "followers_url": "https://api.github.com/users/poiru/followers", "following_url": "https://api.github.com/users/poiru/following{/other_user}", "gists_url": "https://api.github.com/users/poiru/gists{/gist_id}", "starred_url": "https://api.github.com/users/poiru/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poiru/subscriptions", "organizations_url": "https://api.github.com/users/poiru/orgs", "repos_url": "https://api.github.com/users/poiru/repos", "events_url": "https://api.github.com/users/poiru/events{/privacy}", "received_events_url": "https://api.github.com/users/poiru/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T17:02:32Z", "updated_at": "2017-06-26T17:02:32Z", "closed_at": null, "body": "On Windows, after building with:\r\n\r\n```\r\n./script/bootstrap.py --dev\r\n./script/build.py -c D\r\n```\r\n\r\nI can no longer run the resulting `electron.exe` due to errors like:\r\n\r\n```\r\nThe procedure entry point ?SetByBounds@Rect@gfx@@QEAAXHHHH@Z could not be located in the dynamic link library C:\\projects\\electron\\out\\D\\geometry_skia.dll. \r\n```\r\n```\r\nThe procedure entry point ??0BindStateBase@internal@base@@AEAA@P6AXXZP6AXPEBV012@@Z@Z could not be located in the dynamic link library C:\\projects\\electron\\out\\D\\animation.dll. \r\n```\r\n```\r\nThe procedure entry point ?MakeRGB@SkColorSpace@@SA?AV?$sk_sp@VSkColorSpace@@@@AEBUSkColorSpaceTransferFn@@AEBVSkMatrix44@@@Z could not be located in the dynamic link library C:\\projects\\electron\\out\\D\\color_space.dll. \r\n```\r\n\r\nElectron compiles and runs fine before 873a315538ae4da500bf73cbad60924d7d658d96 (#9764). cc @alespergl" }, { "url": "https://api.github.com/repos/electron/electron/issues/9864", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9864/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9864/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9864/events", "html_url": "https://github.com/electron/electron/issues/9864", "id": 238594266, "number": 9864, "title": "how to auto unpack node_modules", "user": { "login": "ZweiZhao", "id": 13098498, "avatar_url": "https://avatars1.githubusercontent.com/u/13098498?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ZweiZhao", "html_url": "https://github.com/ZweiZhao", "followers_url": "https://api.github.com/users/ZweiZhao/followers", "following_url": "https://api.github.com/users/ZweiZhao/following{/other_user}", "gists_url": "https://api.github.com/users/ZweiZhao/gists{/gist_id}", "starred_url": "https://api.github.com/users/ZweiZhao/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ZweiZhao/subscriptions", "organizations_url": "https://api.github.com/users/ZweiZhao/orgs", "repos_url": "https://api.github.com/users/ZweiZhao/repos", "events_url": "https://api.github.com/users/ZweiZhao/events{/privacy}", "received_events_url": "https://api.github.com/users/ZweiZhao/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-26T16:13:39Z", "updated_at": "2017-06-27T03:18:15Z", "closed_at": "2017-06-27T03:18:15Z", "body": "how to auto unpack node_modules" }, { "url": "https://api.github.com/repos/electron/electron/issues/9863", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9863/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9863/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9863/events", "html_url": "https://github.com/electron/electron/issues/9863", "id": 238588122, "number": 9863, "title": "The right side of video image is displayed on the left side in video stream during screen share", "user": { "login": "lubov15911", "id": 14281771, "avatar_url": "https://avatars3.githubusercontent.com/u/14281771?v=3", "gravatar_id": "", "url": "https://api.github.com/users/lubov15911", "html_url": "https://github.com/lubov15911", "followers_url": "https://api.github.com/users/lubov15911/followers", "following_url": "https://api.github.com/users/lubov15911/following{/other_user}", "gists_url": "https://api.github.com/users/lubov15911/gists{/gist_id}", "starred_url": "https://api.github.com/users/lubov15911/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lubov15911/subscriptions", "organizations_url": "https://api.github.com/users/lubov15911/orgs", "repos_url": "https://api.github.com/users/lubov15911/repos", "events_url": "https://api.github.com/users/lubov15911/events{/privacy}", "received_events_url": "https://api.github.com/users/lubov15911/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T15:52:34Z", "updated_at": "2017-06-26T15:55:15Z", "closed_at": null, "body": "* Electron version: 1.6.11\r\n* Operating system: Window 10\r\n\r\nI use `desktopCapturer` to share my screen in application. So, if I choose Entire screen from returned from `getSoures` list, the right side (2-3px) of video image is cut off and displays on the left side (something like video image shifting to right). Below you can see how it looks. The issue is reproduced only with entire screen, but not with windows.\r\n\r\n![bug](https://user-images.githubusercontent.com/14281771/27546092-6c886cac-5a9a-11e7-8e83-542be88400f9.png)\r\n\r\nAs I know Electron is using the Chromium's code for `desktopCapture`, but I cannot reproduce the same issue in Chrome.\r\n\r\nNote:\r\nIt's reproducible on windows 7 too.\r\nThis issue does not appear with two displays.\r\n\r\nPerhaps someone faced with it and knows how to fix this.\r\nCan it be an Electron issue?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9862", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9862/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9862/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9862/events", "html_url": "https://github.com/electron/electron/issues/9862", "id": 238549472, "number": 9862, "title": "processes persists after closing the application on packaged", "user": { "login": "four-eyes-04-04", "id": 21032419, "avatar_url": "https://avatars3.githubusercontent.com/u/21032419?v=3", "gravatar_id": "", "url": "https://api.github.com/users/four-eyes-04-04", "html_url": "https://github.com/four-eyes-04-04", "followers_url": "https://api.github.com/users/four-eyes-04-04/followers", "following_url": "https://api.github.com/users/four-eyes-04-04/following{/other_user}", "gists_url": "https://api.github.com/users/four-eyes-04-04/gists{/gist_id}", "starred_url": "https://api.github.com/users/four-eyes-04-04/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/four-eyes-04-04/subscriptions", "organizations_url": "https://api.github.com/users/four-eyes-04-04/orgs", "repos_url": "https://api.github.com/users/four-eyes-04-04/repos", "events_url": "https://api.github.com/users/four-eyes-04-04/events{/privacy}", "received_events_url": "https://api.github.com/users/four-eyes-04-04/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 8, "created_at": "2017-06-26T13:50:01Z", "updated_at": "2017-06-26T15:21:39Z", "closed_at": null, "body": "Hi everyone, I just started using electron today, I am creating this hello world application that seems okay while in development, so if I run electron, as you would while developing it, using `npm start` that points to `electron .` I see my app which is simply a page with `

hello world!

`, but if I package it using [https://github.com/Urucas/electron-packager-interactive](electron-packager-interactive), I run the `[app name].exe` then if I close the application, the process (on my task manager) is not closing.\r\n\r\n**Directory**\r\n```\r\n|-app\r\n|-node_modules\r\n|-public\r\n|---main.html\r\n|---app.css (bundled with webpack)\r\n|---main.js (bundled with webpack)\r\n|-resources\r\n|---assets\r\n|------scripts\r\n|------styles\r\n```\r\n\r\n**scripts/entry.js**\r\n```\r\nimport electron from 'electron';\r\nimport path from 'path';\r\nimport url from 'url';\r\n\r\nconst Browser = electron.BrowserWindow;\r\nconst App = electron.app;\r\n\r\nlet mainWindow;\r\n\r\nApp.on('ready', () => {\r\n mainWindow = new Browser({\r\n minWidth: 1024,\r\n minHeight: 600,\r\n width: 1024,\r\n height: 600\r\n });\r\n\r\n mainWindow.loadURL(url.format({\r\n pathname: path.join(__dirname, 'main.html'),\r\n protocol: 'file',\r\n slashes: true\r\n }));\r\n});\r\n\r\nApp.on('window-close-all', App.quit);\r\nApp.on('before-quit', () => {\r\n mainWindow.removeAllListeners('close');\r\n});\r\n```\r\n\r\n**styles/entry.sass**\r\n```\r\nh1\r\n color: gray\r\n```\r\n\r\n### while on dev (electron .)\r\n**opened**\r\n![image](https://user-images.githubusercontent.com/21032419/27542385-b051edfe-5ab9-11e7-9937-8dbec5bd6f7d.png)\r\n**closed**\r\n![image](https://user-images.githubusercontent.com/21032419/27542454-dfb00a68-5ab9-11e7-83e0-54336f21acbf.png)\r\n\r\n### packaged\r\n**opened**\r\n![image](https://user-images.githubusercontent.com/21032419/27542504-fc3202ae-5ab9-11e7-88f7-009365fbe57d.png)\r\n**closed**\r\n![image](https://user-images.githubusercontent.com/21032419/27542514-064a6d30-5aba-11e7-8e93-6320a2c760f2.png)\r\n\r\nThe processes simply persist and if I open another application I get 4 total processes (2 new plus the old 2 persisting processes) and the same thing happens to those process.\r\n\r\n### from packager\r\n? Overwrite output directory ? Yes\r\n? Use asar source packaging ? Yes\r\n? Select Electron app source directory: C:\\Users\\aprilpineda\\Documents\\projects\\desktop\\experiments\\1-helloworld\r\n? Select Electron app output directory: (C:\\Users\\aprilpineda\\Documents\\projects\\desktop\\experiments\\1-helloworld\\releas? Select Electron app output directory: C:\\Users\\aprilpineda\\Documents\\projects\\desktop\\experiments\\1-helloworld\\releases\r\n? Select Application name: 1-helloworld\r\n? Select App Bundle Id (optional):\r\n? Select App Version(optional): 0.0.1\r\n? Select Electron icon file:\r\n? Select Electron version release: 1.6.11\r\n? Select platforms:\r\n? Select architecture:\r\n! No arch specified, defaulting to x64\r\n! No platform specified, defaulting to win32\r\nElectron packager settings:\r\n{ dir: 'C:\\\\Users\\\\aprilpineda\\\\Documents\\\\projects\\\\desktop\\\\experiments\\\\1-helloworld',\r\n name: '1-helloworld',\r\n platform: null,\r\n arch: null,\r\n electronVersion: '1.6.11',\r\n out: 'C:\\\\Users\\\\aprilpineda\\\\Documents\\\\projects\\\\desktop\\\\experiments\\\\1-helloworld\\\\releases',\r\n appBundleId: '',\r\n appVersion: '0.0.1',\r\n overwrite: true,\r\n asar: true,\r\n icon: '',\r\n bundle_id: '',\r\n appname: '1-helloworld',\r\n sourcedir: 'C:\\\\Users\\\\aprilpineda\\\\Documents\\\\projects\\\\desktop\\\\experiments\\\\1-helloworld',\r\n ignore: 'C:\\\\Users\\\\aprilpineda\\\\Documents\\\\projects\\\\desktop\\\\experiments\\\\1-helloworld\\\\releases' }\r\nPackaging app for platform win32 x64 using electron v1.6.11\r\n✓ Application packaged successfully to 'C:\\Users\\aprilpineda\\Documents\\projects\\desktop\\experiments\\1-helloworld\\releases\\1-helloworld-win32-x64'" }, { "url": "https://api.github.com/repos/electron/electron/issues/9861", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9861/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9861/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9861/events", "html_url": "https://github.com/electron/electron/issues/9861", "id": 238540933, "number": 9861, "title": "MacOS crash probably while xhr request/response", "user": { "login": "cumajkeee", "id": 1834053, "avatar_url": "https://avatars0.githubusercontent.com/u/1834053?v=3", "gravatar_id": "", "url": "https://api.github.com/users/cumajkeee", "html_url": "https://github.com/cumajkeee", "followers_url": "https://api.github.com/users/cumajkeee/followers", "following_url": "https://api.github.com/users/cumajkeee/following{/other_user}", "gists_url": "https://api.github.com/users/cumajkeee/gists{/gist_id}", "starred_url": "https://api.github.com/users/cumajkeee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cumajkeee/subscriptions", "organizations_url": "https://api.github.com/users/cumajkeee/orgs", "repos_url": "https://api.github.com/users/cumajkeee/repos", "events_url": "https://api.github.com/users/cumajkeee/events{/privacy}", "received_events_url": "https://api.github.com/users/cumajkeee/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T13:21:13Z", "updated_at": "2017-06-26T13:21:29Z", "closed_at": null, "body": "* Electron version: 1.6.2\r\n* Operating system: MacOS 10.12.5 \r\n\r\nLast action before crash was xhr request.\r\n\r\n```\r\nCrashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread\r\n\r\nException Type: EXC_BAD_ACCESS (SIGSEGV)\r\nException Codes: KERN_INVALID_ADDRESS at 0x0000000000000010\r\nException Note: EXC_CORPSE_NOTIFY\r\n\r\nTermination Signal: Segmentation fault: 11\r\nTermination Reason: Namespace SIGNAL, Code 0xb\r\nTerminating Process: exc handler [0]\r\n\r\nVM Regions Near 0x10:\r\n--> \r\n __TEXT 00000001008fb000-00000001008fc000 [ 4K] r-x/rwx SM=COW /Applications/APP.app/Contents/MacOS/APP\r\n\r\nThread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread\r\n0 com.github.electron.framework \t0x0000000100b509b4 0x100907000 + 2398644\r\n1 com.github.electron.framework \t0x000000010098f810 mate::TrackableObjectBase::GetIDFromWrappedClass(base::SupportsUserData*) + 16\r\n2 com.github.electron.framework \t0x000000010096fa31 0x100907000 + 428593\r\n3 com.github.electron.framework \t0x0000000100968eb0 atom::api::WebContents::CreateFrom(v8::Isolate*, content::WebContents*) + 32\r\n4 com.github.electron.framework \t0x00000001009129be atom::api::App::OnLogin(atom::LoginHandler*, base::DictionaryValue const&) + 126\r\n5 com.github.electron.framework \t0x0000000100912bad non-virtual thunk to atom::api::App::OnLogin(atom::LoginHandler*, base::DictionaryValue const&) + 13\r\n6 com.github.electron.framework \t0x000000010099d6c7 atom::Browser::RequestLogin(atom::LoginHandler*, std::__1::unique_ptr >) + 119\r\n7 com.github.electron.framework \t0x00000001009a4867 0x100907000 + 645223\r\n8 com.github.electron.framework \t0x00000001009a480c 0x100907000 + 645132\r\n9 com.github.electron.framework \t0x00000001009a47c3 0x100907000 + 645059\r\n10 com.github.electron.framework \t0x00000001009a4744 base::internal::Invoker >), base::internal::UnretainedWrapper, base::internal::RetainedRefWrapper, base::internal::PassedWrapper > > >, void ()>::Run(base::internal::BindStateBase*) + 20\r\n11 com.github.electron.framework \t0x0000000100b53a31 0x100907000 + 2411057\r\n12 com.github.electron.framework \t0x0000000100b278c6 0x100907000 + 2230470\r\n13 com.github.electron.framework \t0x0000000100b27b9c 0x100907000 + 2231196\r\n14 com.github.electron.framework \t0x0000000100b27ee3 0x100907000 + 2232035\r\n15 com.github.electron.framework \t0x0000000100b2b22d 0x100907000 + 2245165\r\n16 com.github.electron.framework \t0x0000000100ae7dea 0x100907000 + 1969642\r\n17 com.github.electron.framework \t0x0000000100b2aca4 0x100907000 + 2243748\r\n18 com.apple.CoreFoundation \t0x00007fff90b5b3e1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17\r\n19 com.apple.CoreFoundation \t0x00007fff90b3c65c __CFRunLoopDoSources0 + 556\r\n20 com.apple.CoreFoundation \t0x00007fff90b3bb46 __CFRunLoopRun + 934\r\n21 com.apple.CoreFoundation \t0x00007fff90b3b544 CFRunLoopRunSpecific + 420\r\n22 com.apple.HIToolbox \t0x00007fff9009bebc RunCurrentEventLoopInMode + 240\r\n23 com.apple.HIToolbox \t0x00007fff9009bcf1 ReceiveNextEventCommon + 432\r\n24 com.apple.HIToolbox \t0x00007fff9009bb26 _BlockUntilNextEventMatchingListInModeWithFilter + 71\r\n25 com.apple.AppKit \t0x00007fff8e634a54 _DPSNextEvent + 1120\r\n26 com.apple.AppKit \t0x00007fff8edb07ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796\r\n27 com.apple.AppKit \t0x00007fff8e6293db -[NSApplication run] + 926\r\n28 com.github.electron.framework \t0x0000000100b2ba7e 0x100907000 + 2247294\r\n29 com.github.electron.framework \t0x0000000100b2b0ec 0x100907000 + 2244844\r\n30 com.github.electron.framework \t0x0000000100b2762e 0x100907000 + 2229806\r\n31 com.github.electron.framework \t0x0000000100b3c183 0x100907000 + 2314627\r\n32 com.github.electron.framework \t0x0000000100d8be8b 0x100907000 + 4738699\r\n33 com.github.electron.framework \t0x0000000100d8bce0 0x100907000 + 4738272\r\n34 com.github.electron.framework \t0x0000000100d8e422 0x100907000 + 4748322\r\n35 com.github.electron.framework \t0x0000000100d87dbc 0x100907000 + 4722108\r\n36 com.github.electron.framework \t0x0000000100ced9dd 0x100907000 + 4090333\r\n37 com.github.electron.framework \t0x0000000100cecad6 0x100907000 + 4086486\r\n38 com.github.electron.framework \t0x0000000100909747 AtomMain + 71\r\n39 com.unify.circuit \t0x00000001008fbf26 main + 38\r\n40 libdyld.dylib \t0x00007fffa66e9235 start + 1\r\n```" }, { "url": "https://api.github.com/repos/electron/electron/issues/9860", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9860/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9860/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9860/events", "html_url": "https://github.com/electron/electron/issues/9860", "id": 238525038, "number": 9860, "title": "Piclking a value suggested by a for an is not reflected by latters `value` property", "user": { "login": "amn", "id": 471489, "avatar_url": "https://avatars2.githubusercontent.com/u/471489?v=3", "gravatar_id": "", "url": "https://api.github.com/users/amn", "html_url": "https://github.com/amn", "followers_url": "https://api.github.com/users/amn/followers", "following_url": "https://api.github.com/users/amn/following{/other_user}", "gists_url": "https://api.github.com/users/amn/gists{/gist_id}", "starred_url": "https://api.github.com/users/amn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/amn/subscriptions", "organizations_url": "https://api.github.com/users/amn/orgs", "repos_url": "https://api.github.com/users/amn/repos", "events_url": "https://api.github.com/users/amn/events{/privacy}", "received_events_url": "https://api.github.com/users/amn/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T12:19:03Z", "updated_at": "2017-06-26T12:19:36Z", "closed_at": null, "body": "Electron version: 1.7.3 beta\r\nOperating system: Windows 7 x86_64 Professional\r\n\r\nClicking the pyramid icon on an input control associated with a data list and picking a value from the list, then evaluating `value` property of the input control, the value should be the text chosen from datalist which the input control is now showing.\r\n\r\nInstead, the text returned by `value` property is an empty string.\r\n\r\nOnly manual editing of value of the input control, as you would with an ordinary text input without a n associated datalist, causes the `value` property to yield the same text that the input control is showing.\r\n\r\nUsing following markup to reproduce by loading up default Electron distribution and typing `document.location = ...; /* path to file containing below text */` in Developer Tools console:\r\n\r\n\t\r\n\t\r\n\t\t\r\n\t\t\t\r\n\t\t\t\r\n\t\t\t\t\r\n\t\t\r\n\t" }, { "url": "https://api.github.com/repos/electron/electron/issues/9859", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9859/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9859/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9859/events", "html_url": "https://github.com/electron/electron/issues/9859", "id": 238504740, "number": 9859, "title": "can not load Tary ! Exception :conversion failure from ico2.png", "user": { "login": "xinhui-hui", "id": 7787811, "avatar_url": "https://avatars1.githubusercontent.com/u/7787811?v=3", "gravatar_id": "", "url": "https://api.github.com/users/xinhui-hui", "html_url": "https://github.com/xinhui-hui", "followers_url": "https://api.github.com/users/xinhui-hui/followers", "following_url": "https://api.github.com/users/xinhui-hui/following{/other_user}", "gists_url": "https://api.github.com/users/xinhui-hui/gists{/gist_id}", "starred_url": "https://api.github.com/users/xinhui-hui/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xinhui-hui/subscriptions", "organizations_url": "https://api.github.com/users/xinhui-hui/orgs", "repos_url": "https://api.github.com/users/xinhui-hui/repos", "events_url": "https://api.github.com/users/xinhui-hui/events{/privacy}", "received_events_url": "https://api.github.com/users/xinhui-hui/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-26T10:43:02Z", "updated_at": "2017-06-26T10:52:22Z", "closed_at": "2017-06-26T10:52:22Z", "body": "- Electron version: all\r\n- Operating system: windows10\r\n\r\n**Expected behavior**\r\n使用 \"npm start\" 启动能正确的加载到托盘图标，但是使用 “electron.exe path-to-your-app”这种方式不行,。\r\nuse \"npm start\" to start my app can load Tray Icon. but can not use \"electron.exe path-to-your-app\".\r\n\r\n\r\n`function createTray(){\r\n tray = new Tray(\"ico2.png\")\r\n const contextMenu = Menu.buildFromTemplate([\r\n {label: 'Item1', type: 'radio'},\r\n ])\r\n tray.setToolTip('Tray Test')\r\n tray.setContextMenu(contextMenu)\r\n}`\r\n\r\n#**How to reproduce**\r\n![qq 20170626183850](https://user-images.githubusercontent.com/7787811/27535815-d5f83d08-5a9e-11e7-805d-5dd190911bc5.png)\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9858", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9858/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9858/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9858/events", "html_url": "https://github.com/electron/electron/issues/9858", "id": 238500746, "number": 9858, "title": "In sanbox mode, BrowserWindow.reload() does not work", "user": { "login": "CptMaumau", "id": 5366008, "avatar_url": "https://avatars1.githubusercontent.com/u/5366008?v=3", "gravatar_id": "", "url": "https://api.github.com/users/CptMaumau", "html_url": "https://github.com/CptMaumau", "followers_url": "https://api.github.com/users/CptMaumau/followers", "following_url": "https://api.github.com/users/CptMaumau/following{/other_user}", "gists_url": "https://api.github.com/users/CptMaumau/gists{/gist_id}", "starred_url": "https://api.github.com/users/CptMaumau/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/CptMaumau/subscriptions", "organizations_url": "https://api.github.com/users/CptMaumau/orgs", "repos_url": "https://api.github.com/users/CptMaumau/repos", "events_url": "https://api.github.com/users/CptMaumau/events{/privacy}", "received_events_url": "https://api.github.com/users/CptMaumau/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T10:24:16Z", "updated_at": "2017-06-26T10:24:16Z", "closed_at": null, "body": "* Electron version: 1.6.11\r\n* Operating system: darwin x64\r\n\r\n### Expected behavior\r\n\r\nWhen I hit Cmd+R or click on the menu label, the main window reloads\r\n\r\n### Actual behavior\r\n\r\nThe window does not reload\r\n\r\n### How to reproduce\r\n\r\n```\r\nmainWindow = new BrowserWindow({\r\n webPreferences : {\r\n sandbox: true\r\n }\r\n })\r\n```\r\n\r\n```\r\nvar appMenu = Menu.buildFromTemplate([\r\n {\r\n label: \"View\",\r\n submenu: [\r\n { label: \"Reload this page\", accelerator: \"CmdOrCtrl+R\", selector: \"reload:\", click: function() { mainWindow.reload(); } }\r\n ]\r\n }\r\n])\r\n\r\n```\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9857", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9857/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9857/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9857/events", "html_url": "https://github.com/electron/electron/pull/9857", "id": 238484362, "number": 9857, "title": "[WIP] Add enable_osr flag", "user": { "login": "alexeykuzmin", "id": 607250, "avatar_url": "https://avatars0.githubusercontent.com/u/607250?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alexeykuzmin", "html_url": "https://github.com/alexeykuzmin", "followers_url": "https://api.github.com/users/alexeykuzmin/followers", "following_url": "https://api.github.com/users/alexeykuzmin/following{/other_user}", "gists_url": "https://api.github.com/users/alexeykuzmin/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexeykuzmin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexeykuzmin/subscriptions", "organizations_url": "https://api.github.com/users/alexeykuzmin/orgs", "repos_url": "https://api.github.com/users/alexeykuzmin/repos", "events_url": "https://api.github.com/users/alexeykuzmin/events{/privacy}", "received_events_url": "https://api.github.com/users/alexeykuzmin/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T09:16:12Z", "updated_at": "2017-06-26T09:16:12Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9857", "html_url": "https://github.com/electron/electron/pull/9857", "diff_url": "https://github.com/electron/electron/pull/9857.diff", "patch_url": "https://github.com/electron/electron/pull/9857.patch" }, "body": "It would be great to have an ability to turn certain features off for custom builds.\r\nIt could also help with upgrades to new Chromium versions.\r\n\r\n**Issue to address**:\r\nDisable the tests if the flag is turned off." }, { "url": "https://api.github.com/repos/electron/electron/issues/9856", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9856/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9856/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9856/events", "html_url": "https://github.com/electron/electron/pull/9856", "id": 238443192, "number": 9856, "title": "Remove grunt-build-atom-shell", "user": { "login": "paulcbetts", "id": 1396, "avatar_url": "https://avatars1.githubusercontent.com/u/1396?v=3", "gravatar_id": "", "url": "https://api.github.com/users/paulcbetts", "html_url": "https://github.com/paulcbetts", "followers_url": "https://api.github.com/users/paulcbetts/followers", "following_url": "https://api.github.com/users/paulcbetts/following{/other_user}", "gists_url": "https://api.github.com/users/paulcbetts/gists{/gist_id}", "starred_url": "https://api.github.com/users/paulcbetts/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paulcbetts/subscriptions", "organizations_url": "https://api.github.com/users/paulcbetts/orgs", "repos_url": "https://api.github.com/users/paulcbetts/repos", "events_url": "https://api.github.com/users/paulcbetts/events{/privacy}", "received_events_url": "https://api.github.com/users/paulcbetts/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-26T05:14:28Z", "updated_at": "2017-06-26T15:56:00Z", "closed_at": "2017-06-26T15:55:52Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9856", "html_url": "https://github.com/electron/electron/pull/9856", "diff_url": "https://github.com/electron/electron/pull/9856.diff", "patch_url": "https://github.com/electron/electron/pull/9856.patch" }, "body": "That thing is deprecated for _sure_" }, { "url": "https://api.github.com/repos/electron/electron/issues/9855", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9855/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9855/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9855/events", "html_url": "https://github.com/electron/electron/pull/9855", "id": 238442866, "number": 9855, "title": "Recommend electron-forge in auto-updater, fix some Windows stuffs", "user": { "login": "paulcbetts", "id": 1396, "avatar_url": "https://avatars1.githubusercontent.com/u/1396?v=3", "gravatar_id": "", "url": "https://api.github.com/users/paulcbetts", "html_url": "https://github.com/paulcbetts", "followers_url": "https://api.github.com/users/paulcbetts/followers", "following_url": "https://api.github.com/users/paulcbetts/following{/other_user}", "gists_url": "https://api.github.com/users/paulcbetts/gists{/gist_id}", "starred_url": "https://api.github.com/users/paulcbetts/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paulcbetts/subscriptions", "organizations_url": "https://api.github.com/users/paulcbetts/orgs", "repos_url": "https://api.github.com/users/paulcbetts/repos", "events_url": "https://api.github.com/users/paulcbetts/events{/privacy}", "received_events_url": "https://api.github.com/users/paulcbetts/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T05:10:53Z", "updated_at": "2017-06-26T05:10:53Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9855", "html_url": "https://github.com/electron/electron/pull/9855", "diff_url": "https://github.com/electron/electron/pull/9855.diff", "patch_url": "https://github.com/electron/electron/pull/9855.patch" }, "body": "We should point people to electron-forge, it's the modern way to package Electron apps" }, { "url": "https://api.github.com/repos/electron/electron/issues/9854", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9854/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9854/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9854/events", "html_url": "https://github.com/electron/electron/issues/9854", "id": 238431440, "number": 9854, "title": "Electron failed to build on Windows due to error LNK1120: 4 unresolved externals", "user": { "login": "KarenHuang2016", "id": 20896121, "avatar_url": "https://avatars3.githubusercontent.com/u/20896121?v=3", "gravatar_id": "", "url": "https://api.github.com/users/KarenHuang2016", "html_url": "https://github.com/KarenHuang2016", "followers_url": "https://api.github.com/users/KarenHuang2016/followers", "following_url": "https://api.github.com/users/KarenHuang2016/following{/other_user}", "gists_url": "https://api.github.com/users/KarenHuang2016/gists{/gist_id}", "starred_url": "https://api.github.com/users/KarenHuang2016/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KarenHuang2016/subscriptions", "organizations_url": "https://api.github.com/users/KarenHuang2016/orgs", "repos_url": "https://api.github.com/users/KarenHuang2016/repos", "events_url": "https://api.github.com/users/KarenHuang2016/events{/privacy}", "received_events_url": "https://api.github.com/users/KarenHuang2016/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": { "login": "alespergl", "id": 19880051, "avatar_url": "https://avatars2.githubusercontent.com/u/19880051?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alespergl", "html_url": "https://github.com/alespergl", "followers_url": "https://api.github.com/users/alespergl/followers", "following_url": "https://api.github.com/users/alespergl/following{/other_user}", "gists_url": "https://api.github.com/users/alespergl/gists{/gist_id}", "starred_url": "https://api.github.com/users/alespergl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alespergl/subscriptions", "organizations_url": "https://api.github.com/users/alespergl/orgs", "repos_url": "https://api.github.com/users/alespergl/repos", "events_url": "https://api.github.com/users/alespergl/events{/privacy}", "received_events_url": "https://api.github.com/users/alespergl/received_events", "type": "User", "site_admin": false }, "assignees": [ { "login": "alespergl", "id": 19880051, "avatar_url": "https://avatars2.githubusercontent.com/u/19880051?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alespergl", "html_url": "https://github.com/alespergl", "followers_url": "https://api.github.com/users/alespergl/followers", "following_url": "https://api.github.com/users/alespergl/following{/other_user}", "gists_url": "https://api.github.com/users/alespergl/gists{/gist_id}", "starred_url": "https://api.github.com/users/alespergl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alespergl/subscriptions", "organizations_url": "https://api.github.com/users/alespergl/orgs", "repos_url": "https://api.github.com/users/alespergl/repos", "events_url": "https://api.github.com/users/alespergl/events{/privacy}", "received_events_url": "https://api.github.com/users/alespergl/received_events", "type": "User", "site_admin": false } ], "milestone": null, "comments": 2, "created_at": "2017-06-26T03:06:55Z", "updated_at": "2017-06-26T22:44:25Z", "closed_at": "2017-06-26T22:44:25Z", "body": "Electron failed to build (master branch latest source code) on Windows Server 2012 R2 with VS2015 Update 3. This issue can be repro from master branch revision [873a315 ](https://github.com/electron/electron/commit/873a315538ae4da500bf73cbad60924d7d658d96). Could you please take a look at this? Thanks in advance!\r\n\r\n**How to reproduce:**\r\n1. git clone https://github.com/electron/electron.git D:\\Electron\\src\r\n2. Open a clean command prompt and browse to D:\\Electron\r\n3. python script\\bootstrap.py -v --target_arch=ia32\r\n4. vendor\\depot_tools\\ninja.exe -C out\\R electron -v -d keeprsp\r\n\r\n**Acutal result:**\r\n\r\n[electron_x86_build.txt](https://github.com/electron/electron/files/1100941/electron_x86_build.txt)\r\n\r\n
\r\n```\r\n[1170/1190] C:\\tools\\Python2\\python.exe gyp-win-tool link-with-manifests environment.x86 True node.dll \"C:\\tools\\Python2\\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:node.dll.lib /DLL /OUT:node.dll @node.dll.rsp\" 2 mt.exe rc.exe \"obj\\vendor\\node\\node.node.dll.intermediate.manifest\" obj\\vendor\\node\\node.node.dll.generated.manifest\r\nFAILED: C:\\tools\\Python2\\python.exe gyp-win-tool link-with-manifests environment.x86 True node.dll \"C:\\tools\\Python2\\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:node.dll.lib /DLL /OUT:node.dll @node.dll.rsp\" 2 mt.exe rc.exe \"obj\\vendor\\node\\node.node.dll.intermediate.manifest\" obj\\vendor\\node\\node.node.dll.generated.manifest\r\nv8.lib(concurrent-marking.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: int __thiscall std::basic_streambuf >::snextc(void)\" (?snextc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QAEHXZ) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: virtual __thiscall std::basic_ios >::~basic_ios >(void)\" (??1?$basic_ios@DU?$char_traits@D@std@@@std@@UAE@XZ) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: void __thiscall std::basic_ios >::setstate(int,bool)\" (?setstate@?$basic_ios@DU?$char_traits@D@std@@@std@@QAEXH_N@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"protected: __thiscall std::basic_ios >::basic_ios >(void)\" (??0?$basic_ios@DU?$char_traits@D@std@@@std@@IAE@XZ) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: void __thiscall std::basic_ios >::clear(int,bool)\" (?clear@?$basic_ios@DU?$char_traits@D@std@@@std@@QAEXH_N@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: __thiscall std::basic_ostream >::basic_ostream >(class std::basic_streambuf > *,bool)\" (??0?$basic_ostream@DU?$char_traits@D@std@@@std@@QAE@PAV?$basic_streambuf@DU?$char_traits@D@std@@@1@_N@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: virtual __thiscall std::basic_ostream >::~basic_ostream >(void)\" (??1?$basic_ostream@DU?$char_traits@D@std@@@std@@UAE@XZ) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: void __thiscall std::basic_ostream >::_Osfx(void)\" (?_Osfx@?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEXXZ) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(int)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@H@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::flush(void)\" (?flush@?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV12@XZ) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(class std::ios_base & (__cdecl*)(class std::ios_base &))\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@P6AAAVios_base@1@AAV21@@Z@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(__int64)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@_J@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(unsigned __int64)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@_K@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(double)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@N@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(void const *)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@PBX@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(unsigned int)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@I@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(long)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@J@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(unsigned long)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@K@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(float)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@M@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: char __thiscall std::basic_ios >::widen(char)const \" (?widen@?$basic_ios@DU?$char_traits@D@std@@@std@@QBEDD@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(class std::basic_ostream > & (__cdecl*)(class std::basic_ostream > &))\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@P6AAAV01@AAV01@@Z@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::put(char)\" (?put@?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV12@D@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_streambuf > * __thiscall std::basic_ios >::rdbuf(class std::basic_streambuf > *)\" (?rdbuf@?$basic_ios@DU?$char_traits@D@std@@@std@@QAEPAV?$basic_streambuf@DU?$char_traits@D@std@@@2@PAV32@@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::write(char const *,__int64)\" (?write@?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV12@PBD_J@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: __thiscall std::basic_ios >::basic_ios >(class std::basic_streambuf > *)\" (??0?$basic_ios@DU?$char_traits@D@std@@@std@@QAE@PAV?$basic_streambuf@DU?$char_traits@D@std@@@1@@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ios > & __thiscall std::basic_ios >::copyfmt(class std::basic_ios > const &)\" (?copyfmt@?$basic_ios@DU?$char_traits@D@std@@@std@@QAEAAV12@ABV12@@Z) already defined in v8.lib(concurrent-marking.obj)\r\nmsvcprt.lib(MSVCP140.dll) : error LNK2005: \"public: class std::basic_ostream > & __thiscall std::basic_ostream >::operator<<(bool)\" (??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QAEAAV01@_N@Z) already defined in v8.lib(concurrent-marking.obj)\r\nlibcpmt.lib(raisehan.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(ios.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(ios.obj) : error LNK2005: \"public: static void __cdecl std::ios_base::_Addstd(class std::ios_base *)\" (?_Addstd@ios_base@std@@SAXPAV12@@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(ios.obj) : error LNK2005: \"private: static void __cdecl std::ios_base::_Ios_base_dtor(class std::ios_base *)\" (?_Ios_base_dtor@ios_base@std@@CAXPAV12@@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale0.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(locale0.obj) : error LNK2005: \"void __cdecl std::_Facet_Register(class std::_Facet_base *)\" (?_Facet_Register@std@@YAXPAV_Facet_base@1@@Z) already defined in msvcprt.lib(locale0_implib.obj)\r\nlibcpmt.lib(locale0.obj) : error LNK2005: \"private: static class std::locale::_Locimp * __cdecl std::locale::_Getgloballocale(void)\" (?_Getgloballocale@locale@std@@CAPAV_Locimp@12@XZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale0.obj) : error LNK2005: \"private: static class std::locale::_Locimp * __cdecl std::locale::_Init(bool)\" (?_Init@locale@std@@CAPAV_Locimp@12@_N@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale0.obj) : error LNK2005: \"public: static void __cdecl std::_Locinfo::_Locinfo_ctor(class std::_Locinfo *,char const *)\" (?_Locinfo_ctor@_Locinfo@std@@SAXPAV12@PBD@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale0.obj) : error LNK2005: \"public: static void __cdecl std::_Locinfo::_Locinfo_dtor(class std::_Locinfo *)\" (?_Locinfo_dtor@_Locinfo@std@@SAXPAV12@@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(iosptrs.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(locale.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(locale.obj) : error LNK2005: \"public: __thiscall std::locale::id::operator unsigned int(void)\" (??Bid@locale@std@@QAEIXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale.obj) : error LNK2005: \"public: static unsigned int __cdecl std::codecvt::_Getcat(class std::locale::facet const * *,class std::locale const *)\" (?_Getcat@?$codecvt@DDU_Mbstatet@@@std@@SAIPAPBVfacet@locale@2@PBV42@@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale.obj) : error LNK2005: \"protected: char * __thiscall std::basic_streambuf >::_Gninc(void)\" (?_Gninc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@IAEPADXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale.obj) : error LNK2005: \"protected: char * __thiscall std::basic_streambuf >::_Pninc(void)\" (?_Pninc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@IAEPADXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale.obj) : error LNK2005: \"public: int __thiscall std::basic_streambuf >::sbumpc(void)\" (?sbumpc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QAEHXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale.obj) : error LNK2005: \"public: int __thiscall std::basic_streambuf >::sgetc(void)\" (?sgetc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QAEHXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(locale.obj) : error LNK2005: \"public: int __thiscall std::basic_streambuf >::sputc(char)\" (?sputc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QAEHD@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xlock.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(xlock.obj) : error LNK2005: \"public: __thiscall std::_Lockit::_Lockit(int)\" (??0_Lockit@std@@QAE@H@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xlock.obj) : error LNK2005: \"public: __thiscall std::_Lockit::~_Lockit(void)\" (??1_Lockit@std@@QAE@XZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xthrow.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(xthrow.obj) : error LNK2005: \"void __cdecl std::_Xbad_alloc(void)\" (?_Xbad_alloc@std@@YAXXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xthrow.obj) : error LNK2005: \"void __cdecl std::_Xbad_function_call(void)\" (?_Xbad_function_call@std@@YAXXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xthrow.obj) : error LNK2005: \"void __cdecl std::_Xlength_error(char const *)\" (?_Xlength_error@std@@YAXPBD@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xthrow.obj) : error LNK2005: \"void __cdecl std::_Xout_of_range(char const *)\" (?_Xout_of_range@std@@YAXPBD@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(wlocale.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(wlocale.obj) : error LNK2005: \"public: __thiscall std::locale::id::operator unsigned int(void)\" (??Bid@locale@std@@QAEIXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xlocale.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(xlocale.obj) : error LNK2005: \"public: __thiscall std::locale::id::operator unsigned int(void)\" (??Bid@locale@std@@QAEIXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xlocale.obj) : error LNK2005: \"protected: char * __thiscall std::basic_streambuf >::_Gninc(void)\" (?_Gninc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@IAEPADXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xlocale.obj) : error LNK2005: \"protected: char * __thiscall std::basic_streambuf >::_Pninc(void)\" (?_Pninc@?$basic_streambuf@DU?char_traits@D@std@@@std@@IAEPADXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xlocale.obj) : error LNK2005: \"public: int __thiscall std::basic_streambuf >::sbumpc(void)\" (?sbumpc@?$basic_streambuf@DU?char_traits@D@std@@@std@@QAEHXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xlocale.obj) : error LNK2005: \"public: int __thiscall std::basic_streambuf >::sgetc(void)\" (?sgetc@?$basic_streambuf@DU?char_traits@D@std@@@std@@QAEHXZ) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xlocale.obj) : error LNK2005: \"public: int __thiscall std::basic_streambuf >::sputc(char)\" (?sputc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QAEHD@Z) already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(xdateord.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(xwctomb.obj) : error LNK2005: __Getcvt already defined in msvcprt.lib(MSVCP140.dll)\r\nlibcpmt.lib(winapisupp.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(StlCompareStringA.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(winapinls.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(StlCompareStringW.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(StlLCMapStringW.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nlibcpmt.lib(StlLCMapStringA.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in node.agent.obj\r\nLINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; use /NODEFAULTLIB:library\r\nv8.lib(concurrent-marking.obj) : error LNK2001: unresolved external symbol \"public: virtual class v8::Maybe __thiscall v8::ValueSerializer::Delegate::GetWasmModuleTransferId(class v8::Isolate *,class v8::Local)\" (?GetWasmModuleTransferId@Delegate@ValueSerializer@v8@@UAE?AV?$Maybe@I@3@PAVIsolate@3@V?$Local@VWasmCompiledModule@v8@@@3@@Z)\r\nv8.lib(concurrent-marking.obj) : error LNK2001: unresolved external symbol \"public: virtual class v8::MaybeLocal __thiscall v8::ValueDeserializer::Delegate::GetWasmModuleFromId(class v8::Isolate *,unsigned int)\" (?GetWasmModuleFromId@Delegate@ValueDeserializer@v8@@UAE?AV?$MaybeLocal@VWasmCompiledModule@v8@@@3@PAVIsolate@3@I@Z)\r\nv8.lib(concurrent-marking.obj) : error LNK2001: unresolved external symbol \"bool v8::internal::FLAG_concurrent_marking\" (?FLAG_concurrent_marking@internal@v8@@3_NA)\r\nv8.lib(concurrent-marking.obj) : error LNK2001: unresolved external symbol \"bool v8::internal::FLAG_trace_concurrent_marking\" (?FLAG_trace_concurrent_marking@internal@v8@@3_NA)\r\nnode.dll : fatal error LNK1120: 4 unresolved externals\r\n```\r\n
" }, { "url": "https://api.github.com/repos/electron/electron/issues/9853", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9853/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9853/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9853/events", "html_url": "https://github.com/electron/electron/pull/9853", "id": 238418309, "number": 9853, "title": "recommend before-input-event in keyboard shortcuts tutorial", "user": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-26T00:37:57Z", "updated_at": "2017-06-26T16:38:57Z", "closed_at": "2017-06-26T16:38:55Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9853", "html_url": "https://github.com/electron/electron/pull/9853", "diff_url": "https://github.com/electron/electron/pull/9853.diff", "patch_url": "https://github.com/electron/electron/pull/9853.patch" }, "body": "A small bit of documentation from https://github.com/electron/electron/issues/7737#issuecomment-310920444\r\n\r\ncc @poiru " }, { "url": "https://api.github.com/repos/electron/electron/issues/9852", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9852/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9852/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9852/events", "html_url": "https://github.com/electron/electron/pull/9852", "id": 238399282, "number": 9852, "title": "Add webContents.setIgnoreMenuShortcuts()", "user": { "login": "poiru", "id": 1319028, "avatar_url": "https://avatars1.githubusercontent.com/u/1319028?v=3", "gravatar_id": "", "url": "https://api.github.com/users/poiru", "html_url": "https://github.com/poiru", "followers_url": "https://api.github.com/users/poiru/followers", "following_url": "https://api.github.com/users/poiru/following{/other_user}", "gists_url": "https://api.github.com/users/poiru/gists{/gist_id}", "starred_url": "https://api.github.com/users/poiru/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poiru/subscriptions", "organizations_url": "https://api.github.com/users/poiru/orgs", "repos_url": "https://api.github.com/users/poiru/repos", "events_url": "https://api.github.com/users/poiru/events{/privacy}", "received_events_url": "https://api.github.com/users/poiru/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 1, "created_at": "2017-06-25T19:06:01Z", "updated_at": "2017-06-26T21:01:36Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9852", "html_url": "https://github.com/electron/electron/pull/9852", "diff_url": "https://github.com/electron/electron/pull/9852.diff", "patch_url": "https://github.com/electron/electron/pull/9852.patch" }, "body": "This allows you to disable application menu shortcut handling on a per\r\nweb contents basis." }, { "url": "https://api.github.com/repos/electron/electron/issues/9851", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9851/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9851/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9851/events", "html_url": "https://github.com/electron/electron/issues/9851", "id": 238398335, "number": 9851, "title": "Accelerators for invisible menu items should not fire on Windows", "user": { "login": "poiru", "id": 1319028, "avatar_url": "https://avatars1.githubusercontent.com/u/1319028?v=3", "gravatar_id": "", "url": "https://api.github.com/users/poiru", "html_url": "https://github.com/poiru", "followers_url": "https://api.github.com/users/poiru/followers", "following_url": "https://api.github.com/users/poiru/following{/other_user}", "gists_url": "https://api.github.com/users/poiru/gists{/gist_id}", "starred_url": "https://api.github.com/users/poiru/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poiru/subscriptions", "organizations_url": "https://api.github.com/users/poiru/orgs", "repos_url": "https://api.github.com/users/poiru/repos", "events_url": "https://api.github.com/users/poiru/events{/privacy}", "received_events_url": "https://api.github.com/users/poiru/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 196983813, "url": "https://api.github.com/repos/electron/electron/labels/component/menu", "name": "component/menu", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false }, { "id": 193723598, "url": "https://api.github.com/repos/electron/electron/labels/help/beginner", "name": "help/beginner", "color": "5319e7", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-25T18:50:13Z", "updated_at": "2017-06-25T18:50:13Z", "closed_at": null, "body": "See https://github.com/electron/electron/issues/7737#issuecomment-257750474" }, { "url": "https://api.github.com/repos/electron/electron/issues/9850", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9850/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9850/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9850/events", "html_url": "https://github.com/electron/electron/pull/9850", "id": 238396101, "number": 9850, "title": "Fix restricting zooming with webFrame.setVisualZoomLevelLimits()", "user": { "login": "poiru", "id": 1319028, "avatar_url": "https://avatars1.githubusercontent.com/u/1319028?v=3", "gravatar_id": "", "url": "https://api.github.com/users/poiru", "html_url": "https://github.com/poiru", "followers_url": "https://api.github.com/users/poiru/followers", "following_url": "https://api.github.com/users/poiru/following{/other_user}", "gists_url": "https://api.github.com/users/poiru/gists{/gist_id}", "starred_url": "https://api.github.com/users/poiru/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poiru/subscriptions", "organizations_url": "https://api.github.com/users/poiru/orgs", "repos_url": "https://api.github.com/users/poiru/repos", "events_url": "https://api.github.com/users/poiru/events{/privacy}", "received_events_url": "https://api.github.com/users/poiru/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-25T18:08:46Z", "updated_at": "2017-06-26T17:45:05Z", "closed_at": "2017-06-26T17:45:02Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9850", "html_url": "https://github.com/electron/electron/pull/9850", "diff_url": "https://github.com/electron/electron/pull/9850.diff", "patch_url": "https://github.com/electron/electron/pull/9850.patch" }, "body": "Fixes #8793." }, { "url": "https://api.github.com/repos/electron/electron/issues/9849", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9849/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9849/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9849/events", "html_url": "https://github.com/electron/electron/issues/9849", "id": 238369902, "number": 9849, "title": "When network is disconnected while downloading a big file, net.request just hangs and no event is fired", "user": { "login": "amircodota", "id": 25413470, "avatar_url": "https://avatars3.githubusercontent.com/u/25413470?v=3", "gravatar_id": "", "url": "https://api.github.com/users/amircodota", "html_url": "https://github.com/amircodota", "followers_url": "https://api.github.com/users/amircodota/followers", "following_url": "https://api.github.com/users/amircodota/following{/other_user}", "gists_url": "https://api.github.com/users/amircodota/gists{/gist_id}", "starred_url": "https://api.github.com/users/amircodota/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/amircodota/subscriptions", "organizations_url": "https://api.github.com/users/amircodota/orgs", "repos_url": "https://api.github.com/users/amircodota/repos", "events_url": "https://api.github.com/users/amircodota/events{/privacy}", "received_events_url": "https://api.github.com/users/amircodota/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-25T09:19:50Z", "updated_at": "2017-06-25T09:19:50Z", "closed_at": null, "body": "Here's an example code\r\n\r\n```javascript \r\nfunction downloadTest() {\r\n let url = 'https://s3.amazonaws.com/codota-assistant-releases/linux/x64/Codota_0.4.4_amd64.deb';\r\n\r\n const request = net.request(url);\r\n request.on('response', response => {\r\n response.on('data', data => {\r\n console.log(`!!! DEBUG !!!! response data ${data.length}`);\r\n });\r\n\r\n response.on('aborted', () => {\r\n console.log(\"!!!! DEBUG !!! response aborted\");\r\n });\r\n\r\n response.on('end', () => {\r\n console.log(\"!!!! DEBUG !!! response ended\");\r\n });\r\n\r\n response.on('error', err => {\r\n console.log(\"!!!! DEBUG !!! response error \" + err);\r\n });\r\n });\r\n\r\n request.on('abort', () => {\r\n console.log('request aborted');\r\n });\r\n\r\n request.on('close', () => {\r\n console.log('request closed');\r\n });\r\n\r\n request.on('finish', () => {\r\n console.log('request finished');\r\n });\r\n\r\n request.end(err => {\r\n console.log('!!!! DEBUG !!!! request end ' + err);\r\n });\r\n}\r\n```\r\n\r\nWhen running it I see a lot of prints like this \r\n\r\n```\r\n!!! DEBUG !!!! response data 4096\r\n!!! DEBUG !!!! response data 2048\r\n!!! DEBUG !!!! response data 4096\r\n!!! DEBUG !!!! response data 4096\r\n!!! DEBUG !!!! response data 4096\r\n!!! DEBUG !!!! response data 4072\r\n!!! DEBUG !!!! response data 1048\r\n```\r\n\r\nThen I disable the wifi and it is silent. No event is fired to indicate an error/abort.\r\n\r\nAny advice on this would be much appreicated.\r\n\r\nThanks\r\nAmir" }, { "url": "https://api.github.com/repos/electron/electron/issues/9848", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9848/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9848/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9848/events", "html_url": "https://github.com/electron/electron/pull/9848", "id": 238369187, "number": 9848, "title": "Promisify getZoomFactor() and getZoomLevel()", "user": { "login": "liusy182", "id": 3293332, "avatar_url": "https://avatars3.githubusercontent.com/u/3293332?v=3", "gravatar_id": "", "url": "https://api.github.com/users/liusy182", "html_url": "https://github.com/liusy182", "followers_url": "https://api.github.com/users/liusy182/followers", "following_url": "https://api.github.com/users/liusy182/following{/other_user}", "gists_url": "https://api.github.com/users/liusy182/gists{/gist_id}", "starred_url": "https://api.github.com/users/liusy182/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/liusy182/subscriptions", "organizations_url": "https://api.github.com/users/liusy182/orgs", "repos_url": "https://api.github.com/users/liusy182/repos", "events_url": "https://api.github.com/users/liusy182/events{/privacy}", "received_events_url": "https://api.github.com/users/liusy182/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-25T09:02:19Z", "updated_at": "2017-06-25T16:07:59Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9848", "html_url": "https://github.com/electron/electron/pull/9848", "diff_url": "https://github.com/electron/electron/pull/9848.diff", "patch_url": "https://github.com/electron/electron/pull/9848.patch" }, "body": "#9697 \r\n\r\nPromisify `getZoomFactor()` and `getZoomLevel()` APIs" }, { "url": "https://api.github.com/repos/electron/electron/issues/9847", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9847/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9847/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9847/events", "html_url": "https://github.com/electron/electron/pull/9847", "id": 238368451, "number": 9847, "title": "Fixes electron/electron-typescript-definitions/issues/63", "user": { "login": "timfish", "id": 1150298, "avatar_url": "https://avatars1.githubusercontent.com/u/1150298?v=3", "gravatar_id": "", "url": "https://api.github.com/users/timfish", "html_url": "https://github.com/timfish", "followers_url": "https://api.github.com/users/timfish/followers", "following_url": "https://api.github.com/users/timfish/following{/other_user}", "gists_url": "https://api.github.com/users/timfish/gists{/gist_id}", "starred_url": "https://api.github.com/users/timfish/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/timfish/subscriptions", "organizations_url": "https://api.github.com/users/timfish/orgs", "repos_url": "https://api.github.com/users/timfish/repos", "events_url": "https://api.github.com/users/timfish/events{/privacy}", "received_events_url": "https://api.github.com/users/timfish/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-25T08:44:02Z", "updated_at": "2017-06-26T15:50:50Z", "closed_at": "2017-06-26T15:50:50Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9847", "html_url": "https://github.com/electron/electron/pull/9847", "diff_url": "https://github.com/electron/electron/pull/9847.diff", "patch_url": "https://github.com/electron/electron/pull/9847.patch" }, "body": "Fixes electron/electron-typescript-definitions/issues/63" }, { "url": "https://api.github.com/repos/electron/electron/issues/9846", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9846/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9846/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9846/events", "html_url": "https://github.com/electron/electron/issues/9846", "id": 238368309, "number": 9846, "title": "electron work with displayswitch", "user": { "login": "keyiis", "id": 7766085, "avatar_url": "https://avatars2.githubusercontent.com/u/7766085?v=3", "gravatar_id": "", "url": "https://api.github.com/users/keyiis", "html_url": "https://github.com/keyiis", "followers_url": "https://api.github.com/users/keyiis/followers", "following_url": "https://api.github.com/users/keyiis/following{/other_user}", "gists_url": "https://api.github.com/users/keyiis/gists{/gist_id}", "starred_url": "https://api.github.com/users/keyiis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/keyiis/subscriptions", "organizations_url": "https://api.github.com/users/keyiis/orgs", "repos_url": "https://api.github.com/users/keyiis/repos", "events_url": "https://api.github.com/users/keyiis/events{/privacy}", "received_events_url": "https://api.github.com/users/keyiis/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-25T08:40:33Z", "updated_at": "2017-06-25T08:41:08Z", "closed_at": null, "body": "* Electron version:1.6.5\r\n* Operating system:win10 x64\r\n\r\n### Expected behavior\r\n\r\n\r\n\r\nI opened two BrowserWindow in main process,I want the second BrowserWindow display to second monitor automatically,I can open extend monitor by `DisplaySwitch.exe /extend`,but how to send the second BrowserWindow to second monitor by code?\r\n![qq 20170625163908](https://user-images.githubusercontent.com/7766085/27514704-fe003ad8-59c4-11e7-82e7-f050507013b7.png)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9845", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9845/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9845/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9845/events", "html_url": "https://github.com/electron/electron/issues/9845", "id": 238367923, "number": 9845, "title": "capturePage doesnt capture images larger then screen size", "user": { "login": "ronalb", "id": 27764488, "avatar_url": "https://avatars1.githubusercontent.com/u/27764488?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ronalb", "html_url": "https://github.com/ronalb", "followers_url": "https://api.github.com/users/ronalb/followers", "following_url": "https://api.github.com/users/ronalb/following{/other_user}", "gists_url": "https://api.github.com/users/ronalb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ronalb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ronalb/subscriptions", "organizations_url": "https://api.github.com/users/ronalb/orgs", "repos_url": "https://api.github.com/users/ronalb/repos", "events_url": "https://api.github.com/users/ronalb/events{/privacy}", "received_events_url": "https://api.github.com/users/ronalb/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-25T08:30:39Z", "updated_at": "2017-06-25T08:30:39Z", "closed_at": null, "body": "\r\n\r\n* Electron version:\r\n1.6.11\r\n* Operating system:\r\nwindows 10\r\n\r\n### Expected behavior\r\nI created an svg larger then my screen size and i'm trying \r\nto capturePage . the largest png i can get is the my screen size.\r\ni tried with rect and without rect\r\n\r\n\r\nI think if i can make a large web page I should be able to capture it.\r\n\r\n### Actual behavior\r\n\r\n\r\n\r\n### How to reproduce\r\ncreate a page larger then your screen size,and then try to capturePage\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9844", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9844/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9844/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9844/events", "html_url": "https://github.com/electron/electron/issues/9844", "id": 238360413, "number": 9844, "title": "Crashed when launchint by daemon", "user": { "login": "uudiin", "id": 4622009, "avatar_url": "https://avatars3.githubusercontent.com/u/4622009?v=3", "gravatar_id": "", "url": "https://api.github.com/users/uudiin", "html_url": "https://github.com/uudiin", "followers_url": "https://api.github.com/users/uudiin/followers", "following_url": "https://api.github.com/users/uudiin/following{/other_user}", "gists_url": "https://api.github.com/users/uudiin/gists{/gist_id}", "starred_url": "https://api.github.com/users/uudiin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/uudiin/subscriptions", "organizations_url": "https://api.github.com/users/uudiin/orgs", "repos_url": "https://api.github.com/users/uudiin/repos", "events_url": "https://api.github.com/users/uudiin/events{/privacy}", "received_events_url": "https://api.github.com/users/uudiin/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-25T05:07:24Z", "updated_at": "2017-06-25T06:28:07Z", "closed_at": "2017-06-25T06:28:07Z", "body": "It is crashed When I launch electron.exe by CreateProcessAsUser in service. Though it works normal when launching it by double click.\r\n\r\nThe error:\r\n\r\n> Uncaught Exception:\r\n> Error: Failed to get 'appData' path\r\n> at Object. (C:\\app\\resources\\electron.asar\\browser\\init.js:149:39)\r\n> ... ...\r\n\r\n\r\nthe main code:\r\n\r\n`\r\n\r\n if ((sid = WTSGetActiveConsoleSessionId()) == 0xffffffff)\r\n return str_error(L, 0);\r\n if (!WTSQueryUserToken(sid, &token))\r\n return str_error(L, 0);\r\n\r\n memset(&pi, 0, sizeof(pi));\r\n memset(&sui, 0, sizeof(sui));\r\n sui.cb = sizeof(sui);\r\n ret = CreateProcessAsUserA(token, NULL, (char *)binpath, NULL, NULL, FALSE,\r\n 0, NULL, NULL, &sui, &pi);\r\n CloseHandle(token);\r\n`\r\n\r\n\r\n\r\nelectron: 1.6.11\r\nOS: win7 7601 x64" }, { "url": "https://api.github.com/repos/electron/electron/issues/9843", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9843/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9843/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9843/events", "html_url": "https://github.com/electron/electron/issues/9843", "id": 238330406, "number": 9843, "title": "Override menu buttons", "user": { "login": "Gunnthorian", "id": 7622949, "avatar_url": "https://avatars3.githubusercontent.com/u/7622949?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Gunnthorian", "html_url": "https://github.com/Gunnthorian", "followers_url": "https://api.github.com/users/Gunnthorian/followers", "following_url": "https://api.github.com/users/Gunnthorian/following{/other_user}", "gists_url": "https://api.github.com/users/Gunnthorian/gists{/gist_id}", "starred_url": "https://api.github.com/users/Gunnthorian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Gunnthorian/subscriptions", "organizations_url": "https://api.github.com/users/Gunnthorian/orgs", "repos_url": "https://api.github.com/users/Gunnthorian/repos", "events_url": "https://api.github.com/users/Gunnthorian/events{/privacy}", "received_events_url": "https://api.github.com/users/Gunnthorian/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-24T17:24:47Z", "updated_at": "2017-06-24T17:24:47Z", "closed_at": null, "body": "\r\n\r\n### Versions:\r\n\r\n* Electron version: 1.4.13\r\n* Operating system: OSX 10.12.5\r\n\r\nUsing a frameless window with a hidden titlebarstyle has made the window and its menu buttons function and look just as they were intended, however, I need the Maximize button to perform my own function and not the default. The maximize button has setFullScreenable false so it looks like the original \"+\" and won't try and put my app in fullscreen, great! Now Im trying to stop if from attempting to set the app to what it thinks maximize should be.\r\n\r\n### Current\r\n\r\n` mainWindow.on('maximize', function (event) {`\r\n    `event.preventDefault()`\r\n    ` mainWindow.setSize(`\r\n        ` 600,`\r\n        ` 800`\r\n    ` )`\r\n` })`\r\n\r\nHowever, the `event.preventDefault()` doesn't work, or maybe Im doing it wrong.\r\n\r\n### Suggestion\r\n\r\nIn the end I would like for app to toggle between two, three, or four different sizes. This would all be achievable if there was a way to do:\r\n\r\n`mainWindow = new BrowserWindow({`\r\n    ` width: 300,`\r\n    ` height: 400,`\r\n    ` frame: false,`\r\n    ` titleBarStyle: 'hidden',`\r\n    ` insteadOfMaximizeRun: thisFunction(),`\r\n    ` insteadOfMinimizeRun: thatFunction(),`\r\n` })`\r\n\r\n### Suggested behavior\r\n\r\n\r\n\r\nClicking the button should run the function that you specified\r\n\r\n### Actual behavior\r\n\r\n\r\n\r\nwindow gets thrown around the screen and when you move the window in its 'maximized' state (for my app its only 600x800, so it hardly fills the screen) and try and maximize or minimize it again it breaks and you need to relaunch.\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9842", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9842/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9842/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9842/events", "html_url": "https://github.com/electron/electron/issues/9842", "id": 238321084, "number": 9842, "title": "Force integrated GPU", "user": { "login": "sindresorhus", "id": 170270, "avatar_url": "https://avatars2.githubusercontent.com/u/170270?v=3", "gravatar_id": "", "url": "https://api.github.com/users/sindresorhus", "html_url": "https://github.com/sindresorhus", "followers_url": "https://api.github.com/users/sindresorhus/followers", "following_url": "https://api.github.com/users/sindresorhus/following{/other_user}", "gists_url": "https://api.github.com/users/sindresorhus/gists{/gist_id}", "starred_url": "https://api.github.com/users/sindresorhus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sindresorhus/subscriptions", "organizations_url": "https://api.github.com/users/sindresorhus/orgs", "repos_url": "https://api.github.com/users/sindresorhus/repos", "events_url": "https://api.github.com/users/sindresorhus/events{/privacy}", "received_events_url": "https://api.github.com/users/sindresorhus/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-24T14:40:46Z", "updated_at": "2017-06-25T03:33:59Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.7.3\r\n* Operating system: macOS 10.12.5\r\n\r\n### Problem\r\n\r\n[My app](https://github.com/sindresorhus/caprine) uses the discrete GPU constantly which has a negative impact on battery life (https://github.com/sindresorhus/caprine/issues/238). I would like to be able to force my app to only use the integrated GPU if available. Chrome has a flag for this: `--force_discrete_gpu=0`. This is different from the `app.disableHardwareAcceleration()` method as I don't want to disable hardware acceleration, just use the more power efficient GPU.\r\n\r\n### Solution\r\n\r\nSupport it with `app.commandLine.appendSwitch()` or as a separate method `app.forceIntegratedGPU()`. " }, { "url": "https://api.github.com/repos/electron/electron/issues/9841", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9841/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9841/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9841/events", "html_url": "https://github.com/electron/electron/pull/9841", "id": 238312006, "number": 9841, "title": "[Triggering builds] Notification actions refactor", "user": { "login": "MarshallOfSound", "id": 6634592, "avatar_url": "https://avatars0.githubusercontent.com/u/6634592?v=3", "gravatar_id": "", "url": "https://api.github.com/users/MarshallOfSound", "html_url": "https://github.com/MarshallOfSound", "followers_url": "https://api.github.com/users/MarshallOfSound/followers", "following_url": "https://api.github.com/users/MarshallOfSound/following{/other_user}", "gists_url": "https://api.github.com/users/MarshallOfSound/gists{/gist_id}", "starred_url": "https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MarshallOfSound/subscriptions", "organizations_url": "https://api.github.com/users/MarshallOfSound/orgs", "repos_url": "https://api.github.com/users/MarshallOfSound/repos", "events_url": "https://api.github.com/users/MarshallOfSound/events{/privacy}", "received_events_url": "https://api.github.com/users/MarshallOfSound/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-24T11:25:26Z", "updated_at": "2017-06-24T11:58:02Z", "closed_at": "2017-06-24T11:57:56Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9841", "html_url": "https://github.com/electron/electron/pull/9841", "diff_url": "https://github.com/electron/electron/pull/9841.diff", "patch_url": "https://github.com/electron/electron/pull/9841.patch" }, "body": "" }, { "url": "https://api.github.com/repos/electron/electron/issues/9840", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9840/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9840/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9840/events", "html_url": "https://github.com/electron/electron/issues/9840", "id": 238267041, "number": 9840, "title": "DataTransfer.files not available before drop event (when using file protocol)", "user": { "login": "inukshuk", "id": 325102, "avatar_url": "https://avatars1.githubusercontent.com/u/325102?v=3", "gravatar_id": "", "url": "https://api.github.com/users/inukshuk", "html_url": "https://github.com/inukshuk", "followers_url": "https://api.github.com/users/inukshuk/followers", "following_url": "https://api.github.com/users/inukshuk/following{/other_user}", "gists_url": "https://api.github.com/users/inukshuk/gists{/gist_id}", "starred_url": "https://api.github.com/users/inukshuk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/inukshuk/subscriptions", "organizations_url": "https://api.github.com/users/inukshuk/orgs", "repos_url": "https://api.github.com/users/inukshuk/repos", "events_url": "https://api.github.com/users/inukshuk/events{/privacy}", "received_events_url": "https://api.github.com/users/inukshuk/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-23T22:23:23Z", "updated_at": "2017-06-23T22:23:23Z", "closed_at": null, "body": "\r\n* Electron version: 1.7.3\r\n* Operating system: Linux and macOS\r\n\r\n### Expected behavior\r\n\r\nWhen using the file protocol `event.dataTransfer.files` was available to drag events even before the drop event (at least up to Electron 1.6.11) (see related discussion #8720) -- in Electron 1.7.3 the file list is always empty.\r\n\r\n### Actual behavior\r\n\r\nFiles are not available.\r\n\r\n### How to reproduce\r\n\r\nRegister `dragover` or `dragenter` and drag files over the application." }, { "url": "https://api.github.com/repos/electron/electron/issues/9839", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9839/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9839/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9839/events", "html_url": "https://github.com/electron/electron/issues/9839", "id": 238236187, "number": 9839, "title": "Adding mp3 to the patent-free ffmpeg dll", "user": { "login": "phas0r", "id": 4430298, "avatar_url": "https://avatars1.githubusercontent.com/u/4430298?v=3", "gravatar_id": "", "url": "https://api.github.com/users/phas0r", "html_url": "https://github.com/phas0r", "followers_url": "https://api.github.com/users/phas0r/followers", "following_url": "https://api.github.com/users/phas0r/following{/other_user}", "gists_url": "https://api.github.com/users/phas0r/gists{/gist_id}", "starred_url": "https://api.github.com/users/phas0r/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/phas0r/subscriptions", "organizations_url": "https://api.github.com/users/phas0r/orgs", "repos_url": "https://api.github.com/users/phas0r/repos", "events_url": "https://api.github.com/users/phas0r/events{/privacy}", "received_events_url": "https://api.github.com/users/phas0r/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-23T19:44:01Z", "updated_at": "2017-06-25T03:31:11Z", "closed_at": "2017-06-25T03:31:11Z", "body": "Now that mp3 decoding is patent free, will mp3 be added to the patent-free ffmpeg dll and when might that happen?\r\n\r\nI am currently working on a project that would benefit from supporting mp3 over the web audio API.\r\n\r\nIf it will not be added, is there a documented way on how to compile the library for electron myself?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9838", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9838/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9838/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9838/events", "html_url": "https://github.com/electron/electron/issues/9838", "id": 238155031, "number": 9838, "title": "Get click events in screen", "user": { "login": "TheRolfFR", "id": 18086786, "avatar_url": "https://avatars1.githubusercontent.com/u/18086786?v=3", "gravatar_id": "", "url": "https://api.github.com/users/TheRolfFR", "html_url": "https://github.com/TheRolfFR", "followers_url": "https://api.github.com/users/TheRolfFR/followers", "following_url": "https://api.github.com/users/TheRolfFR/following{/other_user}", "gists_url": "https://api.github.com/users/TheRolfFR/gists{/gist_id}", "starred_url": "https://api.github.com/users/TheRolfFR/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TheRolfFR/subscriptions", "organizations_url": "https://api.github.com/users/TheRolfFR/orgs", "repos_url": "https://api.github.com/users/TheRolfFR/repos", "events_url": "https://api.github.com/users/TheRolfFR/events{/privacy}", "received_events_url": "https://api.github.com/users/TheRolfFR/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-23T14:15:08Z", "updated_at": "2017-06-23T14:18:49Z", "closed_at": "2017-06-23T14:18:49Z", "body": "* Electron version: v1.6.11\r\n* Operating system: Windows 7 x64 SP1\r\n\r\nIs there any way to get click events in screen ? I need it to drag a browserWindow when it is not focused.\r\n\r\nThanks in advance.\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9837", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9837/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9837/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9837/events", "html_url": "https://github.com/electron/electron/pull/9837", "id": 238146053, "number": 9837, "title": "Notification actions", "user": { "login": "MarshallOfSound", "id": 6634592, "avatar_url": "https://avatars0.githubusercontent.com/u/6634592?v=3", "gravatar_id": "", "url": "https://api.github.com/users/MarshallOfSound", "html_url": "https://github.com/MarshallOfSound", "followers_url": "https://api.github.com/users/MarshallOfSound/followers", "following_url": "https://api.github.com/users/MarshallOfSound/following{/other_user}", "gists_url": "https://api.github.com/users/MarshallOfSound/gists{/gist_id}", "starred_url": "https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MarshallOfSound/subscriptions", "organizations_url": "https://api.github.com/users/MarshallOfSound/orgs", "repos_url": "https://api.github.com/users/MarshallOfSound/repos", "events_url": "https://api.github.com/users/MarshallOfSound/events{/privacy}", "received_events_url": "https://api.github.com/users/MarshallOfSound/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-23T13:42:23Z", "updated_at": "2017-06-24T11:58:59Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9837", "html_url": "https://github.com/electron/electron/pull/9837", "diff_url": "https://github.com/electron/electron/pull/9837.diff", "patch_url": "https://github.com/electron/electron/pull/9837.patch" }, "body": "Adds support for \"notification actions\" to the main process Notification API.\r\n\r\nThe only supported action at the moment is \"button\" on macOS. In theory this could be expanded to support windows as well in a future PR along with other types of actions (like dropdowns in windows)" }, { "url": "https://api.github.com/repos/electron/electron/issues/9836", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9836/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9836/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9836/events", "html_url": "https://github.com/electron/electron/issues/9836", "id": 238114759, "number": 9836, "title": "Installation fails because of wrong checksum of electron-v1.6.11-linux-x64.zip", "user": { "login": "TheJJ", "id": 673543, "avatar_url": "https://avatars0.githubusercontent.com/u/673543?v=3", "gravatar_id": "", "url": "https://api.github.com/users/TheJJ", "html_url": "https://github.com/TheJJ", "followers_url": "https://api.github.com/users/TheJJ/followers", "following_url": "https://api.github.com/users/TheJJ/following{/other_user}", "gists_url": "https://api.github.com/users/TheJJ/gists{/gist_id}", "starred_url": "https://api.github.com/users/TheJJ/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TheJJ/subscriptions", "organizations_url": "https://api.github.com/users/TheJJ/orgs", "repos_url": "https://api.github.com/users/TheJJ/repos", "events_url": "https://api.github.com/users/TheJJ/events{/privacy}", "received_events_url": "https://api.github.com/users/TheJJ/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-23T11:22:01Z", "updated_at": "2017-06-25T03:34:48Z", "closed_at": "2017-06-25T03:34:48Z", "body": "* Electron version: v1.6.11\r\n* Operating system: Gentoo Linux\r\n\r\n### Expected behavior\r\n\r\nI'm trying to install electron in [`riot-web`](https://github.com/vector-im/riot-web) with `npm install electron`. Apart from funny dependency errors (`fs.realpath`, `core-util-is`, `process-nextick-args`, `util-deprecate`, fixed by manual `npm install $names`),\r\nthe installation fails because of a wrong checksum.\r\n\r\nI'd expect that electron would install...\r\n\r\n### Actual behavior\r\n\r\n`npm install electron` yields `Error: Generated checksum for \"electron-v1.6.11-linux-x64.zip\" did not match expected checksum.`:\r\n\r\n```\r\n$ npm install --verbose electron\r\n....\r\nnpm info lifecycle electron@1.6.11~postinstall: electron@1.6.11\r\n\r\n> electron@1.6.11 postinstall /home/jj/devel/riot-web/node_modules/electron\r\n> node install.js\r\n\r\nDownloading electron-v1.6.11-linux-x64.zip\r\n[============================================>] 100.0% of 48.75 MB (1.77 MB/s)\r\n/home/jj/devel/riot-web/node_modules/electron/install.js:47\r\n throw err\r\n ^\r\n\r\nError: Generated checksum for \"electron-v1.6.11-linux-x64.zip\" did not match expected checksum.\r\n at ChecksumMismatchError.ErrorWithFilename (/home/jj/devel/riot-web/node_modules/sumchecker/build.js:41:124)\r\n at new ChecksumMismatchError (/home/jj/devel/riot-web/node_modules/sumchecker/build.js:56:133)\r\n at Hash. (/home/jj/devel/riot-web/node_modules/sumchecker/build.js:203:22)\r\n at emitNone (events.js:105:13)\r\n at Hash.emit (events.js:207:7)\r\n at emitReadable_ (_stream_readable.js:502:10)\r\n at emitReadable (_stream_readable.js:496:7)\r\n at addChunk (_stream_readable.js:263:7)\r\n at readableAddChunk (_stream_readable.js:239:11)\r\n at Hash.Readable.push (_stream_readable.js:197:10)\r\nnpm verb lifecycle electron@1.6.11~postinstall: unsafe-perm in lifecycle true\r\nnpm verb lifecycle electron@1.6.11~postinstall: PATH: /usr/lib64/node_modules/npm/bin/node-gyp-bin:/home/jj/devel/riot-web/node_modules/electron/node_modules/.bin:/home/jj/devel/riot-web/node_modules/.bin:/usr/x86_64-pc-linux-gnu/gcc-bin/6.3.0:/usr/lib/llvm/4/bin:/usr/local/bin:/usr/bin:/bin:/opt/bin:/usr/lib64/opencascade-6.9.1/ros/lin/bin:/usr/games/bin:/home/jj/bin\r\nnpm verb lifecycle electron@1.6.11~postinstall: CWD: /home/jj/devel/riot-web/node_modules/electron\r\nnpm info lifecycle electron@1.6.11~postinstall: Failed to exec postinstall script\r\nnpm verb unlock done using /home/jj/.npm/_locks/staging-3443e8273d89e58b.lock for /home/jj/devel/riot-web/node_modules/.staging\r\nnpm verb stack Error: electron@1.6.11 postinstall: `node install.js`\r\nnpm verb stack Exit status 1\r\nnpm verb stack at EventEmitter. (/usr/lib64/node_modules/npm/lib/utils/lifecycle.js:283:16)\r\nnpm verb stack at emitTwo (events.js:125:13)\r\nnpm verb stack at EventEmitter.emit (events.js:213:7)\r\nnpm verb stack at ChildProcess. (/usr/lib64/node_modules/npm/lib/utils/spawn.js:40:14)\r\nnpm verb stack at emitTwo (events.js:125:13)\r\nnpm verb stack at ChildProcess.emit (events.js:213:7)\r\nnpm verb stack at maybeClose (internal/child_process.js:897:16)\r\nnpm verb stack at Process.ChildProcess._handle.onexit (internal/child_process.js:208:5)\r\nnpm verb pkgid electron@1.6.11\r\nnpm verb cwd /home/jj/devel/riot-web\r\nnpm verb Linux 4.11.2-JJ\r\nnpm verb argv \"/usr/bin/node\" \"/usr/bin/npm\" \"install\" \"--verbose\" \"electron\"\r\nnpm verb node v8.1.2\r\nnpm verb npm v5.0.3\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! errno 1\r\nnpm ERR! electron@1.6.11 postinstall: `node install.js`\r\nnpm ERR! Exit status 1\r\nnpm ERR! \r\nnpm ERR! Failed at the electron@1.6.11 postinstall script.\r\nnpm ERR! This is probably not a problem with npm. There is likely additional logging output above.\r\nnpm verb exit [ 1, true ]\r\n```\r\n\r\n### How to reproduce\r\n\r\n $ git clone https://github.com/vector-im/riot-web.git\r\n $ npm install\r\n $ npm install electron\r\n\r\n### Moar info\r\n\r\nI deleted `.electron` `.npm` `node_modules` and have no idea how I should further debug this. A first step would be to persuade `npm` to keep files after the failed installation, because now they're deleted instantly after the failure.\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9835", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9835/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9835/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9835/events", "html_url": "https://github.com/electron/electron/issues/9835", "id": 238019099, "number": 9835, "title": "Issues with webview history APIs when visiting Twitter", "user": { "login": "pfrazee", "id": 1270099, "avatar_url": "https://avatars1.githubusercontent.com/u/1270099?v=3", "gravatar_id": "", "url": "https://api.github.com/users/pfrazee", "html_url": "https://github.com/pfrazee", "followers_url": "https://api.github.com/users/pfrazee/followers", "following_url": "https://api.github.com/users/pfrazee/following{/other_user}", "gists_url": "https://api.github.com/users/pfrazee/gists{/gist_id}", "starred_url": "https://api.github.com/users/pfrazee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pfrazee/subscriptions", "organizations_url": "https://api.github.com/users/pfrazee/orgs", "repos_url": "https://api.github.com/users/pfrazee/repos", "events_url": "https://api.github.com/users/pfrazee/events{/privacy}", "received_events_url": "https://api.github.com/users/pfrazee/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-23T01:51:11Z", "updated_at": "2017-06-23T17:23:40Z", "closed_at": null, "body": "* Electron version: Tested on 1.6.2 and 1.7.x\r\n* Operating system: MacOS\r\n\r\nThe webview canGoBack/canGoForward, and actual goBack/goForward actions, seem to get confused with Twitter.\r\n\r\nYou can observe this by visiting twitter from a webview:\r\n\r\n![twitter-history-issue](https://user-images.githubusercontent.com/1270099/27463307-69f3e522-578c-11e7-9eab-0c1635a4693f.gif)\r\n\r\n\r\nDemo: https://github.com/pfrazee/electron-bug-twitter-history\r\n\r\n```\r\n $ git clone https://github.com/pfrazee/electron-bug-twitter-history\r\n $ cd electron-bug-twitter-history\r\n $ npm install\r\n $ npm start\r\n```\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9834", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9834/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9834/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9834/events", "html_url": "https://github.com/electron/electron/pull/9834", "id": 237975362, "number": 9834, "title": "Fix treat packaged app as directory", "user": { "login": "shubham2892", "id": 6316389, "avatar_url": "https://avatars1.githubusercontent.com/u/6316389?v=3", "gravatar_id": "", "url": "https://api.github.com/users/shubham2892", "html_url": "https://github.com/shubham2892", "followers_url": "https://api.github.com/users/shubham2892/followers", "following_url": "https://api.github.com/users/shubham2892/following{/other_user}", "gists_url": "https://api.github.com/users/shubham2892/gists{/gist_id}", "starred_url": "https://api.github.com/users/shubham2892/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shubham2892/subscriptions", "organizations_url": "https://api.github.com/users/shubham2892/orgs", "repos_url": "https://api.github.com/users/shubham2892/repos", "events_url": "https://api.github.com/users/shubham2892/events{/privacy}", "received_events_url": "https://api.github.com/users/shubham2892/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-22T21:11:49Z", "updated_at": "2017-06-22T21:11:49Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9834", "html_url": "https://github.com/electron/electron/pull/9834", "diff_url": "https://github.com/electron/electron/pull/9834.diff", "patch_url": "https://github.com/electron/electron/pull/9834.patch" }, "body": "Fixes #8948 \r\nAdded the flag that enables treating file packages as directories." }, { "url": "https://api.github.com/repos/electron/electron/issues/9833", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9833/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9833/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9833/events", "html_url": "https://github.com/electron/electron/issues/9833", "id": 237850903, "number": 9833, "title": "Child window does not over the parent window after show()", "user": { "login": "JasinYip", "id": 7105264, "avatar_url": "https://avatars1.githubusercontent.com/u/7105264?v=3", "gravatar_id": "", "url": "https://api.github.com/users/JasinYip", "html_url": "https://github.com/JasinYip", "followers_url": "https://api.github.com/users/JasinYip/followers", "following_url": "https://api.github.com/users/JasinYip/following{/other_user}", "gists_url": "https://api.github.com/users/JasinYip/gists{/gist_id}", "starred_url": "https://api.github.com/users/JasinYip/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JasinYip/subscriptions", "organizations_url": "https://api.github.com/users/JasinYip/orgs", "repos_url": "https://api.github.com/users/JasinYip/repos", "events_url": "https://api.github.com/users/JasinYip/events{/privacy}", "received_events_url": "https://api.github.com/users/JasinYip/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-22T13:45:37Z", "updated_at": "2017-06-22T13:53:49Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.7.1\r\n* Operating system: macOS Sierra 10.12.5 (16F73)\r\n\r\n### Expected behavior\r\n\r\nThe child window should overs the parent window even the child window was hidden and we called `childWin.show()` to make it visible. That means if we click the parent window(parent window got focus), the child windows should overs the parent window.\r\n\r\n### Actual behavior\r\n\r\nThe hidden window (whether set `show: false` when `new BrowserWindow` or called `childWin.hide()`) not over the parent window if we focus the parent window. Also when we dragging the parent window, the child window wasn't dragged with.\r\n\r\n### How to reproduce\r\n\r\nThe reproducing code on this repo: https://github.com/JasinYip/electron-child-win-hide-over\r\n\r\nThe following is the core code:\r\n\r\n```js\r\nconst parentWin = new BrowserWindow()\r\nconst childWin = new BrowserWindow({ parent: parentWin, show: false })\r\n\r\nsetTimeout(() => childWin.show(), 2000)\r\n```\r\n\r\nAfter launch the application, click the main window, and you will see the parent window will covers the child window. If we remove `show: false`, we will see the parent window **will not** covers the child window.\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9832", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9832/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9832/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9832/events", "html_url": "https://github.com/electron/electron/issues/9832", "id": 237821655, "number": 9832, "title": "How to call a third-party DLL file", "user": { "login": "xujiahan", "id": 23237343, "avatar_url": "https://avatars3.githubusercontent.com/u/23237343?v=3", "gravatar_id": "", "url": "https://api.github.com/users/xujiahan", "html_url": "https://github.com/xujiahan", "followers_url": "https://api.github.com/users/xujiahan/followers", "following_url": "https://api.github.com/users/xujiahan/following{/other_user}", "gists_url": "https://api.github.com/users/xujiahan/gists{/gist_id}", "starred_url": "https://api.github.com/users/xujiahan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xujiahan/subscriptions", "organizations_url": "https://api.github.com/users/xujiahan/orgs", "repos_url": "https://api.github.com/users/xujiahan/repos", "events_url": "https://api.github.com/users/xujiahan/events{/privacy}", "received_events_url": "https://api.github.com/users/xujiahan/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-22T11:57:49Z", "updated_at": "2017-06-22T14:16:44Z", "closed_at": "2017-06-22T12:11:28Z", "body": "\r\nHow to call a third-party DLL file Des64.dll " }, { "url": "https://api.github.com/repos/electron/electron/issues/9831", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9831/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9831/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9831/events", "html_url": "https://github.com/electron/electron/issues/9831", "id": 237813135, "number": 9831, "title": "app hanging on close if dialog.showOpenDialog() after file drag & drop", "user": { "login": "smilejp", "id": 3704914, "avatar_url": "https://avatars0.githubusercontent.com/u/3704914?v=3", "gravatar_id": "", "url": "https://api.github.com/users/smilejp", "html_url": "https://github.com/smilejp", "followers_url": "https://api.github.com/users/smilejp/followers", "following_url": "https://api.github.com/users/smilejp/following{/other_user}", "gists_url": "https://api.github.com/users/smilejp/gists{/gist_id}", "starred_url": "https://api.github.com/users/smilejp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/smilejp/subscriptions", "organizations_url": "https://api.github.com/users/smilejp/orgs", "repos_url": "https://api.github.com/users/smilejp/repos", "events_url": "https://api.github.com/users/smilejp/events{/privacy}", "received_events_url": "https://api.github.com/users/smilejp/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-22T11:22:28Z", "updated_at": "2017-06-22T11:22:28Z", "closed_at": null, "body": "* Electron version: v0.36.12\r\n* Operating system: Windows 10 64bit\r\n\r\n### Expected behavior\r\n\r\ni wanted to file selection without drag & drop.\r\nso called dialog.showOpenDialog() and tested two type of code to ignore drag & drop\r\n\r\n```\r\nmainWindow.webContents.on('will-navigate', ev => {\r\n ev.preventDefault();\r\n})\r\n```\r\n\r\n```\r\ndocument.addEventListener(\"dragover\",function(e) {\r\n e = e || event;\r\n e.preventDefault();\r\n e.stopPropagation();\r\n}, false);\r\n\r\ndocument.addEventListener(\"drop\",function(e) {\r\n e = e || event;\r\n e.preventDefault();\r\n e.stopPropagation();\r\n}, false);\r\n```\r\nand tested many times quickly drag & drop.\r\nany cases, found freeze app after showOpenDialog closed.\r\n\r\nalso tested in v1.6.11(ia32, x64) had same problem.\r\n\r\n### How to reproduce\r\n\r\n* Start electron app\r\n* call showOpenDialog(). can show file open dialog.\r\n* select file in dialog and drag and drop to MainBrowser\r\n* repeat several times(over 30 times).\r\n\r\nHere's sample example.\r\n[app.zip](https://github.com/electron/electron/files/1094556/app.zip)\r\n\r\n![ezgif com-gif-maker](https://user-images.githubusercontent.com/3704914/27431692-595010c8-5788-11e7-8ba7-81c3da14c742.gif)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9830", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9830/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9830/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9830/events", "html_url": "https://github.com/electron/electron/issues/9830", "id": 237779313, "number": 9830, "title": "Problem with devtools - Network. Requests Display", "user": { "login": "Devhercule", "id": 29538843, "avatar_url": "https://avatars0.githubusercontent.com/u/29538843?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Devhercule", "html_url": "https://github.com/Devhercule", "followers_url": "https://api.github.com/users/Devhercule/followers", "following_url": "https://api.github.com/users/Devhercule/following{/other_user}", "gists_url": "https://api.github.com/users/Devhercule/gists{/gist_id}", "starred_url": "https://api.github.com/users/Devhercule/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Devhercule/subscriptions", "organizations_url": "https://api.github.com/users/Devhercule/orgs", "repos_url": "https://api.github.com/users/Devhercule/repos", "events_url": "https://api.github.com/users/Devhercule/events{/privacy}", "received_events_url": "https://api.github.com/users/Devhercule/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-22T09:08:44Z", "updated_at": "2017-06-22T09:22:44Z", "closed_at": null, "body": "in index.html:\r\n``\r\n\r\nin Renderer.js:\r\n```\r\nvar webview = document.getElementById(\"webview1\");\r\nwebview.addEventListener(\"did-start-loading\", function(){ webview.openDevTools(); });\r\n```\r\n\r\n* Electron version: 1.6.2\r\n* Operating system: Windows7\r\n\r\n### Expected behavior\r\nall requests are displayed in dev tool -> network\r\nespecially the first request (type : document) \r\n\r\n> Request URL:http://www.example.com/\r\n\r\nThis request is not displayed in devtools -> Network\r\nIf i press F5, it appears, but i need to display it without pressing F5\r\n\r\n\r\n\r\n### Actual behavior\r\nAll request are diplayed, EXCEPT the first one.\r\nThe first query is never displayed\r\n\r\n![impr](https://user-images.githubusercontent.com/29538843/27426794-180a518c-573d-11e7-86f4-68b6ddc0c8c6.png)\r\n\r\n\r\n\r\n\r\nCan you help me to display the first sent request?\r\n\r\nThank you\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9829", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9829/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9829/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9829/events", "html_url": "https://github.com/electron/electron/pull/9829", "id": 237771709, "number": 9829, "title": "Merge pull request #1 from electron/master", "user": { "login": "zh880517", "id": 6227354, "avatar_url": "https://avatars3.githubusercontent.com/u/6227354?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zh880517", "html_url": "https://github.com/zh880517", "followers_url": "https://api.github.com/users/zh880517/followers", "following_url": "https://api.github.com/users/zh880517/following{/other_user}", "gists_url": "https://api.github.com/users/zh880517/gists{/gist_id}", "starred_url": "https://api.github.com/users/zh880517/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zh880517/subscriptions", "organizations_url": "https://api.github.com/users/zh880517/orgs", "repos_url": "https://api.github.com/users/zh880517/repos", "events_url": "https://api.github.com/users/zh880517/events{/privacy}", "received_events_url": "https://api.github.com/users/zh880517/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-22T08:40:12Z", "updated_at": "2017-06-22T08:55:15Z", "closed_at": "2017-06-22T08:55:15Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9829", "html_url": "https://github.com/electron/electron/pull/9829", "diff_url": "https://github.com/electron/electron/pull/9829.diff", "patch_url": "https://github.com/electron/electron/pull/9829.patch" }, "body": "updat" }, { "url": "https://api.github.com/repos/electron/electron/issues/9828", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9828/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9828/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9828/events", "html_url": "https://github.com/electron/electron/pull/9828", "id": 237691793, "number": 9828, "title": "Fix crash when using file chooser in BrowserView", "user": { "login": "poiru", "id": 1319028, "avatar_url": "https://avatars1.githubusercontent.com/u/1319028?v=3", "gravatar_id": "", "url": "https://api.github.com/users/poiru", "html_url": "https://github.com/poiru", "followers_url": "https://api.github.com/users/poiru/followers", "following_url": "https://api.github.com/users/poiru/following{/other_user}", "gists_url": "https://api.github.com/users/poiru/gists{/gist_id}", "starred_url": "https://api.github.com/users/poiru/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poiru/subscriptions", "organizations_url": "https://api.github.com/users/poiru/orgs", "repos_url": "https://api.github.com/users/poiru/repos", "events_url": "https://api.github.com/users/poiru/events{/privacy}", "received_events_url": "https://api.github.com/users/poiru/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 2, "created_at": "2017-06-21T23:25:06Z", "updated_at": "2017-06-26T16:55:04Z", "closed_at": "2017-06-26T16:54:31Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9828", "html_url": "https://github.com/electron/electron/pull/9828", "diff_url": "https://github.com/electron/electron/pull/9828.diff", "patch_url": "https://github.com/electron/electron/pull/9828.patch" }, "body": "The crash was a segfault caused by a null `WebDialogHelper::window_`." }, { "url": "https://api.github.com/repos/electron/electron/issues/9827", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9827/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9827/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9827/events", "html_url": "https://github.com/electron/electron/issues/9827", "id": 237684066, "number": 9827, "title": "On Windows, app.setLoginItemSettings sets \"Update\" and \"Github\" as my app's name/publisher in Task Manager > Startup", "user": { "login": "ccnokes", "id": 1610343, "avatar_url": "https://avatars3.githubusercontent.com/u/1610343?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ccnokes", "html_url": "https://github.com/ccnokes", "followers_url": "https://api.github.com/users/ccnokes/followers", "following_url": "https://api.github.com/users/ccnokes/following{/other_user}", "gists_url": "https://api.github.com/users/ccnokes/gists{/gist_id}", "starred_url": "https://api.github.com/users/ccnokes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ccnokes/subscriptions", "organizations_url": "https://api.github.com/users/ccnokes/orgs", "repos_url": "https://api.github.com/users/ccnokes/repos", "events_url": "https://api.github.com/users/ccnokes/events{/privacy}", "received_events_url": "https://api.github.com/users/ccnokes/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-21T22:36:39Z", "updated_at": "2017-06-22T21:50:09Z", "closed_at": "2017-06-22T09:33:20Z", "body": "* Electron version: 1.6.11\r\n* Operating system: Windows 10\r\n\r\n### Expected behavior\r\nIt should use my app's name, icon, and publisher.\r\n\r\n### Actual behavior\r\nIt uses the generic icon, \"Update\", and Github as the publisher. See screenshot.\r\n\r\n![image](https://user-images.githubusercontent.com/1610343/27409538-2ad42dae-569f-11e7-89a0-f0308f6d72bd.png)\r\n\r\n\r\n### How to reproduce\r\nFollowing the docs for Windows, I call it like so: \r\n\r\n```javascript\r\nconst appFolder = path.dirname(process.execPath)\r\nconst updateExe = path.resolve(appFolder, '..', 'Update.exe')\r\nconst exeName = path.basename(process.execPath)\r\n\r\napp.setLoginItemSettings({\r\n openAtLogin: true,\r\n path: updateExe,\r\n args: [\r\n '--processStart', `\"${exeName}\"`,\r\n '--process-start-args', `\"--hidden\"`\r\n ]\r\n})\r\n```\r\n\r\nNote the functionality works as expected, this is more of a visual/informational thing that seems buggy.\r\n\r\nLet me know if you need any more details or if this is actually a Squirrel.Windows issue or something. \r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9826", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9826/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9826/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9826/events", "html_url": "https://github.com/electron/electron/pull/9826", "id": 237681889, "number": 9826, "title": "Fix docs: app.md `setLoginItemSettings`", "user": { "login": "ccnokes", "id": 1610343, "avatar_url": "https://avatars3.githubusercontent.com/u/1610343?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ccnokes", "html_url": "https://github.com/ccnokes", "followers_url": "https://api.github.com/users/ccnokes/followers", "following_url": "https://api.github.com/users/ccnokes/following{/other_user}", "gists_url": "https://api.github.com/users/ccnokes/gists{/gist_id}", "starred_url": "https://api.github.com/users/ccnokes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ccnokes/subscriptions", "organizations_url": "https://api.github.com/users/ccnokes/orgs", "repos_url": "https://api.github.com/users/ccnokes/repos", "events_url": "https://api.github.com/users/ccnokes/events{/privacy}", "received_events_url": "https://api.github.com/users/ccnokes/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-21T22:24:23Z", "updated_at": "2017-06-26T15:07:16Z", "closed_at": "2017-06-26T15:07:16Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9826", "html_url": "https://github.com/electron/electron/pull/9826", "diff_url": "https://github.com/electron/electron/pull/9826.diff", "patch_url": "https://github.com/electron/electron/pull/9826.patch" }, "body": "`app.setLoginItemSettings` documented arguments are misleading -- `path` and `args` should be passed in the `settings` object, not as separate params, like the code sample below it or in the test file here: https://github.com/electron/electron/blob/9250b559f91c3c1654484df46a8ba83f9bdbecd2/spec/api-app-spec.js#L336\r\nand in the actual C++ function declaration here: https://github.com/electron/electron/blob/f5a75c4e87a73a802c41e9fb3608e10772dbe600/atom/browser/browser.h#L104" }, { "url": "https://api.github.com/repos/electron/electron/issues/9825", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9825/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9825/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9825/events", "html_url": "https://github.com/electron/electron/issues/9825", "id": 237639470, "number": 9825, "title": "Setting the renderer's zoom level before a webview is loaded causes the webview's inner content to no longer fill the frame", "user": { "login": "ccnokes", "id": 1610343, "avatar_url": "https://avatars3.githubusercontent.com/u/1610343?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ccnokes", "html_url": "https://github.com/ccnokes", "followers_url": "https://api.github.com/users/ccnokes/followers", "following_url": "https://api.github.com/users/ccnokes/following{/other_user}", "gists_url": "https://api.github.com/users/ccnokes/gists{/gist_id}", "starred_url": "https://api.github.com/users/ccnokes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ccnokes/subscriptions", "organizations_url": "https://api.github.com/users/ccnokes/orgs", "repos_url": "https://api.github.com/users/ccnokes/repos", "events_url": "https://api.github.com/users/ccnokes/events{/privacy}", "received_events_url": "https://api.github.com/users/ccnokes/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 144086588, "url": "https://api.github.com/repos/electron/electron/labels/component/webview", "name": "component/webview", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-21T19:26:28Z", "updated_at": "2017-06-22T09:40:48Z", "closed_at": null, "body": "* Electron version: 1.6.11\r\n* Operating system: MacOS (Windows too probably)\r\n\r\n### Expected behavior\r\n\r\n\r\nThe content of the webview should fill the frame.\r\n\r\n### Actual behavior\r\n\r\n\r\nThe content gets resized smaller than the frame. See screenshot below. \r\n\r\n![image](https://user-images.githubusercontent.com/1610343/27402772-0ae06f5e-5685-11e7-9126-6a33c4f1c3fa.png)\r\n\r\n\r\n### How to reproduce\r\nSee `test1` function here https://github.com/ccnokes/electron-webview-zoom-bugs/blob/master/renderer.js#L43\r\n(Note that repository also demonstrates another bug where a webview's content does not fill the frame if the webview is hidden and then re-shown. That bug might already be adequately reported in #7375.)\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9824", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9824/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9824/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9824/events", "html_url": "https://github.com/electron/electron/pull/9824", "id": 237633892, "number": 9824, "title": "Add process properties in lieu of command line options.", "user": { "login": "jkleinsc", "id": 609052, "avatar_url": "https://avatars3.githubusercontent.com/u/609052?v=3", "gravatar_id": "", "url": "https://api.github.com/users/jkleinsc", "html_url": "https://github.com/jkleinsc", "followers_url": "https://api.github.com/users/jkleinsc/followers", "following_url": "https://api.github.com/users/jkleinsc/following{/other_user}", "gists_url": "https://api.github.com/users/jkleinsc/gists{/gist_id}", "starred_url": "https://api.github.com/users/jkleinsc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jkleinsc/subscriptions", "organizations_url": "https://api.github.com/users/jkleinsc/orgs", "repos_url": "https://api.github.com/users/jkleinsc/repos", "events_url": "https://api.github.com/users/jkleinsc/events{/privacy}", "received_events_url": "https://api.github.com/users/jkleinsc/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-21T19:04:44Z", "updated_at": "2017-06-26T02:16:37Z", "closed_at": "2017-06-26T02:16:34Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9824", "html_url": "https://github.com/electron/electron/pull/9824", "diff_url": "https://github.com/electron/electron/pull/9824.diff", "patch_url": "https://github.com/electron/electron/pull/9824.patch" }, "body": "Resolves #9139\r\nFor certain node command line options, those options can be set via the\r\nprocess object, so there isn't a need to add them to Electron's command line options.\r\nThe following properties were added to the documentation:\r\n\r\n- `process.noDeprecation` to set the `--no-deprecation` flag\r\n- `process.throwDeprecation` to set the `--throw-deprecation` flag\r\n- `process.traceDeprecation` to set the `--trace-deprecation` flag\r\n- `process.traceProcessWarnings` to set the `--trace-warnings` flag\r\n\r\nAlso, sorted properties and methods alphabetically for easier readability." }, { "url": "https://api.github.com/repos/electron/electron/issues/9823", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9823/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9823/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9823/events", "html_url": "https://github.com/electron/electron/issues/9823", "id": 237621230, "number": 9823, "title": "Memory leak when creating Menu", "user": { "login": "Thomas101", "id": 103586, "avatar_url": "https://avatars3.githubusercontent.com/u/103586?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Thomas101", "html_url": "https://github.com/Thomas101", "followers_url": "https://api.github.com/users/Thomas101/followers", "following_url": "https://api.github.com/users/Thomas101/following{/other_user}", "gists_url": "https://api.github.com/users/Thomas101/gists{/gist_id}", "starred_url": "https://api.github.com/users/Thomas101/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Thomas101/subscriptions", "organizations_url": "https://api.github.com/users/Thomas101/orgs", "repos_url": "https://api.github.com/users/Thomas101/repos", "events_url": "https://api.github.com/users/Thomas101/events{/privacy}", "received_events_url": "https://api.github.com/users/Thomas101/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-21T18:16:19Z", "updated_at": "2017-06-21T18:16:19Z", "closed_at": null, "body": "* Electron version: 1.7.3, 1.6.11\r\n* Operating system: macOS 10.12.5\r\n\r\n### Expected & Actual behavior\r\n\r\nCreating a menu object then losing the reference to it should not increase memory consumption. In the below example the menu is thrown away at the end of the function, but remains in memory.\r\n\r\n```js\r\nconst { Menu } = require('electron')\r\n(function () {\r\n const menu = Menu.buildFromTemplate([{ label: 'Test' }])\r\n})()\r\n```\r\n\r\nArguably you should could call `destroy()` on the menu, but if it has submenus the leak remains as the submenus are not destroyed either.\r\n\r\n```js\r\nconst { Menu } = require('electron')\r\n(function () {\r\n const menu = Menu.buildFromTemplate([{\r\n label: 'Test',\r\n submenu: [ { label: 'Test2' } ]\r\n }])\r\n menu.destroy()\r\n})()\r\n```\r\n\r\n### How to reproduce\r\n\r\nProbably best to show this with an example :). This repo does nothing more than create lots of menus and log memory usage\r\n\r\n```\r\ngit clone https://github.com/wavebox/electron-quick-start.git\r\ncd electron-quick-start\r\ngit checkout menu-memory-leak\r\nnpm install\r\nnpm run broken //to see the broken behaviour\r\nnpm run fixed //to see the fixed behaviour\r\n```\r\n\r\nIn the broken example `destroy()` is only called on the topmost created menu. In the fixed example `destroy()` is also called on the submenu\r\n\r\n### Fixes\r\n\r\nI guess there's arguments for either destroying automatically when references are released, or being required to call destroy to release memory. You could also argue that the `destroy` call should destroy all submenus too, but I can imagine use cases where this might not be desirable. Perhaps having a `destroyAll()` type call would be useful." }, { "url": "https://api.github.com/repos/electron/electron/issues/9822", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9822/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9822/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9822/events", "html_url": "https://github.com/electron/electron/issues/9822", "id": 237616118, "number": 9822, "title": "webview jquery not defined when loading website", "user": { "login": "BartNetJS", "id": 4865355, "avatar_url": "https://avatars2.githubusercontent.com/u/4865355?v=3", "gravatar_id": "", "url": "https://api.github.com/users/BartNetJS", "html_url": "https://github.com/BartNetJS", "followers_url": "https://api.github.com/users/BartNetJS/followers", "following_url": "https://api.github.com/users/BartNetJS/following{/other_user}", "gists_url": "https://api.github.com/users/BartNetJS/gists{/gist_id}", "starred_url": "https://api.github.com/users/BartNetJS/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BartNetJS/subscriptions", "organizations_url": "https://api.github.com/users/BartNetJS/orgs", "repos_url": "https://api.github.com/users/BartNetJS/repos", "events_url": "https://api.github.com/users/BartNetJS/events{/privacy}", "received_events_url": "https://api.github.com/users/BartNetJS/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2017-06-21T17:56:17Z", "updated_at": "2017-06-25T03:13:42Z", "closed_at": "2017-06-25T03:13:42Z", "body": "* Electron version: 1.6.11\r\n* Operating system: windows\r\n\r\nI try to load a website that redirects to authenticate to https://login.microsoftonline.com \r\nIn the developer tools/console there is an error jquery not defined inside the jquery library\r\n\r\n![capture](https://user-images.githubusercontent.com/4865355/27398192-43d5b434-56b9-11e7-97ac-babb577774c1.JPG)\r\n\r\nAny idea?\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9821", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9821/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9821/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9821/events", "html_url": "https://github.com/electron/electron/issues/9821", "id": 237573737, "number": 9821, "title": "logged in session", "user": { "login": "muscaiu", "id": 11426309, "avatar_url": "https://avatars3.githubusercontent.com/u/11426309?v=3", "gravatar_id": "", "url": "https://api.github.com/users/muscaiu", "html_url": "https://github.com/muscaiu", "followers_url": "https://api.github.com/users/muscaiu/followers", "following_url": "https://api.github.com/users/muscaiu/following{/other_user}", "gists_url": "https://api.github.com/users/muscaiu/gists{/gist_id}", "starred_url": "https://api.github.com/users/muscaiu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/muscaiu/subscriptions", "organizations_url": "https://api.github.com/users/muscaiu/orgs", "repos_url": "https://api.github.com/users/muscaiu/repos", "events_url": "https://api.github.com/users/muscaiu/events{/privacy}", "received_events_url": "https://api.github.com/users/muscaiu/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-21T15:24:39Z", "updated_at": "2017-06-21T15:57:39Z", "closed_at": "2017-06-21T15:57:39Z", "body": "Is there any way i could inject or set cookies so that i could get a logged in github session in a new window?\r\n\r\n```\r\n let win = new BrowserWindow({\r\n width: 800,\r\n height: 600,\r\n })\r\n win.loadURL('https://www.github.com')\r\n```" }, { "url": "https://api.github.com/repos/electron/electron/issues/9820", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9820/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9820/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9820/events", "html_url": "https://github.com/electron/electron/pull/9820", "id": 237525413, "number": 9820, "title": "Fix #8768", "user": { "login": "ferreus", "id": 206508, "avatar_url": "https://avatars0.githubusercontent.com/u/206508?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ferreus", "html_url": "https://github.com/ferreus", "followers_url": "https://api.github.com/users/ferreus/followers", "following_url": "https://api.github.com/users/ferreus/following{/other_user}", "gists_url": "https://api.github.com/users/ferreus/gists{/gist_id}", "starred_url": "https://api.github.com/users/ferreus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ferreus/subscriptions", "organizations_url": "https://api.github.com/users/ferreus/orgs", "repos_url": "https://api.github.com/users/ferreus/repos", "events_url": "https://api.github.com/users/ferreus/events{/privacy}", "received_events_url": "https://api.github.com/users/ferreus/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-21T13:00:04Z", "updated_at": "2017-06-21T13:50:51Z", "closed_at": "2017-06-21T13:50:51Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9820", "html_url": "https://github.com/electron/electron/pull/9820", "diff_url": "https://github.com/electron/electron/pull/9820.diff", "patch_url": "https://github.com/electron/electron/pull/9820.patch" }, "body": "SetEnabled uses internal counter to handle multiple calls to SetEnabled however that resulted in modal dialog not re-enabling the parent window, when used incorrectly." }, { "url": "https://api.github.com/repos/electron/electron/issues/9819", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9819/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9819/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9819/events", "html_url": "https://github.com/electron/electron/pull/9819", "id": 237514305, "number": 9819, "title": ":bug: Fix #9231: Don't load url when detached.", "user": { "login": "ferreus", "id": 206508, "avatar_url": "https://avatars0.githubusercontent.com/u/206508?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ferreus", "html_url": "https://github.com/ferreus", "followers_url": "https://api.github.com/users/ferreus/followers", "following_url": "https://api.github.com/users/ferreus/following{/other_user}", "gists_url": "https://api.github.com/users/ferreus/gists{/gist_id}", "starred_url": "https://api.github.com/users/ferreus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ferreus/subscriptions", "organizations_url": "https://api.github.com/users/ferreus/orgs", "repos_url": "https://api.github.com/users/ferreus/repos", "events_url": "https://api.github.com/users/ferreus/events{/privacy}", "received_events_url": "https://api.github.com/users/ferreus/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-21T12:19:04Z", "updated_at": "2017-06-25T12:39:07Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9819", "html_url": "https://github.com/electron/electron/pull/9819", "diff_url": "https://github.com/electron/electron/pull/9819.diff", "patch_url": "https://github.com/electron/electron/pull/9819.patch" }, "body": "I tracked down this crash to https://chromium.googlesource.com/experimental/chromium/src/+/58.0.3029.110/content/browser/browser_plugin/browser_plugin_guest.h#153\r\n```\r\nWebContentsImpl* embedder_web_contents() const {\r\n return attached_ ? owner_web_contents_ : nullptr;\r\n}\r\n```\r\n\r\nWhich results in null pointer access on LoadURL when the view is hidden (Because it's detached).\r\nThis is actually not a matter of race condition. As it's simply enough to hide the webview, then issue LoadURL to crash it.\r\n\r\nThis will avoid the crash by simply refusing to navigate when the view is not attached." }, { "url": "https://api.github.com/repos/electron/electron/issues/9818", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9818/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9818/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9818/events", "html_url": "https://github.com/electron/electron/issues/9818", "id": 237512177, "number": 9818, "title": "Browser history not working", "user": { "login": "saadbinsaeed", "id": 21288440, "avatar_url": "https://avatars1.githubusercontent.com/u/21288440?v=3", "gravatar_id": "", "url": "https://api.github.com/users/saadbinsaeed", "html_url": "https://github.com/saadbinsaeed", "followers_url": "https://api.github.com/users/saadbinsaeed/followers", "following_url": "https://api.github.com/users/saadbinsaeed/following{/other_user}", "gists_url": "https://api.github.com/users/saadbinsaeed/gists{/gist_id}", "starred_url": "https://api.github.com/users/saadbinsaeed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/saadbinsaeed/subscriptions", "organizations_url": "https://api.github.com/users/saadbinsaeed/orgs", "repos_url": "https://api.github.com/users/saadbinsaeed/repos", "events_url": "https://api.github.com/users/saadbinsaeed/events{/privacy}", "received_events_url": "https://api.github.com/users/saadbinsaeed/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-21T12:10:19Z", "updated_at": "2017-06-21T12:13:42Z", "closed_at": "2017-06-21T12:13:42Z", "body": "I am using the **react-router v3**. My website works fine with **browserHistory**, But the same application ( with browserHistory ) not working in electron app. **hashHistory** works well but i can not use it because i have multiple applications on my web platform that are using browserHistory. This is why i can not afford any disturbance with the code base. Want to keep it same for **web** and for **electron** app.\r\n\r\nAt first browserHistory was also not working in the web app but then i changed the ngnix configuration which let the browserHistory works. I am presuming that i have to change the configurations of the electron like i did with ngnix. Any help?\r\n\r\n* 1.6.11:\r\n* Ubuntu 16.0.4:\r\n\r\n### Expected behavior\r\n\r\nIt should work with the browserHistory\r\n\r\n### Actual behavior\r\n\r\nNot working with react-router browerHistory\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9817", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9817/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9817/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9817/events", "html_url": "https://github.com/electron/electron/issues/9817", "id": 237357093, "number": 9817, "title": "ses.setPermissionRequestHandler not handling requestPointerLock when invoked within ", "user": { "login": "nicross", "id": 840661, "avatar_url": "https://avatars3.githubusercontent.com/u/840661?v=3", "gravatar_id": "", "url": "https://api.github.com/users/nicross", "html_url": "https://github.com/nicross", "followers_url": "https://api.github.com/users/nicross/followers", "following_url": "https://api.github.com/users/nicross/following{/other_user}", "gists_url": "https://api.github.com/users/nicross/gists{/gist_id}", "starred_url": "https://api.github.com/users/nicross/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nicross/subscriptions", "organizations_url": "https://api.github.com/users/nicross/orgs", "repos_url": "https://api.github.com/users/nicross/repos", "events_url": "https://api.github.com/users/nicross/events{/privacy}", "received_events_url": "https://api.github.com/users/nicross/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 144086588, "url": "https://api.github.com/repos/electron/electron/labels/component/webview", "name": "component/webview", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-20T21:56:21Z", "updated_at": "2017-06-23T15:39:37Z", "closed_at": null, "body": "* Electron version: 1.7.3 beta\r\n* Operating system: OSX, Windows\r\n\r\n### Expected behavior\r\n\r\nThe permissionRequestHandler should be triggered when the webview's contents invoke `requestPointerLock`. The request should succeed or fail based on the callback.\r\n\r\n### Actual behavior\r\n\r\nThe permissionRequestHandler is skipped when the webview's contents invoke `requestPointerLock`. The request always fails.\r\n\r\n### How to reproduce\r\n\r\nWithin the main process: \r\n\r\n```js\r\nconst {app, BrowserWindow} = require('electron');\r\n\r\napp.on('ready', function onAppReady() {\r\n var browserWindow = new BrowserWindow();\r\n\r\n // Path to test file, e.g. http://localhost/test.html\r\n browserWindow.loadURL('http://localhost/test.html');\r\n\r\n browserWindow.webContents.session.setPermissionRequestHandler(\r\n function permissionRequestHandler(webContents, permission, callback) {\r\n // Place a breakpoint here while debugging with the --inspect-brk command line switch\r\n return callback(true);\r\n }\r\n );\r\n});\r\n```\r\n\r\n**test.html**\r\n```html\r\n\r\n\r\n \r\n \r\n \r\n\r\n```\r\n\r\n**webview.html**\r\n```html\r\n\r\n\r\n \r\n \r\n \r\n \r\n\r\n```\r\n\r\n### Other thoughts\r\n\r\nWe can successfully invoke `requestPointerLock` when the BrowserWindow points directly to webview.html. So this could be an issue with Electron's implementation of the `` element." }, { "url": "https://api.github.com/repos/electron/electron/issues/9816", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9816/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9816/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9816/events", "html_url": "https://github.com/electron/electron/issues/9816", "id": 237355102, "number": 9816, "title": "ses.setPermissionRequestHandler not handling requestPointerLock when invoked within ", "user": { "login": "nicross", "id": 840661, "avatar_url": "https://avatars3.githubusercontent.com/u/840661?v=3", "gravatar_id": "", "url": "https://api.github.com/users/nicross", "html_url": "https://github.com/nicross", "followers_url": "https://api.github.com/users/nicross/followers", "following_url": "https://api.github.com/users/nicross/following{/other_user}", "gists_url": "https://api.github.com/users/nicross/gists{/gist_id}", "starred_url": "https://api.github.com/users/nicross/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nicross/subscriptions", "organizations_url": "https://api.github.com/users/nicross/orgs", "repos_url": "https://api.github.com/users/nicross/repos", "events_url": "https://api.github.com/users/nicross/events{/privacy}", "received_events_url": "https://api.github.com/users/nicross/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-20T21:47:10Z", "updated_at": "2017-06-20T22:00:48Z", "closed_at": "2017-06-20T21:51:28Z", "body": "Disregard. See #9817." }, { "url": "https://api.github.com/repos/electron/electron/issues/9815", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9815/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9815/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9815/events", "html_url": "https://github.com/electron/electron/issues/9815", "id": 237343379, "number": 9815, "title": "Error installing electron on Ubuntu Xenial (Linux version 3.18.0)", "user": { "login": "reblevins", "id": 121063, "avatar_url": "https://avatars3.githubusercontent.com/u/121063?v=3", "gravatar_id": "", "url": "https://api.github.com/users/reblevins", "html_url": "https://github.com/reblevins", "followers_url": "https://api.github.com/users/reblevins/followers", "following_url": "https://api.github.com/users/reblevins/following{/other_user}", "gists_url": "https://api.github.com/users/reblevins/gists{/gist_id}", "starred_url": "https://api.github.com/users/reblevins/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reblevins/subscriptions", "organizations_url": "https://api.github.com/users/reblevins/orgs", "repos_url": "https://api.github.com/users/reblevins/repos", "events_url": "https://api.github.com/users/reblevins/events{/privacy}", "received_events_url": "https://api.github.com/users/reblevins/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-20T20:58:57Z", "updated_at": "2017-06-20T20:58:57Z", "closed_at": null, "body": "I'm on Linux trying to install electron using: `sudo npm -g install electron@1.7.2`\r\n\r\n(I don't normally install using `sudo`, but when I didn't it complained that I should)\r\n\r\nand I'm getting the following errors:\r\n\r\n```\r\nError: EACCES: permission denied, mkdir '/usr/lib/node_modules/electron/.electron'\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! errno 1\r\nnpm ERR! electron@1.7.2 postinstall: `node install.js`\r\nnpm ERR! Exit status 1\r\nnpm ERR! \r\nnpm ERR! Failed at the electron@1.7.2 postinstall script.\r\nnpm ERR! This is probably not a problem with npm. There is likely additional logging output above.\r\n```\r\n\r\nI also tried a plain vanilla: `sudo npm -g install electron` and got the same errors.\r\n\r\n* Operating system:\r\nLinux version 3.18.0-14856-g9bbe428768eb (chrome-bot@cros-beefy107-c2) (gcc version 4.9.x 20150123 (prerelease) (4.9.2_cos_gg_4.9.2-r154-32c89c19b042a12b5a1bf0153299154ea5435c03_4.9.2-r154) ) #1 SMP PREEMPT Wed Jun 14 22:13:29 PDT 2017\r\n\r\n(I am running inside a chroot on a Chromebook if that makes any difference.)\r\n\r\nI have attached the output from /home/username_redacted/.npm/_logs/2017-06-20T14_43_16_506Z-debug.log.\r\n\r\n[2017-06-20T14_43_16_506Z-debug.txt](https://github.com/electron/electron/files/1089670/2017-06-20T14_43_16_506Z-debug.txt)\r\n\r\nThanks for your help." }, { "url": "https://api.github.com/repos/electron/electron/issues/9814", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9814/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9814/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9814/events", "html_url": "https://github.com/electron/electron/pull/9814", "id": 237331620, "number": 9814, "title": "Fix full screen when resizable is set to true", "user": { "login": "shubham2892", "id": 6316389, "avatar_url": "https://avatars1.githubusercontent.com/u/6316389?v=3", "gravatar_id": "", "url": "https://api.github.com/users/shubham2892", "html_url": "https://github.com/shubham2892", "followers_url": "https://api.github.com/users/shubham2892/followers", "following_url": "https://api.github.com/users/shubham2892/following{/other_user}", "gists_url": "https://api.github.com/users/shubham2892/gists{/gist_id}", "starred_url": "https://api.github.com/users/shubham2892/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shubham2892/subscriptions", "organizations_url": "https://api.github.com/users/shubham2892/orgs", "repos_url": "https://api.github.com/users/shubham2892/repos", "events_url": "https://api.github.com/users/shubham2892/events{/privacy}", "received_events_url": "https://api.github.com/users/shubham2892/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-20T20:14:15Z", "updated_at": "2017-06-20T20:14:15Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9814", "html_url": "https://github.com/electron/electron/pull/9814", "diff_url": "https://github.com/electron/electron/pull/9814.diff", "patch_url": "https://github.com/electron/electron/pull/9814.patch" }, "body": "Fixes #8166 \r\nSet Resizable to `false` on `windowWillEnterFullScreen` function and restore it in `windowDidExitFullScreen` function." }, { "url": "https://api.github.com/repos/electron/electron/issues/9813", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9813/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9813/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9813/events", "html_url": "https://github.com/electron/electron/issues/9813", "id": 237326092, "number": 9813, "title": "[Question] Change app version.", "user": { "login": "cumajkeee", "id": 1834053, "avatar_url": "https://avatars0.githubusercontent.com/u/1834053?v=3", "gravatar_id": "", "url": "https://api.github.com/users/cumajkeee", "html_url": "https://github.com/cumajkeee", "followers_url": "https://api.github.com/users/cumajkeee/followers", "following_url": "https://api.github.com/users/cumajkeee/following{/other_user}", "gists_url": "https://api.github.com/users/cumajkeee/gists{/gist_id}", "starred_url": "https://api.github.com/users/cumajkeee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cumajkeee/subscriptions", "organizations_url": "https://api.github.com/users/cumajkeee/orgs", "repos_url": "https://api.github.com/users/cumajkeee/repos", "events_url": "https://api.github.com/users/cumajkeee/events{/privacy}", "received_events_url": "https://api.github.com/users/cumajkeee/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-20T19:54:06Z", "updated_at": "2017-06-21T03:09:06Z", "closed_at": "2017-06-21T03:09:06Z", "body": "Hey guys, I'd like to have ability to manually and permanently change app version (app.getVersion). \r\n\r\nTried to change in package.json (/.app/Content/Resources/app.asar.unpacked) and Info.plist (/.app/Contents) without luck, it still return app version that was set on build stage (electron-builder).\r\n\r\nIs it possible?\r\nThanks." }, { "url": "https://api.github.com/repos/electron/electron/issues/9812", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9812/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9812/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9812/events", "html_url": "https://github.com/electron/electron/issues/9812", "id": 237313548, "number": 9812, "title": "chrome is not defined", "user": { "login": "doanchu", "id": 4613000, "avatar_url": "https://avatars1.githubusercontent.com/u/4613000?v=3", "gravatar_id": "", "url": "https://api.github.com/users/doanchu", "html_url": "https://github.com/doanchu", "followers_url": "https://api.github.com/users/doanchu/followers", "following_url": "https://api.github.com/users/doanchu/following{/other_user}", "gists_url": "https://api.github.com/users/doanchu/gists{/gist_id}", "starred_url": "https://api.github.com/users/doanchu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/doanchu/subscriptions", "organizations_url": "https://api.github.com/users/doanchu/orgs", "repos_url": "https://api.github.com/users/doanchu/repos", "events_url": "https://api.github.com/users/doanchu/events{/privacy}", "received_events_url": "https://api.github.com/users/doanchu/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-20T19:07:35Z", "updated_at": "2017-06-21T03:08:45Z", "closed_at": "2017-06-21T03:08:45Z", "body": "* Electron version: 1.6.1\r\n* Operating system: Windows 10 64 bit\r\n\r\n### Expected behavior\r\n\r\nwindow.chrome should not be undefined\r\n\r\n### Actual behavior\r\n\r\nwindow.chrome is indeed undefined. \r\nI wanted to use some of the supported chrome.* APIs but when I tried to access window.chrome, this object is undefined.\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9811", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9811/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9811/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9811/events", "html_url": "https://github.com/electron/electron/issues/9811", "id": 237272865, "number": 9811, "title": "Webview + executeJavaScript + nodeintegration", "user": { "login": "paul321", "id": 555502, "avatar_url": "https://avatars0.githubusercontent.com/u/555502?v=3", "gravatar_id": "", "url": "https://api.github.com/users/paul321", "html_url": "https://github.com/paul321", "followers_url": "https://api.github.com/users/paul321/followers", "following_url": "https://api.github.com/users/paul321/following{/other_user}", "gists_url": "https://api.github.com/users/paul321/gists{/gist_id}", "starred_url": "https://api.github.com/users/paul321/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paul321/subscriptions", "organizations_url": "https://api.github.com/users/paul321/orgs", "repos_url": "https://api.github.com/users/paul321/repos", "events_url": "https://api.github.com/users/paul321/events{/privacy}", "received_events_url": "https://api.github.com/users/paul321/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-20T16:34:45Z", "updated_at": "2017-06-20T16:45:07Z", "closed_at": null, "body": "* Electron version: 1.7.3\r\n* Operating system: MacOS\r\n\r\nWe are trying to load a remote page in webview container, the problem is when the webview has nodeintegration on the webview freezes for 30 seconds when the executJavaScript is called also the webview devtools are blank. Is this a known issue? " }, { "url": "https://api.github.com/repos/electron/electron/issues/9810", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9810/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9810/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9810/events", "html_url": "https://github.com/electron/electron/pull/9810", "id": 237254781, "number": 9810, "title": "Fix dialog access from a renderer process", "user": { "login": "Tazeg", "id": 6105535, "avatar_url": "https://avatars0.githubusercontent.com/u/6105535?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Tazeg", "html_url": "https://github.com/Tazeg", "followers_url": "https://api.github.com/users/Tazeg/followers", "following_url": "https://api.github.com/users/Tazeg/following{/other_user}", "gists_url": "https://api.github.com/users/Tazeg/gists{/gist_id}", "starred_url": "https://api.github.com/users/Tazeg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Tazeg/subscriptions", "organizations_url": "https://api.github.com/users/Tazeg/orgs", "repos_url": "https://api.github.com/users/Tazeg/repos", "events_url": "https://api.github.com/users/Tazeg/events{/privacy}", "received_events_url": "https://api.github.com/users/Tazeg/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-20T15:35:31Z", "updated_at": "2017-06-20T15:40:08Z", "closed_at": "2017-06-20T15:40:08Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9810", "html_url": "https://github.com/electron/electron/pull/9810", "diff_url": "https://github.com/electron/electron/pull/9810.diff", "patch_url": "https://github.com/electron/electron/pull/9810.patch" }, "body": "" }, { "url": "https://api.github.com/repos/electron/electron/issues/9809", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9809/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9809/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9809/events", "html_url": "https://github.com/electron/electron/pull/9809", "id": 237231603, "number": 9809, "title": "Fix #9231: Don't attemt to load url when detached.", "user": { "login": "ferreus", "id": 206508, "avatar_url": "https://avatars0.githubusercontent.com/u/206508?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ferreus", "html_url": "https://github.com/ferreus", "followers_url": "https://api.github.com/users/ferreus/followers", "following_url": "https://api.github.com/users/ferreus/following{/other_user}", "gists_url": "https://api.github.com/users/ferreus/gists{/gist_id}", "starred_url": "https://api.github.com/users/ferreus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ferreus/subscriptions", "organizations_url": "https://api.github.com/users/ferreus/orgs", "repos_url": "https://api.github.com/users/ferreus/repos", "events_url": "https://api.github.com/users/ferreus/events{/privacy}", "received_events_url": "https://api.github.com/users/ferreus/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-20T14:32:24Z", "updated_at": "2017-06-21T11:54:46Z", "closed_at": "2017-06-21T11:54:46Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9809", "html_url": "https://github.com/electron/electron/pull/9809", "diff_url": "https://github.com/electron/electron/pull/9809.diff", "patch_url": "https://github.com/electron/electron/pull/9809.patch" }, "body": "I tracked down this crash to https://chromium.googlesource.com/experimental/chromium/src/+/58.0.3029.110/content/browser/browser_plugin/browser_plugin_guest.h#153\r\n```\r\nWebContentsImpl* embedder_web_contents() const {\r\n return attached_ ? owner_web_contents_ : nullptr;\r\n}\r\n```\r\n\r\nWhich results in null pointer access on LoadURL when the view is hidden (Because it's detached).\r\nThis is actually not a matter of race condition. As it's simply enough to hide the webview, then issue LoadURL to crash it.\r\n\r\nThis will avoid the crash by simply refusing to navigate when the view is not attached." }, { "url": "https://api.github.com/repos/electron/electron/issues/9808", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9808/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9808/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9808/events", "html_url": "https://github.com/electron/electron/pull/9808", "id": 237230723, "number": 9808, "title": "Remove `bash` from windows commands to stop syntax highlighting errors", "user": { "login": "Gryff", "id": 3209691, "avatar_url": "https://avatars1.githubusercontent.com/u/3209691?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Gryff", "html_url": "https://github.com/Gryff", "followers_url": "https://api.github.com/users/Gryff/followers", "following_url": "https://api.github.com/users/Gryff/following{/other_user}", "gists_url": "https://api.github.com/users/Gryff/gists{/gist_id}", "starred_url": "https://api.github.com/users/Gryff/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Gryff/subscriptions", "organizations_url": "https://api.github.com/users/Gryff/orgs", "repos_url": "https://api.github.com/users/Gryff/repos", "events_url": "https://api.github.com/users/Gryff/events{/privacy}", "received_events_url": "https://api.github.com/users/Gryff/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-20T14:30:04Z", "updated_at": "2017-06-20T16:49:08Z", "closed_at": "2017-06-20T16:48:59Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9808", "html_url": "https://github.com/electron/electron/pull/9808", "diff_url": "https://github.com/electron/electron/pull/9808.diff", "patch_url": "https://github.com/electron/electron/pull/9808.patch" }, "body": "Documentation only\r\n[ci skip]\r\n\r\nWhen referenced as a bash script this displays with what looks like escaped characters: \r\n![image](https://user-images.githubusercontent.com/3209691/27338580-88cc056c-55cd-11e7-8622-9e378a54e993.png)\r\n\r\nAfter removing the `bash` from code snippet it looks like this:\r\n![image](https://user-images.githubusercontent.com/3209691/27338644-af2ead36-55cd-11e7-9a21-36e5aa9d88dd.png)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9807", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9807/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9807/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9807/events", "html_url": "https://github.com/electron/electron/issues/9807", "id": 237225198, "number": 9807, "title": "Cookies from webview do not persist when the app is restarted.", "user": { "login": "paul321", "id": 555502, "avatar_url": "https://avatars0.githubusercontent.com/u/555502?v=3", "gravatar_id": "", "url": "https://api.github.com/users/paul321", "html_url": "https://github.com/paul321", "followers_url": "https://api.github.com/users/paul321/followers", "following_url": "https://api.github.com/users/paul321/following{/other_user}", "gists_url": "https://api.github.com/users/paul321/gists{/gist_id}", "starred_url": "https://api.github.com/users/paul321/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paul321/subscriptions", "organizations_url": "https://api.github.com/users/paul321/orgs", "repos_url": "https://api.github.com/users/paul321/repos", "events_url": "https://api.github.com/users/paul321/events{/privacy}", "received_events_url": "https://api.github.com/users/paul321/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-20T14:15:35Z", "updated_at": "2017-06-22T12:10:50Z", "closed_at": null, "body": "* Electron version: 1.7.3\r\n* Operating system: MacOS, Windows\r\n\r\nIn our app cookies that comes from viewview using defaultSession do not persist when the app is restarted, also devtools stores the cookies under file:// and when the app is restarted we do not see anything in cookies file:// \r\n\r\nExpected behavior is for cookies that share defaultSession and from webview to persist across app restarts and we need to see cookies that were saved with ajax requests which doesn't happen.\r\n\r\nAre we doing something wrong with the webviews?\r\n\r\nThanks" }, { "url": "https://api.github.com/repos/electron/electron/issues/9806", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9806/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9806/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9806/events", "html_url": "https://github.com/electron/electron/pull/9806", "id": 237219917, "number": 9806, "title": "Fix #9231: Don't attemt to load url when detached.", "user": { "login": "ferreus", "id": 206508, "avatar_url": "https://avatars0.githubusercontent.com/u/206508?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ferreus", "html_url": "https://github.com/ferreus", "followers_url": "https://api.github.com/users/ferreus/followers", "following_url": "https://api.github.com/users/ferreus/following{/other_user}", "gists_url": "https://api.github.com/users/ferreus/gists{/gist_id}", "starred_url": "https://api.github.com/users/ferreus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ferreus/subscriptions", "organizations_url": "https://api.github.com/users/ferreus/orgs", "repos_url": "https://api.github.com/users/ferreus/repos", "events_url": "https://api.github.com/users/ferreus/events{/privacy}", "received_events_url": "https://api.github.com/users/ferreus/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-20T14:00:53Z", "updated_at": "2017-06-20T14:23:32Z", "closed_at": "2017-06-20T14:23:32Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9806", "html_url": "https://github.com/electron/electron/pull/9806", "diff_url": "https://github.com/electron/electron/pull/9806.diff", "patch_url": "https://github.com/electron/electron/pull/9806.patch" }, "body": "I tracked down this crash to https://chromium.googlesource.com/experimental/chromium/src/+/58.0.3029.110/content/browser/browser_plugin/browser_plugin_guest.h#153\r\n```\r\nWebContentsImpl* embedder_web_contents() const {\r\n return attached_ ? owner_web_contents_ : nullptr;\r\n}\r\n```\r\n\r\nWhich results in null pointer access on LoadURL when the view is hidden (Because it's detached).\r\nThis is actually not a matter of race condition. As it's simply enough to hide the webview, then issue LoadURL to crash it.\r\n\r\nThis will avoid the crash by simply refusing to navigate when the view is not attached." }, { "url": "https://api.github.com/repos/electron/electron/issues/9805", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9805/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9805/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9805/events", "html_url": "https://github.com/electron/electron/issues/9805", "id": 237081162, "number": 9805, "title": "Device Emulation Disabled after Opening/Closing Devtools", "user": { "login": "4eveRS", "id": 4212200, "avatar_url": "https://avatars0.githubusercontent.com/u/4212200?v=3", "gravatar_id": "", "url": "https://api.github.com/users/4eveRS", "html_url": "https://github.com/4eveRS", "followers_url": "https://api.github.com/users/4eveRS/followers", "following_url": "https://api.github.com/users/4eveRS/following{/other_user}", "gists_url": "https://api.github.com/users/4eveRS/gists{/gist_id}", "starred_url": "https://api.github.com/users/4eveRS/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/4eveRS/subscriptions", "organizations_url": "https://api.github.com/users/4eveRS/orgs", "repos_url": "https://api.github.com/users/4eveRS/repos", "events_url": "https://api.github.com/users/4eveRS/events{/privacy}", "received_events_url": "https://api.github.com/users/4eveRS/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-20T03:14:21Z", "updated_at": "2017-06-20T03:14:21Z", "closed_at": null, "body": "* Electron version: 1.6.11\r\n* Operating system: MacOS 10.12.5\r\n\r\n### Expected behavior\r\n\r\n\r\n\r\nDevice emulation should be kept active independently of toggling the webview devtools.\r\n\r\n### Actual behavior\r\n\r\n\r\n\r\nIf you define a device emulation before opening the webview devtools, it will be automatically disabled, the same will happen if you close the devtools, it will disable the device emulation.\r\n\r\n### Partial Fix\r\n\r\nWhat I did to partially fix it, was define a listener to when the user close the devtools, to set the device emulation back, and, when the user opens the devtools I set the device emulation again, after calling the function for opening the devtools.\r\n\r\nIt's far from a perfect solution, since the webview keeps blinking, because of the change on the width and height." }, { "url": "https://api.github.com/repos/electron/electron/issues/9804", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9804/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9804/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9804/events", "html_url": "https://github.com/electron/electron/issues/9804", "id": 237048988, "number": 9804, "title": "Difference between webview.executeJavaScript and webview.getWebContents().executeJavaScript.", "user": { "login": "MaharishiCanada", "id": 5099917, "avatar_url": "https://avatars0.githubusercontent.com/u/5099917?v=3", "gravatar_id": "", "url": "https://api.github.com/users/MaharishiCanada", "html_url": "https://github.com/MaharishiCanada", "followers_url": "https://api.github.com/users/MaharishiCanada/followers", "following_url": "https://api.github.com/users/MaharishiCanada/following{/other_user}", "gists_url": "https://api.github.com/users/MaharishiCanada/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaharishiCanada/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaharishiCanada/subscriptions", "organizations_url": "https://api.github.com/users/MaharishiCanada/orgs", "repos_url": "https://api.github.com/users/MaharishiCanada/repos", "events_url": "https://api.github.com/users/MaharishiCanada/events{/privacy}", "received_events_url": "https://api.github.com/users/MaharishiCanada/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-19T23:11:05Z", "updated_at": "2017-06-20T14:31:06Z", "closed_at": "2017-06-20T14:31:06Z", "body": "\r\n\r\n* Electron version: 1.7.3\r\n* Operating system: Ubuntu 16.10\r\n\r\nI installed electron-quick-start and changed the electron dependency to 1.7.3. I only modified the index.html file:\r\n``` html\r\n\r\n \r\n \r\n Hello World!\r\n \r\n \r\n \r\n \r\n \r\n\r\n```\r\n### Expected behavior\r\n\r\nI expected to get an alert `foo` and `foo`in the console. I also uncommented the line\r\n``` javascript\r\nwebview.getWebContents().executeJavaScript(`var a = 'foo'; alert(a); Promise.resolve(a);`)\r\n```\r\nand commented out \r\n``` javascript\r\nwebview.executeJavaScript(`var a = 'foo'; alert(a); Promise.resolve(a);`)\r\n```\r\nI expected the same result. \r\n\r\n### Actual behavior\r\n\r\nIn the first case, without `getWebContents()`, I got the alert as expected, but the following error message in the console: \r\n>Uncaught TypeError: Cannot read property 'then' of undefined\r\n\r\nWhereas, in the second case, with `getWebContents()`, I got both the the alert `foo` and `foo` in the console. \r\n\r\nThis may actually be only a documentation issue. It just that when I look at the documentation, there is little indication why `executeJavaScript` on a `webview` tag Vs on the `webContents` of this webview, should behave differently. " }, { "url": "https://api.github.com/repos/electron/electron/issues/9803", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9803/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9803/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9803/events", "html_url": "https://github.com/electron/electron/issues/9803", "id": 237042209, "number": 9803, "title": "WebGL does not work with --disable-gpu", "user": { "login": "darshanrajani", "id": 29147479, "avatar_url": "https://avatars0.githubusercontent.com/u/29147479?v=3", "gravatar_id": "", "url": "https://api.github.com/users/darshanrajani", "html_url": "https://github.com/darshanrajani", "followers_url": "https://api.github.com/users/darshanrajani/followers", "following_url": "https://api.github.com/users/darshanrajani/following{/other_user}", "gists_url": "https://api.github.com/users/darshanrajani/gists{/gist_id}", "starred_url": "https://api.github.com/users/darshanrajani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/darshanrajani/subscriptions", "organizations_url": "https://api.github.com/users/darshanrajani/orgs", "repos_url": "https://api.github.com/users/darshanrajani/repos", "events_url": "https://api.github.com/users/darshanrajani/events{/privacy}", "received_events_url": "https://api.github.com/users/darshanrajani/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-19T22:29:20Z", "updated_at": "2017-06-19T22:33:49Z", "closed_at": null, "body": "* Electron version: 1.7.0\r\n* Operating system: Windows Server 2008 R2\r\n\r\n### Expected behavior\r\n\r\nWebGL should work even if --disable-gpu is used by using software-based rendering. Works when Chrome is launched with --disable-gpu\r\n\r\n### Actual behavior\r\n\r\nWebGL context creation fails.\r\n\r\n### How to reproduce\r\n\r\nClone https://github.com/zcbenz/nw-sample-apps and run the app which is under webgl directory.\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9802", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9802/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9802/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9802/events", "html_url": "https://github.com/electron/electron/issues/9802", "id": 236981373, "number": 9802, "title": "Enabling background sync in electron", "user": { "login": "anilshanbhag", "id": 703656, "avatar_url": "https://avatars3.githubusercontent.com/u/703656?v=3", "gravatar_id": "", "url": "https://api.github.com/users/anilshanbhag", "html_url": "https://github.com/anilshanbhag", "followers_url": "https://api.github.com/users/anilshanbhag/followers", "following_url": "https://api.github.com/users/anilshanbhag/following{/other_user}", "gists_url": "https://api.github.com/users/anilshanbhag/gists{/gist_id}", "starred_url": "https://api.github.com/users/anilshanbhag/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anilshanbhag/subscriptions", "organizations_url": "https://api.github.com/users/anilshanbhag/orgs", "repos_url": "https://api.github.com/users/anilshanbhag/repos", "events_url": "https://api.github.com/users/anilshanbhag/events{/privacy}", "received_events_url": "https://api.github.com/users/anilshanbhag/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-19T18:35:42Z", "updated_at": "2017-06-23T03:53:39Z", "closed_at": "2017-06-23T03:53:39Z", "body": "Electron has background sync disabled. Background sync is used to trigger the service worker to sync changes. It helps to sync work which was done by user when he was offline. Would be good to enable it by default. It is enabled by default in chromium and chrome. \r\n\r\n* Electron version: 1.6.11\r\n* Operating system: Mac OS, Linux\r\n\r\n### Expected behavior\r\n\r\nOn page with service worker registered, this snippet should produce no errors.\r\n\r\n```\r\nnavigator.serviceWorker.ready.then(function(swRegistration) {\r\n return swRegistration.sync.register('myFirstSync');\r\n});\r\n```\r\n\r\n### Actual behavior\r\n\r\nWhen run with electron, I get \r\n```\r\nUncaught (in promise) DOMException: Background Sync is disabled.\r\n```\r\n\r\n### How to reproduce\r\n\r\nOpen youtube.com with electron \r\n\r\nOR\r\n\r\n```\r\ngit clone https://github.com/hokein/electron-sample-apps\r\ncd electron-sample-apps\r\nnpm install -g electron\r\nelectron service-worker/mock-response\r\n```\r\n\r\nOpen the console and type in the snippet:\r\n\r\n```\r\nnavigator.serviceWorker.ready.then(function(swRegistration) {\r\n return swRegistration.sync.register('myFirstSync');\r\n});\r\n```\r\n\r\nIt gives the error in electron. Use the same snippet in youtube on the browser, it runs fine.\r\n\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9801", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9801/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9801/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9801/events", "html_url": "https://github.com/electron/electron/pull/9801", "id": 236952115, "number": 9801, "title": "atom@github.com -> electron@github.com", "user": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-19T16:43:32Z", "updated_at": "2017-06-20T03:45:53Z", "closed_at": "2017-06-20T03:45:46Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9801", "html_url": "https://github.com/electron/electron/pull/9801", "diff_url": "https://github.com/electron/electron/pull/9801.diff", "patch_url": "https://github.com/electron/electron/pull/9801.patch" }, "body": "This PR updates various docs to point to the (not very) new electron@github.com support email address." }, { "url": "https://api.github.com/repos/electron/electron/issues/9800", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9800/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9800/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9800/events", "html_url": "https://github.com/electron/electron/pull/9800", "id": 236935506, "number": 9800, "title": "fix typo in linux build instructions", "user": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-19T15:45:57Z", "updated_at": "2017-06-26T05:36:48Z", "closed_at": "2017-06-19T20:20:59Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9800", "html_url": "https://github.com/electron/electron/pull/9800", "diff_url": "https://github.com/electron/electron/pull/9800.diff", "patch_url": "https://github.com/electron/electron/pull/9800.patch" }, "body": "Found by @Toinane while translating docs to French." }, { "url": "https://api.github.com/repos/electron/electron/issues/9799", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9799/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9799/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9799/events", "html_url": "https://github.com/electron/electron/issues/9799", "id": 236905554, "number": 9799, "title": "Requiring native modules fails when using nativeWindowOpen & contextIsolation", "user": { "login": "Thomas101", "id": 103586, "avatar_url": "https://avatars3.githubusercontent.com/u/103586?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Thomas101", "html_url": "https://github.com/Thomas101", "followers_url": "https://api.github.com/users/Thomas101/followers", "following_url": "https://api.github.com/users/Thomas101/following{/other_user}", "gists_url": "https://api.github.com/users/Thomas101/gists{/gist_id}", "starred_url": "https://api.github.com/users/Thomas101/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Thomas101/subscriptions", "organizations_url": "https://api.github.com/users/Thomas101/orgs", "repos_url": "https://api.github.com/users/Thomas101/repos", "events_url": "https://api.github.com/users/Thomas101/events{/privacy}", "received_events_url": "https://api.github.com/users/Thomas101/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-19T14:15:48Z", "updated_at": "2017-06-19T14:15:48Z", "closed_at": null, "body": "* Electron version: 1.7.3\r\n* Operating system: macOS 10.12.5\r\n\r\n### Expected behavior\r\n\r\nWhen you have the following set in webPreferences...\r\n\r\n```js\r\ncontextIsolation: true,\r\nnativeWindowOpen: true,\r\nnodeIntegration: true,\r\npreload: 'preload.js'\r\n```\r\n\r\nand the preload script uses `require` on a native module (e.g. [node-spellchecker](https://github.com/atom/node-spellchecker)), it should load in the main browser window and also in any subsequently created popout windows\r\n\r\n### Actual behavior\r\n\r\nIt loads correctly in the main window. Popout windows complain that the module did not self register\r\n\r\n![screen shot 2017-06-19 at 15 12 52](https://user-images.githubusercontent.com/103586/27289432-d0c71586-5501-11e7-8bf8-aa3a26561902.png)\r\n\r\n\r\n### How to reproduce\r\n\r\n```\r\ngit clone https://github.com/wavebox/electron-quick-start.git\r\ncd electron-quick-start\r\ngit checkout native_require_bug\r\nnpm install\r\nnpm start\r\n```\r\nIn the window that opens, press the `New Window` link\r\n\r\n### Other Info\r\n\r\nIf you remove `contextIsolation` it works as expected. I suspect this is because both browser windows have the same `process.pid` but they do not share the cached module that was required in the first browser window" }, { "url": "https://api.github.com/repos/electron/electron/issues/9798", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9798/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9798/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9798/events", "html_url": "https://github.com/electron/electron/pull/9798", "id": 236877174, "number": 9798, "title": "Fix invisible titlebar on macOS 10.13", "user": { "login": "tonyganch", "id": 872004, "avatar_url": "https://avatars0.githubusercontent.com/u/872004?v=3", "gravatar_id": "", "url": "https://api.github.com/users/tonyganch", "html_url": "https://github.com/tonyganch", "followers_url": "https://api.github.com/users/tonyganch/followers", "following_url": "https://api.github.com/users/tonyganch/following{/other_user}", "gists_url": "https://api.github.com/users/tonyganch/gists{/gist_id}", "starred_url": "https://api.github.com/users/tonyganch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tonyganch/subscriptions", "organizations_url": "https://api.github.com/users/tonyganch/orgs", "repos_url": "https://api.github.com/users/tonyganch/repos", "events_url": "https://api.github.com/users/tonyganch/events{/privacy}", "received_events_url": "https://api.github.com/users/tonyganch/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-19T12:38:34Z", "updated_at": "2017-06-22T21:27:30Z", "closed_at": "2017-06-22T21:27:23Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9798", "html_url": "https://github.com/electron/electron/pull/9798", "diff_url": "https://github.com/electron/electron/pull/9798.diff", "patch_url": "https://github.com/electron/electron/pull/9798.patch" }, "body": "Should fix #9711.\r\nFrom https://developer.apple.com/library/content/releasenotes/AppKit/RN-AppKit/index.html:\r\n\r\n> Previously NSWindow would make the titlebar transparent for certain windows with NSWindowStyleMaskTexturedBackground set, even if titlebarAppearsTransparent was NO. When linking against the 10.13 SDK, textured windows must explicitly set titlebarAppearsTransparent to YES for this behavior.\r\n\r\nI checked the behaviour on 10.12 and 10.13.\r\nAre there any possible downsides on 10.12 i don't see?\r\n\r\n/cc @poiru " }, { "url": "https://api.github.com/repos/electron/electron/issues/9797", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9797/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9797/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9797/events", "html_url": "https://github.com/electron/electron/issues/9797", "id": 236853946, "number": 9797, "title": "Tray icon context menu strange behavior", "user": { "login": "doonay21", "id": 5584647, "avatar_url": "https://avatars0.githubusercontent.com/u/5584647?v=3", "gravatar_id": "", "url": "https://api.github.com/users/doonay21", "html_url": "https://github.com/doonay21", "followers_url": "https://api.github.com/users/doonay21/followers", "following_url": "https://api.github.com/users/doonay21/following{/other_user}", "gists_url": "https://api.github.com/users/doonay21/gists{/gist_id}", "starred_url": "https://api.github.com/users/doonay21/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/doonay21/subscriptions", "organizations_url": "https://api.github.com/users/doonay21/orgs", "repos_url": "https://api.github.com/users/doonay21/repos", "events_url": "https://api.github.com/users/doonay21/events{/privacy}", "received_events_url": "https://api.github.com/users/doonay21/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-19T11:01:00Z", "updated_at": "2017-06-19T12:19:57Z", "closed_at": null, "body": "* Electron version: 1.7.3\r\n* Operating system: Windows 10 Pro 64-bit\r\n\r\n![wrong](https://user-images.githubusercontent.com/5584647/27281050-93071154-54ea-11e7-9d9d-8461157fef84.gif)\r\n\r\nRight clicking on Tray Icon causes Windows native menu pop up covering menu from my app. It is important that Windows taskbar should not be focused, when it is focused everything work as expected.\r\n\r\n### Expected behavior\r\n\r\nOnly context menu of my application should open.\r\n\r\n### Actual behavior\r\n\r\nWindows native context menu (the same menu when right clicking Windows taskbar) pops up covering menu from electron application.\r\n\r\n### How to reproduce\r\n\r\n1. `git clone https://github.com/doonay21/electron-quick-start.git`\r\n2. `cd electron-quick-start`\r\n3. `electron .`\r\n4. Click anywhere but Windows taskbar\r\n5. Right click on tray icon\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9796", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9796/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9796/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9796/events", "html_url": "https://github.com/electron/electron/issues/9796", "id": 236845576, "number": 9796, "title": "how can i intercept some http request fallback to custom file", "user": { "login": "hibin101", "id": 750146, "avatar_url": "https://avatars0.githubusercontent.com/u/750146?v=3", "gravatar_id": "", "url": "https://api.github.com/users/hibin101", "html_url": "https://github.com/hibin101", "followers_url": "https://api.github.com/users/hibin101/followers", "following_url": "https://api.github.com/users/hibin101/following{/other_user}", "gists_url": "https://api.github.com/users/hibin101/gists{/gist_id}", "starred_url": "https://api.github.com/users/hibin101/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hibin101/subscriptions", "organizations_url": "https://api.github.com/users/hibin101/orgs", "repos_url": "https://api.github.com/users/hibin101/repos", "events_url": "https://api.github.com/users/hibin101/events{/privacy}", "received_events_url": "https://api.github.com/users/hibin101/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-19T10:24:57Z", "updated_at": "2017-06-20T02:11:57Z", "closed_at": "2017-06-19T10:26:32Z", "body": "i use win.loadURL('http://example.com/index.html') to load a page，and i want to intercept this request\r\nfallback to custom file like:\r\nprotocol.interceptStringProtocol('http', (request, callback) => {\r\n ...\r\n callback({\r\n data: fs.readFileSync(path.normalize(`${__dirname}/index.html`), 'utf-8')\r\n })\r\n})\r\n\r\nthis will intercept all http request from this page，how can i do only intercept some http request\r\n\r\n\r\n\r\n* Electron version:\r\n* Operating system:\r\n\r\n### Expected behavior\r\n\r\n\r\n\r\n### Actual behavior\r\n\r\n\r\n\r\n### How to reproduce\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9795", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9795/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9795/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9795/events", "html_url": "https://github.com/electron/electron/issues/9795", "id": 236829684, "number": 9795, "title": "Uncaught Exception: TypeError: Error processing argument at index 0, conversion failure from file:///root/doc_electron/chef.ico", "user": { "login": "zombieleet", "id": 14893363, "avatar_url": "https://avatars2.githubusercontent.com/u/14893363?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zombieleet", "html_url": "https://github.com/zombieleet", "followers_url": "https://api.github.com/users/zombieleet/followers", "following_url": "https://api.github.com/users/zombieleet/following{/other_user}", "gists_url": "https://api.github.com/users/zombieleet/gists{/gist_id}", "starred_url": "https://api.github.com/users/zombieleet/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zombieleet/subscriptions", "organizations_url": "https://api.github.com/users/zombieleet/orgs", "repos_url": "https://api.github.com/users/zombieleet/repos", "events_url": "https://api.github.com/users/zombieleet/events{/privacy}", "received_events_url": "https://api.github.com/users/zombieleet/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-19T09:26:16Z", "updated_at": "2017-06-19T13:34:48Z", "closed_at": "2017-06-19T12:05:49Z", "body": "Electron Version: 1.7.2\r\nOperating System: Linux 4.4.0-kali1-amd64 #1 SMP Debian 4.4.6-1kali1 (2016-03-18)\r\n\r\nAm currently following the electron documentation, but the Tray api is not working, it spits out this error\r\n\r\n**Uncaught Exception:\r\nTypeError: Error processing argument at index 0, conversion failure from file:///root/doc_electron/chef.ico\r\n at App.app.on (/root/doc_electron/tray.js:6:10)\r\n at emitTwo (events.js:111:20)\r\n at App.emit (events.js:194:7)**\r\n\r\nThis is the code\r\n\r\n```javascript\r\nconst { app, Menu, Tray } = require(\"electron\");\r\n\r\nlet tray ;\r\n\r\napp.on(\"ready\", () => {\r\n tray = new Tray(`${__dirname}/chef.ico`);\r\n const contextMenu = Menu.buildFromTemplate([\r\n {label: \"Item1\", type: \"radio\"},\r\n {lable: \"Item2\", type:\"radio\"},\r\n {label: \"Item4\", type: \"radio\"}\r\n ]);\r\n tray.setToolTip(\"This is my application.\");\r\n tray.setContextMenu(contextMenu);\r\n});\r\n```" }, { "url": "https://api.github.com/repos/electron/electron/issues/9794", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9794/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9794/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9794/events", "html_url": "https://github.com/electron/electron/issues/9794", "id": 236784167, "number": 9794, "title": "electron supports MOVE as drag&drop operation by default", "user": { "login": "ihalip", "id": 1991437, "avatar_url": "https://avatars2.githubusercontent.com/u/1991437?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ihalip", "html_url": "https://github.com/ihalip", "followers_url": "https://api.github.com/users/ihalip/followers", "following_url": "https://api.github.com/users/ihalip/following{/other_user}", "gists_url": "https://api.github.com/users/ihalip/gists{/gist_id}", "starred_url": "https://api.github.com/users/ihalip/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ihalip/subscriptions", "organizations_url": "https://api.github.com/users/ihalip/orgs", "repos_url": "https://api.github.com/users/ihalip/repos", "events_url": "https://api.github.com/users/ihalip/events{/privacy}", "received_events_url": "https://api.github.com/users/ihalip/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-19T05:33:15Z", "updated_at": "2017-06-19T05:33:15Z", "closed_at": null, "body": "* Electron version: 1.7.3\r\n* Operating system: Windows 7 64-bit\r\n\r\nInitially reported for VS Code: https://github.com/Microsoft/vscode/issues/25196\r\n\r\nWhen dragging and dropping from another application, the default operation is MOVE:\r\n![output](https://user-images.githubusercontent.com/1991437/27270663-95f90f42-54c8-11e7-89f0-4d9eeb4fe90c.gif)\r\n\r\nThis can have unintended side effects:\r\n- Windows Explorer: as per the original report, this can lead to the original file being deleted\r\n\r\n- Notepad++: you can drag&drop a piece of text from NPP to electron; the text is then deleted from NPP\r\n\r\n### Expected behavior\r\n\r\nThe default operation should be COPY (or LINK?).\r\n\r\n### Actual behavior\r\n\r\nThe default operation is MOVE.\r\n\r\n### How to reproduce\r\n\r\n1. Download & run the latest electron release (I used https://github.com/electron/electron/releases/download/v1.7.3/electron-v1.7.3-win32-x64.zip)\r\n\r\n2. Open an FTP location in Windows Explorer (I used ftp://test.rebex.net/pub/example/, user: demo, pass: password)\r\n\r\n3. Drag & drop a file from Windows Explorer to the electron window\r\n\r\n4. You should see a message box mentioning that the file could not be deleted from the server" }, { "url": "https://api.github.com/repos/electron/electron/issues/9793", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9793/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9793/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9793/events", "html_url": "https://github.com/electron/electron/issues/9793", "id": 236777032, "number": 9793, "title": "TS definition for ClearStorageDataOptions does not match docs", "user": { "login": "kevinphelps", "id": 7399499, "avatar_url": "https://avatars2.githubusercontent.com/u/7399499?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinphelps", "html_url": "https://github.com/kevinphelps", "followers_url": "https://api.github.com/users/kevinphelps/followers", "following_url": "https://api.github.com/users/kevinphelps/following{/other_user}", "gists_url": "https://api.github.com/users/kevinphelps/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinphelps/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinphelps/subscriptions", "organizations_url": "https://api.github.com/users/kevinphelps/orgs", "repos_url": "https://api.github.com/users/kevinphelps/repos", "events_url": "https://api.github.com/users/kevinphelps/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinphelps/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-19T04:23:54Z", "updated_at": "2017-06-19T04:48:32Z", "closed_at": "2017-06-19T04:47:16Z", "body": "* Electron version: 1.6.11\r\n* Operating system: Window\r\n\r\n### Expected behavior\r\nThe `origin`, `storages`, and `quotas` properties on the `Electron.ClearStorageDataOptions` interface should be options as specified in [the docs](https://github.com/electron/electron/blob/master/docs/api/session.md#sesclearstoragedataoptions-callback).\r\n\r\n![image](https://user-images.githubusercontent.com/7399499/27269479-e6d909c2-547c-11e7-973c-9172cda36816.png)\r\n\r\n### Actual behavior\r\n\r\nNone of the properties on `Electron.ClearStorageDataOptions` are optional in `electron.d.ts`.\r\n\r\n![image](https://user-images.githubusercontent.com/7399499/27269504-1b67f0d6-547d-11e7-809d-31a53e62f463.png)" }, { "url": "https://api.github.com/repos/electron/electron/issues/9792", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9792/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9792/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9792/events", "html_url": "https://github.com/electron/electron/issues/9792", "id": 236723905, "number": 9792, "title": "Electron Logo Usage (Documentation/Licence clarification)", "user": { "login": "stonegray", "id": 7140974, "avatar_url": "https://avatars2.githubusercontent.com/u/7140974?v=3", "gravatar_id": "", "url": "https://api.github.com/users/stonegray", "html_url": "https://github.com/stonegray", "followers_url": "https://api.github.com/users/stonegray/followers", "following_url": "https://api.github.com/users/stonegray/following{/other_user}", "gists_url": "https://api.github.com/users/stonegray/gists{/gist_id}", "starred_url": "https://api.github.com/users/stonegray/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stonegray/subscriptions", "organizations_url": "https://api.github.com/users/stonegray/orgs", "repos_url": "https://api.github.com/users/stonegray/repos", "events_url": "https://api.github.com/users/stonegray/events{/privacy}", "received_events_url": "https://api.github.com/users/stonegray/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 256494604, "url": "https://api.github.com/repos/electron/electron/labels/question", "name": "question", "color": "c7def8", "default": true } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-18T14:21:40Z", "updated_at": "2017-06-19T15:30:31Z", "closed_at": "2017-06-19T15:30:26Z", "body": "The licence appears to be written in such a way that it's unclear if we can use the Electron logo. \r\n\r\n> When using the Electron or other GitHub logos, be sure to follow the GitHub logo guidelines.\r\n\r\nHowever the [guideline documents](https://github.com/logos) only permit you to use the Github marks, and specifically ask you to contact them to use any other marks (which would include Electron)\r\n\r\nTo remove ambiguity, should we add our own logo usage policy for the Electron logo? Is this something Github should clarify?\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9791", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9791/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9791/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9791/events", "html_url": "https://github.com/electron/electron/issues/9791", "id": 236710553, "number": 9791, "title": "No LCD-text-antialiasing on macOS", "user": { "login": "vguerci", "id": 420745, "avatar_url": "https://avatars0.githubusercontent.com/u/420745?v=3", "gravatar_id": "", "url": "https://api.github.com/users/vguerci", "html_url": "https://github.com/vguerci", "followers_url": "https://api.github.com/users/vguerci/followers", "following_url": "https://api.github.com/users/vguerci/following{/other_user}", "gists_url": "https://api.github.com/users/vguerci/gists{/gist_id}", "starred_url": "https://api.github.com/users/vguerci/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vguerci/subscriptions", "organizations_url": "https://api.github.com/users/vguerci/orgs", "repos_url": "https://api.github.com/users/vguerci/repos", "events_url": "https://api.github.com/users/vguerci/events{/privacy}", "received_events_url": "https://api.github.com/users/vguerci/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-18T09:27:16Z", "updated_at": "2017-06-18T09:27:16Z", "closed_at": null, "body": "* Electron version: 1.6.9 (Latest Atom version, but also Slack, GitKraken have this issue)\r\n* Operating system: macOS Sierra 10.12.5 (Latest)\r\n\r\nNot much describe as I just noticed the exact same behaviour as #6344, but on macOS" }, { "url": "https://api.github.com/repos/electron/electron/issues/9790", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9790/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9790/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9790/events", "html_url": "https://github.com/electron/electron/issues/9790", "id": 236701635, "number": 9790, "title": "Running Changelog or History", "user": { "login": "gabrielcsapo", "id": 1854811, "avatar_url": "https://avatars3.githubusercontent.com/u/1854811?v=3", "gravatar_id": "", "url": "https://api.github.com/users/gabrielcsapo", "html_url": "https://github.com/gabrielcsapo", "followers_url": "https://api.github.com/users/gabrielcsapo/followers", "following_url": "https://api.github.com/users/gabrielcsapo/following{/other_user}", "gists_url": "https://api.github.com/users/gabrielcsapo/gists{/gist_id}", "starred_url": "https://api.github.com/users/gabrielcsapo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gabrielcsapo/subscriptions", "organizations_url": "https://api.github.com/users/gabrielcsapo/orgs", "repos_url": "https://api.github.com/users/gabrielcsapo/repos", "events_url": "https://api.github.com/users/gabrielcsapo/events{/privacy}", "received_events_url": "https://api.github.com/users/gabrielcsapo/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2017-06-18T05:30:11Z", "updated_at": "2017-06-19T03:43:30Z", "closed_at": null, "body": "I always wonder what the unreleased changes are in electron, but can never find a CHANGELOG or HISTORY file anywhere or on the site. \r\n\r\nIs this something that is kept internally or is there a way that it can be more transparent? \r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9789", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9789/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9789/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9789/events", "html_url": "https://github.com/electron/electron/issues/9789", "id": 236697580, "number": 9789, "title": "Fullscreen not working on Arch Linux", "user": { "login": "RickStanley", "id": 23178554, "avatar_url": "https://avatars3.githubusercontent.com/u/23178554?v=3", "gravatar_id": "", "url": "https://api.github.com/users/RickStanley", "html_url": "https://github.com/RickStanley", "followers_url": "https://api.github.com/users/RickStanley/followers", "following_url": "https://api.github.com/users/RickStanley/following{/other_user}", "gists_url": "https://api.github.com/users/RickStanley/gists{/gist_id}", "starred_url": "https://api.github.com/users/RickStanley/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RickStanley/subscriptions", "organizations_url": "https://api.github.com/users/RickStanley/orgs", "repos_url": "https://api.github.com/users/RickStanley/repos", "events_url": "https://api.github.com/users/RickStanley/events{/privacy}", "received_events_url": "https://api.github.com/users/RickStanley/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-18T03:20:41Z", "updated_at": "2017-06-21T02:30:22Z", "closed_at": "2017-06-21T02:30:22Z", "body": "\r\n### Code logic sample\r\nThis should get you an idea of what am I doing.\r\n``` javascript\r\n // Creating an array that will store a window instance\r\n var inSession = [],\r\n id = inSession.length - 1,\r\n isFullscreen;\r\n ...\r\n // win = new BrowserWindow();\r\n inSession[id] = win;\r\n if (id >= 0) {\r\n inSession.splice(id, 1);\r\n }\r\n id--;\r\n ...\r\n inSession[id + 1].setFullScreen(true);\r\n```\r\n### Expected behavior\r\n\r\nIt should go fullscreen when executed: `win.setFullScreen(true);`\r\nEven in the instance itself: `win = new BrowserWindow({fullScreen: true});`\r\nRegistered `globalShortcut` on Alt + Enter, should enable fullscreen. \r\n\r\nLog from `isFullScreen(); == true` every time.\r\n\r\n### Actual behavior\r\n\r\nNo fullscreen.\r\n\r\n### How to reproduce\r\n\r\n``` \r\n $ git clone https://github.com/RickStanley/Majoras_Clock.git\r\n $ cd Majoras_Clock\r\n $ npm install\r\n $ electron . \r\n```\r\nAlso try Alt + Enter.\r\n\r\n--------------------------\r\nIt was working before. After some updates it just broke, unfortunately I didn't keep track of the updates of Electron.\r\n\r\n* Electron version: v1.6.11\r\n* Operating system: Arch Linux (4.11.5-1-ARCH)\r\n* Desktop Environment: Deepin\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9788", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9788/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9788/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9788/events", "html_url": "https://github.com/electron/electron/pull/9788", "id": 236692851, "number": 9788, "title": "Add alwaysShowTitleTextInFullscreen flag", "user": { "login": "shubham2892", "id": 6316389, "avatar_url": "https://avatars1.githubusercontent.com/u/6316389?v=3", "gravatar_id": "", "url": "https://api.github.com/users/shubham2892", "html_url": "https://github.com/shubham2892", "followers_url": "https://api.github.com/users/shubham2892/followers", "following_url": "https://api.github.com/users/shubham2892/following{/other_user}", "gists_url": "https://api.github.com/users/shubham2892/gists{/gist_id}", "starred_url": "https://api.github.com/users/shubham2892/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shubham2892/subscriptions", "organizations_url": "https://api.github.com/users/shubham2892/orgs", "repos_url": "https://api.github.com/users/shubham2892/repos", "events_url": "https://api.github.com/users/shubham2892/events{/privacy}", "received_events_url": "https://api.github.com/users/shubham2892/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-18T00:54:36Z", "updated_at": "2017-06-26T20:58:59Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9788", "html_url": "https://github.com/electron/electron/pull/9788", "diff_url": "https://github.com/electron/electron/pull/9788.diff", "patch_url": "https://github.com/electron/electron/pull/9788.patch" }, "body": "Fixes #8126 \r\nAdd a flag `alwaysShowTitleTextInFullscreen` which enables to show title when `titleBarStyle` is set to `hiddenInset`. Default value is `false`. \r\n\r\nScreenshot with flag enabled:\r\n![image](https://user-images.githubusercontent.com/6316389/27257301-10f743f6-539f-11e7-812d-00a35e04a634.png)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9787", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9787/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9787/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9787/events", "html_url": "https://github.com/electron/electron/issues/9787", "id": 236664605, "number": 9787, "title": "App doesn't restart on relaunch() call", "user": { "login": "lonja", "id": 10297476, "avatar_url": "https://avatars0.githubusercontent.com/u/10297476?v=3", "gravatar_id": "", "url": "https://api.github.com/users/lonja", "html_url": "https://github.com/lonja", "followers_url": "https://api.github.com/users/lonja/followers", "following_url": "https://api.github.com/users/lonja/following{/other_user}", "gists_url": "https://api.github.com/users/lonja/gists{/gist_id}", "starred_url": "https://api.github.com/users/lonja/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lonja/subscriptions", "organizations_url": "https://api.github.com/users/lonja/orgs", "repos_url": "https://api.github.com/users/lonja/repos", "events_url": "https://api.github.com/users/lonja/events{/privacy}", "received_events_url": "https://api.github.com/users/lonja/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-17T14:47:41Z", "updated_at": "2017-06-17T14:53:13Z", "closed_at": null, "body": "* Electron version: 1.3.15\r\n* Operating system: Ubuntu 14.04\r\n\r\nThe following code only closes the app but not starts it again.\r\n```\r\nvar app = require('electron').remote.app;\r\napp.relaunch();\r\napp.quit();\r\n```\r\nHow can I restart the application on Ubuntu?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9786", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9786/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9786/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9786/events", "html_url": "https://github.com/electron/electron/issues/9786", "id": 236649902, "number": 9786, "title": "Dialog on macOs are different from native apps.", "user": { "login": "yolo2013", "id": 5243482, "avatar_url": "https://avatars2.githubusercontent.com/u/5243482?v=3", "gravatar_id": "", "url": "https://api.github.com/users/yolo2013", "html_url": "https://github.com/yolo2013", "followers_url": "https://api.github.com/users/yolo2013/followers", "following_url": "https://api.github.com/users/yolo2013/following{/other_user}", "gists_url": "https://api.github.com/users/yolo2013/gists{/gist_id}", "starred_url": "https://api.github.com/users/yolo2013/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yolo2013/subscriptions", "organizations_url": "https://api.github.com/users/yolo2013/orgs", "repos_url": "https://api.github.com/users/yolo2013/repos", "events_url": "https://api.github.com/users/yolo2013/events{/privacy}", "received_events_url": "https://api.github.com/users/yolo2013/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-17T09:18:28Z", "updated_at": "2017-06-17T09:22:15Z", "closed_at": "2017-06-17T09:20:58Z", "body": "* Electron version: 1.6.11\r\n* Operating system: macOs 10.12.5\r\n\r\nI opened an dialog to choose image for some reasons. But I found the dialog in electron is just show in the center of screen. Then I tried 3-4 apps like twitter. The animation of twitter's dialog is very beautiful.\r\nSomeone have the same problem?\r\n\r\n出于一些原因，我尝试在electron中选择本地文件。在开发过程中发现，electron中dialog的动画非常生硬，直接生硬地显示在屏幕中间。随后我测试了twitter、御饭等应用，发现这些应用的动画就非常自然。想确认下，有没有人和我存在同样的疑问？\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9785", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9785/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9785/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9785/events", "html_url": "https://github.com/electron/electron/issues/9785", "id": 236621397, "number": 9785, "title": "webview goes blank/black when using nativeWindowOpen option", "user": { "login": "snene", "id": 16089931, "avatar_url": "https://avatars1.githubusercontent.com/u/16089931?v=3", "gravatar_id": "", "url": "https://api.github.com/users/snene", "html_url": "https://github.com/snene", "followers_url": "https://api.github.com/users/snene/followers", "following_url": "https://api.github.com/users/snene/following{/other_user}", "gists_url": "https://api.github.com/users/snene/gists{/gist_id}", "starred_url": "https://api.github.com/users/snene/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/snene/subscriptions", "organizations_url": "https://api.github.com/users/snene/orgs", "repos_url": "https://api.github.com/users/snene/repos", "events_url": "https://api.github.com/users/snene/events{/privacy}", "received_events_url": "https://api.github.com/users/snene/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-16T23:32:04Z", "updated_at": "2017-06-20T05:06:12Z", "closed_at": null, "body": "Electron version: pre-release 1.7.3\r\n\r\nI am using useNativeWindowOpen option on a webview. Sometimes I see that when the page loaded in the webview calls window.open, a new popup window is created but the contents in the webview disappear and a black screen is seen in the webview. When you reload the contents by doing a refresh, the contents are restored again. This is not 100% reproducible and seen on both Mac and Windows platform. And this is not a crash either.\r\n\r\nSample code:\r\nMain.js\r\n\r\n```\r\nconst {app, BrowserWindow, ipcMain} = require(\"electron\")\r\nlet win = null\r\n\r\napp.on('ready', () => {\r\n win = new BrowserWindow({\r\n width: 800,\r\n height: 600\r\n });\r\napp.on('web-contents-created', (event, contents) => {\r\n if (contents.getType() === 'webview') {\r\n contents.on('new-window', (evt, url, frameName) => {\r\n if( ) {\r\n evt.preventDefault();\r\n }\r\n }\r\n}\r\nwin.loadURL('./MyWindow.html');\r\n win.on(\"closed\", () => {\r\n win = null\r\n});\r\n```\r\n\r\nMyWindow.html:\r\n```\r\n\r\n \r\n
\r\n \r\n
\r\n \r\n \r\n \r\n\r\n```\r\n\r\nClientShell.js\r\n```\r\nconst BrowserWindowR = require('electron').remote.BrowserWindow;\r\n\r\n webview.addEventListener('dom-ready', () => {\r\n webview.loadURL('Print.html');\r\n});\r\n```\r\n\r\nprint.html has code which opens new window as:\r\n\r\n```\r\nvar printWin = window.open(\"\", \"_blank\");\r\nprintWin.document.open();\r\nprintWin.document.write();\r\nprintWin.document.close();\r\n```\r\n```" }, { "url": "https://api.github.com/repos/electron/electron/issues/9784", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9784/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9784/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9784/events", "html_url": "https://github.com/electron/electron/pull/9784", "id": 236621034, "number": 9784, "title": "Add German translation for README and Contributor Covenant", "user": { "login": "calmandniceperson", "id": 5265630, "avatar_url": "https://avatars1.githubusercontent.com/u/5265630?v=3", "gravatar_id": "", "url": "https://api.github.com/users/calmandniceperson", "html_url": "https://github.com/calmandniceperson", "followers_url": "https://api.github.com/users/calmandniceperson/followers", "following_url": "https://api.github.com/users/calmandniceperson/following{/other_user}", "gists_url": "https://api.github.com/users/calmandniceperson/gists{/gist_id}", "starred_url": "https://api.github.com/users/calmandniceperson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/calmandniceperson/subscriptions", "organizations_url": "https://api.github.com/users/calmandniceperson/orgs", "repos_url": "https://api.github.com/users/calmandniceperson/repos", "events_url": "https://api.github.com/users/calmandniceperson/events{/privacy}", "received_events_url": "https://api.github.com/users/calmandniceperson/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 7, "created_at": "2017-06-16T23:28:44Z", "updated_at": "2017-06-17T00:55:22Z", "closed_at": "2017-06-16T23:32:14Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9784", "html_url": "https://github.com/electron/electron/pull/9784", "diff_url": "https://github.com/electron/electron/pull/9784.diff", "patch_url": "https://github.com/electron/electron/pull/9784.patch" }, "body": "This PR contains German translations for README and the Contributor Covenant (copied from [here](http://contributor-covenant.org/version/1/4/de/code_of_conduct.md)).\r\n\r\nEven though I'm not sure translations for the code of conduct are even supposed to exist for each language (since the other languages seemingly don't contain it), but there are translations of it freely available and I figured that it only made sense to allow *everyone* to understand how they are expected to behave when working on Electron." }, { "url": "https://api.github.com/repos/electron/electron/issues/9783", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9783/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9783/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9783/events", "html_url": "https://github.com/electron/electron/issues/9783", "id": 236610700, "number": 9783, "title": "globalShortcut key release", "user": { "login": "computerquip-streamlabs", "id": 25916193, "avatar_url": "https://avatars0.githubusercontent.com/u/25916193?v=3", "gravatar_id": "", "url": "https://api.github.com/users/computerquip-streamlabs", "html_url": "https://github.com/computerquip-streamlabs", "followers_url": "https://api.github.com/users/computerquip-streamlabs/followers", "following_url": "https://api.github.com/users/computerquip-streamlabs/following{/other_user}", "gists_url": "https://api.github.com/users/computerquip-streamlabs/gists{/gist_id}", "starred_url": "https://api.github.com/users/computerquip-streamlabs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/computerquip-streamlabs/subscriptions", "organizations_url": "https://api.github.com/users/computerquip-streamlabs/orgs", "repos_url": "https://api.github.com/users/computerquip-streamlabs/repos", "events_url": "https://api.github.com/users/computerquip-streamlabs/events{/privacy}", "received_events_url": "https://api.github.com/users/computerquip-streamlabs/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-16T22:10:05Z", "updated_at": "2017-06-16T22:15:05Z", "closed_at": "2017-06-16T22:15:05Z", "body": "I don't see a way to get a key release event in globalShortcut. This is problematic if an app wants something to happen only while a key is pressed (since we can't know when to stop). Am I missing something?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9782", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9782/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9782/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9782/events", "html_url": "https://github.com/electron/electron/pull/9782", "id": 236549514, "number": 9782, "title": "Change NSIS topic level from 2 to 3", "user": { "login": "jotafeldmann", "id": 1572665, "avatar_url": "https://avatars3.githubusercontent.com/u/1572665?v=3", "gravatar_id": "", "url": "https://api.github.com/users/jotafeldmann", "html_url": "https://github.com/jotafeldmann", "followers_url": "https://api.github.com/users/jotafeldmann/followers", "following_url": "https://api.github.com/users/jotafeldmann/following{/other_user}", "gists_url": "https://api.github.com/users/jotafeldmann/gists{/gist_id}", "starred_url": "https://api.github.com/users/jotafeldmann/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jotafeldmann/subscriptions", "organizations_url": "https://api.github.com/users/jotafeldmann/orgs", "repos_url": "https://api.github.com/users/jotafeldmann/repos", "events_url": "https://api.github.com/users/jotafeldmann/events{/privacy}", "received_events_url": "https://api.github.com/users/jotafeldmann/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-16T17:46:00Z", "updated_at": "2017-06-21T17:04:14Z", "closed_at": "2017-06-16T22:06:58Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9782", "html_url": "https://github.com/electron/electron/pull/9782", "diff_url": "https://github.com/electron/electron/pull/9782.diff", "patch_url": "https://github.com/electron/electron/pull/9782.patch" }, "body": "Why: this can mislead interpretation of the rest of the document. The `NSIS` is just one more topic at the same level of Process and Native Modules." }, { "url": "https://api.github.com/repos/electron/electron/issues/9781", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9781/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9781/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9781/events", "html_url": "https://github.com/electron/electron/issues/9781", "id": 236480631, "number": 9781, "title": "Unresponsive event never gets triggered when `show: false` on BrowserWindow", "user": { "login": "domderen", "id": 2360738, "avatar_url": "https://avatars1.githubusercontent.com/u/2360738?v=3", "gravatar_id": "", "url": "https://api.github.com/users/domderen", "html_url": "https://github.com/domderen", "followers_url": "https://api.github.com/users/domderen/followers", "following_url": "https://api.github.com/users/domderen/following{/other_user}", "gists_url": "https://api.github.com/users/domderen/gists{/gist_id}", "starred_url": "https://api.github.com/users/domderen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/domderen/subscriptions", "organizations_url": "https://api.github.com/users/domderen/orgs", "repos_url": "https://api.github.com/users/domderen/repos", "events_url": "https://api.github.com/users/domderen/events{/privacy}", "received_events_url": "https://api.github.com/users/domderen/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-16T13:18:59Z", "updated_at": "2017-06-16T13:18:59Z", "closed_at": null, "body": "* Electron version: 1.6.11 & 1.7.3\r\n* Operating system: macOS Sierra 10.12.5\r\n\r\n### Expected behavior\r\n\r\nBrowserWindow should emit `unresponsive` event when page becomes unresponsive. \r\n\r\n### Actual behavior\r\n\r\nBrowserWindow never emits `unresponsive` event.\r\n\r\n### How to reproduce\r\n\r\nExample of an issue: https://github.com/domderen/electron-quick-start/tree/unresponsive_issue\r\n\r\nThis code loads a page that runs an infinite loop in JS. This makes the browser unresponsive, and it is not possible to interact with such a window.\r\n\r\nWhen BrowserWindow is created with `show: true`, and user will try to interact with the window, it will fire the `unresponsive` event after some time.\r\n\r\nBut if the window is created with `show: false`, it is not possible to interact with the window, so `unresponsive` event never gets emitted. I tried calling `window.webContents.executeJavaScript` or using the ipcRenderer in hope that lack of response from one of those two would trigger the `unresponsive` event, but nothing worked.\r\n\r\nSo there doesn't seem to be a way to figure out that the window become unresponsive if it is not visible.\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9780", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9780/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9780/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9780/events", "html_url": "https://github.com/electron/electron/issues/9780", "id": 236478755, "number": 9780, "title": "Silent print does not use printer defaults", "user": { "login": "redloro", "id": 6530719, "avatar_url": "https://avatars0.githubusercontent.com/u/6530719?v=3", "gravatar_id": "", "url": "https://api.github.com/users/redloro", "html_url": "https://github.com/redloro", "followers_url": "https://api.github.com/users/redloro/followers", "following_url": "https://api.github.com/users/redloro/following{/other_user}", "gists_url": "https://api.github.com/users/redloro/gists{/gist_id}", "starred_url": "https://api.github.com/users/redloro/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/redloro/subscriptions", "organizations_url": "https://api.github.com/users/redloro/orgs", "repos_url": "https://api.github.com/users/redloro/repos", "events_url": "https://api.github.com/users/redloro/events{/privacy}", "received_events_url": "https://api.github.com/users/redloro/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-16T13:11:25Z", "updated_at": "2017-06-16T13:11:25Z", "closed_at": null, "body": "* Electron version: 1.7.3\r\n* Operating system: Debian\r\n\r\nSilent print should use default printer settings including \"Paper Size\".\r\n```\r\nbrowser.webContents.print({\r\n silent: true,\r\n printBackground: false,\r\n deviceName: 'MyPrinter'\r\n});\r\n```\r\n\r\n### Actual behavior\r\n\r\nSilent print with printer default custom paper sizing (ie. 72mm x 200mm)... \r\n```\r\nbrowser.webContents.print({\r\n silent: true,\r\n printBackground: false,\r\n deviceName: 'MyPrinter'\r\n});\r\n```\r\nyields super tiny print. While issuing the same command but with \"silent = false\"... \r\n```\r\nbrowser.webContents.print({\r\n silent: false,\r\n printBackground: false,\r\n deviceName: 'MyPrinter'\r\n});\r\n```\r\nyields correctly sized output.\r\n\r\n### How to reproduce\r\n\r\n1. Setup printer with default custom paper size (ie. 72mm x 200mm)\r\n2. Run the following **(silent = true)** and notice tiny print:\r\n```\r\nbrowser.webContents.print({\r\n silent: true,\r\n printBackground: false,\r\n deviceName: 'MyPrinter'\r\n});\r\n```\r\n3. Run the following **(silent = false)** and notice normal print:\r\n```\r\nbrowser.webContents.print({\r\n silent: false,\r\n printBackground: false,\r\n deviceName: 'MyPrinter'\r\n});\r\n```\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9779", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9779/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9779/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9779/events", "html_url": "https://github.com/electron/electron/issues/9779", "id": 236472922, "number": 9779, "title": "npm install creating files at wrong directory for electron", "user": { "login": "azurinko", "id": 29457341, "avatar_url": "https://avatars2.githubusercontent.com/u/29457341?v=3", "gravatar_id": "", "url": "https://api.github.com/users/azurinko", "html_url": "https://github.com/azurinko", "followers_url": "https://api.github.com/users/azurinko/followers", "following_url": "https://api.github.com/users/azurinko/following{/other_user}", "gists_url": "https://api.github.com/users/azurinko/gists{/gist_id}", "starred_url": "https://api.github.com/users/azurinko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/azurinko/subscriptions", "organizations_url": "https://api.github.com/users/azurinko/orgs", "repos_url": "https://api.github.com/users/azurinko/repos", "events_url": "https://api.github.com/users/azurinko/events{/privacy}", "received_events_url": "https://api.github.com/users/azurinko/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-16T12:46:49Z", "updated_at": "2017-06-16T12:54:16Z", "closed_at": "2017-06-16T12:54:15Z", "body": "* Electron version: Cloned from github today\r\n* Operating system: Windows 10\r\n\r\n### Expected behavior\r\n\r\nWhen I performed \r\nnpm install sqlite3 --build-from-source,\r\nnpm created directories for node js\r\n\r\n### Actual behavior\r\n\r\nnpm didn't created directories for electron\r\n\r\n### How to reproduce\r\n\r\nhttps://github.com/electron/electron-quick-start\r\nmain.js;\r\nadded line \r\nconst sql = require('sqlite3') \r\non line 9\r\n\r\nhttps://pastebin.com/J7s4iTDM\r\n\r\nHere is what I have done, everyting, in command line." }, { "url": "https://api.github.com/repos/electron/electron/issues/9778", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9778/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9778/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9778/events", "html_url": "https://github.com/electron/electron/pull/9778", "id": 236471758, "number": 9778, "title": "Extra properties must be less than 63 characters", "user": { "login": "lepinay", "id": 2689930, "avatar_url": "https://avatars0.githubusercontent.com/u/2689930?v=3", "gravatar_id": "", "url": "https://api.github.com/users/lepinay", "html_url": "https://github.com/lepinay", "followers_url": "https://api.github.com/users/lepinay/followers", "following_url": "https://api.github.com/users/lepinay/following{/other_user}", "gists_url": "https://api.github.com/users/lepinay/gists{/gist_id}", "starred_url": "https://api.github.com/users/lepinay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lepinay/subscriptions", "organizations_url": "https://api.github.com/users/lepinay/orgs", "repos_url": "https://api.github.com/users/lepinay/repos", "events_url": "https://api.github.com/users/lepinay/events{/privacy}", "received_events_url": "https://api.github.com/users/lepinay/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-16T12:41:45Z", "updated_at": "2017-06-26T15:36:43Z", "closed_at": "2017-06-26T15:36:43Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9778", "html_url": "https://github.com/electron/electron/pull/9778", "diff_url": "https://github.com/electron/electron/pull/9778.diff", "patch_url": "https://github.com/electron/electron/pull/9778.patch" }, "body": "I found out that after trying to putting some long text in my extra properties that it was truncated, digging around I found these:\r\n\r\nhttps://github.com/electron/electron/blob/897d58bde1414d73529a526a4f3fbc237683d9be/atom/common/crash_reporter/crash_reporter_win.cc\r\nconst int kNameMaxLength = 64;\r\nconst int kValueMaxLength = 64;" }, { "url": "https://api.github.com/repos/electron/electron/issues/9777", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9777/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9777/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9777/events", "html_url": "https://github.com/electron/electron/issues/9777", "id": 236405078, "number": 9777, "title": "why the video stream is black?chrome has no problem", "user": { "login": "Hazlank", "id": 15724316, "avatar_url": "https://avatars3.githubusercontent.com/u/15724316?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Hazlank", "html_url": "https://github.com/Hazlank", "followers_url": "https://api.github.com/users/Hazlank/followers", "following_url": "https://api.github.com/users/Hazlank/following{/other_user}", "gists_url": "https://api.github.com/users/Hazlank/gists{/gist_id}", "starred_url": "https://api.github.com/users/Hazlank/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Hazlank/subscriptions", "organizations_url": "https://api.github.com/users/Hazlank/orgs", "repos_url": "https://api.github.com/users/Hazlank/repos", "events_url": "https://api.github.com/users/Hazlank/events{/privacy}", "received_events_url": "https://api.github.com/users/Hazlank/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 193723572, "url": "https://api.github.com/repos/electron/electron/labels/more-information-needed", "name": "more-information-needed", "color": "009800", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-16T07:42:36Z", "updated_at": "2017-06-20T01:33:04Z", "closed_at": null, "body": "Hi,all\r\n\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: Windows 10\r\n\r\nwhen i use the electron to open a new BrowserWindow，there is no problem，the video can show the imgae,but when i open a new one，the new window of the video stream is black. and the browser like chorme or firefox become black to。if i am not open electron to run ，the other browser is no problem 。there can add the stream for video in local page 。Edge has the same problem too,why..?\r\n\r\nthere is the get video stream code\r\n\r\n```\r\n function hasUserMedia() {\r\n return !!(navigator.getUserMedia || navigator.webkitGetUserMedia || navigator.mozGetUserMedia || navigator.msGetUserMedia);\r\n}\r\nif (hasUserMedia()) {\r\n navigator.getUserMedia = navigator.getUserMedia || navigator.webkitGetUserMedia || navigator.mozGetUserMedia || navigator.msGetUserMedia; \r\n navigator.getUserMedia({\r\n video: true,\r\n audio: true\r\n }, function (stream) {\r\n var video = document.createElement('video');\r\n video.setAttribute('autoplay', '');\r\n document.body.appendChild(video)\r\n video.src = window.URL.createObjectURL(stream);\r\n }, function (err) {});\r\n} else {\r\n alert(\"sorry,the browser is not support Webrtc\");\r\n}\r\n```\r\n--------------------------------------------------------------------\r\n\r\n\r\n开了两个electron打包后的exe文件 就黑掉了，edge也是这样，只要打开一个窗口，再打开，本地的视频流创建的时候就是黑的啊。。不管再打开chrome 还是firefox 也是黑的，只用chorme 或者 firefox完全没事" }, { "url": "https://api.github.com/repos/electron/electron/issues/9776", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9776/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9776/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9776/events", "html_url": "https://github.com/electron/electron/issues/9776", "id": 236404835, "number": 9776, "title": "Can not get cookies on restart after calling session.clearStorageData", "user": { "login": "chamerling", "id": 264403, "avatar_url": "https://avatars2.githubusercontent.com/u/264403?v=3", "gravatar_id": "", "url": "https://api.github.com/users/chamerling", "html_url": "https://github.com/chamerling", "followers_url": "https://api.github.com/users/chamerling/followers", "following_url": "https://api.github.com/users/chamerling/following{/other_user}", "gists_url": "https://api.github.com/users/chamerling/gists{/gist_id}", "starred_url": "https://api.github.com/users/chamerling/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chamerling/subscriptions", "organizations_url": "https://api.github.com/users/chamerling/orgs", "repos_url": "https://api.github.com/users/chamerling/repos", "events_url": "https://api.github.com/users/chamerling/events{/privacy}", "received_events_url": "https://api.github.com/users/chamerling/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 193723572, "url": "https://api.github.com/repos/electron/electron/labels/more-information-needed", "name": "more-information-needed", "color": "009800", "default": false }, { "id": 546663659, "url": "https://api.github.com/repos/electron/electron/labels/waiting/needs-repro", "name": "waiting/needs-repro", "color": "fbca04", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-16T07:41:16Z", "updated_at": "2017-06-23T12:57:45Z", "closed_at": null, "body": "* Electron version: 1.7.3\r\n* Operating system: OS X 10.11.6\r\n\r\nHi all,\r\n\r\nI have a strange behaviour and need some advice wether it is a bug or not: I was able to get my cookies from `mainWindow.webContents.session.cookies.get` after restarting my application until I called `session.clearStorageData`. Since then I am not able to retrieve any cookie even if I flush them with `cookies.flushStore`\r\n\r\nI wonder if there is something to call to retrieve the initial behaviour or if it is a bug.\r\n\r\nThx\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9775", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9775/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9775/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9775/events", "html_url": "https://github.com/electron/electron/issues/9775", "id": 236393733, "number": 9775, "title": "Typescript translation incorrect for Electron.IpcRenderer.sendSync", "user": { "login": "seyfert", "id": 2137082, "avatar_url": "https://avatars2.githubusercontent.com/u/2137082?v=3", "gravatar_id": "", "url": "https://api.github.com/users/seyfert", "html_url": "https://github.com/seyfert", "followers_url": "https://api.github.com/users/seyfert/followers", "following_url": "https://api.github.com/users/seyfert/following{/other_user}", "gists_url": "https://api.github.com/users/seyfert/gists{/gist_id}", "starred_url": "https://api.github.com/users/seyfert/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/seyfert/subscriptions", "organizations_url": "https://api.github.com/users/seyfert/orgs", "repos_url": "https://api.github.com/users/seyfert/repos", "events_url": "https://api.github.com/users/seyfert/events{/privacy}", "received_events_url": "https://api.github.com/users/seyfert/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 97431925, "url": "https://api.github.com/repos/electron/electron/labels/documentation", "name": "documentation", "color": "eb6420", "default": false } ], "state": "open", "locked": false, "assignee": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 5, "created_at": "2017-06-16T06:40:41Z", "updated_at": "2017-06-27T02:46:33Z", "closed_at": null, "body": "* Electron version: 1.6.11\r\n* Operating system: MacOS\r\n\r\n### Expected behavior\r\n\r\nDocumentation does not define the return value for IpcRenderer.sendSync(). sendSync should be defined to return \"any\"\r\n\r\n### Actual behavior\r\n\r\nDocumentation does not define a return type so the generated typescript definition for sendSync incorrectly returns void\r\n\r\n### How to reproduce\r\n\r\nSee recent documentation and generated electron.d.ts\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9774", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9774/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9774/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9774/events", "html_url": "https://github.com/electron/electron/issues/9774", "id": 236375788, "number": 9774, "title": "how to emulate mobile page in electron ？", "user": { "login": "ydcoming", "id": 3353702, "avatar_url": "https://avatars0.githubusercontent.com/u/3353702?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ydcoming", "html_url": "https://github.com/ydcoming", "followers_url": "https://api.github.com/users/ydcoming/followers", "following_url": "https://api.github.com/users/ydcoming/following{/other_user}", "gists_url": "https://api.github.com/users/ydcoming/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydcoming/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydcoming/subscriptions", "organizations_url": "https://api.github.com/users/ydcoming/orgs", "repos_url": "https://api.github.com/users/ydcoming/repos", "events_url": "https://api.github.com/users/ydcoming/events{/privacy}", "received_events_url": "https://api.github.com/users/ydcoming/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-16T04:15:51Z", "updated_at": "2017-06-16T04:15:51Z", "closed_at": null, "body": "I want the electron analog phone rendering the page, just like the android simulator.how to emulate mobile page in electron ？ tks" }, { "url": "https://api.github.com/repos/electron/electron/issues/9773", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9773/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9773/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9773/events", "html_url": "https://github.com/electron/electron/issues/9773", "id": 236361215, "number": 9773, "title": "dialog.showErrorBox is not modal on Windows", "user": { "login": "LukePowell", "id": 7257117, "avatar_url": "https://avatars1.githubusercontent.com/u/7257117?v=3", "gravatar_id": "", "url": "https://api.github.com/users/LukePowell", "html_url": "https://github.com/LukePowell", "followers_url": "https://api.github.com/users/LukePowell/followers", "following_url": "https://api.github.com/users/LukePowell/following{/other_user}", "gists_url": "https://api.github.com/users/LukePowell/gists{/gist_id}", "starred_url": "https://api.github.com/users/LukePowell/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LukePowell/subscriptions", "organizations_url": "https://api.github.com/users/LukePowell/orgs", "repos_url": "https://api.github.com/users/LukePowell/repos", "events_url": "https://api.github.com/users/LukePowell/events{/privacy}", "received_events_url": "https://api.github.com/users/LukePowell/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-16T02:10:12Z", "updated_at": "2017-06-16T02:12:01Z", "closed_at": null, "body": "* Electron version:\r\n1.6.11\r\n\r\n* Operating system:\r\nWindows 10\r\n\r\n### Expected behavior\r\n\r\ndialog.showErrorBox to display a modal error message on windows\r\n\r\n### Actual behavior\r\n\r\nDisplays an non-modal dialog box allowing the user to interact with the app's content. These operations are not applied immediately however they are queued and applied after the fist dialog is closed. Simply spam click the error button to see this behavior. Additionally the dialog can be hidden causing the app to appear non-responsive to users.\r\n\r\n### How to reproduce\r\nAny code with dialog.showErrorbox see\r\n\r\n $ git clone https://github.com/LukePowell/electron-quick-start\r\n $ npm install\r\n $ npm start\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9772", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9772/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9772/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9772/events", "html_url": "https://github.com/electron/electron/pull/9772", "id": 236349146, "number": 9772, "title": "add CRT to glossary", "user": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-16T00:28:57Z", "updated_at": "2017-06-26T15:37:20Z", "closed_at": "2017-06-26T15:37:12Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9772", "html_url": "https://github.com/electron/electron/pull/9772", "diff_url": "https://github.com/electron/electron/pull/9772.diff", "patch_url": "https://github.com/electron/electron/pull/9772.patch" }, "body": "Something I had to look up after viewing https://github.com/electron/electron/pull/9764, knowing it probably wasn't Cathode Ray Tube. :)" }, { "url": "https://api.github.com/repos/electron/electron/issues/9771", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9771/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9771/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9771/events", "html_url": "https://github.com/electron/electron/issues/9771", "id": 236335521, "number": 9771, "title": "Drag and drop doesn't work if Electron launched from tmux", "user": { "login": "aconchillo", "id": 951761, "avatar_url": "https://avatars0.githubusercontent.com/u/951761?v=3", "gravatar_id": "", "url": "https://api.github.com/users/aconchillo", "html_url": "https://github.com/aconchillo", "followers_url": "https://api.github.com/users/aconchillo/followers", "following_url": "https://api.github.com/users/aconchillo/following{/other_user}", "gists_url": "https://api.github.com/users/aconchillo/gists{/gist_id}", "starred_url": "https://api.github.com/users/aconchillo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aconchillo/subscriptions", "organizations_url": "https://api.github.com/users/aconchillo/orgs", "repos_url": "https://api.github.com/users/aconchillo/repos", "events_url": "https://api.github.com/users/aconchillo/events{/privacy}", "received_events_url": "https://api.github.com/users/aconchillo/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-15T22:51:01Z", "updated_at": "2017-06-15T22:52:50Z", "closed_at": null, "body": "This might be a tmux issue other than an Electron issue, I'm not really sure. So, I'm just posting it here in case you want to give it a try.\r\n\r\n* Electron version: 1.6.11\r\n* tmux version: 2.5 (from brew)\r\n* Operating system: OS X 10.12.4\r\n\r\n### Expected behavior\r\n\r\nDrag and drop should work.\r\n\r\n### Actual behavior\r\n\r\nDrag and drop freezes further mouse interactions with the window.\r\n\r\nErrors reported in the console:\r\n\r\n 2017-06-15 15:52:12.718 Electron[61960:1420958] CoreDragCreate error: -4960\r\n 2017-06-15 15:52:12.718 Electron[61960:1420958] error in CoreDragDispose: -1850\r\n\r\n### How to reproduce\r\n\r\nI just created this silly example (without tmux it should work):\r\n\r\n $ tmux\r\n\r\n $ git clone https://github.com/aconchillo/electron-dnd-test\r\n $ npm install\r\n $ npm start\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9770", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9770/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9770/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9770/events", "html_url": "https://github.com/electron/electron/issues/9770", "id": 236313270, "number": 9770, "title": "Reset printing settings to defaults.", "user": { "login": "Piom", "id": 270211, "avatar_url": "https://avatars0.githubusercontent.com/u/270211?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Piom", "html_url": "https://github.com/Piom", "followers_url": "https://api.github.com/users/Piom/followers", "following_url": "https://api.github.com/users/Piom/following{/other_user}", "gists_url": "https://api.github.com/users/Piom/gists{/gist_id}", "starred_url": "https://api.github.com/users/Piom/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Piom/subscriptions", "organizations_url": "https://api.github.com/users/Piom/orgs", "repos_url": "https://api.github.com/users/Piom/repos", "events_url": "https://api.github.com/users/Piom/events{/privacy}", "received_events_url": "https://api.github.com/users/Piom/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 254932912, "url": "https://api.github.com/repos/electron/electron/labels/component/printing", "name": "component/printing", "color": "f9d0c4", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-15T21:01:40Z", "updated_at": "2017-06-15T22:11:53Z", "closed_at": null, "body": "The default printer settings are set to portrait.\r\nWhen printing documents (eg pdf), I choose the page orientation of the landscape. \r\nThen I try to print again and the orientation is reset to portrait.\r\nHowever, in other browsers(Chrome, IE, Firefox), the orientation is preserved when reprinting.\r\nPrinting goes through the system window and directly from pdf.js\r\n\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: Win 7/10 x64\r\n\r\n### Expected behavior\r\nAbility to save print settings as well as implemented in other browsers. Or the ability to manage the system printing window.\r\n\r\n### How to reproduce\r\n- Try to print the document.\r\n- Change page orientation (layout)\r\n- Repeat printing\r\n- Check print settings\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9769", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9769/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9769/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9769/events", "html_url": "https://github.com/electron/electron/pull/9769", "id": 236296633, "number": 9769, "title": "Add titleBarStyle: 'hidden-inset' to planned breaking changes", "user": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-15T19:53:42Z", "updated_at": "2017-06-15T20:13:05Z", "closed_at": "2017-06-15T20:13:02Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9769", "html_url": "https://github.com/electron/electron/pull/9769", "diff_url": "https://github.com/electron/electron/pull/9769.diff", "patch_url": "https://github.com/electron/electron/pull/9769.patch" }, "body": "Should use `hiddenInset` instead." }, { "url": "https://api.github.com/repos/electron/electron/issues/9768", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9768/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9768/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9768/events", "html_url": "https://github.com/electron/electron/pull/9768", "id": 236295369, "number": 9768, "title": "mention ARM and FIXME in breaking changes doc", "user": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-15T19:48:23Z", "updated_at": "2017-06-15T20:50:40Z", "closed_at": "2017-06-15T20:50:37Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9768", "html_url": "https://github.com/electron/electron/pull/9768", "diff_url": "https://github.com/electron/electron/pull/9768.diff", "patch_url": "https://github.com/electron/electron/pull/9768.patch" }, "body": "This PR updates the list of things that we plan to change in 2.0:\r\n\r\n- deprecate `*-arm.zip` release asset\r\n- look for FIXME comments" }, { "url": "https://api.github.com/repos/electron/electron/issues/9767", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9767/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9767/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9767/events", "html_url": "https://github.com/electron/electron/pull/9767", "id": 236259387, "number": 9767, "title": "Document webContents.focus()", "user": { "login": "poiru", "id": 1319028, "avatar_url": "https://avatars1.githubusercontent.com/u/1319028?v=3", "gravatar_id": "", "url": "https://api.github.com/users/poiru", "html_url": "https://github.com/poiru", "followers_url": "https://api.github.com/users/poiru/followers", "following_url": "https://api.github.com/users/poiru/following{/other_user}", "gists_url": "https://api.github.com/users/poiru/gists{/gist_id}", "starred_url": "https://api.github.com/users/poiru/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poiru/subscriptions", "organizations_url": "https://api.github.com/users/poiru/orgs", "repos_url": "https://api.github.com/users/poiru/repos", "events_url": "https://api.github.com/users/poiru/events{/privacy}", "received_events_url": "https://api.github.com/users/poiru/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-15T17:20:08Z", "updated_at": "2017-06-15T19:34:00Z", "closed_at": "2017-06-15T17:25:17Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9767", "html_url": "https://github.com/electron/electron/pull/9767", "diff_url": "https://github.com/electron/electron/pull/9767.diff", "patch_url": "https://github.com/electron/electron/pull/9767.patch" }, "body": "" }, { "url": "https://api.github.com/repos/electron/electron/issues/9766", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9766/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9766/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9766/events", "html_url": "https://github.com/electron/electron/pull/9766", "id": 236228201, "number": 9766, "title": "[WIP] Upgrade to Chromium 59", "user": { "login": "alexeykuzmin", "id": 607250, "avatar_url": "https://avatars0.githubusercontent.com/u/607250?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alexeykuzmin", "html_url": "https://github.com/alexeykuzmin", "followers_url": "https://api.github.com/users/alexeykuzmin/followers", "following_url": "https://api.github.com/users/alexeykuzmin/following{/other_user}", "gists_url": "https://api.github.com/users/alexeykuzmin/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexeykuzmin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexeykuzmin/subscriptions", "organizations_url": "https://api.github.com/users/alexeykuzmin/orgs", "repos_url": "https://api.github.com/users/alexeykuzmin/repos", "events_url": "https://api.github.com/users/alexeykuzmin/events{/privacy}", "received_events_url": "https://api.github.com/users/alexeykuzmin/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-15T15:24:54Z", "updated_at": "2017-06-22T11:34:13Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9766", "html_url": "https://github.com/electron/electron/pull/9766", "diff_url": "https://github.com/electron/electron/pull/9766.diff", "patch_url": "https://github.com/electron/electron/pull/9766.patch" }, "body": "Related to #9679. \r\nHere are mostly fixes of trivial compilation errors. There are still plenty of errors left, I'm working on it. \r\nKeep it mind that a [PR](https://github.com/electron/libchromiumcontent/pull/313) with changes to libcc hasn't been merged yet.\r\n\r\n/cc @tonyganch @kevinsawicki @zcbenz @setpixel @dezmathio\r\n\r\nAlmost all commits have a corresponding CL title as a first line of their commit message.\r\nLink(s) to the CL(s) can be also found in the commit message.\r\n\r\nIncomplete list of the compilation errors left:\r\n- [x] **atom/browser/bridge_task_runner.cc**:16:28: error: call to implicitly-deleted copy constructor of 'base::OnceClosure'\r\n Related CLs: [chromium/2637843002](https://codereview.chromium.org/2637843002), [chromium/2726523002](https://codereview.chromium.org/2726523002), [chromium/2797133002](https://codereview.chromium.org/2797133002).\r\n- [x] **atom/browser/api/frame_subscriber.cc**:87:10: error: no member named 'copyPixelsTo' in 'SkBitmap'\r\n Related issue: [Remove SkBitmap::copyPixelsTo](https://bugs.chromium.org/p/skia/issues/detail?id=6465)\r\n- [x] **atom/browser/net/atom_url_request_job_factory.h**:58:44: error: only virtual member functions can be marked 'override'\r\n Related CL: https://codereview.chromium.org/2783343002\r\n- [ ] _(taken by alexeykuzmin)_ **atom/browser/osr/osr_web_contents_view.cc**:104:14: error: allocating an object of abstract class type 'atom::OffScreenRenderWidgetHostView'\r\n- [ ] _(taken by alexeykuzmin)_ **atom/browser/osr/osr_render_widget_host_view.cc**:562:40: error: use of undeclared identifier 'GetBackgroundOpaque'\r\n- [ ] _(taken by alexeykuzmin)_ **atom/browser/osr/osr_render_widget_host_view.cc**:581:37: error: out-of-line definition of 'OnSwapCompositorFrame' does not match any declaration in 'atom::OffScreenRenderWidgetHostView'\r\n- [ ] _(taken by alexeykuzmin)_ **atom/browser/osr/osr_render_widget_host_view.cc**:602:32: error: no member named 'SwapDelegatedFrame' in 'content::DelegatedFrameHost'\r\n- [ ] _(taken by alexeykuzmin)_ **atom/browser/osr/osr_render_widget_host_view_mac.mm**:44:51: error: only virtual member functions can be marked 'override'\r\n- [ ] _(taken by alexeykuzmin)_ **atom/browser/osr/osr_render_widget_host_view_mac.mm**:45:43: error: unknown type name 'ViewMsg_ReclaimCompositorResources'\r\n- [x] **atom/common/native_mate_converters/blink_converter.cc**:250:28: error: no member named 'x' in 'blink::WebMouseEvent'\r\n Related CL: https://codereview.chromium.org/2782893002\r\n- [x] **atom/renderer/api/atom_api_spell_check_client.h**:39:64: error: only virtual member functions can be marked 'override'\r\n Related issue: [OOPIF: SpellCheckProvider is a RenderViewObserver](https://crbug.com/638361) and [design doc](https://goo.gl/VfCENk).\r\n- [x] **atom/renderer/atom_autofill_agent.h**:38:45: error: only virtual member functions can be marked 'override'\r\n Related CL: https://codereview.chromium.org/2766053002\r\n- [x] **vendor/native_mate/native_mate/converter.h**:298:24: error: no member named 'ToV8' in 'mate::Converter'\r\n Related CL: https://codereview.chromium.org/2751343002" }, { "url": "https://api.github.com/repos/electron/electron/issues/9765", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9765/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9765/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9765/events", "html_url": "https://github.com/electron/electron/issues/9765", "id": 236108445, "number": 9765, "title": "Canvas performance problem (chromium bug)", "user": { "login": "ogo-adp", "id": 25432938, "avatar_url": "https://avatars0.githubusercontent.com/u/25432938?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ogo-adp", "html_url": "https://github.com/ogo-adp", "followers_url": "https://api.github.com/users/ogo-adp/followers", "following_url": "https://api.github.com/users/ogo-adp/following{/other_user}", "gists_url": "https://api.github.com/users/ogo-adp/gists{/gist_id}", "starred_url": "https://api.github.com/users/ogo-adp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ogo-adp/subscriptions", "organizations_url": "https://api.github.com/users/ogo-adp/orgs", "repos_url": "https://api.github.com/users/ogo-adp/repos", "events_url": "https://api.github.com/users/ogo-adp/events{/privacy}", "received_events_url": "https://api.github.com/users/ogo-adp/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 193723580, "url": "https://api.github.com/repos/electron/electron/labels/blocked", "name": "blocked", "color": "d4c5f9", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false }, { "id": 97403549, "url": "https://api.github.com/repos/electron/electron/labels/platform/windows", "name": "platform/windows", "color": "c7def8", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-15T08:04:26Z", "updated_at": "2017-06-22T17:25:33Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.7.2\r\n* Operating system: Windows 7/10\r\n\r\n### Expected behavior\r\n\r\nGood performance of large drawImage() on canvas\r\n\r\n### Actual behavior\r\n\r\ndrawImage() slow down under some circumstances\r\n\r\n### How to reproduce\r\nhttps://codepen.io/simonsarris/pen/GgXjBG\r\n\r\n\r\nThe issue is not in electron but in chromium itself. It has been fixed in chrome >= 59. As the fix involve only a few lines of codes in chromium would it be possible to backport this fix to electron 1.7.x which is based on chrome 58 ?\r\n\r\nHere is the commit of the fix : https://chromium.googlesource.com/chromium/src.git/+/c78b8bf07f4819342ee6d99796100cc62880718b%5E%21/#F0\r\n\r\nThanks :)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9764", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9764/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9764/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9764/events", "html_url": "https://github.com/electron/electron/pull/9764", "id": 236106677, "number": 9764, "title": "Use dynamic CRT in the release build", "user": { "login": "alespergl", "id": 19880051, "avatar_url": "https://avatars2.githubusercontent.com/u/19880051?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alespergl", "html_url": "https://github.com/alespergl", "followers_url": "https://api.github.com/users/alespergl/followers", "following_url": "https://api.github.com/users/alespergl/following{/other_user}", "gists_url": "https://api.github.com/users/alespergl/gists{/gist_id}", "starred_url": "https://api.github.com/users/alespergl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alespergl/subscriptions", "organizations_url": "https://api.github.com/users/alespergl/orgs", "repos_url": "https://api.github.com/users/alespergl/repos", "events_url": "https://api.github.com/users/alespergl/events{/privacy}", "received_events_url": "https://api.github.com/users/alespergl/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-15T07:57:07Z", "updated_at": "2017-06-23T06:03:52Z", "closed_at": "2017-06-23T06:03:47Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9764", "html_url": "https://github.com/electron/electron/pull/9764", "diff_url": "https://github.com/electron/electron/pull/9764.diff", "patch_url": "https://github.com/electron/electron/pull/9764.patch" }, "body": "This addresses #9443 \r\nDepends on [libchromiumcontent#312](https://github.com/electron/libchromiumcontent/pull/312)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9763", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9763/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9763/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9763/events", "html_url": "https://github.com/electron/electron/issues/9763", "id": 236084367, "number": 9763, "title": "Package an Electron App", "user": { "login": "broros", "id": 598228, "avatar_url": "https://avatars1.githubusercontent.com/u/598228?v=3", "gravatar_id": "", "url": "https://api.github.com/users/broros", "html_url": "https://github.com/broros", "followers_url": "https://api.github.com/users/broros/followers", "following_url": "https://api.github.com/users/broros/following{/other_user}", "gists_url": "https://api.github.com/users/broros/gists{/gist_id}", "starred_url": "https://api.github.com/users/broros/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/broros/subscriptions", "organizations_url": "https://api.github.com/users/broros/orgs", "repos_url": "https://api.github.com/users/broros/repos", "events_url": "https://api.github.com/users/broros/events{/privacy}", "received_events_url": "https://api.github.com/users/broros/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-15T05:53:30Z", "updated_at": "2017-06-15T06:01:28Z", "closed_at": "2017-06-15T06:01:28Z", "body": "can I Package an Electron App for all three operating systems ( macOS, linux, windows) at once?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9762", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9762/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9762/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9762/events", "html_url": "https://github.com/electron/electron/issues/9762", "id": 236070478, "number": 9762, "title": "Electron will not Install", "user": { "login": "FaustianSpirit", "id": 26865326, "avatar_url": "https://avatars3.githubusercontent.com/u/26865326?v=3", "gravatar_id": "", "url": "https://api.github.com/users/FaustianSpirit", "html_url": "https://github.com/FaustianSpirit", "followers_url": "https://api.github.com/users/FaustianSpirit/followers", "following_url": "https://api.github.com/users/FaustianSpirit/following{/other_user}", "gists_url": "https://api.github.com/users/FaustianSpirit/gists{/gist_id}", "starred_url": "https://api.github.com/users/FaustianSpirit/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/FaustianSpirit/subscriptions", "organizations_url": "https://api.github.com/users/FaustianSpirit/orgs", "repos_url": "https://api.github.com/users/FaustianSpirit/repos", "events_url": "https://api.github.com/users/FaustianSpirit/events{/privacy}", "received_events_url": "https://api.github.com/users/FaustianSpirit/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-15T03:54:50Z", "updated_at": "2017-06-15T04:23:27Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.7.3\r\n* Operating system: Linux Mint 18.1 Serena\r\nPython 2.7.12v\r\nnpm 5.0.3v\r\nnode 8.1.1v\r\n\r\n### Expected behavior\r\n\r\n\r\n\r\nShould start and run the script.\r\n\r\nShould successfully execute \r\n\r\n npm start electron\r\nor npm install && npm start\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Actual behavior\r\n\r\n\r\nError Logs:\r\n[2017-06-15T03_23_05_602Z-debug.txt](https://github.com/electron/electron/files/1076508/2017-06-15T03_23_05_602Z-debug.txt)\r\n\r\n[2017-06-15T03_51_50_814Z-debug.txt](https://github.com/electron/electron/files/1076529/2017-06-15T03_51_50_814Z-debug.txt)\r\n### How to reproduce\r\n$ git clone https://github.com/electron/electron\r\n$ cd electron\r\n$ npm install && npm start\r\n\r\n$ git clone https://github.com/npm/npm\r\n$ cd npm\r\n$ npm install && npm start\r\n\r\nError logs match respectively.\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9761", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9761/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9761/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9761/events", "html_url": "https://github.com/electron/electron/issues/9761", "id": 236048882, "number": 9761, "title": "app crashed when launched in AppVerifiy", "user": { "login": "everrr1025", "id": 4454065, "avatar_url": "https://avatars0.githubusercontent.com/u/4454065?v=3", "gravatar_id": "", "url": "https://api.github.com/users/everrr1025", "html_url": "https://github.com/everrr1025", "followers_url": "https://api.github.com/users/everrr1025/followers", "following_url": "https://api.github.com/users/everrr1025/following{/other_user}", "gists_url": "https://api.github.com/users/everrr1025/gists{/gist_id}", "starred_url": "https://api.github.com/users/everrr1025/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/everrr1025/subscriptions", "organizations_url": "https://api.github.com/users/everrr1025/orgs", "repos_url": "https://api.github.com/users/everrr1025/repos", "events_url": "https://api.github.com/users/everrr1025/events{/privacy}", "received_events_url": "https://api.github.com/users/everrr1025/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-15T00:55:17Z", "updated_at": "2017-06-15T00:55:17Z", "closed_at": null, "body": "* Electron version: 1.6.1\r\n* Operating system: win10\r\n\r\n### Expected behavior\r\n Electron app should not crash when launched with AppVerifier\r\nhttps://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/application-verifier\r\n\r\n### Actual behavior\r\nElectron app crashes when launched if AppVerifier is enabled with Basic + Miscellaneous checks enabled LayerName=Locks StopCode=0x211 Critical section is already initialized Module: vrfcore.dll Exc: 80000003\r\n\r\n\r\n### How to reproduce\r\nlaunch AppVerifier\r\nwith Basic + Miscellaneous checks enabled.\r\nselect a Electron app to run\r\nsee the crash happening" }, { "url": "https://api.github.com/repos/electron/electron/issues/9760", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9760/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9760/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9760/events", "html_url": "https://github.com/electron/electron/pull/9760", "id": 236022596, "number": 9760, "title": "Add mouse-enter and mouse-exit events for tray", "user": { "login": "shubham2892", "id": 6316389, "avatar_url": "https://avatars1.githubusercontent.com/u/6316389?v=3", "gravatar_id": "", "url": "https://api.github.com/users/shubham2892", "html_url": "https://github.com/shubham2892", "followers_url": "https://api.github.com/users/shubham2892/followers", "following_url": "https://api.github.com/users/shubham2892/following{/other_user}", "gists_url": "https://api.github.com/users/shubham2892/gists{/gist_id}", "starred_url": "https://api.github.com/users/shubham2892/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shubham2892/subscriptions", "organizations_url": "https://api.github.com/users/shubham2892/orgs", "repos_url": "https://api.github.com/users/shubham2892/repos", "events_url": "https://api.github.com/users/shubham2892/events{/privacy}", "received_events_url": "https://api.github.com/users/shubham2892/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-14T22:03:09Z", "updated_at": "2017-06-15T08:35:35Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9760", "html_url": "https://github.com/electron/electron/pull/9760", "diff_url": "https://github.com/electron/electron/pull/9760.diff", "patch_url": "https://github.com/electron/electron/pull/9760.patch" }, "body": "Fixes #7616 \r\nAdd API for listening to mouse-enter and mouse-exit events for Tray." }, { "url": "https://api.github.com/repos/electron/electron/issues/9759", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9759/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9759/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9759/events", "html_url": "https://github.com/electron/electron/issues/9759", "id": 235962169, "number": 9759, "title": "Storage Info API", "user": { "login": "YurySolovyov", "id": 2168518, "avatar_url": "https://avatars3.githubusercontent.com/u/2168518?v=3", "gravatar_id": "", "url": "https://api.github.com/users/YurySolovyov", "html_url": "https://github.com/YurySolovyov", "followers_url": "https://api.github.com/users/YurySolovyov/followers", "following_url": "https://api.github.com/users/YurySolovyov/following{/other_user}", "gists_url": "https://api.github.com/users/YurySolovyov/gists{/gist_id}", "starred_url": "https://api.github.com/users/YurySolovyov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/YurySolovyov/subscriptions", "organizations_url": "https://api.github.com/users/YurySolovyov/orgs", "repos_url": "https://api.github.com/users/YurySolovyov/repos", "events_url": "https://api.github.com/users/YurySolovyov/events{/privacy}", "received_events_url": "https://api.github.com/users/YurySolovyov/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-14T18:01:14Z", "updated_at": "2017-06-15T17:52:36Z", "closed_at": null, "body": "It would be nice to have an API to:\r\n- enumerate logical drives (hard discs, flash drives)\r\n- get basic info about state (label, free/used space)\r\n- ability to get notified when new drive is added/mounted\r\n\r\nIf Chromuim has anything like that, please point me to the code, I might be able to port it, but I can't promise anything." }, { "url": "https://api.github.com/repos/electron/electron/issues/9758", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9758/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9758/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9758/events", "html_url": "https://github.com/electron/electron/issues/9758", "id": 235936315, "number": 9758, "title": "Reload doesn't work sometimes", "user": { "login": "VikasShashidhar", "id": 27778544, "avatar_url": "https://avatars3.githubusercontent.com/u/27778544?v=3", "gravatar_id": "", "url": "https://api.github.com/users/VikasShashidhar", "html_url": "https://github.com/VikasShashidhar", "followers_url": "https://api.github.com/users/VikasShashidhar/followers", "following_url": "https://api.github.com/users/VikasShashidhar/following{/other_user}", "gists_url": "https://api.github.com/users/VikasShashidhar/gists{/gist_id}", "starred_url": "https://api.github.com/users/VikasShashidhar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VikasShashidhar/subscriptions", "organizations_url": "https://api.github.com/users/VikasShashidhar/orgs", "repos_url": "https://api.github.com/users/VikasShashidhar/repos", "events_url": "https://api.github.com/users/VikasShashidhar/events{/privacy}", "received_events_url": "https://api.github.com/users/VikasShashidhar/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 193723572, "url": "https://api.github.com/repos/electron/electron/labels/more-information-needed", "name": "more-information-needed", "color": "009800", "default": false }, { "id": 546663659, "url": "https://api.github.com/repos/electron/electron/labels/waiting/needs-repro", "name": "waiting/needs-repro", "color": "fbca04", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-14T16:23:45Z", "updated_at": "2017-06-26T20:29:44Z", "closed_at": null, "body": "* Electron version: 1.6.7\r\n* Operating system: macOS Sierra (10.12.5)\r\n\r\n### Expected behavior\r\n\r\nWhen the user does a Cmd+R or reloads the page through context menu, the page should reload.\r\n\r\n### Actual behavior\r\n\r\nIt works most of the time, but not always. Many times when it fails, a blank page appears.\r\n\r\n### How to reproduce\r\n\r\nUnfortunately, there are no clear repro steps. It happens so randomly that it's hard to identify a clear pattern. Will update this issue if I am able to repro this consistently.\r\n\r\nI've observed this on a couple of apps that uses Electron." }, { "url": "https://api.github.com/repos/electron/electron/issues/9757", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9757/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9757/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9757/events", "html_url": "https://github.com/electron/electron/issues/9757", "id": 235895883, "number": 9757, "title": "Electron 1.6.10 is not able to pass App Store verification with sbpl exceptions", "user": { "login": "kcampion", "id": 507265, "avatar_url": "https://avatars1.githubusercontent.com/u/507265?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kcampion", "html_url": "https://github.com/kcampion", "followers_url": "https://api.github.com/users/kcampion/followers", "following_url": "https://api.github.com/users/kcampion/following{/other_user}", "gists_url": "https://api.github.com/users/kcampion/gists{/gist_id}", "starred_url": "https://api.github.com/users/kcampion/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kcampion/subscriptions", "organizations_url": "https://api.github.com/users/kcampion/orgs", "repos_url": "https://api.github.com/users/kcampion/repos", "events_url": "https://api.github.com/users/kcampion/events{/privacy}", "received_events_url": "https://api.github.com/users/kcampion/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 10, "created_at": "2017-06-14T14:20:29Z", "updated_at": "2017-06-24T02:38:13Z", "closed_at": "2017-06-24T02:37:40Z", "body": "* Electron version: 1.6.10\r\n* Operating system: macOs 10.12.5\r\n\r\nWith one of the last version of Electron, I use this on parent.plist to allow Apple Sandbox to execute my application:\r\n```\r\ncom.apple.security.temporary-exception.mach-lookup.global-name\r\n\r\n com.apple.GameController.gamecontrollerd\r\n\r\ncom.apple.security.temporary-exception.sbpl\r\n\r\n (allow mach-lookup (global-name-regex #\"^org.chromium.Chromium.rohitfork.[0-9]+$\"))\r\n (allow mach-register (global-name-regex #\"^com.electron.mysuperapp.rohitfork.[0-9]+$\"))\r\n (allow mach-lookup (global-name-regex #\"^com.electron.mysuperapp.rohitfork.[0-9]+$\"))\r\n\r\n```\r\n\r\nAbout **GameController**: I must use this mach-lookup exception with GameController because a Sandbox violation error appears. I don't know why, because I don't use anything for gaming.\r\n\r\nAbout **rohitfork**: It's for Chromium.\r\n\r\nThe application works well on my computer after signing it, but after 1 day in review, my app was rejected by Apple:\r\n![capture d ecran 2017-06-14 a 16 12 10](https://user-images.githubusercontent.com/507265/27136759-64c0bd94-511c-11e7-9f3e-6f77c2788dbf.png)\r\n\r\nSomeone has already deployed an Electron app with the last version on the AppStore?\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9756", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9756/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9756/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9756/events", "html_url": "https://github.com/electron/electron/issues/9756", "id": 235871254, "number": 9756, "title": "Path with '(' problem", "user": { "login": "doganmurat", "id": 12137916, "avatar_url": "https://avatars1.githubusercontent.com/u/12137916?v=3", "gravatar_id": "", "url": "https://api.github.com/users/doganmurat", "html_url": "https://github.com/doganmurat", "followers_url": "https://api.github.com/users/doganmurat/followers", "following_url": "https://api.github.com/users/doganmurat/following{/other_user}", "gists_url": "https://api.github.com/users/doganmurat/gists{/gist_id}", "starred_url": "https://api.github.com/users/doganmurat/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/doganmurat/subscriptions", "organizations_url": "https://api.github.com/users/doganmurat/orgs", "repos_url": "https://api.github.com/users/doganmurat/repos", "events_url": "https://api.github.com/users/doganmurat/events{/privacy}", "received_events_url": "https://api.github.com/users/doganmurat/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-14T13:01:23Z", "updated_at": "2017-06-14T13:01:23Z", "closed_at": null, "body": "* Electron version: 1.6.11\r\n* Operating system: Windows 64 Bit\r\n\r\n### Expected behavior\r\n\r\nOn start open index.html from asar archieve\r\n\r\n### Actual behavior\r\n\r\nIf path contains \"(\" electron could not load index.html on startup. (like C:\\Program Files (x86)\\Program)\r\n\r\n### How to reproduce\r\nChange directory name with a name that contains \"(\"\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9755", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9755/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9755/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9755/events", "html_url": "https://github.com/electron/electron/pull/9755", "id": 235854978, "number": 9755, "title": "Update windows-store-guide.md", "user": { "login": "Nirmal4G", "id": 4962580, "avatar_url": "https://avatars1.githubusercontent.com/u/4962580?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Nirmal4G", "html_url": "https://github.com/Nirmal4G", "followers_url": "https://api.github.com/users/Nirmal4G/followers", "following_url": "https://api.github.com/users/Nirmal4G/following{/other_user}", "gists_url": "https://api.github.com/users/Nirmal4G/gists{/gist_id}", "starred_url": "https://api.github.com/users/Nirmal4G/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Nirmal4G/subscriptions", "organizations_url": "https://api.github.com/users/Nirmal4G/orgs", "repos_url": "https://api.github.com/users/Nirmal4G/repos", "events_url": "https://api.github.com/users/Nirmal4G/events{/privacy}", "received_events_url": "https://api.github.com/users/Nirmal4G/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": { "login": "felixrieseberg", "id": 1426799, "avatar_url": "https://avatars0.githubusercontent.com/u/1426799?v=3", "gravatar_id": "", "url": "https://api.github.com/users/felixrieseberg", "html_url": "https://github.com/felixrieseberg", "followers_url": "https://api.github.com/users/felixrieseberg/followers", "following_url": "https://api.github.com/users/felixrieseberg/following{/other_user}", "gists_url": "https://api.github.com/users/felixrieseberg/gists{/gist_id}", "starred_url": "https://api.github.com/users/felixrieseberg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/felixrieseberg/subscriptions", "organizations_url": "https://api.github.com/users/felixrieseberg/orgs", "repos_url": "https://api.github.com/users/felixrieseberg/repos", "events_url": "https://api.github.com/users/felixrieseberg/events{/privacy}", "received_events_url": "https://api.github.com/users/felixrieseberg/received_events", "type": "User", "site_admin": false }, "assignees": [ { "login": "felixrieseberg", "id": 1426799, "avatar_url": "https://avatars0.githubusercontent.com/u/1426799?v=3", "gravatar_id": "", "url": "https://api.github.com/users/felixrieseberg", "html_url": "https://github.com/felixrieseberg", "followers_url": "https://api.github.com/users/felixrieseberg/followers", "following_url": "https://api.github.com/users/felixrieseberg/following{/other_user}", "gists_url": "https://api.github.com/users/felixrieseberg/gists{/gist_id}", "starred_url": "https://api.github.com/users/felixrieseberg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/felixrieseberg/subscriptions", "organizations_url": "https://api.github.com/users/felixrieseberg/orgs", "repos_url": "https://api.github.com/users/felixrieseberg/repos", "events_url": "https://api.github.com/users/felixrieseberg/events{/privacy}", "received_events_url": "https://api.github.com/users/felixrieseberg/received_events", "type": "User", "site_admin": false } ], "milestone": null, "comments": 2, "created_at": "2017-06-14T11:57:35Z", "updated_at": "2017-06-15T07:10:43Z", "closed_at": "2017-06-14T21:10:44Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9755", "html_url": "https://github.com/electron/electron/pull/9755", "diff_url": "https://github.com/electron/electron/pull/9755.diff", "patch_url": "https://github.com/electron/electron/pull/9755.patch" }, "body": "Replace \"Windows 8\" to \"Windows 10\"\r\n\r\n**Windows 10** introduced **UWP**, although **WinRT** the API had been since Windows 8.\r\n\r\nApplication Containerization/Virtualization within UWP called _Project Centennial_ aka **Desktop Bridge** introduced _Windows 10 Build 14393_ aka **Anniversary Update**.\r\n\r\nI think this should clarify some things..." }, { "url": "https://api.github.com/repos/electron/electron/issues/9754", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9754/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9754/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9754/events", "html_url": "https://github.com/electron/electron/pull/9754", "id": 235830112, "number": 9754, "title": "Create app.md", "user": { "login": "t-hofmann", "id": 21239924, "avatar_url": "https://avatars3.githubusercontent.com/u/21239924?v=3", "gravatar_id": "", "url": "https://api.github.com/users/t-hofmann", "html_url": "https://github.com/t-hofmann", "followers_url": "https://api.github.com/users/t-hofmann/followers", "following_url": "https://api.github.com/users/t-hofmann/following{/other_user}", "gists_url": "https://api.github.com/users/t-hofmann/gists{/gist_id}", "starred_url": "https://api.github.com/users/t-hofmann/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/t-hofmann/subscriptions", "organizations_url": "https://api.github.com/users/t-hofmann/orgs", "repos_url": "https://api.github.com/users/t-hofmann/repos", "events_url": "https://api.github.com/users/t-hofmann/events{/privacy}", "received_events_url": "https://api.github.com/users/t-hofmann/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-14T10:14:09Z", "updated_at": "2017-06-26T15:54:13Z", "closed_at": "2017-06-26T15:53:45Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9754", "html_url": "https://github.com/electron/electron/pull/9754", "diff_url": "https://github.com/electron/electron/pull/9754.diff", "patch_url": "https://github.com/electron/electron/pull/9754.patch" }, "body": "clarification in respect of execution structure" }, { "url": "https://api.github.com/repos/electron/electron/issues/9753", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9753/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9753/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9753/events", "html_url": "https://github.com/electron/electron/issues/9753", "id": 235824136, "number": 9753, "title": "Frameless window has frame on macOS High Sierra Beta", "user": { "login": "manspeterson", "id": 9446455, "avatar_url": "https://avatars0.githubusercontent.com/u/9446455?v=3", "gravatar_id": "", "url": "https://api.github.com/users/manspeterson", "html_url": "https://github.com/manspeterson", "followers_url": "https://api.github.com/users/manspeterson/followers", "following_url": "https://api.github.com/users/manspeterson/following{/other_user}", "gists_url": "https://api.github.com/users/manspeterson/gists{/gist_id}", "starred_url": "https://api.github.com/users/manspeterson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manspeterson/subscriptions", "organizations_url": "https://api.github.com/users/manspeterson/orgs", "repos_url": "https://api.github.com/users/manspeterson/repos", "events_url": "https://api.github.com/users/manspeterson/events{/privacy}", "received_events_url": "https://api.github.com/users/manspeterson/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-14T09:52:13Z", "updated_at": "2017-06-14T09:53:34Z", "closed_at": "2017-06-14T09:53:34Z", "body": "\r\n\r\n* Electron version: v1.6.11\r\n* Operating system: MacOS High Sierra Beta (10.13)\r\n\r\n### Expected behavior\r\n\r\nWindow should be frameless when BrowserWindow has property \"frame : false\".\r\n\r\n\r\n\r\n### Actual behavior\r\n\r\nWindow shows title frame. See screenshot.\r\n\r\n![Frameless window with frame](https://www.dropbox.com/s/w0872k9t0rhqsll/Sk%C3%A4rmklipp%202017-06-14%2011.47.39.png?dl=1)\r\n\r\n\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9752", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9752/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9752/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9752/events", "html_url": "https://github.com/electron/electron/issues/9752", "id": 235761443, "number": 9752, "title": "AutoUpdate Error code = 13 Permission Denied", "user": { "login": "stephennyu", "id": 17565678, "avatar_url": "https://avatars2.githubusercontent.com/u/17565678?v=3", "gravatar_id": "", "url": "https://api.github.com/users/stephennyu", "html_url": "https://github.com/stephennyu", "followers_url": "https://api.github.com/users/stephennyu/followers", "following_url": "https://api.github.com/users/stephennyu/following{/other_user}", "gists_url": "https://api.github.com/users/stephennyu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stephennyu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stephennyu/subscriptions", "organizations_url": "https://api.github.com/users/stephennyu/orgs", "repos_url": "https://api.github.com/users/stephennyu/repos", "events_url": "https://api.github.com/users/stephennyu/events{/privacy}", "received_events_url": "https://api.github.com/users/stephennyu/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-14T04:46:34Z", "updated_at": "2017-06-14T04:46:34Z", "closed_at": null, "body": "Hi, currently I am having problem with the autoupdate in electron application. Here is the case.\r\n1. The application is able to check for update and successfully downloaded the update\r\n2. The application quits and re-launch however the version is not updated\r\n3. I checkout into the ShipIt_stderr.log and here is what I got\r\n\r\n```\r\n2017-06-14 11:32:15.589 ShipIt[44423:915887] Beginning installation\r\n2017-06-14 11:32:23.460 ShipIt[44423:915887] Installation error: Error Domain=NSPOSIXErrorDomain Code=13 \"Permission denied\" UserInfo={NSLocalizedDescription=Permission denied}\r\n2017-06-14 11:32:23.460 ShipIt[44423:915887] ShipIt quitting\r\n2017-06-14 11:32:23.550 ShipIt[44440:916130] Resuming installation attempt 2\r\n2017-06-14 11:32:33.271 ShipIt[44440:916133] Installation error: Error Domain=NSPOSIXErrorDomain Code=13 \"Permission denied\" UserInfo={NSLocalizedDescription=Permission denied}\r\n2017-06-14 11:32:33.271 ShipIt[44440:916133] ShipIt quitting\r\n2017-06-14 11:32:33.331 ShipIt[44443:916501] Resuming installation attempt 3\r\n2017-06-14 11:32:41.436 ShipIt[44443:916504] Installation error: Error Domain=NSPOSIXErrorDomain Code=13 \"Permission denied\" UserInfo={NSLocalizedDescription=Permission denied}\r\n2017-06-14 11:32:41.436 ShipIt[44443:916504] ShipIt quitting\r\n2017-06-14 11:32:41.552 ShipIt[44444:916571] Too many attempts to install, aborting update\r\n2017-06-14 11:32:41.554 ShipIt[44444:916574] ShipIt quitting\r\n```\r\n\r\n* Electron version: 1.6.11\r\n* Operating system: Mac OS X 10.12.5\r\n\r\nActually this issue never happened before and after I got my electron version updated, there is this issue happening. I try to downgrade my electron version to 1.4.15 and 1.6.6 and 1.6.10 but no luck the problem still persists.\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9751", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9751/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9751/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9751/events", "html_url": "https://github.com/electron/electron/pull/9751", "id": 235688866, "number": 9751, "title": "use lowercase for optional annotation", "user": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-13T20:51:25Z", "updated_at": "2017-06-15T17:12:23Z", "closed_at": "2017-06-15T17:12:15Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9751", "html_url": "https://github.com/electron/electron/pull/9751", "diff_url": "https://github.com/electron/electron/pull/9751.diff", "patch_url": "https://github.com/electron/electron/pull/9751.patch" }, "body": "A little followup to #9750 that favors lowercase `(optional)` over `(Optional)` in API documentation." }, { "url": "https://api.github.com/repos/electron/electron/issues/9750", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9750/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9750/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9750/events", "html_url": "https://github.com/electron/electron/pull/9750", "id": 235649306, "number": 9750, "title": "Make clearStorageData options object's property optional", "user": { "login": "MarshallOfSound", "id": 6634592, "avatar_url": "https://avatars0.githubusercontent.com/u/6634592?v=3", "gravatar_id": "", "url": "https://api.github.com/users/MarshallOfSound", "html_url": "https://github.com/MarshallOfSound", "followers_url": "https://api.github.com/users/MarshallOfSound/followers", "following_url": "https://api.github.com/users/MarshallOfSound/following{/other_user}", "gists_url": "https://api.github.com/users/MarshallOfSound/gists{/gist_id}", "starred_url": "https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MarshallOfSound/subscriptions", "organizations_url": "https://api.github.com/users/MarshallOfSound/orgs", "repos_url": "https://api.github.com/users/MarshallOfSound/repos", "events_url": "https://api.github.com/users/MarshallOfSound/events{/privacy}", "received_events_url": "https://api.github.com/users/MarshallOfSound/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-13T18:34:18Z", "updated_at": "2017-06-13T20:48:15Z", "closed_at": "2017-06-13T20:48:11Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9750", "html_url": "https://github.com/electron/electron/pull/9750", "diff_url": "https://github.com/electron/electron/pull/9750.diff", "patch_url": "https://github.com/electron/electron/pull/9750.patch" }, "body": "Fixes #9749" }, { "url": "https://api.github.com/repos/electron/electron/issues/9749", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9749/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9749/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9749/events", "html_url": "https://github.com/electron/electron/issues/9749", "id": 235640023, "number": 9749, "title": "Properties of ClearStorageDataOptions interface should not be required", "user": { "login": "craxal", "id": 3473026, "avatar_url": "https://avatars2.githubusercontent.com/u/3473026?v=3", "gravatar_id": "", "url": "https://api.github.com/users/craxal", "html_url": "https://github.com/craxal", "followers_url": "https://api.github.com/users/craxal/followers", "following_url": "https://api.github.com/users/craxal/following{/other_user}", "gists_url": "https://api.github.com/users/craxal/gists{/gist_id}", "starred_url": "https://api.github.com/users/craxal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/craxal/subscriptions", "organizations_url": "https://api.github.com/users/craxal/orgs", "repos_url": "https://api.github.com/users/craxal/repos", "events_url": "https://api.github.com/users/craxal/events{/privacy}", "received_events_url": "https://api.github.com/users/craxal/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 535372304, "url": "https://api.github.com/repos/electron/electron/labels/help/docs", "name": "help/docs", "color": "5319e7", "default": false } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-13T18:06:56Z", "updated_at": "2017-06-13T21:02:44Z", "closed_at": "2017-06-13T20:48:11Z", "body": "* Electron version: 1.7.2\r\n* Operating system: Windows 10\r\n\r\n### Expected behavior\r\nAll properties as defined by the `ClearStorageDataOptions` interface should be optional. When passing an options object to `session.clearStorageData`, I should only have to specify the options I want.\r\n\r\n### Actual behavior\r\nAll properties as defined by the `ClearStorageDataOptions` interface are declared as required. When passing an options object to `session.clearStorageData`, Typescript requires I define all three properties.\r\n\r\nThere is an easy workaround. Just insert an `` cast.\r\n\r\n### How to reproduce\r\n1. Create a sample Electron project using Typescript.\r\n2. Insert the following code somewhere in the renderer process:\r\n```ts\r\nwindow.webContents.session.cleareStorageData({ storages: [\"cookies\"] });\r\n```\r\n3. Compile using `tsc`. Typescript reports an error." }, { "url": "https://api.github.com/repos/electron/electron/issues/9748", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9748/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9748/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9748/events", "html_url": "https://github.com/electron/electron/issues/9748", "id": 235609203, "number": 9748, "title": "Feature request. Add Dragon Web extension for chrome.", "user": { "login": "alsoeric", "id": 8798037, "avatar_url": "https://avatars0.githubusercontent.com/u/8798037?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alsoeric", "html_url": "https://github.com/alsoeric", "followers_url": "https://api.github.com/users/alsoeric/followers", "following_url": "https://api.github.com/users/alsoeric/following{/other_user}", "gists_url": "https://api.github.com/users/alsoeric/gists{/gist_id}", "starred_url": "https://api.github.com/users/alsoeric/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alsoeric/subscriptions", "organizations_url": "https://api.github.com/users/alsoeric/orgs", "repos_url": "https://api.github.com/users/alsoeric/repos", "events_url": "https://api.github.com/users/alsoeric/events{/privacy}", "received_events_url": "https://api.github.com/users/alsoeric/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-13T16:14:32Z", "updated_at": "2017-06-13T16:14:32Z", "closed_at": null, "body": "Adding the Dragon Web extension for chrome to electron might make NaturallySpeaking work better with electron based apps." }, { "url": "https://api.github.com/repos/electron/electron/issues/9747", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9747/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9747/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9747/events", "html_url": "https://github.com/electron/electron/issues/9747", "id": 235592358, "number": 9747, "title": "Incorrect status code/headers on response from NTLM proxy when using net module", "user": { "login": "eugirdor", "id": 1062181, "avatar_url": "https://avatars2.githubusercontent.com/u/1062181?v=3", "gravatar_id": "", "url": "https://api.github.com/users/eugirdor", "html_url": "https://github.com/eugirdor", "followers_url": "https://api.github.com/users/eugirdor/followers", "following_url": "https://api.github.com/users/eugirdor/following{/other_user}", "gists_url": "https://api.github.com/users/eugirdor/gists{/gist_id}", "starred_url": "https://api.github.com/users/eugirdor/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eugirdor/subscriptions", "organizations_url": "https://api.github.com/users/eugirdor/orgs", "repos_url": "https://api.github.com/users/eugirdor/repos", "events_url": "https://api.github.com/users/eugirdor/events{/privacy}", "received_events_url": "https://api.github.com/users/eugirdor/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-13T15:21:29Z", "updated_at": "2017-06-15T16:07:03Z", "closed_at": null, "body": "* Electron version: 1.6.8\r\n* Operating system: Windows 8.1\r\n\r\nI am in the process of switching our app over to use the `net` module so that we can better support NTLM proxies, but I'm running into a strange issue:\r\n\r\nWhen reading the response from the `response` event of `net.request()` I am getting back the correct body, but the `statusCode`, `statusMessage` and `headers` all appear incorrect.\r\n\r\n```\r\nstatusCode: 407\r\nstatusMessage: \"Proxy Authorization Required\"\r\nheaders: {\r\n 'content-length': '2629',\r\n 'proxy-authenticate': [ 'NTLM' ],\r\n 'proxy-connection': '[ keep-alive' ]\r\n}\r\n```\r\n\r\nLike I said, the body of the response is correct. I turned on `--log-net-log` and from the log I can see that the app went through the whole NTLM handshake, and I can also see my request with the proper `200 OK` status and appropriate headers.\r\n\r\nIt appears that the status code/message/headers I am getting are the initial headers returned from the NTLM handshake instead of the final headers.\r\n\r\nSnippets from the net log below:\r\n\r\n```\r\n21: SOCKET\r\npm/ssl/xxx:443\r\nStart Time: 2017-06-13 09:29:11.921\r\n\r\nt=1126 [st= 0] +SOCKET_ALIVE [dt=3219]\r\n --> source_dependency = 20 (CONNECT_JOB)\r\nt=1126 [st= 0] +TCP_CONNECT [dt=1]\r\n --> address_list = [\"192.168.230.1:8080\"]\r\nt=1126 [st= 0] TCP_CONNECT_ATTEMPT [dt=1]\r\n --> address = \"192.168.230.1:8080\"\r\nt=1127 [st= 1] -TCP_CONNECT\r\n --> source_address = \"192.168.230.5:49548\"\r\nt=1127 [st= 1] +SOCKET_IN_USE [dt=3218]\r\n --> source_dependency = 19 (PROXY_CLIENT_SOCKET_WRAPPER)\r\nt=1127 [st= 1] +HTTP_TRANSACTION_TUNNEL_SEND_REQUEST [dt=0]\r\nt=1127 [st= 1] HTTP_TRANSACTION_SEND_TUNNEL_HEADERS\r\n --> CONNECT xxx:443 HTTP/1.1\r\n Host: xxx:443\r\n Proxy-Connection: keep-alive\r\n User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) xxx Chrome/56.0.2924.87 Electron/1.6.8 Safari/537.36\r\nt=1127 [st= 1] HTTP_TRANSACTION_SEND_REQUEST_HEADERS\r\n --> CONNECT xxx:443 HTTP/1.1\r\n Host: xxx:443\r\n Proxy-Connection: keep-alive\r\n User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) xxx Chrome/56.0.2924.87 Electron/1.6.8 Safari/537.36\r\nt=1127 [st= 1] SOCKET_BYTES_SENT\r\n --> byte_count = 270\r\nt=1127 [st= 1] -HTTP_TRANSACTION_TUNNEL_SEND_REQUEST\r\nt=1127 [st= 1] +HTTP_TRANSACTION_TUNNEL_READ_HEADERS [dt=3]\r\nt=1127 [st= 1] +HTTP_STREAM_PARSER_READ_HEADERS [dt=1]\r\nt=1128 [st= 2] SOCKET_BYTES_RECEIVED\r\n --> byte_count = 2895\r\nt=1128 [st= 2] -HTTP_STREAM_PARSER_READ_HEADERS\r\nt=1128 [st= 2] HTTP_TRANSACTION_READ_TUNNEL_RESPONSE_HEADERS\r\n --> HTTP/1.1 407 Proxy Authorization Required\r\n Proxy-Authenticate: NTLM\r\n Date: Tue, 13 Jun 2017 14:29:12 GMT\r\n Cache-Control: no-cache\r\n Pragma: no-cache\r\n Content-Type: text/html; charset=\"UTF-8\"\r\n Content-Length: 2629\r\n Accept-Ranges: none\r\n Proxy-Connection: keep-alive\r\nt=1130 [st= 4] -HTTP_TRANSACTION_TUNNEL_READ_HEADERS\r\n --> net_error = -127 (ERR_PROXY_AUTH_REQUESTED)\r\nt=1130 [st= 4] AUTH_PROXY [dt=0]\r\nt=1130 [st= 4] +HTTP_TRANSACTION_TUNNEL_SEND_REQUEST [dt=1]\r\nt=1130 [st= 4] HTTP_TRANSACTION_SEND_TUNNEL_HEADERS\r\n --> CONNECT xxx:443 HTTP/1.1\r\n Host: xxx:443\r\n Proxy-Connection: keep-alive\r\n User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) xxx Chrome/56.0.2924.87 Electron/1.6.8 Safari/537.36\r\n Proxy-Authorization: [61 bytes were stripped]\r\nt=1131 [st= 5] HTTP_TRANSACTION_SEND_REQUEST_HEADERS\r\n --> CONNECT xxx:443 HTTP/1.1\r\n Host: xxx:443\r\n Proxy-Connection: keep-alive\r\n User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) xxx Chrome/56.0.2924.87 Electron/1.6.8 Safari/537.36\r\n Proxy-Authorization: [61 bytes were stripped]\r\nt=1131 [st= 5] SOCKET_BYTES_SENT\r\n --> byte_count = 354\r\nt=1131 [st= 5] -HTTP_TRANSACTION_TUNNEL_SEND_REQUEST\r\nt=1131 [st= 5] +HTTP_TRANSACTION_TUNNEL_READ_HEADERS [dt=0]\r\nt=1131 [st= 5] +HTTP_STREAM_PARSER_READ_HEADERS [dt=0]\r\nt=1131 [st= 5] SOCKET_BYTES_RECEIVED\r\n --> byte_count = 3164\r\nt=1131 [st= 5] -HTTP_STREAM_PARSER_READ_HEADERS\r\nt=1131 [st= 5] HTTP_TRANSACTION_READ_TUNNEL_RESPONSE_HEADERS\r\n --> HTTP/1.1 407 Proxy Authorization Required\r\n Proxy-Authenticate: NTLM [268 bytes were stripped]\r\n Date: Tue, 13 Jun 2017 14:29:12 GMT\r\n Cache-Control: no-cache\r\n Pragma: no-cache\r\n Content-Type: text/html; charset=\"UTF-8\"\r\n Content-Length: 2629\r\n Accept-Ranges: none\r\n Proxy-Connection: keep-alive\r\nt=1131 [st= 5] -HTTP_TRANSACTION_TUNNEL_READ_HEADERS\r\n --> net_error = -127 (ERR_PROXY_AUTH_REQUESTED)\r\nt=1132 [st= 6] AUTH_PROXY [dt=0]\r\nt=1132 [st= 6] +HTTP_TRANSACTION_TUNNEL_SEND_REQUEST [dt=0]\r\nt=1132 [st= 6] HTTP_TRANSACTION_SEND_TUNNEL_HEADERS\r\n --> CONNECT xxx:443 HTTP/1.1\r\n Host: xxx:443\r\n Proxy-Connection: keep-alive\r\n User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) xxx Chrome/56.0.2924.87 Electron/1.6.8 Safari/537.36\r\n Proxy-Authorization: [645 bytes were stripped]\r\nt=1132 [st= 6] HTTP_TRANSACTION_SEND_REQUEST_HEADERS\r\n --> CONNECT xxx:443 HTTP/1.1\r\n Host: xxx:443\r\n Proxy-Connection: keep-alive\r\n User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) xxx Chrome/56.0.2924.87 Electron/1.6.8 Safari/537.36\r\n Proxy-Authorization: [645 bytes were stripped]\r\nt=1132 [st= 6] SOCKET_BYTES_SENT\r\n --> byte_count = 938\r\nt=1132 [st= 6] -HTTP_TRANSACTION_TUNNEL_SEND_REQUEST\r\nt=1132 [st= 6] +HTTP_TRANSACTION_TUNNEL_READ_HEADERS [dt=36]\r\nt=1132 [st= 6] +HTTP_STREAM_PARSER_READ_HEADERS [dt=36]\r\nt=1168 [st= 42] SOCKET_BYTES_RECEIVED\r\n --> byte_count = 69\r\nt=1168 [st= 42] -HTTP_STREAM_PARSER_READ_HEADERS\r\nt=1168 [st= 42] HTTP_TRANSACTION_READ_TUNNEL_RESPONSE_HEADERS\r\n --> HTTP/1.1 200 Connection Established\r\n Proxy-Connection: keep-alive\r\nt=1168 [st= 42] -HTTP_TRANSACTION_TUNNEL_READ_HEADERS\r\nt=1169 [st= 43] SOCKET_BYTES_SENT\r\n --> byte_count = 207\r\nt=1217 [st= 91] SOCKET_BYTES_RECEIVED\r\n --> byte_count = 4096\r\nt=1221 [st= 95] SOCKET_BYTES_RECEIVED\r\n --> byte_count = 1108\r\nt=1223 [st= 97] SOCKET_BYTES_SENT\r\n --> byte_count = 126\r\nt=1249 [st= 123] SOCKET_BYTES_RECEIVED\r\n --> byte_count = 51\r\nt=1269 [st= 143] SOCKET_BYTES_SENT\r\n --> byte_count = 358\r\nt=1298 [st= 172] SOCKET_BYTES_RECEIVED\r\n --> byte_count = 449\r\nt=4345 [st=3219] SOCKET_CLOSED\r\nt=4345 [st=3219] -SOCKET_IN_USE\r\nt=4345 [st=3219] -SOCKET_ALIVE\r\n```\r\n\r\n```\r\n2: URL_REQUEST\r\nxxx\r\nStart Time: 2017-06-13 09:29:10.873\r\n\r\nt= 78 [st= 0] +REQUEST_ALIVE [dt=1221]\r\nt= 78 [st= 0] URL_REQUEST_DELEGATE [dt=0]\r\nt= 78 [st= 0] +URL_REQUEST_START_JOB [dt=1221]\r\n --> load_flags = 512 (DO_NOT_SEND_COOKIES)\r\n --> method = \"GET\"\r\n --> priority = \"LOWEST\"\r\n --> upload_id = \"0\"\r\n --> url = \"xxx\"\r\nt= 78 [st= 0] URL_REQUEST_DELEGATE [dt=0]\r\nt= 78 [st= 0] HTTP_CACHE_GET_BACKEND [dt=19]\r\nt= 97 [st= 19] HTTP_CACHE_OPEN_ENTRY [dt=0]\r\n --> net_error = -2 (ERR_FAILED)\r\nt= 97 [st= 19] HTTP_CACHE_CREATE_ENTRY [dt=1]\r\nt= 98 [st= 20] HTTP_CACHE_ADD_TO_ENTRY [dt=0]\r\nt= 98 [st= 20] +HTTP_STREAM_REQUEST [dt=1171]\r\nt= 98 [st= 20] HTTP_STREAM_REQUEST_STARTED_JOB\r\n --> source_dependency = 6 (HTTP_STREAM_JOB)\r\nt=1130 [st=1052] HTTP_STREAM_REQUEST_BOUND_TO_JOB\r\n --> source_dependency = 6 (HTTP_STREAM_JOB)\r\nt=1130 [st=1052] URL_REQUEST_DELEGATE [dt=0]\r\nt=1130 [st=1052] URL_REQUEST_DELEGATE [dt=0]\r\nt=1131 [st=1053] URL_REQUEST_DELEGATE [dt=1]\r\nt=1132 [st=1054] URL_REQUEST_DELEGATE [dt=0]\r\nt=1269 [st=1191] -HTTP_STREAM_REQUEST\r\nt=1269 [st=1191] UPLOAD_DATA_STREAM_INIT [dt=0]\r\n --> is_chunked = false\r\n --> net_error = 0 (?)\r\n --> total_size = 0\r\nt=1269 [st=1191] +HTTP_TRANSACTION_SEND_REQUEST [dt=0]\r\nt=1269 [st=1191] HTTP_TRANSACTION_SEND_REQUEST_HEADERS\r\n --> GET xxx HTTP/1.1\r\n Host: xxx\r\n Connection: keep-alive\r\n Content-Length: 0\r\n User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) xxx Chrome/56.0.2924.87 Electron/1.6.8 Safari/537.36\r\n Accept-Encoding: gzip, deflate\r\n Accept-Language: en-US\r\nt=1269 [st=1191] -HTTP_TRANSACTION_SEND_REQUEST\r\nt=1269 [st=1191] +HTTP_TRANSACTION_READ_HEADERS [dt=29]\r\nt=1269 [st=1191] HTTP_STREAM_PARSER_READ_HEADERS [dt=29]\r\nt=1298 [st=1220] HTTP_TRANSACTION_READ_RESPONSE_HEADERS\r\n --> HTTP/1.1 200 OK\r\n Cache-Control: no-store, must-revalidate, no-cache, private\r\n Content-Type: application/json; charset=utf-8\r\n Date: Tue, 13 Jun 2017 14:29:12 GMT\r\n P3P: CP=\"NON ONL UNI COM NAV INT STA CURa OUR IND\"\r\n Pragma: no-cache\r\n Server: \r\n Set-Cookie: [30 bytes were stripped]\r\n X-Content-Type-Options: nosniff\r\n X-XSS-Protection: 1; mode=block\r\n Content-Length: 22\r\n Connection: keep-alive\r\nt=1298 [st=1220] -HTTP_TRANSACTION_READ_HEADERS\r\nt=1298 [st=1220] HTTP_CACHE_WRITE_INFO [dt=0]\r\nt=1298 [st=1220] URL_REQUEST_DELEGATE [dt=0]\r\nt=1299 [st=1221] -URL_REQUEST_START_JOB\r\nt=1299 [st=1221] URL_REQUEST_DELEGATE [dt=0]\r\nt=1299 [st=1221] HTTP_TRANSACTION_READ_BODY [dt=0]\r\nt=1299 [st=1221] URL_REQUEST_JOB_FILTERED_BYTES_READ\r\n --> byte_count = 22\r\nt=1299 [st=1221] HTTP_TRANSACTION_READ_BODY [dt=0]\r\nt=1299 [st=1221] -REQUEST_ALIVE\r\n```" }, { "url": "https://api.github.com/repos/electron/electron/issues/9746", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9746/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9746/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9746/events", "html_url": "https://github.com/electron/electron/issues/9746", "id": 235571398, "number": 9746, "title": "打包后的exe，如何接收外部程序调用 时，传递的参数", "user": { "login": "tkggusraqk", "id": 5164663, "avatar_url": "https://avatars3.githubusercontent.com/u/5164663?v=3", "gravatar_id": "", "url": "https://api.github.com/users/tkggusraqk", "html_url": "https://github.com/tkggusraqk", "followers_url": "https://api.github.com/users/tkggusraqk/followers", "following_url": "https://api.github.com/users/tkggusraqk/following{/other_user}", "gists_url": "https://api.github.com/users/tkggusraqk/gists{/gist_id}", "starred_url": "https://api.github.com/users/tkggusraqk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tkggusraqk/subscriptions", "organizations_url": "https://api.github.com/users/tkggusraqk/orgs", "repos_url": "https://api.github.com/users/tkggusraqk/repos", "events_url": "https://api.github.com/users/tkggusraqk/events{/privacy}", "received_events_url": "https://api.github.com/users/tkggusraqk/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-13T14:20:54Z", "updated_at": "2017-06-15T05:23:57Z", "closed_at": null, "body": "electron 程序打包完成后，比如app.exe；需要对接一个第三方程序，在这个第三方程序里启动 app.exe，同时传递 启动参数，比如用c#调用 app.exe：\r\n Process proc = new Process();\r\n proc.StartInfo.FileName = startPath;\r\n proc.StartInfo.Arguments = \"-name test\";\r\n proc.Start();\r\n如何在app.exe启动的时候 接收到这些参数 ：-name test" }, { "url": "https://api.github.com/repos/electron/electron/issues/9745", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9745/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9745/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9745/events", "html_url": "https://github.com/electron/electron/pull/9745", "id": 235556440, "number": 9745, "title": "Add 'All Files (*.*)' filter for file dialog", "user": { "login": "yuya-oc", "id": 1412057, "avatar_url": "https://avatars3.githubusercontent.com/u/1412057?v=3", "gravatar_id": "", "url": "https://api.github.com/users/yuya-oc", "html_url": "https://github.com/yuya-oc", "followers_url": "https://api.github.com/users/yuya-oc/followers", "following_url": "https://api.github.com/users/yuya-oc/following{/other_user}", "gists_url": "https://api.github.com/users/yuya-oc/gists{/gist_id}", "starred_url": "https://api.github.com/users/yuya-oc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yuya-oc/subscriptions", "organizations_url": "https://api.github.com/users/yuya-oc/orgs", "repos_url": "https://api.github.com/users/yuya-oc/repos", "events_url": "https://api.github.com/users/yuya-oc/events{/privacy}", "received_events_url": "https://api.github.com/users/yuya-oc/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-13T13:35:59Z", "updated_at": "2017-06-13T13:35:59Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9745", "html_url": "https://github.com/electron/electron/pull/9745", "diff_url": "https://github.com/electron/electron/pull/9745.diff", "patch_url": "https://github.com/electron/electron/pull/9745.patch" }, "body": "The dialog would filter files as well as Chrome, especially when using webview or BrowserView." }, { "url": "https://api.github.com/repos/electron/electron/issues/9744", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9744/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9744/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9744/events", "html_url": "https://github.com/electron/electron/issues/9744", "id": 235555307, "number": 9744, "title": "When application was minimized by click on taskbar icon, some BrowserWindow API is broken", "user": { "login": "cumajkeee", "id": 1834053, "avatar_url": "https://avatars0.githubusercontent.com/u/1834053?v=3", "gravatar_id": "", "url": "https://api.github.com/users/cumajkeee", "html_url": "https://github.com/cumajkeee", "followers_url": "https://api.github.com/users/cumajkeee/followers", "following_url": "https://api.github.com/users/cumajkeee/following{/other_user}", "gists_url": "https://api.github.com/users/cumajkeee/gists{/gist_id}", "starred_url": "https://api.github.com/users/cumajkeee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cumajkeee/subscriptions", "organizations_url": "https://api.github.com/users/cumajkeee/orgs", "repos_url": "https://api.github.com/users/cumajkeee/repos", "events_url": "https://api.github.com/users/cumajkeee/events{/privacy}", "received_events_url": "https://api.github.com/users/cumajkeee/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-13T13:32:27Z", "updated_at": "2017-06-13T13:35:05Z", "closed_at": null, "body": "\r\n\r\n* Electron version:1.6.11\r\n* Operating system: Windows\r\n\r\n### Expected behavior\r\nwin.isFocused() and win.isVisible() should be false when window is minimized.\r\n\r\n### Actual behavior\r\n```\r\nwin.isFocused() // true (can be so, but I do not believe that some one expect minimized window to be focused)\r\nwin.isVisible() // true\r\n```\r\n\r\n### How to reproduce\r\n```\r\nconst {app, BrowserWindow} = require('electron')\r\n\r\nlet mainWindow\r\n\r\napp.on('ready', () => {\r\n mainWindow = new BrowserWindow()\r\n mainWindow.loadURL('about:blank')\r\n\r\n setTimeout(() => {\r\n console.log(mainWindow.isFocused(), mainWindow.isVisible());\r\n }, 10000)\r\n})\r\n\r\napp.on('quit', () => {\r\n app.quit()\r\n})\r\n\r\n```" }, { "url": "https://api.github.com/repos/electron/electron/issues/9743", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9743/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9743/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9743/events", "html_url": "https://github.com/electron/electron/pull/9743", "id": 235508947, "number": 9743, "title": "Don't mutate the accelerator character with the shift key if it's a number", "user": { "login": "MarshallOfSound", "id": 6634592, "avatar_url": "https://avatars0.githubusercontent.com/u/6634592?v=3", "gravatar_id": "", "url": "https://api.github.com/users/MarshallOfSound", "html_url": "https://github.com/MarshallOfSound", "followers_url": "https://api.github.com/users/MarshallOfSound/followers", "following_url": "https://api.github.com/users/MarshallOfSound/following{/other_user}", "gists_url": "https://api.github.com/users/MarshallOfSound/gists{/gist_id}", "starred_url": "https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MarshallOfSound/subscriptions", "organizations_url": "https://api.github.com/users/MarshallOfSound/orgs", "repos_url": "https://api.github.com/users/MarshallOfSound/repos", "events_url": "https://api.github.com/users/MarshallOfSound/events{/privacy}", "received_events_url": "https://api.github.com/users/MarshallOfSound/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-13T10:32:13Z", "updated_at": "2017-06-26T18:20:55Z", "closed_at": "2017-06-26T18:20:52Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9743", "html_url": "https://github.com/electron/electron/pull/9743", "diff_url": "https://github.com/electron/electron/pull/9743.diff", "patch_url": "https://github.com/electron/electron/pull/9743.patch" }, "body": "Before this fix if you had an accelerator.\r\n\r\n```\r\nCommandOrControl+Shift+1\r\n```\r\n\r\nIt would be represented in menus as \"Command+!\" which although is correct in regards to keycodes it isn't semantically correct from a users perspective, nor from the intention of the shortcut in most cases.\r\n\r\nThis fix will unmutate the character if it is a number" }, { "url": "https://api.github.com/repos/electron/electron/issues/9742", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9742/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9742/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9742/events", "html_url": "https://github.com/electron/electron/issues/9742", "id": 235466070, "number": 9742, "title": "How build electron with shared node and openssl?", "user": { "login": "algv", "id": 16474118, "avatar_url": "https://avatars2.githubusercontent.com/u/16474118?v=3", "gravatar_id": "", "url": "https://api.github.com/users/algv", "html_url": "https://github.com/algv", "followers_url": "https://api.github.com/users/algv/followers", "following_url": "https://api.github.com/users/algv/following{/other_user}", "gists_url": "https://api.github.com/users/algv/gists{/gist_id}", "starred_url": "https://api.github.com/users/algv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/algv/subscriptions", "organizations_url": "https://api.github.com/users/algv/orgs", "repos_url": "https://api.github.com/users/algv/repos", "events_url": "https://api.github.com/users/algv/events{/privacy}", "received_events_url": "https://api.github.com/users/algv/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-13T07:52:49Z", "updated_at": "2017-06-13T07:52:49Z", "closed_at": null, "body": "For build electron with shared openssl on Linux add:\r\n_./common.gypi:_\r\n `'node_shared_openssl': 'true'`\r\n\r\n_./vendor/node/node.gyp:_\r\n```\r\n'libraries': [ '-L/trustedssl/lib',\r\n '-lcrypto',\r\n '-lssl',\r\n '-Wl,-rpath,/trustedssl/lib'],\r\n```\r\nBuild success. Now get ciphers:\r\n```JS\r\nvar tls = require('tls')\r\ntls.getCiphers()\r\n```\r\n\r\n> Array[32]\r\n> \r\n> 0:\"aes128-gcm-sha256\"\r\n> 1:\"aes128-sha\"\r\n> 2:\"aes128-sha256\"\r\n> 3:\"aes256-gcm-sha384\"\r\n> 4:\"aes256-sha\"\r\n> 5:\"aes256-sha256\"\r\n> 6:\"des-cbc3-sha\"\r\n> 7:\"dhe-rsa-aes128-gcm-sha256\"\r\n> 8:\"dhe-rsa-aes128-sha\"\r\n> 9:\"dhe-rsa-aes128-sha256\"\r\n> 10:\"dhe-rsa-aes256-gcm-sha384\"\r\n> 11:\"dhe-rsa-aes256-sha\"\r\n> 12:\"dhe-rsa-aes256-sha256\"\r\n> 13:\"ecdhe-ecdsa-aes128-gcm-sha256\"\r\n> 14:\"ecdhe-ecdsa-aes128-sha\"\r\n> 15:\"ecdhe-ecdsa-aes128-sha256\"\r\n> 16:\"ecdhe-ecdsa-aes256-gcm-sha384\"\r\n> 17:\"ecdhe-ecdsa-aes256-sha\"\r\n> 18:\"ecdhe-ecdsa-aes256-sha384\"\r\n> 19:\"ecdhe-ecdsa-chacha20-poly1305\"\r\n> 20:\"ecdhe-psk-aes128-cbc-sha\"\r\n> 21:\"ecdhe-psk-aes256-cbc-sha\"\r\n> 22:\"ecdhe-psk-chacha20-poly1305\"\r\n> 23:\"ecdhe-rsa-aes128-gcm-sha256\"\r\n> 24:\"ecdhe-rsa-aes128-sha\"\r\n> 25:\"ecdhe-rsa-aes128-sha256\"\r\n> 26:\"ecdhe-rsa-aes256-gcm-sha384\"\r\n> 27:\"ecdhe-rsa-aes256-sha\"\r\n> 28:\"ecdhe-rsa-aes256-sha384\"\r\n> 29:\"ecdhe-rsa-chacha20-poly1305\"\r\n> 30:\"psk-aes128-cbc-sha\"\r\n> 31:\"psk-aes256-cbc-sha\r\n\r\nIt boringssl out? Because in static build openssl out 98 ciphers. And also cannot load openssl engines (in InitCryptoOnce fprintf ERR_get_error():\r\n\r\n> error:00000000:invalid library (0):OPENSSL_internal:invalid library (0)\r\n\r\nHow can build electron with shared node and shared openssl? Need for support openssl dynamic engines." }, { "url": "https://api.github.com/repos/electron/electron/issues/9741", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9741/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9741/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9741/events", "html_url": "https://github.com/electron/electron/pull/9741", "id": 235348630, "number": 9741, "title": "Send window visibility to webview after DOM ready", "user": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-12T20:00:21Z", "updated_at": "2017-06-14T22:24:00Z", "closed_at": "2017-06-14T22:22:56Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9741", "html_url": "https://github.com/electron/electron/pull/9741", "diff_url": "https://github.com/electron/electron/pull/9741.diff", "patch_url": "https://github.com/electron/electron/pull/9741.patch" }, "body": "There seems to be a possible race condition where `window-setup.js` is loading and cannot receive IPC events and if the window changes visibility during that time, the ``'s `document.visibilityState` will be out of sync with the window.\r\n\r\nThis pull requests listens for `dom-ready` and sends the visibility state to the webview page then to make sure they are in sync.\r\n\r\nCloses #9717" }, { "url": "https://api.github.com/repos/electron/electron/issues/9740", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9740/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9740/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9740/events", "html_url": "https://github.com/electron/electron/issues/9740", "id": 235336730, "number": 9740, "title": "\"unhandledRejection\" never fires in renderer process", "user": { "login": "seanzer", "id": 489755, "avatar_url": "https://avatars0.githubusercontent.com/u/489755?v=3", "gravatar_id": "", "url": "https://api.github.com/users/seanzer", "html_url": "https://github.com/seanzer", "followers_url": "https://api.github.com/users/seanzer/followers", "following_url": "https://api.github.com/users/seanzer/following{/other_user}", "gists_url": "https://api.github.com/users/seanzer/gists{/gist_id}", "starred_url": "https://api.github.com/users/seanzer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/seanzer/subscriptions", "organizations_url": "https://api.github.com/users/seanzer/orgs", "repos_url": "https://api.github.com/users/seanzer/repos", "events_url": "https://api.github.com/users/seanzer/events{/privacy}", "received_events_url": "https://api.github.com/users/seanzer/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-12T19:12:52Z", "updated_at": "2017-06-12T19:12:52Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.7.2\r\n* Operating system: Windows 10 64-bit\r\n\r\n### Expected behavior\r\n\r\n\r\nWhen an unhandled promise rejection is encountered, my \"unhandledRejection\" event handler should be called.\r\n\r\n### Actual behavior\r\nIn Dev Tools window:\r\n>process.on(\"unhandledRejection\", _ => console.log(\"unhandled rejection\"))\r\n>setImmediate(() => Promise.reject(\"foo\"))\r\n\r\nI can see that `emitPendingUnhandledRejections` is called in internal/process/promises.js, but `pendingUnhandledRejections.length` is always 0, so `process.emit` is never called.\r\n\r\nWhen running similar code from the browser, these callback never get called.\r\n\r\n### How to reproduce\r\n\r\n\r\n$ git clone https://github.com/seanzer/electron-quick-start.git -b renderer-unhandledRejection\r\n$ npm i\r\n$ electron .\r\n\r\nClick the buttons in the UI. Note that no text is output for unhandled rejections.\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9739", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9739/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9739/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9739/events", "html_url": "https://github.com/electron/electron/pull/9739", "id": 235332072, "number": 9739, "title": "app: add support for inspect/inspect-brk in forked node process", "user": { "login": "deepak1556", "id": 964386, "avatar_url": "https://avatars2.githubusercontent.com/u/964386?v=3", "gravatar_id": "", "url": "https://api.github.com/users/deepak1556", "html_url": "https://github.com/deepak1556", "followers_url": "https://api.github.com/users/deepak1556/followers", "following_url": "https://api.github.com/users/deepak1556/following{/other_user}", "gists_url": "https://api.github.com/users/deepak1556/gists{/gist_id}", "starred_url": "https://api.github.com/users/deepak1556/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/deepak1556/subscriptions", "organizations_url": "https://api.github.com/users/deepak1556/orgs", "repos_url": "https://api.github.com/users/deepak1556/repos", "events_url": "https://api.github.com/users/deepak1556/events{/privacy}", "received_events_url": "https://api.github.com/users/deepak1556/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-12T18:55:18Z", "updated_at": "2017-06-13T04:00:00Z", "closed_at": "2017-06-12T21:23:34Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9739", "html_url": "https://github.com/electron/electron/pull/9739", "diff_url": "https://github.com/electron/electron/pull/9739.diff", "patch_url": "https://github.com/electron/electron/pull/9739.patch" }, "body": "Fixes https://github.com/electron/electron/issues/9696" }, { "url": "https://api.github.com/repos/electron/electron/issues/9738", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9738/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9738/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9738/events", "html_url": "https://github.com/electron/electron/pull/9738", "id": 235299116, "number": 9738, "title": "Upgrade crashpad for http status fix", "user": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-12T17:05:08Z", "updated_at": "2017-06-12T17:30:38Z", "closed_at": "2017-06-12T17:30:36Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9738", "html_url": "https://github.com/electron/electron/pull/9738", "diff_url": "https://github.com/electron/electron/pull/9738.diff", "patch_url": "https://github.com/electron/electron/pull/9738.patch" }, "body": "Pulls in https://github.com/electron/crashpad/pull/4\r\n\r\n/cc @cifratila " }, { "url": "https://api.github.com/repos/electron/electron/issues/9737", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9737/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9737/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9737/events", "html_url": "https://github.com/electron/electron/issues/9737", "id": 235229206, "number": 9737, "title": "in window 10 uninteractive border in window", "user": { "login": "Ingrim4", "id": 8127996, "avatar_url": "https://avatars3.githubusercontent.com/u/8127996?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Ingrim4", "html_url": "https://github.com/Ingrim4", "followers_url": "https://api.github.com/users/Ingrim4/followers", "following_url": "https://api.github.com/users/Ingrim4/following{/other_user}", "gists_url": "https://api.github.com/users/Ingrim4/gists{/gist_id}", "starred_url": "https://api.github.com/users/Ingrim4/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ingrim4/subscriptions", "organizations_url": "https://api.github.com/users/Ingrim4/orgs", "repos_url": "https://api.github.com/users/Ingrim4/repos", "events_url": "https://api.github.com/users/Ingrim4/events{/privacy}", "received_events_url": "https://api.github.com/users/Ingrim4/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-12T13:17:38Z", "updated_at": "2017-06-12T13:28:40Z", "closed_at": null, "body": "* Electron version: 1.7.3\r\n* Operating system: Windows 10 x64\r\n\r\n### Expected behavior\r\nThe whole area of the window should be clickable and trigger a click event.\r\n\r\n### Actual behavior\r\nThe whole window has a 4px border which doesn't trigger click events. If you remove the `resizable: false` from the BrowserWindow options this bug doesn't occur.\r\n\r\n### How to reproduce\r\n\r\n1. \r\n * $ git clone https://github.com/Ingrim4/electron-quick-start\r\n * $ cd electron-quick-start/\r\n * $ npm install\r\n * $ npm start\r\n2. open the console\r\n3. try clicking the outer ring of the window where you useally would see the resize icon from a resizable window (no event should be printed in the console)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9736", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9736/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9736/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9736/events", "html_url": "https://github.com/electron/electron/issues/9736", "id": 235186137, "number": 9736, "title": "webviewTag is not compatible with contextIsolation", "user": { "login": "pwnsdx", "id": 2057765, "avatar_url": "https://avatars0.githubusercontent.com/u/2057765?v=3", "gravatar_id": "", "url": "https://api.github.com/users/pwnsdx", "html_url": "https://github.com/pwnsdx", "followers_url": "https://api.github.com/users/pwnsdx/followers", "following_url": "https://api.github.com/users/pwnsdx/following{/other_user}", "gists_url": "https://api.github.com/users/pwnsdx/gists{/gist_id}", "starred_url": "https://api.github.com/users/pwnsdx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pwnsdx/subscriptions", "organizations_url": "https://api.github.com/users/pwnsdx/orgs", "repos_url": "https://api.github.com/users/pwnsdx/repos", "events_url": "https://api.github.com/users/pwnsdx/events{/privacy}", "received_events_url": "https://api.github.com/users/pwnsdx/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-12T10:18:18Z", "updated_at": "2017-06-12T10:18:18Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.7.2\r\n* Operating system: macOS Sierra\r\n\r\n### Expected behavior\r\n\r\nWebview appear\r\n\r\n### Actual behavior\r\n\r\nIt don't\r\n\r\n### How to reproduce\r\n\r\n1. Create a browser window with contextIsolation on true and webviewTag on true\r\n2. Inside of it, add a webview\r\n3. Run it, webview should not appear\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9735", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9735/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9735/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9735/events", "html_url": "https://github.com/electron/electron/issues/9735", "id": 235176310, "number": 9735, "title": "Add command line switch to crashpad service for full memory dump creation", "user": { "login": "igorshevach", "id": 10923933, "avatar_url": "https://avatars2.githubusercontent.com/u/10923933?v=3", "gravatar_id": "", "url": "https://api.github.com/users/igorshevach", "html_url": "https://github.com/igorshevach", "followers_url": "https://api.github.com/users/igorshevach/followers", "following_url": "https://api.github.com/users/igorshevach/following{/other_user}", "gists_url": "https://api.github.com/users/igorshevach/gists{/gist_id}", "starred_url": "https://api.github.com/users/igorshevach/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/igorshevach/subscriptions", "organizations_url": "https://api.github.com/users/igorshevach/orgs", "repos_url": "https://api.github.com/users/igorshevach/repos", "events_url": "https://api.github.com/users/igorshevach/events{/privacy}", "received_events_url": "https://api.github.com/users/igorshevach/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-12T09:40:58Z", "updated_at": "2017-06-12T13:58:16Z", "closed_at": null, "body": "\r\n\r\n* Electron version: latest\r\n* Operating system: windows 7/8/10\r\n\r\n### Expected behavior\r\n\r\n\r\ncrashpad service should allow for specifying creation of a full memory dumps just as google breakpad component is designed for.\r\nwhen specifying full dump option following should happen:\r\n- minimal (PEB+TEB) dump will be uploaded to submit url (existing behavior)\r\n- there will be created full memory dump in the the dump folder.\r\n### Actual behavior\r\n\r\n\r\napplication passes minimal dump (PEB+TEB) flags to crashpad service\r\n### How to reproduce\r\n\r\nthis functionality is not yet available\r\n\r\nPull request containing the fix can be found at:\r\nhttps://github.com/electron/electron/pull/9734\r\n\r\nIMPORTANT:\r\ncurrently used version of breakpad src (33a4375) does not contain necessary fixes. therefore for pull request to work breakpad src must be synchronized with master (https://chromium.googlesource.com/breakpad/breakpad/+/7ec3caf6c7cdff0a99cd34249acfdc61f76f2d86)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9734", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9734/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9734/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9734/events", "html_url": "https://github.com/electron/electron/pull/9734", "id": 235170649, "number": 9734, "title": "- add support for full dump via cmd line.", "user": { "login": "igorshevach", "id": 10923933, "avatar_url": "https://avatars2.githubusercontent.com/u/10923933?v=3", "gravatar_id": "", "url": "https://api.github.com/users/igorshevach", "html_url": "https://github.com/igorshevach", "followers_url": "https://api.github.com/users/igorshevach/followers", "following_url": "https://api.github.com/users/igorshevach/following{/other_user}", "gists_url": "https://api.github.com/users/igorshevach/gists{/gist_id}", "starred_url": "https://api.github.com/users/igorshevach/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/igorshevach/subscriptions", "organizations_url": "https://api.github.com/users/igorshevach/orgs", "repos_url": "https://api.github.com/users/igorshevach/repos", "events_url": "https://api.github.com/users/igorshevach/events{/privacy}", "received_events_url": "https://api.github.com/users/igorshevach/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-12T09:20:09Z", "updated_at": "2017-06-26T07:49:39Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9734", "html_url": "https://github.com/electron/electron/pull/9734", "diff_url": "https://github.com/electron/electron/pull/9734.diff", "patch_url": "https://github.com/electron/electron/pull/9734.patch" }, "body": "usage:\r\nenable full dump creation:\r\n-full-memory-crash-report=1\r\nforce disable full dump creation:\r\n-full-memory-crash-report=0.\r\n\r\nIMPORTANT:\r\nvendor/breakpad should be updated to latest master version since commit 33a4375 does not contain required code fixes." }, { "url": "https://api.github.com/repos/electron/electron/issues/9733", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9733/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9733/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9733/events", "html_url": "https://github.com/electron/electron/pull/9733", "id": 235165070, "number": 9733, "title": "Use Buffer.from instead of deprecated new Buffer", "user": { "login": "qazbnm456", "id": 6451933, "avatar_url": "https://avatars1.githubusercontent.com/u/6451933?v=3", "gravatar_id": "", "url": "https://api.github.com/users/qazbnm456", "html_url": "https://github.com/qazbnm456", "followers_url": "https://api.github.com/users/qazbnm456/followers", "following_url": "https://api.github.com/users/qazbnm456/following{/other_user}", "gists_url": "https://api.github.com/users/qazbnm456/gists{/gist_id}", "starred_url": "https://api.github.com/users/qazbnm456/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/qazbnm456/subscriptions", "organizations_url": "https://api.github.com/users/qazbnm456/orgs", "repos_url": "https://api.github.com/users/qazbnm456/repos", "events_url": "https://api.github.com/users/qazbnm456/events{/privacy}", "received_events_url": "https://api.github.com/users/qazbnm456/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": { "login": "jkleinsc", "id": 609052, "avatar_url": "https://avatars3.githubusercontent.com/u/609052?v=3", "gravatar_id": "", "url": "https://api.github.com/users/jkleinsc", "html_url": "https://github.com/jkleinsc", "followers_url": "https://api.github.com/users/jkleinsc/followers", "following_url": "https://api.github.com/users/jkleinsc/following{/other_user}", "gists_url": "https://api.github.com/users/jkleinsc/gists{/gist_id}", "starred_url": "https://api.github.com/users/jkleinsc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jkleinsc/subscriptions", "organizations_url": "https://api.github.com/users/jkleinsc/orgs", "repos_url": "https://api.github.com/users/jkleinsc/repos", "events_url": "https://api.github.com/users/jkleinsc/events{/privacy}", "received_events_url": "https://api.github.com/users/jkleinsc/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "jkleinsc", "id": 609052, "avatar_url": "https://avatars3.githubusercontent.com/u/609052?v=3", "gravatar_id": "", "url": "https://api.github.com/users/jkleinsc", "html_url": "https://github.com/jkleinsc", "followers_url": "https://api.github.com/users/jkleinsc/followers", "following_url": "https://api.github.com/users/jkleinsc/following{/other_user}", "gists_url": "https://api.github.com/users/jkleinsc/gists{/gist_id}", "starred_url": "https://api.github.com/users/jkleinsc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jkleinsc/subscriptions", "organizations_url": "https://api.github.com/users/jkleinsc/orgs", "repos_url": "https://api.github.com/users/jkleinsc/repos", "events_url": "https://api.github.com/users/jkleinsc/events{/privacy}", "received_events_url": "https://api.github.com/users/jkleinsc/received_events", "type": "User", "site_admin": true }, { "login": "vanessayuenn", "id": 6842965, "avatar_url": "https://avatars0.githubusercontent.com/u/6842965?v=3", "gravatar_id": "", "url": "https://api.github.com/users/vanessayuenn", "html_url": "https://github.com/vanessayuenn", "followers_url": "https://api.github.com/users/vanessayuenn/followers", "following_url": "https://api.github.com/users/vanessayuenn/following{/other_user}", "gists_url": "https://api.github.com/users/vanessayuenn/gists{/gist_id}", "starred_url": "https://api.github.com/users/vanessayuenn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vanessayuenn/subscriptions", "organizations_url": "https://api.github.com/users/vanessayuenn/orgs", "repos_url": "https://api.github.com/users/vanessayuenn/repos", "events_url": "https://api.github.com/users/vanessayuenn/events{/privacy}", "received_events_url": "https://api.github.com/users/vanessayuenn/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 2, "created_at": "2017-06-12T08:58:07Z", "updated_at": "2017-06-14T01:16:34Z", "closed_at": "2017-06-13T18:44:35Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9733", "html_url": "https://github.com/electron/electron/pull/9733", "diff_url": "https://github.com/electron/electron/pull/9733.diff", "patch_url": "https://github.com/electron/electron/pull/9733.patch" }, "body": "Use Buffer.from instead of deprecated new Buffer." }, { "url": "https://api.github.com/repos/electron/electron/issues/9732", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9732/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9732/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9732/events", "html_url": "https://github.com/electron/electron/issues/9732", "id": 235164516, "number": 9732, "title": "Unable to perform independent OpenGL rendering", "user": { "login": "alexlitty", "id": 4219222, "avatar_url": "https://avatars1.githubusercontent.com/u/4219222?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alexlitty", "html_url": "https://github.com/alexlitty", "followers_url": "https://api.github.com/users/alexlitty/followers", "following_url": "https://api.github.com/users/alexlitty/following{/other_user}", "gists_url": "https://api.github.com/users/alexlitty/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexlitty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexlitty/subscriptions", "organizations_url": "https://api.github.com/users/alexlitty/orgs", "repos_url": "https://api.github.com/users/alexlitty/repos", "events_url": "https://api.github.com/users/alexlitty/events{/privacy}", "received_events_url": "https://api.github.com/users/alexlitty/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-12T08:55:56Z", "updated_at": "2017-06-13T05:14:28Z", "closed_at": null, "body": "I've developed an OpenGL-based C++ animation engine. I'm wrapping it into a Node.js module using [SWIG](https://github.com/swig/swig) and would like to hook it into an Electron app.\r\n\r\nThe engine has a very encompassing test suite -- Between that and the simplest node scripts, I can see all basic functionality working as expected outside an Electron app. The test suite and scripts also work when running Electron as Node via `ELECTRON_RUN_AS_NODE`.\r\n\r\nMysteriously, I can't perform any rendering _inside_ an Electron app in neither the browser nor render process.\r\n\r\nMore accurately, any calls to `glGenX` return 0. Querying `glGetString(GL_VERSION)` returns null, afterward `glGetError` reports no error. I've made a [StackOverflow question](https://stackoverflow.com/questions/44512019/mysteriously-invalid-opengl-context-in-electron) that describes how I check context creation; I don't think I'm missing anything, but contexts still appear to be dysfunctional.\r\n\r\nIs this perhaps known behavior? Is there a caveat I'm missing?\r\n\r\n- I'm running Debian Stretch and Electron 1.5.1, unable to upgrade to a newer version without module version mismatches.\r\n- In case Chromium is interfering with my OpenGL contexts somehow, I've tried disabling hardware acceleration, ensuring it is disabled before the app is ready. I've also tried passing `--disable-gpu`.\r\n- All OpenGL actions are 100% definitely occurring in the same thread.\r\n- Architecture of electron and the module are both `x64`." }, { "url": "https://api.github.com/repos/electron/electron/issues/9731", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9731/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9731/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9731/events", "html_url": "https://github.com/electron/electron/issues/9731", "id": 235162152, "number": 9731, "title": "\"moved\" triggering every time when screen resolution was changed", "user": { "login": "igogo5yo", "id": 3601883, "avatar_url": "https://avatars2.githubusercontent.com/u/3601883?v=3", "gravatar_id": "", "url": "https://api.github.com/users/igogo5yo", "html_url": "https://github.com/igogo5yo", "followers_url": "https://api.github.com/users/igogo5yo/followers", "following_url": "https://api.github.com/users/igogo5yo/following{/other_user}", "gists_url": "https://api.github.com/users/igogo5yo/gists{/gist_id}", "starred_url": "https://api.github.com/users/igogo5yo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/igogo5yo/subscriptions", "organizations_url": "https://api.github.com/users/igogo5yo/orgs", "repos_url": "https://api.github.com/users/igogo5yo/repos", "events_url": "https://api.github.com/users/igogo5yo/events{/privacy}", "received_events_url": "https://api.github.com/users/igogo5yo/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-12T08:46:25Z", "updated_at": "2017-06-12T15:02:13Z", "closed_at": null, "body": "* Electron version: 1.6.2, 1.6.10\r\n* Operating system: macOS 10.12.5\r\n\r\n### Expected behavior\r\n\r\nWhen resolution was changed 'display-metrics-changed' event should be triggered first.\r\n\r\n Actual behavior\r\n\r\nWhen resolution was changed 'moved' event was triggered first.\r\n\r\n### How to reproduce\r\n\r\nRun electron app and then change screen resolution.\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9730", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9730/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9730/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9730/events", "html_url": "https://github.com/electron/electron/pull/9730", "id": 235140152, "number": 9730, "title": "Chromium 59", "user": { "login": "dezmathio", "id": 515228, "avatar_url": "https://avatars0.githubusercontent.com/u/515228?v=3", "gravatar_id": "", "url": "https://api.github.com/users/dezmathio", "html_url": "https://github.com/dezmathio", "followers_url": "https://api.github.com/users/dezmathio/followers", "following_url": "https://api.github.com/users/dezmathio/following{/other_user}", "gists_url": "https://api.github.com/users/dezmathio/gists{/gist_id}", "starred_url": "https://api.github.com/users/dezmathio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dezmathio/subscriptions", "organizations_url": "https://api.github.com/users/dezmathio/orgs", "repos_url": "https://api.github.com/users/dezmathio/repos", "events_url": "https://api.github.com/users/dezmathio/events{/privacy}", "received_events_url": "https://api.github.com/users/dezmathio/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-12T06:58:00Z", "updated_at": "2017-06-12T14:36:41Z", "closed_at": "2017-06-12T14:36:41Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9730", "html_url": "https://github.com/electron/electron/pull/9730", "diff_url": "https://github.com/electron/electron/pull/9730.diff", "patch_url": "https://github.com/electron/electron/pull/9730.patch" }, "body": "`Update CLANG_VERSION to match version Chrome is using in update.py`\r\n\r\nwas following https://electron.atom.io/docs/development/upgrading-chrome/ a bit loosely;\r\n\r\nI followed this locally: https://github.com/electron/electron/blob/master/docs/development/build-instructions-osx.md\r\nran bootstrap.py, then build.py, then test.py scripts -- Wasn't 100% sure if I missed anything, the instructions in the upgrade guide didn't have instructions as detailed as the ones for building electron itself. Let me know if you want me to take this PR down. Cheers." }, { "url": "https://api.github.com/repos/electron/electron/issues/9729", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9729/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9729/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9729/events", "html_url": "https://github.com/electron/electron/issues/9729", "id": 235119307, "number": 9729, "title": "Windows 7: Window restores improperly after snap and minimize", "user": { "login": "bpasero", "id": 900690, "avatar_url": "https://avatars0.githubusercontent.com/u/900690?v=3", "gravatar_id": "", "url": "https://api.github.com/users/bpasero", "html_url": "https://github.com/bpasero", "followers_url": "https://api.github.com/users/bpasero/followers", "following_url": "https://api.github.com/users/bpasero/following{/other_user}", "gists_url": "https://api.github.com/users/bpasero/gists{/gist_id}", "starred_url": "https://api.github.com/users/bpasero/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bpasero/subscriptions", "organizations_url": "https://api.github.com/users/bpasero/orgs", "repos_url": "https://api.github.com/users/bpasero/repos", "events_url": "https://api.github.com/users/bpasero/events{/privacy}", "received_events_url": "https://api.github.com/users/bpasero/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-12T03:51:18Z", "updated_at": "2017-06-12T03:51:18Z", "closed_at": null, "body": "* Electron version: 1.7.2\r\n* Operating system: Windows 7\r\n\r\n### Expected behavior\r\n\r\nA windows restores to its previous bounds and location after restoring from being minimized.\r\n\r\n### Actual behavior\r\n\r\nThe window restores in the center with some kind of default bounds.\r\n\r\n### How to reproduce\r\n\r\n* run simple Electron out of the box\r\n* maximize the window\r\n* press Windows-ArrowRight to snap the window to the right\r\n* minimize the window\r\n* restore the window\r\n\r\n=> bounds are not the same as before\r\n\r\nThis seems to work fine on Windows 10\r\n\r\n![panel-red](https://user-images.githubusercontent.com/900690/27018769-25ad4fa4-4f33-11e7-8815-8fff23bbe80e.gif)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9728", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9728/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9728/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9728/events", "html_url": "https://github.com/electron/electron/issues/9728", "id": 235093979, "number": 9728, "title": "Add the ability to completely hide the menu bar.", "user": { "login": "giuscri", "id": 4048120, "avatar_url": "https://avatars0.githubusercontent.com/u/4048120?v=3", "gravatar_id": "", "url": "https://api.github.com/users/giuscri", "html_url": "https://github.com/giuscri", "followers_url": "https://api.github.com/users/giuscri/followers", "following_url": "https://api.github.com/users/giuscri/following{/other_user}", "gists_url": "https://api.github.com/users/giuscri/gists{/gist_id}", "starred_url": "https://api.github.com/users/giuscri/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/giuscri/subscriptions", "organizations_url": "https://api.github.com/users/giuscri/orgs", "repos_url": "https://api.github.com/users/giuscri/repos", "events_url": "https://api.github.com/users/giuscri/events{/privacy}", "received_events_url": "https://api.github.com/users/giuscri/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-11T21:43:31Z", "updated_at": "2017-06-11T21:46:20Z", "closed_at": null, "body": "\r\n\r\n* Electron version: N/A\r\n* Operating system: N/A\r\n\r\n### Expected behavior\r\n\r\nIf properly instructed, pressing Alt should *not* show the menu bar.\r\n\r\n### Actual behavior\r\nIt seems like there's no way to disable the listener showing the menu bar.\r\n\r\n### How to reproduce\r\nN/A\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9727", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9727/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9727/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9727/events", "html_url": "https://github.com/electron/electron/issues/9727", "id": 235070122, "number": 9727, "title": "Cannot open mainWindow on Ubuntu 16.04", "user": { "login": "royzuo", "id": 685242, "avatar_url": "https://avatars0.githubusercontent.com/u/685242?v=3", "gravatar_id": "", "url": "https://api.github.com/users/royzuo", "html_url": "https://github.com/royzuo", "followers_url": "https://api.github.com/users/royzuo/followers", "following_url": "https://api.github.com/users/royzuo/following{/other_user}", "gists_url": "https://api.github.com/users/royzuo/gists{/gist_id}", "starred_url": "https://api.github.com/users/royzuo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/royzuo/subscriptions", "organizations_url": "https://api.github.com/users/royzuo/orgs", "repos_url": "https://api.github.com/users/royzuo/repos", "events_url": "https://api.github.com/users/royzuo/events{/privacy}", "received_events_url": "https://api.github.com/users/royzuo/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-11T14:45:47Z", "updated_at": "2017-06-11T14:45:47Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: ubuntu 16.04\r\n\r\n### Expected behavior\r\n\r\n\r\nRun hello world app, which is introduced in quick start (https://electron.atom.io/docs/tutorial/quick-start/). \r\n\r\n### Actual behavior\r\n\r\n\r\n\r\nThe mainWindow cannot open.\r\n\r\n### How to reproduce\r\n\r\nUse \"ELECTRON_ENABLE_LOGGING=true electron . \"\r\nThere are some messages:\r\n\r\n[15326:0611/223758.110740:VERBOSE1:CONSOLE(8299)] \"Main._createAppUI: 383.333ms\", source: chrome-devtools://devtools/bundled/inspector.js (8299)\r\n[15326:0611/223758.508825:VERBOSE1:CONSOLE(8304)] \"Main._showAppUI: 387.985ms\", source: chrome-devtools://devtools/bundled/inspector.js (8304)\r\n[15326:0611/223800.492846:VERBOSE1:CONSOLE(8305)] \"Main._initializeTarget: 570.689ms\", source: chrome-devtools://devtools/bundled/inspector.js (8305)\r\n\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9726", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9726/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9726/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9726/events", "html_url": "https://github.com/electron/electron/issues/9726", "id": 235058105, "number": 9726, "title": "Tray's context menu is cut when changing resolution ", "user": { "login": "shaniAlgazi", "id": 25342044, "avatar_url": "https://avatars2.githubusercontent.com/u/25342044?v=3", "gravatar_id": "", "url": "https://api.github.com/users/shaniAlgazi", "html_url": "https://github.com/shaniAlgazi", "followers_url": "https://api.github.com/users/shaniAlgazi/followers", "following_url": "https://api.github.com/users/shaniAlgazi/following{/other_user}", "gists_url": "https://api.github.com/users/shaniAlgazi/gists{/gist_id}", "starred_url": "https://api.github.com/users/shaniAlgazi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shaniAlgazi/subscriptions", "organizations_url": "https://api.github.com/users/shaniAlgazi/orgs", "repos_url": "https://api.github.com/users/shaniAlgazi/repos", "events_url": "https://api.github.com/users/shaniAlgazi/events{/privacy}", "received_events_url": "https://api.github.com/users/shaniAlgazi/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-11T10:56:20Z", "updated_at": "2017-06-11T10:56:20Z", "closed_at": null, "body": "* Electron version: 1.4.13\r\n* Operating system: Windows 10\r\n\r\nHey guys, \r\n\r\nI'm trying to add a context menu to my tray app: \r\n\r\n this._tray.setContextMenu(this._contextMenu);\r\n\r\nIt's working just fine until i'm pulling my laptop out of the docking station (that has 2 screens) and open it - this causes a change in the resolution and when then trying to click again on the tray from my laptop it looks like this : \r\n\r\n![image](https://user-images.githubusercontent.com/25342044/27010427-c1e3cbe6-4eac-11e7-9aea-b89d7930733f.png)\r\n\r\nI also tried : \r\ntray.popUpContextMenu\r\nwith the position of the current screen, but getDisplayMatching() and getPrimaryDisplay() keeps giving me the position of the docking screens. " }, { "url": "https://api.github.com/repos/electron/electron/issues/9725", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9725/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9725/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9725/events", "html_url": "https://github.com/electron/electron/pull/9725", "id": 235052413, "number": 9725, "title": "Add \"New Tab\" button for Native macOS Tabs", "user": { "login": "danielma", "id": 993340, "avatar_url": "https://avatars1.githubusercontent.com/u/993340?v=3", "gravatar_id": "", "url": "https://api.github.com/users/danielma", "html_url": "https://github.com/danielma", "followers_url": "https://api.github.com/users/danielma/followers", "following_url": "https://api.github.com/users/danielma/following{/other_user}", "gists_url": "https://api.github.com/users/danielma/gists{/gist_id}", "starred_url": "https://api.github.com/users/danielma/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/danielma/subscriptions", "organizations_url": "https://api.github.com/users/danielma/orgs", "repos_url": "https://api.github.com/users/danielma/repos", "events_url": "https://api.github.com/users/danielma/events{/privacy}", "received_events_url": "https://api.github.com/users/danielma/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-11T08:50:37Z", "updated_at": "2017-06-26T17:36:18Z", "closed_at": "2017-06-26T06:07:10Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9725", "html_url": "https://github.com/electron/electron/pull/9725", "diff_url": "https://github.com/electron/electron/pull/9725.diff", "patch_url": "https://github.com/electron/electron/pull/9725.patch" }, "body": "Adds responders for `newWindowForTab` to `AtomApplicationDelegate` and\r\n`NativeWindowMac`, so that `BrowserWindow`s with a `tabbingIdentifier`\r\nwill get the new tab button, and both `app` and `window` will emit a\r\n`new-tab-for-window` event.\r\n\r\nThis builds on the work done in https://github.com/electron/electron/pull/9052\r\n\r\nTesting app: https://github.com/danielma/electron-quick-start/tree/native-new-tab-button\r\nVideo: https://cl.ly/1W1i2K0c0509\r\n\r\n\"screen\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9724", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9724/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9724/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9724/events", "html_url": "https://github.com/electron/electron/pull/9724", "id": 235022141, "number": 9724, "title": "Bump standard-markdown", "user": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-10T19:25:29Z", "updated_at": "2017-06-15T00:26:57Z", "closed_at": "2017-06-15T00:26:54Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9724", "html_url": "https://github.com/electron/electron/pull/9724", "diff_url": "https://github.com/electron/electron/pull/9724.diff", "patch_url": "https://github.com/electron/electron/pull/9724.patch" }, "body": "This updates `standard-markdown` to a new version that lints with `standard` v10 and fixes some issues that were detected by the update.\r\n\r\n> 'new Buffer()' was deprecated since v6. Use 'Buffer.alloc()' or 'Buffer.from()' (use 'https://www.npmjs.com/package/safe-buffer' for '<4.5.0') instead.\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9723", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9723/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9723/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9723/events", "html_url": "https://github.com/electron/electron/issues/9723", "id": 234996873, "number": 9723, "title": "ReferenceError on accessing local variable within executeJavaScript", "user": { "login": "yrahul3910", "id": 8930954, "avatar_url": "https://avatars2.githubusercontent.com/u/8930954?v=3", "gravatar_id": "", "url": "https://api.github.com/users/yrahul3910", "html_url": "https://github.com/yrahul3910", "followers_url": "https://api.github.com/users/yrahul3910/followers", "following_url": "https://api.github.com/users/yrahul3910/following{/other_user}", "gists_url": "https://api.github.com/users/yrahul3910/gists{/gist_id}", "starred_url": "https://api.github.com/users/yrahul3910/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yrahul3910/subscriptions", "organizations_url": "https://api.github.com/users/yrahul3910/orgs", "repos_url": "https://api.github.com/users/yrahul3910/repos", "events_url": "https://api.github.com/users/yrahul3910/events{/privacy}", "received_events_url": "https://api.github.com/users/yrahul3910/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-10T11:24:47Z", "updated_at": "2017-06-10T11:59:37Z", "closed_at": "2017-06-10T11:59:37Z", "body": "I'm trying to access a variable from a function that's called in `webContents.executeJavaScript`, but I get a `ReferenceError` on trying. I use jQuery for event handling. Here's some sample code to replicate the issue.\r\n```\r\nlet var;\r\n\r\nconst menuClick = () => {\r\n var = 5;\r\n let html = \"

Some test paragraph

\";\r\n win.webContents.executeJavaScript(`\r\n $(\"#list\").append(\"${html}\");\r\n $('div').click(${onDivClicked});\r\n `);\r\n}\r\n\r\nconst onDivClicked = (e) => {\r\n console.log(var);\r\n}\r\n```\r\nI expect it to show 5, but it gives me a `ReferenceError` instead. Any ideas on how to fix this?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9722", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9722/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9722/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9722/events", "html_url": "https://github.com/electron/electron/issues/9722", "id": 234985839, "number": 9722, "title": "Browser Tabs for ", "user": { "login": "Valder-Dev", "id": 28824836, "avatar_url": "https://avatars0.githubusercontent.com/u/28824836?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Valder-Dev", "html_url": "https://github.com/Valder-Dev", "followers_url": "https://api.github.com/users/Valder-Dev/followers", "following_url": "https://api.github.com/users/Valder-Dev/following{/other_user}", "gists_url": "https://api.github.com/users/Valder-Dev/gists{/gist_id}", "starred_url": "https://api.github.com/users/Valder-Dev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Valder-Dev/subscriptions", "organizations_url": "https://api.github.com/users/Valder-Dev/orgs", "repos_url": "https://api.github.com/users/Valder-Dev/repos", "events_url": "https://api.github.com/users/Valder-Dev/events{/privacy}", "received_events_url": "https://api.github.com/users/Valder-Dev/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-10T07:08:24Z", "updated_at": "2017-06-11T07:38:37Z", "closed_at": "2017-06-10T07:15:23Z", "body": "- **Electron version:** 1.4.13.\r\n- **Operating System:** Windows 7.\r\n\r\n### Question:\r\nHow create Browser Tabs as in the Google Hrome or Firefox?\r\n\r\n**PS:** Thanks for a help.\r\n\r\n![image](https://user-images.githubusercontent.com/28824836/27000892-911c60ea-4e07-11e7-839f-45156a3bba5a.png)\r\n![image](https://user-images.githubusercontent.com/28824836/27000897-b01956b0-4e07-11e7-9cf3-17abd0620714.png)\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9721", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9721/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9721/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9721/events", "html_url": "https://github.com/electron/electron/pull/9721", "id": 234942021, "number": 9721, "title": "Update rectangle.md (issue #9552)", "user": { "login": "brianfajardo", "id": 25241230, "avatar_url": "https://avatars2.githubusercontent.com/u/25241230?v=3", "gravatar_id": "", "url": "https://api.github.com/users/brianfajardo", "html_url": "https://github.com/brianfajardo", "followers_url": "https://api.github.com/users/brianfajardo/followers", "following_url": "https://api.github.com/users/brianfajardo/following{/other_user}", "gists_url": "https://api.github.com/users/brianfajardo/gists{/gist_id}", "starred_url": "https://api.github.com/users/brianfajardo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/brianfajardo/subscriptions", "organizations_url": "https://api.github.com/users/brianfajardo/orgs", "repos_url": "https://api.github.com/users/brianfajardo/repos", "events_url": "https://api.github.com/users/brianfajardo/events{/privacy}", "received_events_url": "https://api.github.com/users/brianfajardo/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-09T21:22:35Z", "updated_at": "2017-06-13T18:53:49Z", "closed_at": "2017-06-13T18:53:49Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9721", "html_url": "https://github.com/electron/electron/pull/9721", "diff_url": "https://github.com/electron/electron/pull/9721.diff", "patch_url": "https://github.com/electron/electron/pull/9721.patch" }, "body": "`typeError` is shown when floating point values are passed to the rectangle object. \r\n\r\nFor example, `BrowserWindow.setBounds(5, 10, 15.5, 20.5)` results in `typeError`\r\n\r\nAdded a small note in rectangle.md to add clarity." }, { "url": "https://api.github.com/repos/electron/electron/issues/9720", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9720/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9720/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9720/events", "html_url": "https://github.com/electron/electron/issues/9720", "id": 234862855, "number": 9720, "title": "Layout changes all happen at once after hiding/showing a BrowserWindow", "user": { "login": "romaincointepas", "id": 797899, "avatar_url": "https://avatars1.githubusercontent.com/u/797899?v=3", "gravatar_id": "", "url": "https://api.github.com/users/romaincointepas", "html_url": "https://github.com/romaincointepas", "followers_url": "https://api.github.com/users/romaincointepas/followers", "following_url": "https://api.github.com/users/romaincointepas/following{/other_user}", "gists_url": "https://api.github.com/users/romaincointepas/gists{/gist_id}", "starred_url": "https://api.github.com/users/romaincointepas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/romaincointepas/subscriptions", "organizations_url": "https://api.github.com/users/romaincointepas/orgs", "repos_url": "https://api.github.com/users/romaincointepas/repos", "events_url": "https://api.github.com/users/romaincointepas/events{/privacy}", "received_events_url": "https://api.github.com/users/romaincointepas/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-09T15:30:22Z", "updated_at": "2017-06-09T18:40:30Z", "closed_at": null, "body": "* Electron version: 1.6.x, 1.7.x\r\n* Operating system: macOS 10.12.5, Windows 10\r\n\r\n### Expected behavior\r\n\r\nA way to update the layout of a hidden window (that has been shown in the past, then was hidden) while it is hidden.\r\n\r\n### Actual behavior\r\n\r\nAll layout changes applied while the window was hidden are all applied at once when showing the window again (and it's visible).\r\n\r\nSetting `backgroundThrottling: false` as `webPreferences` for that window doesn't solve the problem.\r\n\r\n### How to reproduce\r\n\r\n1. Show a BrowserWindow with the current time in seconds that updates itself every 1 second.\r\n2. Hide the window for a few seconds.\r\n3. Show the window again, the time that was shown when the window was hidden will still be visible for a few milliseconds, then will be replaced by the \"current\" one. Same thing applies to any HTML/CSS changes (from element width/height, to background color, etc.)." }, { "url": "https://api.github.com/repos/electron/electron/issues/9719", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9719/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9719/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9719/events", "html_url": "https://github.com/electron/electron/issues/9719", "id": 234861288, "number": 9719, "title": "Short blocking operations in main process freeze CSS animations in all renderer processes", "user": { "login": "romaincointepas", "id": 797899, "avatar_url": "https://avatars1.githubusercontent.com/u/797899?v=3", "gravatar_id": "", "url": "https://api.github.com/users/romaincointepas", "html_url": "https://github.com/romaincointepas", "followers_url": "https://api.github.com/users/romaincointepas/followers", "following_url": "https://api.github.com/users/romaincointepas/following{/other_user}", "gists_url": "https://api.github.com/users/romaincointepas/gists{/gist_id}", "starred_url": "https://api.github.com/users/romaincointepas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/romaincointepas/subscriptions", "organizations_url": "https://api.github.com/users/romaincointepas/orgs", "repos_url": "https://api.github.com/users/romaincointepas/repos", "events_url": "https://api.github.com/users/romaincointepas/events{/privacy}", "received_events_url": "https://api.github.com/users/romaincointepas/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-09T15:25:15Z", "updated_at": "2017-06-09T17:11:34Z", "closed_at": null, "body": "* Electron version: 1.6.x, 1.7.x\r\n* Operating system: macOS 10.12.5, Windows 10\r\n\r\n### Expected behavior\r\n\r\nDoing blocking (10ms or higher) node operations in main process or in renderer process shouldn't freeze CSS animations in an entirely different BrowserWindow/renderer processes (that only contains HTML/CSS, no JS/node, but has `noteIntegration: true`).\r\n\r\n### Actual behavior\r\n\r\nLong *blocking* node operations (from 10ms to higher) in the main process or in a renderer process will freeze CSS animations in ALL renderer processes.\r\n\r\n### How to reproduce\r\n\r\n1. Create one BrowserWindow with `nodeIntegration: true`, and rotate a green square div using CSS animation.\r\n2. In main process or a different BrowserWindow, do anything that is blocking.\r\n3. Even if nothing is happening in the BrowserWindow with the animation (pure html/css, no JS), the square rotating animation will be jerky when the blocking operation is happening in the main process or other renderer.\r\n\r\nThis is pretty annoying because even extremely small blocking operations will still make a fluid animation (like a infinite rotating loader) jerky.\r\n\r\nAlso, doing the same operation in another BrowserWindow will have the same effect (I'm assuming all node operations, in main or renderer process, are all in the same node thread?)." }, { "url": "https://api.github.com/repos/electron/electron/issues/9718", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9718/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9718/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9718/events", "html_url": "https://github.com/electron/electron/issues/9718", "id": 234836347, "number": 9718, "title": "how to pass param by shell.openItem ", "user": { "login": "crylg", "id": 4261373, "avatar_url": "https://avatars2.githubusercontent.com/u/4261373?v=3", "gravatar_id": "", "url": "https://api.github.com/users/crylg", "html_url": "https://github.com/crylg", "followers_url": "https://api.github.com/users/crylg/followers", "following_url": "https://api.github.com/users/crylg/following{/other_user}", "gists_url": "https://api.github.com/users/crylg/gists{/gist_id}", "starred_url": "https://api.github.com/users/crylg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/crylg/subscriptions", "organizations_url": "https://api.github.com/users/crylg/orgs", "repos_url": "https://api.github.com/users/crylg/repos", "events_url": "https://api.github.com/users/crylg/events{/privacy}", "received_events_url": "https://api.github.com/users/crylg/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-09T14:02:14Z", "updated_at": "2017-06-09T14:05:10Z", "closed_at": "2017-06-09T14:05:10Z", "body": "Invalid:\r\nshell.openItem(\"d:\\abc.exe arg1 arg2 arg3\")\r\ncallback echo \"false\"" }, { "url": "https://api.github.com/repos/electron/electron/issues/9717", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9717/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9717/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9717/events", "html_url": "https://github.com/electron/electron/issues/9717", "id": 234830297, "number": 9717, "title": "document.visibilityState is hidden in s when BrowserWindow shown on ready-to-show", "user": { "login": "javan", "id": 5355, "avatar_url": "https://avatars0.githubusercontent.com/u/5355?v=3", "gravatar_id": "", "url": "https://api.github.com/users/javan", "html_url": "https://github.com/javan", "followers_url": "https://api.github.com/users/javan/followers", "following_url": "https://api.github.com/users/javan/following{/other_user}", "gists_url": "https://api.github.com/users/javan/gists{/gist_id}", "starred_url": "https://api.github.com/users/javan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/javan/subscriptions", "organizations_url": "https://api.github.com/users/javan/orgs", "repos_url": "https://api.github.com/users/javan/repos", "events_url": "https://api.github.com/users/javan/events{/privacy}", "received_events_url": "https://api.github.com/users/javan/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 144086588, "url": "https://api.github.com/repos/electron/electron/labels/component/webview", "name": "component/webview", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false }, { "id": 538879644, "url": "https://api.github.com/repos/electron/electron/labels/fixme/regression", "name": "fixme/regression", "color": "fc2929", "default": false } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-09T13:40:36Z", "updated_at": "2017-06-15T12:42:33Z", "closed_at": "2017-06-14T22:22:56Z", "body": "* Electron version: 1.7.3\r\n* Operating system: macOS 10.12.5\r\n\r\nWhen a `BrowserWindow` is created with `{show: false}` and then `show`n on `ready-to-show`, its ``s will (incorrectly?) have a `document.visibilityState` of `hidden`. Prior to https://github.com/electron/electron/pull/9178 (cc: @poiru), it would be `visible`. \r\n\r\nHere's a little example app: https://gist.github.com/javan/f1f5257044bfdf6f3dae47ccc2f57be4\r\n\r\n![screen shot 2017-06-09 at 9 36 25 am](https://user-images.githubusercontent.com/5355/26977748-fa554d5e-4cf6-11e7-89d4-633969f5ac12.png)\r\n\r\nShowing the window on `dom-ready` works and the `visibilityState` is `visible`.\r\n```js\r\nmainWindow.webContents.on('dom-ready', function() {\r\n mainWindow.show()\r\n})\r\n```" }, { "url": "https://api.github.com/repos/electron/electron/issues/9716", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9716/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9716/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9716/events", "html_url": "https://github.com/electron/electron/pull/9716", "id": 234827687, "number": 9716, "title": "Add tray icon workaround for newer Ubuntu releases (fixes #9046)", "user": { "login": "dakira", "id": 576555, "avatar_url": "https://avatars2.githubusercontent.com/u/576555?v=3", "gravatar_id": "", "url": "https://api.github.com/users/dakira", "html_url": "https://github.com/dakira", "followers_url": "https://api.github.com/users/dakira/followers", "following_url": "https://api.github.com/users/dakira/following{/other_user}", "gists_url": "https://api.github.com/users/dakira/gists{/gist_id}", "starred_url": "https://api.github.com/users/dakira/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dakira/subscriptions", "organizations_url": "https://api.github.com/users/dakira/orgs", "repos_url": "https://api.github.com/users/dakira/repos", "events_url": "https://api.github.com/users/dakira/events{/privacy}", "received_events_url": "https://api.github.com/users/dakira/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": { "login": "vanessayuenn", "id": 6842965, "avatar_url": "https://avatars0.githubusercontent.com/u/6842965?v=3", "gravatar_id": "", "url": "https://api.github.com/users/vanessayuenn", "html_url": "https://github.com/vanessayuenn", "followers_url": "https://api.github.com/users/vanessayuenn/followers", "following_url": "https://api.github.com/users/vanessayuenn/following{/other_user}", "gists_url": "https://api.github.com/users/vanessayuenn/gists{/gist_id}", "starred_url": "https://api.github.com/users/vanessayuenn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vanessayuenn/subscriptions", "organizations_url": "https://api.github.com/users/vanessayuenn/orgs", "repos_url": "https://api.github.com/users/vanessayuenn/repos", "events_url": "https://api.github.com/users/vanessayuenn/events{/privacy}", "received_events_url": "https://api.github.com/users/vanessayuenn/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "vanessayuenn", "id": 6842965, "avatar_url": "https://avatars0.githubusercontent.com/u/6842965?v=3", "gravatar_id": "", "url": "https://api.github.com/users/vanessayuenn", "html_url": "https://github.com/vanessayuenn", "followers_url": "https://api.github.com/users/vanessayuenn/followers", "following_url": "https://api.github.com/users/vanessayuenn/following{/other_user}", "gists_url": "https://api.github.com/users/vanessayuenn/gists{/gist_id}", "starred_url": "https://api.github.com/users/vanessayuenn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vanessayuenn/subscriptions", "organizations_url": "https://api.github.com/users/vanessayuenn/orgs", "repos_url": "https://api.github.com/users/vanessayuenn/repos", "events_url": "https://api.github.com/users/vanessayuenn/events{/privacy}", "received_events_url": "https://api.github.com/users/vanessayuenn/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 1, "created_at": "2017-06-09T13:31:41Z", "updated_at": "2017-06-09T22:02:18Z", "closed_at": "2017-06-09T22:01:32Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9716", "html_url": "https://github.com/electron/electron/pull/9716", "diff_url": "https://github.com/electron/electron/pull/9716.diff", "patch_url": "https://github.com/electron/electron/pull/9716.patch" }, "body": "Starting with 17.04, Ubuntu sets XDG_CURRENT_DESKTOP to `Unity:Unity7` which prevents tray icons from being displayed. There already is a workaround for a similiar situation (for ElementaryOS).\r\n\r\nI tested [this fix](https://github.com/electron/electron/issues/9046#issuecomment-296169661) by @MarshallOfSound in Ubuntu 17.04, and regression-tested it on older releases. Everythings works as expected.\r\n\r\nFixes #9046 " }, { "url": "https://api.github.com/repos/electron/electron/issues/9715", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9715/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9715/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9715/events", "html_url": "https://github.com/electron/electron/issues/9715", "id": 234787295, "number": 9715, "title": "Error on starting electron application", "user": { "login": "talhaanees", "id": 14168151, "avatar_url": "https://avatars0.githubusercontent.com/u/14168151?v=3", "gravatar_id": "", "url": "https://api.github.com/users/talhaanees", "html_url": "https://github.com/talhaanees", "followers_url": "https://api.github.com/users/talhaanees/followers", "following_url": "https://api.github.com/users/talhaanees/following{/other_user}", "gists_url": "https://api.github.com/users/talhaanees/gists{/gist_id}", "starred_url": "https://api.github.com/users/talhaanees/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/talhaanees/subscriptions", "organizations_url": "https://api.github.com/users/talhaanees/orgs", "repos_url": "https://api.github.com/users/talhaanees/repos", "events_url": "https://api.github.com/users/talhaanees/events{/privacy}", "received_events_url": "https://api.github.com/users/talhaanees/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-09T10:32:41Z", "updated_at": "2017-06-09T19:51:30Z", "closed_at": null, "body": "I have been working on electron for a whole month to develop an application. But today suddenly at around 11:30 am all my electron applications stopped working. I have no idea what happened but they all give the same error. I tried this:\r\n\r\n# Clone the Quick Start repository\r\n```\r\n$ git clone https://github.com/electron/electron-quick-start\r\n```\r\n# Go into the repository\r\n```\r\n$ cd electron-quick-start\r\n```\r\n# Install the dependencies and run\r\n```\r\n$ npm install && npm start\r\n```\r\n\r\n to see if the basic stuff works but no luck. This is the error I get:\r\n```\r\ninternal/child_process.js:319\r\n throw errnoException(err, 'spawn');\r\n ^\r\n\r\nError: spawn EPERM\r\n at exports._errnoException (util.js:1018:11)\r\n at ChildProcess.spawn (internal/child_process.js:319:11)\r\n at Object.exports.spawn (child_process.js:378:9)\r\n at Object. (G:\\**********\\electron-quick-start\\node_modules\\electron\\cli.js:\r\n7:18)\r\n at Module._compile (module.js:570:32)\r\n at Object.Module._extensions..js (module.js:579:10)\r\n at Module.load (module.js:487:32)\r\n at tryModuleLoad (module.js:446:12)\r\n at Function.Module._load (module.js:438:3)\r\n at Module.runMain (module.js:604:10)\r\n\r\nnpm ERR! Windows_NT 10.0.14393\r\nnpm ERR! argv \"D:\\\\Applications\\\\Node.js\\\\node.exe\" \"D:\\\\Applications\\\\Node.js\\\\node_modules\\\\npm\\\\bin\\\\npm-cli.js\" \"sta\r\nrt\"\r\nnpm ERR! node v6.10.3\r\nnpm ERR! npm v3.10.10\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! electron-quick-start@1.0.0 start: `electron .`\r\nnpm ERR! Exit status 1\r\nnpm ERR!\r\nnpm ERR! Failed at the electron-quick-start@1.0.0 start script 'electron .'.\r\nnpm ERR! Make sure you have the latest version of node.js and npm installed.\r\nnpm ERR! If you do, this is most likely a problem with the electron-quick-start package,\r\nnpm ERR! not with npm itself.\r\nnpm ERR! Tell the author that this fails on your system:\r\nnpm ERR! electron .\r\nnpm ERR! You can get information on how to open an issue for this project with:\r\nnpm ERR! npm bugs electron-quick-start\r\nnpm ERR! Or if that isn't available, you can get their info via:\r\nnpm ERR! npm owner ls electron-quick-start\r\nnpm ERR! There is likely additional logging output above.\r\n\r\nnpm ERR! Please include the following file with any support request:\r\nnpm ERR! G:\\************\\electron-quick-start\\npm-debug.log\r\n```" }, { "url": "https://api.github.com/repos/electron/electron/issues/9714", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9714/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9714/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9714/events", "html_url": "https://github.com/electron/electron/issues/9714", "id": 234770684, "number": 9714, "title": "Support --openssl-config cli argument?", "user": { "login": "algv", "id": 16474118, "avatar_url": "https://avatars2.githubusercontent.com/u/16474118?v=3", "gravatar_id": "", "url": "https://api.github.com/users/algv", "html_url": "https://github.com/algv", "followers_url": "https://api.github.com/users/algv/followers", "following_url": "https://api.github.com/users/algv/following{/other_user}", "gists_url": "https://api.github.com/users/algv/gists{/gist_id}", "starred_url": "https://api.github.com/users/algv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/algv/subscriptions", "organizations_url": "https://api.github.com/users/algv/orgs", "repos_url": "https://api.github.com/users/algv/repos", "events_url": "https://api.github.com/users/algv/events{/privacy}", "received_events_url": "https://api.github.com/users/algv/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-09T09:25:01Z", "updated_at": "2017-06-09T09:25:01Z", "closed_at": null, "body": "I want use node: --openssl-config cli argument (https://github.com/nodejs/node/commit/1ea0358a91)\r\n\r\nHow use it from command line for electron?\r\n\r\nIf build from source, can see wat openssl_config in InitCryptoOnce() always null.\r\n\r\n* Electron version: ^1.6.6\r\n* Operating system: Ubuntu 16\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9713", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9713/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9713/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9713/events", "html_url": "https://github.com/electron/electron/issues/9713", "id": 234768214, "number": 9713, "title": "Webview crashes when opening popup", "user": { "login": "Thomas101", "id": 103586, "avatar_url": "https://avatars3.githubusercontent.com/u/103586?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Thomas101", "html_url": "https://github.com/Thomas101", "followers_url": "https://api.github.com/users/Thomas101/followers", "following_url": "https://api.github.com/users/Thomas101/following{/other_user}", "gists_url": "https://api.github.com/users/Thomas101/gists{/gist_id}", "starred_url": "https://api.github.com/users/Thomas101/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Thomas101/subscriptions", "organizations_url": "https://api.github.com/users/Thomas101/orgs", "repos_url": "https://api.github.com/users/Thomas101/repos", "events_url": "https://api.github.com/users/Thomas101/events{/privacy}", "received_events_url": "https://api.github.com/users/Thomas101/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 144086588, "url": "https://api.github.com/repos/electron/electron/labels/component/webview", "name": "component/webview", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false }, { "id": 144752898, "url": "https://api.github.com/repos/electron/electron/labels/fixme/crash", "name": "fixme/crash", "color": "fc2929", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 9, "created_at": "2017-06-09T09:15:31Z", "updated_at": "2017-06-17T10:28:25Z", "closed_at": null, "body": "* Electron version: 1.7.2 & 1.7.3\r\n* Operating system: macOS 10.12.5 & Ubuntu 16.10, maybe others\r\n\r\n### Expected behavior\r\n\r\nOpen a popup window\r\n\r\n### Actual behavior\r\n\r\nPopup window opens, but webview intermittently crashes\r\n\r\n### How to reproduce\r\n\r\n*The example I've provided uses gmail, although the behaviour can be seen on multiple other websites listed at the bottom of the issue*\r\n\r\n```\r\ngit clone https://github.com/wavebox/electron-quick-start.git\r\ncd electron-quick-start\r\ngit checkout webview-popup-crash\r\nnpm install\r\nnpm start\r\n```\r\n\r\nSign in to your gmail account through the embedded webview. Then once gmail has loaded...\r\n\r\n1. Click Compose\r\n2. Shift+Click the full-screen button to open a popout window\r\n \r\n![1](https://user-images.githubusercontent.com/103586/26968574-67faa37e-4cfa-11e7-90f2-204479e7c5b4.png)\r\n\r\n3. Click the pop-in button\r\n \r\n![2](https://user-images.githubusercontent.com/103586/26968578-6e75ffa0-4cfa-11e7-9e46-e8265c3e1816.png)\r\n\r\n4. Repeat steps 2 - 3 a number of times\r\n\r\n\r\nIt doesn't reliably crash every single time but normally crashes after 2-10 attempts. When I've tried to reproduce it seems to be much more reliable when the machine is under load or there's other bits going on in the electron app.\r\n\r\nThe crashed event fires from the webview and the web-contents but no additional information is provided. No additional logs on the command line.\r\n\r\nThis bug isn't exclusive to gmail and its compose window behaviour but it seems pretty reliable when using this example. Other places that you can reproduce...\r\n* **gmail** hangouts popout\r\n* **gmail** github link in message header\r\n* **feedly** login popup\r\n* **asana** login popup\r\n\r\nThanks!" }, { "url": "https://api.github.com/repos/electron/electron/issues/9712", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9712/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9712/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9712/events", "html_url": "https://github.com/electron/electron/issues/9712", "id": 234750013, "number": 9712, "title": "Add callback to webContent.print", "user": { "login": "tim37021", "id": 5507113, "avatar_url": "https://avatars2.githubusercontent.com/u/5507113?v=3", "gravatar_id": "", "url": "https://api.github.com/users/tim37021", "html_url": "https://github.com/tim37021", "followers_url": "https://api.github.com/users/tim37021/followers", "following_url": "https://api.github.com/users/tim37021/following{/other_user}", "gists_url": "https://api.github.com/users/tim37021/gists{/gist_id}", "starred_url": "https://api.github.com/users/tim37021/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tim37021/subscriptions", "organizations_url": "https://api.github.com/users/tim37021/orgs", "repos_url": "https://api.github.com/users/tim37021/repos", "events_url": "https://api.github.com/users/tim37021/events{/privacy}", "received_events_url": "https://api.github.com/users/tim37021/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-09T07:58:06Z", "updated_at": "2017-06-13T10:44:06Z", "closed_at": null, "body": "* Electron version: 1.6\r\n* Operating system: Windows 10\r\n\r\nwebContent.printToPDF does have callback so that we are notified when finishing. I wish electron adding callback to webContent.print as well. \r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9711", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9711/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9711/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9711/events", "html_url": "https://github.com/electron/electron/issues/9711", "id": 234746805, "number": 9711, "title": "In macOS 10.13 frameless BrowserWindow still displays a titlebar", "user": { "login": "RCD-Y", "id": 18318060, "avatar_url": "https://avatars1.githubusercontent.com/u/18318060?v=3", "gravatar_id": "", "url": "https://api.github.com/users/RCD-Y", "html_url": "https://github.com/RCD-Y", "followers_url": "https://api.github.com/users/RCD-Y/followers", "following_url": "https://api.github.com/users/RCD-Y/following{/other_user}", "gists_url": "https://api.github.com/users/RCD-Y/gists{/gist_id}", "starred_url": "https://api.github.com/users/RCD-Y/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RCD-Y/subscriptions", "organizations_url": "https://api.github.com/users/RCD-Y/orgs", "repos_url": "https://api.github.com/users/RCD-Y/repos", "events_url": "https://api.github.com/users/RCD-Y/events{/privacy}", "received_events_url": "https://api.github.com/users/RCD-Y/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false }, { "id": 97403606, "url": "https://api.github.com/repos/electron/electron/labels/platform/macOS", "name": "platform/macOS", "color": "c7def8", "default": false } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-09T07:42:16Z", "updated_at": "2017-06-22T21:27:23Z", "closed_at": "2017-06-22T21:27:23Z", "body": "\r\n\r\nAs described in the title, even a BrowserWindow is passed `frame: false`, the title bar would still be rendered in macOS 10.13. This behavior doesn't happen in 10.12.\r\n\r\nSee this image:\r\n\r\n![Image](http://cgs.news:8080/richard/screenshot.png)\r\n\r\n* Electron version: 1.6.10 and 1.7.3 Beta\r\n* Operating system: macOS 10.13 (Beta) 17A264c\r\n\r\n### Expected behavior\r\n\r\n\r\nNo title bar should be displayed.\r\n\r\n### Actual behavior\r\n\r\n\r\nA white title bar is displayed at the top.\r\n\r\n### How to reproduce\r\n\r\n\r\n\r\nSee this repo: [Demo](https://github.com/RCD-Y/BrowserWindow-bug-demo)\r\n\r\nRun it like so:\r\n\r\n $ git clone https://github.com/RCD-Y/BrowserWindow-bug-demo\r\n $ npm install\r\n $ npm start || electron ." }, { "url": "https://api.github.com/repos/electron/electron/issues/9710", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9710/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9710/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9710/events", "html_url": "https://github.com/electron/electron/issues/9710", "id": 234733401, "number": 9710, "title": "anyone meet this?", "user": { "login": "jinggk", "id": 21035344, "avatar_url": "https://avatars2.githubusercontent.com/u/21035344?v=3", "gravatar_id": "", "url": "https://api.github.com/users/jinggk", "html_url": "https://github.com/jinggk", "followers_url": "https://api.github.com/users/jinggk/followers", "following_url": "https://api.github.com/users/jinggk/following{/other_user}", "gists_url": "https://api.github.com/users/jinggk/gists{/gist_id}", "starred_url": "https://api.github.com/users/jinggk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jinggk/subscriptions", "organizations_url": "https://api.github.com/users/jinggk/orgs", "repos_url": "https://api.github.com/users/jinggk/repos", "events_url": "https://api.github.com/users/jinggk/events{/privacy}", "received_events_url": "https://api.github.com/users/jinggk/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-09T06:30:34Z", "updated_at": "2017-06-09T07:34:20Z", "closed_at": "2017-06-09T07:11:15Z", "body": "\r\nI am doing a project, use electron to do a desktop application, when I use the nodejs fs.createWriteStream in the main process to download the file, if the program installed in the windows C drive, there will be the following mistakes, Have you met? Can you know how to avoid this problem?\r\n\r\n![sqh ro 5c5 zx4infy ite](https://user-images.githubusercontent.com/21035344/26963554-ba1d8d5e-4d1f-11e7-82ab-1110349c0aae.png)\r\n\r\nhere is my code:\r\n![u9y e4 4u 7 8d3grw7j_w](https://user-images.githubusercontent.com/21035344/26963611-099ddb68-4d20-11e7-8162-9cd51e424342.png)\r\n\r\nI used chmod 777 to try to modify the file permissions, but did not work, i do not know why" }, { "url": "https://api.github.com/repos/electron/electron/issues/9709", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9709/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9709/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9709/events", "html_url": "https://github.com/electron/electron/issues/9709", "id": 234725335, "number": 9709, "title": "Only the first letter will be alphabetic when input Japanese. (using Japanese IME)", "user": { "login": "Kurom96", "id": 1531679, "avatar_url": "https://avatars0.githubusercontent.com/u/1531679?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Kurom96", "html_url": "https://github.com/Kurom96", "followers_url": "https://api.github.com/users/Kurom96/followers", "following_url": "https://api.github.com/users/Kurom96/following{/other_user}", "gists_url": "https://api.github.com/users/Kurom96/gists{/gist_id}", "starred_url": "https://api.github.com/users/Kurom96/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Kurom96/subscriptions", "organizations_url": "https://api.github.com/users/Kurom96/orgs", "repos_url": "https://api.github.com/users/Kurom96/repos", "events_url": "https://api.github.com/users/Kurom96/events{/privacy}", "received_events_url": "https://api.github.com/users/Kurom96/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 193723580, "url": "https://api.github.com/repos/electron/electron/labels/blocked", "name": "blocked", "color": "d4c5f9", "default": false }, { "id": 144086588, "url": "https://api.github.com/repos/electron/electron/labels/component/webview", "name": "component/webview", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false }, { "id": 538879644, "url": "https://api.github.com/repos/electron/electron/labels/fixme/regression", "name": "fixme/regression", "color": "fc2929", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2017-06-09T05:31:04Z", "updated_at": "2017-06-14T17:37:01Z", "closed_at": null, "body": "* Electron version: 1.7.2\r\n* Operating system: mac OSX El Capitan 10.11.6\r\n* Node version: 4.4.7, 7.2.1, 7.9.0\r\n\r\n### Expected behavior\r\nWe should be able to input Japanese in text-input on webview, using the Japanese IME to convert alphabets to Japanese.\r\n\r\n### Actual behavior\r\nImmediately after application focus, and start typing Japanese input.\r\nOnly the first letter will be alphabetic.\r\n\r\n### How to reproduce\r\n```\r\n$ git clone https://github.com/Kurom96/electron-quick-start.git -b japanese-input-bug\r\n$ cd electron-quick-start\r\n$ npm i\r\n$ npm start\r\n```\r\n\r\nSee bellow.\r\n\r\n![japanese-input-bug](https://user-images.githubusercontent.com/1531679/26962289-230ba364-4d20-11e7-9096-856d1d042432.gif)\r\n\r\n\r\n### Others\r\n* It does not occur under 1.7.1\r\n* Is this fix affected? #9173\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9708", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9708/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9708/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9708/events", "html_url": "https://github.com/electron/electron/pull/9708", "id": 234716294, "number": 9708, "title": "Reverting per monitor dpi aware causing issues with different dpis", "user": { "login": "juturu", "id": 11049886, "avatar_url": "https://avatars1.githubusercontent.com/u/11049886?v=3", "gravatar_id": "", "url": "https://api.github.com/users/juturu", "html_url": "https://github.com/juturu", "followers_url": "https://api.github.com/users/juturu/followers", "following_url": "https://api.github.com/users/juturu/following{/other_user}", "gists_url": "https://api.github.com/users/juturu/gists{/gist_id}", "starred_url": "https://api.github.com/users/juturu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/juturu/subscriptions", "organizations_url": "https://api.github.com/users/juturu/orgs", "repos_url": "https://api.github.com/users/juturu/repos", "events_url": "https://api.github.com/users/juturu/events{/privacy}", "received_events_url": "https://api.github.com/users/juturu/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-09T04:05:21Z", "updated_at": "2017-06-09T20:27:46Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9708", "html_url": "https://github.com/electron/electron/pull/9708", "diff_url": "https://github.com/electron/electron/pull/9708.diff", "patch_url": "https://github.com/electron/electron/pull/9708.patch" }, "body": "Fixes #9688 #9560 #9691 \r\n\r\nReverts #8786 " }, { "url": "https://api.github.com/repos/electron/electron/issues/9707", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9707/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9707/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9707/events", "html_url": "https://github.com/electron/electron/issues/9707", "id": 234633477, "number": 9707, "title": "npm install electron on Windows 10 error!!!", "user": { "login": "BobOntario", "id": 27965673, "avatar_url": "https://avatars1.githubusercontent.com/u/27965673?v=3", "gravatar_id": "", "url": "https://api.github.com/users/BobOntario", "html_url": "https://github.com/BobOntario", "followers_url": "https://api.github.com/users/BobOntario/followers", "following_url": "https://api.github.com/users/BobOntario/following{/other_user}", "gists_url": "https://api.github.com/users/BobOntario/gists{/gist_id}", "starred_url": "https://api.github.com/users/BobOntario/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BobOntario/subscriptions", "organizations_url": "https://api.github.com/users/BobOntario/orgs", "repos_url": "https://api.github.com/users/BobOntario/repos", "events_url": "https://api.github.com/users/BobOntario/events{/privacy}", "received_events_url": "https://api.github.com/users/BobOntario/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-08T19:35:39Z", "updated_at": "2017-06-09T20:13:33Z", "closed_at": null, "body": "I am trying to install electron using npm:\r\n```\r\nnpm install electron --save-dev\r\n```\r\n\r\n[npm-debug.log.txt](https://github.com/electron/electron/files/1062185/npm-debug.log.txt)\r\n[npm-debug.log.txt](https://github.com/electron/electron/files/1062181/npm-debug.log.txt)\r\n```\r\nelectron@1.6.10 postinstall C:\\Electron\\node_modules\\electron\r\n> node install.js\r\n\r\nC:\\Electron\\node_modules\\electron\\install.js:47\r\n throw err\r\n ^\r\n\r\nError: unable to get local issuer certificate\r\n at Error (native)\r\n at TLSSocket. (_tls_wrap.js:1092:38)\r\n at emitNone (events.js:86:13)\r\n at TLSSocket.emit (events.js:185:7)\r\n at TLSSocket._finishInit (_tls_wrap.js:610:8)\r\n at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:440:38)\r\nnpm WARN Electron@1.0.0 No description\r\nnpm WARN Electron@1.0.0 No repository field.\r\nnpm ERR! Windows_NT 10.0.14393\r\nnpm ERR! argv \"C:\\\\Program Files\\\\nodejs\\\\node.exe\" \"C:\\\\Program Files\\\\nodejs\\\\node_modules\\\\npm\\\\bin\\\\npm-cli.js\" \"install\" \"electron\"\r\nnpm ERR! node v6.11.0\r\nnpm ERR! npm v3.10.10\r\nnpm ERR! code ELIFECYCLE\r\n\r\nnpm ERR! electron@1.6.10 postinstall: `node install.js`\r\nnpm ERR! Exit status 1\r\nnpm ERR!\r\nnpm ERR! Failed at the electron@1.6.10 postinstall script 'node install.js'.\r\nnpm ERR! Make sure you have the latest version of node.js and npm installed.\r\nnpm ERR! If you do, this is most likely a problem with the electron package,\r\nnpm ERR! not with npm itself.\r\nnpm ERR! Tell the author that this fails on your system:\r\nnpm ERR! node install.js\r\nnpm ERR! You can get information on how to open an issue for this project with:\r\nnpm ERR! npm bugs electron\r\nnpm ERR! Or if that isn't available, you can get their info via:\r\nnpm ERR! npm owner ls electron\r\nnpm ERR! There is likely additional logging output above.\r\n\r\nnpm ERR! Please include the following file with any support request:\r\nnpm ERR! C:\\Electron\\npm-debug.log\r\n```" }, { "url": "https://api.github.com/repos/electron/electron/issues/9706", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9706/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9706/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9706/events", "html_url": "https://github.com/electron/electron/pull/9706", "id": 234597571, "number": 9706, "title": "📝 add notes for peak working set size on macOS", "user": { "login": "KagamiChan", "id": 3816900, "avatar_url": "https://avatars2.githubusercontent.com/u/3816900?v=3", "gravatar_id": "", "url": "https://api.github.com/users/KagamiChan", "html_url": "https://github.com/KagamiChan", "followers_url": "https://api.github.com/users/KagamiChan/followers", "following_url": "https://api.github.com/users/KagamiChan/following{/other_user}", "gists_url": "https://api.github.com/users/KagamiChan/gists{/gist_id}", "starred_url": "https://api.github.com/users/KagamiChan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KagamiChan/subscriptions", "organizations_url": "https://api.github.com/users/KagamiChan/orgs", "repos_url": "https://api.github.com/users/KagamiChan/repos", "events_url": "https://api.github.com/users/KagamiChan/events{/privacy}", "received_events_url": "https://api.github.com/users/KagamiChan/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-08T17:17:13Z", "updated_at": "2017-06-09T15:43:07Z", "closed_at": "2017-06-09T15:43:07Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9706", "html_url": "https://github.com/electron/electron/pull/9706", "diff_url": "https://github.com/electron/electron/pull/9706.diff", "patch_url": "https://github.com/electron/electron/pull/9706.patch" }, "body": "According to current [implementation](https://chromium.googlesource.com/chromium/src/base/+/master/process/process_metrics_mac.cc#141) in upstram chromium, the `peakWorkingSetSize` value will always be 0 on macOS (and freebsd, but seems we don't have freebsd releases). I think it is worth noting down for avoid confusions." }, { "url": "https://api.github.com/repos/electron/electron/issues/9705", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9705/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9705/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9705/events", "html_url": "https://github.com/electron/electron/issues/9705", "id": 234567044, "number": 9705, "title": "registerURLSchemeAsPrivileged does not allow service worker to use file:// scheme", "user": { "login": "leshow", "id": 1128302, "avatar_url": "https://avatars0.githubusercontent.com/u/1128302?v=3", "gravatar_id": "", "url": "https://api.github.com/users/leshow", "html_url": "https://github.com/leshow", "followers_url": "https://api.github.com/users/leshow/followers", "following_url": "https://api.github.com/users/leshow/following{/other_user}", "gists_url": "https://api.github.com/users/leshow/gists{/gist_id}", "starred_url": "https://api.github.com/users/leshow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leshow/subscriptions", "organizations_url": "https://api.github.com/users/leshow/orgs", "repos_url": "https://api.github.com/users/leshow/repos", "events_url": "https://api.github.com/users/leshow/events{/privacy}", "received_events_url": "https://api.github.com/users/leshow/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 227722189, "url": "https://api.github.com/repos/electron/electron/labels/component/protocol", "name": "component/protocol", "color": "f9d0c4", "default": false }, { "id": 546663659, "url": "https://api.github.com/repos/electron/electron/labels/waiting/needs-repro", "name": "waiting/needs-repro", "color": "fbca04", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-08T15:30:30Z", "updated_at": "2017-06-23T04:12:58Z", "closed_at": null, "body": "* Electron version: 1.6.10 ia32\r\n* Operating system: windows 7 x64\r\n\r\n### Expected behavior\r\ncreate-react-app comes with a service worker by default that uses the fetch API to cache and load resources. I'm expecting `webFrame.registerURLSchemeAsPrivileged('file');` to allow the fetch to load with the file scheme.\r\n\r\n### Actual behavior\r\nWhen fetch is used inside of Electron from the service worker the original error is:\r\n```\r\nFetch API cannot load file://.... URL scheme \"file\" is not supported\"\r\n```\r\nAccording to,\r\nhttps://github.com/electron/electron/issues/2831\r\nhttps://github.com/electron/electron/issues/9474\r\n\r\n \"You can add fetch support to file scheme in your app by using webFrame.registerURLSchemeAsPrivileged api.\"\r\n\r\nSo I attempted `webFrame.registerURLSchemeAsPrivileged('file');` \r\n\r\nWhich changes the error to:\r\n\r\n`Uncaught (in promise) TypeError: Request scheme 'file' is unsupported at service-worker.js:1`\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9704", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9704/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9704/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9704/events", "html_url": "https://github.com/electron/electron/pull/9704", "id": 234545824, "number": 9704, "title": "Upgrade to electron/libchromiumcontent@3d692b2280", "user": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-08T14:26:13Z", "updated_at": "2017-06-08T16:39:45Z", "closed_at": "2017-06-08T16:39:43Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9704", "html_url": "https://github.com/electron/electron/pull/9704", "diff_url": "https://github.com/electron/electron/pull/9704.diff", "patch_url": "https://github.com/electron/electron/pull/9704.patch" }, "body": "Pulls in https://github.com/electron/libchromiumcontent/pull/296\r\n\r\nWhich allows `webgl` configuration with a `powerPreference`:\r\n\r\n```js\r\ndocument.createElement('canvas').getContext('webgl', {powerPreference: \"low-power\"});\r\n```\r\n\r\n/cc @miniak " }, { "url": "https://api.github.com/repos/electron/electron/issues/9703", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9703/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9703/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9703/events", "html_url": "https://github.com/electron/electron/pull/9703", "id": 234520377, "number": 9703, "title": "Fix typings for cookies.get", "user": { "login": "MarshallOfSound", "id": 6634592, "avatar_url": "https://avatars0.githubusercontent.com/u/6634592?v=3", "gravatar_id": "", "url": "https://api.github.com/users/MarshallOfSound", "html_url": "https://github.com/MarshallOfSound", "followers_url": "https://api.github.com/users/MarshallOfSound/followers", "following_url": "https://api.github.com/users/MarshallOfSound/following{/other_user}", "gists_url": "https://api.github.com/users/MarshallOfSound/gists{/gist_id}", "starred_url": "https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MarshallOfSound/subscriptions", "organizations_url": "https://api.github.com/users/MarshallOfSound/orgs", "repos_url": "https://api.github.com/users/MarshallOfSound/repos", "events_url": "https://api.github.com/users/MarshallOfSound/events{/privacy}", "received_events_url": "https://api.github.com/users/MarshallOfSound/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 1, "created_at": "2017-06-08T13:04:05Z", "updated_at": "2017-06-08T17:43:44Z", "closed_at": "2017-06-08T17:43:42Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9703", "html_url": "https://github.com/electron/electron/pull/9703", "diff_url": "https://github.com/electron/electron/pull/9703.diff", "patch_url": "https://github.com/electron/electron/pull/9703.patch" }, "body": "/cc @zeke " }, { "url": "https://api.github.com/repos/electron/electron/issues/9702", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9702/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9702/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9702/events", "html_url": "https://github.com/electron/electron/issues/9702", "id": 234504096, "number": 9702, "title": "electron width socket.io error", "user": { "login": "crylg", "id": 4261373, "avatar_url": "https://avatars2.githubusercontent.com/u/4261373?v=3", "gravatar_id": "", "url": "https://api.github.com/users/crylg", "html_url": "https://github.com/crylg", "followers_url": "https://api.github.com/users/crylg/followers", "following_url": "https://api.github.com/users/crylg/following{/other_user}", "gists_url": "https://api.github.com/users/crylg/gists{/gist_id}", "starred_url": "https://api.github.com/users/crylg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/crylg/subscriptions", "organizations_url": "https://api.github.com/users/crylg/orgs", "repos_url": "https://api.github.com/users/crylg/repos", "events_url": "https://api.github.com/users/crylg/events{/privacy}", "received_events_url": "https://api.github.com/users/crylg/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-08T12:01:54Z", "updated_at": "2017-06-08T12:01:54Z", "closed_at": null, "body": "WebSocket connection to 'ws://120.76.235.149:8000/socket.io/?EIO=3&transport=websocket&sid=RimiajuKN-wN5JrhAAAh' failed: Error during WebSocket handshake: Unexpected response code: 400\r\n\r\nclient.js\r\n\r\nGlobal.SOCKET = io('http://120.76.235.149:8000');\r\n\r\nit is strange that.., \r\n 1.There is no error in the socket.io intranet server \r\n2. before the client is packaged by electron-package, there is no error in accessing the extranet 3.http://amritb.github.io/socketio-client-tool/#url=aHR0cDovLzEyMC43Ni4yMzUuMTQ5OjgwMDA=&opt=&events= log->show:6:32:51:332 Connected" }, { "url": "https://api.github.com/repos/electron/electron/issues/9701", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9701/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9701/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9701/events", "html_url": "https://github.com/electron/electron/issues/9701", "id": 234460909, "number": 9701, "title": "Electron window handler didn't work with Unity on win10", "user": { "login": "Lordkodo", "id": 6387777, "avatar_url": "https://avatars3.githubusercontent.com/u/6387777?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Lordkodo", "html_url": "https://github.com/Lordkodo", "followers_url": "https://api.github.com/users/Lordkodo/followers", "following_url": "https://api.github.com/users/Lordkodo/following{/other_user}", "gists_url": "https://api.github.com/users/Lordkodo/gists{/gist_id}", "starred_url": "https://api.github.com/users/Lordkodo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lordkodo/subscriptions", "organizations_url": "https://api.github.com/users/Lordkodo/orgs", "repos_url": "https://api.github.com/users/Lordkodo/repos", "events_url": "https://api.github.com/users/Lordkodo/events{/privacy}", "received_events_url": "https://api.github.com/users/Lordkodo/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-08T09:13:38Z", "updated_at": "2017-06-08T09:17:22Z", "closed_at": null, "body": "Hello guys\r\n\r\nI try to launch an unity exe in an electron window.\r\n\r\nFor that:\r\n- I get my window handler ID with `win.getNativeWindowHandle()` from [electron](https://electron.atom.io/docs/api/browser-window/#wingetnativewindowhandle).\r\n- I launch my unity exe with : `./unity/Child.exe -parentHWND {window_handler_id} delayed` from [unity doc](https://docs.unity3d.com/Manual/CommandLineArguments.html).\r\n- On win7 and win8 my window display the unity application, but with win10 I get a blinking window who sometime display my unity exe.\r\n\r\nIf I launch my unity exe on another window, Firefox for example, it works. But not on Slack or Atom (electron apps).\r\n\r\nDo you got an idea ?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9700", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9700/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9700/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9700/events", "html_url": "https://github.com/electron/electron/pull/9700", "id": 234460722, "number": 9700, "title": "Zoom controller improvements", "user": { "login": "brenca", "id": 1690458, "avatar_url": "https://avatars1.githubusercontent.com/u/1690458?v=3", "gravatar_id": "", "url": "https://api.github.com/users/brenca", "html_url": "https://github.com/brenca", "followers_url": "https://api.github.com/users/brenca/followers", "following_url": "https://api.github.com/users/brenca/following{/other_user}", "gists_url": "https://api.github.com/users/brenca/gists{/gist_id}", "starred_url": "https://api.github.com/users/brenca/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/brenca/subscriptions", "organizations_url": "https://api.github.com/users/brenca/orgs", "repos_url": "https://api.github.com/users/brenca/repos", "events_url": "https://api.github.com/users/brenca/events{/privacy}", "received_events_url": "https://api.github.com/users/brenca/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-08T09:12:54Z", "updated_at": "2017-06-14T10:15:29Z", "closed_at": "2017-06-14T10:15:29Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9700", "html_url": "https://github.com/electron/electron/pull/9700", "diff_url": "https://github.com/electron/electron/pull/9700.diff", "patch_url": "https://github.com/electron/electron/pull/9700.patch" }, "body": "I've ported some code from the chromium zoom controller implementation to make the native PDF plugin work like it would in chromium - on zoom change only the document is zoomed, not the UI. " }, { "url": "https://api.github.com/repos/electron/electron/issues/9699", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9699/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9699/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9699/events", "html_url": "https://github.com/electron/electron/issues/9699", "id": 234458855, "number": 9699, "title": "This dependency was not found: * fs in ./~/.1.6.10@electron/index.js", "user": { "login": "lyric-index", "id": 23474941, "avatar_url": "https://avatars1.githubusercontent.com/u/23474941?v=3", "gravatar_id": "", "url": "https://api.github.com/users/lyric-index", "html_url": "https://github.com/lyric-index", "followers_url": "https://api.github.com/users/lyric-index/followers", "following_url": "https://api.github.com/users/lyric-index/following{/other_user}", "gists_url": "https://api.github.com/users/lyric-index/gists{/gist_id}", "starred_url": "https://api.github.com/users/lyric-index/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lyric-index/subscriptions", "organizations_url": "https://api.github.com/users/lyric-index/orgs", "repos_url": "https://api.github.com/users/lyric-index/repos", "events_url": "https://api.github.com/users/lyric-index/events{/privacy}", "received_events_url": "https://api.github.com/users/lyric-index/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-08T09:05:57Z", "updated_at": "2017-06-08T09:11:52Z", "closed_at": "2017-06-08T09:11:52Z", "body": "\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: windows10 15063.296\r\n* nodejs: 6.11.0\r\n\r\nProblem:\r\n This dependency was not found:\r\n * fs in ./~/.1.6.10@electron/index.js\r\n To install it, you can run: npm install --save fs\r\n\r\n![image](https://user-images.githubusercontent.com/23474941/26920683-5383078a-4c6c-11e7-9379-aa4f40e5d9e4.png)\r\n![image](https://user-images.githubusercontent.com/23474941/26920789-b35383c4-4c6c-11e7-836b-4fd11f894ae6.png)\r\n-->\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9698", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9698/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9698/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9698/events", "html_url": "https://github.com/electron/electron/issues/9698", "id": 234443199, "number": 9698, "title": "unable to copy paste cut selectall on MAC in Production Environment", "user": { "login": "isNeilLin", "id": 18683728, "avatar_url": "https://avatars1.githubusercontent.com/u/18683728?v=3", "gravatar_id": "", "url": "https://api.github.com/users/isNeilLin", "html_url": "https://github.com/isNeilLin", "followers_url": "https://api.github.com/users/isNeilLin/followers", "following_url": "https://api.github.com/users/isNeilLin/following{/other_user}", "gists_url": "https://api.github.com/users/isNeilLin/gists{/gist_id}", "starred_url": "https://api.github.com/users/isNeilLin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/isNeilLin/subscriptions", "organizations_url": "https://api.github.com/users/isNeilLin/orgs", "repos_url": "https://api.github.com/users/isNeilLin/repos", "events_url": "https://api.github.com/users/isNeilLin/events{/privacy}", "received_events_url": "https://api.github.com/users/isNeilLin/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-08T08:03:30Z", "updated_at": "2017-06-08T08:04:11Z", "closed_at": null, "body": "In development Environment track 'copy', 'paste','cut' event is ok, in Production Environment couldn't track 'copy', 'paste','cut' event . and unable to copy paste cut selectall on MAC, on windows is ok. my electron version is 1.4.13" }, { "url": "https://api.github.com/repos/electron/electron/issues/9697", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9697/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9697/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9697/events", "html_url": "https://github.com/electron/electron/issues/9697", "id": 234324525, "number": 9697, "title": "Promisify Electron APIs", "user": { "login": "j-f1", "id": 25517624, "avatar_url": "https://avatars1.githubusercontent.com/u/25517624?v=3", "gravatar_id": "", "url": "https://api.github.com/users/j-f1", "html_url": "https://github.com/j-f1", "followers_url": "https://api.github.com/users/j-f1/followers", "following_url": "https://api.github.com/users/j-f1/following{/other_user}", "gists_url": "https://api.github.com/users/j-f1/gists{/gist_id}", "starred_url": "https://api.github.com/users/j-f1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/j-f1/subscriptions", "organizations_url": "https://api.github.com/users/j-f1/orgs", "repos_url": "https://api.github.com/users/j-f1/repos", "events_url": "https://api.github.com/users/j-f1/events{/privacy}", "received_events_url": "https://api.github.com/users/j-f1/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 35575880, "url": "https://api.github.com/repos/electron/electron/labels/enhancement", "name": "enhancement", "color": "84b6eb", "default": true } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-07T19:57:56Z", "updated_at": "2017-06-09T16:29:39Z", "closed_at": null, "body": "\r\n\r\n* Electron version: N/A\r\n* Operating system: N/A\r\n\r\n### Expected behavior\r\n\r\n\r\n```js\r\n// or any other async API\r\nwin.webContents.getZoomFactor().then(factor => {\r\n // ...\r\n})\r\n// This should also work:\r\nwin.webContents.getZoomFactor(factor => {\r\n // ...\r\n})\r\n```\r\n\r\n### Actual behavior\r\n\r\n\r\nThe `Promise`-based one fails to execute, but the callback-based one works.\r\n\r\n### How to reproduce\r\n\r\nN/A" }, { "url": "https://api.github.com/repos/electron/electron/issues/9696", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9696/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9696/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9696/events", "html_url": "https://github.com/electron/electron/issues/9696", "id": 234312647, "number": 9696, "title": "--inspect does not seem to work in forked processes", "user": { "login": "bpasero", "id": 900690, "avatar_url": "https://avatars0.githubusercontent.com/u/900690?v=3", "gravatar_id": "", "url": "https://api.github.com/users/bpasero", "html_url": "https://github.com/bpasero", "followers_url": "https://api.github.com/users/bpasero/followers", "following_url": "https://api.github.com/users/bpasero/following{/other_user}", "gists_url": "https://api.github.com/users/bpasero/gists{/gist_id}", "starred_url": "https://api.github.com/users/bpasero/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bpasero/subscriptions", "organizations_url": "https://api.github.com/users/bpasero/orgs", "repos_url": "https://api.github.com/users/bpasero/repos", "events_url": "https://api.github.com/users/bpasero/events{/privacy}", "received_events_url": "https://api.github.com/users/bpasero/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 565223195, "url": "https://api.github.com/repos/electron/electron/labels/component/node-integration", "name": "component/node-integration", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-07T19:11:38Z", "updated_at": "2017-06-13T04:01:02Z", "closed_at": "2017-06-12T21:23:34Z", "body": "* Electron version: 1.7.2\r\n* Operating system: macOS 10.12.5\r\n\r\n### Expected behavior\r\n\r\nForked processes can be started with `--inspect` or `--inspect-brk` for debugging them.\r\n\r\n### Actual behavior\r\n\r\nThis option does not seem to have any impact.\r\n\r\n### How to reproduce\r\n\r\n* `git clone https://github.com/bpasero/electron-inspect.git`\r\n* `npm install`\r\n* `./node_modules/.bin/electron .`\r\n\r\n=> we fork the process in https://github.com/bpasero/electron-inspect/blob/master/fork.js#L3\r\n=> you see a file `tempXYZ` appearing which means `script.js` was executed\r\n=> this is unexpected because `fork.js` was forked with `--inspect-brk`\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9695", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9695/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9695/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9695/events", "html_url": "https://github.com/electron/electron/pull/9695", "id": 234274605, "number": 9695, "title": "Fix an issue where alwaysOnTop window disappears when restore…", "user": { "login": "shubham2892", "id": 6316389, "avatar_url": "https://avatars1.githubusercontent.com/u/6316389?v=3", "gravatar_id": "", "url": "https://api.github.com/users/shubham2892", "html_url": "https://github.com/shubham2892", "followers_url": "https://api.github.com/users/shubham2892/followers", "following_url": "https://api.github.com/users/shubham2892/following{/other_user}", "gists_url": "https://api.github.com/users/shubham2892/gists{/gist_id}", "starred_url": "https://api.github.com/users/shubham2892/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shubham2892/subscriptions", "organizations_url": "https://api.github.com/users/shubham2892/orgs", "repos_url": "https://api.github.com/users/shubham2892/repos", "events_url": "https://api.github.com/users/shubham2892/events{/privacy}", "received_events_url": "https://api.github.com/users/shubham2892/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-07T16:50:36Z", "updated_at": "2017-06-25T22:38:49Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9695", "html_url": "https://github.com/electron/electron/pull/9695", "diff_url": "https://github.com/electron/electron/pull/9695.diff", "patch_url": "https://github.com/electron/electron/pull/9695.patch" }, "body": "Fixes #9170 \r\nReset the custom level when windowWillMiniaturize fires and then restores it when windowDidDeminiaturize fires as suggested in issue.\r\n\r\nBefore: \r\n![Before Gif](http://i.imgur.com/81KX0Nm.gif)\r\n\r\nAfter:\r\n![After Gif](http://g.recordit.co/KNSZ7jDrhw.gif)\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9694", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9694/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9694/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9694/events", "html_url": "https://github.com/electron/electron/pull/9694", "id": 234271494, "number": 9694, "title": ":memo: Fix link to Thai documentation", "user": { "login": "yuit", "id": 489742, "avatar_url": "https://avatars1.githubusercontent.com/u/489742?v=3", "gravatar_id": "", "url": "https://api.github.com/users/yuit", "html_url": "https://github.com/yuit", "followers_url": "https://api.github.com/users/yuit/followers", "following_url": "https://api.github.com/users/yuit/following{/other_user}", "gists_url": "https://api.github.com/users/yuit/gists{/gist_id}", "starred_url": "https://api.github.com/users/yuit/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yuit/subscriptions", "organizations_url": "https://api.github.com/users/yuit/orgs", "repos_url": "https://api.github.com/users/yuit/repos", "events_url": "https://api.github.com/users/yuit/events{/privacy}", "received_events_url": "https://api.github.com/users/yuit/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-07T16:39:13Z", "updated_at": "2017-06-08T13:56:41Z", "closed_at": "2017-06-08T13:56:34Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9694", "html_url": "https://github.com/electron/electron/pull/9694", "diff_url": "https://github.com/electron/electron/pull/9694.diff", "patch_url": "https://github.com/electron/electron/pull/9694.patch" }, "body": "" }, { "url": "https://api.github.com/repos/electron/electron/issues/9693", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9693/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9693/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9693/events", "html_url": "https://github.com/electron/electron/issues/9693", "id": 234118186, "number": 9693, "title": "max_old_space_size doesn't work when running electron as node", "user": { "login": "jrieken", "id": 1794099, "avatar_url": "https://avatars1.githubusercontent.com/u/1794099?v=3", "gravatar_id": "", "url": "https://api.github.com/users/jrieken", "html_url": "https://github.com/jrieken", "followers_url": "https://api.github.com/users/jrieken/followers", "following_url": "https://api.github.com/users/jrieken/following{/other_user}", "gists_url": "https://api.github.com/users/jrieken/gists{/gist_id}", "starred_url": "https://api.github.com/users/jrieken/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jrieken/subscriptions", "organizations_url": "https://api.github.com/users/jrieken/orgs", "repos_url": "https://api.github.com/users/jrieken/repos", "events_url": "https://api.github.com/users/jrieken/events{/privacy}", "received_events_url": "https://api.github.com/users/jrieken/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-07T07:35:54Z", "updated_at": "2017-06-07T07:36:31Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.6.10\r\n\r\n### Expected behavior\r\n\r\nI expect `--max_old_space_size` to work when electron is run as node. This was initially discussed [here](https://github.com/electron/electron/issues/2056#issuecomment-306565476) (Sorry for the double post in case you follow-up on comments in closed issues)\r\n\r\n### How to reproduce\r\n\r\n* Have a program that keeps allocating memory (see below, save it as `big.js`)\r\n* Run it via `./node_modules/electron/dist/Electron.app/Contents/MacOS/Electron --js-flags=\"--max_old_space_size=128\" ~/Desktop/big.js` and see that the last message is `heapTotal: 139`\r\n* Now run as node via `env ELECTRON_RUN_AS_NODE=true ./node_modules/electron/dist/Electron.app/Contents/MacOS/Electron --max_old_space_size=128 ~/Desktop/big.js` and see that the last message is `heapTotal: 1504`\r\n* :bug: The `max_old_space_size`-flag has no effect when running as node, the limit is always ~1.5GB and cannot be lowered nor increased. \r\n\r\n```js\r\nlet all = [];\r\nlet big = [];\r\nall.push(big);\r\nfor (let i = 0; i < 1000000000; i++) {\r\n let newLen = big.push(Math.random());\r\n if (newLen % 500000 === 0) {\r\n big = [];\r\n all.push(big);\r\n console.log('all.length: ' + all.length);\r\n console.log('heapTotal: ' + Math.round(process.memoryUsage().heapTotal / 1e6));\r\n }\r\n}\r\n\r\nconsole.log(all.length);\r\n\r\n```\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9692", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9692/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9692/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9692/events", "html_url": "https://github.com/electron/electron/issues/9692", "id": 234110488, "number": 9692, "title": "window.open is opening link in default browser", "user": { "login": "RamanKharchee", "id": 16698919, "avatar_url": "https://avatars1.githubusercontent.com/u/16698919?v=3", "gravatar_id": "", "url": "https://api.github.com/users/RamanKharchee", "html_url": "https://github.com/RamanKharchee", "followers_url": "https://api.github.com/users/RamanKharchee/followers", "following_url": "https://api.github.com/users/RamanKharchee/following{/other_user}", "gists_url": "https://api.github.com/users/RamanKharchee/gists{/gist_id}", "starred_url": "https://api.github.com/users/RamanKharchee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RamanKharchee/subscriptions", "organizations_url": "https://api.github.com/users/RamanKharchee/orgs", "repos_url": "https://api.github.com/users/RamanKharchee/repos", "events_url": "https://api.github.com/users/RamanKharchee/events{/privacy}", "received_events_url": "https://api.github.com/users/RamanKharchee/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-07T06:59:11Z", "updated_at": "2017-06-07T08:49:11Z", "closed_at": "2017-06-07T08:35:22Z", "body": "I have one problem. Currently i am running my application on localhost in chrome/mozilla/IE. In my application i have one js file that i get the link from the server and then i call window.open to open that link in new tab, And now i have written one main.js to run my application on electron. It starts completely good, but when it comes to window.open it opens it in my chrome browser not in electron app. I want to open it in electron app as a new Browser window or as an tab. But not in the same page. How to achieve it?\r\n\r\nand this is my main.js where i have mentioned about open in new browser window\r\n\r\nfunction(module, exports, __webpack_require__) {\r\n\r\n‘use strict’;\r\n \r\n Object.defineProperty(exports, “__esModule”, {\r\n value: true\r\n });\r\n \r\n var _electron = __webpack_require__(14);\r\n \r\n function initContextMenu(mainWindow) {\r\n _electron.ipcMain.on(‘contextMenuOpened’, function (event, targetHref) {\r\n var contextMenuTemplate = [{\r\n label: ‘Open in default browser’,\r\n click: function click() {\r\n if (targetHref) {\r\n _electron.shell.openExternal(targetHref);\r\n return;\r\n }\r\n }\r\n }, {\r\n label: ‘Open in new window’,\r\n click: function click() {\r\n if (targetHref) {\r\n new _electron.BrowserWindow().loadURL(targetHref);\r\n return;\r\n }\r\n \r\n mainWindow.useDefaultWindowBehaviour = true;\r\n mainWindow.webContents.send(‘contextMenuClosed’);\r\n }\r\n }];\r\n \r\n var contextMenu = _electron.Menu.buildFromTemplate(contextMenuTemplate);\r\n contextMenu.popup(mainWindow);\r\n mainWindow.contextMenuOpen = true;\r\n });\r\n }\r\n \r\n exports.default = initContextMenu;\r\n\r\n/***/ }" }, { "url": "https://api.github.com/repos/electron/electron/issues/9691", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9691/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9691/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9691/events", "html_url": "https://github.com/electron/electron/issues/9691", "id": 234105440, "number": 9691, "title": "Wrong BrowserWindow size on Hi-dpi devices", "user": { "login": "KochiyaOcean", "id": 8194131, "avatar_url": "https://avatars0.githubusercontent.com/u/8194131?v=3", "gravatar_id": "", "url": "https://api.github.com/users/KochiyaOcean", "html_url": "https://github.com/KochiyaOcean", "followers_url": "https://api.github.com/users/KochiyaOcean/followers", "following_url": "https://api.github.com/users/KochiyaOcean/following{/other_user}", "gists_url": "https://api.github.com/users/KochiyaOcean/gists{/gist_id}", "starred_url": "https://api.github.com/users/KochiyaOcean/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KochiyaOcean/subscriptions", "organizations_url": "https://api.github.com/users/KochiyaOcean/orgs", "repos_url": "https://api.github.com/users/KochiyaOcean/repos", "events_url": "https://api.github.com/users/KochiyaOcean/events{/privacy}", "received_events_url": "https://api.github.com/users/KochiyaOcean/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-07T06:31:06Z", "updated_at": "2017-06-24T13:58:53Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: Windows 10 (System scaling factor is 2.5)\r\n\r\n### Expected behavior\r\n\r\nCreate a BrowserWindow and the BrowserWindow's size is the same of option.\r\n\r\n### Actual behavior\r\n\r\nThe created BrowserWindow's size is larger than the option\r\n\r\n### How to reproduce\r\n\r\nJust create a BrowserWindow as below.\r\n\r\nSeems only happens on devices that doesn't have an integer scaling factor.\r\n\r\n![image](https://user-images.githubusercontent.com/8194131/26865110-d487d296-4b8d-11e7-8469-8a4949588201.png)\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9690", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9690/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9690/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9690/events", "html_url": "https://github.com/electron/electron/issues/9690", "id": 234087787, "number": 9690, "title": "Can't register custom protocol", "user": { "login": "Zyles", "id": 1741593, "avatar_url": "https://avatars0.githubusercontent.com/u/1741593?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Zyles", "html_url": "https://github.com/Zyles", "followers_url": "https://api.github.com/users/Zyles/followers", "following_url": "https://api.github.com/users/Zyles/following{/other_user}", "gists_url": "https://api.github.com/users/Zyles/gists{/gist_id}", "starred_url": "https://api.github.com/users/Zyles/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Zyles/subscriptions", "organizations_url": "https://api.github.com/users/Zyles/orgs", "repos_url": "https://api.github.com/users/Zyles/repos", "events_url": "https://api.github.com/users/Zyles/events{/privacy}", "received_events_url": "https://api.github.com/users/Zyles/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-07T04:13:55Z", "updated_at": "2017-06-07T04:23:20Z", "closed_at": "2017-06-07T04:21:57Z", "body": "Okay after hours of work I got my last issue solved with your custom callback error on eslint.\r\n\r\nNow to the second issue. How do I get this protocol to actually work?\r\n\r\nI used the sample code from the docs: https://electron.atom.io/docs/api/protocol/\r\n\r\nI can not access atom:// in Google Chrome when my app is running. I also tried registerHttpProtocol, but same problem. Is this normal? Do I need to access this url from inside the app itself?\r\n\r\nI am using this in a ouath2 redirect fashion.\r\n\r\nIf I put a console.log() inside the function it never echoes, but neither does the error.\r\n\r\nI tried to search the registry and I couldn't find an entry there either.\r\n\r\nIf I use it with mainWindow.loadURL(), the console.log() DOES echo but it returns to a blank page.\r\n\r\n* Electron version: 1.7.2\r\n* Operating system: Win 10\r\n\r\n### Expected behavior\r\n\r\nRegister new protocol, registry changes, access through browser\r\n\r\n### Actual behavior\r\n\r\nNada.\r\n\r\n### How to reproduce\r\n\r\nUse docs code." }, { "url": "https://api.github.com/repos/electron/electron/issues/9689", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9689/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9689/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9689/events", "html_url": "https://github.com/electron/electron/issues/9689", "id": 234073050, "number": 9689, "title": "PrinterInfo in Windows", "user": { "login": "rensiu", "id": 6029722, "avatar_url": "https://avatars3.githubusercontent.com/u/6029722?v=3", "gravatar_id": "", "url": "https://api.github.com/users/rensiu", "html_url": "https://github.com/rensiu", "followers_url": "https://api.github.com/users/rensiu/followers", "following_url": "https://api.github.com/users/rensiu/following{/other_user}", "gists_url": "https://api.github.com/users/rensiu/gists{/gist_id}", "starred_url": "https://api.github.com/users/rensiu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rensiu/subscriptions", "organizations_url": "https://api.github.com/users/rensiu/orgs", "repos_url": "https://api.github.com/users/rensiu/repos", "events_url": "https://api.github.com/users/rensiu/events{/privacy}", "received_events_url": "https://api.github.com/users/rensiu/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-07T02:13:16Z", "updated_at": "2017-06-07T02:13:16Z", "closed_at": null, "body": "Electron:1.7.2 beta\r\nCan you add 'printer-uri-supported' into PrinterInfo.options in windows ，which be included in PrinterInfo.options of mac now?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9688", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9688/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9688/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9688/events", "html_url": "https://github.com/electron/electron/issues/9688", "id": 234070377, "number": 9688, "title": "In windows multiple monitor setup with different DPIs, electron app starts out of bounds", "user": { "login": "juturu", "id": 11049886, "avatar_url": "https://avatars1.githubusercontent.com/u/11049886?v=3", "gravatar_id": "", "url": "https://api.github.com/users/juturu", "html_url": "https://github.com/juturu", "followers_url": "https://api.github.com/users/juturu/followers", "following_url": "https://api.github.com/users/juturu/following{/other_user}", "gists_url": "https://api.github.com/users/juturu/gists{/gist_id}", "starred_url": "https://api.github.com/users/juturu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/juturu/subscriptions", "organizations_url": "https://api.github.com/users/juturu/orgs", "repos_url": "https://api.github.com/users/juturu/repos", "events_url": "https://api.github.com/users/juturu/events{/privacy}", "received_events_url": "https://api.github.com/users/juturu/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 538879644, "url": "https://api.github.com/repos/electron/electron/labels/fixme/regression", "name": "fixme/regression", "color": "fc2929", "default": false }, { "id": 97403549, "url": "https://api.github.com/repos/electron/electron/labels/platform/windows", "name": "platform/windows", "color": "c7def8", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-07T01:52:04Z", "updated_at": "2017-06-07T06:38:01Z", "closed_at": null, "body": "* Electron version: 1.6.8 or 1.7.1\r\n* Operating system: Windows\r\n\r\n### Expected behavior\r\nIn windows multiple monitor setup with different DPIs, electron app starts out of bounds\r\n\r\n### Actual behavior\r\nShould start at the same place where app was last opened\r\n\r\n### How to reproduce\r\n1. Have two monitors with 200% and 100% DPI\r\n2. Start electron app and move the app to monitor with 100% DPI (non maximized)\r\n3. Quit and Restart the app\r\n\r\nApp starts out of the bounds in the 100% DPI monitor.\r\n\r\nThis is a regression after #8786 . I reverted this change and this issue no longer repros." }, { "url": "https://api.github.com/repos/electron/electron/issues/9687", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9687/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9687/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9687/events", "html_url": "https://github.com/electron/electron/pull/9687", "id": 234049179, "number": 9687, "title": "Simplify customButtonsOnHover implementation", "user": { "login": "poiru", "id": 1319028, "avatar_url": "https://avatars1.githubusercontent.com/u/1319028?v=3", "gravatar_id": "", "url": "https://api.github.com/users/poiru", "html_url": "https://github.com/poiru", "followers_url": "https://api.github.com/users/poiru/followers", "following_url": "https://api.github.com/users/poiru/following{/other_user}", "gists_url": "https://api.github.com/users/poiru/gists{/gist_id}", "starred_url": "https://api.github.com/users/poiru/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poiru/subscriptions", "organizations_url": "https://api.github.com/users/poiru/orgs", "repos_url": "https://api.github.com/users/poiru/repos", "events_url": "https://api.github.com/users/poiru/events{/privacy}", "received_events_url": "https://api.github.com/users/poiru/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 4, "created_at": "2017-06-06T22:59:42Z", "updated_at": "2017-06-12T15:10:57Z", "closed_at": "2017-06-07T01:54:05Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9687", "html_url": "https://github.com/electron/electron/pull/9687", "diff_url": "https://github.com/electron/electron/pull/9687.diff", "patch_url": "https://github.com/electron/electron/pull/9687.patch" }, "body": "" }, { "url": "https://api.github.com/repos/electron/electron/issues/9686", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9686/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9686/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9686/events", "html_url": "https://github.com/electron/electron/pull/9686", "id": 234031060, "number": 9686, "title": ":memo: Fixed typo", "user": { "login": "awaigand", "id": 5626967, "avatar_url": "https://avatars2.githubusercontent.com/u/5626967?v=3", "gravatar_id": "", "url": "https://api.github.com/users/awaigand", "html_url": "https://github.com/awaigand", "followers_url": "https://api.github.com/users/awaigand/followers", "following_url": "https://api.github.com/users/awaigand/following{/other_user}", "gists_url": "https://api.github.com/users/awaigand/gists{/gist_id}", "starred_url": "https://api.github.com/users/awaigand/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/awaigand/subscriptions", "organizations_url": "https://api.github.com/users/awaigand/orgs", "repos_url": "https://api.github.com/users/awaigand/repos", "events_url": "https://api.github.com/users/awaigand/events{/privacy}", "received_events_url": "https://api.github.com/users/awaigand/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-06T21:31:31Z", "updated_at": "2017-06-06T21:33:31Z", "closed_at": "2017-06-06T21:33:26Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9686", "html_url": "https://github.com/electron/electron/pull/9686", "diff_url": "https://github.com/electron/electron/pull/9686.diff", "patch_url": "https://github.com/electron/electron/pull/9686.patch" }, "body": "Fixed a simple typo in the docs." }, { "url": "https://api.github.com/repos/electron/electron/issues/9685", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9685/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9685/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9685/events", "html_url": "https://github.com/electron/electron/issues/9685", "id": 234010154, "number": 9685, "title": "Protocol: Unexpected literal in error position of callback", "user": { "login": "Zyles", "id": 1741593, "avatar_url": "https://avatars0.githubusercontent.com/u/1741593?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Zyles", "html_url": "https://github.com/Zyles", "followers_url": "https://api.github.com/users/Zyles/followers", "following_url": "https://api.github.com/users/Zyles/following{/other_user}", "gists_url": "https://api.github.com/users/Zyles/gists{/gist_id}", "starred_url": "https://api.github.com/users/Zyles/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Zyles/subscriptions", "organizations_url": "https://api.github.com/users/Zyles/orgs", "repos_url": "https://api.github.com/users/Zyles/repos", "events_url": "https://api.github.com/users/Zyles/events{/privacy}", "received_events_url": "https://api.github.com/users/Zyles/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-06T20:12:55Z", "updated_at": "2017-06-07T02:30:14Z", "closed_at": "2017-06-07T02:30:14Z", "body": "https://electron.atom.io/docs/api/protocol/\r\n\r\n* Electron version: 1.7.2\r\n* Operating system: Win 10\r\n\r\n### Expected behavior\r\n\r\nNo errors.\r\n\r\n### Actual behavior\r\n\r\nErrors: \r\n\r\n````\r\n https://google.com/#q=standard%2Fno-callback-literal Unexpected literal in error position of callback\r\n src\\main\\index.js:48:5\r\n callback({path: path.normalize(`${__dirname}/${url}`)})\r\n`````\r\n\r\n\r\n### How to reproduce\r\n\r\nDo exactly like the docs." }, { "url": "https://api.github.com/repos/electron/electron/issues/9684", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9684/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9684/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9684/events", "html_url": "https://github.com/electron/electron/issues/9684", "id": 234006442, "number": 9684, "title": "fetch does not support posting files as multipart/form-data", "user": { "login": "ProPuke", "id": 105934, "avatar_url": "https://avatars3.githubusercontent.com/u/105934?v=3", "gravatar_id": "", "url": "https://api.github.com/users/ProPuke", "html_url": "https://github.com/ProPuke", "followers_url": "https://api.github.com/users/ProPuke/followers", "following_url": "https://api.github.com/users/ProPuke/following{/other_user}", "gists_url": "https://api.github.com/users/ProPuke/gists{/gist_id}", "starred_url": "https://api.github.com/users/ProPuke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ProPuke/subscriptions", "organizations_url": "https://api.github.com/users/ProPuke/orgs", "repos_url": "https://api.github.com/users/ProPuke/repos", "events_url": "https://api.github.com/users/ProPuke/events{/privacy}", "received_events_url": "https://api.github.com/users/ProPuke/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-06T19:59:06Z", "updated_at": "2017-06-07T21:56:54Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.7.2\r\n* Operating system: Windows 7 Home Premium\r\n\r\n### Expected behavior\r\n\r\nAmending a file to a FormData instance and then POSTing it with fetch from the renderer should include the file contents as multipart/form-data\r\n```js\r\nlet data = new FormData();\r\ndata.append('file', fs.createReadStream(filename), path.basename(filename));\r\n\r\nfetch(url, {\r\n method: 'POST',\r\n body: data\r\n});\r\n```\r\n\r\n### Actual behavior\r\n\r\nThe `file` parameter is passed with no value and the filename parameter is ignored.\r\nUsing a Blob instead of a fs.ReadStream, the filename parameter is honoured and data sent, but unfortunately incorrect data is sent.\r\n\r\n### How to reproduce\r\n\r\n```\r\nlet data = new FormData();\r\ndata.append('file', fs.createReadStream(filename), path.basename(filename));\r\n\r\nfetch(url, {\r\n method: 'POST',\r\n body: data\r\n});\r\n```\r\nCheck the network tab in Developer Tools and verify there is no filename or data on the request data" }, { "url": "https://api.github.com/repos/electron/electron/issues/9683", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9683/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9683/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9683/events", "html_url": "https://github.com/electron/electron/issues/9683", "id": 233972225, "number": 9683, "title": "Touch isn't working on a specific Surface Book ", "user": { "login": "juturu", "id": 11049886, "avatar_url": "https://avatars1.githubusercontent.com/u/11049886?v=3", "gravatar_id": "", "url": "https://api.github.com/users/juturu", "html_url": "https://github.com/juturu", "followers_url": "https://api.github.com/users/juturu/followers", "following_url": "https://api.github.com/users/juturu/following{/other_user}", "gists_url": "https://api.github.com/users/juturu/gists{/gist_id}", "starred_url": "https://api.github.com/users/juturu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/juturu/subscriptions", "organizations_url": "https://api.github.com/users/juturu/orgs", "repos_url": "https://api.github.com/users/juturu/repos", "events_url": "https://api.github.com/users/juturu/events{/privacy}", "received_events_url": "https://api.github.com/users/juturu/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-06T17:48:21Z", "updated_at": "2017-06-06T17:48:21Z", "closed_at": null, "body": "* Electron version: 1.6.x or 1.7.x\r\n* Operating system: Windows 10\r\n\r\n### Expected behavior\r\nUsing touch, user should be able to interact.\r\n\r\n### Actual behavior\r\nTouch doesn't work on a Surface Book. This is happening only on one surface book and not all of them.\r\nThis issue is not repro'ing on chrome on the same Surface book.\r\n\r\n### How to reproduce\r\n\r\nOn a surface book, launch Electron 1.7.2 or 1.6.10. Touch doesn't work. I have a surface book which is exhibiting this behavior.\r\nCan you point me in a direction to debug this issue further? Any logs i can capture to see what is going on? Any command line args which can be passed to chromium to get touch traces?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9682", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9682/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9682/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9682/events", "html_url": "https://github.com/electron/electron/pull/9682", "id": 233957551, "number": 9682, "title": "Rebuild native modules when configuration starts with R", "user": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-06T16:53:40Z", "updated_at": "2017-06-06T20:37:51Z", "closed_at": "2017-06-06T20:37:49Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9682", "html_url": "https://github.com/electron/electron/pull/9682", "diff_url": "https://github.com/electron/electron/pull/9682.diff", "patch_url": "https://github.com/electron/electron/pull/9682.patch" }, "body": "Support other release configurations that may have the architecture in them like `R_x64`.\r\n\r\nCloses #9651" }, { "url": "https://api.github.com/repos/electron/electron/issues/9681", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9681/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9681/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9681/events", "html_url": "https://github.com/electron/electron/issues/9681", "id": 233814294, "number": 9681, "title": "[Linux] Menu bar text color doesn't follow desktop theme colors", "user": { "login": "Photon89", "id": 1191480, "avatar_url": "https://avatars1.githubusercontent.com/u/1191480?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Photon89", "html_url": "https://github.com/Photon89", "followers_url": "https://api.github.com/users/Photon89/followers", "following_url": "https://api.github.com/users/Photon89/following{/other_user}", "gists_url": "https://api.github.com/users/Photon89/gists{/gist_id}", "starred_url": "https://api.github.com/users/Photon89/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Photon89/subscriptions", "organizations_url": "https://api.github.com/users/Photon89/orgs", "repos_url": "https://api.github.com/users/Photon89/repos", "events_url": "https://api.github.com/users/Photon89/events{/privacy}", "received_events_url": "https://api.github.com/users/Photon89/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-06T08:22:11Z", "updated_at": "2017-06-16T11:35:24Z", "closed_at": null, "body": "First of all, let me say sorry for the fact that this issue will most probably not comply with the issue reporting guidelines. This is due to the fact that I am not a developer using electron but just a user using electron apps, in particular Franz (http://meetfranz.com) and Skype (the new electron version of it). Since the issue I want to report appeared in both apps, I assume that it is an issue of electron itself, but if I am wrong here, let me know.\r\n\r\nThe issue is of rather cosmetic nature: The text color in the menu bar seems to be hard coded to white when not hovered and black when hovered. This leads to the problem that in dark themes the text becomes hard to read when hovered and on light themes when not hovered. Here are some screenshots demonstrating the issue in Skype:\r\n\r\nLight theme, not hovered: ![auswahl_054](https://cloud.githubusercontent.com/assets/1191480/26819946/5afdde44-4aa1-11e7-97ae-0d6f34cd9567.png)\r\nLight theme, hovered: ![auswahl_053](https://cloud.githubusercontent.com/assets/1191480/26819944/5af10cf0-4aa1-11e7-8f73-4ef3a30d232e.png)\r\nDark theme, not hovered: ![auswahl_051](https://cloud.githubusercontent.com/assets/1191480/26819943/5aeda5d8-4aa1-11e7-9b7a-62664926b7c0.png)\r\nDark theme, hovered: ![auswahl_052](https://cloud.githubusercontent.com/assets/1191480/26819945/5afb6312-4aa1-11e7-9997-e70b0f0a1661.png)\r\n\r\n\r\n\r\n* Electron version: Unknown, I'm using binary packages of Franz and Skype. \r\n* Operating system: Manjaro Linux\r\n\r\n### Expected behavior\r\n\r\n\r\nThe text color in the menu bar should follow the theme settings like in native (GTK) applications\r\n\r\n\r\n### Actual behavior\r\n\r\n\r\nThe text color is hard to read if hovered on dark themes or not hovered on light themes\r\n\r\n### How to reproduce\r\n\r\n\r\nUse Skype or Franz on Linux with light or dark GTK themes." }, { "url": "https://api.github.com/repos/electron/electron/issues/9680", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9680/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9680/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9680/events", "html_url": "https://github.com/electron/electron/issues/9680", "id": 233765205, "number": 9680, "title": "BrowserWindow.openDevTools doesn't force show of hidden BrowserWindow if dev tools docked.", "user": { "login": "TimNZ", "id": 1051701, "avatar_url": "https://avatars3.githubusercontent.com/u/1051701?v=3", "gravatar_id": "", "url": "https://api.github.com/users/TimNZ", "html_url": "https://github.com/TimNZ", "followers_url": "https://api.github.com/users/TimNZ/followers", "following_url": "https://api.github.com/users/TimNZ/following{/other_user}", "gists_url": "https://api.github.com/users/TimNZ/gists{/gist_id}", "starred_url": "https://api.github.com/users/TimNZ/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TimNZ/subscriptions", "organizations_url": "https://api.github.com/users/TimNZ/orgs", "repos_url": "https://api.github.com/users/TimNZ/repos", "events_url": "https://api.github.com/users/TimNZ/events{/privacy}", "received_events_url": "https://api.github.com/users/TimNZ/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-06T02:53:06Z", "updated_at": "2017-06-06T02:53:06Z", "closed_at": null, "body": "* Electron version: 1.7.2\r\n* Operating system: At least Windows\r\n\r\n### Expected behavior\r\nbrowserWindowInstance.openDevTools() on window created with { show: false } forces show of BrowserWindow if devtools are docked.\r\n\r\n### Actual behavior\r\nDev tools window only opened if { show: false} and dev tools has been previously detached\r\n\r\n### How to reproduce\r\n\r\nIf dev tools docked to BrowserWindow, window will not show on openDevTools()\r\nIf dev tools detached from BrowserWindow, DevTools window will show if BrowserWindow instance hidden. \r\n\r\nThis was confusing the hell out of me as DevTools window was popping up on my Mac, but just a co-incidence that I had previously detached.\r\n\r\n```\r\nconst {BrowserWindow,app} = require('electron');\r\n\r\napp.on('ready',() => {\r\nlet browserWindow = new BrowserWindow({show:false});\r\nbrowserWindow.loadURL('https://www.xero.com');\r\nbrowserWindow.openDevTools(); // Won't show if docked\r\n\r\n});\r\n```\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9679", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9679/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9679/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9679/events", "html_url": "https://github.com/electron/electron/issues/9679", "id": 233737139, "number": 9679, "title": "Add Chromium 59 Support", "user": { "login": "setpixel", "id": 441117, "avatar_url": "https://avatars1.githubusercontent.com/u/441117?v=3", "gravatar_id": "", "url": "https://api.github.com/users/setpixel", "html_url": "https://github.com/setpixel", "followers_url": "https://api.github.com/users/setpixel/followers", "following_url": "https://api.github.com/users/setpixel/following{/other_user}", "gists_url": "https://api.github.com/users/setpixel/gists{/gist_id}", "starred_url": "https://api.github.com/users/setpixel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/setpixel/subscriptions", "organizations_url": "https://api.github.com/users/setpixel/orgs", "repos_url": "https://api.github.com/users/setpixel/repos", "events_url": "https://api.github.com/users/setpixel/events{/privacy}", "received_events_url": "https://api.github.com/users/setpixel/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 535392427, "url": "https://api.github.com/repos/electron/electron/labels/component/build", "name": "component/build", "color": "f9d0c4", "default": false }, { "id": 35575880, "url": "https://api.github.com/repos/electron/electron/labels/enhancement", "name": "enhancement", "color": "84b6eb", "default": true } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 9, "created_at": "2017-06-05T23:16:19Z", "updated_at": "2017-06-17T20:40:13Z", "closed_at": null, "body": "Woot. Chromium 59 was released stable with some gigantic bugs squashed very important to my project! 💃 \r\n\r\nWhat can I do to help?\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9678", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9678/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9678/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9678/events", "html_url": "https://github.com/electron/electron/issues/9678", "id": 233725995, "number": 9678, "title": "CSP sandbox directive still allows modals", "user": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "labels": [ { "id": 35575880, "url": "https://api.github.com/repos/electron/electron/labels/enhancement", "name": "enhancement", "color": "84b6eb", "default": true }, { "id": 193723590, "url": "https://api.github.com/repos/electron/electron/labels/fixme/security", "name": "fixme/security", "color": "FF0000", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-05T22:12:53Z", "updated_at": "2017-06-06T15:07:31Z", "closed_at": null, "body": "Setting the `sandbox` CSP directive still allows `alert`, `confirm`, and `window.open` to be called from a `BrowserWindow`.\r\n\r\nThe `window.open` issue can be addressed by setting `nativeWindowOpen` to `true` which will show proper `Blocked opening URL in a new window because the request was made in a sandboxed frame whose 'allow-popups' permission is not set.` errors.\r\n\r\n`alert` and `confirm` support can be added by dropping the custom implementations from https://github.com/electron/electron/blob/53b6ee0e3ff3b5abd2f28cd52cc29e4e0d6cb570/lib/renderer/window-setup.js#L132-L138 and using Chrome's default JavaScript dialog manager.\r\n\r\nhttps://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/sandbox" }, { "url": "https://api.github.com/repos/electron/electron/issues/9677", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9677/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9677/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9677/events", "html_url": "https://github.com/electron/electron/issues/9677", "id": 233672661, "number": 9677, "title": "Issue in the documentation of types for DesktopCapturer.getSources() function ", "user": { "login": "Nykkolas", "id": 26922258, "avatar_url": "https://avatars1.githubusercontent.com/u/26922258?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Nykkolas", "html_url": "https://github.com/Nykkolas", "followers_url": "https://api.github.com/users/Nykkolas/followers", "following_url": "https://api.github.com/users/Nykkolas/following{/other_user}", "gists_url": "https://api.github.com/users/Nykkolas/gists{/gist_id}", "starred_url": "https://api.github.com/users/Nykkolas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Nykkolas/subscriptions", "organizations_url": "https://api.github.com/users/Nykkolas/orgs", "repos_url": "https://api.github.com/users/Nykkolas/repos", "events_url": "https://api.github.com/users/Nykkolas/events{/privacy}", "received_events_url": "https://api.github.com/users/Nykkolas/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-05T18:36:16Z", "updated_at": "2017-06-06T01:48:36Z", "closed_at": "2017-06-06T01:48:36Z", "body": "Hello,\r\n\r\n* Electron version: v1.6.10\r\n* Operating system: macOS 10.12.5\r\n\r\nI believe that there is an issue in electron-api.json for DesktopCapturer.getSources() function.\r\nIn the options arguments, types is declared as String but, according to the documentation, it should be an Array of Strings. \r\n\r\nIt causes issues when using it with Hate externs (https://github.com/fponticelli/hxelectron).\r\n\r\nThanks and have a nice day !\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9676", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9676/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9676/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9676/events", "html_url": "https://github.com/electron/electron/issues/9676", "id": 233663056, "number": 9676, "title": "OnMouseLeave and OnMouseOut not firing when element is leaved from RIGHT side", "user": { "login": "NahroTo", "id": 16029639, "avatar_url": "https://avatars3.githubusercontent.com/u/16029639?v=3", "gravatar_id": "", "url": "https://api.github.com/users/NahroTo", "html_url": "https://github.com/NahroTo", "followers_url": "https://api.github.com/users/NahroTo/followers", "following_url": "https://api.github.com/users/NahroTo/following{/other_user}", "gists_url": "https://api.github.com/users/NahroTo/gists{/gist_id}", "starred_url": "https://api.github.com/users/NahroTo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NahroTo/subscriptions", "organizations_url": "https://api.github.com/users/NahroTo/orgs", "repos_url": "https://api.github.com/users/NahroTo/repos", "events_url": "https://api.github.com/users/NahroTo/events{/privacy}", "received_events_url": "https://api.github.com/users/NahroTo/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-05T17:56:58Z", "updated_at": "2017-06-05T17:56:58Z", "closed_at": null, "body": "OnMouseLeave and OnMouseOut are not firing if the mouse leaves the element from the RIGHT side. Very annoying bug." }, { "url": "https://api.github.com/repos/electron/electron/issues/9675", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9675/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9675/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9675/events", "html_url": "https://github.com/electron/electron/issues/9675", "id": 233613913, "number": 9675, "title": "destroyed event not fired when moving webcontents across webviews on different BrowserWindow", "user": { "login": "magne4000", "id": 1098371, "avatar_url": "https://avatars3.githubusercontent.com/u/1098371?v=3", "gravatar_id": "", "url": "https://api.github.com/users/magne4000", "html_url": "https://github.com/magne4000", "followers_url": "https://api.github.com/users/magne4000/followers", "following_url": "https://api.github.com/users/magne4000/following{/other_user}", "gists_url": "https://api.github.com/users/magne4000/gists{/gist_id}", "starred_url": "https://api.github.com/users/magne4000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/magne4000/subscriptions", "organizations_url": "https://api.github.com/users/magne4000/orgs", "repos_url": "https://api.github.com/users/magne4000/repos", "events_url": "https://api.github.com/users/magne4000/events{/privacy}", "received_events_url": "https://api.github.com/users/magne4000/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-05T14:51:36Z", "updated_at": "2017-06-09T09:03:57Z", "closed_at": null, "body": "* Electron version: 1.7.2\r\n* Operating system: MacOS 10.12.5\r\n\r\n### Expected behavior\r\nWhen moving a webcontents from a webview to another one **contained on a different `BrowserWindow`**, with the help of `guestinstance` attribute, the source webview should receive a `destroyed` event.\r\n\r\n### Actual behavior\r\n`destroyed` event is not fired.\r\n\r\n### How to reproduce\r\nI have [a repo](https://github.com/magne4000/electron-boilerplate/pull/1) in which the issue is reproducible.\r\nWhen you `npm start`, main window creates a webview and sends its `guestinstance` to the main process.\r\nThen a second window is opened, it reads the `guestinstance` from the main and set it on its own webview, but `destroyed` event is not triggered on the main webview." }, { "url": "https://api.github.com/repos/electron/electron/issues/9674", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9674/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9674/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9674/events", "html_url": "https://github.com/electron/electron/pull/9674", "id": 233600403, "number": 9674, "title": "Revert \"Merge pull request #8724 from electron/defer_load_url\"", "user": { "login": "deepak1556", "id": 964386, "avatar_url": "https://avatars2.githubusercontent.com/u/964386?v=3", "gravatar_id": "", "url": "https://api.github.com/users/deepak1556", "html_url": "https://github.com/deepak1556", "followers_url": "https://api.github.com/users/deepak1556/followers", "following_url": "https://api.github.com/users/deepak1556/following{/other_user}", "gists_url": "https://api.github.com/users/deepak1556/gists{/gist_id}", "starred_url": "https://api.github.com/users/deepak1556/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/deepak1556/subscriptions", "organizations_url": "https://api.github.com/users/deepak1556/orgs", "repos_url": "https://api.github.com/users/deepak1556/repos", "events_url": "https://api.github.com/users/deepak1556/events{/privacy}", "received_events_url": "https://api.github.com/users/deepak1556/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 3, "created_at": "2017-06-05T14:09:40Z", "updated_at": "2017-06-06T21:09:00Z", "closed_at": "2017-06-05T17:21:19Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9674", "html_url": "https://github.com/electron/electron/pull/9674", "diff_url": "https://github.com/electron/electron/pull/9674.diff", "patch_url": "https://github.com/electron/electron/pull/9674.patch" }, "body": "There are edge cases involving pending navigation entries that weren't accounted for in the original PR. https://github.com/electron/electron/issues/8700 can be fixed with plznavigate move.\r\n\r\nFixes https://github.com/electron/electron/issues/9121" }, { "url": "https://api.github.com/repos/electron/electron/issues/9673", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9673/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9673/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9673/events", "html_url": "https://github.com/electron/electron/issues/9673", "id": 233576866, "number": 9673, "title": "AtExit hook for native modules", "user": { "login": "grigorryev", "id": 21245681, "avatar_url": "https://avatars2.githubusercontent.com/u/21245681?v=3", "gravatar_id": "", "url": "https://api.github.com/users/grigorryev", "html_url": "https://github.com/grigorryev", "followers_url": "https://api.github.com/users/grigorryev/followers", "following_url": "https://api.github.com/users/grigorryev/following{/other_user}", "gists_url": "https://api.github.com/users/grigorryev/gists{/gist_id}", "starred_url": "https://api.github.com/users/grigorryev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/grigorryev/subscriptions", "organizations_url": "https://api.github.com/users/grigorryev/orgs", "repos_url": "https://api.github.com/users/grigorryev/repos", "events_url": "https://api.github.com/users/grigorryev/events{/privacy}", "received_events_url": "https://api.github.com/users/grigorryev/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-05T12:43:54Z", "updated_at": "2017-06-05T12:44:07Z", "closed_at": null, "body": "Hi!\r\nI'm trying to perform some uninitialization within my C++ native module in the moment before electron main process is finished.\r\nI tried to use Node AtExit hook, as suggested in Node documentation (https://nodejs.org/api/addons.html#addons_atexit_hooks), but it doesn't work.\r\nIs there any way to do this in electron? \r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9672", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9672/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9672/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9672/events", "html_url": "https://github.com/electron/electron/issues/9672", "id": 233561856, "number": 9672, "title": "SRC attribute issue", "user": { "login": "caishengmao", "id": 20150875, "avatar_url": "https://avatars2.githubusercontent.com/u/20150875?v=3", "gravatar_id": "", "url": "https://api.github.com/users/caishengmao", "html_url": "https://github.com/caishengmao", "followers_url": "https://api.github.com/users/caishengmao/followers", "following_url": "https://api.github.com/users/caishengmao/following{/other_user}", "gists_url": "https://api.github.com/users/caishengmao/gists{/gist_id}", "starred_url": "https://api.github.com/users/caishengmao/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/caishengmao/subscriptions", "organizations_url": "https://api.github.com/users/caishengmao/orgs", "repos_url": "https://api.github.com/users/caishengmao/repos", "events_url": "https://api.github.com/users/caishengmao/events{/privacy}", "received_events_url": "https://api.github.com/users/caishengmao/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-05T11:30:06Z", "updated_at": "2017-06-05T11:55:30Z", "closed_at": "2017-06-05T11:55:30Z", "body": "In Angularjs, how do you use webview to write the value of the SRC attribute as a variable." }, { "url": "https://api.github.com/repos/electron/electron/issues/9671", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9671/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9671/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9671/events", "html_url": "https://github.com/electron/electron/issues/9671", "id": 233542750, "number": 9671, "title": "Window: backgroundColor does not match CSS color", "user": { "login": "bpasero", "id": 900690, "avatar_url": "https://avatars0.githubusercontent.com/u/900690?v=3", "gravatar_id": "", "url": "https://api.github.com/users/bpasero", "html_url": "https://github.com/bpasero", "followers_url": "https://api.github.com/users/bpasero/followers", "following_url": "https://api.github.com/users/bpasero/following{/other_user}", "gists_url": "https://api.github.com/users/bpasero/gists{/gist_id}", "starred_url": "https://api.github.com/users/bpasero/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bpasero/subscriptions", "organizations_url": "https://api.github.com/users/bpasero/orgs", "repos_url": "https://api.github.com/users/bpasero/repos", "events_url": "https://api.github.com/users/bpasero/events{/privacy}", "received_events_url": "https://api.github.com/users/bpasero/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-05T09:53:52Z", "updated_at": "2017-06-25T16:54:11Z", "closed_at": null, "body": "* Electron version: 1.7.x\r\n* Operating system: macOS 10.12.5\r\n\r\n### Expected behavior\r\n\r\nSetting a window `backgroundColor` should produce the same visual result as setting it via CSS.\r\n\r\n### Actual behavior\r\n\r\nThere is a slight flicker from where the background color from CSS kicks in.\r\n\r\n### How to reproduce\r\n\r\n* create a window with background color: `new BrowserWindow({ width: 800, height: 600, backgroundColor: '#DDDDDD' })`\r\n* in that window set the same background color via CSS: ``\r\n* `loadURL` of the window with a slight timeout to see the difference\r\n```javascript\r\nsetTimeout(function () {\r\n win.loadURL(url.format({\r\n pathname: path.join(__dirname, 'index.html'),\r\n protocol: 'file:',\r\n slashes: true\r\n }))\r\n}, 2000);\r\n```\r\n\r\nThe following video shows the difference clearly:\r\n\r\n![panel-red](https://cloud.githubusercontent.com/assets/900690/26779427/9775cdb2-49e5-11e7-9ec3-b8dbfa600c7a.gif)\r\n\r\nCould it be that the window `backgroundColor` somehow uses a different color space compared to the renderer one via CSS?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9670", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9670/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9670/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9670/events", "html_url": "https://github.com/electron/electron/issues/9670", "id": 233522693, "number": 9670, "title": "Option to keep Chromium's browser interface", "user": { "login": "Jop-V", "id": 2750434, "avatar_url": "https://avatars2.githubusercontent.com/u/2750434?v=3", "gravatar_id": "", "url": "https://api.github.com/users/Jop-V", "html_url": "https://github.com/Jop-V", "followers_url": "https://api.github.com/users/Jop-V/followers", "following_url": "https://api.github.com/users/Jop-V/following{/other_user}", "gists_url": "https://api.github.com/users/Jop-V/gists{/gist_id}", "starred_url": "https://api.github.com/users/Jop-V/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Jop-V/subscriptions", "organizations_url": "https://api.github.com/users/Jop-V/orgs", "repos_url": "https://api.github.com/users/Jop-V/repos", "events_url": "https://api.github.com/users/Jop-V/events{/privacy}", "received_events_url": "https://api.github.com/users/Jop-V/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-05T08:14:58Z", "updated_at": "2017-06-07T09:50:22Z", "closed_at": "2017-06-05T11:09:49Z", "body": "It would be helpful if there was an option to keep the user interface of Chromium, with its back/forward buttons, reload button and tabs (and theoretically even Google account history syncing). \r\n\r\nWould this be hard, has the codebase deviated too much?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9669", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9669/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9669/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9669/events", "html_url": "https://github.com/electron/electron/issues/9669", "id": 233465555, "number": 9669, "title": "GamePad API accepts input when window not in focus", "user": { "login": "LukePulverenti", "id": 3607463, "avatar_url": "https://avatars1.githubusercontent.com/u/3607463?v=3", "gravatar_id": "", "url": "https://api.github.com/users/LukePulverenti", "html_url": "https://github.com/LukePulverenti", "followers_url": "https://api.github.com/users/LukePulverenti/followers", "following_url": "https://api.github.com/users/LukePulverenti/following{/other_user}", "gists_url": "https://api.github.com/users/LukePulverenti/gists{/gist_id}", "starred_url": "https://api.github.com/users/LukePulverenti/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LukePulverenti/subscriptions", "organizations_url": "https://api.github.com/users/LukePulverenti/orgs", "repos_url": "https://api.github.com/users/LukePulverenti/repos", "events_url": "https://api.github.com/users/LukePulverenti/events{/privacy}", "received_events_url": "https://api.github.com/users/LukePulverenti/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-04T22:50:20Z", "updated_at": "2017-06-04T22:50:20Z", "closed_at": null, "body": "* Electron version: 1.7.2, 1.6.11, 1.4.16\r\n* Operating system: Windows 10, Windows 8, Windows 7\r\n\r\n### Expected behavior\r\n\r\nGamePad API should mimic browser behavior and only accept input when electron window is focused.\r\n\r\n### Actual behavior\r\n\r\nGamePad API always accepts input, even with window minimized or out of focus.\r\n\r\n### How to reproduce\r\n\r\nRun an input loop using requestAnimationFrame to listen for GamePad input. Or load this url into an electron browser window: \r\n\r\nhttp://html5gamepad.com\r\n\r\nObserve that input is handled with electron not in focus. As time allows i will create a sample repository. Thanks !\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9668", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9668/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9668/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9668/events", "html_url": "https://github.com/electron/electron/issues/9668", "id": 233450037, "number": 9668, "title": "Crash randomly when using a custom protocol (as standard, privileged)", "user": { "login": "pwnsdx", "id": 2057765, "avatar_url": "https://avatars0.githubusercontent.com/u/2057765?v=3", "gravatar_id": "", "url": "https://api.github.com/users/pwnsdx", "html_url": "https://github.com/pwnsdx", "followers_url": "https://api.github.com/users/pwnsdx/followers", "following_url": "https://api.github.com/users/pwnsdx/following{/other_user}", "gists_url": "https://api.github.com/users/pwnsdx/gists{/gist_id}", "starred_url": "https://api.github.com/users/pwnsdx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pwnsdx/subscriptions", "organizations_url": "https://api.github.com/users/pwnsdx/orgs", "repos_url": "https://api.github.com/users/pwnsdx/repos", "events_url": "https://api.github.com/users/pwnsdx/events{/privacy}", "received_events_url": "https://api.github.com/users/pwnsdx/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-04T18:16:14Z", "updated_at": "2017-06-06T15:27:01Z", "closed_at": "2017-06-06T01:56:35Z", "body": "\r\n\r\n* Electron version: 1.7.2\r\n* Operating system: macOS Sierra 10.12.5\r\n\r\n### Expected behavior\r\n\r\n\r\nNot to crash\r\n\r\n### Actual behavior\r\n\r\n\r\nCrash\r\n\r\n```\r\n$ electron electron\r\n[...]\r\nSegmentation fault: 11\r\n```\r\n\r\nCrashlog:\r\n\r\n```\r\nProcess: Electron [92066]\r\nPath: /Users/USER/Desktop/*/Electron.app/Contents/MacOS/Electron\r\nIdentifier: com.github.electron\r\nVersion: 1.7.0 (1.7.0)\r\nCode Type: X86-64 (Native)\r\nParent Process: node [92065]\r\nResponsible: Electron [97769]\r\nUser ID: 501\r\n\r\nDate/Time: 2017-06-04 19:40:39.379 +0200\r\nOS Version: Mac OS X 10.12.5 (16F73)\r\nReport Version: 12\r\nAnonymous UUID: A7596419-C7A8-02C1-C8F0-94252677B560\r\n\r\n\r\nTime Awake Since Boot: 530000 seconds\r\n\r\nSystem Integrity Protection: enabled\r\n\r\nCrashed Thread: 22 Chrome_IOThread\r\n\r\nException Type: EXC_BAD_ACCESS (SIGSEGV)\r\nException Codes: KERN_INVALID_ADDRESS at 0x0000000000000000\r\n\r\nVM Regions Near 0:\r\n--> \r\n __TEXT 0000000106f74000-0000000106f75000 [ 4K] r-x/rwx SM=COW /Users/USER/Desktop/*/Electron.app/Contents/MacOS/Electron\r\n\r\nThread 0:: CrBrowserMain Dispatch queue: com.apple.main-thread\r\n0 libsystem_kernel.dylib \t0x00007fffd210934a mach_msg_trap + 10\r\n1 libsystem_kernel.dylib \t0x00007fffd2108797 mach_msg + 55\r\n2 com.apple.CoreFoundation \t0x00007fffbc869434 __CFRunLoopServiceMachPort + 212\r\n3 com.apple.CoreFoundation \t0x00007fffbc8688c1 __CFRunLoopRun + 1361\r\n4 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n5 com.apple.HIToolbox \t0x00007fffbbdc9ebc RunCurrentEventLoopInMode + 240\r\n6 com.apple.HIToolbox \t0x00007fffbbdc9cf1 ReceiveNextEventCommon + 432\r\n7 com.apple.HIToolbox \t0x00007fffbbdc9b26 _BlockUntilNextEventMatchingListInModeWithFilter + 71\r\n8 com.apple.AppKit \t0x00007fffba362a54 _DPSNextEvent + 1120\r\n9 com.apple.AppKit \t0x00007fffbaade7ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796\r\n10 com.apple.AppKit \t0x00007fffba3573db -[NSApplication run] + 926\r\n11 com.github.electron.framework \t0x00000001071bfdfe 0x106f77000 + 2395646\r\n12 com.github.electron.framework \t0x00000001071bf3ec 0x106f77000 + 2393068\r\n13 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n14 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n15 com.github.electron.framework \t0x0000000107436fab 0x106f77000 + 4980651\r\n16 com.github.electron.framework \t0x0000000107436e00 0x106f77000 + 4980224\r\n17 com.github.electron.framework \t0x0000000107439f22 0x106f77000 + 4992802\r\n18 com.github.electron.framework \t0x00000001074329ec 0x106f77000 + 4962796\r\n19 com.github.electron.framework \t0x000000010738b920 0x106f77000 + 4278560\r\n20 com.github.electron.framework \t0x000000010738aa76 0x106f77000 + 4274806\r\n21 com.github.electron.framework \t0x0000000106f79287 AtomMain + 71\r\n22 com.github.electron \t0x0000000106f74f26 main + 38\r\n23 libdyld.dylib \t0x00007fffd1fe2235 start + 1\r\n\r\nThread 1:\r\n0 libsystem_kernel.dylib \t0x00007fffd211144e __workq_kernreturn + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fb621 _pthread_wqthread + 1426\r\n2 libsystem_pthread.dylib \t0x00007fffd21fb07d start_wqthread + 13\r\n\r\nThread 2:\r\n0 libsystem_kernel.dylib \t0x00007fffd211144e __workq_kernreturn + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fb621 _pthread_wqthread + 1426\r\n2 libsystem_pthread.dylib \t0x00007fffd21fb07d start_wqthread + 13\r\n\r\nThread 3:\r\n0 libsystem_kernel.dylib \t0x00007fffd211144e __workq_kernreturn + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fb48e _pthread_wqthread + 1023\r\n2 libsystem_pthread.dylib \t0x00007fffd21fb07d start_wqthread + 13\r\n\r\nThread 4:: WorkerPool/13835\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc833 _pthread_cond_wait + 769\r\n2 com.github.electron.framework \t0x0000000107177d1b 0x106f77000 + 2100507\r\n3 com.github.electron.framework \t0x00000001072251d6 0x106f77000 + 2810326\r\n4 com.github.electron.framework \t0x0000000107225667 0x106f77000 + 2811495\r\n5 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n6 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 5:\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc7fa _pthread_cond_wait + 712\r\n2 libnode.dylib \t0x000000010b6b16f9 uv_cond_wait + 9\r\n3 libnode.dylib \t0x000000010b6a5ac3 0x10b547000 + 1436355\r\n4 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n5 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n6 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 6:\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc7fa _pthread_cond_wait + 712\r\n2 libnode.dylib \t0x000000010b6b16f9 uv_cond_wait + 9\r\n3 libnode.dylib \t0x000000010b6a5ac3 0x10b547000 + 1436355\r\n4 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n5 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n6 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 7:\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc7fa _pthread_cond_wait + 712\r\n2 libnode.dylib \t0x000000010b6b16f9 uv_cond_wait + 9\r\n3 libnode.dylib \t0x000000010b6a5ac3 0x10b547000 + 1436355\r\n4 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n5 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n6 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 8:\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc7fa _pthread_cond_wait + 712\r\n2 libnode.dylib \t0x000000010b6b16f9 uv_cond_wait + 9\r\n3 libnode.dylib \t0x000000010b6a5ac3 0x10b547000 + 1436355\r\n4 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n5 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n6 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 9:: NetworkConfigWatcher\r\n0 libsystem_kernel.dylib \t0x00007fffd210934a mach_msg_trap + 10\r\n1 libsystem_kernel.dylib \t0x00007fffd2108797 mach_msg + 55\r\n2 com.apple.CoreFoundation \t0x00007fffbc869434 __CFRunLoopServiceMachPort + 212\r\n3 com.apple.CoreFoundation \t0x00007fffbc8688c1 __CFRunLoopRun + 1361\r\n4 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n5 com.apple.Foundation \t0x00007fffbe27b4e2 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277\r\n6 com.github.electron.framework \t0x00000001071bfc2e 0x106f77000 + 2395182\r\n7 com.github.electron.framework \t0x00000001071bf3ec 0x106f77000 + 2393068\r\n8 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n9 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n10 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n11 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n12 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n13 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n14 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 10:: DnsConfigService\r\n0 libsystem_kernel.dylib \t0x00007fffd2111d96 kevent + 10\r\n1 com.github.electron.framework \t0x000000010722a847 0x106f77000 + 2832455\r\n2 com.github.electron.framework \t0x00000001072299dd 0x106f77000 + 2828765\r\n3 com.github.electron.framework \t0x00000001071be9ff 0x106f77000 + 2390527\r\n4 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n5 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n6 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n7 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n9 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n10 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 11:: CrShutdownDetector\r\n0 libsystem_kernel.dylib \t0x00007fffd2112246 read + 10\r\n1 com.github.electron.framework \t0x000000010700e36f 0x106f77000 + 619375\r\n2 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n3 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n4 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n5 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 12:: TaskSchedulerServiceThread\r\n0 libsystem_kernel.dylib \t0x00007fffd2111d96 kevent + 10\r\n1 com.github.electron.framework \t0x000000010722a847 0x106f77000 + 2832455\r\n2 com.github.electron.framework \t0x00000001072299dd 0x106f77000 + 2828765\r\n3 com.github.electron.framework \t0x00000001071be9ff 0x106f77000 + 2390527\r\n4 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n5 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n6 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n7 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n9 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n10 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 13:: TaskSchedulerBackgroundWorker0\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc833 _pthread_cond_wait + 769\r\n2 com.github.electron.framework \t0x0000000107177d1b 0x106f77000 + 2100507\r\n3 com.github.electron.framework \t0x00000001072227f0 0x106f77000 + 2799600\r\n4 com.github.electron.framework \t0x0000000107222921 0x106f77000 + 2799905\r\n5 com.github.electron.framework \t0x00000001071d6a60 0x106f77000 + 2488928\r\n6 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n9 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 14:: TaskSchedulerBackgroundBlockingWorker0\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc833 _pthread_cond_wait + 769\r\n2 com.github.electron.framework \t0x0000000107177d1b 0x106f77000 + 2100507\r\n3 com.github.electron.framework \t0x00000001072227f0 0x106f77000 + 2799600\r\n4 com.github.electron.framework \t0x0000000107222921 0x106f77000 + 2799905\r\n5 com.github.electron.framework \t0x00000001071d6a60 0x106f77000 + 2488928\r\n6 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n9 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 15:: TaskSchedulerForegroundWorker0\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc833 _pthread_cond_wait + 769\r\n2 com.github.electron.framework \t0x0000000107177d1b 0x106f77000 + 2100507\r\n3 com.github.electron.framework \t0x00000001072227f0 0x106f77000 + 2799600\r\n4 com.github.electron.framework \t0x0000000107222921 0x106f77000 + 2799905\r\n5 com.github.electron.framework \t0x00000001071d6cf8 0x106f77000 + 2489592\r\n6 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n9 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 16:: TaskSchedulerForegroundBlockingWorker0\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc833 _pthread_cond_wait + 769\r\n2 com.github.electron.framework \t0x0000000107177d1b 0x106f77000 + 2100507\r\n3 com.github.electron.framework \t0x00000001072227f0 0x106f77000 + 2799600\r\n4 com.github.electron.framework \t0x0000000107222921 0x106f77000 + 2799905\r\n5 com.github.electron.framework \t0x00000001071d6a60 0x106f77000 + 2488928\r\n6 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n9 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 17:: Chrome_DBThread\r\n0 libsystem_kernel.dylib \t0x00007fffd210934a mach_msg_trap + 10\r\n1 libsystem_kernel.dylib \t0x00007fffd2108797 mach_msg + 55\r\n2 com.apple.CoreFoundation \t0x00007fffbc869434 __CFRunLoopServiceMachPort + 212\r\n3 com.apple.CoreFoundation \t0x00007fffbc8688c1 __CFRunLoopRun + 1361\r\n4 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n5 com.github.electron.framework \t0x00000001071bf94f 0x106f77000 + 2394447\r\n6 com.github.electron.framework \t0x00000001071bf3ec 0x106f77000 + 2393068\r\n7 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n8 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n9 com.github.electron.framework \t0x0000000107444f28 0x106f77000 + 5037864\r\n10 com.github.electron.framework \t0x00000001074452ef 0x106f77000 + 5038831\r\n11 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n12 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n13 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n14 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n15 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 18:: Chrome_FileThread\r\n0 libsystem_kernel.dylib \t0x00007fffd2111d96 kevent + 10\r\n1 com.github.electron.framework \t0x000000010722a847 0x106f77000 + 2832455\r\n2 com.github.electron.framework \t0x00000001072299dd 0x106f77000 + 2828765\r\n3 com.github.electron.framework \t0x00000001071be9e6 0x106f77000 + 2390502\r\n4 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n5 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n6 com.github.electron.framework \t0x0000000107444fa8 0x106f77000 + 5037992\r\n7 com.github.electron.framework \t0x00000001074452ff 0x106f77000 + 5038847\r\n8 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n9 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n10 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n11 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n12 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 19:: Chrome_FileUserBlockingThread\r\n0 libsystem_kernel.dylib \t0x00007fffd210934a mach_msg_trap + 10\r\n1 libsystem_kernel.dylib \t0x00007fffd2108797 mach_msg + 55\r\n2 com.apple.CoreFoundation \t0x00007fffbc869434 __CFRunLoopServiceMachPort + 212\r\n3 com.apple.CoreFoundation \t0x00007fffbc8688c1 __CFRunLoopRun + 1361\r\n4 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n5 com.github.electron.framework \t0x00000001071bf94f 0x106f77000 + 2394447\r\n6 com.github.electron.framework \t0x00000001071bf3ec 0x106f77000 + 2393068\r\n7 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n8 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n9 com.github.electron.framework \t0x0000000107445028 0x106f77000 + 5038120\r\n10 com.github.electron.framework \t0x000000010744530f 0x106f77000 + 5038863\r\n11 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n12 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n13 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n14 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n15 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 20:: Chrome_ProcessLauncherThread\r\n0 libsystem_kernel.dylib \t0x00007fffd210934a mach_msg_trap + 10\r\n1 libsystem_kernel.dylib \t0x00007fffd2108797 mach_msg + 55\r\n2 com.apple.CoreFoundation \t0x00007fffbc869434 __CFRunLoopServiceMachPort + 212\r\n3 com.apple.CoreFoundation \t0x00007fffbc8688c1 __CFRunLoopRun + 1361\r\n4 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n5 com.github.electron.framework \t0x00000001071bf94f 0x106f77000 + 2394447\r\n6 com.github.electron.framework \t0x00000001071bf3ec 0x106f77000 + 2393068\r\n7 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n8 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n9 com.github.electron.framework \t0x00000001074450a8 0x106f77000 + 5038248\r\n10 com.github.electron.framework \t0x000000010744531c 0x106f77000 + 5038876\r\n11 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n12 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n13 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n14 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n15 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 21:: Chrome_CacheThread\r\n0 libsystem_kernel.dylib \t0x00007fffd2112216 pwrite + 10\r\n1 com.github.electron.framework \t0x0000000107192742 0x106f77000 + 2209602\r\n2 com.github.electron.framework \t0x00000001088fd520 0x106f77000 + 26764576\r\n3 com.github.electron.framework \t0x000000010889e91c 0x106f77000 + 26376476\r\n4 com.github.electron.framework \t0x00000001088f883f 0x106f77000 + 26744895\r\n5 com.github.electron.framework \t0x00000001088f81eb 0x106f77000 + 26743275\r\n6 com.github.electron.framework \t0x00000001088f7da5 0x106f77000 + 26742181\r\n7 com.github.electron.framework \t0x00000001088f83fe 0x106f77000 + 26743806\r\n8 com.github.electron.framework \t0x0000000108988d36 0x106f77000 + 27335990\r\n9 com.github.electron.framework \t0x00000001071f2ea0 0x106f77000 + 2604704\r\n10 com.github.electron.framework \t0x00000001071bb9eb 0x106f77000 + 2378219\r\n11 com.github.electron.framework \t0x00000001071bbd3c 0x106f77000 + 2379068\r\n12 com.github.electron.framework \t0x00000001071bc103 0x106f77000 + 2380035\r\n13 com.github.electron.framework \t0x00000001071bf58a 0x106f77000 + 2393482\r\n14 com.github.electron.framework \t0x0000000107173aea 0x106f77000 + 2083562\r\n15 com.github.electron.framework \t0x00000001071befb4 0x106f77000 + 2391988\r\n16 com.apple.CoreFoundation \t0x00007fffbc888321 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17\r\n17 com.apple.CoreFoundation \t0x00007fffbc86921d __CFRunLoopDoSources0 + 557\r\n18 com.apple.CoreFoundation \t0x00007fffbc868716 __CFRunLoopRun + 934\r\n19 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n20 com.github.electron.framework \t0x00000001071bf94f 0x106f77000 + 2394447\r\n21 com.github.electron.framework \t0x00000001071bf3ec 0x106f77000 + 2393068\r\n22 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n23 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n24 com.github.electron.framework \t0x0000000107445128 0x106f77000 + 5038376\r\n25 com.github.electron.framework \t0x0000000107445329 0x106f77000 + 5038889\r\n26 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n27 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n28 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n29 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n30 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 22 Crashed:: Chrome_IOThread\r\n0 com.github.electron.framework \t0x0000000108ab4e2b 0x106f77000 + 28565035\r\n1 com.github.electron.framework \t0x000000010703d9f6 atom::URLRequestFetchJob::OnURLFetchComplete(net::URLFetcher const*) + 70\r\n2 com.github.electron.framework \t0x000000010703da60 non-virtual thunk to atom::URLRequestFetchJob::OnURLFetchComplete(net::URLFetcher const*) + 16\r\n3 com.github.electron.framework \t0x00000001071f2ea0 0x106f77000 + 2604704\r\n4 com.github.electron.framework \t0x00000001071bb9eb 0x106f77000 + 2378219\r\n5 com.github.electron.framework \t0x00000001071bbd3c 0x106f77000 + 2379068\r\n6 com.github.electron.framework \t0x00000001071bc103 0x106f77000 + 2380035\r\n7 com.github.electron.framework \t0x00000001071be925 0x106f77000 + 2390309\r\n8 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n9 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n10 com.github.electron.framework \t0x00000001074451a8 0x106f77000 + 5038504\r\n11 com.github.electron.framework \t0x0000000107445336 0x106f77000 + 5038902\r\n12 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n13 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n14 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n15 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n16 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 23:: IndexedDB\r\n0 libsystem_kernel.dylib \t0x00007fffd210934a mach_msg_trap + 10\r\n1 libsystem_kernel.dylib \t0x00007fffd2108797 mach_msg + 55\r\n2 com.apple.CoreFoundation \t0x00007fffbc869434 __CFRunLoopServiceMachPort + 212\r\n3 com.apple.CoreFoundation \t0x00007fffbc8688c1 __CFRunLoopRun + 1361\r\n4 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n5 com.github.electron.framework \t0x00000001071bf94f 0x106f77000 + 2394447\r\n6 com.github.electron.framework \t0x00000001071bf3ec 0x106f77000 + 2393068\r\n7 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n8 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n9 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n10 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n11 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n12 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n13 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 24:: CompositorTileWorker1/43779\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc7fa _pthread_cond_wait + 712\r\n2 com.github.electron.framework \t0x0000000107327a68 0x106f77000 + 3869288\r\n3 com.github.electron.framework \t0x00000001071e0a9c 0x106f77000 + 2529948\r\n4 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n5 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n6 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 25:: AudioThread\r\n0 libsystem_kernel.dylib \t0x00007fffd210934a mach_msg_trap + 10\r\n1 libsystem_kernel.dylib \t0x00007fffd2108797 mach_msg + 55\r\n2 com.apple.CoreFoundation \t0x00007fffbc869434 __CFRunLoopServiceMachPort + 212\r\n3 com.apple.CoreFoundation \t0x00007fffbc8688c1 __CFRunLoopRun + 1361\r\n4 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n5 com.github.electron.framework \t0x00000001071bf94f 0x106f77000 + 2394447\r\n6 com.github.electron.framework \t0x00000001071bf3ec 0x106f77000 + 2393068\r\n7 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n8 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n9 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n10 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n11 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n12 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n13 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 26:\r\n0 libsystem_kernel.dylib \t0x00007fffd2110eb6 __select + 10\r\n1 com.github.electron.framework \t0x000000010708f7d2 atom::NodeBindingsMac::PollEvents() + 210\r\n2 com.github.electron.framework \t0x000000010708ee8f atom::NodeBindings::EmbedThreadRunner(void*) + 63\r\n3 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n4 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n5 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 27:\r\n0 libsystem_kernel.dylib \t0x00007fffd211144e __workq_kernreturn + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fb621 _pthread_wqthread + 1426\r\n2 libsystem_pthread.dylib \t0x00007fffd21fb07d start_wqthread + 13\r\n\r\nThread 28:: BrowserBlockingWorker1/14343\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc833 _pthread_cond_wait + 769\r\n2 com.github.electron.framework \t0x0000000107177d1b 0x106f77000 + 2100507\r\n3 com.github.electron.framework \t0x00000001071dc638 0x106f77000 + 2512440\r\n4 com.github.electron.framework \t0x00000001071db526 0x106f77000 + 2508070\r\n5 com.github.electron.framework \t0x00000001071e0a9c 0x106f77000 + 2529948\r\n6 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n9 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 29:: NetworkConfigWatcher\r\n0 libsystem_kernel.dylib \t0x00007fffd210934a mach_msg_trap + 10\r\n1 libsystem_kernel.dylib \t0x00007fffd2108797 mach_msg + 55\r\n2 com.apple.CoreFoundation \t0x00007fffbc869434 __CFRunLoopServiceMachPort + 212\r\n3 com.apple.CoreFoundation \t0x00007fffbc8688c1 __CFRunLoopRun + 1361\r\n4 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n5 com.apple.Foundation \t0x00007fffbe27b4e2 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277\r\n6 com.github.electron.framework \t0x00000001071bfc2e 0x106f77000 + 2395182\r\n7 com.github.electron.framework \t0x00000001071bf3ec 0x106f77000 + 2393068\r\n8 com.github.electron.framework \t0x00000001071bb6be 0x106f77000 + 2377406\r\n9 com.github.electron.framework \t0x00000001071d52c3 0x106f77000 + 2482883\r\n10 com.github.electron.framework \t0x00000001071f5a29 0x106f77000 + 2615849\r\n11 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n12 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n13 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n14 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 30:: com.apple.NSEventThread\r\n0 libsystem_kernel.dylib \t0x00007fffd210934a mach_msg_trap + 10\r\n1 libsystem_kernel.dylib \t0x00007fffd2108797 mach_msg + 55\r\n2 com.apple.CoreFoundation \t0x00007fffbc869434 __CFRunLoopServiceMachPort + 212\r\n3 com.apple.CoreFoundation \t0x00007fffbc8688c1 __CFRunLoopRun + 1361\r\n4 com.apple.CoreFoundation \t0x00007fffbc868114 CFRunLoopRunSpecific + 420\r\n5 com.apple.AppKit \t0x00007fffba4aff02 _NSEventThread + 205\r\n6 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 31:: WorkerPool/72451\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc833 _pthread_cond_wait + 769\r\n2 com.github.electron.framework \t0x0000000107177d1b 0x106f77000 + 2100507\r\n3 com.github.electron.framework \t0x00000001072251d6 0x106f77000 + 2810326\r\n4 com.github.electron.framework \t0x0000000107225667 0x106f77000 + 2811495\r\n5 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n6 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 32:: TaskSchedulerForegroundWorker1\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc833 _pthread_cond_wait + 769\r\n2 com.github.electron.framework \t0x0000000107177d1b 0x106f77000 + 2100507\r\n3 com.github.electron.framework \t0x00000001072227f0 0x106f77000 + 2799600\r\n4 com.github.electron.framework \t0x0000000107222921 0x106f77000 + 2799905\r\n5 com.github.electron.framework \t0x00000001071d6cf8 0x106f77000 + 2489592\r\n6 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n9 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 33:: WorkerPool/14867\r\n0 libsystem_kernel.dylib \t0x00007fffd2110bf2 __psynch_cvwait + 10\r\n1 libsystem_pthread.dylib \t0x00007fffd21fc833 _pthread_cond_wait + 769\r\n2 com.github.electron.framework \t0x0000000107177d1b 0x106f77000 + 2100507\r\n3 com.github.electron.framework \t0x00000001072251d6 0x106f77000 + 2810326\r\n4 com.github.electron.framework \t0x0000000107225667 0x106f77000 + 2811495\r\n5 com.github.electron.framework \t0x00000001071c9857 0x106f77000 + 2435159\r\n6 libsystem_pthread.dylib \t0x00007fffd21fb93b _pthread_body + 180\r\n7 libsystem_pthread.dylib \t0x00007fffd21fb887 _pthread_start + 286\r\n8 libsystem_pthread.dylib \t0x00007fffd21fb08d thread_start + 13\r\n\r\nThread 22 crashed with X86 Thread State (64-bit):\r\n rax: 0x0000000000000000 rbx: 0x000070000951e518 rcx: 0x0000000000000220 rdx: 0x0000000000000000\r\n rdi: 0x0000000000000000 rsi: 0x000070000951e53c rbp: 0x000070000951e560 rsp: 0x000070000951e4a0\r\n r8: 0x0000000108ab4dcd r9: 0x0000000000000000 r10: 0x00007fffd7c352e0 r11: 0x00007ff52cd01960\r\n r12: 0x000070000951e4a8 r13: 0x000000010b157d50 r14: 0x0000000000000000 r15: 0x000070000951e518\r\n rip: 0x0000000108ab4e2b rfl: 0x0000000000010206 cr2: 0x0000000000000000\r\n \r\nLogical CPU: 1\r\nError Code: 0x00000004\r\nTrap Number: 14\r\n\r\n\r\nBinary Images:\r\n 0x106f74000 - 0x106f74ff7 +com.github.electron (1.7.0 - 1.7.0) /Users/USER/Desktop/*/Electron.app/Contents/MacOS/Electron\r\n 0x106f77000 - 0x10aec9ff3 +com.github.electron.framework (0) <81EC4A22-F2C1-3190-AC6C-1C1D2CBDDA3A> /Users/USER/Desktop/*/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework\r\n 0x10b411000 - 0x10b42bfff +com.github.Squirrel (1.0 - 1) <4C459C36-AFB6-3B8A-8FEC-76C192C17E30> /Users/USER/Desktop/*/Electron.app/Contents/Frameworks/Squirrel.framework/Versions/A/Squirrel\r\n 0x10b44c000 - 0x10b4afff7 +org.reactivecocoa.ReactiveCocoa (1.0 - 1) <701B20DE-3ADD-3643-B52A-E05744C30DB3> /Users/USER/Desktop/*/Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/A/ReactiveCocoa\r\n 0x10b521000 - 0x10b535fff +org.mantle.Mantle (1.0 - ???) <31915DD6-48E6-3706-A076-C9D4CE17F4F6> /Users/USER/Desktop/*/Electron.app/Contents/Frameworks/Mantle.framework/Versions/A/Mantle\r\n 0x10b547000 - 0x10c44dff3 +libnode.dylib (0) /Users/USER/Desktop/*/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib\r\n 0x10c6db000 - 0x10c93ffef +libffmpeg.dylib (0) /Users/USER/Desktop/*/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libffmpeg.dylib\r\n 0x10cb49000 - 0x10cb87ff7 com.apple.audio.midi.CoreMIDI (1.10 - 88) <5E2D1F53-B466-312E-AEA7-117B68C9A7F0> /System/Library/Frameworks/CoreMIDI.framework/Versions/A/CoreMIDI\r\n 0x10cbaf000 - 0x10cbc8ffb libexpat.1.dylib (15) /usr/lib/libexpat.1.dylib\r\n 0x11022d000 - 0x110244ffb libCGInterfaces.dylib (331.5) <17109679-A284-3C72-AA60-DBA815D3062B> /System/Library/Frameworks/Accelerate.framework/Frameworks/vImage.framework/Versions/A/Libraries/libCGInterfaces.dylib\r\n 0x1118b2000 - 0x1118efdc7 dyld (433.5) <322C06B7-8878-311D-888C-C8FD2CA96FF3> /usr/lib/dyld\r\n 0x11c1cb000 - 0x11c371fff GLEngine (14.0.16) <1999FBF9-0B82-34B1-8876-87B4F82101BB> /System/Library/Frameworks/OpenGL.framework/Resources/GLEngine.bundle/GLEngine\r\n 0x11c3b0000 - 0x11ce05ff7 com.apple.driver.AppleIntelSKLGraphicsGLDriver (10.25.13 - 10.2.5) <3FDB486A-E09C-3A1E-BC86-75E2FA5540BD> /System/Library/Extensions/AppleIntelSKLGraphicsGLDriver.bundle/Contents/MacOS/AppleIntelSKLGraphicsGLDriver\r\n 0x11d138000 - 0x11d162fff GLRendererFloat (14.0.16) <8D11C08E-8249-38DB-9856-BFC01EEDE0CB> /System/Library/Frameworks/OpenGL.framework/Resources/GLRendererFloat.bundle/GLRendererFloat\r\n 0x11d16c000 - 0x11d1faff7 com.apple.driver.AppleIntelSKLGraphicsMTLDriver (10.25.13 - 10.2.5) /System/Library/Extensions/AppleIntelSKLGraphicsMTLDriver.bundle/Contents/MacOS/AppleIntelSKLGraphicsMTLDriver\r\n 0x7fffb900f000 - 0x7fffb91d0fff com.apple.avfoundation (2.0 - 1187.36) <8C7813BE-B548-33E3-A61E-FF1F1984386A> /System/Library/Frameworks/AVFoundation.framework/Versions/A/AVFoundation\r\n 0x7fffb91d1000 - 0x7fffb9273ff7 com.apple.audio.AVFAudio (1.0 - ???) <7997D588-B542-3EBB-B822-D719C1114BB4> /System/Library/Frameworks/AVFoundation.framework/Versions/A/Frameworks/AVFAudio.framework/Versions/A/AVFAudio\r\n 0x7fffb933e000 - 0x7fffb933efff com.apple.Accelerate (1.11 - Accelerate 1.11) <916E360F-323C-3AE1-AB3D-D1F3B284AEE9> /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate\r\n 0x7fffb9357000 - 0x7fffb9870feb com.apple.vImage (8.1 - ???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage\r\n 0x7fffb9871000 - 0x7fffb99e2ff3 libBLAS.dylib (1185.50.4) <4087FFE0-627E-3623-96B4-F0A9A1991E09> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib\r\n 0x7fffb99e3000 - 0x7fffb99f7ffb libBNNS.dylib (15) <254698C7-7D36-3FFF-864E-ADEEEE543076> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBNNS.dylib\r\n 0x7fffb99f8000 - 0x7fffb9deefef libLAPACK.dylib (1185.50.4) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib\r\n 0x7fffb9def000 - 0x7fffb9e05fff libLinearAlgebra.dylib (1185.50.4) <345CAACF-7263-36EF-B69B-793EA8B390AF> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLinearAlgebra.dylib\r\n 0x7fffb9e06000 - 0x7fffb9e0cfff libQuadrature.dylib (3) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libQuadrature.dylib\r\n 0x7fffb9e0d000 - 0x7fffb9e21ff7 libSparseBLAS.dylib (1185.50.4) <67BA432E-FB59-3C78-A8BE-ED4274CBC359> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libSparseBLAS.dylib\r\n 0x7fffb9e22000 - 0x7fffb9fa9fe7 libvDSP.dylib (600.60.1) <4155F45B-41CD-3782-AE8F-7AE740FD83C3> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib\r\n 0x7fffb9faa000 - 0x7fffba05cfff libvMisc.dylib (600.60.1) <98F27D2D-E5DD-38EF-8747-0C4DE821A23D> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib\r\n 0x7fffba05d000 - 0x7fffba05dfff com.apple.Accelerate.vecLib (3.11 - vecLib 3.11) <7C5733E7-0568-3E7D-AF61-160F19FED544> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib\r\n 0x7fffba31c000 - 0x7fffbb0f5ff3 com.apple.AppKit (6.9 - 1504.83.101) /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit\r\n 0x7fffbb107000 - 0x7fffbb107fff com.apple.ApplicationServices (48 - 48) <4C71CBA8-47E4-38BF-BE3B-F20DF8667D5D> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices\r\n 0x7fffbb108000 - 0x7fffbb176ff7 com.apple.ApplicationServices.ATS (377 - 422.2) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS\r\n 0x7fffbb210000 - 0x7fffbb33fff7 libFontParser.dylib (194.12) <73C3946D-EF92-3AC1-89C3-0E75B2A85325> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontParser.dylib\r\n 0x7fffbb340000 - 0x7fffbb38afff libFontRegistry.dylib (196.4) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontRegistry.dylib\r\n 0x7fffbb3e7000 - 0x7fffbb41afff libTrueTypeScaler.dylib (194.12) <8944A23A-EE36-3657-9B4F-933231C8FDEC> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libTrueTypeScaler.dylib\r\n 0x7fffbb487000 - 0x7fffbb531ff7 com.apple.ColorSync (4.12.0 - 502.2) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync\r\n 0x7fffbb532000 - 0x7fffbb583fff com.apple.HIServices (1.22 - 592.1) <7353E76E-9A3A-3693-87AF-41953585E024> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices\r\n 0x7fffbb584000 - 0x7fffbb593ff3 com.apple.LangAnalysis (1.7.0 - 1.7.0) <2CBE7F61-2056-3F96-99A1-0D527796AFA6> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis\r\n 0x7fffbb594000 - 0x7fffbb5e1fff com.apple.print.framework.PrintCore (12 - 491) <5027FD58-F0EE-33E4-8577-934CA06CD2AF> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore\r\n 0x7fffbb5e2000 - 0x7fffbb61dfff com.apple.QD (3.12 - 313) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD\r\n 0x7fffbb61e000 - 0x7fffbb629fff com.apple.speech.synthesis.framework (6.6.2 - 6.6.2) <7853EFF4-62B9-394E-B7B8-41A645656820> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis\r\n 0x7fffbb62a000 - 0x7fffbb836fff com.apple.audio.toolbox.AudioToolbox (1.14 - 1.14) <91D2BA22-B168-3A9A-9008-6FFC5A8FDC1E> /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox\r\n 0x7fffbb837000 - 0x7fffbb837fff com.apple.audio.units.AudioUnit (1.14 - 1.14) <8C0153FD-FEFF-309C-AACD-BF9657A31F8E> /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit\r\n 0x7fffbb9a0000 - 0x7fffbbd7afff com.apple.CFNetwork (811.5.4 - 811.5.4) <4DBF8932-6286-3B23-87D9-63615B9958D9> /System/Library/Frameworks/CFNetwork.framework/Versions/A/CFNetwork\r\n 0x7fffbbd94000 - 0x7fffbbd94fff com.apple.Carbon (154 - 157) <69F403C7-F0CB-34E6-89B0-235CF4978C17> /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon\r\n 0x7fffbbd95000 - 0x7fffbbd98fff com.apple.CommonPanels (1.2.6 - 98) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels\r\n 0x7fffbbd99000 - 0x7fffbc0a2fff com.apple.HIToolbox (2.1.1 - 857.8) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox\r\n 0x7fffbc0a3000 - 0x7fffbc0a6ff7 com.apple.help (1.3.5 - 49) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help\r\n 0x7fffbc0a7000 - 0x7fffbc0acfff com.apple.ImageCapture (9.0 - 9.0) <341252B4-E082-361A-B756-6A330259C741> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture\r\n 0x7fffbc0ad000 - 0x7fffbc144ff3 com.apple.ink.framework (10.9 - 219) <1BD40B45-FD33-3177-A935-565EE5FC79D7> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink\r\n 0x7fffbc145000 - 0x7fffbc15ffff com.apple.openscripting (1.7 - 172) <31CFBB35-24BD-3E12-9B6B-1FA842FB605B> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting\r\n 0x7fffbc160000 - 0x7fffbc161ff3 com.apple.print.framework.Print (12 - 267) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print\r\n 0x7fffbc162000 - 0x7fffbc164ff7 com.apple.securityhi (9.0 - 55006) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI\r\n 0x7fffbc165000 - 0x7fffbc16bff7 com.apple.speech.recognition.framework (6.0.1 - 6.0.1) <082895DC-3AC7-3DEF-ADCA-5B018C19C9D3> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition\r\n 0x7fffbc24c000 - 0x7fffbc24cfff com.apple.Cocoa (6.11 - 22) <85EDFBE1-75F0-369E-8CA8-C6A639B98FA6> /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa\r\n 0x7fffbc396000 - 0x7fffbc423fff com.apple.audio.CoreAudio (4.3.0 - 4.3.0) <78767F88-91D4-31CE-AAC6-1F9407F479BB> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio\r\n 0x7fffbc424000 - 0x7fffbc437fff com.apple.CoreBluetooth (1.0 - 1) /System/Library/Frameworks/CoreBluetooth.framework/Versions/A/CoreBluetooth\r\n 0x7fffbc438000 - 0x7fffbc733fff com.apple.CoreData (120 - 754.2) <4C9CAB2C-60D4-3694-A0A0-5B04B14BD14E> /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData\r\n 0x7fffbc734000 - 0x7fffbc7e0ff7 com.apple.CoreDisplay (1.0 - 1) /System/Library/Frameworks/CoreDisplay.framework/Versions/A/CoreDisplay\r\n 0x7fffbc7e1000 - 0x7fffbcc7aff7 com.apple.CoreFoundation (6.9 - 1349.8) <09ED473E-5DE8-307F-B55C-16F6419236D5> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation\r\n 0x7fffbcc7b000 - 0x7fffbd2fdfff com.apple.CoreGraphics (2.0 - 1070.22) <78E7C882-837D-3CC3-B221-767B999873CE> /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics\r\n 0x7fffbd2fe000 - 0x7fffbd541ffb com.apple.CoreImage (12.4.0 - 451.4.9) /System/Library/Frameworks/CoreImage.framework/Versions/A/CoreImage\r\n 0x7fffbd5a8000 - 0x7fffbd659fff com.apple.CoreMedia (1.0 - 1907.59.1.5) <6CCDE81A-6992-33ED-A1D9-9D27A4C1E31F> /System/Library/Frameworks/CoreMedia.framework/Versions/A/CoreMedia\r\n 0x7fffbd65a000 - 0x7fffbd6a5ff7 com.apple.CoreMediaIO (805.0 - 4932) /System/Library/Frameworks/CoreMediaIO.framework/Versions/A/CoreMediaIO\r\n 0x7fffbd6a6000 - 0x7fffbd6a6fff com.apple.CoreServices (775.19 - 775.19) <7255917D-EFBB-3BE2-A8FD-DAD631BC0949> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices\r\n 0x7fffbd6a7000 - 0x7fffbd6f8fff com.apple.AE (712.5 - 712.5) <61F2AE2C-E04E-3FDF-9E88-201325136C83> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE\r\n 0x7fffbd6f9000 - 0x7fffbd9d4ff7 com.apple.CoreServices.CarbonCore (1159.6 - 1159.6) <08AC074C-965B-3EDF-8E45-0707C8DE9EAD> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore\r\n 0x7fffbd9d5000 - 0x7fffbda08fff com.apple.DictionaryServices (1.2 - 274) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices\r\n 0x7fffbda09000 - 0x7fffbda11ff3 com.apple.CoreServices.FSEvents (1230.50.1 - 1230.50.1) <2AD1B0E5-7214-37C4-8D11-A27C9CAC0F74> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents\r\n 0x7fffbda12000 - 0x7fffbdb7eff7 com.apple.LaunchServices (775.19 - 775.19) <94D15A2A-852C-3B4B-A701-43043C8F1527> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices\r\n 0x7fffbdb7f000 - 0x7fffbdc2fffb com.apple.Metadata (10.7.0 - 1075.40) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata\r\n 0x7fffbdc30000 - 0x7fffbdc8ffff com.apple.CoreServices.OSServices (775.19 - 775.19) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices\r\n 0x7fffbdc90000 - 0x7fffbdd00fff com.apple.SearchKit (1.4.0 - 1.4.0) <7A6DDA2B-03F1-3137-BA9E-1CC211973E26> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit\r\n 0x7fffbdd01000 - 0x7fffbdd46ff7 com.apple.coreservices.SharedFileList (38 - 38) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList\r\n 0x7fffbddcf000 - 0x7fffbdf1cffb com.apple.CoreText (352.0 - 544.15) /System/Library/Frameworks/CoreText.framework/Versions/A/CoreText\r\n 0x7fffbdf1d000 - 0x7fffbdf52ff3 com.apple.CoreVideo (1.8 - 235.3) /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo\r\n 0x7fffbdf53000 - 0x7fffbdfc4ffb com.apple.framework.CoreWLAN (11.0 - 1200.31) /System/Library/Frameworks/CoreWLAN.framework/Versions/A/CoreWLAN\r\n 0x7fffbe0c2000 - 0x7fffbe0c7fff com.apple.DiskArbitration (2.7 - 2.7) <8AC72143-D3C4-3AA6-84DF-734E3AFAC49B> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration\r\n 0x7fffbe259000 - 0x7fffbe5ffff3 com.apple.Foundation (6.9 - 1349.81) <730B7944-BB43-35D5-A546-9F6CCED4B9F3> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation\r\n 0x7fffbe62b000 - 0x7fffbe65cff7 com.apple.GSS (4.0 - 2.0) <6FADED0B-0425-3567-A75A-040C5A4638EB> /System/Library/Frameworks/GSS.framework/Versions/A/GSS\r\n 0x7fffbe65d000 - 0x7fffbe675ff7 com.apple.GameController (1.0 - 1) /System/Library/Frameworks/GameController.framework/Versions/A/GameController\r\n 0x7fffbe71c000 - 0x7fffbe7bfffb com.apple.Bluetooth (5.0.4 - 5.0.4f18) /System/Library/Frameworks/IOBluetooth.framework/Versions/A/IOBluetooth\r\n 0x7fffbe7c0000 - 0x7fffbe856ff7 com.apple.framework.IOKit (2.0.2 - 1324.60.3) <7CE4C98B-107C-3AAA-B49A-F2ACFCBBF526> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit\r\n 0x7fffbe857000 - 0x7fffbe85dffb com.apple.IOSurface (159.7 - 159.7) <40550017-EF96-3C52-B400-806AFEE4B134> /System/Library/Frameworks/IOSurface.framework/Versions/A/IOSurface\r\n 0x7fffbe85e000 - 0x7fffbe8afff7 com.apple.ImageCaptureCore (7.0 - 7.0) /System/Library/Frameworks/ImageCaptureCore.framework/Versions/A/ImageCaptureCore\r\n 0x7fffbe8b0000 - 0x7fffbea10fef com.apple.ImageIO.framework (3.3.0 - 1599.10.2) <87AA4D39-0AFC-3A34-98EF-02710E2BF3CA> /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO\r\n 0x7fffbea11000 - 0x7fffbea15fff libGIF.dylib (1599.10.2) <6ED05614-1301-3452-943B-118F00F20C8D> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib\r\n 0x7fffbea16000 - 0x7fffbeb06ff7 libJP2.dylib (1599.10.2) <72C00423-55F0-3CAD-B198-EF00950791E6> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libJP2.dylib\r\n 0x7fffbeb07000 - 0x7fffbeb2affb libJPEG.dylib (1599.10.2) <78945614-990F-3705-A91C-46F717F7C635> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib\r\n 0x7fffbeb2b000 - 0x7fffbeb52ff7 libPng.dylib (1599.10.2) /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib\r\n 0x7fffbeb53000 - 0x7fffbeb55ff3 libRadiance.dylib (1599.10.2) <037D95B4-82A7-3A59-B3EB-0FF0977CF7A5> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib\r\n 0x7fffbeb56000 - 0x7fffbeba4fff libTIFF.dylib (1599.10.2) /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib\r\n 0x7fffbed02000 - 0x7fffbf90aff3 com.apple.JavaScriptCore (12603 - 12603.2.4) /System/Library/Frameworks/JavaScriptCore.framework/Versions/A/JavaScriptCore\r\n 0x7fffbf90b000 - 0x7fffbf924ff7 com.apple.Kerberos (3.0 - 1) /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos\r\n 0x7fffbfbad000 - 0x7fffbfbb3fff com.apple.MediaAccessibility (1.0 - 97.1.1) <0BD82735-6644-37CE-B13D-8E7CC59A1752> /System/Library/Frameworks/MediaAccessibility.framework/Versions/A/MediaAccessibility\r\n 0x7fffbfbc9000 - 0x7fffc0102ff7 com.apple.MediaToolbox (1.0 - 1907.59.1.5) <2024A2A2-50B6-36AA-BC6D-3AAFA78EB707> /System/Library/Frameworks/MediaToolbox.framework/Versions/A/MediaToolbox\r\n 0x7fffc0103000 - 0x7fffc015efff com.apple.Metal (87.18 - 87.18) <5C2F12FB-45C1-3103-A827-3D225BF8D05A> /System/Library/Frameworks/Metal.framework/Versions/A/Metal\r\n 0x7fffc0a47000 - 0x7fffc0a4ffff com.apple.NetFS (6.0 - 4.0) <14A24D00-5673-330A-959D-87F72040DEFF> /System/Library/Frameworks/NetFS.framework/Versions/A/NetFS\r\n 0x7fffc0c26000 - 0x7fffc0c2eff7 libcldcpuengine.dylib (2.8.5) <73E1E526-01DF-3199-9B48-155F0329EF44> /System/Library/Frameworks/OpenCL.framework/Versions/A/Libraries/libcldcpuengine.dylib\r\n 0x7fffc0c2f000 - 0x7fffc0c7dff3 com.apple.opencl (2.8.6 - 2.8.6) <5FAF6F49-2648-39E6-922B-5630A5D7F7E4> /System/Library/Frameworks/OpenCL.framework/Versions/A/OpenCL\r\n 0x7fffc0c7e000 - 0x7fffc0c97ffb com.apple.CFOpenDirectory (10.12 - 194) /System/Library/Frameworks/OpenDirectory.framework/Versions/A/Frameworks/CFOpenDirectory.framework/Versions/A/CFOpenDirectory\r\n 0x7fffc0c98000 - 0x7fffc0ca3ff7 com.apple.OpenDirectory (10.12 - 194) <4298FFD0-B1A7-3064-AF5B-708B3FA38671> /System/Library/Frameworks/OpenDirectory.framework/Versions/A/OpenDirectory\r\n 0x7fffc0ca4000 - 0x7fffc0ca6fff libCVMSPluginSupport.dylib (14.0.16) /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCVMSPluginSupport.dylib\r\n 0x7fffc0ca7000 - 0x7fffc0caaff7 libCoreFSCache.dylib (156.3) <687C4CC3-6537-344B-8BE1-5234C8CB2864> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCoreFSCache.dylib\r\n 0x7fffc0cab000 - 0x7fffc0caffff libCoreVMClient.dylib (156.3) /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCoreVMClient.dylib\r\n 0x7fffc0cb0000 - 0x7fffc0cb9ff7 libGFXShared.dylib (14.0.16) <63542E68-EB1A-3ECF-AAFB-E7B8AB313C70> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGFXShared.dylib\r\n 0x7fffc0cba000 - 0x7fffc0cc5fff libGL.dylib (14.0.16) <84BEED97-0A93-356D-A922-97EA311EA446> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib\r\n 0x7fffc0cc6000 - 0x7fffc0d02ff7 libGLImage.dylib (14.0.16) <3518A85C-6905-3511-A6C9-2F82C519D28F> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib\r\n 0x7fffc0d03000 - 0x7fffc0e79ff3 libGLProgrammability.dylib (14.0.16) <0EDA89D8-7C28-3D53-BDBA-7CB25232C329> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLProgrammability.dylib\r\n 0x7fffc0e7a000 - 0x7fffc0ebbff7 libGLU.dylib (14.0.16) <9860DCF7-56E0-3A8F-A377-52635C9D8B27> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib\r\n 0x7fffc1823000 - 0x7fffc1831fff com.apple.opengl (14.0.16 - 14.0.16) <27E7D76E-A26B-39F8-8CF2-AB57920776A3> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL\r\n 0x7fffc18ce000 - 0x7fffc1a15fff com.apple.QTKit (7.7.3 - 2978.7) <49F88771-52FE-3989-AAB7-10A7494C4419> /System/Library/Frameworks/QTKit.framework/Versions/A/QTKit\r\n 0x7fffc1a16000 - 0x7fffc1c80ff7 com.apple.imageKit (3.0 - 1023) <9C547565-CBAA-3ACB-A3F6-1366A0DCDCB4> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/ImageKit.framework/Versions/A/ImageKit\r\n 0x7fffc1c81000 - 0x7fffc1d48fff com.apple.PDFKit (1.0 - 1) /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/PDFKit.framework/Versions/A/PDFKit\r\n 0x7fffc1d49000 - 0x7fffc226fff7 com.apple.QuartzComposer (5.1 - 356) /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzComposer.framework/Versions/A/QuartzComposer\r\n 0x7fffc2270000 - 0x7fffc2293ffb com.apple.quartzfilters (1.10.0 - 1.10.0) <365342ED-7A1A-3C75-AE60-90764E96034C> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzFilters.framework/Versions/A/QuartzFilters\r\n 0x7fffc2294000 - 0x7fffc2381fff com.apple.QuickLookUIFramework (5.0 - 720.7) <3136C23E-399E-3296-928A-B18EC9FC423C> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuickLookUI.framework/Versions/A/QuickLookUI\r\n 0x7fffc2382000 - 0x7fffc2382fff com.apple.quartzframework (1.5 - 21) <09455972-8A33-3D61-B193-BA7E7CF984CA> /System/Library/Frameworks/Quartz.framework/Versions/A/Quartz\r\n 0x7fffc2383000 - 0x7fffc2583fff com.apple.QuartzCore (1.11 - 453.39.3) /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore\r\n 0x7fffc2584000 - 0x7fffc25d9fff com.apple.QuickLookFramework (5.0 - 720.7) <3BD7BA2F-924C-3EFF-B26E-3F930E62E6B4> /System/Library/Frameworks/QuickLook.framework/Versions/A/QuickLook\r\n 0x7fffc25da000 - 0x7fffc25effff com.apple.SafariServices.framework (12603 - 12603.2.4) /System/Library/Frameworks/SafariServices.framework/Versions/A/SafariServices\r\n 0x7fffc2aea000 - 0x7fffc2decff7 com.apple.security (7.0 - 57740.60.18) <021AACF6-D15F-37E0-840B-88853684BA00> /System/Library/Frameworks/Security.framework/Versions/A/Security\r\n 0x7fffc2ded000 - 0x7fffc2e62fff com.apple.securityfoundation (6.0 - 55132.50.7) <4433C0CC-FE90-3DD3-BAC1-CC31D515B510> /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation\r\n 0x7fffc2e63000 - 0x7fffc2e8cfff com.apple.securityinterface (10.0 - 55079.50.4) <50E3EAA8-1AF0-3910-AAFD-57D93D958DFF> /System/Library/Frameworks/SecurityInterface.framework/Versions/A/SecurityInterface\r\n 0x7fffc2e8d000 - 0x7fffc2e90ff3 com.apple.xpc.ServiceManagement (1.0 - 1) <9F285B19-B53B-3502-85A2-72C26DB40EA7> /System/Library/Frameworks/ServiceManagement.framework/Versions/A/ServiceManagement\r\n 0x7fffc3217000 - 0x7fffc3286ff7 com.apple.SystemConfiguration (1.14 - 1.14) <2412CDE0-C317-31EA-8F53-7A58BBFCC720> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration\r\n 0x7fffc3287000 - 0x7fffc3635fff com.apple.VideoToolbox (1.0 - 1907.59.1.5) <75E2F901-572F-3FC8-A599-96A085EEBC88> /System/Library/Frameworks/VideoToolbox.framework/Versions/A/VideoToolbox\r\n 0x7fffc5adb000 - 0x7fffc5af6ff3 com.apple.AppContainer (4.0 - 307.50.21) /System/Library/PrivateFrameworks/AppContainer.framework/Versions/A/AppContainer\r\n 0x7fffc5af7000 - 0x7fffc5b04ff3 com.apple.AppSandbox (4.0 - 307.50.21) /System/Library/PrivateFrameworks/AppSandbox.framework/Versions/A/AppSandbox\r\n 0x7fffc5b05000 - 0x7fffc5b27ffb com.apple.framework.Apple80211 (12.0 - 1200.47) /System/Library/PrivateFrameworks/Apple80211.framework/Versions/A/Apple80211\r\n 0x7fffc5b28000 - 0x7fffc5b37feb com.apple.AppleFSCompression (88.50.3 - 1.0) <478E8BFF-8BA2-375E-BE02-BA27F115C15A> /System/Library/PrivateFrameworks/AppleFSCompression.framework/Versions/A/AppleFSCompression\r\n 0x7fffc5c2b000 - 0x7fffc5cb697f com.apple.AppleJPEG (1.0 - 1) /System/Library/PrivateFrameworks/AppleJPEG.framework/Versions/A/AppleJPEG\r\n 0x7fffc5cef000 - 0x7fffc5cf2ff3 com.apple.AppleSystemInfo (3.1.5 - 3.1.5) <42A1731A-A576-307A-B07C-9F8F64696CB7> /System/Library/PrivateFrameworks/AppleSystemInfo.framework/Versions/A/AppleSystemInfo\r\n 0x7fffc5cf3000 - 0x7fffc5d45fff com.apple.AppleVAFramework (5.0.36 - 5.0.36) <7352078D-C230-397C-81A5-57A48CF218C0> /System/Library/PrivateFrameworks/AppleVA.framework/Versions/A/AppleVA\r\n 0x7fffc60e9000 - 0x7fffc6167ff7 com.apple.backup.framework (1.8.5 - 1.8.5) /System/Library/PrivateFrameworks/Backup.framework/Versions/A/Backup\r\n 0x7fffc6df2000 - 0x7fffc6e19ff3 com.apple.ChunkingLibrary (173 - 173) /System/Library/PrivateFrameworks/ChunkingLibrary.framework/Versions/A/ChunkingLibrary\r\n 0x7fffc773e000 - 0x7fffc7747ffb com.apple.CommonAuth (4.0 - 2.0) <216950CB-269F-3476-BA17-D6363AC49FBC> /System/Library/PrivateFrameworks/CommonAuth.framework/Versions/A/CommonAuth\r\n 0x7fffc78cb000 - 0x7fffc7caaff7 com.apple.CoreAUC (226.0.0 - 226.0.0) /System/Library/PrivateFrameworks/CoreAUC.framework/Versions/A/CoreAUC\r\n 0x7fffc7cab000 - 0x7fffc7cdbfff com.apple.CoreAVCHD (5.9.0 - 5900.4.1) <3F6857D1-AE7C-3593-B064-930F5BB7269E> /System/Library/PrivateFrameworks/CoreAVCHD.framework/Versions/A/CoreAVCHD\r\n 0x7fffc7e8f000 - 0x7fffc7e9ffff com.apple.CoreEmoji (1.0 - 40.3.3) /System/Library/PrivateFrameworks/CoreEmoji.framework/Versions/A/CoreEmoji\r\n 0x7fffc7f64000 - 0x7fffc7f7aff3 com.apple.CoreMediaAuthoring (2.2 - 956) /System/Library/PrivateFrameworks/CoreMediaAuthoring.framework/Versions/A/CoreMediaAuthoring\r\n 0x7fffc7f81000 - 0x7fffc8011ffb com.apple.CorePDF (4.0 - 4) <7F50E4A6-940C-33F5-BE4E-7E01AFE98A8F> /System/Library/PrivateFrameworks/CorePDF.framework/Versions/A/CorePDF\r\n 0x7fffc81da000 - 0x7fffc820aff3 com.apple.CoreServicesInternal (276.2 - 276.2) <05EB7D45-DD4C-3A0F-AC63-A0C2A68E6481> /System/Library/PrivateFrameworks/CoreServicesInternal.framework/Versions/A/CoreServicesInternal\r\n 0x7fffc849b000 - 0x7fffc852aff7 com.apple.CoreSymbolication (62046) <7839CD8E-011D-3567-88DE-3D472C661136> /System/Library/PrivateFrameworks/CoreSymbolication.framework/Versions/A/CoreSymbolication\r\n 0x7fffc852b000 - 0x7fffc866afe7 com.apple.coreui (2.1 - 431.3) <2E8FEC10-FC5B-3782-92DA-A85C24B7BF7C> /System/Library/PrivateFrameworks/CoreUI.framework/Versions/A/CoreUI\r\n 0x7fffc866b000 - 0x7fffc873bff3 com.apple.CoreUtils (5.1 - 510.31) /System/Library/PrivateFrameworks/CoreUtils.framework/Versions/A/CoreUtils\r\n 0x7fffc878b000 - 0x7fffc87f0ff3 com.apple.framework.CoreWiFi (12.0 - 1200.31) /System/Library/PrivateFrameworks/CoreWiFi.framework/Versions/A/CoreWiFi\r\n 0x7fffc87f1000 - 0x7fffc87ffff7 com.apple.CrashReporterSupport (10.12 - 827) <14037A71-ECFE-394A-8D6E-2CECE98F02EE> /System/Library/PrivateFrameworks/CrashReporterSupport.framework/Versions/A/CrashReporterSupport\r\n 0x7fffc8871000 - 0x7fffc887bffb com.apple.framework.DFRFoundation (1.0 - 104.25) <7CFF896C-EF22-3941-BB3D-F3615CE4C908> /System/Library/PrivateFrameworks/DFRFoundation.framework/Versions/A/DFRFoundation\r\n 0x7fffc887c000 - 0x7fffc8880ff3 com.apple.DSExternalDisplay (3.1 - 380) /System/Library/PrivateFrameworks/DSExternalDisplay.framework/Versions/A/DSExternalDisplay\r\n 0x7fffc88b6000 - 0x7fffc892bffb com.apple.datadetectorscore (7.0 - 539.1) <9C312AAC-8AEE-3C72-BDE5-7FBF62452525> /System/Library/PrivateFrameworks/DataDetectorsCore.framework/Versions/A/DataDetectorsCore\r\n 0x7fffc8967000 - 0x7fffc89a6fff com.apple.DebugSymbols (137 - 137) <58A70B66-2628-3CFE-B103-2200D95FC5F7> /System/Library/PrivateFrameworks/DebugSymbols.framework/Versions/A/DebugSymbols\r\n 0x7fffc89a7000 - 0x7fffc8ab8fff com.apple.desktopservices (1.11.5 - 1.11.5) <46A9D4F3-1EF8-373C-98A4-AD48D285E484> /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv\r\n 0x7fffc8bfb000 - 0x7fffc8c06fff com.apple.DisplayServicesFW (3.1 - 380) <83BB7C77-F18D-382D-9023-26132D925F75> /System/Library/PrivateFrameworks/DisplayServices.framework/Versions/A/DisplayServices\r\n 0x7fffc8da0000 - 0x7fffc91d1ff7 com.apple.vision.FaceCore (3.3.2 - 3.3.2) <9391D5A3-738C-3136-9D07-518CB43DBADA> /System/Library/PrivateFrameworks/FaceCore.framework/Versions/A/FaceCore\r\n 0x7fffca528000 - 0x7fffca528fff libmetal_timestamp.dylib (600.0.49.9) /System/Library/PrivateFrameworks/GPUCompiler.framework/libmetal_timestamp.dylib\r\n 0x7fffca535000 - 0x7fffca540ff3 libGPUSupportMercury.dylib (14.0.16) <7E99C736-2F48-313E-BEF6-6F8BABFADD9F> /System/Library/PrivateFrameworks/GPUSupport.framework/Versions/A/Libraries/libGPUSupportMercury.dylib\r\n 0x7fffca7f9000 - 0x7fffca815fff com.apple.GenerationalStorage (2.0 - 267.1) <3DE1C580-D089-362D-8582-8DE68A3C5F13> /System/Library/PrivateFrameworks/GenerationalStorage.framework/Versions/A/GenerationalStorage\r\n 0x7fffcaf26000 - 0x7fffcaf9cff3 com.apple.Heimdal (4.0 - 2.0) <8F9C9041-66D5-36C9-8A4C-1658035C311D> /System/Library/PrivateFrameworks/Heimdal.framework/Versions/A/Heimdal\r\n 0x7fffcb5b7000 - 0x7fffcb5beffb com.apple.IOAccelerator (311.13 - 311.13) <40C04C41-A76A-3687-8D64-F76E8C46AA81> /System/Library/PrivateFrameworks/IOAccelerator.framework/Versions/A/IOAccelerator\r\n 0x7fffcb5c0000 - 0x7fffcb5d4ff7 com.apple.IOPresentment (1.0 - 29.10) /System/Library/PrivateFrameworks/IOPresentment.framework/Versions/A/IOPresentment\r\n 0x7fffcb5d5000 - 0x7fffcb5f7fff com.apple.IconServices (74.4 - 74.4) <218DDD05-35F4-3833-B98D-471ED0EBC031> /System/Library/PrivateFrameworks/IconServices.framework/Versions/A/IconServices\r\n 0x7fffcb693000 - 0x7fffcb6a3ff3 com.apple.IntlPreferences (2.0 - 216) <47681AE8-4539-3525-890C-206B301CEC77> /System/Library/PrivateFrameworks/IntlPreferences.framework/Versions/A/IntlPreferences\r\n 0x7fffcb6de000 - 0x7fffcb895fff com.apple.LanguageModeling (1.0 - 123.2.5) /System/Library/PrivateFrameworks/LanguageModeling.framework/Versions/A/LanguageModeling\r\n 0x7fffcbf05000 - 0x7fffcbf08fff com.apple.Mangrove (1.0 - 1) <98814966-FD65-302B-B47E-00928DC34E5C> /System/Library/PrivateFrameworks/Mangrove.framework/Versions/A/Mangrove\r\n 0x7fffcc1b6000 - 0x7fffcc22fff7 com.apple.MetalPerformanceShaders.MetalPerformanceShaders (1.0 - 1) /System/Library/PrivateFrameworks/MetalPerformanceShaders.framework/Versions/A/MetalPerformanceShaders\r\n 0x7fffcc38b000 - 0x7fffcc398ff3 com.apple.MobileKeyBag (2.0 - 1.0) /System/Library/PrivateFrameworks/MobileKeyBag.framework/Versions/A/MobileKeyBag\r\n 0x7fffcc3a9000 - 0x7fffcc3d1ff7 com.apple.MultitouchSupport.framework (368.16 - 368.16) <512ADEC6-D694-3D73-A48A-6BE79CD39539> /System/Library/PrivateFrameworks/MultitouchSupport.framework/Versions/A/MultitouchSupport\r\n 0x7fffcc483000 - 0x7fffcc48efff com.apple.NetAuth (6.2 - 6.2) <97F487D6-8089-31A8-B68C-6C1EAC6ED1B5> /System/Library/PrivateFrameworks/NetAuth.framework/Versions/A/NetAuth\r\n 0x7fffccd66000 - 0x7fffccda7ff3 com.apple.PerformanceAnalysis (1.148.3 - 148.3) <6A21AB41-3AAA-32F3-9D46-2555A143A8B9> /System/Library/PrivateFrameworks/PerformanceAnalysis.framework/Versions/A/PerformanceAnalysis\r\n 0x7fffcd48f000 - 0x7fffcd4a9fff com.apple.ProtocolBuffer (1 - 249.1) /System/Library/PrivateFrameworks/ProtocolBuffer.framework/Versions/A/ProtocolBuffer\r\n 0x7fffcd4aa000 - 0x7fffcd4b9ff7 com.apple.QuickLookThumbnailing (1.0 - 1) <173EE873-1700-3FCA-9782-C060FBB5BCAD> /System/Library/PrivateFrameworks/QuickLookThumbnailing.framework/Versions/A/QuickLookThumbnailing\r\n 0x7fffcd4c2000 - 0x7fffcd4e5ff3 com.apple.RemoteViewServices (2.0 - 124) <6B967FDA-6591-302C-BA0A-76C4856E584E> /System/Library/PrivateFrameworks/RemoteViewServices.framework/Versions/A/RemoteViewServices\r\n 0x7fffce1ac000 - 0x7fffce1affff com.apple.SecCodeWrapper (4.0 - 307.50.21) /System/Library/PrivateFrameworks/SecCodeWrapper.framework/Versions/A/SecCodeWrapper\r\n 0x7fffce23e000 - 0x7fffce2cbfff com.apple.Sharing (696.2.67 - 696.2.67) /System/Library/PrivateFrameworks/Sharing.framework/Versions/A/Sharing\r\n 0x7fffce2ec000 - 0x7fffce552fef com.apple.SkyLight (1.600.0 - 170.3) <83AB220F-48C0-3063-8ED3-ACDB69243B4D> /System/Library/PrivateFrameworks/SkyLight.framework/Versions/A/SkyLight\r\n 0x7fffce731000 - 0x7fffce73dff7 com.apple.SpeechRecognitionCore (3.3.2 - 3.3.2) <684BD1EA-8268-331C-A5A9-080EB375C658> /System/Library/PrivateFrameworks/SpeechRecognitionCore.framework/Versions/A/SpeechRecognitionCore\r\n 0x7fffcee29000 - 0x7fffcee9dfdf com.apple.Symbolication (62048.1) <1A30ED19-7532-3F46-9DD3-9879A973D0CF> /System/Library/PrivateFrameworks/Symbolication.framework/Versions/A/Symbolication\r\n 0x7fffcf2dc000 - 0x7fffcf2e2ff7 com.apple.TCC (1.0 - 1) <911B534B-4AC7-34E4-935E-E42ECD008CBC> /System/Library/PrivateFrameworks/TCC.framework/Versions/A/TCC\r\n 0x7fffcf36e000 - 0x7fffcf434ff7 com.apple.TextureIO (2.8 - 2.8) <3D61E533-4156-3B21-B7ED-CB823E680DFC> /System/Library/PrivateFrameworks/TextureIO.framework/Versions/A/TextureIO\r\n 0x7fffcf4a8000 - 0x7fffcf4a9fff com.apple.TrustEvaluationAgent (2.0 - 28.50.1) /System/Library/PrivateFrameworks/TrustEvaluationAgent.framework/Versions/A/TrustEvaluationAgent\r\n 0x7fffcf4aa000 - 0x7fffcf63aff3 com.apple.UIFoundation (1.0 - 490.7) <2A3063FE-1790-3510-8A0E-AEC581D42B7E> /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation\r\n 0x7fffd0109000 - 0x7fffd01c9fff com.apple.ViewBridge (283 - 283) <25A635B3-C87C-3D3A-ADF3-539713FA1048> /System/Library/PrivateFrameworks/ViewBridge.framework/Versions/A/ViewBridge\r\n 0x7fffd0614000 - 0x7fffd061afff com.apple.XPCService (2.0 - 1) <4B28B225-2105-33F4-9ED0-F04288FF4FB1> /System/Library/PrivateFrameworks/XPCService.framework/Versions/A/XPCService\r\n 0x7fffd06eb000 - 0x7fffd06edffb com.apple.loginsupport (1.0 - 1) /System/Library/PrivateFrameworks/login.framework/Versions/A/Frameworks/loginsupport.framework/Versions/A/loginsupport\r\n 0x7fffd0742000 - 0x7fffd075dff7 libCRFSuite.dylib (34) /usr/lib/libCRFSuite.dylib\r\n 0x7fffd075e000 - 0x7fffd0769fff libChineseTokenizer.dylib (21) <0886E908-A825-36AF-B94B-2361FD8BC2A1> /usr/lib/libChineseTokenizer.dylib\r\n 0x7fffd07fb000 - 0x7fffd07fcff3 libDiagnosticMessagesClient.dylib (102) <84A04D24-0E60-3810-A8C0-90A65E2DF61A> /usr/lib/libDiagnosticMessagesClient.dylib\r\n 0x7fffd07fd000 - 0x7fffd0a10fff libFosl_dynamic.dylib (16.39) /usr/lib/libFosl_dynamic.dylib\r\n 0x7fffd0a2c000 - 0x7fffd0a33fff libMatch.1.dylib (27) <70D4BD2A-9383-37F2-B0D6-9B592D236601> /usr/lib/libMatch.1.dylib\r\n 0x7fffd0a34000 - 0x7fffd0a34fff libOpenScriptingUtil.dylib (172) <90743888-C1E8-34E3-924E-1A754B2B63B9> /usr/lib/libOpenScriptingUtil.dylib\r\n 0x7fffd0a35000 - 0x7fffd0a39ffb libScreenReader.dylib (477.40.6) /usr/lib/libScreenReader.dylib\r\n 0x7fffd0a3a000 - 0x7fffd0a3bffb libSystem.B.dylib (1238.60.2) /usr/lib/libSystem.B.dylib\r\n 0x7fffd0aa7000 - 0x7fffd0ad2ff3 libarchive.2.dylib (41.50.2) /usr/lib/libarchive.2.dylib\r\n 0x7fffd0ad3000 - 0x7fffd0b4ffc7 libate.dylib (1.12.13) /usr/lib/libate.dylib\r\n 0x7fffd0b53000 - 0x7fffd0b53ff3 libauto.dylib (187) <34388D0B-C539-3C1B-9408-2BC152162E43> /usr/lib/libauto.dylib\r\n 0x7fffd0b54000 - 0x7fffd0b64ff3 libbsm.0.dylib (34) <20084796-B04D-3B35-A003-EA11459557A9> /usr/lib/libbsm.0.dylib\r\n 0x7fffd0b65000 - 0x7fffd0b73ff7 libbz2.1.0.dylib (38) /usr/lib/libbz2.1.0.dylib\r\n 0x7fffd0b74000 - 0x7fffd0bcaff7 libc++.1.dylib (307.5) <0B43BB5D-E6EB-3464-8DE9-B41AC8ED9D1C> /usr/lib/libc++.1.dylib\r\n 0x7fffd0bcb000 - 0x7fffd0bf5fff libc++abi.dylib (307.3) <30199352-88BF-30BD-8CFF-2A4FBE247523> /usr/lib/libc++abi.dylib\r\n 0x7fffd0bf6000 - 0x7fffd0c06ffb libcmph.dylib (6) <2B5D405E-2D0B-3320-ABD6-622934C86ABE> /usr/lib/libcmph.dylib\r\n 0x7fffd0c07000 - 0x7fffd0c1dfcf libcompression.dylib (39) /usr/lib/libcompression.dylib\r\n 0x7fffd0c1e000 - 0x7fffd0c1eff7 libcoretls.dylib (121.50.4) <64B1001E-10F6-3542-A3B2-C4B49F51817F> /usr/lib/libcoretls.dylib\r\n 0x7fffd0c1f000 - 0x7fffd0c20ff3 libcoretls_cfhelpers.dylib (121.50.4) <1A10303E-5EB0-3C7C-9165-021FCDFD934D> /usr/lib/libcoretls_cfhelpers.dylib\r\n 0x7fffd0cda000 - 0x7fffd0dbfff7 libcrypto.0.9.8.dylib (64.50.6) /usr/lib/libcrypto.0.9.8.dylib\r\n 0x7fffd0f5d000 - 0x7fffd0fb0ff7 libcups.2.dylib (450) <9950BFCB-7882-33C9-9ECF-CE66773C5657> /usr/lib/libcups.2.dylib\r\n 0x7fffd1002000 - 0x7fffd1009ff3 libdscsym.dylib (148.3) <63492BDA-33A8-31DE-90E8-A3D44F07EB9C> /usr/lib/libdscsym.dylib\r\n 0x7fffd102b000 - 0x7fffd102bfff libenergytrace.dylib (15) /usr/lib/libenergytrace.dylib\r\n 0x7fffd103b000 - 0x7fffd1040ff7 libheimdal-asn1.dylib (498.50.8) /usr/lib/libheimdal-asn1.dylib\r\n 0x7fffd1041000 - 0x7fffd1133ff7 libiconv.2.dylib (50) <42125B35-81D7-3FC4-9475-A26DBE10884D> /usr/lib/libiconv.2.dylib\r\n 0x7fffd1134000 - 0x7fffd1359ffb libicucore.A.dylib (57165.0.1) <2931B842-2946-3576-AD1D-1CDA22FA1388> /usr/lib/libicucore.A.dylib\r\n 0x7fffd135f000 - 0x7fffd1360fff liblangid.dylib (126) <2085E7A7-9A34-3735-87F4-F174EF8EABF0> /usr/lib/liblangid.dylib\r\n 0x7fffd1361000 - 0x7fffd137affb liblzma.5.dylib (10) <44BD0279-99DD-36B5-8A6E-C11432E2098D> /usr/lib/liblzma.5.dylib\r\n 0x7fffd137b000 - 0x7fffd1391ff7 libmarisa.dylib (5) <9030D214-5D0F-30CB-AC03-902C63909362> /usr/lib/libmarisa.dylib\r\n 0x7fffd1392000 - 0x7fffd163aff7 libmecabra.dylib (744.8) /usr/lib/libmecabra.dylib\r\n 0x7fffd166d000 - 0x7fffd16e7ff3 libnetwork.dylib (856.60.1) <191E99F5-4723-3180-8013-02AF2F9AE4B8> /usr/lib/libnetwork.dylib\r\n 0x7fffd16e8000 - 0x7fffd1aba047 libobjc.A.dylib (709) /usr/lib/libobjc.A.dylib\r\n 0x7fffd1abd000 - 0x7fffd1ac1fff libpam.2.dylib (21.30.1) <71EB0D88-DE84-3C8D-A2C5-58AA282BC5BC> /usr/lib/libpam.2.dylib\r\n 0x7fffd1ac2000 - 0x7fffd1af3fff libpcap.A.dylib (67.60.1) /usr/lib/libpcap.A.dylib\r\n 0x7fffd1b10000 - 0x7fffd1b2cffb libresolv.9.dylib (64) /usr/lib/libresolv.9.dylib\r\n 0x7fffd1b2d000 - 0x7fffd1b66fff libsandbox.1.dylib (592.60.1) /usr/lib/libsandbox.1.dylib\r\n 0x7fffd1b7a000 - 0x7fffd1b7bff3 libspindump.dylib (231.3) /usr/lib/libspindump.dylib\r\n 0x7fffd1b7c000 - 0x7fffd1cc9ff7 libsqlite3.dylib (254.7) <07CD6DE3-394D-3C6A-A4B4-4CAB1054A041> /usr/lib/libsqlite3.dylib\r\n 0x7fffd1dbe000 - 0x7fffd1dcbfff libxar.1.dylib (357) <69547C64-E811-326F-BBED-490C6361BDCB> /usr/lib/libxar.1.dylib\r\n 0x7fffd1dcc000 - 0x7fffd1ebbffb libxml2.2.dylib (30.16) /usr/lib/libxml2.2.dylib\r\n 0x7fffd1ebc000 - 0x7fffd1ee5fff libxslt.1.dylib (15.9) <00735AD5-B62D-3E83-86AC-5533E4E2B102> /usr/lib/libxslt.1.dylib\r\n 0x7fffd1ee6000 - 0x7fffd1ef7ff3 libz.1.dylib (67) <46E3FFA2-4328-327A-8D34-A03E20BFFB8E> /usr/lib/libz.1.dylib\r\n 0x7fffd1f06000 - 0x7fffd1f0aff7 libcache.dylib (79) <093A4DAB-8385-3D47-A350-E20CB7CCF7BF> /usr/lib/system/libcache.dylib\r\n 0x7fffd1f0b000 - 0x7fffd1f15fff libcommonCrypto.dylib (60092.50.5) <8A64D1B0-C70E-385C-92F0-E669079FDA90> /usr/lib/system/libcommonCrypto.dylib\r\n 0x7fffd1f16000 - 0x7fffd1f1dfff libcompiler_rt.dylib (62) <55D47421-772A-32AB-B529-1A46C2F43B4D> /usr/lib/system/libcompiler_rt.dylib\r\n 0x7fffd1f1e000 - 0x7fffd1f26fff libcopyfile.dylib (138) <819BEA3C-DF11-3E3D-A1A1-5A51C5BF1961> /usr/lib/system/libcopyfile.dylib\r\n 0x7fffd1f27000 - 0x7fffd1faafdf libcorecrypto.dylib (442.50.19) <65D7165E-2E71-335D-A2D6-33F78E2DF0C1> /usr/lib/system/libcorecrypto.dylib\r\n 0x7fffd1fab000 - 0x7fffd1fdcfff libdispatch.dylib (703.50.37) <6582BAD6-ED27-3B30-B620-90B1C5A4AE3C> /usr/lib/system/libdispatch.dylib\r\n 0x7fffd1fdd000 - 0x7fffd1fe2ffb libdyld.dylib (433.5) /usr/lib/system/libdyld.dylib\r\n 0x7fffd1fe3000 - 0x7fffd1fe3ffb libkeymgr.dylib (28) <7AA011A9-DC21-3488-BF73-3B5B14D1FDD6> /usr/lib/system/libkeymgr.dylib\r\n 0x7fffd1fe4000 - 0x7fffd1ff0ffb libkxld.dylib (3789.60.24) <5DFCDC05-6CBC-35A6-8B92-DF6803492E12> /usr/lib/system/libkxld.dylib\r\n 0x7fffd1ff1000 - 0x7fffd1ff1fff liblaunch.dylib (972.60.2) /usr/lib/system/liblaunch.dylib\r\n 0x7fffd1ff2000 - 0x7fffd1ff7ff3 libmacho.dylib (898) <17D5D855-F6C3-3B04-B680-E9BF02EF8AED> /usr/lib/system/libmacho.dylib\r\n 0x7fffd1ff8000 - 0x7fffd1ffaff3 libquarantine.dylib (85.50.1) <12448CC2-378E-35F3-BE33-9DC395A5B970> /usr/lib/system/libquarantine.dylib\r\n 0x7fffd1ffb000 - 0x7fffd1ffcffb libremovefile.dylib (45) <38D4CB9C-10CD-30D3-8B7B-A515EC75FE85> /usr/lib/system/libremovefile.dylib\r\n 0x7fffd1ffd000 - 0x7fffd2015ff7 libsystem_asl.dylib (349.50.5) <096E4228-3B7C-30A6-8B13-EC909A64499A> /usr/lib/system/libsystem_asl.dylib\r\n 0x7fffd2016000 - 0x7fffd2016ff7 libsystem_blocks.dylib (67) <10DC5404-73AB-35B3-A277-A8AFECB476EB> /usr/lib/system/libsystem_blocks.dylib\r\n 0x7fffd2017000 - 0x7fffd20a4fef libsystem_c.dylib (1158.50.2) /usr/lib/system/libsystem_c.dylib\r\n 0x7fffd20a5000 - 0x7fffd20a8ffb libsystem_configuration.dylib (888.60.2) /usr/lib/system/libsystem_configuration.dylib\r\n 0x7fffd20a9000 - 0x7fffd20acfff libsystem_coreservices.dylib (41.4) <7D26DE79-B424-3450-85E1-F7FAB32714AB> /usr/lib/system/libsystem_coreservices.dylib\r\n 0x7fffd20ad000 - 0x7fffd20c5fff libsystem_coretls.dylib (121.50.4) /usr/lib/system/libsystem_coretls.dylib\r\n 0x7fffd20c6000 - 0x7fffd20ccfff libsystem_dnssd.dylib (765.50.9) /usr/lib/system/libsystem_dnssd.dylib\r\n 0x7fffd20cd000 - 0x7fffd20f6ff7 libsystem_info.dylib (503.50.4) <611DB84C-BF70-3F92-8702-B9F28A900920> /usr/lib/system/libsystem_info.dylib\r\n 0x7fffd20f7000 - 0x7fffd2119ff7 libsystem_kernel.dylib (3789.60.24) <6E9E485F-91F6-36B7-A125-AE91DC978BCC> /usr/lib/system/libsystem_kernel.dylib\r\n 0x7fffd211a000 - 0x7fffd2161fe7 libsystem_m.dylib (3121.6) <86D499B5-BBDC-3D3B-8A4E-97AE8E6672A4> /usr/lib/system/libsystem_m.dylib\r\n 0x7fffd2162000 - 0x7fffd2180ff7 libsystem_malloc.dylib (116.50.8) /usr/lib/system/libsystem_malloc.dylib\r\n 0x7fffd2181000 - 0x7fffd21daffb libsystem_network.dylib (856.60.1) <369D0221-56CA-3C3E-9EDE-94B41CAE77B7> /usr/lib/system/libsystem_network.dylib\r\n 0x7fffd21db000 - 0x7fffd21e4ff3 libsystem_networkextension.dylib (563.60.2) /usr/lib/system/libsystem_networkextension.dylib\r\n 0x7fffd21e5000 - 0x7fffd21eeff3 libsystem_notify.dylib (165.20.1) /usr/lib/system/libsystem_notify.dylib\r\n 0x7fffd21ef000 - 0x7fffd21f7fe7 libsystem_platform.dylib (126.50.8) <897462FD-B318-321B-A554-E61982630F7E> /usr/lib/system/libsystem_platform.dylib\r\n 0x7fffd21f8000 - 0x7fffd2202ff7 libsystem_pthread.dylib (218.60.3) /usr/lib/system/libsystem_pthread.dylib\r\n 0x7fffd2203000 - 0x7fffd2206ff7 libsystem_sandbox.dylib (592.60.1) /usr/lib/system/libsystem_sandbox.dylib\r\n 0x7fffd2207000 - 0x7fffd2208ff3 libsystem_secinit.dylib (24.50.4) /usr/lib/system/libsystem_secinit.dylib\r\n 0x7fffd2209000 - 0x7fffd2210ffb libsystem_symptoms.dylib (532.50.47) <3390E07C-C1CE-348F-ADBD-2C5440B45EAA> /usr/lib/system/libsystem_symptoms.dylib\r\n 0x7fffd2211000 - 0x7fffd2224ff7 libsystem_trace.dylib (518.60.2) <6B145B10-5874-3E89-90CD-D370DB475BA1> /usr/lib/system/libsystem_trace.dylib\r\n 0x7fffd2225000 - 0x7fffd222affb libunwind.dylib (35.3) <3D50D8A8-C460-334D-A519-2DA841102C6B> /usr/lib/system/libunwind.dylib\r\n 0x7fffd222b000 - 0x7fffd2254ff7 libxpc.dylib (972.60.2) <1C9AF716-69DF-359F-85E9-7DFDE362F9A2> /usr/lib/system/libxpc.dylib\r\n\r\nExternal Modification Summary:\r\n Calls made by other processes targeting this process:\r\n task_for_pid: 1\r\n thread_create: 0\r\n thread_set_state: 0\r\n Calls made by this process:\r\n task_for_pid: 0\r\n thread_create: 0\r\n thread_set_state: 0\r\n Calls made by all processes on this machine:\r\n task_for_pid: 32146897\r\n thread_create: 0\r\n thread_set_state: 0\r\n\r\nVM Region Summary:\r\nReadOnly portion of Libraries: Total=384.5M resident=0K(0%) swapped_out_or_unallocated=384.5M(100%)\r\nWritable regions: Total=473.9M written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=473.9M(100%)\r\n \r\n VIRTUAL REGION \r\nREGION TYPE SIZE COUNT (non-coalesced) \r\n=========== ======= ======= \r\nAccelerate framework 384K 4 \r\nActivity Tracing 256K 2 \r\nCG backing stores 53.7M 4 \r\nCG image 60K 8 \r\nCoreAnimation 40K 5 \r\nCoreUI image data 1600K 10 \r\nCoreUI image file 292K 6 \r\nDispatch continuations 8192K 2 \r\nFoundation 4K 2 \r\nIOKit 19.2M 14 \r\nKernel Alloc Once 8K 2 \r\nMALLOC 129.6M 28 \r\nMALLOC guard page 48K 10 \r\nMemory Tag 242 12K 2 \r\nMemory Tag 255 549.1M 118 \r\nSTACK GUARD 56.1M 35 \r\nStack 205.8M 70 \r\nVM_ALLOCATE 56K 8 \r\n__DATA 32.5M 267 \r\n__GLSLBUILTINS 2588K 2 \r\n__IMAGE 528K 2 \r\n__LINKEDIT 121.4M 17 \r\n__TEXT 263.1M 262 \r\n__UNICODE 556K 2 \r\nmapped file 72.3M 36 \r\nshared memory 33.4M 28 \r\n=========== ======= ======= \r\nTOTAL 1.5G 920 \r\n```\r\n\r\n### How to reproduce\r\n\r\n\r\n\r\n```\r\n $ git clone https://github.com/pwnsdx/wire-desktop\r\n $ npm install\r\n```\r\n(Extract [app.wire.com.zip](https://github.com/electron/electron/files/1050568/app.wire.com.zip) in ~/Library/Application Support/Wire/app.wire.com/)\r\n```\r\n $ DEBUG=* npm start\r\n```\r\n\r\nAs it's random it might not crash the first time, try to run it like 10 times." }, { "url": "https://api.github.com/repos/electron/electron/issues/9667", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9667/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9667/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9667/events", "html_url": "https://github.com/electron/electron/pull/9667", "id": 233448508, "number": 9667, "title": "change 'request' version", "user": { "login": "solinium", "id": 27219506, "avatar_url": "https://avatars1.githubusercontent.com/u/27219506?v=3", "gravatar_id": "", "url": "https://api.github.com/users/solinium", "html_url": "https://github.com/solinium", "followers_url": "https://api.github.com/users/solinium/followers", "following_url": "https://api.github.com/users/solinium/following{/other_user}", "gists_url": "https://api.github.com/users/solinium/gists{/gist_id}", "starred_url": "https://api.github.com/users/solinium/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/solinium/subscriptions", "organizations_url": "https://api.github.com/users/solinium/orgs", "repos_url": "https://api.github.com/users/solinium/repos", "events_url": "https://api.github.com/users/solinium/events{/privacy}", "received_events_url": "https://api.github.com/users/solinium/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-04T17:51:21Z", "updated_at": "2017-06-05T17:00:08Z", "closed_at": "2017-06-05T17:00:08Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9667", "html_url": "https://github.com/electron/electron/pull/9667", "diff_url": "https://github.com/electron/electron/pull/9667.diff", "patch_url": "https://github.com/electron/electron/pull/9667.patch" }, "body": "https://nodesecurity.io/advisories/request_remote-memory-exposure\r\ndependency 'request' has a security vulnerability for versions earlier than 2.68.0" }, { "url": "https://api.github.com/repos/electron/electron/issues/9666", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9666/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9666/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9666/events", "html_url": "https://github.com/electron/electron/issues/9666", "id": 233437193, "number": 9666, "title": "Line break in tray tooltip", "user": { "login": "mikaoras", "id": 9078877, "avatar_url": "https://avatars2.githubusercontent.com/u/9078877?v=3", "gravatar_id": "", "url": "https://api.github.com/users/mikaoras", "html_url": "https://github.com/mikaoras", "followers_url": "https://api.github.com/users/mikaoras/followers", "following_url": "https://api.github.com/users/mikaoras/following{/other_user}", "gists_url": "https://api.github.com/users/mikaoras/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikaoras/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikaoras/subscriptions", "organizations_url": "https://api.github.com/users/mikaoras/orgs", "repos_url": "https://api.github.com/users/mikaoras/repos", "events_url": "https://api.github.com/users/mikaoras/events{/privacy}", "received_events_url": "https://api.github.com/users/mikaoras/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-04T14:33:36Z", "updated_at": "2017-06-04T14:33:36Z", "closed_at": null, "body": "* Electron version: 1.6.10\r\n* Operating system: Windows 10\r\n\r\nIs there any way to break line in tray's tooltip?\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9665", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9665/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9665/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9665/events", "html_url": "https://github.com/electron/electron/issues/9665", "id": 233430718, "number": 9665, "title": "Windows 7 notifications taking up half the screen", "user": { "login": "alexbrazier", "id": 5689874, "avatar_url": "https://avatars1.githubusercontent.com/u/5689874?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alexbrazier", "html_url": "https://github.com/alexbrazier", "followers_url": "https://api.github.com/users/alexbrazier/followers", "following_url": "https://api.github.com/users/alexbrazier/following{/other_user}", "gists_url": "https://api.github.com/users/alexbrazier/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexbrazier/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexbrazier/subscriptions", "organizations_url": "https://api.github.com/users/alexbrazier/orgs", "repos_url": "https://api.github.com/users/alexbrazier/repos", "events_url": "https://api.github.com/users/alexbrazier/events{/privacy}", "received_events_url": "https://api.github.com/users/alexbrazier/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 544279309, "url": "https://api.github.com/repos/electron/electron/labels/component/notifications", "name": "component/notifications", "color": "f9d0c4", "default": false }, { "id": 97403549, "url": "https://api.github.com/repos/electron/electron/labels/platform/windows", "name": "platform/windows", "color": "c7def8", "default": false } ], "state": "open", "locked": false, "assignee": { "login": "alespergl", "id": 19880051, "avatar_url": "https://avatars2.githubusercontent.com/u/19880051?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alespergl", "html_url": "https://github.com/alespergl", "followers_url": "https://api.github.com/users/alespergl/followers", "following_url": "https://api.github.com/users/alespergl/following{/other_user}", "gists_url": "https://api.github.com/users/alespergl/gists{/gist_id}", "starred_url": "https://api.github.com/users/alespergl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alespergl/subscriptions", "organizations_url": "https://api.github.com/users/alespergl/orgs", "repos_url": "https://api.github.com/users/alespergl/repos", "events_url": "https://api.github.com/users/alespergl/events{/privacy}", "received_events_url": "https://api.github.com/users/alespergl/received_events", "type": "User", "site_admin": false }, "assignees": [ { "login": "alespergl", "id": 19880051, "avatar_url": "https://avatars2.githubusercontent.com/u/19880051?v=3", "gravatar_id": "", "url": "https://api.github.com/users/alespergl", "html_url": "https://github.com/alespergl", "followers_url": "https://api.github.com/users/alespergl/followers", "following_url": "https://api.github.com/users/alespergl/following{/other_user}", "gists_url": "https://api.github.com/users/alespergl/gists{/gist_id}", "starred_url": "https://api.github.com/users/alespergl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alespergl/subscriptions", "organizations_url": "https://api.github.com/users/alespergl/orgs", "repos_url": "https://api.github.com/users/alespergl/repos", "events_url": "https://api.github.com/users/alespergl/events{/privacy}", "received_events_url": "https://api.github.com/users/alespergl/received_events", "type": "User", "site_admin": false } ], "milestone": null, "comments": 2, "created_at": "2017-06-04T12:31:22Z", "updated_at": "2017-06-06T11:02:41Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: Windows 7\r\n\r\n### Expected behavior\r\n\r\n\r\n\r\nNotification size should be smaller, similar to the one you can just see in the screenshot below that you can just see the bottom of, behind the large notification.\r\n\r\n\r\n### Actual behavior\r\n\r\n\r\n\r\nThe new notifications for windows 7 are taking up half of the screen space as seen in the image below:\r\n![image](https://cloud.githubusercontent.com/assets/5689874/26761521/f2eec2c4-4928-11e7-9572-6df74ddb7ad1.png)\r\n\r\nI'm running windows in parallels on a mac, so I expect it to be a screen resolution issue (2880x1800)\r\n\r\n\r\n\r\n### How to reproduce\r\n\r\nTest notifications on Windows 7 with parallels on a mac, or use Windows with a high screen resolution (e.g. 2880x1800).\r\n\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9664", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9664/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9664/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9664/events", "html_url": "https://github.com/electron/electron/issues/9664", "id": 233407274, "number": 9664, "title": "Add documentation for use of preload to get functions from arbitrary scripts in webview.", "user": { "login": "MaharishiCanada", "id": 5099917, "avatar_url": "https://avatars0.githubusercontent.com/u/5099917?v=3", "gravatar_id": "", "url": "https://api.github.com/users/MaharishiCanada", "html_url": "https://github.com/MaharishiCanada", "followers_url": "https://api.github.com/users/MaharishiCanada/followers", "following_url": "https://api.github.com/users/MaharishiCanada/following{/other_user}", "gists_url": "https://api.github.com/users/MaharishiCanada/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaharishiCanada/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaharishiCanada/subscriptions", "organizations_url": "https://api.github.com/users/MaharishiCanada/orgs", "repos_url": "https://api.github.com/users/MaharishiCanada/repos", "events_url": "https://api.github.com/users/MaharishiCanada/events{/privacy}", "received_events_url": "https://api.github.com/users/MaharishiCanada/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-04T02:26:15Z", "updated_at": "2017-06-05T17:57:43Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: Ubuntu 16.10\r\n\r\nI have successfully injected and used a script in a webview using this webview tag in index.html:\r\n``` html\r\n\r\n``` \r\nthese definitions in preloadtest.js:\r\n``` javascript\r\nfunction test() {console.log('Hello from test in preload.js'); }\r\nglobal.myApi = {\r\n hellofct: test\r\n}\r\n```\r\nand this script in executeJavaScript on the webContent of the webview: \r\n``` javascript \r\nmyApi.hellofct();\r\n```\r\nI also succeeded in a more complex case: the script [css-selector-generator.js](https://github.com/fczbkk/css-selector-generator/blob/master/build/css-selector-generator.js). As in the simple example, I preloaded the script in a webview tag: \r\n``` html\r\n\r\n```\r\nHowever, I had to hack the script. The script exports a constructor `CssSelectorGenerator` into an object `exports`, if it is defined. By default, `exports`is defined in Node. So, I simply added this snippet at the bottom:\r\n``` javascript\r\nglobal.myapi = {\r\n CssSelectorGenerator : exports.CssSelectorGenerator\r\n} \r\n```\r\nIn executeJavaScript, I used the constructor the normal way:\r\n``` javascript \r\nvar my_selector_generator = new myapi.CssSelectorGenerator; \r\nvar my_element_selector = my_selector_generator.getSelector(any_dom_html_node);\r\nconsole.log(my_element_selector); \r\n```\r\nIs there a more systematic way to export script objects in a webview? The script css-selector-generator.js, came from a Node module, so there is a simpler way in that case. You simply install the module and require it in your preload script with \r\n``` javascript\r\nvar CssSelectorGenerator = require('css-selector-generator').CssSelectorGenerator;\r\n```\r\nand then export `CssSelectorGenerator` as we did before. \r\n``` javascript\r\nglobal.myapi = {\r\n CssSelectorGenerator : CssSelectorGenerator\r\n} \r\n``` \r\nNo need to hack the script. However, what do we do when it is not a Node module? I looked for documentation in Electron to see what was known. \r\n\r\n### Expected behavior \r\n\r\nI only saw reference to `remote`, but it was not clear how it can be useful. If the principle used above is valid and robust, it will be nice to have some documentation on this in the Electron documentation with more complex examples. Perhaps, what I am missing are general guidelines to migrate an arbitrary script into a script that can be imported in a webview. Perhaps, the way to proceed is to first migrate an arbitrary script into a Node package. It will be nice if the big picture was presented somewhere. \r\n\r\n### Actual behavior\r\n\r\n[I found this in Stackoverflow](https://stackoverflow.com/questions/39441448/communicate-with-webview-in-electron). I also saw that people injected jquery using a preload script, but I could not generalize the principle. I also saw ways to inject an entire script by appending it to the head as a script tag element, but this is different and fails when the page is restricted with a CSP policy. " }, { "url": "https://api.github.com/repos/electron/electron/issues/9663", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9663/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9663/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9663/events", "html_url": "https://github.com/electron/electron/issues/9663", "id": 233392765, "number": 9663, "title": "Can't register service workers for a custom protocol", "user": { "login": "pfrazee", "id": 1270099, "avatar_url": "https://avatars1.githubusercontent.com/u/1270099?v=3", "gravatar_id": "", "url": "https://api.github.com/users/pfrazee", "html_url": "https://github.com/pfrazee", "followers_url": "https://api.github.com/users/pfrazee/followers", "following_url": "https://api.github.com/users/pfrazee/following{/other_user}", "gists_url": "https://api.github.com/users/pfrazee/gists{/gist_id}", "starred_url": "https://api.github.com/users/pfrazee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pfrazee/subscriptions", "organizations_url": "https://api.github.com/users/pfrazee/orgs", "repos_url": "https://api.github.com/users/pfrazee/repos", "events_url": "https://api.github.com/users/pfrazee/events{/privacy}", "received_events_url": "https://api.github.com/users/pfrazee/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 227722189, "url": "https://api.github.com/repos/electron/electron/labels/component/protocol", "name": "component/protocol", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-03T20:14:42Z", "updated_at": "2017-06-23T09:57:21Z", "closed_at": null, "body": "* Electron version: 1.6.10\r\n* Operating system: MacOS 10.12.5\r\n\r\nRegistering a service worker with a custom protocol gives this error:\r\n\r\n`ServiceWorker registration failed: DOMException: Failed to register a ServiceWorker: No URL is associated with the caller's document.`\r\n\r\nThis occurs despite following this process:\r\n\r\n```js\r\n// in index.js\r\nelectron.protocol.registerStandardSchemes(['custom'], { secure: true })\r\n\r\nfunction onReady () {\r\n electron.protocol.registerServiceWorkerSchemes(['custom'])\r\n electron.protocol.registerHttpProtocol('custom', ...)\r\n // ...\r\n}\r\n\r\n// in webview-preload.js\r\nwebFrame.registerURLSchemeAsPrivileged('custom', {allowServiceWorkers: true})\r\n```\r\n\r\nDemonstrated with https://github.com/pfrazee/electron-bug-service-workers-failure\r\n\r\n```\r\ngit clone https://github.com/pfrazee/electron-bug-service-workers-failure\r\ncd electron-bug-service-workers-failure\r\nnpm i\r\nnpm start\r\n```\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9662", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9662/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9662/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9662/events", "html_url": "https://github.com/electron/electron/issues/9662", "id": 233386730, "number": 9662, "title": "musl libc support", "user": { "login": "DirectorX", "id": 6268846, "avatar_url": "https://avatars0.githubusercontent.com/u/6268846?v=3", "gravatar_id": "", "url": "https://api.github.com/users/DirectorX", "html_url": "https://github.com/DirectorX", "followers_url": "https://api.github.com/users/DirectorX/followers", "following_url": "https://api.github.com/users/DirectorX/following{/other_user}", "gists_url": "https://api.github.com/users/DirectorX/gists{/gist_id}", "starred_url": "https://api.github.com/users/DirectorX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DirectorX/subscriptions", "organizations_url": "https://api.github.com/users/DirectorX/orgs", "repos_url": "https://api.github.com/users/DirectorX/repos", "events_url": "https://api.github.com/users/DirectorX/events{/privacy}", "received_events_url": "https://api.github.com/users/DirectorX/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-03T18:24:42Z", "updated_at": "2017-06-03T18:24:42Z", "closed_at": null, "body": "\r\n\r\n* Electron version: all\r\n* Operating system: Void Linux **(musl)**\r\n\r\n### Expected behavior\r\n\r\nElectron should be built for musl libc systems\r\n\r\n### Actual behavior\r\n\r\nElectron should be built for musl libc systems\r\n\r\n### How to reproduce\r\n\r\nirrelevant" }, { "url": "https://api.github.com/repos/electron/electron/issues/9661", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9661/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9661/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9661/events", "html_url": "https://github.com/electron/electron/issues/9661", "id": 233385418, "number": 9661, "title": "SVG icons support on nativeImage", "user": { "login": "bil-elmoussaoui", "id": 7660997, "avatar_url": "https://avatars1.githubusercontent.com/u/7660997?v=3", "gravatar_id": "", "url": "https://api.github.com/users/bil-elmoussaoui", "html_url": "https://github.com/bil-elmoussaoui", "followers_url": "https://api.github.com/users/bil-elmoussaoui/followers", "following_url": "https://api.github.com/users/bil-elmoussaoui/following{/other_user}", "gists_url": "https://api.github.com/users/bil-elmoussaoui/gists{/gist_id}", "starred_url": "https://api.github.com/users/bil-elmoussaoui/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bil-elmoussaoui/subscriptions", "organizations_url": "https://api.github.com/users/bil-elmoussaoui/orgs", "repos_url": "https://api.github.com/users/bil-elmoussaoui/repos", "events_url": "https://api.github.com/users/bil-elmoussaoui/events{/privacy}", "received_events_url": "https://api.github.com/users/bil-elmoussaoui/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-03T18:03:15Z", "updated_at": "2017-06-05T22:36:04Z", "closed_at": "2017-06-05T22:36:03Z", "body": "\r\n\r\n* Electron version: v1.6.9\r\n* Operating system: Arch Linux with Gnome as DE\r\n\r\n### Expected behavior\r\nNativeImage does not support SVG images :( I've to convert the images to png's and there's no easy way to doing so (use external libraries that almost every one of them requires PhantomJs...)\r\n\r\nEvery Linux distro supports using SVG icons for Tray icons. And so should nativeImage on Linux desktop.\r\n\r\n### Actual behavior\r\nDoesn't work as SVG icons are not supported\r\n\r\n\r\n### How to reproduce\r\n```javascript\r\nconst nativeImage = require('electron').nativeImage\r\n\r\nlet image = nativeImage.createFromPath('/Users/somebody/images/icon.svg')\r\nconsole.log(image)\r\n```\r\n\r\nThe reason why I need this is that I've created a simple package to look for an icon on current icon theme used by the user. This way, electron applications can look more native with tray icons that can be themed by any theme designer (without any hackish solution like extracting the user file...)\r\nAnd every icon theme on Linux is using SVG icons. I hope this convince you enough to make this happen:+1: " }, { "url": "https://api.github.com/repos/electron/electron/issues/9660", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9660/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9660/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9660/events", "html_url": "https://github.com/electron/electron/issues/9660", "id": 233380258, "number": 9660, "title": "Changing devtools preferences doesn't reload the UI", "user": { "login": "jhen0409", "id": 3001525, "avatar_url": "https://avatars3.githubusercontent.com/u/3001525?v=3", "gravatar_id": "", "url": "https://api.github.com/users/jhen0409", "html_url": "https://github.com/jhen0409", "followers_url": "https://api.github.com/users/jhen0409/followers", "following_url": "https://api.github.com/users/jhen0409/following{/other_user}", "gists_url": "https://api.github.com/users/jhen0409/gists{/gist_id}", "starred_url": "https://api.github.com/users/jhen0409/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jhen0409/subscriptions", "organizations_url": "https://api.github.com/users/jhen0409/orgs", "repos_url": "https://api.github.com/users/jhen0409/repos", "events_url": "https://api.github.com/users/jhen0409/events{/privacy}", "received_events_url": "https://api.github.com/users/jhen0409/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 144086475, "url": "https://api.github.com/repos/electron/electron/labels/component/devtools", "name": "component/devtools", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-03T16:34:12Z", "updated_at": "2017-06-22T17:13:17Z", "closed_at": null, "body": "* Electron version: 1.7.2\r\n* Operating system: macOS Sierra\r\n\r\n### Expected behavior\r\n\r\nIn the browser devtools, it should reload the devtools when we do a one of the following items:\r\n\r\n1. Change the devtools theme\r\n2. Click `Restore defaults and reload`\r\n\r\n### Actual behavior\r\n\r\nIt doesn't reload In Electron devtools, I have to manually restart the devtools.\r\n\r\n### How to reproduce\r\n\r\nThe `Expected behavior` have explained.\r\n\r\nIt's also related to https://github.com/jhen0409/react-native-debugger/issues/87. It should be a longterm problem, but I can't found the similar issues on this repo." }, { "url": "https://api.github.com/repos/electron/electron/issues/9659", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9659/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9659/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9659/events", "html_url": "https://github.com/electron/electron/issues/9659", "id": 233373795, "number": 9659, "title": "contents.getPrinters() is undifined?", "user": { "login": "askie", "id": 1140973, "avatar_url": "https://avatars1.githubusercontent.com/u/1140973?v=3", "gravatar_id": "", "url": "https://api.github.com/users/askie", "html_url": "https://github.com/askie", "followers_url": "https://api.github.com/users/askie/followers", "following_url": "https://api.github.com/users/askie/following{/other_user}", "gists_url": "https://api.github.com/users/askie/gists{/gist_id}", "starred_url": "https://api.github.com/users/askie/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/askie/subscriptions", "organizations_url": "https://api.github.com/users/askie/orgs", "repos_url": "https://api.github.com/users/askie/repos", "events_url": "https://api.github.com/users/askie/events{/privacy}", "received_events_url": "https://api.github.com/users/askie/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-03T14:45:18Z", "updated_at": "2017-06-05T15:45:09Z", "closed_at": "2017-06-05T15:45:09Z", "body": "electron 1.6.10 remove contents.getPrinters() ?" }, { "url": "https://api.github.com/repos/electron/electron/issues/9658", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9658/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9658/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9658/events", "html_url": "https://github.com/electron/electron/issues/9658", "id": 233345118, "number": 9658, "title": "Electron build failed in Linux & Windows (robotjs 0.4.7 failed in travis & normalize-package-data cannot find in Appveyor)", "user": { "login": "fyhao", "id": 1223477, "avatar_url": "https://avatars3.githubusercontent.com/u/1223477?v=3", "gravatar_id": "", "url": "https://api.github.com/users/fyhao", "html_url": "https://github.com/fyhao", "followers_url": "https://api.github.com/users/fyhao/followers", "following_url": "https://api.github.com/users/fyhao/following{/other_user}", "gists_url": "https://api.github.com/users/fyhao/gists{/gist_id}", "starred_url": "https://api.github.com/users/fyhao/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fyhao/subscriptions", "organizations_url": "https://api.github.com/users/fyhao/orgs", "repos_url": "https://api.github.com/users/fyhao/repos", "events_url": "https://api.github.com/users/fyhao/events{/privacy}", "received_events_url": "https://api.github.com/users/fyhao/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-03T04:58:50Z", "updated_at": "2017-06-03T05:02:12Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: Travis Linux / Appveyor Windows\r\n\r\n### Expected behavior\r\n\r\nSuccessfully built Electron\r\n\r\n### Actual behavior\r\n\r\nTravis & Appveyor built failed as:\r\n\r\nTravis error: https://travis-ci.org/fyhao/electron-wf/jobs/239000922\r\n`\r\nmake: *** [Release/obj.target/robotjs/src/robotjs.o] Error 1\r\nmake: Leaving directory `/home/travis/build/fyhao/electron-wf/node_modules/robotjs/build'\r\ngyp ERR! build error \r\ngyp ERR! stack Error: `make` failed with exit code: 2\r\ngyp ERR! stack at ChildProcess.onExit (/home/travis/.nvm/versions/node/v8.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:285:23)\r\ngyp ERR! stack at emitTwo (events.js:125:13)\r\ngyp ERR! stack at ChildProcess.emit (events.js:213:7)\r\ngyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:197:12)\r\ngyp ERR! System Linux 4.8.12-040812-generic\r\ngyp ERR! command \"/home/travis/.nvm/versions/node/v8.0.0/bin/node\" \"/home/travis/.nvm/versions/node/v8.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"\r\ngyp ERR! cwd /home/travis/build/fyhao/electron-wf/node_modules/robotjs\r\ngyp ERR! node -v v8.0.0\r\ngyp ERR! node-gyp -v v3.6.1\r\ngyp0m ERR! not ok \r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! errno 1\r\nnpm ERR! robotjs@0.4.7 install: `prebuild-install || node-gyp rebuild`\r\nnpm ERR! Exit status 1\r\nnpm ERR! \r\nnpm ERR! Failed at the robotjs@0.4.7 install script.\r\nnpm ERR! This is probably not a problem with npm. There is likely additional logging output above.\r\nnpm ERR! A complete log of this run can be found in:\r\nnpm ERR! /home/travis/.npm/_logs/2017-06-03T04_40_58_770Z-debug.log\r\nThe command \"eval npm install \" failed 3 times.\r\nThe command \"npm install \" failed and exited with 1 during .\r\nYour build has been stopped.\r\n`\r\nAppveyor error: https://ci.appveyor.com/project/electron-bot/electron-prebuilt/branch/master/job/80njubw65q42297i\r\n`\r\n fsevents@1.1.1 install C:\\projects\\electron-wf\\node_modules\\fsevents\r\n> node install\r\n> electron-prebuilt@1.4.13 postinstall C:\\projects\\electron-wf\\node_modules\\electron-prebuilt\r\n> node install.js\r\n> electron@1.6.10 postinstall C:\\projects\\electron-wf\\node_modules\\electron\r\n> node install.js\r\n> electron-wf@0.1.0 postinstall C:\\projects\\electron-wf\r\n> install-app-deps\r\nError: Cannot find module 'normalize-package-data'\r\n at Function.Module._resolveFilename (module.js:455:15)\r\n at Function.Module._load (module.js:403:25)\r\n at Module.require (module.js:483:17)\r\n at require (internal/module.js:20:19)\r\n at Object. (C:\\projects\\electron-wf\\node_modules\\electron-builder\\out\\util\\readPackageJson.js:202:23)\r\n at Module._compile (module.js:556:32)\r\n at Object.Module._extensions..js (module.js:565:10)\r\n at Module.load (module.js:473:32)\r\n at tryModuleLoad (module.js:432:12)\r\n at Function.Module._load (module.js:424:3)\r\n at Module.require (module.js:483:17)\r\n at require (internal/module.js:20:19)\r\n at _load_readPackageJson (C:\\projects\\electron-wf\\node_modules\\electron-builder\\out\\cli\\install-app-deps.js:61:31)\r\n at C:\\projects\\electron-wf\\node_modules\\electron-builder\\out\\cli\\install-app-deps.js:26:56\r\n at next (native)\r\nFrom previous event:\r\n at main (C:\\projects\\electron-wf\\node_modules\\electron-builder\\out\\cli\\install-app-deps.js:36:21)\r\n at Object. (C:\\projects\\electron-wf\\node_modules\\electron-builder\\out\\cli\\install-app-deps.js:72:1)\r\n at Module._compile (module.js:556:32)\r\n at Object.Module._extensions..js (module.js:565:10)\r\n at Module.load (module.js:473:32)\r\n at tryModuleLoad (module.js:432:12)\r\n at Function.Module._load (module.js:424:3)\r\n at Module.runMain (module.js:590:10)\r\n at run (bootstrap_node.js:394:7)\r\n at startup (bootstrap_node.js:149:9)\r\n at bootstrap_node.js:509:3\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! errno 4294967295\r\nnpm ERR! electron-wf@0.1.0 postinstall: `install-app-deps`\r\nnpm ERR! Exit status 4294967295\r\nnpm ERR! \r\nnpm ERR! Failed at the electron-wf@0.1.0 postinstall script.\r\nnpm ERR! This is probably not a problem with npm. There is likely additional logging output above.\r\nnpm ERR! A complete log of this run can be found in:\r\nnpm ERR! C:\\Users\\appveyor\\AppData\\Roaming\\npm-cache\\_logs\\2017-06-03T04_39_54_431Z-debug.log\r\nThe batch file cannot be found.\r\nCommand exited with code 1\r\n`\r\n\r\n### How to reproduce\r\nRefer the issue here: https://github.com/fyhao/electron-wf/issues/123\r\nThe failed build in travis: https://travis-ci.org/fyhao/electron-wf/jobs/239000922\r\nThe failed build in appveyor: https://ci.appveyor.com/project/electron-bot/electron-prebuilt/branch/master/job/80njubw65q42297i\r\nThe package json: https://github.com/fyhao/electron-wf/blob/master/package.json\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9657", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9657/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9657/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9657/events", "html_url": "https://github.com/electron/electron/pull/9657", "id": 233344815, "number": 9657, "title": "Typescript menu popup fix", "user": { "login": "MarshallOfSound", "id": 6634592, "avatar_url": "https://avatars0.githubusercontent.com/u/6634592?v=3", "gravatar_id": "", "url": "https://api.github.com/users/MarshallOfSound", "html_url": "https://github.com/MarshallOfSound", "followers_url": "https://api.github.com/users/MarshallOfSound/followers", "following_url": "https://api.github.com/users/MarshallOfSound/following{/other_user}", "gists_url": "https://api.github.com/users/MarshallOfSound/gists{/gist_id}", "starred_url": "https://api.github.com/users/MarshallOfSound/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MarshallOfSound/subscriptions", "organizations_url": "https://api.github.com/users/MarshallOfSound/orgs", "repos_url": "https://api.github.com/users/MarshallOfSound/repos", "events_url": "https://api.github.com/users/MarshallOfSound/events{/privacy}", "received_events_url": "https://api.github.com/users/MarshallOfSound/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-03T04:50:55Z", "updated_at": "2017-06-05T15:56:09Z", "closed_at": "2017-06-05T15:55:58Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9657", "html_url": "https://github.com/electron/electron/pull/9657", "diff_url": "https://github.com/electron/electron/pull/9657.diff", "patch_url": "https://github.com/electron/electron/pull/9657.patch" }, "body": "This removes the weird required syntax in menu docs that tricked the parser\r\n\r\nFixes electron/electron-typescript-definitions/issues/54" }, { "url": "https://api.github.com/repos/electron/electron/issues/9656", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9656/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9656/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9656/events", "html_url": "https://github.com/electron/electron/issues/9656", "id": 233334858, "number": 9656, "title": "Potential security issue with BrowserWindow.loadURL", "user": { "login": "sancarn", "id": 7938900, "avatar_url": "https://avatars2.githubusercontent.com/u/7938900?v=3", "gravatar_id": "", "url": "https://api.github.com/users/sancarn", "html_url": "https://github.com/sancarn", "followers_url": "https://api.github.com/users/sancarn/followers", "following_url": "https://api.github.com/users/sancarn/following{/other_user}", "gists_url": "https://api.github.com/users/sancarn/gists{/gist_id}", "starred_url": "https://api.github.com/users/sancarn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sancarn/subscriptions", "organizations_url": "https://api.github.com/users/sancarn/orgs", "repos_url": "https://api.github.com/users/sancarn/repos", "events_url": "https://api.github.com/users/sancarn/events{/privacy}", "received_events_url": "https://api.github.com/users/sancarn/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2017-06-03T01:26:13Z", "updated_at": "2017-06-03T15:11:35Z", "closed_at": "2017-06-03T04:32:44Z", "body": "BrowserWindow.loadURL is a great way to implement websites into your own applications. For instance BrowserWindow.loadURL('http://google.com'), opens google in the current browser window, which is fantastic and I am really glad this feature exists. Another feature which I am glad exists is the ability for the BrowserWindow to execute NodeJS code.\r\n\r\nWith the ability to load URLs into the BrowserWindow things like custom WebBrowsers are one of the first thoughts that comes to mind. Or at least one that came to my mind when I first came across NodeJS. However you have to be very careful because since your browser can execute NodeJS code, any website you navigate to - or rather any website the user navigates to intentionally or otherwise - could have dire consequences.\r\n\r\nAs a test example I created the following website:\r\n```\r\n\r\n\r\n \r\n Security Breach \r\n \r\n \r\n \r\n Look at your desktop! ;)\r\n \r\n\r\n```\r\n\r\nIf loaded in a regular WebBrowser nothing interesting happens. However if you create a WebBrowser with Electron (and you don't implement any protection) the javascript will write a file to your desktop autonomously without your permission.\r\n\r\nThere is no denying that the fix for this security issue should probably come from the developer of the WebBrowser. However it would be nice if there was an option within Electron to sandbox (using an iframe) all **web resources** into loaded into a BrowserWindow. \r\n\r\n```BrowserWindow.sandboxAllWebResources = true/false```\r\n\r\nRecently a friend and I wanted to do this dynamically (we're making a plugin system for an application we're making and want to enable this option by default) and since we can't modify electron at it's source (otherwise the application wouldn't stand the test of time) we need to override `require()` to override electron's browserwindow's loadURL function. Not a big deal, but it would be nice if such an option existed, and it would at least protect unsuspecting users from websites which exploit applications made by uninformed developers.\r\n\r\nI still believe however that this rule should only apply to web content, and that local NodeJS code should execute as it does now. So correct me if I am wrong but this suggestion is different to the current existing sandbox and nodeIntegration options for the BrowserWindow. Ultimately in my opinion:\r\n\r\nLocal = Trustworthy\r\nOnline = Potentially untrustworthy\r\n\r\nThoughts?\r\n\r\nNote:\r\nAn alternative solution would be an option in loadURL() to launch the URL in 'safe' mode or similar." }, { "url": "https://api.github.com/repos/electron/electron/issues/9655", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9655/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9655/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9655/events", "html_url": "https://github.com/electron/electron/issues/9655", "id": 233329724, "number": 9655, "title": "`window.history.go(-1)` does not always go to the previous history state", "user": { "login": "drewmacneil", "id": 2507916, "avatar_url": "https://avatars2.githubusercontent.com/u/2507916?v=3", "gravatar_id": "", "url": "https://api.github.com/users/drewmacneil", "html_url": "https://github.com/drewmacneil", "followers_url": "https://api.github.com/users/drewmacneil/followers", "following_url": "https://api.github.com/users/drewmacneil/following{/other_user}", "gists_url": "https://api.github.com/users/drewmacneil/gists{/gist_id}", "starred_url": "https://api.github.com/users/drewmacneil/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/drewmacneil/subscriptions", "organizations_url": "https://api.github.com/users/drewmacneil/orgs", "repos_url": "https://api.github.com/users/drewmacneil/repos", "events_url": "https://api.github.com/users/drewmacneil/events{/privacy}", "received_events_url": "https://api.github.com/users/drewmacneil/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-06-03T00:14:11Z", "updated_at": "2017-06-03T04:34:28Z", "closed_at": "2017-06-03T04:34:28Z", "body": "* Electron version: 1.6.10\r\n* Operating system: macOS 10.12.5\r\n\r\n### Short description\r\n\r\nPerforming `window.history.go(-1)` should always go to the prior state on the history stack, even if the URL for the prior state matches the current URL. This is best illustrated with an example.\r\n\r\n### Example\r\n\r\n1. `electron https://en.wikipedia.org/wiki/Electron`\r\n2. Open the developer tools and switch to the JS console.\r\n3. Run `window.location.href`, observe the result is 'https://en.wikipedia.org/wiki/Electron'.\r\n4. Click the 'Composition' link in the sidebar on the right.\r\n5. Run `window.location.href`, observe the URL is 'https://en.wikipedia.org/wiki/Particle#Composition'.\r\n6. Run `window.history.pushState('new_state', 'title', window.location.href)`.\r\n7. Run `window.location.href` and notice the result is the same as Step 5.\r\n8. Run `window.history.state` and observe that 'new_state' is returned.\r\n9. Run `window.history.go(-1)`.\r\n10. Observe that you are back at the original URL (ie. `window.location.href` is 'https://en.wikipedia.org/wiki/Electron'). This is incorrect behavior.\r\n\r\nStep 10 visually should not have done anything, because 'https://en.wikipedia.org/wiki/Particle#Composition' should have been in the history stack twice (once for the navigation in Step 4 and again for the manual `pushState` call in Step 6). This is what happens in Chrome 58.\r\n\r\nAnother observation is that replacing Step 6 with a call to `window.history.pushState('new_state', 'title', window.location.href + '#')` (ie. add '#' to the current URL when pushing the new state) results in Step 10 doing the right thing; you remain on the 'Composition' page.\r\n\r\n### Expected behavior\r\n\r\nCurrently, Electron seems to go back to the most recent unique URL when performing `window.history.go(-1)`. It shouldn't do that; it should always go to the previous history state, even if it contains a URL that matches the current one." }, { "url": "https://api.github.com/repos/electron/electron/issues/9654", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9654/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9654/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9654/events", "html_url": "https://github.com/electron/electron/issues/9654", "id": 233320558, "number": 9654, "title": "TypeScript translation broken for BrowserWindow.setOverlayIcon", "user": { "login": "mrfunkycold", "id": 2460039, "avatar_url": "https://avatars2.githubusercontent.com/u/2460039?v=3", "gravatar_id": "", "url": "https://api.github.com/users/mrfunkycold", "html_url": "https://github.com/mrfunkycold", "followers_url": "https://api.github.com/users/mrfunkycold/followers", "following_url": "https://api.github.com/users/mrfunkycold/following{/other_user}", "gists_url": "https://api.github.com/users/mrfunkycold/gists{/gist_id}", "starred_url": "https://api.github.com/users/mrfunkycold/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mrfunkycold/subscriptions", "organizations_url": "https://api.github.com/users/mrfunkycold/orgs", "repos_url": "https://api.github.com/users/mrfunkycold/repos", "events_url": "https://api.github.com/users/mrfunkycold/events{/privacy}", "received_events_url": "https://api.github.com/users/mrfunkycold/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-02T22:49:16Z", "updated_at": "2017-06-03T04:38:09Z", "closed_at": "2017-06-03T04:35:30Z", "body": "\r\n\r\n* Electron version: 1.7.2\r\n* Operating system: All (but test feature on Win 10)\r\n\r\n### Expected behavior\r\n\r\n```\r\nconst {BrowserWindow} = require('electron');\r\nconst win = new BrowserWindow();\r\n\r\nwin.setOverlayIcon(null, ''); // resets the overlay icon\r\n});\r\n```\r\n\r\n\r\n\r\n### Actual behavior\r\n\r\n```\r\nconst {BrowserWindow} = require('electron');\r\nconst win = new BrowserWindow();\r\n\r\nwin.setOverlayIcon(null, ''); // only allows you to set a native Image\r\n});\r\n```\r\n\r\n\r\n\r\n### How to reproduce\r\nUpdate the repo to electron 1.7.2. Use TypeScript. Create a module and copy/paste the code snippet above. If using an IDE with TypeScript intellisense (i.e. Visual Studio Code), null value in `setOverlayIcon` will be highlighted in red. Error indicated is: `[ts] Argument of type 'null' is not assignable to parameter of type 'NativeImage'.`\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9653", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9653/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9653/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9653/events", "html_url": "https://github.com/electron/electron/issues/9653", "id": 233255840, "number": 9653, "title": "Lock event on macOS", "user": { "login": "antelle", "id": 633557, "avatar_url": "https://avatars1.githubusercontent.com/u/633557?v=3", "gravatar_id": "", "url": "https://api.github.com/users/antelle", "html_url": "https://github.com/antelle", "followers_url": "https://api.github.com/users/antelle/followers", "following_url": "https://api.github.com/users/antelle/following{/other_user}", "gists_url": "https://api.github.com/users/antelle/gists{/gist_id}", "starred_url": "https://api.github.com/users/antelle/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/antelle/subscriptions", "organizations_url": "https://api.github.com/users/antelle/orgs", "repos_url": "https://api.github.com/users/antelle/repos", "events_url": "https://api.github.com/users/antelle/events{/privacy}", "received_events_url": "https://api.github.com/users/antelle/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 35575880, "url": "https://api.github.com/repos/electron/electron/labels/enhancement", "name": "enhancement", "color": "84b6eb", "default": true }, { "id": 97403606, "url": "https://api.github.com/repos/electron/electron/labels/platform/macOS", "name": "platform/macOS", "color": "c7def8", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-02T17:57:38Z", "updated_at": "2017-06-12T18:52:44Z", "closed_at": null, "body": "Electron supports `session-end` for Windows. It would be great to be able to have the same for macOS, probably for these system events:\r\n- `com.apple.screenIsLocked`\r\n- `com.apple.screensaver.didstart`" }, { "url": "https://api.github.com/repos/electron/electron/issues/9652", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9652/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9652/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9652/events", "html_url": "https://github.com/electron/electron/issues/9652", "id": 233152056, "number": 9652, "title": "Is there any reason why we can't use Win32 SendMessage APIs?", "user": { "login": "sancarn", "id": 7938900, "avatar_url": "https://avatars2.githubusercontent.com/u/7938900?v=3", "gravatar_id": "", "url": "https://api.github.com/users/sancarn", "html_url": "https://github.com/sancarn", "followers_url": "https://api.github.com/users/sancarn/followers", "following_url": "https://api.github.com/users/sancarn/following{/other_user}", "gists_url": "https://api.github.com/users/sancarn/gists{/gist_id}", "starred_url": "https://api.github.com/users/sancarn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sancarn/subscriptions", "organizations_url": "https://api.github.com/users/sancarn/orgs", "repos_url": "https://api.github.com/users/sancarn/repos", "events_url": "https://api.github.com/users/sancarn/events{/privacy}", "received_events_url": "https://api.github.com/users/sancarn/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-02T11:15:37Z", "updated_at": "2017-06-02T11:17:01Z", "closed_at": null, "body": "I find it a bit odd how we can use win.hookWindowMessage(message, callback) and manipulate messages but we can't use Send/Post message to other windows. It is quite common for a process to reply to a received message with some data however with these callbacks I'm not sure that is possible? If not, SendMessage / PostMessage APIs would be very helpful (unless there is a reason for them not to be used)" }, { "url": "https://api.github.com/repos/electron/electron/issues/9651", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9651/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9651/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9651/events", "html_url": "https://github.com/electron/electron/issues/9651", "id": 233083847, "number": 9651, "title": "5 electron tests failed with master branch latest revision", "user": { "login": "KarenHuang2016", "id": 20896121, "avatar_url": "https://avatars3.githubusercontent.com/u/20896121?v=3", "gravatar_id": "", "url": "https://api.github.com/users/KarenHuang2016", "html_url": "https://github.com/KarenHuang2016", "followers_url": "https://api.github.com/users/KarenHuang2016/followers", "following_url": "https://api.github.com/users/KarenHuang2016/following{/other_user}", "gists_url": "https://api.github.com/users/KarenHuang2016/gists{/gist_id}", "starred_url": "https://api.github.com/users/KarenHuang2016/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KarenHuang2016/subscriptions", "organizations_url": "https://api.github.com/users/KarenHuang2016/orgs", "repos_url": "https://api.github.com/users/KarenHuang2016/repos", "events_url": "https://api.github.com/users/KarenHuang2016/events{/privacy}", "received_events_url": "https://api.github.com/users/KarenHuang2016/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 535392427, "url": "https://api.github.com/repos/electron/electron/labels/component/build", "name": "component/build", "color": "f9d0c4", "default": false }, { "id": 35575878, "url": "https://api.github.com/repos/electron/electron/labels/fixme/bug", "name": "fixme/bug", "color": "fc2929", "default": false } ], "state": "closed", "locked": false, "assignee": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 6, "created_at": "2017-06-02T05:54:16Z", "updated_at": "2017-06-06T20:37:49Z", "closed_at": "2017-06-06T20:37:49Z", "body": "We tried to build and run tests for electron. There are 5 tests failed on master branch latest revision dfab104. I reported issue https://github.com/electron/electron/issues/9442 before. And you fixed these 4 tests on x86. However these 4 tests still failed on x64. And there is a new test failed on both x86 and x64. Could you please help to take a look at this? Thanks in advance!\r\n\r\n**Repro steps:**\r\n1. git clone https://github.com/electron/electron.git D:\\Electron\\src\r\n2. Open a clean command prompt and browse to D:\\Electron\\src\r\n3. set APPVEYOR=True\r\n4. Build and test electron:\r\n**For x86:**\r\na. python script\\bootstrap.py -v --target_arch=ia32\r\nb. vendor\\depot_tools\\ninja.exe -C out\\R electron -v -d keeprsp\r\nc. python script\\test.py --ci -c R\r\n**For x64:**\r\na. python script\\bootstrap.py -v --target_arch=x64\r\nb. vendor\\depot_tools\\ninja.exe -C out\\R_x64 electron -v -d keeprsp\r\nc. python script\\test.py --ci -c R_x64\r\n\r\n**Expected behavior**\r\nAll tests passed on x86 and x64\r\n\r\n**Actual behavior**\r\n**For x86: 1 test failed**\r\n**not ok 126** BrowserWindow module \"webPreferences\" option nativeWindowOpen option blocks accessing cross-origin frames\r\n Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\n at D:\\Electron\\src\\spec\\node_modules\\mocha\\lib\\runnable.js:232:19\r\n\r\n**For x64: 5 tests failed**\r\n**not ok 116** BrowserWindow module \"webPreferences\" option nativeWindowOpen option blocks accessing cross-origin frames\r\n Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\n at D:\\Electron\\src\\spec\\node_modules\\mocha\\lib\\runnable.js:232:19\r\n**not ok 118** BrowserWindow module \"webPreferences\" option nativeWindowOpen option loads native addons correctly after reload\r\n Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\n at D:\\Electron\\src\\spec\\node_modules\\mocha\\lib\\runnable.js:232:19\r\n**not ok 668** modules support third-party module runas can be required in renderer\r\n Error: A dynamic link library (DLL) initialization routine failed. \r\n \\\\?\\D:\\Electron\\src\\spec\\node_modules\\runas\\build\\Release\\runas.node\r\n at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:173:20)\r\n at Object.Module._extensions..node (module.js:598:18)\r\n at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:173:20)\r\n at Module.load (module.js:488:32)\r\n at tryModuleLoad (module.js:447:12)\r\n at Function.Module._load (module.js:439:3)\r\n at Module.require (module.js:498:17)\r\n at require (internal/module.js:20:19)\r\n at Object. (D:\\Electron\\src\\spec\\node_modules\\runas\\lib\\runas.js:4:11)\r\n at Object. (D:\\Electron\\src\\spec\\node_modules\\runas\\lib\\runas.js:47:4)\r\n**not ok 669** modules support third-party module runas can be required in node binary\r\n AssertionError: 'A dynamic link library (DLL) initialization routine failed.\\r\\n\\\\\\\\?\\\\D:\\\\Electron\\\\src\\\\spec\\\\node_modules\\\\runas\\\\build\\\\Rele == 'ok'\r\n at ChildProcess. (D:\\Electron\\src\\spec\\modules-spec.js:25:18)\r\n at emitTwo (events.js:106:13)\r\n at ChildProcess.emit (events.js:194:7)\r\n at process.nextTick (internal/child_process.js:766:12)\r\n at _combinedTickCallback (internal/process/next_tick.js:73:7)\r\n at process._tickCallback (internal/process/next_tick.js:104:9)\r\n**not ok 723** tag nodeintegration attribute loads native modules when navigation happens\r\n AssertionError: 'Uncaught Error: A dynamic link library (DLL) initialization routine failed.\\r\\n\\\\\\\\?\\\\D:\\\\Electron\\\\src\\\\spec\\\\node_modules\\\\ru == 'function'\r\n at HTMLElement.listener2 (D:\\Electron\\src\\spec\\webview-spec.js:181:18)\r\n at WebViewImpl.dispatchEvent (D:\\Electron\\src\\out\\R_x64\\resources\\electron.asar\\renderer\\web-view\\web-view.js:175:22)\r\n at dispatchEvent (D:\\Electron\\src\\out\\R_x64\\resources\\electron.asar\\renderer\\web-view\\guest-view-internal.js:55:11)\r\n at EventEmitter. (D:\\Electron\\src\\out\\R_x64\\resources\\electron.asar\\renderer\\web-view\\guest-view-internal.js:72:7)\r\n at emitMany (events.js:127:13)\r\n at EventEmitter.emit (events.js:204:7)" }, { "url": "https://api.github.com/repos/electron/electron/issues/9650", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9650/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9650/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9650/events", "html_url": "https://github.com/electron/electron/issues/9650", "id": 233060616, "number": 9650, "title": "asar support for Tray Icon", "user": { "login": "zh99998", "id": 359622, "avatar_url": "https://avatars2.githubusercontent.com/u/359622?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zh99998", "html_url": "https://github.com/zh99998", "followers_url": "https://api.github.com/users/zh99998/followers", "following_url": "https://api.github.com/users/zh99998/following{/other_user}", "gists_url": "https://api.github.com/users/zh99998/gists{/gist_id}", "starred_url": "https://api.github.com/users/zh99998/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zh99998/subscriptions", "organizations_url": "https://api.github.com/users/zh99998/orgs", "repos_url": "https://api.github.com/users/zh99998/repos", "events_url": "https://api.github.com/users/zh99998/events{/privacy}", "received_events_url": "https://api.github.com/users/zh99998/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-06-02T02:34:31Z", "updated_at": "2017-06-06T01:57:43Z", "closed_at": "2017-06-06T01:57:43Z", "body": "\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: Windows\r\n\r\n### Expected behavior\r\n\r\n\r\nload Tray icon from asar package\r\n### Actual behavior\r\n\r\n\r\n![image](https://cloud.githubusercontent.com/assets/359622/26708549/036ac2fc-477f-11e7-8ee6-cb3c359e1864.png)\r\n\r\n### How to reproduce\r\n```javascript\r\nnew Tray('images/icon.ico')\r\n```\r\nin a asar-packaged app\r\n\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9649", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9649/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9649/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9649/events", "html_url": "https://github.com/electron/electron/issues/9649", "id": 233046955, "number": 9649, "title": "crash when creating remote object in sandboxed renderer", "user": { "login": "lneir", "id": 1760440, "avatar_url": "https://avatars2.githubusercontent.com/u/1760440?v=3", "gravatar_id": "", "url": "https://api.github.com/users/lneir", "html_url": "https://github.com/lneir", "followers_url": "https://api.github.com/users/lneir/followers", "following_url": "https://api.github.com/users/lneir/following{/other_user}", "gists_url": "https://api.github.com/users/lneir/gists{/gist_id}", "starred_url": "https://api.github.com/users/lneir/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lneir/subscriptions", "organizations_url": "https://api.github.com/users/lneir/orgs", "repos_url": "https://api.github.com/users/lneir/repos", "events_url": "https://api.github.com/users/lneir/events{/privacy}", "received_events_url": "https://api.github.com/users/lneir/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-02T00:36:43Z", "updated_at": "2017-06-19T19:34:45Z", "closed_at": null, "body": "* Electron version: 1.6.11\r\n* Operating system: MacOS Sierrra (10.12.5)\r\n\r\n### behavior\r\n\r\nTrying to create remote object in sandboxed renderer will fail if an Object tag (or iframe) is added to the dom then removed. Adding Object tag to the dom causes preload to get invoked because this creates a new JS context and I presume removing appears frees up context and somehow messes up lifetime of remote. Also this bug will happen if an iframe is loaded (with same domain as parent).\r\n\r\n### How to reproduce\r\n\r\nThis repo demonstrates the issue...\r\n\r\nhttps://github.com/lneir/electron-remote-constructor-crash\r\n\r\nThis bug seems to have been introduced in 1.6.7. It doesn't happen right away there but will occur if repo steps are repeated a few times. It happens first time in 1.6.11 and also 1.7.2. This issue does not happen when sandbox is turned off for main window.\r\n\r\nThe error message seen in console is:\r\nUncaught Error: Cannot call constructor on missing remote object 6\r\n\r\nThe error is being produced in main process by code: https://github.com/electron/electron/blob/master/lib/browser/rpc-server.js#L303\r\n\r\nAppears that main process is somehow removing entry in \"objectsRegistry\"\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9648", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9648/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9648/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9648/events", "html_url": "https://github.com/electron/electron/pull/9648", "id": 232929507, "number": 9648, "title": "Integrity check for ASAR files", "user": { "login": "develar", "id": 350686, "avatar_url": "https://avatars3.githubusercontent.com/u/350686?v=3", "gravatar_id": "", "url": "https://api.github.com/users/develar", "html_url": "https://github.com/develar", "followers_url": "https://api.github.com/users/develar/followers", "following_url": "https://api.github.com/users/develar/following{/other_user}", "gists_url": "https://api.github.com/users/develar/gists{/gist_id}", "starred_url": "https://api.github.com/users/develar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/develar/subscriptions", "organizations_url": "https://api.github.com/users/develar/orgs", "repos_url": "https://api.github.com/users/develar/repos", "events_url": "https://api.github.com/users/develar/events{/privacy}", "received_events_url": "https://api.github.com/users/develar/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 18, "created_at": "2017-06-01T16:03:16Z", "updated_at": "2017-06-14T16:31:17Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9648", "html_url": "https://github.com/electron/electron/pull/9648", "diff_url": "https://github.com/electron/electron/pull/9648.diff", "patch_url": "https://github.com/electron/electron/pull/9648.patch" }, "body": "Addresses [Code Signing of ASAR files](https://github.com/electron/asar/issues/123).\r\n\r\n* Any application that uses external files as code sources are not protected and code signing doesn't make sense.\r\n* Anyone can use trusted app from trusted vendor as a template for malicious app.\r\n * macOS: Static validation failed (when you manually check using codesign tool or another tools), dynamic (performed on run for quarantined apps) passed.\r\n * Windows: no app bundle concept at all, no way to statically check app, no dynamic validation at all. Nothing prevents.\r\n* Java, Electron apps are affected. \r\n\r\nHow do we can fix it?\r\n\r\n1. Embedding code sources into the executables.\r\n 1.1 Modifying existing executable.\r\n * macOS: [Not possible](https://stackoverflow.com/questions/4022495/how-can-i-add-sections-to-an-existing-os-x-executable).\r\n * Windows: using windows resources.\r\n\r\n As it is not possible on macOS, this approach is rejected.\r\n\r\n 1.2 Linking during build. It will complicate Electron app development. Another approach should be used.\r\n\r\n So, although embedding code sources into the executables approach is the most secured, price is too high. \r\n\r\n2. Really sign ASAR file and verify on ASAR file load. Well, implementation will be complex and fragile (very easy to verify code integrity, but identity validation...). So, this approach is rejected.\r\n\r\n3. Keep code integrity data in the application manifest and verify only integrity on ASAR file load. As application manifest is a part of executable file (Windows) and `Info.plist` is a part of application bundle (macOS), we don't need to verify identity and so, our implementation is robust and straightforward. If integrity data will be changed — code signature will be broken and application will be marked as damaged by OS.\r\n\r\nThird approach, \"code integrity data in the application manifest\", is implemented in this PR.\r\n\r\nSome notes:\r\n* macOS specific: Depending on not yet known reasons even modified Info.plist is not a reason to prevent run on macOS sometimes. Under some conditions app is marked as damaged, but under another conditions not (interestingly, in both cases app is quarantined (`com.apple.quarantine`, can be checked using `xattr` tool)). Well, it doesn't invalidate the whole idea of this PR:\r\n * small amount of data can be embedded into existing Mach-O object file if will be proven that `Info.plist` is not really secured. So, it can be implemented later if need.\r\n * static validation is not passed (since code signature will be broken), so, user has ability to verify application using standard tools.\r\n* sha512 is used because [it is faster](https://crypto.stackexchange.com/questions/26336/sha512-faster-than-sha256) than sha256 on x64 machines.\r\n * 5MB hashed in 4ms, 30MB hashed in 45ms. So, integrity check doesn't slow down app loading.\r\n* macOS specific: Officially [not recommended](https://developer.apple.com/library/content/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG201) to sign non-Mach-O executables. So, unlikely PR to `electron-osx-sign` will be filed to sign ASAR files.\r\n* Windows is unsecured, even macOS Gatekeeper doesn't work as expected... Should we worry about code integrity if even checks on OS level so insecure? Well... no excuse for us. Integrity check is cheap, build process is not complicated. So, why not to make sure that on our level user is protected and we do our best to protect users?\r\n\r\nChecksums stored as JSON object under the key `AsarChecksums`. If key not specified — no integrity check. `electron-builder` (asar is enabled by default) will add integrity data on build (will be implemented as separated npm module to reuse this logic in other build tools).\r\n\r\nImplemented for macOS only for now, I want to hear your feedback.\r\n\r\nupdate 1: macOS performs full static validation on first run of downloaded application. So, changes in this PR not \"should\", but \"must\" be implemented (planned fix on `electron-osx-sign` under investigation)." }, { "url": "https://api.github.com/repos/electron/electron/issues/9647", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9647/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9647/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9647/events", "html_url": "https://github.com/electron/electron/issues/9647", "id": 232848136, "number": 9647, "title": "Webview redirect fails to load", "user": { "login": "lukeapage", "id": 309321, "avatar_url": "https://avatars2.githubusercontent.com/u/309321?v=3", "gravatar_id": "", "url": "https://api.github.com/users/lukeapage", "html_url": "https://github.com/lukeapage", "followers_url": "https://api.github.com/users/lukeapage/followers", "following_url": "https://api.github.com/users/lukeapage/following{/other_user}", "gists_url": "https://api.github.com/users/lukeapage/gists{/gist_id}", "starred_url": "https://api.github.com/users/lukeapage/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lukeapage/subscriptions", "organizations_url": "https://api.github.com/users/lukeapage/orgs", "repos_url": "https://api.github.com/users/lukeapage/repos", "events_url": "https://api.github.com/users/lukeapage/events{/privacy}", "received_events_url": "https://api.github.com/users/lukeapage/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2017-06-01T11:25:57Z", "updated_at": "2017-06-01T12:24:06Z", "closed_at": "2017-06-01T12:24:06Z", "body": "* Electron version: \r\n1.7.2 - OK\r\n1.6.11 - has bug\r\n1.6.3 - has bug\r\n1.6.2 - does not appear to have bug, but has other instabilities\r\n1.5.1 - OK\r\n1.3.x and before - OK\r\n* Operating system: Windows 8\r\n\r\n### Expected behavior\r\n\r\nPage should redirect ok as it used to..\r\n\r\n### Actual behavior\r\n\r\nAt some point during redirect, the page fails to load. This shows the did-load-fail event occuring after a did-navigate.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/309321/26677670/42c48404-46cd-11e7-81e6-0990ddf3b369.png)\r\n\r\nThe bug occurs 1 time in 2, but on a different redirect each time.\r\n\r\nAs well as getting load fail, the webview does not render anything and if devtools is attached to the window, it shows a disconnected message.\r\n\r\nAccording the fiddler the page that the webview emits a load fail on is fetched successfully - no network problems with the page.\r\n\r\nI've investigated if it could be:\r\n#8505 but changing the webview to always be visible doesn't help\r\n#6139 but disabling hardware acceleration does not help\r\n\r\nI've looked up the error code 0 and error status \"OK\" and can't find any info about what might cause it.\r\n\r\nAny help debugging or diagnosing would be appreciated." }, { "url": "https://api.github.com/repos/electron/electron/issues/9646", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9646/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9646/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9646/events", "html_url": "https://github.com/electron/electron/issues/9646", "id": 232832759, "number": 9646, "title": "Exit code 3221225477 - IsSandboxedProcess / GetHandleVerifier", "user": { "login": "fasterthanlime", "id": 7998310, "avatar_url": "https://avatars3.githubusercontent.com/u/7998310?v=3", "gravatar_id": "", "url": "https://api.github.com/users/fasterthanlime", "html_url": "https://github.com/fasterthanlime", "followers_url": "https://api.github.com/users/fasterthanlime/followers", "following_url": "https://api.github.com/users/fasterthanlime/following{/other_user}", "gists_url": "https://api.github.com/users/fasterthanlime/gists{/gist_id}", "starred_url": "https://api.github.com/users/fasterthanlime/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fasterthanlime/subscriptions", "organizations_url": "https://api.github.com/users/fasterthanlime/orgs", "repos_url": "https://api.github.com/users/fasterthanlime/repos", "events_url": "https://api.github.com/users/fasterthanlime/events{/privacy}", "received_events_url": "https://api.github.com/users/fasterthanlime/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-06-01T10:21:25Z", "updated_at": "2017-06-03T11:05:55Z", "closed_at": null, "body": "* Electron version: 1.7.2\r\n* Operating system: Windows 10.0.14393 Build 14393\r\n\r\n### Expected behavior\r\n\r\nElectron should hum happily.\r\n\r\n### Actual behavior\r\n\r\nElectron crashes with code 3221225477.\r\n\r\n### How to reproduce\r\n\r\nWell:\r\n\r\n```\r\n$ git clone https://github.com/itchio/itch -b get-handle-verifier\r\n$ yarn\r\n$ NODE_ENV=production yarn start\r\n```\r\n\r\n...but, it's a branch in the middle of a big rewrite, so it's not very reproduce-friendly. Plus, you need an itch.io account. Happens to me when scrolling through my 300+ games library, I'll see if I can gather a better repro case.\r\n\r\n```\r\nBacktrace:\r\n GetHandleVerifier [0x00007FF7BC0F518B+1439451]\r\n IsSandboxedProcess [0x00007FF7BC366384+564612]\r\n GetHandleVerifier [0x00007FF7BC0EFFF4+1418564]\r\n GetHandleVerifier [0x00007FF7BC0DF7F6+1350982]\r\n GetHandleVerifier [0x00007FF7BC0F07F1+1420609]\r\n IsSandboxedProcess [0x00007FF7BC30DF96+203158]\r\n IsSandboxedProcess [0x00007FF7BC43B880+1438336]\r\n GetHandleVerifier [0x00007FF7BC03977C+670924]\r\n GetHandleVerifier [0x00007FF7BBFDB986+286422]\r\n GetHandleVerifier [0x00007FF7BBFDA470+281024]\r\n GetHandleVerifier [0x00007FF7BC03A951+675489]\r\n GetHandleVerifier [0x00007FF7BC03B114+677476]\r\n GetHandleVerifier [0x00007FF7BBFD799E+270062]\r\n IsSandboxedProcess [0x00007FF7BC3D9FA2+1038754]\r\n IsSandboxedProcess [0x00007FF7BC3DB4EA+1044202]\r\n IsSandboxedProcess [0x00007FF7BC68E53A+3874618]\r\n IsSandboxedProcess [0x00007FF7BC671264+3755108]\r\n GetHandleVerifier [0x00007FF7BC2DB57D+3431117]\r\n GetHandleVerifier [0x00007FF7BC2DB474+3430852]\r\n GetHandleVerifier [0x00007FF7BC08E6A0+1018864]\r\n (No symbol) [0x00007FF7BBCF8464]\r\n IsSandboxedProcess [0x00007FF7BEF8B1AF+46853039]\r\n BaseThreadInitThunk [0x00007FFE61188364+20]\r\n RtlUserThreadStart [0x00007FFE63A970D1+33]\r\nerror Command failed with exit code 3221225477.\r\n```\r\n\r\n### Notes\r\n\r\nI've been keeping an eye on #3570 - it's the same error code (but it's a pretty generic one). I *do* have some require extension at play here since I'm using https://github.com/electron/electron-compile - so there's something in common between both issues at least." }, { "url": "https://api.github.com/repos/electron/electron/issues/9645", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9645/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9645/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9645/events", "html_url": "https://github.com/electron/electron/pull/9645", "id": 232775005, "number": 9645, "title": "Fix unresponsive app after fullscreen->normal state toggle (Windows)", "user": { "login": "dharders", "id": 16676192, "avatar_url": "https://avatars2.githubusercontent.com/u/16676192?v=3", "gravatar_id": "", "url": "https://api.github.com/users/dharders", "html_url": "https://github.com/dharders", "followers_url": "https://api.github.com/users/dharders/followers", "following_url": "https://api.github.com/users/dharders/following{/other_user}", "gists_url": "https://api.github.com/users/dharders/gists{/gist_id}", "starred_url": "https://api.github.com/users/dharders/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dharders/subscriptions", "organizations_url": "https://api.github.com/users/dharders/orgs", "repos_url": "https://api.github.com/users/dharders/repos", "events_url": "https://api.github.com/users/dharders/events{/privacy}", "received_events_url": "https://api.github.com/users/dharders/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "assignees": [ { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true } ], "milestone": null, "comments": 4, "created_at": "2017-06-01T06:10:09Z", "updated_at": "2017-06-15T03:29:13Z", "closed_at": "2017-06-14T21:10:00Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9645", "html_url": "https://github.com/electron/electron/pull/9645", "diff_url": "https://github.com/electron/electron/pull/9645.diff", "patch_url": "https://github.com/electron/electron/pull/9645.patch" }, "body": "Fixes #6036\r\n\r\n**Summary**\r\n\r\nIn **Windows only**, starting an app in the fullscreen state i.e. with the BrowserWindow options `{ fullscreen: true }` produces an unresponsive window after toggling to the normal window state. e.g. Pressing F11 or `setFullScreen(false)`. See issue #6036\r\n\r\nThe window visibility flag `WS_VISIBLE` is never set for the `GWL_STYLE` when we start in fullscreen mode. This fix simply detects the fullscreen->normal window state transition and checks if the window is visible (which it always should be). If it isn't, it sets the visibility to true. i.e. :\r\n\r\n```cpp\r\nvoid NativeWindowViews::SetFullScreen(bool fullscreen) {\r\n bool fullscreen_to_normal_detected = IsFullscreen() && !fullscreen;\r\n ...\r\n if (fullscreen_to_normal_detected && !IsVisible()) {\r\n LONG frame_style = ::GetWindowLong(GetAcceleratedWidget(), GWL_STYLE);\r\n frame_style |= WS_VISIBLE;\r\n ::SetWindowLong(GetAcceleratedWidget(), GWL_STYLE, frame_style);\r\n }\r\n ...\r\n}\r\n```\r\n\r\nIncludes tests (this branch passes, old behavior fails)\r\n\r\nFixes #6036" }, { "url": "https://api.github.com/repos/electron/electron/issues/9644", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9644/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9644/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9644/events", "html_url": "https://github.com/electron/electron/pull/9644", "id": 232773936, "number": 9644, "title": "Enable sandbox on webview", "user": { "login": "juturu", "id": 11049886, "avatar_url": "https://avatars1.githubusercontent.com/u/11049886?v=3", "gravatar_id": "", "url": "https://api.github.com/users/juturu", "html_url": "https://github.com/juturu", "followers_url": "https://api.github.com/users/juturu/followers", "following_url": "https://api.github.com/users/juturu/following{/other_user}", "gists_url": "https://api.github.com/users/juturu/gists{/gist_id}", "starred_url": "https://api.github.com/users/juturu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/juturu/subscriptions", "organizations_url": "https://api.github.com/users/juturu/orgs", "repos_url": "https://api.github.com/users/juturu/repos", "events_url": "https://api.github.com/users/juturu/events{/privacy}", "received_events_url": "https://api.github.com/users/juturu/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 12, "created_at": "2017-06-01T06:02:48Z", "updated_at": "2017-06-26T23:20:33Z", "closed_at": null, "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9644", "html_url": "https://github.com/electron/electron/pull/9644", "diff_url": "https://github.com/electron/electron/pull/9644.diff", "patch_url": "https://github.com/electron/electron/pull/9644.patch" }, "body": "Fixes #9611 " }, { "url": "https://api.github.com/repos/electron/electron/issues/9643", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9643/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9643/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9643/events", "html_url": "https://github.com/electron/electron/issues/9643", "id": 232733712, "number": 9643, "title": "Sandbox option from Electron doesnt not load a webpage", "user": { "login": "psh0628", "id": 28660230, "avatar_url": "https://avatars3.githubusercontent.com/u/28660230?v=3", "gravatar_id": "", "url": "https://api.github.com/users/psh0628", "html_url": "https://github.com/psh0628", "followers_url": "https://api.github.com/users/psh0628/followers", "following_url": "https://api.github.com/users/psh0628/following{/other_user}", "gists_url": "https://api.github.com/users/psh0628/gists{/gist_id}", "starred_url": "https://api.github.com/users/psh0628/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/psh0628/subscriptions", "organizations_url": "https://api.github.com/users/psh0628/orgs", "repos_url": "https://api.github.com/users/psh0628/repos", "events_url": "https://api.github.com/users/psh0628/events{/privacy}", "received_events_url": "https://api.github.com/users/psh0628/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-06-01T00:25:14Z", "updated_at": "2017-06-01T00:26:50Z", "closed_at": null, "body": "hi all,\r\n\r\nI tried to add Sandbox option into my project and spend some tome to get familiar to use sandbox (https://github.com/electron/electron/blob/master/docs/api/sandbox-option.md)\r\n\r\nwithout this option like command, \"electron main.js\" loaded successfully the webpage. However, \"electron --enable-sandbox main.js\" doesnt load the webpage at all. The following is my code. I really appreciate if you could give me any suggestion.\r\n\r\n\r\nmain.js\r\n=> \r\nconst electron = require('electron');\r\nconst app = electron.app;\r\nconst path = require('path');\r\n\r\nconst BrowserWindow = electron.BrowserWindow;\r\nlet win\r\napp.on('ready', () => {\r\n win = new BrowserWindow({\r\n webPreferences: {\r\n sandbox: true,\r\n preload: path.join(__dirname, 'preload.js')\r\n //preload: 'preload.js'\r\n }\r\n })\r\n win.loadURL('http://google.com')\r\n})\r\n\r\n\r\n\r\npreload.js\r\n=> \r\nconst fs = require('fs')\r\nconst {ipcRenderer} = require('electron')\r\n\r\nconst buf = fs.readFileSync('allowed-popup-urls.json')\r\n\r\nconst defaultWindowOpen = window.open\r\n\r\n function customWindowOpen (url, ...args) {\r\n console.log('custom window');\r\n // if (JSON.parse(buf.toString('utf8')).indexOf(url) === -1) {\r\n // ipcRenderer.sendSync('blocked-popup-notification', location.origin, url)\r\n // return null\r\n // }\r\n // return defaultWindowOpen(url, ...args)\r\n }\r\n\r\n window.open = customWindowOpen\r\n\r\nprocess.once('loaded', function () {\r\n console.log('loaded');\r\n});\r\n\r\n\r\ntest.html\r\n=>\r\n \r\n\r\n\r\n\r\n\r\n

Hello Wrold

\r\n\r\n\r\n\r\n\r\nallowed-popup-urls.json\r\n=> [\"www.msn.com\", \"www.yahoo.com\"]" }, { "url": "https://api.github.com/repos/electron/electron/issues/9642", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9642/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9642/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9642/events", "html_url": "https://github.com/electron/electron/issues/9642", "id": 232710616, "number": 9642, "title": "Add support for SVG tray icons on Linux", "user": { "login": "stewartlord", "id": 218503, "avatar_url": "https://avatars0.githubusercontent.com/u/218503?v=3", "gravatar_id": "", "url": "https://api.github.com/users/stewartlord", "html_url": "https://github.com/stewartlord", "followers_url": "https://api.github.com/users/stewartlord/followers", "following_url": "https://api.github.com/users/stewartlord/following{/other_user}", "gists_url": "https://api.github.com/users/stewartlord/gists{/gist_id}", "starred_url": "https://api.github.com/users/stewartlord/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stewartlord/subscriptions", "organizations_url": "https://api.github.com/users/stewartlord/orgs", "repos_url": "https://api.github.com/users/stewartlord/repos", "events_url": "https://api.github.com/users/stewartlord/events{/privacy}", "received_events_url": "https://api.github.com/users/stewartlord/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 205529029, "url": "https://api.github.com/repos/electron/electron/labels/component/tray", "name": "component/tray", "color": "f9d0c4", "default": false }, { "id": 35575880, "url": "https://api.github.com/repos/electron/electron/labels/enhancement", "name": "enhancement", "color": "84b6eb", "default": true }, { "id": 97403642, "url": "https://api.github.com/repos/electron/electron/labels/platform/linux", "name": "platform/linux", "color": "c7def8", "default": false } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-05-31T22:04:45Z", "updated_at": "2017-06-05T22:36:42Z", "closed_at": null, "body": "\r\n\r\n* Electron version: 1.6.10\r\n* Operating system: elementary OS 0.4.1 Loki\r\n\r\n### Expected behavior\r\n\r\nIt should be possible to set a tray image in SVG format. This would allow tray icons to adapt to the current theme (ie. appear white on black, or black on white).\r\n\r\n### Actual behavior\r\n\r\nThe image must be supplied as a PNG or a JPG and therefore does not adapt to the platform's theme.\r\n\r\n### How to reproduce\r\n\r\n```\r\nnew Tray('/path/to/image.png');\r\n```\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9641", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9641/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9641/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9641/events", "html_url": "https://github.com/electron/electron/issues/9641", "id": 232677174, "number": 9641, "title": "checkboxLabel in dialog not working?", "user": { "login": "gielcobben", "id": 2663212, "avatar_url": "https://avatars3.githubusercontent.com/u/2663212?v=3", "gravatar_id": "", "url": "https://api.github.com/users/gielcobben", "html_url": "https://github.com/gielcobben", "followers_url": "https://api.github.com/users/gielcobben/followers", "following_url": "https://api.github.com/users/gielcobben/following{/other_user}", "gists_url": "https://api.github.com/users/gielcobben/gists{/gist_id}", "starred_url": "https://api.github.com/users/gielcobben/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gielcobben/subscriptions", "organizations_url": "https://api.github.com/users/gielcobben/orgs", "repos_url": "https://api.github.com/users/gielcobben/repos", "events_url": "https://api.github.com/users/gielcobben/events{/privacy}", "received_events_url": "https://api.github.com/users/gielcobben/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 9, "created_at": "2017-05-31T19:54:46Z", "updated_at": "2017-05-31T20:34:39Z", "closed_at": "2017-05-31T20:32:34Z", "body": "This is my code:\r\n\r\n```\r\n showNothingFoundDialog() {\r\n const dialog = remote.dialog;\r\n const options = {\r\n type: \"question\",\r\n buttons: [\"OK\", \"Cancel\"],\r\n message: \"This is a test.\",\r\n checkboxLabel: \"Do not show this message again.\"\r\n };\r\n\r\n dialog.showMessageBox(options, (response, checkboxChecked) => {\r\n console.log(response, checkboxChecked);\r\n });\r\n }\r\n```\r\n\r\nAnd this is the result:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/2663212/26650958/73c15bae-464b-11e7-88d4-272c098acda1.png)\r\n\r\nI use Electron v1.6.10." }, { "url": "https://api.github.com/repos/electron/electron/issues/9640", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9640/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9640/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9640/events", "html_url": "https://github.com/electron/electron/pull/9640", "id": 232665613, "number": 9640, "title": "bump ts linter with fixes for numeric keys", "user": { "login": "zeke", "id": 2289, "avatar_url": "https://avatars2.githubusercontent.com/u/2289?v=3", "gravatar_id": "", "url": "https://api.github.com/users/zeke", "html_url": "https://github.com/zeke", "followers_url": "https://api.github.com/users/zeke/followers", "following_url": "https://api.github.com/users/zeke/following{/other_user}", "gists_url": "https://api.github.com/users/zeke/gists{/gist_id}", "starred_url": "https://api.github.com/users/zeke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zeke/subscriptions", "organizations_url": "https://api.github.com/users/zeke/orgs", "repos_url": "https://api.github.com/users/zeke/repos", "events_url": "https://api.github.com/users/zeke/events{/privacy}", "received_events_url": "https://api.github.com/users/zeke/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2017-05-31T19:10:01Z", "updated_at": "2017-05-31T22:18:55Z", "closed_at": "2017-05-31T22:16:57Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9640", "html_url": "https://github.com/electron/electron/pull/9640", "diff_url": "https://github.com/electron/electron/pull/9640.diff", "patch_url": "https://github.com/electron/electron/pull/9640.patch" }, "body": "Explicit bump to get TypeScript file generation working on master for everyone.\r\n\r\nDetails at https://github.com/electron/electron-typescript-definitions/pull/61" }, { "url": "https://api.github.com/repos/electron/electron/issues/9639", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9639/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9639/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9639/events", "html_url": "https://github.com/electron/electron/issues/9639", "id": 232659750, "number": 9639, "title": "test", "user": { "login": "lbonillaii", "id": 7102177, "avatar_url": "https://avatars0.githubusercontent.com/u/7102177?v=3", "gravatar_id": "", "url": "https://api.github.com/users/lbonillaii", "html_url": "https://github.com/lbonillaii", "followers_url": "https://api.github.com/users/lbonillaii/followers", "following_url": "https://api.github.com/users/lbonillaii/following{/other_user}", "gists_url": "https://api.github.com/users/lbonillaii/gists{/gist_id}", "starred_url": "https://api.github.com/users/lbonillaii/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lbonillaii/subscriptions", "organizations_url": "https://api.github.com/users/lbonillaii/orgs", "repos_url": "https://api.github.com/users/lbonillaii/repos", "events_url": "https://api.github.com/users/lbonillaii/events{/privacy}", "received_events_url": "https://api.github.com/users/lbonillaii/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-05-31T18:47:40Z", "updated_at": "2017-05-31T18:48:14Z", "closed_at": "2017-05-31T18:48:14Z", "body": "" }, { "url": "https://api.github.com/repos/electron/electron/issues/9638", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9638/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9638/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9638/events", "html_url": "https://github.com/electron/electron/issues/9638", "id": 232650476, "number": 9638, "title": "Virtual File Drag & Drop Events", "user": { "login": "felixrieseberg", "id": 1426799, "avatar_url": "https://avatars0.githubusercontent.com/u/1426799?v=3", "gravatar_id": "", "url": "https://api.github.com/users/felixrieseberg", "html_url": "https://github.com/felixrieseberg", "followers_url": "https://api.github.com/users/felixrieseberg/followers", "following_url": "https://api.github.com/users/felixrieseberg/following{/other_user}", "gists_url": "https://api.github.com/users/felixrieseberg/gists{/gist_id}", "starred_url": "https://api.github.com/users/felixrieseberg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/felixrieseberg/subscriptions", "organizations_url": "https://api.github.com/users/felixrieseberg/orgs", "repos_url": "https://api.github.com/users/felixrieseberg/repos", "events_url": "https://api.github.com/users/felixrieseberg/events{/privacy}", "received_events_url": "https://api.github.com/users/felixrieseberg/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 593553044, "url": "https://api.github.com/repos/electron/electron/labels/component/drag-and-drop", "name": "component/drag-and-drop", "color": "f9d0c4", "default": false }, { "id": 35575880, "url": "https://api.github.com/repos/electron/electron/labels/enhancement", "name": "enhancement", "color": "84b6eb", "default": true } ], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-05-31T18:13:07Z", "updated_at": "2017-05-31T20:47:22Z", "closed_at": null, "body": "Many drag and drop operations contain virtual file data. Chrome currently only accepts files on disk. This means that you can't drag images directly from a browser into an Electron app. The same is true for e-mails in Outlook/Mail.app, entries in Calendar apps, etc.\r\n\r\n* Electron version: All\r\n* Operating system: macOS, Windows, Linux\r\n\r\n### Expected behavior\r\nWhen a virtual file is dropped on an Electron app, the developer should have some means of retrieving the data.\r\n\r\n### Actual behavior\r\nChrome only handles `CF_HDROP` data (and it seems like that won't change anytime soon), so we might have to help ourselves here. The drop event is received, but all data fields are empty.\r\n\r\n### How to reproduce\r\nLoad http://html5demos.com/file-api in an electron app. Try to drag an image from Chrome into the upload area. The cursor will change, the image will be \"dragged\", but no data will be received." }, { "url": "https://api.github.com/repos/electron/electron/issues/9637", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9637/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9637/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9637/events", "html_url": "https://github.com/electron/electron/issues/9637", "id": 232645351, "number": 9637, "title": "dialog.showMessageBox not displaying modal window in windows", "user": { "login": "tdhawan", "id": 7579946, "avatar_url": "https://avatars0.githubusercontent.com/u/7579946?v=3", "gravatar_id": "", "url": "https://api.github.com/users/tdhawan", "html_url": "https://github.com/tdhawan", "followers_url": "https://api.github.com/users/tdhawan/followers", "following_url": "https://api.github.com/users/tdhawan/following{/other_user}", "gists_url": "https://api.github.com/users/tdhawan/gists{/gist_id}", "starred_url": "https://api.github.com/users/tdhawan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tdhawan/subscriptions", "organizations_url": "https://api.github.com/users/tdhawan/orgs", "repos_url": "https://api.github.com/users/tdhawan/repos", "events_url": "https://api.github.com/users/tdhawan/events{/privacy}", "received_events_url": "https://api.github.com/users/tdhawan/received_events", "type": "User", "site_admin": false }, "labels": [], "state": "open", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 0, "created_at": "2017-05-31T17:53:45Z", "updated_at": "2017-05-31T17:53:45Z", "closed_at": null, "body": "\r\n\r\nElectron version:1.6.7\r\nOperating system: Mac OS 10.12.4\r\n\r\n### Expected behavior\r\n\r\ndialog.showMessageBox should show a modal window. if the action is not taken on the modal window, the other windows/ app should not close.\r\n\r\n\r\n### Actual behavior\r\n\r\n1. app modal works in macOS when we use this implementation : dialog.showMessageBox(options: ShowMessageBoxOptions, callback?: (response: number) => void): number;\r\nhowever its NOT WORKING in win32\r\n\r\n2. app modal works in win32 when we use this implementation: \t\tdialog.showMessageBox(browserWindow: BrowserWindow, options: ShowMessageBoxOptions, callback?: (response: number) => void): number;\r\nhowever its NOT WORKING in macOS\r\n\r\nSo, we have to make these 2 separate calls depending on platform. ideally it should be just one call, that should create the modal window regardless of the operating systems.\r\n\r\n\r\n### How to reproduce\r\n\r\n1. implement a modal window with this call \r\ndialog.showMessageBox(options, callback);\r\nit will work as modal window in macOS, not in win32\r\n\r\n2. implement a modal window with this call \r\ndialog.showMessageBox(browserWindow, options, callback);\r\nit will work as modal window in win32, not in macOS\r\n-->\r\n" }, { "url": "https://api.github.com/repos/electron/electron/issues/9636", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9636/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9636/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9636/events", "html_url": "https://github.com/electron/electron/pull/9636", "id": 232641246, "number": 9636, "title": "Add return type to systemPreferences.isAeroGlassEnabled()", "user": { "login": "kevinsawicki", "id": 671378, "avatar_url": "https://avatars0.githubusercontent.com/u/671378?v=3", "gravatar_id": "", "url": "https://api.github.com/users/kevinsawicki", "html_url": "https://github.com/kevinsawicki", "followers_url": "https://api.github.com/users/kevinsawicki/followers", "following_url": "https://api.github.com/users/kevinsawicki/following{/other_user}", "gists_url": "https://api.github.com/users/kevinsawicki/gists{/gist_id}", "starred_url": "https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinsawicki/subscriptions", "organizations_url": "https://api.github.com/users/kevinsawicki/orgs", "repos_url": "https://api.github.com/users/kevinsawicki/repos", "events_url": "https://api.github.com/users/kevinsawicki/events{/privacy}", "received_events_url": "https://api.github.com/users/kevinsawicki/received_events", "type": "User", "site_admin": true }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 1, "created_at": "2017-05-31T17:38:19Z", "updated_at": "2017-05-31T22:45:30Z", "closed_at": "2017-05-31T20:22:30Z", "pull_request": { "url": "https://api.github.com/repos/electron/electron/pulls/9636", "html_url": "https://github.com/electron/electron/pull/9636", "diff_url": "https://github.com/electron/electron/pull/9636.diff", "patch_url": "https://github.com/electron/electron/pull/9636.patch" }, "body": "Noticed this was listed as `void` in the `electron.d.ts` file." }, { "url": "https://api.github.com/repos/electron/electron/issues/9635", "repository_url": "https://api.github.com/repos/electron/electron", "labels_url": "https://api.github.com/repos/electron/electron/issues/9635/labels{/name}", "comments_url": "https://api.github.com/repos/electron/electron/issues/9635/comments", "events_url": "https://api.github.com/repos/electron/electron/issues/9635/events", "html_url": "https://github.com/electron/electron/issues/9635", "id": 232636491, "number": 9635, "title": "Crash error in video streaming on a custom protocol", "user": { "login": "pfrazee", "id": 1270099, "avatar_url": "https://avatars1.githubusercontent.com/u/1270099?v=3", "gravatar_id": "", "url": "https://api.github.com/users/pfrazee", "html_url": "https://github.com/pfrazee", "followers_url": "https://api.github.com/users/pfrazee/followers", "following_url": "https://api.github.com/users/pfrazee/following{/other_user}", "gists_url": "https://api.github.com/users/pfrazee/gists{/gist_id}", "starred_url": "https://api.github.com/users/pfrazee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pfrazee/subscriptions", "organizations_url": "https://api.github.com/users/pfrazee/orgs", "repos_url": "https://api.github.com/users/pfrazee/repos", "events_url": "https://api.github.com/users/pfrazee/events{/privacy}", "received_events_url": "https://api.github.com/users/pfrazee/received_events", "type": "User", "site_admin": false }, "labels": [ { "id": 227722189, "url": "https://api.github.com/repos/electron/electron/labels/component/protocol", "name": "component/protocol", "color": "f9d0c4", "default": false }, { "id": 144752898, "url": "https://api.github.com/repos/electron/electron/labels/fixme/crash", "name": "fixme/crash", "color": "fc2929", "default": false }, { "id": 538879644, "url": "https://api.github.com/repos/electron/electron/labels/fixme/regression", "name": "fixme/regression", "color": "fc2929", "default": false } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2017-05-31T17:19:34Z", "updated_at": "2017-06-23T14:18:37Z", "closed_at": "2017-06-23T10:09:15Z", "body": "* Electron version: 1.7.1\r\n* Operating system: MacOS 10.12.5\r\n\r\nRendering a `