From 45891aa75b77061edc548dd142f4ccf8a5deae4d Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 7 Aug 2024 10:01:59 +0200 Subject: [PATCH] build: fix patchup logic only running on one platform (#43139) --- .github/actions/checkout/action.yml | 2 +- .github/workflows/build.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/checkout/action.yml b/.github/actions/checkout/action.yml index 0a20bc90f2..869c6b32c5 100644 --- a/.github/actions/checkout/action.yml +++ b/.github/actions/checkout/action.yml @@ -75,7 +75,7 @@ runs: "$GITHUB_SERVER_URL/$GITHUB_REPOSITORY" ELECTRON_USE_THREE_WAY_MERGE_FOR_PATCHES=1 gclient sync --with_branch_heads --with_tags -vvvvv - if [ "${{ inputs.is-release }}" != "true" ]; then + if [ "${{ inputs.is-release }}" != "true" && -n "${{ env.PATCH_UP_APP_CREDS }}" ]; then # Re-export all the patches to check if there were changes. python3 src/electron/script/export_all_patches.py src/electron/patches/config.json cd src/electron diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index becc12f312..9ad0e26789 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -90,7 +90,6 @@ jobs: - /var/run/sas:/var/run/sas env: GCLIENT_EXTRA_ARGS: '--custom-var=checkout_mac=True --custom-var=host_os=mac' - PATCH_UP_APP_CREDS: ${{ secrets.PATCH_UP_APP_CREDS }} outputs: build-image-sha: ${{ needs.setup.outputs.build-image-sha }} steps: @@ -116,6 +115,7 @@ jobs: - /var/run/sas:/var/run/sas env: GCLIENT_EXTRA_ARGS: '--custom-var=checkout_arm=True --custom-var=checkout_arm64=True' + PATCH_UP_APP_CREDS: ${{ secrets.PATCH_UP_APP_CREDS }} outputs: build-image-sha: ${{ needs.setup.outputs.build-image-sha}} steps: