From 4b674c1daf2c291c2459925ed417dfdbd930ddb8 Mon Sep 17 00:00:00 2001
From: Samuel Attard <sattard@slack-corp.com>
Date: Wed, 3 Jul 2019 16:36:59 -0700
Subject: [PATCH] build: ensure that we bundle the correct version of
 @types/node (#19102)

---
 npm/package.json        |  2 +-
 spec-main/types-spec.ts | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 spec-main/types-spec.ts

diff --git a/npm/package.json b/npm/package.json
index 43bb4a6982..694e63385f 100644
--- a/npm/package.json
+++ b/npm/package.json
@@ -9,7 +9,7 @@
   },
   "dependencies": {
     "@electron/get": "^1.0.1",
-    "@types/node": "^10.12.18",
+    "@types/node": "^12.0.12",
     "extract-zip": "^1.0.3"
   },
   "engines": {
diff --git a/spec-main/types-spec.ts b/spec-main/types-spec.ts
new file mode 100644
index 0000000000..b0de8df6f1
--- /dev/null
+++ b/spec-main/types-spec.ts
@@ -0,0 +1,10 @@
+import { expect } from 'chai'
+
+describe('bundled @types/node', () => {
+  it('should match the major version of bundled node', () => {
+    expect(require('../npm/package.json').dependencies).to.have.property('@types/node')
+    const range = require('../npm/package.json').dependencies['@types/node']
+    expect(range).to.match(/^\^.+/, 'should allow any type dep in a major range')
+    expect(range.slice(1).split('.')[0]).to.equal(process.versions.node.split('.')[0])
+  })
+})