зеркало из https://github.com/electron/electron.git
ci: improve blocked/need-repro workflow (#39451)
* ci: improve blocked/need-repro workflow * ci: let maintainer comments suppress bot comment * ci: ensure failures bubble up
This commit is contained in:
Родитель
813853297d
Коммит
5d11c30720
|
@ -38,15 +38,29 @@ jobs:
|
||||||
issues: write # for actions-cool/issues-helper to update issues
|
issues: write # for actions-cool/issues-helper to update issues
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
|
- name: Check if comment needed
|
||||||
|
id: check-for-comment
|
||||||
|
env:
|
||||||
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
GH_REPO: electron/electron
|
||||||
|
run: |
|
||||||
|
set -eo pipefail
|
||||||
|
COMMENT_COUNT=$(gh issue view ${{ github.event.issue.number }} --comments --json comments | jq '[ .comments[] | select(.author.login == "github-actions" or .authorAssociation == "OWNER" or .authorAssociation == "MEMBER") | select(.body | startswith("<!-- blocked/need-repro -->")) ] | length')
|
||||||
|
if [[ $COMMENT_COUNT -eq 0 ]]; then
|
||||||
|
echo "SHOULD_COMMENT=1" >> "$GITHUB_OUTPUT"
|
||||||
|
fi
|
||||||
- name: Create comment
|
- name: Create comment
|
||||||
uses: actions-cool/issues-helper@dad28fdb88da5f082c04659b7373d85790f9b135 # v3.3.0
|
if: ${{ steps.check-for-comment.outputs.SHOULD_COMMENT }}
|
||||||
|
uses: actions-cool/issues-helper@275328970dbc3bfc3bc43f5fe741bf3638300c0a # v3.3.3
|
||||||
with:
|
with:
|
||||||
actions: 'create-comment'
|
actions: 'create-comment'
|
||||||
body: |
|
body: |
|
||||||
|
<!-- blocked/need-repro -->
|
||||||
|
|
||||||
Hello @${{ github.event.issue.user.login }}. Thanks for reporting this and helping to make Electron better!
|
Hello @${{ github.event.issue.user.login }}. Thanks for reporting this and helping to make Electron better!
|
||||||
|
|
||||||
Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, [Electron Fiddle](https://www.electronjs.org/fiddle) is a great tool for making small test cases and makes it easy to publish your test case to a [gist](https://gist.github.com) that Electron maintainers can use.
|
Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, [Electron Fiddle](https://www.electronjs.org/fiddle) is a great tool for making small test cases and makes it easy to publish your test case to a [gist](https://gist.github.com) that Electron maintainers can use.
|
||||||
|
|
||||||
Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.
|
Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.
|
||||||
|
|
||||||
Now adding the `blocked/need-repro` label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.
|
Now adding the https://github.com/electron/electron/labels/blocked%2Fneed-repro label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.
|
||||||
|
|
Загрузка…
Ссылка в новой задаче