diff --git a/patches/node/.patches b/patches/node/.patches index c0ffa7f81d..a222f4a950 100644 --- a/patches/node/.patches +++ b/patches/node/.patches @@ -34,3 +34,4 @@ fix_expose_lookupandcompile_with_parameters.patch fix_prevent_changing_functiontemplateinfo_after_publish.patch enable_crashpad_linux_node_processes.patch allow_embedder_to_control_codegenerationfromstringscallback.patch +test_mark_cpu_prof_tests_as_flaky_in_electron.patch diff --git a/patches/node/test_mark_cpu_prof_tests_as_flaky_in_electron.patch b/patches/node/test_mark_cpu_prof_tests_as_flaky_in_electron.patch new file mode 100644 index 0000000000..8b40ddffd2 --- /dev/null +++ b/patches/node/test_mark_cpu_prof_tests_as_flaky_in_electron.patch @@ -0,0 +1,28 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Samuel Attard +Date: Wed, 8 Feb 2023 02:54:05 -0800 +Subject: test: mark cpu prof tests as flaky in electron + +Instead of disabling the tests, flag them as flaky so they still run +but don't cause CI failures on flakes. + +diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status +index 5d88747b7066ce795b091eaaec2a5653f42b2c26..e3c7b531bc519bc97f363a1d4e7df2f059b11614 100644 +--- a/test/sequential/sequential.status ++++ b/test/sequential/sequential.status +@@ -7,6 +7,15 @@ prefix sequential + [true] # This section applies to all platforms + # https://github.com/nodejs/node/issues/27611#issuecomment-613100468 + test-cpu-prof-dir-worker: PASS, FLAKY ++test-cpu-prof-dir-and-name: PASS, FLAKY ++test-cpu-prof-worker-argv: PASS, FLAKY ++test-cpu-prof-default: PASS, FLAKY ++test-cpu-prof-dir-absolute: PASS, FLAKY ++test-cpu-prof-dir-relative: PASS, FLAKY ++test-cpu-prof-exit: PASS, FLAKY ++test-cpu-prof-name: PASS, FLAKY ++test-worker-prof: PASS, FLAKY ++test-inspector-stop-profile-after-done: PASS, FLAKY + # https://github.com/nodejs/node/issues/44898 + test-watch-mode: PASS, FLAKY + test-watch-mode-inspect: PASS, FLAKY diff --git a/script/node-spec-runner.js b/script/node-spec-runner.js index a450b222db..78d881ddd1 100644 --- a/script/node-spec-runner.js +++ b/script/node-spec-runner.js @@ -29,6 +29,7 @@ const defaultOptions = [ 'default', `--skip-tests=${DISABLED_TESTS.join(',')}`, '--flaky-tests=dontcare', + '--measure-flakiness=9', '--shell', utils.getAbsoluteElectronExec(), '-J'