Get the linen background painting during elastic scrolling

We weren't setting the location of the resource bundle correctly in the
renderer process. It turns out base::mac::OuterBundle() returns the helper
app's bundle in the renderer process. So now we have MainApplicationBundle() to
give us the bundle of the main app.
This commit is contained in:
Adam Roben 2013-03-14 13:05:01 -04:00
Родитель b2a79856ef
Коммит fe35a92de5
5 изменённых файлов: 69 добавлений и 20 удалений

Просмотреть файл

@ -47,6 +47,8 @@
'common/application_name_mac.mm',
'common/content_client.cc',
'common/content_client.h',
'common/mac/main_application_bundle.h',
'common/mac/main_application_bundle.mm',
'common/main_delegate.cc',
'common/main_delegate.h',
'common/main_delegate_mac.mm',

Просмотреть файл

@ -1,12 +1,13 @@
#import "common/application_name.h"
#import "base/mac/bundle_locations.h"
#import "common/mac/main_application_bundle.h"
#import "base/mac/foundation_util.h"
namespace brightray {
std::string GetApplicationName() {
return [[base::mac::OuterBundle().infoDictionary objectForKey:base::mac::CFToNSCast(kCFBundleNameKey)] UTF8String];
return [[MainApplicationBundle().infoDictionary objectForKey:base::mac::CFToNSCast(kCFBundleNameKey)] UTF8String];
}
}

Просмотреть файл

@ -0,0 +1,20 @@
#ifndef BRIGHTRAY_COMMON_MAC_MAIN_APPLICATION_BUNDLE_H_
#define BRIGHTRAY_COMMON_MAC_MAIN_APPLICATION_BUNDLE_H_
@class NSBundle;
namespace base {
class FilePath;
}
namespace brightray {
// The "main" application bundle is the outermost bundle for this logical application. E.g., if you
// have MyApp.app and MyApp.app/Contents/Frameworks/MyApp Helper.app, the main application bundle is
// MyApp.app, no matter which executable is currently running.
NSBundle* MainApplicationBundle();
base::FilePath MainApplicationBundlePath();
}
#endif

Просмотреть файл

@ -0,0 +1,42 @@
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Copyright (c) 2013 Adam Roben <adam@roben.org>. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE-CHROMIUM file.
#import "common/mac/main_application_bundle.h"
#import "base/files/file_path.h"
#import "base/mac/foundation_util.h"
#import "base/path_service.h"
namespace brightray {
base::FilePath MainApplicationBundlePath() {
// Start out with the path to the running executable.
base::FilePath path;
PathService::Get(base::FILE_EXE, &path);
// Up to Contents.
if (base::mac::IsBackgroundOnlyProcess()) {
// The running executable is the helper. Go up five steps:
// Contents/Frameworks/Helper.app/Contents/MacOS/Helper
// ^ to here ^ from here
path = path.DirName().DirName().DirName().DirName().DirName();
} else {
// One step up to MacOS, another to Contents.
path = path.DirName().DirName();
}
DCHECK_EQ(path.BaseName().value(), "Contents");
// Up one more level to the .app.
path = path.DirName();
DCHECK_EQ(path.BaseName().Extension(), ".app");
return path;
}
NSBundle* MainApplicationBundle() {
return [NSBundle bundleWithPath:base::mac::FilePathToNSString(MainApplicationBundlePath())];
}
}

Просмотреть файл

@ -6,6 +6,7 @@
#import "main_delegate.h"
#include "common/application_name.h"
#include "common/mac/main_application_bundle.h"
#include "base/mac/bundle_locations.h"
#include "base/mac/foundation_util.h"
@ -18,24 +19,7 @@ namespace brightray {
namespace {
base::FilePath GetFrameworksPath() {
// Start out with the path to the running executable.
base::FilePath path;
PathService::Get(base::FILE_EXE, &path);
// Up to Contents.
if (base::mac::IsBackgroundOnlyProcess()) {
// The running executable is the helper. Go up five steps:
// Contents/Frameworks/Helper.app/Contents/MacOS/Helper
// ^ to here ^ from here
path = path.DirName().DirName().DirName().DirName().DirName();
} else {
// One step up to MacOS, another to Contents.
path = path.DirName().DirName();
}
DCHECK_EQ(path.BaseName().value(), "Contents");
// Go into the frameworks directory.
return path.Append("Frameworks");
return MainApplicationBundlePath().Append("Contents").Append("Frameworks");
}
}