8201623d92
test: fix visibility-state-spec.ts flaky test ( #44037 )
...
* test: refactor visibility-state-spec
* ci: shard tests
* test: update split-tests for use on Windows
* test: run visibility-state-spec.ts first
2024-10-11 10:00:22 -04:00
d93285dde1
ci: don't call datadog test logging on forks ( #44181 )
2024-10-11 12:08:51 +02:00
3d2f68a9df
refactor: spanify image utils ( #44127 )
...
* refactor: electron::util::AddImageSkiaRepFromJPEG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromPNG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromBuffer() takes a span arg
* feat: add Node-buffer-to-base-span helper function
* refactor: electron::api::NativeImage::CreateFromPNG() now takes a span param
* refactor: electron::api::NativeImage::CreateFromJPEG() now takes a span param
* refactor: use base::as_byte_span()
* fix: -Wunsafe-buffer-usage warning in NativeImage::CreateFromNamedImage()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: error: function introduces unsafe buffer manipulation [-Werror,-Wunsafe-buffer-usage]
131 | {reinterpret_cast<const uint8_t*>((char*)[png_data bytes]),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
132 | [png_data length]});
| ~~~~~~~~~~~~~~~~~~
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: note: See //docs/unsafe_buffers.md for help.
* chore: add // SAFETY comment for Node-buffer-to-span func
* chore: add // SAFETY comment for NSData-to-span func
2024-10-10 09:34:55 -04:00
d51ef7d794
build: update NMV to 132 ( #44135 )
...
Node PR: https://github.com/nodejs/node/pull/55306
Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34
Please merge this PR before branching 34-x-y
2024-10-09 11:55:59 -07:00
78fa477726
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() ( #44133 )
2024-10-09 13:02:00 -05:00
dbbdf55493
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() ( #44134 )
...
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()
* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use
2024-10-09 12:18:19 -05:00
b5227b4a17
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44149 )
...
fixup e8948397
2024-10-09 09:12:48 -05:00
08d315da14
refactor: revert url::DomainIs() for cookie domains ( #44153 )
...
build: revert DomainIs refactor
2024-10-08 18:39:37 -07:00
ebeae6f301
ci: only upload to datadog when running tests ( #44152 )
2024-10-08 15:07:17 -04:00
4cf69f396f
fix: context shear in cli_remove_deprecated_v8_flag.patch ( #44148 )
...
fix: patch shear in cli_remove_deprecated_v8_flag.patch
2024-10-08 07:54:33 -07:00
bcbc8d3bb2
chore: bump chromium to 131.0.6762.0 (main) ( #44117 )
...
* chore: bump chromium in DEPS to 131.0.6756.0
* chore: update disable_hidden.patch
no code changes; just handling upstream context shear
https://chromium-review.googlesource.com/c/chromium/src/+/5887019
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Factor out URLLoader's URLRequest configuration into a helper
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5902254
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 1
* chore: e patches all
* 5882129: Fix basic auth issues for sub frame and sub resources | https://chromium-review.googlesource.com/c/chromium/src/+/5882129
- Add `is_request_for_navigation` param to
ElectronBrowserClient::CreateLoginDelegate().
- Propagate the flag as another undocumented property
in the app.login Event's authenticationResponseDetails object
- Side cleanup: also in CreateLoginDelegate(), use upstream's name
for the `is_request_for_main_frame` param, renamed back in
https://chromium-review.googlesource.com/c/chromium/src/+/3256171
* 5875189: [FSA] Check for DANGEROUS extension types when creating a new file. | https://chromium-review.googlesource.com/c/chromium/src/+/5875189
* chore: node ./script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6758.0
* chore: bump chromium in DEPS to 131.0.6760.0
* chore: update patches
* [A11y] Remove Accessibility Object Model (AOM)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5896593
* chore: bump chromium in DEPS to 131.0.6762.0
* [heap] Remove deprecated V8 flag
Refs https://chromium-review.googlesource.com/c/v8/v8/+/5904046
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-10-07 18:06:47 -05:00
aa40e817c8
ci: add datadog test logging ( #44094 )
2024-10-07 18:51:23 -04:00
b95ee8964c
chore: bump node to v20.18.0 (main) ( #44119 )
...
* chore: bump node in DEPS to v20.18.0
* chore: update patches
* src: improve buffer.transcode performance
https://github.com/nodejs/node/pull/54153
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-07 18:51:08 -04:00
ab1488a1be
chore: bump chromium to 131.0.6754.0 (main) ( #44110 )
...
* chore: bump chromium in DEPS to 131.0.6754.0
* chore: update gin_enable_disable_v8_platform.patch
fix minor context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5901115
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-03 13:35:03 -04:00
122685194a
build: add import/order eslint rule ( #44085 )
...
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-02 19:10:44 -07:00
684e345f68
fix: deprecated API and -Wunsafe-buffer-usage warnings in AsarFileValidator ( #44068 )
...
* refactor: const correctness
* refactor: extract-method AsarFileValidator::EnsureHashExists()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* refactor: use span API in AsarFileValidator::OnRead()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* fixup! refactor: use span API in AsarFileValidator::OnRead()
fix: electron-ia32-testing FTBFS
2024-10-02 16:44:28 -04:00
9df092e034
fix: remove use of deprecated API base::Hash() ( #44076 )
2024-10-02 16:36:06 -04:00
93dd9fc17b
build: use node 20.17 on Windows ( #44065 )
...
* build: rebake image
* build: use e-131.0.6734.0-node-20.17-0
* build: bump msvs version to 2022
2024-10-02 20:12:41 +02:00
59a43ef2e3
chore: bump chromium to 131.0.6752.0 (main) ( #44093 )
...
* chore: bump chromium in DEPS to 131.0.6752.0
* chore: update refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
adjust to upstream #include shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5872830
* chore: e patches all
* Remove the <selectlist> prototype implementation
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5855076
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 08:35:18 -07:00
5a97ee26ff
chore: bump chromium to 131.0.6751.0 (main) ( #44087 )
...
chore: bump chromium in DEPS to 131.0.6751.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-01 21:30:40 -05:00
5b34138db8
build: fix relative file read during npm publish ( #44088 )
2024-10-01 17:09:57 -07:00
1fc2064f6a
chore: bump chromium to 131.0.6750.0 (main) ( #44066 )
...
* chore: bump chromium in DEPS to 131.0.6750.0
* Clean up stale base::Feature "RestrictFileURLNavigation"
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5891262
* chore: update mas_avoid_private_macos_api_usage.patch
Comment out some new private macOS API use.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5837702
Xref: https://electronhq.slack.com/archives/C5VT8SQ8K/p1727807285899389
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-01 19:34:32 -04:00
f4ffd018e6
build: cleanup release scripts, separate cli entrypoints from logic ( #44058 )
...
* build: cleanup release scripts, separate cli entrypoints from logic
* build: use repo/org constants
2024-10-01 13:51:40 -07:00
15c8759ee0
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() ( #44053 )
2024-10-01 10:06:02 -07:00
06bce8166b
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI ctor ( #44055 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI constructor
2024-10-01 10:05:46 -07:00
6f88f0c795
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() ( #44067 )
...
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
2024-10-01 10:04:57 -07:00
f828c1da09
build: remove github actions dependabot on release branches ( #44054 )
2024-10-01 08:50:42 -07:00
47cf1e3acd
build: use ts-node to spawn the version-bumper ( #44057 )
...
Missed this in the tsification, we should probably call this via API instead of spawning a sub-proc?
2024-09-30 21:19:59 -07:00
61565465fd
build: convert all release scripts to typescript ( #44035 )
...
* build: convert all release scripts to typescript
* fix test imports
* build: fix version bumper export
* refactor: use as const
* spec: fix bad type spec
2024-09-30 17:55:27 -07:00
7ebc427bf5
build: update appveyor to node 20.17 ( #44026 )
...
* build: update appveyor to node 20.17
* build: bake new images with npm dir
* build: use e-131.0.6734.0-node-20.17-1
2024-09-30 16:14:46 -04:00
5d9800e176
chore: bump chromium to 131.0.6748.0 (main) ( #44027 )
...
* chore: bump chromium in DEPS to 131.0.6748.0
* chore: gen-libc++-filenames.js
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-30 13:32:50 -04:00
1d4b86cb3e
fix: -Wunsafe-buffer-usage warnings in AddComponentResourceEntries() ( #44024 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
just replace pointer-and-length args with a span
2024-09-30 11:01:24 -05:00
77f7ba96ca
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() ( #44014 )
...
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: remove logging
* fix: unconditionally write
* chore: naming
* chore: add code comments
* chore: more code comments
* chore: remove unrelated changes
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: naming
* refactor: naming
* refactor: naming
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
2024-09-30 15:09:36 +02:00
af58931efa
chore: bump chromium to 131.0.6744.0 (main) ( #43948 )
...
* chore: bump chromium in DEPS to 131.0.6738.0
* chore: bump chromium in DEPS to 131.0.6740.0
* 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* https://boringssl.googlesource.com/boringssl.git/+/40dd94116ba03678226443ba20c5887459c9bf16/crypto/fipsmodule/digest/digests.c.inc
* chore: update patches
* 5878695: Add IsolationInfo for embedders handling external protocols | https://chromium-review.googlesource.com/c/chromium/src/+/5878695
* 5854304: [UI] Remove alias of mojom | https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: bump chromium in DEPS to 131.0.6742.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6744.0
* fixup! 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* chore: e patches all
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5894233
* [UI] Remove alias of mojom 'WindowShowState'
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: gen-libc++-filenames.js
* chore: partially revert https://chromium-review.googlesource.com/c/chromium/src/+/5894233
see patch commit message for description
* Clean up stale base::Feature "kFileSystemAccessLocalUNCPathBlock"
This feature is always on by default and doesn't have active finch
experiments.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5881253
* fix: asar integrity test recognizes SIGABRT as a crash
https://chromium-review.googlesource.com/c/chromium/src/+/5882758
ValidateIntegrityOrDie() exits via LOG(FATAL)'s call to
base::ImmediateCrash(). There's been churn there upstream between
5332940 and 5882758 on whether to use SIGTRAP or SIGABRT. For now,
let's accept both until the churn is done.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-30 14:54:44 +02:00
eb40d2cbfa
fix: FTBFS when building with `enable_plugins = false` ( #44003 )
...
* fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
it fails to build from source with this error:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
17 | #error "Plugins should be enabled"
* fix: FTBFS in printing_utils.cc when ENABLE_PDF is false
* fixup! fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
fix BUILD.gn linting
2024-09-29 17:10:34 -05:00
27d2a8f9e2
ci: write test logging to console on Windows ( #43990 )
...
test: write logging to console on Windows
2024-09-27 15:17:32 -04:00
d4e4cdee6c
fix: remove resize listener when BrowserWindow closed ( #43972 )
2024-09-27 10:34:00 -04:00
f68184a9f9
feat: add error event for utility process ( #43774 )
...
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-27 10:17:06 +09:00
8397fef3ef
chore: remove unused nogncheck includes ( #43964 )
2024-09-26 17:09:42 -05:00
852f9ff329
perf: build g_dgettext domain name at compile time ( #43960 )
...
perf: build GettextPackage name at compile time
2024-09-26 13:10:30 -04:00
a974b74e82
fix: replace deprecated libnotify API calls ( #43962 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 11:21:45 -05:00
da6ab92353
fix: ensure correct `WebContents` when checking `PDFReadyToPrint` ( #43943 )
...
* fix: ensure correct WebContents when checking PDFReadyToPrint
* test: fix paths on Windows
2024-09-26 10:54:13 -04:00
ddd45db6ca
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43956 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
2024-09-26 08:32:43 -05:00
40cae71df8
test: re-enable tests that were disabled in chromium rolls ( #43968 )
...
* test: fix should support base url for data urls test
Caused by https://chromium-review.googlesource.com/c/chromium/src/+/5802682
* test: fixup extensions can cancel http requests
* chore: document custom protocol handling on Windows change due to Non-Special Scheme URLs shipping
https://chromium-review.googlesource.com/c/chromium/src/+/5802682
2024-09-26 08:53:27 -04:00
b60013fcf1
build: update appveyor image to latest version ( #43971 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-09-26 13:10:34 +02:00
74af96da16
build: update some build dependencies ( #43882 )
...
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
2024-09-26 00:12:11 -07:00
15db63e26d
fix: SCContentSharingPicker crash in iframes ( #43905 )
...
When running `getDisplayMedia` from an `iframe` and then destroying that
`iframe`, the destrutcor for ScreenCaptureKitDeviceMac gets run, but it
doesn't clean up the observers for the shared macOS picker.
In this change we remove the observer on cleanup and fix the associated
crash:
*** Terminating app due to uncaught exception 'NSGenericException', reason: '*** Collection <__NSArrayM: 0x12c024123a0> was mutated while being enumerated.'
0 CoreFoundation 0x000000018eda0ec0 __exceptionPreprocess + 176
1 libobjc.A.dylib 0x000000018e886cd8 objc_exception_throw + 88
2 CoreFoundation 0x000000018ee47f80 -[__NSSingleObjectEnumerator init] + 0
3 ScreenCaptureKit 0x000000022971f3e0 -[SCContentSharingPicker contentPickerDidSelectFilter:forStream:] + 436
4 ReplayKit 0x00000001d7b879d8 -[RPScreenRecorder contentPickerDidSelectFilter:forStream:] + 84
5 ReplayKit 0x00000001d7b95ce0 -[RPDaemonProxy contentPickerDidSelectFilter:forStream:] + 224
6 CoreFoundation 0x000000018ed0e8b4 __invoking___ + 148
7 CoreFoundation 0x000000018ed0e72c -[NSInvocation invoke] + 428
8 ReplayKit 0x00000001d7b91678 -[RPDaemonProxy connection:handleInvocation:isReply:] + 316
9 Foundation 0x0000000190899f64 -[NSXPCConnection _decodeAndInvokeMessageWithEvent:reply:flags:] + 1108
10 Foundation 0x000000019089b7d0 message_handler_message + 88
11 Foundation 0x000000018feb0160 message_handler + 152
12 libxpc.dylib 0x000000018e954460 _xpc_connection_call_event_handler + 144
13 libxpc.dylib 0x000000018e952bb4 _xpc_connection_mach_event + 1120
14 libdispatch.dylib 0x000000018ea94718 _dispatch_client_callout4 + 20
15 libdispatch.dylib 0x000000018eab0c00 _dispatch_mach_msg_invoke + 464
16 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
17 libdispatch.dylib 0x000000018eab1954 _dispatch_mach_invoke + 456
18 libdispatch.dylib 0x000000018ea9bae8 _dispatch_lane_serial_drain + 368
19 libdispatch.dylib 0x000000018ea9c79c _dispatch_lane_invoke + 432
20 libdispatch.dylib 0x000000018eaa77e8 _dispatch_root_queue_drain_deferred_wlh + 288
21 libdispatch.dylib 0x000000018eaa7034 _dispatch_workloop_worker_thread + 540
22 libsystem_pthread.dylib 0x000000018ec433d8 _pthread_wqthread + 288
23 libsystem_pthread.dylib 0x000000018ec420f0 start_wqthread + 8
2024-09-25 16:43:23 -07:00
ff36ff84b7
build(deps-dev): bump eslint-plugin-promise from 4.3.1 to 7.1.0 ( #43935 )
...
Bumps [eslint-plugin-promise](https://github.com/eslint-community/eslint-plugin-promise ) from 4.3.1 to 7.1.0.
- [Release notes](https://github.com/eslint-community/eslint-plugin-promise/releases )
- [Changelog](https://github.com/eslint-community/eslint-plugin-promise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint-community/eslint-plugin-promise/compare/v4.3.1...v7.1.0 )
---
updated-dependencies:
- dependency-name: eslint-plugin-promise
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 16:49:03 -05:00
846b31b77d
build(deps-dev): bump @types/chai-as-promised from 7.1.3 to 8.0.1 ( #43936 )
...
Bumps [@types/chai-as-promised](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/chai-as-promised ) from 7.1.3 to 8.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/chai-as-promised )
---
updated-dependencies:
- dependency-name: "@types/chai-as-promised"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 09:06:26 -05:00
c8895d0547
fix: close all open sheets before closing window on macOS ( #43706 )
2024-09-25 13:23:49 +02:00
John Kleinschmidt
Charles Kerr
Michaela Laurencin
Keeley Hammond
electron-roller[bot]
Samuel Attard
Shelley Vohr
Robo
electron-appveyor-updater[bot]
Fedor Indutny
dependabot[bot]
John Beutner