ab785e73ac
Bump v6.0.0-nightly.20190307
2019-03-07 12:34:10 -08:00
d4d6b9862f
fix: make StreamSubscriber ref counted ( #17221 )
...
It is owned by URLRequestStreamJob on the IO thread once request starts,
but if the ownership was abondoned while transfering it to IO thread
which is possible when a request is aborted, then we need to make sure
its destroyed on the right thread to avoid lock in v8.
2019-03-07 20:50:03 +05:30
b575631bb0
fix: bad assertion in crypto functions that use BN_bn2bin_padded ( #17220 )
...
* chore: roll node
in particular, this picks up electron/node#70a78f07b, which fixes an issue with incorrect usage of the BN_bn2bin_padded API in boringssl
* fix tests
2019-03-07 07:29:53 +05:30
5422fd9941
fix: backport upstream fixes for color chooser dialogs ( #17227 )
...
* fix: backport upstream fixes for color chooser dialogs
* chore: fix patches, Windows bad, linux good
* Update color_chooser_mac.patch
* Update color_chooser_win.patch
2019-03-07 07:25:15 +05:30
2733697819
refactor: make ELECTRON_INSPECTOR_SELECT_FILE handler async ( #17235 )
2019-03-06 22:22:45 +01:00
6cb7b8d3a4
feat: promisify dialog.showSaveDialog() ( #17054 )
...
* feat: promisify dialog.showSaveDialog()
* address some feedback from review
* filename => filePath
* fix last filename => filePath
2019-03-05 13:48:20 -08:00
92c9dbc179
chore: bump chromium in DEPS to 73.0.3683.65 ( #17234 )
2019-03-05 11:01:38 -08:00
5a88d9e6fc
docs: add troubleshooting note about pywin32 ( #17216 )
2019-03-05 10:40:52 -08:00
aa863f3246
Fix typo in registerSchemesAsPrivileged reference ( #17214 )
2019-03-05 09:20:52 -08:00
e05985145b
feat: promisify dialog.showOpenDialog() ( #16973 )
...
* feat: promisify dialog.showOpenDialog()
* address feedback from review
* address feedback from review
2019-03-05 05:54:48 -08:00
7936237677
build: enable gn check for //electron:electron_lib ( #17100 )
...
* build: enable gn check for //electron:electron_lib
* ci: add gn check step
* ci: set depot_tools path
* chrome_key_systems_provider.h nogncheck
* chore: fix gn check errors on windows
* chore: gn check //electron:electron_app
2019-03-05 10:38:55 +05:30
ed31cfebc9
fix: check for pane focus before removing it. ( #17164 )
...
Fixes #16883 . This bug seems to have been introduced in the #15302's
menu a11y refactor and is new in 5-0-x.
2019-03-04 09:47:59 -06:00
8dcb5662e3
refactor: remove chromium/net_url_request_job.patch ( #17174 )
...
Does not appear to be used any more
2019-03-02 15:23:47 +05:30
f4169f3491
chore: bump chromium to 73.0.3683.61 (master) ( #17191 )
...
also backport https://chromium-review.googlesource.com/c/chromium/src/+/1496448
2019-03-01 12:35:27 -08:00
bbd1ae315a
refactor: use invoke/invokeSync helpers for <webview> implementation ( #16784 )
2019-03-01 13:33:03 -05:00
2adbc7836b
refactor: prevent node macros from overriding base ( #17178 )
2019-03-01 10:04:30 -08:00
59a7fa6927
refactor: Port api/web-frame to TypeScript ( #17053 )
2019-03-01 08:39:04 +00:00
676c02611d
spec: add missing checks to "validates process APIs access in sandboxed renderer" ( #17129 )
2019-02-28 22:24:18 -08:00
67f04c0370
docs: remove dead link to chromiumdev slack ( #17161 )
...
* docs: remove dead link to chromiumdev slack
Closes #17154
* Update chromium-development.md
2019-02-28 16:43:55 -05:00
544d8a423c
feat: allow MenuItems to work optionally when hidden ( #16853 )
...
* feat: allow MenuItems to work optionally when hidden
* fix: actually include forward_declaration
2019-02-28 17:00:54 +00:00
6d55498cc7
docs: Fix types and missing property in WebRequest APIs ( #17046 )
...
* docs: Fixed hook methods of WebRequest accepts null as listener
* docs: Added missing `referrer` property in OnBeforeRequestDetails
* docs: Add `referrer` to each webRequest responses
2019-02-28 09:30:38 +00:00
64078324bf
refactor: make CHROME_GET_MESSAGES handler async ( #17148 )
2019-02-27 21:30:35 -06:00
bfa07ec4be
feat: Add new powerMonitor synchronous API ( #17144 )
...
`powerMonitor.querySystemIdleState` and `powerMonitor.querySystemIdleTime` had async backing APIs in chromium (https://chromium-review.googlesource.com/c/chromium/src/+/1379183 ). However, that has changed in ch73. So, this PR deprecates the old async APIs and adds new sync APIs.
2019-02-27 15:54:01 -05:00
29ab74688d
chore: update CODEOWNERS to reflect governance ( #17143 )
...
* chore: update CODEOWNERS to reflect governance
* Add /patches/ @electron/wg-upgrades
* Update CODEOWNERS
2019-02-27 15:17:35 -05:00
d4cfaaf047
Update debugging-main-process-vscode.md ( #16363 )
...
[console.log() not printing to terminal when debugging Electron apps. #49 ](https://github.com/Microsoft/vscode-recipes/issues/49#issuecomment-354367330 )
2019-02-27 15:03:15 -05:00
5da89c3a2b
chore:Remove transparency hack ( #17128 )
...
This change undoes the hack that was put in because of a bug in chromium. That has since been fixed in chromium, so this is no longer need, hence removing.
The 'BrowserWindow' > 'preserves transparency' test, validates this working.
2019-02-27 14:51:30 -05:00
e01c3615c4
chore: replace usage of deprecated beginSheetModalForWindow API ( #16994 )
2019-02-27 10:23:17 -08:00
1bbb47be5b
docs: Improved security doc, particularly around isolation and tool ( #16703 )
...
* Improved security doc, particularly around isolation and tool
* Fixes as suggested by @ckerr
* libcc update
* fixing lint stuff
2019-02-27 10:09:38 -08:00
a07cb2afd7
Bump v6.0.0-nightly.20190227
2019-02-27 09:55:19 -08:00
4e25dc3c3c
chore: bump chromium in DEPS to 73.0.3683.58 ( #17156 )
2019-02-27 09:48:08 -08:00
5ecda17c7a
refactor: make shell.ShowItemInFolder asynchronous ( #17121 )
...
* fix: add scoped_blocking_calls to platform_win
https://chromium-review.googlesource.com/c/chromium/src/+/1191582
* feat: make ShowItemInFolder async
* address feedback from review
* fix build
2019-02-27 12:58:23 +00:00
08066581b0
fix: set cancelId to 1 when defaultId == 0 and no 'cancel' button ( #17123 )
2019-02-27 08:24:13 +00:00
42aa375497
fix: access of out-of-scope reference in ShowOpenDialog and ShowSaveDialog ( #17126 )
...
In the mac file dialog implementation of show*OpenDialog, a settings
object is passed down to the dialog completion handler.
However at the time the completion handler is invoked, the settings
object is already out-of-scope, resulting in an invalid access to
the security_scoped_bookmarks flag.
The fix is to capture the value of the flag and passing that directly
to the completion handler.
fixes issue #16664
2019-02-27 08:14:04 +00:00
5a99ea4c46
refactor: merge ipcMainUtils.handle / handleSync ( #17062 )
2019-02-26 15:48:26 -08:00
848d16525f
Revert "Bump v6.0.0-nightly.20190226"
...
This reverts commit 7c78f11b82
2019-02-26 15:20:32 -08:00
7c78f11b82
Bump v6.0.0-nightly.20190226
2019-02-26 14:56:19 -08:00
28899c3885
chore: roll chromium 73.0.3683.54 ( #17124 )
...
* chore: roll chromium 73.0.3683.52
* chore: roll 73.0.3683.54
2019-02-26 21:35:27 +00:00
be8f9bd597
chore: clean up issue templates ( #17085 )
...
* chore: clean up issue templates
* address feedback from review
* cleanup
2019-02-26 17:51:29 +09:00
d9c7735a04
chore: augment promisifyMultiArg deprecation ( #17066 )
2019-02-25 18:25:25 -08:00
7a7389ab1c
build: upgrade to asar@^1.0.0 ( #17061 )
...
* build: upgrade asar to ^1.0.0
This is to remove a transitive security vulnerability.
The API changed from callbacks to Promises, so `script/gn-asar.js`
needed to be changed.
* build: add klaw to package.json
`klaw` is used in `script/lint.js`, but it was a transitive dependency.
* build: add fs-extra to package.json
`fs-extra` is used in `script/gn-asar.js`, but it was a transitive
dependency.
2019-02-25 18:25:00 -08:00
30213089ae
docs: allow webRequest listener to passing null ( #17006 )
2019-02-25 18:13:00 -08:00
391f6dd663
docs: add sample code for contents.insertCSS() ( #16959 )
...
it not work before Event: 'did-finish-load', so add this sample code to show it.
2019-02-25 18:10:56 -08:00
7f007109c3
refactor: Port inspector to TypeScript ( #16943 )
...
* refactor: Port inspector to TypeScript
* refactor: Add another type to inspector
* refactor: Use correct paths
* Update lib/renderer/inspector.ts
Co-Authored-By: felixrieseberg <felix@felixrieseberg.com>
* refactor: Implement feedback <3
* refactor: Don't define blob at all
* fix: Correct type
2019-02-25 18:10:25 -08:00
ddcebb096f
fix: use frame tree api to remove <webview> frame ( #16501 )
...
Replaces the usage of testing api added in
03d499bf34
2019-02-25 17:47:29 -08:00
6da939629b
fix: respect the user's active app focus ( #16400 )
...
* Respect the user's active app
Apple recommends not setting this to true. https://developer.apple.com/documentation/appkit/nsapplication/1428468-activateignoringotherapps?language=objc
* Remove atom_bundle_mover.mm change for [NSApp activateIgnoringOtherApps:]
2019-02-25 17:44:38 -08:00
5e762d6a47
chore: finalize dropping support for OS X Mavericks (version 10.9) ( #17102 )
2019-02-25 17:21:57 +00:00
df5305d6a7
docs: fix MenuItem `windowMenu` role description ( #17065 )
...
It was changed in https://github.com/electron/electron/pull/15930
2019-02-25 13:34:32 +00:00
1674388028
Fix webContents.print() ( #17052 )
2019-02-25 13:30:21 +00:00
944cdb4430
chore: bump chromium in DEPS to 73.0.3683.49 ( #17095 )
2019-02-22 17:17:02 -08:00
28b150f6dc
test: fix race condition in debugger spec ( #17091 )
2019-02-22 16:45:48 -08:00
Electron Bot
Robo
Jeremy Apthorp
Heilig Benedek
Milan Burda
Shelley Vohr
Roller Bot
Koen [XII]
Charles Kerr
Samuel Attard
Felix Rieseberg
Linda_pp
Nitish Sakhawalkar
qwabra
Luca Carettoni
Johann Fuechsl
Mark Lee
Vlad Hashimoto
Gavin Wang
Shazron Abdullah
Sindre Sorhus
Thomas Beverley