122685194a
build: add import/order eslint rule ( #44085 )
...
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-02 19:10:44 -07:00
778d3098a0
feat: customize border radius of Views ( #42320 )
...
* feat: add View#setBorderRadius
test: initial setBorderRadius tests
fix: robustly set border radius
chore: add PAUSE_CAPTURE_TESTS for easier screencap dev
feat: add view border radius support
test: view border radius
refactor: cleanup view code
* maybe delay capture to fix tests?
* refactor: retry screen captures in an attempt to fix flakiness
* refactor: ScreenCapture constructor no longer async
* increase screen capture timeout, feels a little short
* refactor: move rounded rect util into chromium_src
* skip some capture tests on mas
2024-07-16 20:16:25 -04:00
cb2e7f130b
fix: potentially closed webContents in BrowserView ( #42633 )
2024-07-08 12:13:53 +02:00
e9a93a8c5c
fix: setTopBrowserView focus issue with reordering ( #42653 )
...
* fix: reorder top browser view instead of adding/removing
* fix: update browserViews order
* test: add a test for setTopBrowserView
2024-07-01 11:36:04 +02:00
5fb117a7d7
fix: don't destroy BrowserView webContents when owning BrowserWindow hasn't been closed ( #42353 )
...
* fix: moves bv webContents close to closed event
* chore: adds unit tests
* chore: test that bv webContents are destroyed when parent bw closed
2024-06-05 09:58:38 +02:00
a6133e85d1
test: disable flaky macOS panel test & refactor screen capture testing ( #41441 )
...
* Disable flaky test
* Add helper for storing test artifacts
* Refactor screen capture tests
We have a pattern for inspecting a screen capture, so this refactor codifies that pattern into a helper. This gives us shorter test code, consistency (previously, the display in test code and the display captured could theoretically be different), and better debugging/observability on failure.
2024-02-28 12:54:20 +09:00
15c6014324
feat: replace BrowserView with WebContentsView ( #35658 )
2023-12-13 13:01:03 -08:00
f27b034045
test: convert a few more specs to async/await ( #39712 )
2023-09-04 12:33:29 +02:00
a8999bc529
fix: ensure `BrowserView` bounds are always relative to window ( #39605 )
...
fix: ensure BrowserView bounds are always relative to window
2023-08-23 09:55:31 -04:00
f959fb0c96
feat: `browserWindow.getBrowserViews()` to return sorted by z-index array ( #38943 )
2023-07-11 11:01:30 +02:00
c7bdd907d7
fix: set prototype names on `gin::Constructible` classes ( #39006 )
...
* fix: set prototype names on gin::Constructible classes
* test: add tests
2023-07-10 11:49:20 +02:00
5a77c75753
revert: compensate for title bar height when setting bounds on `BrowserView` ( #38981 )
...
This reverts commit 75f9573e53
2023-07-06 09:50:08 +02:00
a00a25376d
fix: crash calling `BrowserWindow.removeBrowserView()` with destroyed `webContents` ( #38842 )
...
fix: crash calling removeBrowserView() with destroyed webContents
https://github.com/electron/electron/issues/37642
2023-06-21 15:20:54 -04:00
d78f37ec8f
refactor: use node scheme imports in spec ( #38487 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-06-15 10:42:27 -04:00
82af000a37
chore: cleanup eslint suppressions ( #38417 )
...
* chore: cleanup eslint suppressions
* address feedback
* revert script/lib/azput.js
* revert spec/fixtures/apps/remote-control/main.js
* address feedback
* revert typings/internal-ambient.d.ts
2023-05-25 10:09:17 +09:00
5e25d23794
fix: handle closing `webContents` in `BrowserView`s ( #37420 )
...
* fix: handle closing webContents in BrowserViews
* test: add window.close() test
2023-03-01 11:35:06 +01:00
a3e3efe4c4
test: use node helpers for events.once and setTimeout promise ( #37374 )
2023-02-23 15:53:53 -08:00
ea848bc1c5
test: use webContents.create() in type-safe way ( #37281 )
...
test: use (webContents as typeof ElectronInternal.WebContents).create()
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-16 15:41:41 +01:00
8d382b9c60
chore: remove deprecated capturer count APIs ( #37075 )
...
chore: remove deprecated incrementCapturerCount() / decrementCapturerCount()
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-06 07:54:47 -08:00
4bc6b15f53
refactor: move spec helpers to spec/lib ( #37010 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-01-25 13:01:25 -08:00
5fd7a43970
test: replace (webContents as any).destroy() with webContents.destroy() ( #36653 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2022-12-14 16:07:38 -05:00
b71cccb0d6
ci: bake appveyor images automatically, run sync on depshash change ( #35396 )
...
* chore: update yml formatting for parser
* ci: bake appveyor images automatically, run sync on depshash change
* chore: clean up .yml files
* chore: bump to e-110.0.5415.0
2022-11-21 10:24:26 -05:00
f99122abfc
refactor: BrowserView is owned by a BaseWindow ( #35511 )
2022-08-31 17:40:02 -07:00
75f9573e53
fix: compensate for title bar height when setting bounds on `BrowserView` ( #34713 )
...
fix: compensate for title bar height when setting bounds
2022-08-29 17:53:03 +02:00
db7c92fd57
test: drop now-empty remote runner ( #35343 )
...
* test: drop the now-empty remote runner from CI
* move fixtures to spec-main
* remove remote runner
* fix stuff
* remove global-paths hack
* move ts-smoke to spec/
* fix test after merge
* rename spec-main to spec
* no need to ignore spec/node_modules twice
* simplify spec-runner a little
* no need to hash pj/yl twice
* undo lint change to verify-mksnapshot.py
* excessive ..
* update electron_woa_testing.yml
* don't search for test-results-remote.xml
it is never produced now
2022-08-16 15:23:13 -04:00
Samuel Attard
Sam Maddock
Shelley Vohr
Alice Zhao
Anny Yang
Calvin
Jeremy Rose
Milan Burda
Mikhail Leliakin
Keeley Hammond