fea722b621
docs: fix broken notification-spec markdown link ( #42309 )
...
* docs: fix broken notification-spec markdown link
Co-authored-by: IsmaelMartinez <ISMAELMARTINEZ@GMAIL.COM>
* docs: update notification-spec linkt to point to freedesktop
Co-authored-by: Ismael Martinez Ramos <ismael.martinez@postcodelottery.co.uk>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: IsmaelMartinez <ISMAELMARTINEZ@GMAIL.COM>
Co-authored-by: Ismael Martinez Ramos <ismael.martinez@postcodelottery.co.uk>
2024-05-30 11:06:16 +02:00
b0ba1a2113
build: update NMV to 125 ( #42314 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: mlaurencin <mlaurencin@electronjs.org>
2024-05-29 14:54:15 -07:00
420e834a31
docs: ensure all links are on a single line ( #42298 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-05-29 11:41:15 +02:00
8edbefcfa3
fix: restore original BrowserWindow.show() behavior ( #42305 )
...
The new activate API on macOS is pretty bad, we should just keep using
the old API. Similar to #42180 . Restores non-panel behavior to pre-panel
support.
Notes: BrowserWindow.show() now correctly restores focus to inactive apps on macOS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2024-05-29 11:39:46 +02:00
e21c70a9e0
fix: fixed the type of `WebviewTag.webpreferences` ( #42279 )
...
fix: fixed the type of WebviewTag.webpreferences
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: EvolutionX <85353424+EvolutionX-10@users.noreply.github.com>
2024-05-26 21:48:31 +02:00
6b86fb4bbb
fix: calculate a hash for the Tag property of ToastNotification. ( #42272 )
...
* fix: calculate a hash for the Tag property of ToastNotification.
Co-authored-by: bill.shen <shenyb32768@gmail.com>
* fix: calculate a hash for the Tag property of ToastNotification.
Co-authored-by: bill.shen <shenyb32768@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-05-26 20:05:45 +02:00
81c184ffc1
chore: cherry-pick 3e037e195e50 from v8 ( #42254 )
...
* chore: cherry-pick 3e037e195e50 from v8
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-23 18:28:35 +02:00
31a753ff7a
fix: `setTitleBarOverlay` should be implemented on `BaseWindow` ( #42150 )
2024-05-23 11:08:36 +02:00
7ff3905120
fix: ensure showInactive actually shows ( #42227 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2024-05-20 15:34:48 -07:00
18da367676
docs: fix broken anchors ( #42216 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-05-17 12:04:37 +02:00
b029f38750
fix: `win.center()` on Windows ( #42197 )
...
fix: win.center() on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-16 10:15:54 -07:00
e4bcd82590
fix: `webContents.navigationHistory` should be enumerable ( #42182 )
...
fix: webContents.navigationHistory should be enumerable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-15 10:49:24 +02:00
a3c6dd9767
chore: remove focus ring patch ( #42188 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-05-14 17:44:51 -07:00
c2540f555c
fix: restore non-panel focus behavior ( #42186 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2024-05-14 17:44:38 -07:00
a0500a5faa
fix: fix cast in ElectronDesktopWindowTreeHostLinux ( #42184 )
...
Fix cast in ElectronDesktopWindowTreeHostLinux
The frame view of the widget is an `ClientFrameViewLinux` instance only
when both `frame` and `client_frame` booleans are set to `true`.
Otherwise it is an instance of a different class and thus casting to
`ClientFrameViewLinux` is incorrect and leads to crashes.
Fix : #41839
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Fedor Indutny <indutny@signal.org>
2024-05-14 17:33:49 -07:00
ebf09b587b
chore: cherry-pick b3c01ac1e60a from v8 ( #42173 )
...
* chore: cherry-pick b3c01ac1e60a from v8
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-14 12:50:36 -07:00
41feba221d
build: update appveyor image to latest version ( #42155 )
...
* build: update appveyor image to latest version
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-14 14:26:13 +02:00
bd900fb10f
chore: update patches after #42126 was merged ( #42156 )
...
chore: update patches after focus ring was merged
2024-05-13 16:36:32 -07:00
ea3001dd39
test: add tests for electron fuses ( #42147 )
...
* spec: add tests for electron fuses
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* spec: fix tests for windows
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* spec: handle weird crash codes on win32
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* spec: disable fuse tests on arm64 windows
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2024-05-13 13:36:03 -07:00
7294c766ac
fix: partially revert invalidate focus ring ( #42146 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
2024-05-13 12:11:58 -07:00
fb9d3ec897
chore: bump chromium to 126.0.6445.0 (31-x-y) ( #42119 )
...
* chore: bump chromium to 126.0.6445.0 31-x-y
* chore: bump chromium in DEPS to 125.0.6421.0
* chore: bump chromium in DEPS to 125.0.6422.0
* Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5434658
* chore: update patches
* fixup: Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
* chore: bump chromium in DEPS to 126.0.6423.0
* chore: update patches
* 5426599: Next generation control of unsafe-buffers-usage plugin
https://chromium-review.googlesource.com/c/chromium/src/+/5426599
* chore: bump chromium in DEPS to 126.0.6425.0
* chore: update patches
* Roll clang+rust llvmorg-19-init-7229-g315c88c5-2 : llvmorg-19-init-8091-gab037c4f-1 / ceab6128fa48a616bfd3e3adf4bc80133b8ee223-1 : ab71ee7a9214c2793108a41efb065aa77aeb7326-1
https://chromium-review.googlesource.com/c/chromium/src/+/5444328
Also see https://issues.chromium.org/issues/332931387
* 5445074: [Views AX] Move AXEventNotificationDetails to ui/accessibility/
https://chromium-review.googlesource.com/c/chromium/src/+/5445074
Also
5455993: [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents | https://chromium-review.googlesource.com/c/chromium/src/+/5455993
* Pass IsolationInfo to ContentBrowserClient::WillCreateURLLoaderFactory()
https://chromium-review.googlesource.com/c/chromium/src/+/5405301
* chore: bump chromium in DEPS to 126.0.6427.0
* chore: update patches
* chore: remove no longer needed patch
perfetto is now turned on so this patch is no longer needed.
* chore: bump chromium in DEPS to 126.0.6429.0
* chore: bump chromium in DEPS to 126.0.6431.0
* chore: bump chromium in DEPS to 126.0.6433.0
* 5466654: Do not create a console if logging to a handle
https://chromium-review.googlesource.com/c/chromium/src/+/5466654
* chore: fixup patch indices
* Address Linux NonClientFrameView Changes
- https://chromium-review.googlesource.com/c/chromium/src/+/5180720
- https://chromium-review.googlesource.com/c/chromium/src/+/5367794
* chore: bump chromium in DEPS to 126.0.6435.0
* chore: bump chromium in DEPS to 126.0.6437.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6439.0
* chore: bump chromium in DEPS to 126.0.6441.0
* 5477689: components/crash/content/tools: Format with yapf | https://chromium-review.googlesource.com/c/chromium/src/+/5477689
* 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* chore: update chromium patches
* chore: bump chromium in DEPS to 126.0.6443.0
* 5465608: Convert DCHECKs near RenderWidgetHost, DelegatedFrameHost to CHECK | https://chromium-review.googlesource.com/c/chromium/src/+/5465608
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6445.0
* chore: update patches
* 5468588: Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct | https://chromium-review.googlesource.com/c/chromium/src/+/5468588
* fixup! 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* 5461340: `size_t` in `mojo::DataPipe[Consumer|Producer]Handle`: /components. | https://chromium-review.googlesource.com/c/chromium/src/+/5461340
* 5480213: Add an EvictIds struct to FrameEvictorClient | https://chromium-review.googlesource.com/c/chromium/src/+/5480213
* 4341506: [api] Deprecate Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/4341506
* 5300826: [v8-tasks] Add source location to v8::TaskRunner, step 4/4. | https://chromium-review.googlesource.com/c/v8/v8/+/5300826
* partially revert is_newly_created to allow for browser initiated about:blank loads
* add dep on app_launch_prefetch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5420149
* install sysroots from electron not from chrome
We should add a new var upstream for `download_sysroots` so that we can skip downloading chromes at all.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5462469
* refactor: make UpdateFrameHints an override
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5473548
* fix ppapi
* refactor: update namespace for pwm switches
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5459367: WebSQL: Restrict WebSQL service creation to Android only | https://chromium-review.googlesource.com/c/chromium/src/+/5459367
* 5455853: Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac." | https://chromium-review.googlesource.com/c/chromium/src/+/5455853
* fixup! refactor: update namespace for pwm switches
edd9e26https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5147611: [heap] Add checks for ensuring position info slow path is not used in heap snapshot | https://chromium-review.googlesource.com/c/v8/v8/+/5147611
* fixup! 5412666: [heap] Also avoid heap allocation for allocation tracked functions | https://chromium-review.googlesource.com/c/v8/v8/+/5412666
* chore: add websql removal to breaking-changes.md
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update .patches after trop
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-13 20:19:31 +02:00
75cefdb527
fix: BrowserView autoresizing conversion error ( #42138 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-13 16:59:43 +02:00
9694e7593f
docs: improve protocol.handle file examples ( #42142 )
...
* docs: improve protocol.handle file examples
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* chore: fix lint
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-05-13 16:59:34 +02:00
8d41e6ea9b
fix: View reordering on re-addition to same parent ( #42116 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-13 11:48:51 +02:00
e282ff6e4a
fix: ensure originalFs.promises.cp works ( #42134 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2024-05-13 10:25:48 +02:00
282ffa10e5
chore: cherry-pick f320600cd1f4 from v8 ( #42121 )
2024-05-11 14:17:19 -07:00
72d85e90ac
refactor: use `//ui/shell_dialogs` on Linux ( #42109 )
2024-05-10 11:31:48 +02:00
2fc89a6b2c
fix: CHECK when adding view as its own child ( #42108 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-10 10:30:58 +02:00
12bc4dc6c0
fix: `BrowserWindow.center()` should center relative to screen ( #42101 )
...
* fix: BrowserWindow.center() should center relative to screen
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: feedback from review & remove test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-09 10:43:41 +02:00
cdf508a734
chore: cherry-pick b2cc7b7ac538 from chromium ( #42095 )
...
* chore: cherry-pick b2cc7b7ac538 from chromium
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-08 14:29:58 -07:00
1dd99250c3
docs: make corrections for BrowserViews since it is deprecated ( #42084 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Peter Xu <sysu.peter.hsu@gmail.com>
2024-05-08 13:09:39 +02:00
d2cb956a75
docs: update formatting for mdx3 compatibility ( #42070 )
...
docs: update formatting for mdx3 compat
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-05-07 21:50:07 -05:00
004ca01049
fix: avoid crash after upgrade on Linux ( #42062 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>
2024-05-07 20:31:49 -04:00
ec4ffa99b6
fix: `requestFullscreen` from `WebContentsView` ( #41995 )
...
fix: requestFullscreen from WebContentsView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-05-01 12:59:39 -04:00
844265303c
fix: recentDocuments on macOS not working ( #41993 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-05-01 11:52:20 -04:00
aee588b650
chore: fixup gn check when enable_pdf_viewer is false ( #42009 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-05-01 09:20:03 -04:00
8f51e8fb5d
chore: disable tests that require nut.js ( #42010 )
...
* chore: disable tests that require nut.js
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! chore: disable tests that require nut.js
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-04-30 22:46:53 -04:00
773777f209
refactor: address changes and fix errors in `chrome://accessibility` ( #41948 )
...
refactor: address changes and fix errors in chrome://accessibility
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-04-23 21:14:14 -05:00
9437dd3ea8
docs: Windows typo in Tutorial document ( #41952 )
...
Update tutorial-6-publishing-updating.md
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: South Drifted <shiy2008@gmail.com>
2024-04-23 21:13:34 -05:00
fb5ffd2876
fix: `nativeImage.createThumbnailFromPath` and `shell.openExternal` in renderer ( #41908 )
...
* fix: nativeImage.createThumbnailFromPath in renderer
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* also fix shell.openExternal
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2024-04-23 15:12:46 -04:00
2d36065a15
docs: correct the return value for canceled showSaveDialog ( #41947 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
2024-04-23 12:49:30 -04:00
e19963b0ac
build: fixup codespaces on-create ( #41936 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-04-23 12:05:43 -04:00
9c631ea744
fix: data corruption in `protocol.handle` ( #41932 )
...
* fix: data corruption in protocol.handle
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* slice instead of subarray
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2024-04-23 09:51:31 -04:00
9ab77e77b1
fix: offscreen rendering does not paint after gpu process crashed ( #41924 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: zhangqi.67 <zhangqi.67@bytedance.com>
2024-04-22 14:51:42 -04:00
eb56416cb5
build: use latest devcontainer buildimage with codespaces ( #41922 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-04-22 11:10:18 -04:00
703241e1e7
fix: EINVAL when spawning cmd files on Windows ( #41906 )
...
fix: EINVAL when spawning on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-04-22 09:48:43 -04:00
0a8ed258da
build: enable Perfetto in Chromium ( #41910 )
...
* build: enable perfetto in Chromium
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: delete TracingControllerImpl
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: TraceObject isn't present when v8_use_perfetto is true
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: update lib/internal/http for perfetto
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: remove stray log
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-04-19 16:32:41 -04:00
7ef5402599
chore: remove unused hash function ( #41886 )
...
Unused since e1e73fa#24115
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-04-18 09:42:47 -04:00
a799513b2e
docs: update build docs,support Powershell on Windows ( #41882 )
...
* docs: update build docs,support Powershell on Windows
Co-authored-by: nashaofu <diaocheng@outlook.com>
* chore: fix capitalization
Co-authored-by: nashaofu <diaocheng@outlook.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: nashaofu <diaocheng@outlook.com>
2024-04-17 20:06:15 -04:00
bf754a3cae
fix: make window.flashFrame(bool) flash continuously on macOS ( #41391 )
...
fix: window.flashFrame to flash continuously on mac
This brings the behavior to parity with Windows and Linux. Prior behavior: The first `flashFrame(true)` bounces the dock icon only once (using the [NSInformationalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nsinformationalrequest ) level) and `flashFrame(false)` does nothing. New behavior: Flash continuously until `flashFrame(false)` is called. This uses the [NSCriticalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nscriticalrequest ) level instead. To explicitly use `NSInformationalRequest` to cause a single dock icon bounce, it is still possible to use [`dock.bounce('informational')`](https://www.electronjs.org/docs/latest/api/dock#dockbouncetype-macos ).
2024-04-17 12:42:34 -04:00
trop[bot]
Keeley Hammond
Shelley Vohr
Samuel Attard
James Yuzawa