From d9204d1a30c943baf288f30330c1322f49dd8b42 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Fri, 6 May 2022 13:16:58 -0700 Subject: [PATCH] build: switch from gh-contractor-zcbenz S3 bucket to artifacts.electronjs.org (#4263) * build: switch S3 buckets from gh-contractor-zcbenz to electronjs-artifacts * chore: add blog post * Update headers.js * Update s3-bucket-change.md * Update s3-bucket-change.md * Update s3-bucket-change.md --- data/blog/s3-bucket-change.md | 35 +++++++++++++++++++++++++++++++++++ routes/headers.js | 2 +- 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 data/blog/s3-bucket-change.md diff --git a/data/blog/s3-bucket-change.md b/data/blog/s3-bucket-change.md new file mode 100644 index 000000000..ec3581844 --- /dev/null +++ b/data/blog/s3-bucket-change.md @@ -0,0 +1,35 @@ +--- +title: "S3 Bucket Migration" +author: MarshallOfSound +date: '2022-05-06' +--- + +Electron is changing its primary S3 bucket, you may need to update your build scripts + +--- + +# What is happening? + +Currently a significant amount of Electrons build artifacts are uploaded to an S3 bucket called `gh-contractor-zcbenz`, as part of ongoing infrastructure / ownership migrations that started way back in 2020 we will be changing everything that used `gh-contractor-zcbenz` from it's current home in S3 to a new storage system hosted at `https://artifacts.electronjs.org`. The path prefix that most of our assets use is changing slightly as well. Examples are included below: + +**Before:** https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist/v17.0.0/node.lib +**After:** https://artifacts.electronjs.org/headers/dist/v17.0.0/node.lib + +The important things here are the **Hostname** changed and the `/atom-shell` **prefix** changed. Another example, this time for debug symbols: + +**Before:** https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/symbols/path/to/symbol.pdb +**After:** https://artifacts.electronjs.org/symbols/path/to/symbol.pdb + +Again, the hostname changed and the `/atom-shell` prefix was changed. + +# How might this impact you? + +For anyone using standard build tooling such as `electron-rebuild`, `electron-packager` or `@electron/get` you won't have to do anything, this should be the majority of people. + +For anyone directly referencing the S3 bucket, you must update your reference to point at the hostname and update the path as well. + +# What about existing data? + +Most data that existed on the `gh-contractor-zcbenz` bucket has been cloned into the new storage system. This means all debug symbols and all headers have been copied. If you relied on some data in that bucket that hasn't been copied over please raise an issue in [`electron/electron`](https://github.com/electron/electron) and let us know. + +The current `gh-contractor-zcbenz` S3 bucket will not be actively deleted however we can't guarantee how long that bucket will be left alive. We **strongly** reccomend updating to target the new bucket as soon as possible. diff --git a/routes/headers.js b/routes/headers.js index 947b4577f..40425fa0f 100644 --- a/routes/headers.js +++ b/routes/headers.js @@ -1,4 +1,4 @@ -const DIST_URL = 'https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist' +const DIST_URL = 'https://artifacts.electronjs.org/headers/dist' module.exports = (req, res, next) => { const url = req.params[0]