From e5fd4311b9b797404af93e98c420d67323776bce Mon Sep 17 00:00:00 2001 From: Robo Date: Fri, 31 Aug 2018 00:58:41 +0530 Subject: [PATCH] build: [gyp] explicitly override rtc_use_h264 (#667) --- chromiumcontent/args/shared_library.gn | 7 +++++++ chromiumcontent/args/static_library.gn | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/chromiumcontent/args/shared_library.gn b/chromiumcontent/args/shared_library.gn index bd30267f..63b2119b 100644 --- a/chromiumcontent/args/shared_library.gn +++ b/chromiumcontent/args/shared_library.gn @@ -11,6 +11,13 @@ proprietary_codecs = true is_component_ffmpeg = true ffmpeg_branding = "Chrome" +# This may be guarded behind is_chrome_branded alongside +# proprietary_codecs https://webrtc-review.googlesource.com/c/src/+/36321, +# explicitly override here to build OpenH264 encoder/FFmpeg decoder. +# The initialization of the decoder depends on whether ffmpeg has +# been built with H.264 support. +rtc_use_h264 = true + # Use the system provided standard library on platforms other than Linux. if (target_os != "linux") { use_custom_libcxx = false diff --git a/chromiumcontent/args/static_library.gn b/chromiumcontent/args/static_library.gn index bc81e062..72bbdbf5 100644 --- a/chromiumcontent/args/static_library.gn +++ b/chromiumcontent/args/static_library.gn @@ -10,6 +10,13 @@ proprietary_codecs = true is_component_ffmpeg = true ffmpeg_branding = "Chrome" +# This may be guarded behind is_chrome_branded alongside +# proprietary_codecs https://webrtc-review.googlesource.com/c/src/+/36321, +# explicitly override here to build OpenH264 encoder/FFmpeg decoder. +# The initialization of the decoder depends on whether ffmpeg has +# been built with H.264 support. +rtc_use_h264 = true + # CFI is disabled for the time being, as Electron is not a monolithic binary # with at least one shared library component (Node) and CFI is tricky in that # scenario