readline: don't cache the "keypress" listeners

it's not safe to since `removeAllListeners()` will detach the returned
Array from the stream instance if that's ever called by the user.
This commit is contained in:
Nathan Rajlich 2012-06-14 16:59:02 -07:00 коммит произвёл isaacs
Родитель c9a1b5d162
Коммит 032fc42e64
1 изменённых файлов: 2 добавлений и 4 удалений

Просмотреть файл

@ -786,10 +786,8 @@ function emitKeypressEvents(stream) {
if (stream._emitKeypress) return;
stream._emitKeypress = true;
var keypressListeners = stream.listeners('keypress');
function onData(b) {
if (keypressListeners.length) {
if (stream.listeners('keypress').length > 0) {
emitKey(stream, b);
} else {
// Nobody's watching anyway
@ -805,7 +803,7 @@ function emitKeypressEvents(stream) {
}
}
if (keypressListeners.length) {
if (stream.listeners('keypress').length > 0) {
stream.on('data', onData);
} else {
stream.on('newListener', onNewListener);