tools: Use `throw new Error()` consistently
In preparation for a lint rule that will enforce `throw new Error()` over `throw Error()`, fix the handful of instances in the code that use `throw Error()`. PR-URL: https://github.com/nodejs/node/pull/3714 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Родитель
0966ab9996
Коммит
35f2f64edd
|
@ -40,7 +40,7 @@ assert.strictEqual(42, makeCallback(recv, 'two', 1337));
|
||||||
const target = vm.runInNewContext(`
|
const target = vm.runInNewContext(`
|
||||||
(function($Object) {
|
(function($Object) {
|
||||||
if (Object === $Object)
|
if (Object === $Object)
|
||||||
throw Error('bad');
|
throw new Error('bad');
|
||||||
return Object;
|
return Object;
|
||||||
})
|
})
|
||||||
`);
|
`);
|
||||||
|
@ -55,7 +55,7 @@ const forward = vm.runInNewContext(`
|
||||||
// Runs in outer context.
|
// Runs in outer context.
|
||||||
const endpoint = function($Object) {
|
const endpoint = function($Object) {
|
||||||
if (Object === $Object)
|
if (Object === $Object)
|
||||||
throw Error('bad');
|
throw new Error('bad');
|
||||||
return Object;
|
return Object;
|
||||||
};
|
};
|
||||||
assert.strictEqual(Object, makeCallback(process, forward, endpoint));
|
assert.strictEqual(Object, makeCallback(process, forward, endpoint));
|
||||||
|
|
|
@ -466,6 +466,6 @@ testBlockTypeError(assert.doesNotThrow, undefined);
|
||||||
|
|
||||||
// https://github.com/nodejs/node/issues/3275
|
// https://github.com/nodejs/node/issues/3275
|
||||||
assert.throws(() => { throw 'error'; }, err => err === 'error');
|
assert.throws(() => { throw 'error'; }, err => err === 'error');
|
||||||
assert.throws(() => { throw Error(); }, err => err instanceof Error);
|
assert.throws(() => { throw new Error(); }, err => err instanceof Error);
|
||||||
|
|
||||||
console.log('All OK');
|
console.log('All OK');
|
||||||
|
|
|
@ -110,7 +110,7 @@ function nextTest() {
|
||||||
break;
|
break;
|
||||||
|
|
||||||
default:
|
default:
|
||||||
throw Error('?');
|
throw new Error('?');
|
||||||
}
|
}
|
||||||
|
|
||||||
response.setEncoding('utf8');
|
response.setEncoding('utf8');
|
||||||
|
|
|
@ -46,7 +46,7 @@ var timeToQuit = Date.now() + 8e3; //Test during no more than this seconds.
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
else {
|
else {
|
||||||
throw Error("Buffer GC'ed test -> FAIL");
|
throw new Error("Buffer GC'ed test -> FAIL");
|
||||||
}
|
}
|
||||||
|
|
||||||
if (Date.now() < timeToQuit) {
|
if (Date.now() < timeToQuit) {
|
||||||
|
|
|
@ -21,7 +21,7 @@ function tailCB(data) {
|
||||||
console.error('[FAIL]\n DATA -> ');
|
console.error('[FAIL]\n DATA -> ');
|
||||||
console.error(data);
|
console.error(data);
|
||||||
console.error('\n');
|
console.error('\n');
|
||||||
throw Error('Buffers GC test -> FAIL');
|
throw new Error('Buffers GC test -> FAIL');
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче