From 3b6a00b664afdc7695ddddefc637b1fbebf94fc6 Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Sat, 2 Jun 2012 16:01:18 +0200 Subject: [PATCH] Unbreak the Windows build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The v8 team apparently decided that all build products should go into ./build/«type», and updated their common.gypi file to do so. Unfortunately v8's common.gypi is only used for some targets. All the other targets would still look in the old place to find their their dependencies, which effectively broke the build. In the long run it would be good for node to send all build output to ./build too, on all platforms. --- deps/v8/build/common.gypi | 1 - 1 file changed, 1 deletion(-) diff --git a/deps/v8/build/common.gypi b/deps/v8/build/common.gypi index 72f7d354af..bc366d9ad1 100644 --- a/deps/v8/build/common.gypi +++ b/deps/v8/build/common.gypi @@ -239,7 +239,6 @@ 'WIN32', ], 'msvs_configuration_attributes': { - 'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)', 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)', 'CharacterSet': '1', },