collaborator_guide: clarify commit message rules
Italicize the full URL being required in metadata. PR-URL: https://github.com/nodejs/node/pull/5661 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
This commit is contained in:
Родитель
f2bd9cddee
Коммит
4c4d9aeff1
|
@ -93,14 +93,17 @@ information regarding the change process:
|
||||||
|
|
||||||
- A `Reviewed-By: Name <email>` line for yourself and any
|
- A `Reviewed-By: Name <email>` line for yourself and any
|
||||||
other Collaborators who have reviewed the change.
|
other Collaborators who have reviewed the change.
|
||||||
- A `PR-URL:` line that references the full GitHub URL of the original
|
- A `PR-URL:` line that references the *full* GitHub URL of the original
|
||||||
pull request being merged so it's easy to trace a commit back to the
|
pull request being merged so it's easy to trace a commit back to the
|
||||||
conversation that led up to that change.
|
conversation that led up to that change.
|
||||||
- A `Fixes: X` line, where _X_ is either includes the full GitHub URL
|
- A `Fixes: X` line, where _X_ either includes the *full* GitHub URL
|
||||||
for an issue, and/or the hash and commit message if the commit fixes
|
for an issue, and/or the hash and commit message if the commit fixes
|
||||||
a bug in a previous commit. Multiple `Fixes:` lines may be added if
|
a bug in a previous commit. Multiple `Fixes:` lines may be added if
|
||||||
appropriate.
|
appropriate.
|
||||||
|
|
||||||
|
Review the commit message to ensure that it adheres to the guidelines
|
||||||
|
outlined in the [contributing](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit) guide.
|
||||||
|
|
||||||
See the commit log for examples such as
|
See the commit log for examples such as
|
||||||
[this one](https://github.com/nodejs/node/commit/b636ba8186) if unsure
|
[this one](https://github.com/nodejs/node/commit/b636ba8186) if unsure
|
||||||
exactly how to format your commit messages.
|
exactly how to format your commit messages.
|
||||||
|
|
Загрузка…
Ссылка в новой задаче