From a72bfb94ddb27b1c8cff229702f32df46233506c Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 19 Mar 2018 12:04:29 -0700 Subject: [PATCH] doc: simplify COLLABORATOR_GUIDE.md instructions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove bulleted list formatting. Only check email/name for new contributors. Change `full name` to `name` and remove italics to avoid incorrect implication that we need a "legal name". PR-URL: https://github.com/nodejs/node/pull/19458 Reviewed-By: Colin Ihrig Reviewed-By: Michaƫl Zasso Reviewed-By: Richard Lau Reviewed-By: Daniel Bevenius Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Jon Moss --- COLLABORATOR_GUIDE.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 6ffa73c2ff..882b2555d8 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -494,12 +494,11 @@ The TSC should serve as the final arbiter where required. one](https://github.com/nodejs/node/commit/b636ba8186) if unsure exactly how to format your commit messages. -Additionally: +Check PRs from new contributors to make sure the person's name and email address +are correct before merging. -* Double check PRs to make sure the person's _full name_ and email - address are correct before merging. -* All commits should be self-contained (meaning every commit should pass all - tests). This makes it much easier when bisecting to find a breaking change. +All commits should be self-contained, meaning every commit should pass all +tests. This makes it much easier when bisecting to find a breaking change. ### Using `git-node`