From dbf0d6bb70902fba80b10adccf3f54fe9cf5beb7 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 4 Oct 2010 12:52:46 -0700 Subject: [PATCH] ClearWeak on ObjectWraps. I /think/ this is the correct semantics --- src/node_object_wrap.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/node_object_wrap.h b/src/node_object_wrap.h index 8eafd891cf..fba40fb2c6 100644 --- a/src/node_object_wrap.h +++ b/src/node_object_wrap.h @@ -16,6 +16,7 @@ class ObjectWrap { virtual ~ObjectWrap ( ) { if (!handle_.IsEmpty()) { assert(handle_.IsNearDeath()); + handle_.ClearWeak(); handle_->SetInternalField(0, v8::Undefined()); handle_.Dispose(); handle_.Clear(); @@ -82,7 +83,8 @@ class ObjectWrap { ObjectWrap *obj = static_cast(data); assert(value == obj->handle_); assert(!obj->refs_); - if (value.IsNearDeath()) delete obj; + assert(value.IsNearDeath()); + delete obj; } };