diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5352fd4..efc26d7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,5 +1,5 @@ # Contributing -Please note that the Steeltoe project has adopted the [Contributor Code of Conduct](http://www.dotnetfoundation.org/code-of-conduct). By participating in this project you agree to abide by its terms. +Please note that the Steeltoe project has adopted the [Contributor Code of Conduct](https://www.dotnetfoundation.org/code-of-conduct). By participating in this project you agree to abide by its terms. For more information on how to get involved and to view our project governance model, please read our [contributing guidelines](project-docs/contributing.md). \ No newline at end of file diff --git a/README.md b/README.md index a757597..cbbe967 100644 --- a/README.md +++ b/README.md @@ -104,8 +104,8 @@ The Steeltoe project welcomes contributions both by filing issues and through PR Check out the [contributing](https://github.com/SteeltoeOSS/Home/tree/master/project-docs/contributing.md) page to see how you can get involved and contribute to Steeltoe. -Also its worth noting, the Steeltoe project has adopted the code of conduct defined by the [Contributor Covenant](http://contributor-covenant.org/). -If you'd like more information, see the [.NET Foundation Code of Conduct](http://www.dotnetfoundation.org/code-of-conduct) write-up. +Also its worth noting, the Steeltoe project has adopted the code of conduct defined by the [Contributor Covenant](https://contributor-covenant.org/). +If you'd like more information, see the [.NET Foundation Code of Conduct](https://www.dotnetfoundation.org/code-of-conduct) write-up. ## Governance Model diff --git a/project-docs/contributing-code-style.md b/project-docs/contributing-code-style.md index c5f16e4..e002bbc 100644 --- a/project-docs/contributing-code-style.md +++ b/project-docs/contributing-code-style.md @@ -6,7 +6,7 @@ This guide provides instructions which you can follow that will help you during While we likely are not completely consistent throughout our code base, we are striving to be better, so please try to follow our coding guidelines. The general set of rules we try to follow is to use "Visual Studio defaults". As an FYI, most of these guidelines come from the `corefx` C# coding style guide. -1. We use [Allman style](http://en.wikipedia.org/wiki/Indent_style#Allman_style) braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and it must not be nested in other statement blocks that use braces. +1. We use [Allman style](https://en.wikipedia.org/wiki/Indent_style#Allman_style) braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and it must not be nested in other statement blocks that use braces. 1. We use four spaces of indentation (no tabs). 1. We use `_camelCase` for internal and private fields and use `readonly` where possible. Prefix instance fields with `_`, static fields with `s_` and thread static fields with `t_`. When used on static fields, `readonly` should come after `static` (i.e. `static readonly` not `readonly static`). 1. We avoid `this.` unless absolutely necessary. diff --git a/project-docs/contributing-license.md b/project-docs/contributing-license.md index 26715b5..4fe3831 100644 --- a/project-docs/contributing-license.md +++ b/project-docs/contributing-license.md @@ -1,8 +1,8 @@ # Contributor License Agreement -You must sign a [.NET Foundation Contribution License Agreement (CLA)](http://cla2.dotnetfoundation.org) before your Pull Request will be merged. This is a one-time requirement for projects in the .NET Foundation. You can read more about [Contribution License Agreements (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) on Wikipedia. +You must sign a [.NET Foundation Contribution License Agreement (CLA)](https://cla.dotnetfoundation.org) before your Pull Request will be merged. This is a one-time requirement for projects in the .NET Foundation. You can read more about [Contribution License Agreements (CLA)](https://en.wikipedia.org/wiki/Contributor_License_Agreement) on Wikipedia. -The agreement: [net-foundation-contribution-license-agreement.pdf](https://cla2.dotnetfoundation.org/cladoc/net-foundation-contribution-license-agreement.pdf) +The agreement: [net-foundation-contribution-license-agreement.pdf](https://cla.dotnetfoundation.org/cladoc/net-foundation-contribution-license-agreement.pdf) You don't have to do this up-front. You can simply clone, fork, and submit your pull-request as usual. When your pull-request is created, it is classified by a CLA bot. If the change is trivial (for example, you just fixed a typo), then the PR is labelled with cla-not-required. Otherwise it's classified as cla-required. Once you signed a CLA, the current and all future pull-requests will be labelled as cla-signed. diff --git a/project-docs/contributing-workflow.md b/project-docs/contributing-workflow.md index 17da701..14e64f3 100644 --- a/project-docs/contributing-workflow.md +++ b/project-docs/contributing-workflow.md @@ -29,7 +29,7 @@ You should **never** work on a clone of `master`, and you should **never** send While you're working away in your branch it's quite possible that the upstream `dev` branch will be updated. If this happens you should: -1. [Stash](http://git-scm.com/book/en/v2/Git-Tools-Stashing-and-Cleaning) any un-committed changes you need to save +1. [Stash](https://git-scm.com/book/en/v2/Git-Tools-Stashing-and-Cleaning) any un-committed changes you need to save 1. `git checkout dev` 1. `git pull upstream dev` 1. `git rebase dev myBranch` @@ -52,7 +52,7 @@ The systems we use for CI (i.e. AppVeyor and Travis) will automatically perform ## Commit Messages -Please format commit messages as follows (based on [A Note About Git Commit Messages](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)): +Please format commit messages as follows (based on [A Note About Git Commit Messages](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)): ```text Summarize change in 50 characters or less