From 30974cb895756e159d21403c5960d52f0c55dfd7 Mon Sep 17 00:00:00 2001 From: "Thomas M. DuBuisson" Date: Mon, 3 Aug 2020 19:12:34 -0700 Subject: [PATCH] travis/script.sh: fix use of `-n' with unquoted envvar Shellcheck tells us "-n doesn't work with unquoted arguments. quote or use [[ ]]." And testing shows: ``` docker run --rm -it ubuntu bash root@fe85ce156856:/# [ -n $DOES_NOT_EXIST ] && echo "I ran" I ran root@fe85ce156856:/# [ -n "$DOES_NOT_EXIST" ] && echo "I ran" root@fe85ce156856:/# ``` Closes #5773 --- scripts/travis/script.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/travis/script.sh b/scripts/travis/script.sh index b71f20a66..147b62886 100755 --- a/scripts/travis/script.sh +++ b/scripts/travis/script.sh @@ -84,7 +84,7 @@ if [ "$T" = "normal" ]; then if [ -z $NOTESTS ]; then make test-nonflaky fi - if [ -n $CHECKSRC ]; then + if [ -n "$CHECKSRC" ]; then make checksrc fi fi