From c2127b448df1bfab99f3ea9b2bd2eaf0e68701e1 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Wed, 15 Feb 2017 15:12:32 +0100 Subject: [PATCH] TODO: consider file name from the redirected URL with -O ? It isn't easily solved, but with some thinking someone could probably come up with a working approach? Closes #1241 --- docs/TODO | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/docs/TODO b/docs/TODO index 20944b27a..06142f86c 100644 --- a/docs/TODO +++ b/docs/TODO @@ -151,6 +151,7 @@ 18.14 --fail without --location should treat 3xx as a failure 18.15 --retry should resume 18.16 send only part of --data + 18.17 consider file name from the redirected URL with -O ? 19. Build 19.1 roffit @@ -1026,6 +1027,25 @@ that doesn't exist on the server, just like --ftp-create-dirs. See https://github.com/curl/curl/issues/1200 +18.17 consider file name from the redirected URL with -O ? + + When a user gives a URL and uses -O, and curl follows a redirect to a new + URL, the file name is not extracted and used from the newly redirected-to URL + even if the new URL may have a much more sensible file name. + + This is clearly documented and helps for security since there's no surprise + to users which file name that might get overwritten. But maybe a new option + could allow for this or maybe -J should imply such a treatment as well as -J + already allows for the server to decide what file name to use so it already + provides the "may overwrite any file" risk. + + This is extra tricky if the original URL has no file name part at all since + then the current code path will error out with an error message, and we can't + *know* already at that point if curl will be redirected to a URL that has a + file name... + + See https://github.com/curl/curl/issues/1241 + 19. Build 19.1 roffit