c8a7df108f
security: Pass the right parameter to init.
...
init is expecting app_data. Passing it the struct connecdata would make
us crash later.
2010-11-12 08:24:32 -08:00
0152dbbe23
krb4: make a few functions static
2010-10-18 10:00:37 +02:00
87badbef84
krb5-gssapi: Remove several memory leaks.
...
Remove a leak seen on Kerberos/MIT (gss_OID is copied internally and
we were leaking it). Now we just pass NULL as advised in RFC2744.
|tmp| was never set back to buf->data.
Cleaned up Curl_sec_end to take into account failure in Curl_sec_login
(where conn->mech would be NULL but not conn->app_data or
conn->in_buffer->data).
2010-09-28 22:05:24 -07:00
e3811ed7c3
security.c: Remove Curl_sec_fflush_fd.
...
The current implementation would make us send wrong data on a closed
socket. We don't buffer our data so the method can be safely removed.
2010-09-28 22:05:24 -07:00
dacc44ddc2
security.c: We should always register the socket handler.
...
Following a change in the way socket handler are registered, the custom
recv and send method were conditionaly registered.
We need to register them everytime to handle the ftp security
extensions.
Re-added the clear text handling in sec_recv.
2010-09-28 22:05:24 -07:00
fc9f369829
security.c: Fix Curl_sec_login after rewrite.
...
Curl_sec_login was returning the opposite result that the code in ftp.c
was expecting. Simplified the return code (using a CURLcode) so to see
more clearly what is going on.
2010-09-28 22:05:24 -07:00
bfbc4c7e00
security.c: Readd the '\n' to the infof() calls.
...
They are not automatically added and make the output of the verbose
mode a lot more readable.
2010-09-28 22:05:24 -07:00
05b72a6af2
security.c: Fix typo (PSBZ -> PBSZ)
2010-09-28 22:05:24 -07:00
1e2056fecb
security.c: Fix ftp_send_command.
...
My use of va_args was completely wrong. Fixed the usage so that
we send the right commands!
2010-09-28 22:05:24 -07:00
a10f5b34ff
Revert "security.c: buffer_read various fixes."
...
This reverts commit fbb38de415
2010-09-24 00:20:02 +02:00
b1df37c60e
security.c: removed superfluous parentheses
...
And also removed the FIXME where memory was zeroed just before freed,
and some other minor whitespace changes.
2010-09-22 23:41:28 +02:00
31d59fb2cc
security.c: Update the #include statements after the rewrite.
2010-09-22 23:34:36 +02:00
562d40e671
security.c: sec_write tweaks
...
- |fd| is now a curl_socket_t and |len| a size_t to avoid conversions.
- Added 2 FIXMEs about the 2 unsigned -> signed conversions.
- Included 2 minor changes to Curl_sec_end.
2010-09-22 23:34:36 +02:00
612832e4c0
security.c: _sec_send tweaks
...
- Renamed the method to sec_send now that we
renamed sec_send to do_sec_send.
- Some more variable renaming.
2010-09-22 23:34:36 +02:00
3c69a08e3b
security.c: sec_read tweaks
...
- Renamed the function to sec_recv.
- Renamed the parameters and variable to match the rest of the code.
2010-09-22 23:34:36 +02:00
5ea9e78bd7
security.c: Curl_sec_fflush_fd tweaks
...
- Use an early return as it makes the code more readable.
- Added a FIXME about a conversion.
2010-09-22 23:34:36 +02:00
69d7c48072
security.c: sec_send tweaks
...
- Renamed it to do_sec_send as it is the function doing the actual
transfer.
- Do not return any values as no one was checking it and it never
reported a failure (added a FIXME about checking for errors).
- Renamed the variables to make their use more specific.
- Removed some casts (int -> curl_socket_t, ...)
- Avoid doing the htnl <-> nthl twice by caching the 2 results.
2010-09-22 23:34:36 +02:00
7d4f8c2809
security.c: Curl_sec_read_msg tweaks
...
- Renamed the variables name to better match their intend.
- Unified the |decoded_len| checks.
- Added some FIXMEs to flag some improvement that did not go in this
change.
2010-09-22 23:34:36 +02:00
d23c59ecfc
security.c: Curl_sec_set_protection_level tweaking
...
- Removed sec_prot_internal as it is now inlined in the function (this removed
a redundant check).
- Changed the prototype to return an error code.
- Updated the method to use the new ftp_send_command function.
- Added a level_to_char helper method to avoid relying on the compiler's
bound checks. This default to the maximum security we have in case of a
wrong input.
2010-09-22 23:34:36 +02:00
1d95a48fe9
security.c: factored the logic from Curl_sec_login into a dedicated method that better reflect its intent.
...
Introduced a helper method ftp_send_command that synchronously send
an FTP query.
2010-09-22 23:34:36 +02:00
512a82d395
security.c: Remove out_buffer as it was never written into.
2010-09-22 23:34:36 +02:00
fbb38de415
security.c: buffer_read various fixes.
...
Tighten the type of the |data| parameter to avoid a cast. Also made
it const as we should not modify it.
Added a DEBUGASSERT on the size to be written while changing it.
2010-09-22 23:34:36 +02:00
0006cdddee
security.c: Made block_write return a CURLcode.
...
While doing so, renamed it to socket_write to better match its
function.
2010-09-22 23:34:36 +02:00
b684ccd8b1
security.c: Made block_read and sec_get_data return CURLcode.
...
To do so, made block_read call Curl_read_plain instead of read.
While changing them renamed block_read to socket_read and sec_get_data
to read_data to better match their function.
Also fixed a potential memory leak in block_read.
2010-09-22 23:34:36 +02:00
3f64d05d34
Security.c: Fix headers guard to match the rest of the code.
2010-09-22 23:34:35 +02:00
bc8fc9803f
sendrecv: make them two pairs of send/recv to properly deal with FTPS
...
FTP(S) use two connections that can be set to different recv and
send functions independently, so by introducing recv+send pairs
in the same manner we already have sockets/connections we can
work with FTPS fine.
This commit fixes the FTPS regression introduced in change d64bd82
2010-05-11 22:48:38 +02:00
d64bd82bdc
sendrecv: split the I/O handling into private handler
...
Howard Chu brought the bulk work of this patch that properly
moves out the sending and recving of data to the parts of the
code that are properly responsible for the various ways of doing
so.
Daniel Stenberg assisted with polishing a few bits and fixed some
minor flaws in the original patch.
Another upside of this patch is that we now abuse CURLcodes less
with the "magic" -1 return codes and instead use CURLE_AGAIN more
consistently.
2010-05-07 15:05:34 +02:00
4e75c70874
silence a compiler warning
2009-07-11 09:57:54 +00:00
33a3753c3f
libcurl's memory.h renamed to curl_memory.h
2009-04-21 11:46:16 +00:00
484d549ece
Marked with TODO comments a number of problems in the Kerberos code detected
...
while investigating the issue in http://curl.haxx.se/mail/lib-2008-09/0262.html
I'm hesitant to fix them because I have no way of testing the result.
2008-11-02 05:01:39 +00:00
b701ea36a7
moved the Curl_raw_ functions into the new lib/rawstr.c file for easier curlx_
...
inclusion by the curl tool without colliding with the curl_strequal functions.
2008-10-23 11:49:19 +00:00
6c14c96e71
added include to make the krb4 code compile again
2008-10-23 08:06:47 +00:00
bab5183820
Created Curl_raw_nequal() which does a C-locale string case comparison.
...
Changed checkprefix() to use it and those instances of strnequal() that
compare host names or other protocol strings that are defined to be
independent of case in the C locale. This should fix a few more
Turkish locale problems.
2008-10-23 01:20:57 +00:00
ac18b471d2
libcurl internal base64.h header file renamed to curl_base64.h
2008-08-17 00:25:38 +00:00
d6f8f16068
fix: preprocessor complaining about macro redefinition
2008-05-26 01:59:00 +00:00
4aa176c127
Fixed some include file problems on Windows reported by David Rosenstrauch
2008-05-22 19:44:10 +00:00
e2b82b4325
- Make Curl_write and it's callees accept a const pointer, in preparation
...
of tetetest's patch for curl_easy_send()
2008-05-09 11:27:54 +00:00
cbd1a77ec2
if () => if()
...
while () => while()
and some other minor re-indentings
2007-11-07 09:21:35 +00:00
74ad8516d7
Thomas J. Moore made it build with less warnings
2007-07-06 22:14:29 +00:00
54967d2a3a
Thomas J. Moore provided a patch that introduces Kerberos5 support in
...
libcurl. This also makes the options change name to --krb (from --krb4) and
CURLOPT_KRBLEVEL (from CURLOPT_KRB4LEVEL) but the old names are still
2007-07-01 22:01:18 +00:00
be0d17e812
cleaned up Curl_write() and the sub functions it uses for various protocols.
...
They all now return ssize_t to Curl_write().
Unfortunately, Curl_read() is in a sorrier state but it too would benefit from
a similar cleanup.
2006-11-11 21:34:43 +00:00
62970da675
Removed security.h since it shadows an include file mingw needs when building
...
for SSPI support. The contents of the file has been moved into the krb4.h file.
2005-03-14 00:00:45 +00:00
f8b4ba80e0
krb4 fixed
2005-02-22 12:20:30 +00:00
a28b32aa45
Make some arrays of pointers const, too.
2004-12-15 02:32:04 +00:00
1ba47e7af9
Add 'const' to immutable arrays.
2004-12-15 01:38:25 +00:00
62f97f1817
use curl_strnequal(), not strncasecmp()
2004-10-07 22:56:24 +00:00
39af394a1c
removed tabs and trailing whitespace from source
2004-10-06 07:50:18 +00:00
6c3759d78d
removed trailing whitespace, free a missing malloc when returning error
2004-06-30 11:51:24 +00:00
bbafb2eb27
curl_global_init_mem() allows the memory functions to be replaced.
...
memory.h is included everywhere for this.
2004-05-11 11:30:23 +00:00
800052dc50
use the HAVE_KRB4 define instead of just KRB4
2003-12-02 13:27:29 +00:00
308bc9d919
use CURLDEBUG instead of MALLOCDEBUG for preprocessor conditions
2003-06-26 11:22:12 +00:00
a7c72b7abf
removed the local variables for emacs and vim, use the new sample.emacs
...
way for emacs, and vim users should provide a similar non-polluting style
2003-01-29 10:14:20 +00:00
a15133f5cf
removed unused code
2003-01-09 11:50:34 +00:00
d0b97f7e1f
Curl_GetFTPResponse() takes a different set of parameters and now return a
...
proper CURLcode. The default timeout for reading one response is now also
possible to change while running.
2002-12-03 10:25:31 +00:00
08ef208fb7
added disable-[protocol] support, largely provided by Miklos Nemeth
2002-06-11 11:13:01 +00:00
e192261788
failf() calls should not have newlines in the message string!
2001-12-11 13:13:01 +00:00
4118c68df1
check Curl_ftpsendf return codes
2001-10-31 15:06:38 +00:00
8e91d5de8e
looks nicer and is better compatible with older vim versions
2001-10-11 09:32:19 +00:00
88e21894c7
improved readability slightly
2001-09-28 09:25:59 +00:00
09da2c1767
fixed the missing getftpresponse edits
2001-09-28 09:19:35 +00:00
ae2ecfc5cb
removed the socket argument from some functions that always passed in the
...
same socket and it was available from the passed-in struct anyway!
2001-09-28 09:15:19 +00:00
6147879837
Added formatting sections for emacs and vim
2001-09-07 04:01:32 +00:00
47e7a3e678
a few more struct fixes
2001-08-30 22:59:58 +00:00
0ece1b5c34
Major rename and redesign of the internal "backbone" structs. Details will
...
be posted in a minute to the libcurl list.
2001-08-30 22:48:34 +00:00
a2688b6ca1
removed dead/unused code
...
removed use of global variables
removed name space pollutions (added Curl_ prefixes)
2001-08-17 10:11:46 +00:00
8e1f95ac7d
cleaned up some picky compiler warnings and indented the code curl style
2001-08-14 08:32:50 +00:00
a1d6ad2610
multiple connection support initial commit
2001-02-20 17:35:51 +00:00
4031104404
Internal symbols that aren't static are now prefixed with 'Curl_'
2001-01-05 10:11:41 +00:00
0f8facb49b
added memory debugging include file
2000-10-09 11:12:34 +00:00
91bda5650c
include base64.h instead of base64_krb.h
2000-09-28 10:36:31 +00:00
1dac7f4d05
Martin Hedenfalk added sec_fflush_fd()
2000-09-25 22:15:56 +00:00
def69c3087
new for kerberos support
2000-09-21 08:46:14 +00:00
Julien Chaffraix
Daniel Stenberg
Howard Chu
Yang Tse
Dan Fandrich
Michal Marek
Sterling Hughes