From 2b6ac966c0143a6b5535126f0337df0aefaa9fad Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 5 Jan 2016 13:45:34 +0800 Subject: [PATCH] Do not write our own filter code The Win32 API has done everything for us, there is no need to do this oursevles. --- atom/browser/ui/file_dialog_win.cc | 25 +------------------------ 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/atom/browser/ui/file_dialog_win.cc b/atom/browser/ui/file_dialog_win.cc index f39094f9d..6577e4c08 100644 --- a/atom/browser/ui/file_dialog_win.cc +++ b/atom/browser/ui/file_dialog_win.cc @@ -262,30 +262,7 @@ bool ShowSaveDialog(atom::NativeWindow* parent_window, if (FAILED(hr)) return false; - std::string file_name = base::WideToUTF8(std::wstring(buffer)); - - // Append extension according to selected filter. - if (!filters.empty()) { - UINT filter_index = 1; - save_dialog.GetPtr()->GetFileTypeIndex(&filter_index); - const Filter& filter = filters[filter_index - 1]; - - bool matched = false; - for (size_t i = 0; i < filter.second.size(); ++i) { - if (filter.second[i] == "*" || - base::EndsWith( - file_name, filter.second[i], - base::CompareCase::INSENSITIVE_ASCII)) { - matched = true; - break;; - } - } - - if (!matched && !filter.second.empty()) - file_name += ("." + filter.second[0]); - } - - *path = base::FilePath(base::UTF8ToUTF16(file_name)); + *path = base::FilePath(buffer); return true; }