From 3deffa859d5dde1e4555981774f31eb841b15001 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 23 May 2018 09:24:32 -0700 Subject: [PATCH] remove appcommand media-play_pause option deprecation --- atom/browser/native_window_views_win.cc | 4 ---- docs/tutorial/planned-breaking-changes.md | 13 ------------- 2 files changed, 17 deletions(-) diff --git a/atom/browser/native_window_views_win.cc b/atom/browser/native_window_views_win.cc index 430f30904..c9802b2e0 100644 --- a/atom/browser/native_window_views_win.cc +++ b/atom/browser/native_window_views_win.cc @@ -143,10 +143,6 @@ bool NativeWindowViews::ExecuteWindowsCommand(int command_id) { std::string command = AppCommandToString(command_id); NotifyWindowExecuteWindowsCommand(command); - if (command_id == APPCOMMAND_MEDIA_PLAY_PAUSE) - // FIXME(htk3): Remove media-play_pause in 3.0 - NotifyWindowExecuteWindowsCommand("media-play_pause"); - return false; } diff --git a/docs/tutorial/planned-breaking-changes.md b/docs/tutorial/planned-breaking-changes.md index 2785527f0..dc03ed6a2 100644 --- a/docs/tutorial/planned-breaking-changes.md +++ b/docs/tutorial/planned-breaking-changes.md @@ -14,19 +14,6 @@ let windowA = new BrowserWindow(optionsA) // Replace with let optionsB = {webPreferences: {enableBlinkFeatures: ''}} let windowB = new BrowserWindow(optionsB) - -// Deprecated -window.on('app-command', (e, cmd) => { - if (cmd === 'media-play_pause') { - // do something - } -}) -// Replace with -window.on('app-command', (e, cmd) => { - if (cmd === 'media-play-pause') { - // do something - } -}) ``` ## `nativeImage`