🎨

lib/browser/guest-window-manager.js

@@ -120,14 +120,13 @@ const createGuest = function (embedder, url, frameName, options, postData) {
     // The above code would not work if a navigation to "about:blank" is done
     // here, since the window would be cleared of all changes in the next tick.
     const loadOptions = {}
-    if (postData) {
+    if (postData != null) {
       loadOptions.postData = postData
       loadOptions.extraHeaders = 'content-type: application/x-www-form-urlencoded'
-      if (postData.length) {
+      if (postData.length > 0) {
         const postDataFront = postData[0].bytes.toString()
-        const regex = new RegExp(/^--.*[^-\r\n]/)
-        const boundary = regex.exec(postDataFront)
-        if (boundary) {
+        const boundary = /^--.*[^-\r\n]/.exec(postDataFront)
+        if (boundary != null) {
           loadOptions.extraHeaders = `content-type: multipart/form-data; boundary=${boundary[0].substr(2)}`
         }
       }

spec/api-browser-window-spec.js

@@ -29,15 +29,15 @@ describe('browser-window module', function () {
     const fileStats = fs.statSync(filePath)
     postData = [
       {
-        'type': 'rawData',
-        'bytes': new Buffer('username=test&file=')
+        type: 'rawData',
+        bytes: new Buffer('username=test&file=')
       },
       {
-        'type': 'file',
-        'filePath': filePath,
-        'offset': 0,
-        'length': fileStats.size,
-        'modificationTime': fileStats.mtime.getTime() / 1000
+        type: 'file',
+        filePath: filePath,
+        offset: 0,
+        length: fileStats.size,
+        modificationTime: fileStats.mtime.getTime() / 1000
       }
     ]
     server = http.createServer(function (req, res) {