do more manual cleanup and specify globals

lib/common/asar.js

@@ -1,3 +1,5 @@
+/* globals $, xit */
+
 (function () {
   const asar = process.binding('atom_common_asar')
   const child_process = require('child_process')

lib/renderer/inspector.js

@@ -1,3 +1,5 @@
+/* globals InspectorFrontendHost, WebInspector, DevToolsAPI, DevToolsAPI, Blob */
+
 window.onload = function () {
   // Use menu API to show context menu.
   InspectorFrontendHost.showContextMenuAtPoint = createMenu

package.json

@@ -12,7 +12,8 @@
   },
   "standard": {
     "ignore": ["/vendor"],
-    "globals": ["afterEach", "beforeEach", "describe", "it", "location"]
+    "globals": ["$", "after", "afterEach", "before",
+      "beforeEach", "describe", "it", "location"]
   },
   "private": true,
   "scripts": {

spec/api-web-request-spec.js

@@ -1,3 +1,5 @@
+/* globals $ */
+
 const assert = require('assert')
 const http = require('http')
 const qs = require('querystring')

spec/fixtures/module/fork_ping.js

@@ -1,8 +1,10 @@
+const path = require('path')
+
 process.on('uncaughtException', function (error) {
   process.send(error.stack)
 })
 
-var child = require('child_process').fork(__dirname + '/ping.js')
+var child = require('child_process').fork(path.join(__dirname, '/ping.js'))
 process.on('message', function (msg) {
   child.send(msg)
 })

spec/fixtures/module/function.js

@@ -1 +1 @@
-exports.aFunction = function () { return 1127; }
+exports.aFunction = function () { return 1127 }

spec/fixtures/module/locale-compare.js

@@ -2,6 +2,6 @@ process.on('message', function () {
   process.send([
     'a'.localeCompare('a'),
     'ä'.localeCompare('z', 'de'),
-    'ä'.localeCompare('a', 'sv', { sensitivity: 'base' }),
+    'ä'.localeCompare('a', 'sv', { sensitivity: 'base' })
   ])
 })

spec/fixtures/pages/service-worker/service-worker.js

@@ -1,3 +1,5 @@
+/* globals self, URL, Response */
+
 self.addEventListener('fetch', function (event) {
   var requestUrl = new URL(event.request.url)
 

spec/node-spec.js

@@ -1,3 +1,5 @@
+/* globals xit */
+
 const assert = require('assert')
 const child_process = require('child_process')
 const fs = require('fs')

spec/static/main.js

@@ -17,7 +17,7 @@ var argv = require('yargs')
   .argv
 
 var window = null
-process.port = 0; // will be used by crash-reporter spec.
+process.port = 0 // will be used by crash-reporter spec.
 
 app.commandLine.appendSwitch('js-flags', '--expose_gc')
 app.commandLine.appendSwitch('ignore-certificate-errors')
@@ -48,7 +48,7 @@ ipcMain.on('process.exit', function (event, code) {
 })
 
 ipcMain.on('eval', function (event, script) {
-  event.returnValue = eval(script)
+  event.returnValue = eval(script) // eslint-disable-line
 })
 
 ipcMain.on('echo', function (event, msg) {
@@ -84,10 +84,10 @@ app.on('ready', function () {
     height: 600,
     webPreferences: {
       javascript: true // Test whether web preferences crashes.
-    },
+    }
   })
   window.loadURL(url.format({
-    pathname: __dirname + '/index.html',
+    pathname: path.join(__dirname, '/index.html'),
     protocol: 'file',
     query: {
       grep: argv.grep,