795447f61a
Implement dialog (alert/confirm) blocking as a user switch after the first dialog
...
* This is to enable more browser-like behavior so that users who run third-party code
will not be DOS'ed with alerts and confirms. This is already handled like this
in most major browsers so this will greatly help these developers
2018-03-06 11:19:15 +09:00
199cf31b9e
deprecate screen.getMenuBarHeight
2018-03-05 19:45:51 -05:00
35cbe9d140
Fix dockMenu not being referenced in JavaScript ( #12062 )
...
* Fix dockMenu not being referenced in JavaScript
* spec: Test garbage collecting dock menu
2018-02-26 22:15:06 -08:00
18362eb948
improve Menu and MenuItem testing ( #12015 )
...
* split menu/menuitem and add some tests
* fix ipc send issue
* feedback: make tests less brittle
* clean up MenuItem accelerator and label tests
2018-02-23 07:53:59 -06:00
2a97e48465
Merge pull request #11968 from electron/refactor-menu-popup
...
Refactor menu.popup
2018-02-21 14:29:52 -05:00
0ef8f1bdad
Add deprecation warnings fot html/rtf methods ( #11995 )
2018-02-21 06:53:48 -06:00
772a69e24a
deprecate autoSubmit in favor of uploadToServer ( #11992 )
2018-02-20 22:31:48 -06:00
193febd18c
deprecate boolean highlightMode param ( #11993 )
...
* deprecate boolean highlightMode param
* add process.noDeprecations check
* fix native method override
* add todo
2018-02-20 22:30:32 -06:00
719e5a93b4
deprecation for webContents.openDevTools ( #11986 )
...
* deprecate old openDevTools param
* add deprecation check and existence check
* fix method issues
2018-02-20 22:30:02 -06:00
f59d078eea
Use more idiomatic JS in WebContents' init()
2018-02-20 19:20:11 -06:00
9c56b81b71
Throw an error if menu.popup() has no window
2018-02-20 18:38:05 -06:00
5a25b88b50
Fix browserWindow detection in menu.popup()
2018-02-20 18:35:39 -06:00
708f39a1a5
update a few menu.popup() calls to use the new API
2018-02-20 14:02:24 -06:00
5065e159f1
positionItem => positioningItem
2018-02-20 11:28:34 -05:00
dc62e51ba4
Fix the cyclic reference in menu delegate ( #11967 )
...
* Fix the cyclic reference in menu delegate
* Fix menu tests due to delegate change
2018-02-20 10:11:35 -06:00
fb7fb4972d
options all the things
2018-02-20 11:10:53 -05:00
e1b81b8a62
remove support for crashReporter autoSubmit ( #11976 )
2018-02-20 10:10:35 -06:00
8d4bf3e29a
Merge pull request #11974 from electron/remove-setZoomLevelLimits
...
remove setZoomLevelLimits
2018-02-20 10:51:41 -05:00
211b542ae4
remove setZoomLevelLimits
2018-02-20 08:57:48 -05:00
1a3661206e
remove unused deprecate module from crashreporter
2018-02-20 08:31:38 -05:00
fc025064f7
remove setExtraParameter for 2.0
2018-02-20 08:26:10 -05:00
56f06187d5
forgot to remove old method
2018-02-19 21:03:10 -05:00
6e11a3e53d
add restructured window.popup
2018-02-19 20:59:27 -05:00
cd9e7142e4
add conditional for menu.popup(window, callback)
2018-02-19 13:06:37 -05:00
a20b379f26
fix windows tests
2018-02-16 16:02:10 +11:00
6318cd781d
Update to use Squirrel.Mac that supports CDN releases
2018-02-15 14:00:46 +11:00
d1d50a4c92
Implement App-Scoped Security scoped bookmarks ( #11711 )
...
* implementation of security scoped bookmarks
* option is now only available on mas builds
2018-02-12 13:25:06 -05:00
66b57858b8
Fix child touch bar items not updating ( #11812 )
...
* Fix child touch bar items not updating
Deep children of a TouchBar didn't cause the top level touch bar to update, now they do
Fixes #11761 .
* Remove unused newValue property in TB setter
2018-02-12 12:53:04 -05:00
3c64062f69
Replace custom function with Object.values()
2018-02-05 20:03:28 -08:00
5240352326
Remove extra menu separators ( #11827 )
...
* add function to remove leading/trailing separators
* change const name for clarity
* add spec to check filtered separators
* clean method and add edge case spec per review
2018-02-05 11:55:12 -06:00
8ae3d9dd0b
Simplify the public PowerObserver interface
2018-02-05 15:28:58 +09:00
56b53e71aa
Implement powerMonitor 'shutdown' event for Linux.
...
The event is emitted when the OS is rebooting/shutting down, and allows
an electron app to call `e.preventDefault()` in order to delay shutdown
and exit cleanly.
2018-02-05 15:21:31 +09:00
d586ef2f39
feature: Hot security tips ( #11810 )
...
* 🔧 Add security issue detection (and logs)
* 🔧 Check for it on load
* 👷 Add some tests
* 👷 Make the linter happy
* 🔧 Allow them to be enabled by force
* 📝 Make message slightly prettier
* 🔧 Fix a typo in the code comment
* 🔧 Classic mistake
* 🚀 Optimize things a bit more
* 👷 Add tests, fix tests
* 📝 Document things
* 🔧 Make linter happy
* 🔧 One more piece of cleanup
2018-02-03 07:50:12 -07:00
1545a95782
Merge pull request #11799 from electron/browserview-inherit-fix
...
Don't inherit isBrowserView preference
2018-02-01 14:36:56 -05:00
db6d84de74
don't inherit isBrowserView for spawned child windows
2018-02-01 00:09:37 -05:00
b74304145e
createShadowRoot => attachShadow
2018-01-31 19:29:23 -05:00
32a1395bcf
Merge pull request #11565 from electron/add-load-file-helper
...
Add window.loadFile and webContents.loadFile helper methods
2018-01-23 09:08:23 +11:00
bd271cffb9
Throw when inAppPurchase is used on unsupported platforms
2018-01-10 18:53:55 +09:00
ac6f895f64
Turn InAppPurchase into an EventEmitter
2018-01-10 16:37:05 +09:00
b2542a27c3
Update code style
2018-01-10 13:14:18 +09:00
eb2520488f
Adapt code style
2018-01-10 13:14:18 +09:00
f3ae566164
Add in-app purchase for MacOS
2018-01-10 13:14:18 +09:00
eb89e12c5b
Merge pull request #11532 from sethlu/camelcase-menuitem-role
...
Make MenuItem roles camelCase-compatible
2018-01-04 09:53:58 -08:00
1553b54779
Add window.loadFile and webContents.loadFile helper methods
2018-01-04 11:38:56 +13:00
46330ac2a9
Remove the closed event of Menu
...
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
2018-01-01 17:22:07 +09:00
73d78d345a
Make callback work for old-style Menu.popup call
...
While the old-style Menu.popup has been deprecated, it is still being
used widely in apps and even in Electron itself.
2018-01-01 17:17:01 +09:00
7b01a8b860
Add callback parameter to Menu.popup
2018-01-01 16:26:19 +09:00
b8ec84c761
Fix syntax
2018-01-01 02:23:32 +08:00
d45914c3f7
MenuItem roles camelCase-compatible
2017-12-28 13:28:20 +08:00
5aac091f40
Add Support for Pop!_OS GNOME Session
...
Similar to this PR: https://github.com/electron/electron/pull/10355 , Pop!_OS suffers from the same problem. Using Ubuntu AppIndicator will not show the icon currently unless the XDG_CURRENT_DESKTOP variable is modified. This commit will add support for pop so that this workaround is not needed.
Ref: https://github.com/pop-os/pop/issues/84
2017-12-21 14:16:15 -05:00
088042841d
win: Correctly close popup menu
2017-12-21 15:26:32 +09:00
e4770c7604
Coding style fixes
2017-12-20 18:48:09 +09:00
c586806609
fix flash menu being unresponsive to commands
2017-12-20 15:40:07 +09:00
8166a64f98
🔧 Last round of feedback
2017-12-12 11:25:01 -08:00
c4ec8b4545
🔧 Feedback
2017-12-12 11:25:01 -08:00
5b7f7c8a1a
🔧 Menu returns its properties now
2017-12-12 11:25:01 -08:00
ffc54967e9
🔧 Fix value shift
2017-12-12 11:25:01 -08:00
99031834ff
🔧 Cleanup
2017-12-12 11:25:01 -08:00
3719ee0b53
🔧 Allow for `menu.popup({})`
2017-12-12 11:25:01 -08:00
9e660b1d32
🔧 Always find a window (or error)
2017-12-12 11:25:01 -08:00
4f901c6d24
🔧 Oh wow, that looks wrong
2017-12-12 11:25:01 -08:00
1c8eb03574
Revert "fix: Fix `menu.popup()` bugs"
2017-12-12 13:59:34 +03:00
927c63b477
🔧 Last round of feedback
2017-12-11 15:19:33 -08:00
89b90be6a2
🔧 Feedback
2017-12-11 14:43:35 -08:00
22e9d665d2
🔧 Menu returns its properties now
2017-12-11 14:03:01 -08:00
93b46116f4
🔧 Fix value shift
2017-12-11 13:30:35 -08:00
abd56eda6f
🔧 Cleanup
2017-12-08 14:40:51 -08:00
955564abd7
🔧 Allow for `menu.popup({})`
2017-12-08 14:37:16 -08:00
bd6767fac6
🔧 Always find a window (or error)
2017-12-08 14:36:52 -08:00
38bb9baac5
🔧 Oh wow, that looks wrong
2017-12-08 14:36:29 -08:00
24f60dcd1b
re-add warning removed in https://github.com/electron/electron/pull/11013
2017-12-07 11:42:18 -05:00
46f79146ad
Merge pull request #11316 from electron/hide-update-exe
...
fix: Ensure that update.exe doesn't open up a console window
2017-12-06 14:50:12 +09:00
cb3a9c69ab
Add a SessionPreferences to manage session related data
...
By design the BrowserClient should not be aware of the api:: classes.
2017-12-05 15:59:15 +09:00
d9359d8b6c
s/global/session in constants
2017-12-05 11:35:53 +09:00
d2707315e6
s/global/session
2017-12-05 11:35:53 +09:00
0ddd078aaf
Add ability to set global preload scripts
2017-12-05 11:35:27 +09:00
9646f0c99a
🔧 Sprinkle some ES6 across the file
2017-12-01 17:18:57 -08:00
c5abe96b39
🔧 Hide subprocess window
2017-12-01 17:18:37 -08:00
59476f0b30
Create webContents for webview even when src is not set
2017-12-01 10:35:23 +09:00
b161a4f515
Merge pull request #11166 from sethlu/openrecent
...
feat: Recent documents menu item
2017-11-28 10:55:14 +09:00
dcdc3621ac
Rename roles
2017-11-27 17:26:22 +09:00
5d44dbaf54
Redesign recent documents role API
...
- For more flexibility in designing the recent documents menu, now there can be one menu item (known issue: you may specify more but AppKit doens't display more than one) in the submenu list, rather than separating the labels with a tab.
- Also added is the role `clearrecent` that can be given to a menu item that can clear the recent documents.
2017-11-27 17:26:22 +09:00
828d233f2a
Rollback duplicated feature
2017-11-27 17:26:22 +09:00
0b9cea334f
Specify "Clear Menu" through label option
...
Like a bit of a hack right now, conforming to the existing menu item definition
2017-11-27 17:26:22 +09:00
4da2eb9366
Introduce openrecent role
...
- Does not yet accept any options except label--"Clear Menu" can't be modified through exposed node API
- If `openrecent` is present across multiple menu items, the last seen will be visible in the main menu due to that it is designed to behave like a singleton
2017-11-27 17:26:22 +09:00
f0bff74995
Add "Open Recent" submenu to default
2017-11-27 17:26:22 +09:00
1c0ea0286e
Merge pull request #11235 from electron/standard-10
...
infra: Upgrade to StandardJS 10
2017-11-27 15:42:52 +09:00
465f9009ff
Update stack string parsing in the CallbacksRegistry
...
Fixes the "ipc module > remote listeners
> detaches listeners subscribed to destroyed renderers, and shows a warning"
test.
2017-11-24 10:58:53 +09:00
4e859b4718
Remove "async" option from `menu.popup()`
...
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
f7d6e3fa7b
🔧 Disable standard/no-callback-literal where necessary
2017-11-23 13:53:03 -08:00
f81bfb7b86
🔧 Fix style issues
2017-11-23 13:42:48 -08:00
451a44c4b5
🔧 Don’t use deprecated `new Buffer()`
2017-11-23 13:41:47 -08:00
9c217fc6c7
Merge pull request #11224 from electron/browser-view-window
...
feature: Add `BrowserWindow.fromBrowserView()`
2017-11-23 14:41:36 +01:00
037f76c47b
🐛 Ooops, fix that
2017-11-22 17:07:57 -08:00
4d18cbe728
🔧 BrowserView.fromWebContents()
2017-11-22 16:59:00 -08:00
7630ac6e90
🔧 Return null if not found
2017-11-22 15:48:11 -08:00
8c5aad8b17
🔧 Add BrowserWindow.fromBrowserView()
2017-11-22 14:36:54 -08:00
05bae0b4c4
🔧 Util is no longer used here
2017-11-20 09:52:13 -08:00
b029c088db
🔧 Bonus ;
2017-11-20 09:48:33 -08:00
b8b3b441a7
🔧 util._extend is deprecated, too
2017-11-20 09:46:02 -08:00
Samuel Attard
Shelley Vohr
Cheng Zhao
shelley vohr
John Kleinschmidt
Charles Kerr
acheronfail
kaylie
Thiago de Arruda
Felix Rieseberg
Adrien Fery
Zeke Sikelianos
Zhuo Lu
Kyle Corry
Heilig Benedek
Alexey Kuzmin
Aleksei Kuzmin
Birunthan Mohanathas