Merge pull request #3132 from juj/micro_opt_log_garbage

Micro-optimize shell files to avoid redundant garbage in stdout and stderr prints.

src/shell.html

@@ -1224,7 +1224,7 @@
           var element = document.getElementById('output');
           if (element) element.value = ''; // clear browser cache
           return function(text) {
-            text = Array.prototype.slice.call(arguments).join(' ');
+            if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
             // These replacements are necessary if you render to raw HTML
             //text = text.replace(/&/g, "&");
             //text = text.replace(/</g, "&lt;");
@@ -1238,7 +1238,7 @@
           };
         })(),
         printErr: function(text) {
-          text = Array.prototype.slice.call(arguments).join(' ');
+          if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
           if (0) { // XXX disabled for safety typeof dump == 'function') {
             dump(text + '\n'); // fast, straight to the real console
           } else {

src/shell_minimal.html

@@ -80,7 +80,7 @@
           var element = document.getElementById('output');
           if (element) element.value = ''; // clear browser cache
           return function(text) {
-            text = Array.prototype.slice.call(arguments).join(' ');
+            if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
             // These replacements are necessary if you render to raw HTML
             //text = text.replace(/&/g, "&");
             //text = text.replace(/</g, "&lt;");
@@ -94,7 +94,7 @@
           };
         })(),
         printErr: function(text) {
-          text = Array.prototype.slice.call(arguments).join(' ');
+          if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
           if (0) { // XXX disabled for safety typeof dump == 'function') {
             dump(text + '\n'); // fast, straight to the real console
           } else {

tests/embind/shell.html

@@ -41,7 +41,7 @@
           var element = document.getElementById('output');
           element.value = ''; // clear browser cache
           return function(text) {
-            text = Array.prototype.slice.call(arguments).join(' ');
+            if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
             // These replacements are necessary if you render to raw HTML
             //text = text.replace(/&/g, "&");
             //text = text.replace(/</g, "&lt;");
@@ -52,7 +52,7 @@
           };
         })(),
         printErr: function(text) {
-          text = Array.prototype.slice.call(arguments).join(' ');
+          if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
           if (0) { // XXX disabled for safety typeof dump == 'function') {
             dump(text + '\n'); // fast, straight to the real console
           } else {

tests/sdl_canvas_size.html

@@ -44,7 +44,7 @@
           var element = document.getElementById('output');
           element.value = ''; // clear browser cache
           return function(text) {
-            text = Array.prototype.slice.call(arguments).join(' ');
+            if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
             // These replacements are necessary if you render to raw HTML
             //text = text.replace(/&/g, "&");
             //text = text.replace(/</g, "&lt;");
@@ -55,7 +55,7 @@
           };
         })(),
         printErr: function(text) {
-          text = Array.prototype.slice.call(arguments).join(' ');
+          if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
           if (0) { // XXX disabled for safety typeof dump == 'function') {
             dump(text + '\n'); // fast, straight to the real console
           } else {

tests/test_browser.py

@@ -997,7 +997,7 @@ keydown(100);keyup(100); // trigger the end
                 var element = document.getElementById('output');
                 element.value = ''; // clear browser cache
                 return function(text) {
-                  text = Array.prototype.slice.call(arguments).join(' ');
+                  if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
                   element.value += text + "\\n";
                   element.scrollTop = element.scrollHeight; // focus on bottom
                 };
@@ -2289,7 +2289,7 @@ Module['_main'] = function() {
                 var element = document.getElementById('output');
                 element.value = ''; // clear browser cache
                 return function(text) {
-                  text = Array.prototype.slice.call(arguments).join(' ');
+                  if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
                   element.value += text + "\\n";
                   element.scrollTop = element.scrollHeight; // focus on bottom
                 };

tests/test_fflush.html

@@ -91,7 +91,7 @@
           var element = document.getElementById('output');
           if (element) element.value = ''; // clear browser cache
           return function(text) {
-            text = Array.prototype.slice.call(arguments).join(' ');
+            if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
             // These replacements are necessary if you render to raw HTML
             //text = text.replace(/&/g, "&");
             //text = text.replace(/</g, "&lt;");
@@ -106,7 +106,7 @@
           };
         })(),
         printErr: function(text) {
-          text = Array.prototype.slice.call(arguments).join(' ');
+          if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
           if (text == 'hello from stderr too!') { Module.gotStderr = true; if (Module.gotStdout && Module.gotStdCerr) Module.reportSuccess(); }
           if (text == 'std::cerr in two parts.') { Module.gotStdCerr = true; if (Module.gotStdout && Module.gotStderr) Module.reportSuccess(); }
           if (0) { // XXX disabled for safety typeof dump == 'function') {

tests/test_html5_fullscreen.html

@@ -80,7 +80,7 @@
           var element = document.getElementById('output');
           if (element) element.value = ''; // clear browser cache
           return function(text) {
-            text = Array.prototype.slice.call(arguments).join(' ');
+            if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
             // These replacements are necessary if you render to raw HTML
             //text = text.replace(/&/g, "&");
             //text = text.replace(/</g, "&lt;");
@@ -94,7 +94,7 @@
           };
         })(),
         printErr: function(text) {
-          text = Array.prototype.slice.call(arguments).join(' ');
+          if (arguments.length > 1) text = Array.prototype.slice.call(arguments).join(' ');
           if (0) { // XXX disabled for safety typeof dump == 'function') {
             dump(text + '\n'); // fast, straight to the real console
           } else {