From dc4a8ef1b03283fb7a7e652161bae80970226c56 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Fri, 13 Nov 2020 12:49:02 -0800 Subject: [PATCH] Fix test configurations used in test_minimal_runtime_hello_pthread (#12774) I believe this tests is always supposed to run with MINIMAL_RUNTIME. Without this change the half of the innter test runs just run with pthreads which is redundant. --- tests/test_browser.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_browser.py b/tests/test_browser.py index b00b4932b..fe4fdd7af 100644 --- a/tests/test_browser.py +++ b/tests/test_browser.py @@ -4484,8 +4484,8 @@ window.close = function() { # Tests that a pthreads build of -s MINIMAL_RUNTIME=1 works well in different build modes def test_minimal_runtime_hello_pthread(self): for opts in [[], ['-O3']]: - for modularize in [[], ['-s', 'MODULARIZE=1', '-s', 'EXPORT_NAME=MyModule', '-s', 'MINIMAL_RUNTIME=1']]: - self.btest(path_from_root('tests', 'pthread', 'hello_thread.c'), expected='1', args=['-s', 'USE_PTHREADS=1'] + modularize + opts) + for modularize in [[], ['-s', 'MODULARIZE=1', '-s', 'EXPORT_NAME=MyModule']]: + self.btest(path_from_root('tests', 'pthread', 'hello_thread.c'), expected='1', args=['-s', 'MINIMAL_RUNTIME=1', '-s', 'USE_PTHREADS=1'] + modularize + opts) # Tests memory growth in pthreads mode, but still on the main thread. @requires_threads