Do not weak-link Xcode Private Frameworks

Summary: These are linked at runtime, so using these in tests or linking at build-time is un-needed

Reviewed By: jamescoggan

Differential Revision: D33630215

fbshipit-source-id: 5796ea88cf907c304d0069ee1fcf608994916276

FBSimulatorControl/FBSimulatorControl.xcconfig

@@ -2,9 +2,6 @@
 #include "../Configuration/Shared.xcconfig"
 #include "../Configuration/Framework.xcconfig"
 
-// Weak-Link Xcode Private Frameworks
-OTHER_LDFLAGS = $(inherited) -weak_framework CoreSimulator -weak_framework SimulatorKit
-
 // Target-Specific Settings
 INFOPLIST_FILE = $(SRCROOT)/FBSimulatorControl/FBSimulatorControl-Info.plist;
 PRODUCT_BUNDLE_IDENTIFIER = com.facebook.FBSimulatorControl

FBSimulatorControlTests/Utilities/CoreSimulatorDoubles.h

@@ -7,8 +7,7 @@
 
 #import <Foundation/Foundation.h>
 
-#import <CoreSimulator/SimDevice.h>
-#import <CoreSimulator/SimDeviceSet.h>
+@class SimDeviceNotificationManager;
 
 @interface FBSimulatorControlTests_SimDeviceType_Double : NSObject