Summary:
It now appears that to support both ASL and `os_log`, Apple needed to add in the ability to set a custom logging function. This API is then part of the `CoreSimulator`, and we can therefore use it.
This is pretty simple, and `SimLog` is a standard format function with the function name and line number. We discard (but document) these values. We can then extract the actual format string and pass it into our logging subsystem.
Reviewed By: c-ryan747
Differential Revision: D14225899
fbshipit-source-id: 3f389617f1baf90d7fcbe4367a695e37942a73be
Summary: We now don't need the Xcode frameworks for devices, so can remove the loading of these classes. This also means ejecting some unit tests that are no longer relevant, since the code this depends on is also gone
Reviewed By: zeyadsalloum
Differential Revision: D14163765
fbshipit-source-id: 158ef2d469a4900fc99f9ec3a154bfdb85261bf5
Summary: This can be shared as the behaviour for SimulatorKit and AMDevice can be the same.
Differential Revision: D8116756
fbshipit-source-id: 2e0157fccd427fed102ae769d9f3692c8a8da587
Summary:
Currently the implementation of framework loading is done via subclassing `FBControlCoreFrameworkLoader`. By moving towards shared-instances the following happens:
1) Sharing of state via instances, rather than ad-hoc `hasLoaded` static vars
2) Two-Stage loading in `FBDeviceControl` is vastly simplified through class-clusters
3) No repetition of the actual framework loading call in subclasses.
4) The simple-case in `XCTestBootstrap` is done via an instance
5) Improved clarity in callers of two-stage loading
6) No need to explictly override a method on `FBControlCoreFrameworkLoader`
Reviewed By: asm89
Differential Revision: D5488270
fbshipit-source-id: 1ae592c4aa64211183c38d59590917bbae4540a3
Summary: This will enable re-use in `FBSimulatorControl`
Reviewed By: mattjgalloway
Differential Revision: D5337885
fbshipit-source-id: 433d1af4f5c0b5933a5a050cf8d348c35253d577
Summary: If you run as root, you're gonna have a bad time. This makes this kind of failure even more obvious by providing an error message.
Reviewed By: marekcirkos
Differential Revision: D3702859
fbshipit-source-id: 0b5457a2f993cb4c27b21b16a56357edf0f89883
Andres Suarez
Lawrence Lomax