idb/FBControlCore/Utility
Lawrence Lomax 2acd0f7f11 Move task execution to runUntilCompletionWithAcceptableExitCodes:
Summary:
This will help extract the exit code checking from an implicit behaviour of `-[FBTask completed]` and into concrete semantics.

The default value when no exit codes are defined in the builder is a set with a single exit code of 0 defined. This results in the following transformations:

- For builders where the exit code is defined, this is moved to `runUntilCompletionWithAcceptableExitCodes`
- For builders where no exit code is defined, the default of `[NSSet setWithObject:0]` is passed since it is he default
- For builders where exit code checking is suppressed, `nil` is passed.

All other builders that do not `runUntilCompletion` are left intact. These changes will be more complex as they will require moving the exit code checking to another component.

Reviewed By: jamescoggan

Differential Revision: D30191049

fbshipit-source-id: 8edf0d155372fb46ffbb5048249be209e89c32e9
2021-08-12 05:58:26 -07:00
..
FBAccessibilityTraits.h Yearless license header 2019-11-03 13:03:11 -08:00
FBAccessibilityTraits.m Yearless license header 2019-11-03 13:03:11 -08:00
FBArchitecture.h Yearless license header 2019-11-03 13:03:11 -08:00
FBArchitecture.m Yearless license header 2019-11-03 13:03:11 -08:00
FBArchiveOperations.h Remove exit code checks in builder for `FBArchiveOperations` 2021-08-12 03:52:36 -07:00
FBArchiveOperations.m Move task execution to runUntilCompletionWithAcceptableExitCodes: 2021-08-12 05:58:26 -07:00
FBCollectionInformation.h Remove +[FBCollectionInformation oneLineJSONDescription:] 2021-01-14 08:06:56 -08:00
FBCollectionInformation.m Remove +[FBCollectionInformation oneLineJSONDescription:] 2021-01-14 08:06:56 -08:00
FBCollectionOperations.h Add FBDeviceDiagnosticInformationCommands 2020-07-29 05:59:55 -07:00
FBCollectionOperations.m Add FBDeviceDiagnosticInformationCommands 2020-07-29 05:59:55 -07:00
FBConcurrentCollectionOperations.h Yearless license header 2019-11-03 13:03:11 -08:00
FBConcurrentCollectionOperations.m Yearless license header 2019-11-03 13:03:11 -08:00
FBControlCoreError.h Remove all automatic error logging 2021-02-11 07:57:47 -08:00
FBControlCoreError.m Remove all automatic error logging 2021-02-11 07:57:47 -08:00
FBControlCoreFrameworkLoader.h Yearless license header 2019-11-03 13:03:11 -08:00
FBControlCoreFrameworkLoader.m Per-Framework Root-Disallow 2020-05-19 11:17:05 -07:00
FBControlCoreGlobalConfiguration.h Extract Safe Subprocess Env 2021-02-23 09:55:51 -08:00
FBControlCoreGlobalConfiguration.m Extract Safe Subprocess Env 2021-02-23 09:55:51 -08:00
FBControlCoreLogger+OSLog.h Yearless license header 2019-11-03 13:03:11 -08:00
FBControlCoreLogger+OSLog.m Yearless license header 2019-11-03 13:03:11 -08:00
FBControlCoreLogger.h s/recieve/receive 2020-01-21 04:06:20 -08:00
FBControlCoreLogger.m Yearless license header 2019-11-03 13:03:11 -08:00
FBCrashLogStore.h Yearless license header 2019-11-03 13:03:11 -08:00
FBCrashLogStore.m Add error messaging for crash log parsing 2021-03-01 01:43:29 -08:00
FBDataBuffer.h s/recieve/receive 2020-01-21 04:06:20 -08:00
FBDataBuffer.m Yearless license header 2019-11-03 13:03:11 -08:00
FBDataConsumer.h Use FBDataConsumerStackConsuming as a marker of stack-consumption 2020-10-23 08:13:50 -07:00
FBDataConsumer.m Wait for all process output to return before exiting launch 2021-02-03 14:58:42 -08:00
FBDeveloperDiskImage.h Move FBDeveloperDiskImage to FBControlCore 2020-11-09 11:29:35 -08:00
FBDeveloperDiskImage.m Move FBDeveloperDiskImage to FBControlCore 2020-11-09 11:29:35 -08:00
FBDispatchSourceNotifier.h Yearless license header 2019-11-03 13:03:11 -08:00
FBDispatchSourceNotifier.m Yearless license header 2019-11-03 13:03:11 -08:00
FBFileReader.h Yearless license header 2019-11-03 13:03:11 -08:00
FBFileReader.m Fix sending zero-length dispatch_data 2020-06-30 11:29:37 -07:00
FBFileWriter.h Use FBDataConsumerStackConsuming as a marker of stack-consumption 2020-10-23 08:13:50 -07:00
FBFileWriter.m Don't segfault on out-of-order writing 2020-02-10 02:53:04 -08:00
FBInstrumentsOperation.h Remove FBiOSTargetOperation conformance from FBInstrumentsOperation 2021-06-30 08:40:21 -07:00
FBInstrumentsOperation.m Move task execution to runUntilCompletionWithAcceptableExitCodes: 2021-08-12 05:58:26 -07:00
FBLoggingWrapper.h Add configuration for naming of event names in wrapping logger 2020-02-04 03:04:59 -08:00
FBLoggingWrapper.m Fix implode trailing comma in logging 2021-08-03 02:45:21 -07:00
FBProcessIO.h Make detach before attach impossible in FBProcessIO API 2021-06-28 05:37:57 -07:00
FBProcessIO.m Make detach before attach impossible in FBProcessIO API 2021-06-28 05:37:57 -07:00
FBProcessStream.h Remove FBiOSTargetOperationType 2021-01-04 06:40:02 -08:00
FBProcessStream.m Remove FBiOSTargetOperationType 2021-01-04 06:40:02 -08:00
FBVideoFileWriter.h Extract FBVideoFileWriter 2021-06-23 06:30:08 -07:00
FBVideoFileWriter.m Extract FBVideoFileWriter 2021-06-23 06:30:08 -07:00
FBVideoStream.h Remove FBVideoStreamAttributes 2021-01-14 08:06:55 -08:00
FBVideoStream.m Remove FBVideoStreamAttributes 2021-01-14 08:06:55 -08:00
FBWeakFramework+ApplePrivateFrameworks.h Add Accessibility Translator PrivateFramework 2020-06-29 07:42:45 -07:00
FBWeakFramework+ApplePrivateFrameworks.m Add Accessibility Translator PrivateFramework 2020-06-29 07:42:45 -07:00
FBWeakFramework.h Simplify constructors, exposing rootPermitted 2020-05-19 11:17:05 -07:00
FBWeakFramework.m Remove FBJSONConversion & FBDebugDescribeable 2021-01-14 08:55:37 -08:00
FBWeakFrameworkLoader.h Yearless license header 2019-11-03 13:03:11 -08:00
FBWeakFrameworkLoader.m Yearless license header 2019-11-03 13:03:11 -08:00
FBXCTraceOperation.h use absolute path for xctrace 2021-03-23 09:56:27 -07:00
FBXCTraceOperation.m Move task execution to runUntilCompletionWithAcceptableExitCodes: 2021-08-12 05:58:26 -07:00
FBXcodeConfiguration.h Throw when called with an Xcode version >= 12.5 2021-05-11 09:07:30 -07:00
FBXcodeConfiguration.m Do not double call xcode-select 2021-07-01 00:49:16 -07:00
FBXcodeDirectory.h Simplify FBXcodeDirectory 2021-06-30 06:57:00 -07:00
FBXcodeDirectory.m Move task execution to runUntilCompletionWithAcceptableExitCodes: 2021-08-12 05:58:26 -07:00
NSPredicate+FBControlCore.h Yearless license header 2019-11-03 13:03:11 -08:00
NSPredicate+FBControlCore.m Yearless license header 2019-11-03 13:03:11 -08:00