* centraldashboard(front): Install Cypress
- Install Cypress & npm scripts for UI tests
- Update frontend README.md with UI tests instructions
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* centraldashboard-angular(front): Add UI tests with Cypress
Add UI tests with Cypress to check that the URLs of the browser and the
iframe are always synced. More specifically, we test the following
scenarios:
- User navigates to pages inside the same WA (JWA)
- User navigates to another WA from the one they were previously in (to
the corresponding PVC from JWA details page)
- User clicks and affects the query parameters of the current URL
(navigates to tabs inside JWA details page)
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Modify script names
Modify script names in order to conform with script names in other WAs.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* gh-actions(cdb-angular): Add UI tests to CDB's frontend workflow
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
---------
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(back): Append notebooks using each PVC
Append notebooks using each PVC when getting and parsing all PVCs.
Refs arrikto/dev#2017
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Create custom delete action column
Create custom delete column component that extends ActionComponent from
Kubeflow common code and adds the following functionalities:
* Disable the button when a row's notebooks array is not empty
* Display an appropriate message including the notebooks' names
Refs arrikto/dev#2017
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add delete button component in index page
Implement custom delete column in the table in VWA's index page.
Refs arrikto/dev#2017
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add Used by column in volumes table
Add a Used by column in volumes table of VWA's index page in order to
link to the notebooks that are using each PVC.
Refs arrikto/dev#2017
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Fix integration tests
Update mock request for PVCs
Refs arrikto/dev#2017
Refs arrikto/dev#2135
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Fix format error
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Fix linting errors
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
---------
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* Implement a culling controller for notebooks
Changes:
* Move the idleness/culling logic into a separate controller
as part of the Notebooks Controller/Operator.
* Introduce an "notebooks.kubeflow.org/last_activity_check_timestamp".
annotation in each Notebook CR to keep the timestamp of the last
performed idleness check
The controller can then compare this timestamp with the current time to
ensure that notebooks will get reconciled every IDLENESS_CHECK_PERIOD
minutes.
The culling-controller will:
* reconcile only notebooks CRs
* set/update culling annotations
- 'notebooks.kubeflow.org/last_activity'
- 'notebooks.kubeflow.org/last_activity_check_timestamp'
* perform idleness checks every 'IDLENESS_CHECK_PERIOD' minutes
and set the 'kubeflow-resource-stopped' annotation, if a notebook
needs to be culled.
Refs: kubeflow/kubeflow#6767
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* review: Remove culling annotations when Pod is not found
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* review: Improve logs
Add a log message at the beginning of the reconciliation loop
to make it clear that a Reconcile was called for a notebook.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Run the controller locally
* Introduce make rule for running the controller locally with
culling enabled
* Introduce a dev_culling_authorization_policy which must be
applied when testing the culling-controller locally
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Update README instructions
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* twa(front): Install Cypress
- Install Cypress & npm scripts for UI tests
- Remove Protractor files
- Update README.md with UI tests instructions
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* twa(front): Add UI tests with Cypress
Add UI tests with Cypress to check that:
- New Tensorboard form dialog has proper default values and updates
accordingly when its radio button value changes.
- Index page
* renders every tensorboard name into the table
* renders correctly Status icon for every tensorboard
* disables CONNECT button when tensorboard's status not ready
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* gh-actions(twa): Add UI tests to TWA's frontend action
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Fix bug where extracting the ENV vars from PodDefaults for a notebook
would fail when one of the PodDefaults didn't contain any ENV variables.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Currently there is a single build-all rule in the top-level Makefile
under components/ dir that calls all sub-makefiles for building all
images in a serial manner. This makes the whole proccess very time-consuming
as we can't use the "-j" option of make to run jobs in parallel.
Changes to the top-level Makefile for building all KF images:
- create a single rule for each directory containing a sub-makefile
- have each directory rule as a dependency to the build-all rule in the
central Makefile
Similarly, the central makefile for building all the example-notebook-servers images
calls each sub-Makefile for each of the notebook servers in a serial manner.
Changes to the central Makefile for building all notebook-server-images:
- Split the single target rule into multiple rules which perform recursive make
calls (sub-makefiles) to build all the notebook-server-images.
- Use the variable MAKE for recursive make commands instead of explicit 'make'
command:
- https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html#MAKE-Variable
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* web-apps(front): Import @angular/router package
Import @angular/router package to use routerLink directive.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Introduce LinkValue class
Introduce a distinct class for our external and internal links.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Modify unit tests
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Remove isLink property from PropertyValue class
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Make links actual links
Make JWA's main table links actual links by using the new LinkValue
class.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Make links actual links
Make VWA's main table links actual links by using the new LinkValue
class.
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
Update the RStudio image to be able to handle multiple values in the
X-Forwarded-{Proto,Host} headers. The server should care about the first
values which are the ones the user's browser is using
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Add integration tests with Cypress
- Upgrade Cypress to version ^10.10.0
- Add integration tests with Cypress to check that:
* Index page renders every Notebook name into the table
* Index page shows correct Status icon for all notebooks
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* gh-actions(jwa): Add UI tests to JWA's frontend workflow
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* fixup! gh-actions(jwa): Add UI tests to JWA's frontend workflow
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* Adds field to struct to disable auto-update of trust policy in case where user has security concerns about auto-mutation
* add unit-test and restructure code to allow for unit-testing
Style the dashboard and the iframe in order for the iframe to be
responsive, fit in the screen and not exceed it.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Add homepage and iframe-wrapper components
Generate iframe-wrapper and components using Angular cli.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Add safe pipe in iframe
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Add JWA and VWA in the iframe
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Sync Browser and Iframe URLs
- Detect changes in iframe's internal URL by checking in time
intervals. Upon change, modify the browser's (Router) URL to be the
same as the iframe's one.
- Update iframe's src property based on route events.
- Modify iframe's src property setter by appending/removing the
location origin, in order for the iframe to reload even when
passing the same value to src.
- Update the src property only when the browser's URL and the
iframe's URL are different in order to prevent the iframe from
reloading on every user click.
- Send manually a postMessage with a hardcoded namespace
'kubeflow-user' in order to be able to test the WAs until we
implement a functionality for handling namespaces.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Lint code
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Review comment fixes
- Introduce appendBackslash(string):string
- Add/modify comments
- Improve code readability
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Add local proxy for '/api'
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Use prefix '/_' in links
Use prefix '/_' (as we already do) in order to keep web apps iframed
under the Central Dashboard.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Fix query parameters bug
- Modify appendBackslash to append the backslash at the end of the URL
path but always before the query parameters.
- Add/modify comments for clearness and readability
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Add missing generateName form control
Add missing generateName form control when creating the metadata
form group from a PVC.
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Update volume's mount path when name changes
Extend VolumeMountComponent class and update volume's mount path
when it is not dirty and name is changed. This feature affects only
the data volumes and not the workspace volume.
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Add UI tests for volume's mount path input
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
In this commit we extend workflow for running frontend tests. For
the CentralDashboard (Angular) tests we also need to ensure some
underlying apps are proxied.
In this commit we extended the dedicated workflow for the frontend tests by:
1. Applying the necessary KF Controllers (Profiles, Notebooks)
2. Applying the JWA manifests and port-forward its k8s Service
3. Applying the VWA manifests and port-forward its k8s Service
4. Creating a user namespace (kubeflow-user) via a Profile
5. Creating a test Notebook, with a PVC, in that namespace
Next steps will be to run the Cypress tests of the CDB (Angular) that
will be using the proxied apps.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Remove Protractor files
Remove Protractor files since it's not used anywhere in the common
code.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Add Cypress attributes
Add more attributes and modify some existing ones for elements to be
selectable during UI tests with Cypress.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Install Cypress
- Install Cypress & npm scripts for UI tests
- Remove Protractor files
- Update README.md with UI tests instructions
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Add UI tests with Cypress
- Add Cypress attributes for elements to be selectable during
UI tests.
- Add UI tests with Cypress to check that:
* New Volume form dialog has proper values
* Index page table contains all PVC names received
* Index page table status icons are correctly shown
* Index page table browse buttons are correctly shown
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* gh-actions(vwa): Add UI tests to VWA's frontend workflow
Add UI tests to VWA's frontend workflow. These tests should run in
Ubuntu 20.04 since Ubuntu 20.04 includes both Chrome and Firefox
installations by default.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Fix formatting errors
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Fix format errors
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Add script
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Install Prettier
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Format code
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Create a workflow for code formatting/linting and unit tests
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Format code
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Add formatting/linting to VWA's frontend workflow
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* centraldashboard-angular(front): Add source maps in the browser
Enable source maps in both development and production.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* centraldashboard-angular(front): Add library.js file
Copy libary.js file from the old centraldashboard project and build it
using webpack.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* centraldashboard(front): Configure ESLint
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* fixup! centraldashboard-angular(front): Add library.js file
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Revert changes introduced in https://github.com/kubeflow/kubeflow/pull/6849
regarding fetching all history for all tags and branches when workflows run.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Set REGISTRY prefix when building notebook-server images
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Fix publish workflows for nb-server images when a PR is merged
Whenever a PR is merged:
* Build/Push notebook-server images with TAG=$(shell git describe --tags --always --dirty)
* Build/Push notebook-server images with TAG=latest when the target branch is master
* Build/Push notebook-server images with TAG=$(cat releasing/version/VERSION) when
Version changes
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Update manifests to use latest tag for notebook-server images
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* web-apps(front): Sort tables according to input
Configure tableConfig with new fields (column and order) that the table
will use to sort items during initialization.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Sort conditions table by timestamp
Initialize conditions table sorted by Last Transition Time column, with
the most recent ones being on top.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Sort events by timestamp
Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Sort events by timestamp
Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Fix format errors
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Create lib-urls component
Create a URLs component in Kubeflow common library which takes a
list of URLs and their corresponding name and exposes them
horizontally in a div.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Add unit test for lib-urls
Add a unit test for lib-urls component
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Remove column Volumes from index page
Remove Volumes column from the table in JWA's index page.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Link to a Volume details from JWA details page
- Expose all volumes from a notebook, not only PVCs.
- Expose the volumes grouped by type, having PVCs link to their
corresponding volume details page in VWA, using lib-urls
component.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Implement lib-urls in VWA details page
Implement lib-urls component in the OVERVIEW tab of VWA's volume
details page to avoid duplicate code.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Use common link styles
Use common link styles in configurations component.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* Fix linting errors
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Fix a bug in the namespace selectors of JWA, VWA and TWA. In order to
show the namespace selector, they only checked if there is no
env.production variable available. This resulted in the selector not
showing even if there was no dashboard which is not expected.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
review changes
* build images with the latest tag only when a PR
is merged to master branch
* revert changes in manifests/workflows for the
notebook-server images
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Extend docker publish workflows to be triggered on Version change
Changes:
* Add the path releasing/version/VERSION in the paths
* Use the 'dorny/paths-filter@v2' action to monitor the path
"releasing/version/VERSION" and if it changes run a step
that pushes the image with the TAG=$(cat releasing/version/VERSION)
* Set fetch-depth:0 to fetch all history for all tags and branches.
This is required so that the tags won't end up being just a hash
commit.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Set Version to `latest`
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Introduce manifests for centraldb-angular component
The manifests are identical to the ones we have for the
centraldashboard component.
Changes:
* Fix image/name references to be centraldashboard-angular
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* centraldb-angular: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow
* Publish Docker image only when PR is merged
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* jwa(front): Add buttons to Notebook details page
In this commit:
- Add buttons for Connect, Start/Stop, Delete actions.
- Create Actions Service to handle button actions and implement it
in all components that use these buttons.
- Small CSS tweak in title toolbar component in order for
buttons to be aligned horizontally.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Handle query parameters in Notebook page
Add query parameter handling for each tab in order for the user to
be able to navigate directly to the tab of choice inside the
Notebook details page.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Add default values in lib-conditions-table fields
Add default values for lastTransitionTime, reason & message fields
in order to prevent the table's Sorting functionality returning
error due to null values.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Add unit tests for notebook-page component
In this commit, add unit tests in order to:
- Show only the proper tab according to query parameters passed.
- Switch tabs according to query parameters passed.
- Update disabled field of buttons according to notebook status.
- Update start/stop button according to notebook status.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Add unit tests for OVERVIEW tab component
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Handle query parameters in Volume details page
Add query parameter handling for each tab in order for the user to
be able to navigate directly to the tab of choice inside the Volume
details page.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Add unit tests for volume-details-page component
Add unit tests in order to:
- Show only the proper tab according to query parameters passed.
- Switch tabs according to query parameters passed.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Add unit tests for overview component
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* gh-actions(vwa): Add frontend tests
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Fix linting errors
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Fix panel.ts file
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Modify form name component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Add a helper tooltip in section component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Rework the Create page
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix linting errors
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* poddefaults: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Introduce bash script to install cert-manager
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* review: Fix cert-manager installation script
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Changes:
* Introduce intergration test workflow
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
* Fix centrardashboard-angular docker-build workflow
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Extend spinner component by adding some text below the spinner in order
to inform users why we're spinning about.
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* Introduce intergration test workflow for notebook-controller
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Publish Docker image only when PR is merged
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Remove kind & manifest gh-action workflows
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Update tag in manifests to v1.6.0
This change is required as images with v1.5.0 do not
exist in Dockerhub.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Introduce intergration test workflow for tensorboard-controller
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Publish Docker image only when PR is merged
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Remove kind & manifest gh-action workflows
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Update tag in manifests to v1.6.0
This change is required as images with v1.5.0 do not
exist in Dockerhub.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* jwa: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow for JWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* twa: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow for TWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* vwa: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow for VWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Introduce github action workflow for intergration test
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Publish Docker image only when PR is merged
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Remove kind & manifest gh action tests
* Review fixes
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Extend intergration test
* Trigger workflow when kfam code changes since
KFAM manifests are deployed with Profile Controller
manifests.
* Build KFAM image as well and update manifests with sed
before deploying them in the KinD cluster.
* Update tag in manifests to v1.6.0 since the images with
tag v1.5.0 do not exist in Dockerhub.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* jwa(front): Add source maps in the browser
* Enable source maps in both development and production.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Add source maps in the browser
* Enable source maps in both development and production.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Add source maps in the browser
* Enable source maps in both development and production.
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Update @angular/common package
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix unit tests
Signed-off-by: Elena Zioga <elena@arrikto.com>
* gh-actions: Add GH action to run TWA unit tests
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>