Граф коммитов

2538 Коммитов

Автор SHA1 Сообщение Дата
Orfeas Kourkakis 7db9c95136
cdb-angular(front): Add UI tests (#6895)
* centraldashboard(front): Install Cypress

 - Install Cypress & npm scripts for UI tests
 - Update frontend README.md with UI tests instructions

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* centraldashboard-angular(front): Add UI tests with Cypress

Add UI tests with Cypress to check that the URLs of the browser and the
iframe are always synced. More specifically, we test the following
scenarios:

 - User navigates to pages inside the same WA (JWA)
 - User navigates to another WA from the one they were previously in (to
   the corresponding PVC from JWA details page)
 - User clicks and affects the query parameters of the current URL
   (navigates to tabs inside JWA details page)

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Modify script names

Modify script names in order to conform with script names in other WAs.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(cdb-angular): Add UI tests to CDB's frontend workflow

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

---------

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-02-01 12:59:31 +00:00
Orfeas Kourkakis bf9da0a15b
vwa(front): Prevent PVCs from being deleted when there is a corresponding notebook (#6899)
* vwa(back): Append notebooks using each PVC

Append notebooks using each PVC when getting and parsing all PVCs.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Create custom delete action column

Create custom delete column component that extends ActionComponent from
Kubeflow common code and adds the following functionalities:

* Disable the button when a row's notebooks array is not empty
* Display an appropriate message including the notebooks' names

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add delete button component in index page

Implement custom delete column in the table in VWA's index page.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add Used by column in volumes table

Add a Used by column in volumes table of VWA's index page in order to
link to the notebooks that are using each PVC.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix integration tests

Update mock request for PVCs

Refs arrikto/dev#2017
Refs arrikto/dev#2135

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix format error

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

---------

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-30 10:02:05 +00:00
Elena Zioga 29e74b1397
centraldashboard: Rename Models to Endpoints (#6911)
Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-01-26 15:08:10 +00:00
apoger 361a2665e0
Implement a culling controller for Notebooks (#6807)
* Implement a culling controller for notebooks

Changes:

 * Move the idleness/culling logic into a separate controller
   as part of the Notebooks Controller/Operator.

 * Introduce an "notebooks.kubeflow.org/last_activity_check_timestamp".
   annotation in each Notebook CR to keep the timestamp of the last
   performed idleness check

The controller can then compare this timestamp with the current time to
ensure that notebooks will get reconciled every IDLENESS_CHECK_PERIOD
minutes.

The culling-controller will:

* reconcile only notebooks CRs
* set/update culling annotations
  - 'notebooks.kubeflow.org/last_activity'
  - 'notebooks.kubeflow.org/last_activity_check_timestamp'
* perform idleness checks every 'IDLENESS_CHECK_PERIOD' minutes
  and set the 'kubeflow-resource-stopped' annotation, if a notebook
  needs to be culled.

Refs: kubeflow/kubeflow#6767

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* review: Remove culling annotations when Pod is not found

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* review: Improve logs

Add a log message at the beginning of the reconciliation loop
to make it clear that a Reconcile was called for a notebook.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Run the controller locally

* Introduce make rule for running the controller locally with
  culling enabled

* Introduce a dev_culling_authorization_policy which must be
  applied when testing the culling-controller locally

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update README instructions

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2023-01-26 13:32:10 +00:00
Orfeas Kourkakis f09a39741a
twa(front): Add UI tests with Cypress (#6896)
* twa(front): Install Cypress

 - Install Cypress & npm scripts for UI tests
 - Remove Protractor files
 - Update README.md with UI tests instructions

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* twa(front): Add UI tests with Cypress

Add UI tests with Cypress to check that:
 - New Tensorboard form dialog has proper default values and updates
   accordingly when its radio button value changes.
 - Index page
    * renders every tensorboard name into the table
    * renders correctly Status icon for every tensorboard
    * disables CONNECT button when tensorboard's status not ready

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(twa): Add UI tests to TWA's frontend action

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-26 09:37:10 +00:00
adilhusain-s 566bdcab56
Updating central-board Dockerfile for multi-arch support (#6861) 2023-01-25 19:27:05 +00:00
Orfeas Kourkakis b00ceeef7b
jwa(front): Fix ENV vars bug in details page (#6903)
Fix bug where extracting the ENV vars from PodDefaults for a notebook
would fail when one of the PodDefaults didn't contain any ENV variables.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-25 17:44:52 +00:00
apoger 3b027f966d
make: Build KF images in parallel (#6873)
Currently there is a single build-all rule in the top-level Makefile
under components/ dir that calls all sub-makefiles for building all
images in a serial manner. This makes the whole proccess very time-consuming
as we can't use the "-j" option of make to run jobs in parallel.

Changes to the top-level Makefile for building all KF images:

- create a single rule for each directory containing a sub-makefile

- have each directory rule as a dependency to the build-all rule in the
  central Makefile

Similarly, the central makefile for building all the example-notebook-servers images
calls each sub-Makefile for each of the notebook servers in a serial manner.

Changes to the central Makefile for building all notebook-server-images:

- Split the single target rule into multiple rules which perform recursive make
  calls (sub-makefiles) to build all the notebook-server-images.

- Use the variable MAKE for recursive make commands instead of explicit 'make'
  command:
  - https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html#MAKE-Variable

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2023-01-23 10:03:53 +00:00
Suraj Kota 04b79ef657
Support Pod Defaults in Tensorboard controller (#6874)
* support poddefaults in tensorboard controller

* initilize empty map
2023-01-18 15:22:21 +00:00
Elena Zioga 8dcfe792c5
[wa-actual-links-in-tables] Make links in our table component actual links (#6864)
* web-apps(front): Import @angular/router package

Import @angular/router package to use routerLink directive.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce LinkValue class

Introduce a distinct class for our external and internal links.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Remove isLink property from PropertyValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Make links actual links

Make JWA's main table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Make links actual links

Make VWA's main table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-01-18 14:19:21 +00:00
Kimonas Sotirchos a4ad3d0786
rstudio: Update version to properly handle X-Forwarded headers (#6890)
Update the RStudio image to be able to handle multiple values in the
X-Forwarded-{Proto,Host} headers. The server should care about the first
values which are the ones the user's browser is using

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-01-18 09:14:20 +00:00
Orfeas Kourkakis 6774b1018d
jwa(front): Add UI tests with Cypress (#6891)
* jwa(front): Add integration tests with Cypress

 - Upgrade Cypress to version ^10.10.0
 - Add integration tests with Cypress to check that:
   * Index page renders every Notebook name into the table
   * Index page shows correct Status icon for all notebooks

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(jwa): Add UI tests to JWA's frontend workflow

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* fixup! gh-actions(jwa): Add UI tests to JWA's frontend workflow

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-16 11:03:00 +00:00
ryansteakley 0f57b056ef
[Profile controller IAM plugin] Support annotation only (#6887)
* Adds field to struct to disable auto-update of trust policy in case where user has security concerns about auto-mutation

* add unit-test and restructure code to allow for unit-testing
2023-01-16 10:14:59 +00:00
dependabot[bot] 63dd1b2f6a
build(deps): bump decode-uri-component from 0.2.0 to 0.2.2 in /components/centraldashboard-angular/frontend (#6793)
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-13 15:51:49 +00:00
dependabot[bot] c26d73bec7
build(deps): bump glob-parent and nodemon in /components/centraldashboard-angular/backend (#6774)
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) to 5.1.2 and updates ancestor dependency [nodemon](https://github.com/remy/nodemon). These dependencies need to be updated together.


Updates `glob-parent` from 3.1.0 to 5.1.2
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](https://github.com/gulpjs/glob-parent/compare/v3.1.0...v5.1.2)

Updates `nodemon` from 1.19.4 to 2.0.20
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](https://github.com/remy/nodemon/compare/v1.19.4...v2.0.20)

---
updated-dependencies:
- dependency-name: glob-parent
  dependency-type: indirect
- dependency-name: nodemon
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-13 14:03:49 +00:00
Orfeas Kourkakis 3169c09fba
cdb-angular(front): Fix Iframe's sizing to fit to screen (#6892)
Style the dashboard and the iframe in order for the iframe to be
responsive, fit in the screen and not exceed it.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-13 11:58:49 +00:00
deepk2u 5a720a0710
add support of initContainers and sideCars in poddefault (#6749)
* add support of initContainers and sideCars in poddefault

* adding tests

* adding examples
2023-01-13 11:49:49 +00:00
Orfeas Kourkakis 5a068deb05
centraldashboard-angular(front): Sync Browser and Iframe URLs (#6856)
* cdb-angular(front): Add homepage and iframe-wrapper components

Generate iframe-wrapper and components using Angular cli.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Add safe pipe in iframe

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Add JWA and VWA in the iframe

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Sync Browser and Iframe URLs

 - Detect changes in iframe's internal URL by checking in time
   intervals. Upon change, modify the browser's (Router) URL to be the
   same as the iframe's one.
 - Update iframe's src property based on route events.
   - Modify iframe's src property setter by appending/removing the
     location origin, in order for the iframe to reload even when
     passing the same value to src.
   - Update the src property only when the browser's URL and the
     iframe's URL are different in order to prevent the iframe from
     reloading on every user click.
 - Send manually a postMessage with a hardcoded namespace
   'kubeflow-user' in order to be able to test the WAs until we
   implement a functionality for handling namespaces.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Lint code

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Review comment fixes

 - Introduce appendBackslash(string):string
 - Add/modify comments
 - Improve code readability

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Add local proxy for '/api'

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Use prefix '/_' in links

Use prefix '/_' (as we already do) in order to keep web apps iframed
under the Central Dashboard.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Fix query parameters bug

 - Modify appendBackslash to append the backslash at the end of the URL
path but always before the query parameters.
 - Add/modify comments for clearness and readability

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-13 10:51:49 +00:00
Tasos Alexiou 3ea7b443f1
jwa(front): Auto update mount path (#6875)
* jwa(front): Add missing generateName form control

Add missing generateName form control when creating the metadata
form group from a PVC.

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Update volume's mount path when name changes

Extend VolumeMountComponent class and update volume's mount path
when it is not dirty and name is changed. This feature affects only
the data volumes and not the workspace volume.

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Add UI tests for volume's mount path input

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
2023-01-11 14:38:16 +00:00
Kimonas Sotirchos 77ea762560
gh-actions: Create testing setup for CDB tests (#6882)
In this commit we extend workflow for running frontend tests. For
the CentralDashboard (Angular) tests we also need to ensure some
underlying apps are proxied.

In this commit we extended the dedicated workflow for the frontend tests by:
1. Applying the necessary KF Controllers (Profiles, Notebooks)
2. Applying the JWA manifests and port-forward its k8s Service
3. Applying the VWA manifests and port-forward its k8s Service
4. Creating a user namespace (kubeflow-user) via a Profile
5. Creating a test Notebook, with a PVC, in that namespace

Next steps will be to run the Cypress tests of the CDB (Angular) that
will be using the proxied apps.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-01-10 11:00:58 +00:00
Elena Zioga 20b904e109
centraldashboard(front): Move code linting to app's frontend workflow (#6855)
* centraldashboard(front): Add script file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* centraldashboard(front): Move linting check to app's frontend workflow

Signed-off-by: Elena Zioga <elena@arrikto.com>

* gh-actions: Remove frontend_linting workflow

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-01-09 12:43:57 +00:00
Elena Zioga 1fe6dbcd08
twa(front): Install prettier and add gh action (#6850)
* twa(front): Add script file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Install Prettier

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Format code

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Add formatting/linting to TWA's frontend workflow

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-01-03 13:38:24 +00:00
Orfeas Kourkakis fc213b0e5e
vwa(front): Add UI tests with Cypress (#6862)
* web-apps(front): Remove Protractor files

Remove Protractor files since it's not used anywhere in the common
code.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add Cypress attributes

Add more attributes and modify some existing ones for elements to be
selectable during UI tests with Cypress.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Install Cypress

 - Install Cypress & npm scripts for UI tests
 - Remove Protractor files
 - Update README.md with UI tests instructions

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add UI tests with Cypress

 - Add Cypress attributes for elements to be selectable during
   UI tests.
 - Add UI tests with Cypress to check that:
    * New Volume form dialog has proper values
    * Index page table contains all PVC names received
    * Index page table status icons are correctly shown
    * Index page table browse buttons are correctly shown

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(vwa): Add UI tests to VWA's frontend workflow

Add UI tests to VWA's frontend workflow. These tests should run in
Ubuntu 20.04 since Ubuntu 20.04 includes both Chrome and Firefox
installations by default.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix formatting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix format errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-03 13:11:24 +00:00
Elena Zioga 1d8d63eabe
web-apps(front): Install prettier and create a frontend workflow (#6853)
* web-apps(front): Add script

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Install Prettier

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Format code

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Create a workflow for code formatting/linting and unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-23 13:49:14 +00:00
Elena Zioga ff4711edfc
vwa(front): Add formatting/linting to VWA's frontend workflow (#6852)
* vwa(front): Format code

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Add formatting/linting to VWA's frontend workflow

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-23 13:47:15 +00:00
Orfeas Kourkakis bc6ea74433
centraldashboard-angular(front): Add library.js, source-maps & ESLint (#6846)
* centraldashboard-angular(front): Add source maps in the browser

Enable source maps in both development and production.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* centraldashboard-angular(front): Add library.js file

Copy libary.js file from the old centraldashboard project and build it
using webpack.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* centraldashboard(front): Configure ESLint

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* fixup! centraldashboard-angular(front): Add library.js file

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-23 13:42:14 +00:00
apoger f7e0655fbf
gh-actions: Revert changes for fetching full git history in the workflows (#6863)
Revert changes introduced in https://github.com/kubeflow/kubeflow/pull/6849
regarding fetching all history for all tags and branches when workflows run.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-22 08:46:14 +00:00
apoger 804ef4bdb1
Fix Makefiles/Workflows/Manifests for the example-notebook-server images (#6860)
* Set REGISTRY prefix when building notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Fix publish workflows for nb-server images when a PR is merged

Whenever a PR is merged:

* Build/Push notebook-server images with TAG=$(shell git describe --tags --always --dirty)

* Build/Push notebook-server images with TAG=latest when the target branch is master

* Build/Push notebook-server images with TAG=$(cat releasing/version/VERSION) when
  Version changes

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update manifests to use latest tag for notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-21 07:43:12 +00:00
Orfeas Kourkakis 4c2b0b320c
web-apps(front): Sort events & conditions tables by date (#6858)
* web-apps(front): Sort tables according to input

Configure tableConfig with new fields (column and order) that the table
will use to sort items during initialization.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Sort conditions table by timestamp

Initialize conditions table sorted by Last Transition Time column, with
the most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Sort events by timestamp

Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Sort events by timestamp

Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix format errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:50:19 +00:00
Orfeas Kourkakis ff2ef033ac
jwa(front): Link to VWA details page (#6857)
* web-apps(front): Create lib-urls component

Create a URLs component in Kubeflow common library which takes a
list of URLs and their corresponding name and exposes them
horizontally in a div.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add unit test for lib-urls

Add a unit test for lib-urls component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Remove column Volumes from index page

Remove Volumes column from the table in JWA's index page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Link to a Volume details from JWA details page

 - Expose all volumes from a notebook, not only PVCs.
 - Expose the volumes grouped by type, having PVCs link to their
   corresponding volume details page in VWA, using lib-urls
   component.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Implement lib-urls in VWA details page

Implement lib-urls component in the OVERVIEW tab of VWA's volume
details page to avoid duplicate code.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Use common link styles

Use common link styles in configurations component.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:49:18 +00:00
Orfeas Kourkakis a6b53f0289
web-apps(front): Fix namespace selector bug (#6845)
Fix a bug in the namespace selectors of JWA, VWA and TWA. In order to
show the namespace selector, they only checked if there is no
env.production variable available. This resulted in the selector not
showing even if there was no dashboard which is not expected.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:47:18 +00:00
apoger 5a49072aa9
Update KF manifests and gh-action workflows to use the tag=`latest` (#6854)
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

review changes

* build images with the latest tag only when a PR
  is merged to master branch

* revert changes  in manifests/workflows for the
  notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-20 15:59:18 +00:00
apoger 658f5b8a76
Extend Docker Publish workflows to be triggered on Version change (#6849)
* Extend docker publish workflows to be triggered on Version change

Changes:
* Add the path releasing/version/VERSION in the paths

* Use the 'dorny/paths-filter@v2' action to monitor the path
  "releasing/version/VERSION" and if it changes run a step
  that pushes the image with the TAG=$(cat releasing/version/VERSION)

* Set fetch-depth:0 to fetch all history for all tags and branches.
  This is required so that the tags won't end up being just a hash
  commit.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Set Version to `latest`

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-15 17:05:22 +00:00
apoger bc599a2644
centraldashboard-angular: Extend tests for using images of each PR (#6848)
* Introduce manifests for centraldb-angular component

The manifests are identical to the ones we have for the
centraldashboard component.

Changes:

* Fix image/name references to be centraldashboard-angular

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* centraldb-angular: Extend tests for using images of each PR

Changes:
* Introduce intergration test workflow
* Publish Docker image only when PR is merged

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-15 13:37:22 +00:00
Elena Zioga f73da15dea
jwa(front): Add formatting/linting to JWA's frontend workflow (#6851)
* jwa(front): Add formatting/linting to JWA's frontend workflow

Signed-off-by: Elena Zioga <elena@arrikto.com>

* Update .github/workflows/jwa_frontend_tests.yaml

Co-authored-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Update .github/workflows/jwa_frontend_tests.yaml

Co-authored-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Co-authored-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2022-12-15 13:34:22 +00:00
Orfeas Kourkakis cb89302995
jwa(front): Add details page functionalities & unit tests (#6822)
* jwa(front): Add buttons to Notebook details page

In this commit:

 - Add buttons for Connect, Start/Stop, Delete actions.
 - Create Actions Service to handle button actions and implement it
   in all components that use these buttons.
 - Small CSS tweak in title toolbar component in order for
   buttons to be aligned horizontally.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Handle query parameters in Notebook page

Add query parameter handling for each tab in order for the user to
be able to navigate directly to the tab of choice inside the
Notebook details page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add default values in lib-conditions-table fields

Add default values for lastTransitionTime, reason & message fields
in order to prevent the table's Sorting functionality returning
error due to null values.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Add unit tests for notebook-page component

In this commit, add unit tests in order to:
 - Show only the proper tab according to query parameters passed.
 - Switch tabs according to query parameters passed.
 - Update disabled field of buttons according to notebook status.
 - Update start/stop button according to notebook status.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Add unit tests for OVERVIEW tab component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-15 11:54:21 +00:00
Orfeas Kourkakis eeb0f2a3e3
vwa(front): Handle query parameters and add unit tests (#6835)
* vwa(front): Handle query parameters in Volume details page

Add query parameter handling for each tab in order for the user to
be able to navigate directly to the tab of choice inside the Volume
details page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add unit tests for volume-details-page component

Add unit tests in order to:
 - Show only the proper tab according to query parameters passed.
 - Switch tabs according to query parameters passed.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add unit tests for overview component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(vwa): Add frontend tests

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-15 11:51:21 +00:00
apoger 1addeb8457
Fix workflows for publishing images only when PR is merged (#6842)
* Fix docker-publish workflows

* Remove workflow that builds/push all images

* Remove redundant files from manifests
2022-12-15 09:51:21 +00:00
Elena Zioga e01deaf8e6
jwa(front): Rework the create page (#6826)
* jwa(front): Fix panel.ts file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify form name component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add a helper tooltip in section component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Rework the Create page

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix linting errors

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-15 09:06:22 +00:00
apoger 26e4569083
poddefaults: Extend tests for using images of each PR (#6836)
* poddefaults: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Introduce bash script to install cert-manager

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* review: Fix cert-manager installation script

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-14 11:42:29 +00:00
apoger 0190cd5abb
centraldashboard: Extend tests for using images of each PR (#6841)
Changes:

* Introduce intergration test workflow
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.
* Fix centrardashboard-angular docker-build workflow

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-14 11:08:29 +00:00
Elena Zioga b931a7f82e
web-apps(front): Add text bellow the spinner component (#6844)
Extend spinner component by adding some text below the spinner in order
to inform users why we're spinning about.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-14 10:54:29 +00:00
apoger e0daf70f04
notebook-controller: Extend tests for using images of each PR (#6830)
* Introduce intergration test workflow for notebook-controller

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Publish Docker image only when PR is merged

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Remove kind & manifest gh-action workflows

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update tag in manifests to v1.6.0

This change is required as images with v1.5.0 do not
exist in Dockerhub.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-12 14:16:28 +00:00
apoger 0d55ad3641
tensorboard-controller: Extend tests for using images of each PR (#6831)
* Introduce intergration test workflow for tensorboard-controller

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Publish Docker image only when PR is merged

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Remove kind & manifest gh-action workflows

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update tag in manifests to v1.6.0

This change is required as images with v1.5.0 do not
exist in Dockerhub.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-12 14:12:28 +00:00
apoger 7aac9d9938
crud-web-apps: Extend tests for using images of each PR (#6832)
* jwa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for JWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* twa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for TWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* vwa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for VWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-12 12:23:27 +00:00
apoger 253cfcbfa2
profile-controller: Extend tests for using images of each PR (#6820)
* Introduce github action workflow for intergration test

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Publish Docker image only when PR is merged

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Remove kind & manifest gh action tests

* Review fixes

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Extend intergration test

* Trigger workflow when kfam code changes since
  KFAM manifests are deployed with Profile Controller
  manifests.

* Build KFAM image as well and update manifests with sed
  before deploying them in the KinD cluster.

* Update tag in manifests to v1.6.0 since the images with
  tag v1.5.0 do not exist in Dockerhub.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-12 12:14:28 +00:00
Elena Zioga 1c2f3f727b
web-apps(front): Enable source maps in WAs (#6787)
* jwa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-09 14:12:11 +00:00
Elena Zioga 0327c5dcd9
twa(front): Fix unit tests (#6824)
* twa(front): Update @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* gh-actions: Add GH action to run TWA unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-09 10:44:11 +00:00
Orfeas Kourkakis b52cdc0276
vwa(front): Add YAML tab to Volume details page (#6823)
Add tab to show the full yaml of the PVC.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-09 10:43:11 +00:00
amitmukati-2604 3e4dd8da6e
Adding support for linux/ppc64le in CI for tensorboard-web-app multi-arch docker images. (#6810) 2022-12-09 09:16:11 +00:00