Cleaned up sources with pre-commit hooks. (#69)

.pre-commit-config.yaml

@@ -0,0 +1,41 @@
+# Copyright (c) 2019 Shotgun Software Inc.
+#
+# CONFIDENTIAL AND PROPRIETARY
+#
+# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit
+# Source Code License included in this distribution package. See LICENSE.
+# By accessing, using, copying or modifying this work you indicate your
+# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights
+# not expressly granted therein are reserved by Shotgun Software Inc.
+
+# Styles the code properly
+# Exclude the UI files, as they are auto-generated.
+exclude: "ui\/.*py$"
+# List of super useful formatters.
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v2.2.3
+    hooks:
+    # Ensures the code is syntaxically correct
+    - id: check-ast
+      language_version: python3
+    # Ensures a yaml file is properly formatted
+    - id: check-yaml
+    # Ensures a file name will resolve on all platform
+    - id: check-case-conflict
+    # Checks files with the execute bit set have shebangs
+    - id: check-executables-have-shebangs
+    # Ensure there's no incomplete merges
+    - id: check-merge-conflict
+    # Adds an empty line if missing at the end of a file.
+    - id: end-of-file-fixer
+    # Makes sure requirements.txt is properly formatted
+    - id: requirements-txt-fixer
+    # Removes trailing whitespaces.
+    - id: trailing-whitespace
+  # Leave black at the bottom so all touchups are done before it is run.
+  - repo: https://github.com/ambv/black
+    rev: stable
+    hooks:
+    - id: black
+      language_version: python3

after_project_create.py

@@ -23,6 +23,7 @@ the following keyword arguments:
 
 """
 
+
 def create(sg, project_id, log, **kwargs):
     """
     Insert post-project code here

core/hooks/pick_environment.py

@@ -16,7 +16,6 @@ from tank import Hook
 
 
 class PickEnvironment(Hook):
-
     def execute(self, context, **kwargs):
         """
         The default implementation assumes there are three environments, called shot, asset

core/roots.yml

@@ -67,4 +67,3 @@ primary:
 #     description: "High performance storage for fast/frequent texture access"
 #     shotgun_storage_id: 2
 #
-

core/schema/project/assets/asset_type.yml

@@ -21,4 +21,3 @@ skip_unused: false
 
 # the shotgun field to use for the folder name
 field_name: "sg_asset_type"
-

core/schema/project/assets/asset_type/asset/step.yml

@@ -13,4 +13,3 @@ type: "shotgun_step"
 
 # the shotgun field to use for the folder name
 name: "short_name"
-

core/schema/project/assets/asset_type/asset/step/publish/3dsmax.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when 3dsmax starts
 defer_creation: ["tk-3dsmax", "tk-3dsmaxplus"]
-

core/schema/project/assets/asset_type/asset/step/publish/alias.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Nuke starts
 defer_creation: "tk-alias"
-

core/schema/project/assets/asset_type/asset/step/publish/houdini.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Houdini starts
 defer_creation: "tk-houdini"
-

core/schema/project/assets/asset_type/asset/step/publish/maya.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Maya starts
 defer_creation: "tk-maya"
-

core/schema/project/assets/asset_type/asset/step/publish/mobu.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Motion Builder starts
 defer_creation: "tk-motionbuilder"
-

core/schema/project/assets/asset_type/asset/step/publish/nuke.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Nuke starts
 defer_creation: "tk-nuke"
-

core/schema/project/assets/asset_type/asset/step/publish/photoshop.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Photoshop starts
 defer_creation: "tk-photoshopcc"
-

core/schema/project/assets/asset_type/asset/step/publish/vred.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Nuke starts
 defer_creation: "tk-vred"
-

core/schema/project/assets/asset_type/asset/step/work/3dsmax.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when 3dsmax starts
 defer_creation: ["tk-3dsmax", "tk-3dsmaxplus"]
-

core/schema/project/assets/asset_type/asset/step/work/alias.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Maya starts
 defer_creation: "tk-alias"
-

core/schema/project/assets/asset_type/asset/step/work/houdini.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Houdini starts
 defer_creation: "tk-houdini"
-

core/schema/project/assets/asset_type/asset/step/work/maya.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Maya starts
 defer_creation: "tk-maya"
-

core/schema/project/assets/asset_type/asset/step/work/mobu.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Motion Builder starts
 defer_creation: "tk-motionbuilder"
-

core/schema/project/assets/asset_type/asset/step/work/nuke.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Nuke starts
 defer_creation: "tk-nuke"
-

core/schema/project/assets/asset_type/asset/step/work/photoshop.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Photoshop starts
 defer_creation: "tk-photoshopcc"
-

core/schema/project/assets/asset_type/asset/step/work/vred.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Maya starts
 defer_creation: "tk-vred"
-

core/schema/project/sequences/sequence.yml

@@ -23,4 +23,3 @@ entity_type: "Sequence"
 # (this is std shotgun API syntax)
 # any values starting with $ are resolved into path objects
 filters: [ { "path": "project", "relation": "is", "values": [ "$project" ] } ]
-

core/schema/project/sequences/sequence/shot/step.yml

@@ -13,4 +13,3 @@ type: "shotgun_step"
 
 # the shotgun field to use for the folder name
 name: "short_name"
-

core/schema/project/sequences/sequence/shot/step/publish/3dsmax.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when 3dsmax starts
 defer_creation: ["tk-3dsmax", "tk-3dsmaxplus"]
-

core/schema/project/sequences/sequence/shot/step/publish/houdini.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Houdini starts
 defer_creation: "tk-houdini"
-

core/schema/project/sequences/sequence/shot/step/publish/maya.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Maya starts
 defer_creation: "tk-maya"
-

core/schema/project/sequences/sequence/shot/step/publish/mobu.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Motion Builder starts
 defer_creation: "tk-motionbuilder"
-

core/schema/project/sequences/sequence/shot/step/publish/nuke.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Nuke starts
 defer_creation: "tk-nuke"
-

core/schema/project/sequences/sequence/shot/step/publish/photoshop.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Photoshop starts
 defer_creation: "tk-photoshopcc"
-

core/schema/project/sequences/sequence/shot/step/work/3dsmax.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when 3dsmax starts
 defer_creation: ["tk-3dsmax", "tk-3dsmaxplus"]
-

core/schema/project/sequences/sequence/shot/step/work/houdini.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Houdini starts
 defer_creation: "tk-houdini"
-

core/schema/project/sequences/sequence/shot/step/work/maya.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Maya starts
 defer_creation: "tk-maya"
-

core/schema/project/sequences/sequence/shot/step/work/mobu.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Motion Builder starts
 defer_creation: "tk-motionbuilder"
-

core/schema/project/sequences/sequence/shot/step/work/nuke.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Nuke starts
 defer_creation: "tk-nuke"
-

core/schema/project/sequences/sequence/shot/step/work/photoshop.yml

@@ -13,4 +13,3 @@ type: "static"
 
 # defer creation and only create this folder when Photoshop starts
 defer_creation: "tk-photoshopcc"
-

env/includes/settings/tk-houdini.yml

@@ -118,4 +118,3 @@ settings.tk-houdini.shot_step:
   - {app_instance: tk-multi-workfiles2, name: File Save...}
   - {app_instance: tk-multi-publish2, name: Publish...}
   location: '@engines.tk-houdini.location'
-

env/includes/settings/tk-multi-launchapp.yml

@@ -60,4 +60,3 @@ settings.tk-multi-launchapp.motionbuilder:
   windows_path: "@path.windows.motionbuilder"
   menu_name: MotionBuilder
   location: "@apps.tk-multi-launchapp.location"
-

env/includes/settings/tk-multi-loader2.yml

@@ -363,5 +363,3 @@ settings.tk-multi-loader2.vred:
   actions_hook: "{engine}/tk-multi-loader2/basic/scene_actions.py"
   publish_filters: [["sg_status_list", "is_not", null]]
   location: "@apps.tk-multi-loader2.location"
-
-

env/includes/settings/tk-multi-publish2.yml

@@ -555,4 +555,3 @@ settings.tk-multi-publish2.vred.asset_step:
      settings: {}
   help_url: *help_url
   location: "@apps.tk-multi-publish2.location"
-

hooks/snapshot_history_post_quickdaily.py

@@ -11,8 +11,8 @@
 from tank import Hook
 from tank import TankError
 
-class SnapshotHistoryPostQuickdaily(Hook):
 
+class SnapshotHistoryPostQuickdaily(Hook):
     def execute(self, mov_path, version_id, comments, **kwargs):
         app = self.parent
         # get app

hooks/tk-multi-launchapp/before_register_command.py

@@ -12,6 +12,7 @@ import sgtk
 
 HookBaseClass = sgtk.get_hook_baseclass()
 
+
 class BeforeRegisterCommand(HookBaseClass):
     """
     Before Register Command Hook
@@ -20,6 +21,7 @@ class BeforeRegisterCommand(HookBaseClass):
     the parent engine. Note: this hook is only run for Software entity
     launchers.
     """
+
     def determine_engine_instance_name(self, software_version, engine_instance_name):
         """
         Hook method to intercept SoftwareLauncher and engine instance name data prior to
@@ -42,4 +44,3 @@ class BeforeRegisterCommand(HookBaseClass):
             engine_instance_name = "tk-nukestudio"
 
         return engine_instance_name
-