Correct route provider attribute usages (fixes #1405).

Also cleanup redundant attribute usage attributes on MVC filter overrides.

src/Common/Routing/RouteProviderAttribute.cs

@@ -16,6 +16,7 @@ namespace System.Web.Mvc.Routing
 #endif
 {
     /// <summary>Represents an attribute route that may contain custom constraints.</summary>
+    [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = false, AllowMultiple = true)]
     public abstract class RouteProviderAttribute : Attribute, IDirectRouteProvider
     {
         private readonly string _template;

src/System.Web.Mvc/OverrideActionFiltersAttribute.cs

@@ -5,7 +5,6 @@ using System.Web.Mvc.Filters;
 namespace System.Web.Mvc
 {
     /// <summary>Represents a filter attribute that overrides action filters defined at a higher level.</summary>
-    [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = false)]
     public sealed class OverrideActionFiltersAttribute : FilterAttribute, IOverrideFilter
     {
         /// <inheritdoc />

src/System.Web.Mvc/OverrideAuthenticationAttribute.cs

@@ -7,7 +7,6 @@ namespace System.Web.Mvc
     /// <summary>
     /// Represents a filter attribute that overrides authentication filters defined at a higher level.
     /// </summary>
-    [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = false)]
     public sealed class OverrideAuthenticationAttribute : FilterAttribute, IOverrideFilter
     {
         /// <inheritdoc />

src/System.Web.Mvc/OverrideAuthorizationAttribute.cs

@@ -7,7 +7,6 @@ namespace System.Web.Mvc
     /// <summary>
     /// Represents a filter attribute that overrides authorization filters defined at a higher level.
     /// </summary>
-    [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = false)]
     public sealed class OverrideAuthorizationAttribute : FilterAttribute, IOverrideFilter
     {
         /// <inheritdoc />

src/System.Web.Mvc/OverrideExceptionFiltersAttribute.cs

@@ -5,7 +5,6 @@ using System.Web.Mvc.Filters;
 namespace System.Web.Mvc
 {
     /// <summary>Represents a filter attribute that overrides exception filters defined at a higher level.</summary>
-    [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = false)]
     public sealed class OverrideExceptionFiltersAttribute : FilterAttribute, IOverrideFilter
     {
         /// <inheritdoc />

src/System.Web.Mvc/OverrideResultFiltersAttribute.cs

@@ -5,7 +5,6 @@ using System.Web.Mvc.Filters;
 namespace System.Web.Mvc
 {
     /// <summary>Represents a filter attribute that overrides result filters defined at a higher level.</summary>
-    [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = false)]
     public sealed class OverrideResultFiltersAttribute : FilterAttribute, IOverrideFilter
     {
         /// <inheritdoc />

test/Common/Routing/RouteProviderAttributeTests.cs

@@ -253,6 +253,20 @@ namespace System.Web.Mvc.Routing
             Assert.Same(existingConstraints, constraints);
         }
 
+        [Fact]
+        public void AttributeUsage_IsAsSpecified()
+        {
+            // Act
+            AttributeUsageAttribute usage = (AttributeUsageAttribute)Attribute.GetCustomAttribute(
+                typeof(RouteProviderAttribute), typeof(AttributeUsageAttribute));
+
+            // Assert
+            Assert.NotNull(usage);
+            Assert.Equal(AttributeTargets.Class | AttributeTargets.Method, usage.ValidOn);
+            Assert.Equal(false, usage.Inherited);
+            Assert.Equal(true, usage.AllowMultiple);
+        }
+
         private static DirectRouteBuilder CreateBuilder(Func<RouteEntry> build)
         {
             return new LambdaDirectRouteBuilder(build);