- #16
- remove temporary suppression for this rule
- add suppressions for a couple of rules violated only in Debug builds
Tested to confirm all MW120x rule suppresions are needed and therefore that rules work fine.
- removed global override for MW1200; already suppressed in one place it's needed (`RazorParser`)
- #2
- a few manual changes in `License.txt`, `Settings.StyleCop`, `CommonAssemblyInfo.*`, and
`tools\src\Microsoft.Web.FxCop\Properties\AssemblyInfo.cs`
- add `DisplayExtensionsTest` and `EditorExtensionsTest`, were previously
primarily testing lower-level calls to `TemplateHelper` or the templates
A few intentional gaps...
- do not test every overload of each helper since they share HTML generation
- test only DropDownList() since `DropDownListFor()`, `EnumDropDownListFor()`,
and `TextBox()` use the same HTML generation
- do not test _every_ value source (parameter value, `ModelMetadata.Model`,
`ModelStateDictionary` entry, `ViewDataDictionary.Model`,
`ViewDataDictionary` entry), they are treated identically once found
- do not test id sanitization except in `Id[For[Model]]()` themselves,
worst case they'll be attribute-encoded (no, that never happens)
- do not test validation attributes since they are treated like any other
attribute and data comes from `ModelClientValidationRule` instances
- correct `DisplayNameExtensions` typo, one test executed `Display()` and not
`DisplayName()`
- update one parameter name in recently-added `DefaultDisplayTemplatesTest`
method
- all()/any() of more element types
- arithmetic negate
- casts to more complex and entity types and from string to more types
- group inclusions
- validation of nested expressions
Clean tests up
- correct use of System.Web.Http.OData.Query.Expressions namespace in v4 tests
- improve test and data set names e.g. "Of" -> "If" and removing "Fails"
- test `Address` type only when using `Product` model
Test other flag properties in `ODataValidationSettings`
- remove `[Fact]` tests for specific flags and add `[Theory]` tests
- follow model of recently-added `AllowedFunctions` tests
nits
- make test data more consistent between v3 / v4 test classes
- change some "*Throw*" test methods to allow None; exception thrown regardless
- add missing `// Arrange` etc. comments
- Stream comes before String
- fix a few comment typos
- wrap a couple of long lines
an attribute routed action while inside Controller.Initialize.
The issue is that we haven't selected the 'real' action yet and promoted
its route data when we run Controller.Initialize.
This change adds the required value to data tokens so that we return the
right value inside Initialize.
WebHost scenarios
The issue here is that when we do batching in a Web Host scenario, we
delegate to the System.Web route table - we do this by wrapping each
HttpRequestMessage in a wrapper that implements HttpRequestBase.
Our adapter isn't doing the right thing with respect to escaping. This
change brings the adapter into compliance and adds an integration test.
media type.
This change adds an overload to ReadAsMultipartAsync which bypasses header
validation for the individual 'parts'. This allows handling of file
uploads where the client doesn't specify a valid media type.
Note that the caller will have to retrieve the header values of the
'parts' using the indexer to the header collection. The getters for
strongly-typed header values will return null if the header is invalid.