Needed for docker/docker#24823.
This changes datastructures in accordance with the upstream swarmkit
changes. It also adds flags to SwarmUpdate to allow token rotation.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
This fix tries to address the issue raised in
https://github.com/docker/docker/issues/23367
where an out-of-band volume driver deletion leaves some data in docker.
This prevent the reuse of deleted volume names (by out-of-band volume driver
like flocker).
This fix adds a `--force` field in `docker volume rm` to forcefully purge
the data of the volume that has already been deleted.
This fix is related to pull request in docker:
https://github.com/docker/docker/pull/23436
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
In general, the Docker API client should avoid exposing HTTP details in
client, as it elides type safety and makes discovery of inputs to a
method more challenging. These have been removed and replaced with an
options type.
We may want to consider arbitrary header transmission through context,
but that is a bigger change.
Proper build tags have been added to experimental features that were
failing during non-tagged build.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
Modify `ServiceInspect` to `ServiceInspectWithRaw`, and have it returned
the raw bytes.
Signed-off-by: Arnaud Porterie (icecrime) <arnaud.porterie@docker.com>
This groups method definitions by "object" type (container, image, …)
into smaller interface and use composition to make CommonAPIClient and
APIClient the same as right now.
This also moves `Checkpoint*` methods to the *experimental* interface as
it will be enabled into experimental first.
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
This fix tries to add config paramter to change per-contaienr stop timeout during
the daemon shutdown. As the part of the update, this fix also changes `docker restart`
and `docker stop` so that if `--time` is not specified, then the default stop timeout
(10s) will be used.
This fix is related to
https://github.com/docker/docker/pull/22566https://github.com/docker/docker/issues/22471
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Currently docker start API always contains a trailing `checkpoint=` even
if value is empty, this is unnecessary, we can set it only when it's not
empty.
Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
This fix is related to docker:
https://github.com/docker/docker/pull/23090
The -f flag on docker tag has been deprecated in docker 1.10 and is
expected to be removed in docker 1.12.
This fix updated the associated files in engine-api.
Related tests have also been updated.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
At some point the format of the reference should be daemon specific, and
thus should not be *imposed* via the repository:tag current
arguments. The engine-api library should encorage the use of reference.
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Change method signatures to make required arguments actually
required (using a paramater), all accross the API.
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
In general, `net/context.Context` should be the first argument to
methods that may be on a request call chain. While some API methods had
context, many did not, making support inconsistent. Applications that
require full plumbing of context, such as those that rely on
cancellation for resource cleanup, would be incompatible with
inconsistent plumbing. The change takes a first pass at adding context
through the entire API.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
Backported from docker/docker project. Makes it easy and readable to
know what methods to implement to be considered as a complete docker client.
Signed-off-by: Vincent Demeester <vincent@sbr.pm>