* Simplify. Just let roslyn always load the compiler assemblies.
* Update doc
* Update roslyn version
* Fix warnings introduced when multitargeting
---------
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
Co-authored-by: Jared Parsons <jared@paranoidcoding.org>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 10.0.561001 -> To Version 10.0.562001
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Fixes https://github.com/dotnet/razor/issues/10744
Needs https://github.com/dotnet/roslyn/pull/76293 to merge and a version
bump, but you know the idea by now I'm sure.
Pretty straight forward. The test snippet file was copied directly from
Roslyns own inline completion tests. Turns out our existing inline
completion has zero tests, and was inadvertently turned off in the first
cohosting completion PR 🤦♂️
Fixes https://github.com/dotnet/razor/issues/11237
Needs https://github.com/dotnet/roslyn/pull/76002 and a version bump
Very simple one, though I was a little cheeky. There is basically no
code that could be shared, except for code that removes `__o` and
`k_BackingField` from the results, but those methods operate on VS LSP
types. Given cohosting largely uses Roslyn LSP types, and will be
exclusively FUSE, and FUSE doesn't have `__o`, I just skipped that bit.
Confirmed in VS that having cohosting and FUSE on makes for nice looking
results with no generated code artifacts.
Side note: I don't think anything will ever have `k_BackingField` in the
results, but there is zero test coverage so who knows! 😁
* Update dependencies from https://github.com/dotnet/arcade build 20241122.2
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 9.0.0-beta.24562.13 -> To Version 9.0.0-beta.24572.2
* Failed to perform coherency update for one or more dependencies.
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Handle skipped trivia in the C# tokenizer
Reaction to https://github.com/dotnet/roslyn/pull/75724. Will need to update to a version of Roslyn with this change to be able to test.
* Account for included newline
* Update versions
* Report an error when encountering a `#` in skipped tokens, new tests/update baselines
* More baselines
* Add test example
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 9.0.0-beta.24516.2 -> To Version 9.0.0-beta.24562.13
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update Roslyn package references to latest available and do minor fixup
* Updating Versions.Details.xml to match Versions.props
* PR suggestion
* Fixing test failures
Roslyn was requesting new IRazorMappingService and our TestRazorDocumentServiceProvider was throwing. Returning null for now per suggestion from Andrew.
* Adding TODO comment per code review
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 10.0.0-alpha.1.24467.1 -> To Version 10.0.0-alpha.1.24473.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Fixes https://github.com/dotnet/razor/issues/10696
Fixes https://github.com/dotnet/razor/issues/10769
Fixes https://github.com/dotnet/razor/issues/10874
Needs Roslyn change: https://github.com/dotnet/roslyn/pull/75102
The actual code change was quite straight foward. The test code was a
bigger pain. Previously in cohosting tests we had two MEF composition,
one for Razor and one for Roslyn. Since Roslyn diagnostics can only run,
or at least start, in devenv, we now need three MEF compositions -
Roslyn devenv, Roslyn OOP and razor OOP - and two workspaces - Roslyn
devenv and Roslyn OOP - and our previous MEF infrastructure really
didn't handle this well, as evidenced by the fact that this PR also
fixes https://github.com/dotnet/razor/issues/10874
Now our MEF infra is simpler: We still cache catalogs etc. statically
the save time, but we create an `ExportProvider` as needed and expect
consumers to dispose of it like any other `IDisposable`, though there is
also here a test fixture to share the editor composition in the
formatting tests so we don't pay a huge penalty in terms of test run
time.
Commit-at-a-time if you want to read the story from beginning to end,
but it should be reasonably okay to just review as a whole too.
David Barbet
dotnet-maestro[bot]
Chris Sienkiewicz
David Wengier
dotnet-maestro[bot]
Carlos Sánchez López
Jan Jones
Fred Silberberg
Alex Gavrilov
Ankita Khera
akhera99
Phil Allen