Граф коммитов

7448 Коммитов

Автор SHA1 Сообщение Дата
David Wengier 30258ab875 Call the new mapping method when formatting 2021-11-17 17:18:07 +11:00
David Wengier 51f53e0609 Add a new method to map an edit which takes into account mutliline edits that start in an unmapped region, and end in a mapped region. 2021-11-17 17:18:00 +11:00
David Wengier 5082877620 Add failing and passing tests 2021-11-17 17:17:32 +11:00
David Wengier 9b4b496f60
Merge pull request #5739 from davidwengier/IfStatementInsideLambda 2021-11-17 10:36:12 +11:00
David Wengier 39d4591033 Add failing test 2021-11-16 17:56:14 +11:00
dotnet-maestro[bot] 350c1c98c9
Update dependencies from https://github.com/dotnet/arcade build 20211109.3 (#5734)
[main] Update dependencies from dotnet/arcade
2021-11-15 13:54:54 +00:00
dotnet-maestro[bot] 76465fc4b4
[main] Update dependencies from dotnet/aspnetcore (#5720)
[main] Update dependencies from dotnet/aspnetcore
2021-11-13 21:48:39 +00:00
N. Taylor Mullen 85df41f8c4 Fix directive attribute completion in legacy Razor editor
- In legacy editor's directive attribute completion we used to dismiss the active completion session to take over and show our own attribute completion. Looks like when we changed our threading model we broke the UI thread expectation of dismissing that old active session. This in turn results in a flooding of directive completion sessions.
- Updated tests

### Before

![image](https://user-images.githubusercontent.com/2008729/141396947-9a107ff8-1760-451a-a4af-11a0ce75f28b.png)

### After

![image](https://user-images.githubusercontent.com/2008729/141396883-3b4dd048-a53b-47c5-987e-f9c03bf8312a.png)

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1434858
2021-11-11 20:41:22 -08:00
N. Taylor Mullen 233996dad7
Merge pull request #5633 from dotnet/darc-main-864344fb-8c9b-4843-8ec8-0d0286de492b
[main] Update dependencies from dotnet/aspnetcore dotnet/arcade
2021-11-09 17:04:03 -08:00
Ryan Brandenburg f158533dae
Fix provisional completion in error cases (#5705) 2021-11-09 17:02:16 -08:00
N. Taylor Mullen bdd55d02d5 Restrict C# forced "invoke base completion" to not apply to HTML.
- Our Razor language server provides component/TagHelper completions at start of words and when I originally added the completion logic to request full completion lists always I didn't consider that markup languages are a lot less "kind" to that approach. Therefore, I'm reverting that specific portion of logic + the test change that went with it.

### Before

![before experience](https://i.imgur.com/QlBo4xJ.gif)

### After

![after experience](https://i.imgur.com/xddr9id.gif)

Fixes #5685
2021-11-08 16:44:06 -08:00
David Wengier 34a14d6cf4
Merge pull request #5706 from davidwengier/DontReturnNetZeroEdits 2021-11-09 11:23:32 +11:00
N. Taylor Mullen 6f8e3d5a5a Attempt to fix transient StreamJsonRpc CI failure.
- Given the CI failure is impossible to reproduce locally / doesn't happen consistently this is a shot in the dark. My thought is that if we can ensure that the transient StreamJsonRpc package referenes always normalize down into one version in our .NET Framework projects via pinning that ideally we shouldn't have any issues. I only ever saw LiveShare and Remote.Razor projects have this issue via binlogs so I'm starting the StreamJsonRpc pinning here.
- Was able to remove the ExternalAccess.Razor dependency from Remote.Razor because it was brought in transitively.

Fixes #4327
2021-11-08 14:52:20 -08:00
N. Taylor Mullen 359bef1c59 Fix binding redirects to point to 6.0.1.0 for Razor compiler binaries. 2021-11-08 13:59:23 -08:00
N. Taylor Mullen 4c69a1e638
Dismiss C# completion on typing of numeric. (#5701)
- Found that when typing out numeric characters C# completion would stay active. Turns out the reason behind this was that our word pattern for C# was incorrect for identifiers resulting in numerics at beginning of words being considered part of the identifier.
- This fix restricts numerics `\d` at the beginning of C# identifiers which then causes the platform to dismiss completion on breaking of word boundaries.

### Before

![before image](https://i.imgur.com/UJGnwcD.gif)

### After

Note, cursor jumping to the top of the block after typing `;` in this gif is a platform [bug](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1430727).
![after image](https://i.imgur.com/Z8d5PUq.gif)

Fixes dotnet/aspnetcore#5691
2021-11-08 21:33:59 +00:00
Ryan Brandenburg eaed606701
Add logging to LinkedEditingRangeEndpoint (#5700) 2021-11-08 13:27:20 -08:00
Ryan Brandenburg 9a7bd4f58c
Nullable in CodeActions (#5690)
* Nullable in CodeActions

* PR suggestion
2021-11-08 11:14:28 -08:00
Ryan Brandenburg 5a1ce433f3 Handle nuget.org API change 2021-11-08 11:00:00 -08:00
dotnet-maestro[bot] 3b31067a8a Update dependencies from https://github.com/dotnet/arcade build 20211105.2
Microsoft.DotNet.Arcade.Sdk
 From Version 7.0.0-beta.21518.1 -> To Version 7.0.0-beta.21555.2
2021-11-08 13:20:22 +00:00
David Wengier bb90c50d95 Don't send back edits if no changes were made 2021-11-08 15:37:10 +11:00
Safia Abdalla 81502e1cb9
Pin vsce version used in release script (#5704) 2021-11-07 11:41:32 -08:00
dotnet-maestro[bot] f2e1410885 Update dependencies from https://github.com/dotnet/aspnetcore build 20211104.17
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21518.12 -> To Version 6.0.1

Dependency coherency updates

Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging,System.Diagnostics.DiagnosticSource,System.Resources.Extensions,System.Text.Encodings.Web,Microsoft.Extensions.DependencyModel,Microsoft.NETCore.App.Ref,Microsoft.NETCore.BrowserDebugHost.Transport,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.Platforms
 From Version 6.0.0-rtm.21518.4 -> To Version 6.0.0 (parent: Microsoft.CodeAnalysis.Razor
2021-11-05 01:34:52 +00:00
N. Taylor Mullen 7bfa1b995c Fix Enqueue_DisposedPreventsRestart flaky test.
- Turns out we weren't waiting for our background workloads to actually complete before disposing our baching work queue resulting in the possibility that dispose occurs before actually processing any items.
- Ran the test over 20k times (`Combinatorial` attribute) and didn't see a failure after the fix (saw failures pre-fix).

Fixes #4398
2021-11-03 13:27:16 -07:00
dotnet-maestro[bot] 5333629565 Update dependencies from https://github.com/dotnet/aspnetcore build 20211102.33
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21518.12 -> To Version 6.0.1

Dependency coherency updates

Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging,System.Diagnostics.DiagnosticSource,System.Resources.Extensions,System.Text.Encodings.Web,Microsoft.Extensions.DependencyModel,Microsoft.NETCore.App.Ref,Microsoft.NETCore.BrowserDebugHost.Transport,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.Platforms
 From Version 6.0.0-rtm.21518.4 -> To Version 6.0.0 (parent: Microsoft.CodeAnalysis.Razor
2021-11-03 04:06:37 +00:00
N. Taylor Mullen 6eaa0997e9 Update src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test.Common/LanguageServerTestBase.cs
Co-authored-by: Allison Chou <allichou@microsoft.com>
2021-11-02 13:06:04 -07:00
N. Taylor Mullen 88353874f5 Fix FileSystemWatcher_RazorFileEvent_Background_AddRemoveDoesNotNotify flaky test.
- Turns out XUnit would occasionally construct a `TestProjectSnapshotManagerDispatcher` on test threads (there was no guarantee which thread was the constructor) and because of that the test variant of the dispatcher would bind to that thread and use it to attempt to re-dispatch notifications. Well our RazorFileEvent test's final step would be to re-dispatch file notifications via the dispatcher while simultaneously waiting for the notification to be sent on the test side. This resulted in a deadlock killing the test.
- Updated the `LanguageServerTestBase` to rename the existing `Dispatcher` to `LegacyDispatcher` and add a new `Dispatcher` that utilizes the real LSP dispatcher. I took this approach because there's loads of locations that utilize the pre-existing `LegacyDispatcher` that will need to be iteratively moved to the real dispatcher type to ensure things work as expected. Issue tracking migrating tests to the "real" dispatcher: https://github.com/dotnet/razor-tooling/issues/5683

Fixes #4401
2021-11-02 13:06:04 -07:00
dotnet-maestro[bot] 6c000760a3 Dependency coherency updates
Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging,System.Diagnostics.DiagnosticSource,System.Resources.Extensions,System.Text.Encodings.Web,Microsoft.Extensions.DependencyModel,Microsoft.NETCore.App.Ref,Microsoft.NETCore.BrowserDebugHost.Transport,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.Platforms
 From Version 6.0.0-rtm.21518.4 -> To Version 6.0.0 (parent: Microsoft.CodeAnalysis.Razor
2021-11-01 23:10:51 +00:00
dotnet-maestro[bot] cd6014fecd Update dependencies from https://github.com/dotnet/arcade build 20211029.1
Microsoft.DotNet.Arcade.Sdk
 From Version 7.0.0-beta.21524.1 -> To Version 7.0.0-beta.21529.1
2021-11-01 23:10:35 +00:00
dotnet-maestro[bot] 207f0e3268 Update dependencies from https://github.com/dotnet/aspnetcore build 20211026.8
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0 -> To Version 6.0.0
2021-11-01 23:10:12 +00:00
dotnet-maestro[bot] 3b7b5a4e64 Update dependencies from https://github.com/dotnet/arcade build 20211024.1
Microsoft.DotNet.Arcade.Sdk
 From Version 7.0.0-beta.21518.1 -> To Version 7.0.0-beta.21524.1
2021-11-01 23:10:05 +00:00
dotnet-maestro[bot] e3df31e9ae Update dependencies from https://github.com/dotnet/aspnetcore build 20211023.4
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0 -> To Version 6.0.0
2021-11-01 23:09:42 +00:00
dotnet-maestro[bot] b9527d54ad Update dependencies from https://github.com/dotnet/aspnetcore build 20211023.2
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0 -> To Version 6.0.0
2021-11-01 23:09:35 +00:00
dotnet-maestro[bot] aa736d6ca7 Update dependencies from https://github.com/dotnet/aspnetcore build 20211021.10
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0 -> To Version 6.0.0
2021-11-01 23:09:28 +00:00
dotnet-maestro[bot] 4e0fed7df8 Update dependencies from https://github.com/dotnet/aspnetcore build 20211021.9
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0 -> To Version 6.0.0
2021-11-01 23:09:21 +00:00
dotnet-maestro[bot] 7c150638c9 Update dependencies from https://github.com/dotnet/aspnetcore build 20211021.7
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0 -> To Version 6.0.0
2021-11-01 23:09:14 +00:00
dotnet-maestro[bot] 9b2ac23c97 Update dependencies from https://github.com/dotnet/aspnetcore build 20211021.5
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0 -> To Version 6.0.0
2021-11-01 23:09:07 +00:00
dotnet-maestro[bot] fc256d9830 Update dependencies from https://github.com/dotnet/aspnetcore build 20211021.2
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0 -> To Version 6.0.0
2021-11-01 23:08:59 +00:00
dotnet-maestro[bot] 9a69636373 Update dependencies from https://github.com/dotnet/aspnetcore build 20211021.1
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0 -> To Version 6.0.0
2021-11-01 23:08:52 +00:00
dotnet-maestro[bot] ca24519203 Update dependencies from https://github.com/dotnet/aspnetcore build 20211020.14
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21520.4 -> To Version 6.0.0
2021-11-01 23:08:45 +00:00
dotnet-maestro[bot] 4f84c04941 Update dependencies from https://github.com/dotnet/aspnetcore build 20211020.4
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21520.1 -> To Version 6.0.0-rtm.21520.4
2021-11-01 23:08:39 +00:00
dotnet-maestro[bot] d15faa48bb Update dependencies from https://github.com/dotnet/aspnetcore build 20211020.1
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21519.22 -> To Version 6.0.0-rtm.21520.1
2021-11-01 23:08:32 +00:00
dotnet-maestro[bot] 45bd8a7988 Update dependencies from https://github.com/dotnet/aspnetcore build 20211019.22
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21519.19 -> To Version 6.0.0-rtm.21519.22
2021-11-01 23:08:26 +00:00
dotnet-maestro[bot] 7d494e8b10 Update dependencies from https://github.com/dotnet/aspnetcore build 20211019.19
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21519.13 -> To Version 6.0.0-rtm.21519.19
2021-11-01 23:08:19 +00:00
dotnet-maestro[bot] aa8a442dc4 Update dependencies from https://github.com/dotnet/aspnetcore build 20211019.13
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21519.6 -> To Version 6.0.0-rtm.21519.13
2021-11-01 23:08:13 +00:00
dotnet-maestro[bot] 4aa36b159f Update dependencies from https://github.com/dotnet/aspnetcore build 20211019.6
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21519.3 -> To Version 6.0.0-rtm.21519.6
2021-11-01 23:08:07 +00:00
dotnet-maestro[bot] 0b400da315 Update dependencies from https://github.com/dotnet/aspnetcore build 20211019.3
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21518.20 -> To Version 6.0.0-rtm.21519.3
2021-11-01 23:08:00 +00:00
dotnet-maestro[bot] 5bb41464cd Update dependencies from https://github.com/dotnet/aspnetcore build 20211018.20
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
 From Version 6.0.0-rtm.21518.12 -> To Version 6.0.0-rtm.21518.20
2021-11-01 23:07:53 +00:00
N. Taylor Mullen 8625439e1a
Merge branch 'main' into darc-main-864344fb-8c9b-4843-8ec8-0d0286de492b 2021-11-01 15:57:04 -07:00
Ryan Brandenburg ad92296920
Log GoToDefinition ProjectionResult null (#5667) 2021-10-29 09:50:38 -07:00
Allison Chou 7a15c3fd24
Add wordPattern (#5671) 2021-10-28 18:35:42 -07:00