Now that razor is on .NET 9 arcade, it can switch over to the new control schema. For this repo, this is roughly:
- DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build.
- DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build.
- ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build.
It was tedious to get the actual argument right, so this checks for multiple forms and tries to correct them.
The following should be supported now:
eng\scripts\featureflag.ps1 -set -flag Razor.LSP.ForceRuntimeCodeGeneration -enable
eng\scripts\featureflag.ps1 -set -flag Razor\LSP\ForceRuntimeCodeGeneration -enable
eng\scripts\featureflag.ps1 -set -flag FeatureFlags.Razor.LSP.ForceRuntimeCodeGeneration -enable
eng\scripts\featureflag.ps1 -set -flag FeatureFlags\Razor\LSP\ForceRuntimeCodeGeneration -enable
This should make copying the value from code easier to figure out. We could also just assume feature flags start with FeatureFlags\LSP\Razor\<flagname> but that's not inherantly true, just happens to be for now.
Since integrating our repos, there have been a number of changes in PRs that touch the encoding of the file, adding or removing a BOM as the editor in question decides. I've standardized on UTF-8 with BOM, as we do in roslyn, and put it in the .gitattributes so it should hopefully stay consistent.
- In preparation for merging the Razor VSCode extension I've added support for npmproj files. I tried to maintain the same functionality that AspNetCore offers for its npmproj support.
- Added an extra `--ignore-engines` check to `yarn install` in preparation for VSCode's extension model. They expect there to be a vscode engine in the package.json that yarn doesn't understand.
aspnet/AspNetCore#13494
Changes:
* Update to latest core-setup dependencies (generated using https://github.com/aspnet/AspNetCore-Internal/pull/1830)
* Add a step which asserts that version.props and versions.details.xml are in sync
* Add PR check which ensures solution files are not broken
Matt Mitchell
Andrew Hall
David Wengier
Fred Silberberg
Ryan Brandenburg
Dustin Campbell
Doug Bunting
Kevin Pilch
John Luo
N. Taylor Mullen
Javier Calvarro Nelson
Nate McMaster