* Pin all Microsoft.Extensions.X to 6.0.0.
- Prior to this O# would bring in 2.0.0 versions of logging and dependency injection. This conflicted with VS4Mac's dependency of 6.0.0.
- Updated binding redirects for the abstractions and non-abstraction variants so that VS win does the right thing at runtime (also verified manually).
- Removed the `MicrosoftExtensions.ConfigurationPackageVersion` specification. Grouped it with the other Extension package versions (6.0.0)
Part of 6038
* Fix nullref warnings
* Remove DependencyModelPackageVersion
- Looks like this was all legacy code from back when the Razor compiler + SDK was in our repo. Removed!
* Fixed build warning about duplicate analyzers.
- We get analyzers transitively from `Microsoft.CodeAnalysis.Common`
- The old `DefaultLSPEditorFeatureDetector` was bound to windows (read VS win settings, feature flags, UI Contexts, depended on LiveShare) so I moved it to the windows specific binary and renamed it to be windows specific. I plan to implement a VSMac equivalent in a follow up.
- Had to add some new project dependencies to the windows assembly because oddly the LSP.Implementation assembly that's platform agnostic has VSwindows specific transitive dependencies.
Part of #6038
* Fix Dependency Tree
@wtgodbe pointed out that `Microsoft.AspNetCore.Testing` isn't actually a dependency here, which is causing issues with the darc subscription.
* Update Version.Details.xml
* Microsoft.NET.Sdk.Razor (aspnetcore -> sdk)
* Update Dependencies Darc
* Remove Microsoft.NET.Sdk.Razor & Microsoft.NETCore.App.Ref
* React to `TrySplitNamespaceAndType` removal.
- In our `AddUsingsCodeActionProviderFactory` I went ahead and recreated the base type so we could continue to work as expected.
* Update src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/AddUsingsCodeActionProviderFactory.cs
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
* Remove MicrosoftNETCoreAppRefPackageVersion
* Fix more warnings
* Update eng/Versions.props
Co-authored-by: Pranav K <prkrishn@hotmail.com>
* Revert Microsoft.NETCore.App.Runtime & Microsoft.NETCore.Platforms changes
* Fix hashes
* Fix `MicrosoftNETSdkRazorPackageVersion` Missing in Version.Details.xml
* Microsoft.NETCore.App.Runtime Removal
* Fix broken rename tests.
Co-authored-by: N. Taylor Mullen <nimullen@microsoft.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
* Fix ability to run tests in VS & on command line.
- Since Razor utilizes a global.json that restricts what SDK is used this conflicts with the test runner who expects net6.0 to be available. Migrating our test projects to net6.0 resolves the ability to run tests in VS & at command line while simultaneously making everything faster 😄.
- Also moved rzls (VSCode language server) to net6.0 because it was darn easy and didn't require much extra work!
Fixes#5904
* Update net461 -> net472
* Manually install node
* Use Git SHA instead of BranchName
* SourceBranchName
* Install node closer to build
* Update Version
* React to Template and classification changes
* Skip coloration tests based on VS version
[main] Update dependencies from dotnet/aspnetcore
- Coherency Updates:
- Microsoft.NETCore.App.Ref: from 6.0.1 to 6.0.2 (parent: Microsoft.AspNetCore.Testing)
- Microsoft.NETCore.BrowserDebugHost.Transport: from 6.0.1-servicing.21567.5 to 6.0.2-servicing.22064.6 (parent: Microsoft.AspNetCore.Testing)
- Microsoft.NETCore.App.Runtime.win-x64: from 6.0.1 to 6.0.2 (parent: Microsoft.AspNetCore.Testing)
* Bump Razor addin version to 17.0
* Remove redundant Addin attributes
* Update mpack version in more places
* Delete RazorAddin.cs as it no longer seems used for anything
Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Internal.Transport , Microsoft.AspNetCore.Razor.Symbols.Transport , Microsoft.CodeAnalysis.Razor.Tooling.Internal
From Version 6.0.2-1.22056.2 -> To Version 6.0.2-1.22076.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Internal.Transport , Microsoft.CodeAnalysis.Razor.Tooling.Internal
From Version 6.0.2-1.21616.1 -> To Version 6.0.2-1.21617.1
[main] Update dependencies from dotnet/aspnetcore
- Coherency Updates:
- Microsoft.NETCore.App.Ref: from 6.0.0 to 6.0.1 (parent: Microsoft.AspNetCore.Testing)
- Microsoft.NETCore.BrowserDebugHost.Transport: from 6.0.0-rtm.21522.10 to 6.0.1-servicing.21567.5 (parent: Microsoft.AspNetCore.Testing)
- Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0 to 6.0.1 (parent: Microsoft.AspNetCore.Testing)
- Microsoft.NETCore.Platforms: from 6.0.0 to 6.0.1 (parent: Microsoft.AspNetCore.Testing)
- Unpinned Nerdbank.Streams in some projects since it seemed that our restore graph already encompassed coherent nerdbank versions, we were the only ones causing issues.
- Pinned Microsoft.VisualStudio.Threading to 17.0.63 (this is what core editor is pinning too) to avoid all of the various incoherent versions from transient packages floating around. This in turn upgraded some threading analyzers which I had to react to as well.
Fixes#5717
Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Internal.Transport , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.CodeAnalysis.Razor.Tooling.Internal
From Version 6.0.2-1.21602.2 -> To Version 6.0.2-1.21609.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/razor-compiler build 20211202.2
Microsoft.AspNetCore.Razor.Internal.Transport
From Version 6.0.1-servicing.21565.21 -> To Version 6.0.2-1.21602.2
* Use transport packages
This required updating the VS protocol assemblies to 17.1.2, as that was
where this method name was introduced (though it's been in the LSP spec
for a long time).
- Given the CI failure is impossible to reproduce locally / doesn't happen consistently this is a shot in the dark. My thought is that if we can ensure that the transient StreamJsonRpc package referenes always normalize down into one version in our .NET Framework projects via pinning that ideally we shouldn't have any issues. I only ever saw LiveShare and Remote.Razor projects have this issue via binlogs so I'm starting the StreamJsonRpc pinning here.
- Was able to remove the ExternalAccess.Razor dependency from Remote.Razor because it was brought in transitively.
Fixes#4327
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21518.12 -> To Version 6.0.1
Dependency coherency updates
Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging,System.Diagnostics.DiagnosticSource,System.Resources.Extensions,System.Text.Encodings.Web,Microsoft.Extensions.DependencyModel,Microsoft.NETCore.App.Ref,Microsoft.NETCore.BrowserDebugHost.Transport,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.Platforms
From Version 6.0.0-rtm.21518.4 -> To Version 6.0.0 (parent: Microsoft.CodeAnalysis.Razor
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21518.12 -> To Version 6.0.1
Dependency coherency updates
Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging,System.Diagnostics.DiagnosticSource,System.Resources.Extensions,System.Text.Encodings.Web,Microsoft.Extensions.DependencyModel,Microsoft.NETCore.App.Ref,Microsoft.NETCore.BrowserDebugHost.Transport,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.Platforms
From Version 6.0.0-rtm.21518.4 -> To Version 6.0.0 (parent: Microsoft.CodeAnalysis.Razor
Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging,System.Diagnostics.DiagnosticSource,System.Resources.Extensions,System.Text.Encodings.Web,Microsoft.Extensions.DependencyModel,Microsoft.NETCore.App.Ref,Microsoft.NETCore.BrowserDebugHost.Transport,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.Platforms
From Version 6.0.0-rtm.21518.4 -> To Version 6.0.0 (parent: Microsoft.CodeAnalysis.Razor
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21520.4 -> To Version 6.0.0
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21520.1 -> To Version 6.0.0-rtm.21520.4
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21519.22 -> To Version 6.0.0-rtm.21520.1
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21519.19 -> To Version 6.0.0-rtm.21519.22
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21519.13 -> To Version 6.0.0-rtm.21519.19
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21519.6 -> To Version 6.0.0-rtm.21519.13
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21519.3 -> To Version 6.0.0-rtm.21519.6
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21518.20 -> To Version 6.0.0-rtm.21519.3
Microsoft.CodeAnalysis.Razor , Microsoft.AspNetCore.Testing , Microsoft.AspNetCore.Razor.Language , Microsoft.AspNetCore.Razor.Internal.Transport , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X , Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X , Microsoft.AspNetCore.Mvc.Razor.Extensions
From Version 6.0.0-rtm.21518.12 -> To Version 6.0.0-rtm.21518.20
- Saw that automation was having a hard time auto-merging and noticed some stale / incorrect dependencies. Ran a few darc commands to fix things up.
- Razor no longer depends on Configuration.Json so could remove & needed to update the Extensiosn.Configuration package to have a coherent parent dependency to match.