[main] Update dependencies from dotnet/efcore dotnet/runtime
- Update templatestrings.json files
- Update template.json files
- Update other references to net7
- Rename publicApi folders
- Fix RepoTasks
- Fix it more fixily
- Really fix it for real this time
- Undo PreviewFeatures changes
- Using
- Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653
- Tasks
- IO
- CTS
- Net70
- Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653
- Try using net8.0 for HelixTestRunner
- Try making ReferenceAssemblies
- Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653
- Get analyzer tests working
- Ok fine
- Update doc
- Path combine
- Try somethin wacky
- Fix
- Using
- Merge remote-tracking branch 'upstream/main' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653
- Quarantine regressed WriteAsJsonAsync tests #45557
- Quarantine regressed async Json test #45557
- Re-order DataAnnotationsMetadataProviderTest expected results
- Quarantine regressed async Json test #45557
- Re-order DataAnnotationsMetadataProviderTest expected results
- Merge remote-tracking branch 'upstream/main' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653
- Bump E2E timeout to 2 hours
Per discussion in https://github.com/dotnet/aspnetcore/pull/44834#issuecomment-1334592371
- React to enum ordering change
- Merge remote-tracking branch 'upstream/darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653
- Skip a microbenchmark, update a version
- Make test resilient to order changes
- Unquar tests
- remove custom loader for .wasm file (#45611)
* Refresh BuildFromSource documentation for new contributors
* Fix summary formatting (#43711)
Fix the formatting of the interlude to render the link correctly and be a bit easier to read.
* Address feedback from review
Co-authored-by: Martin Costello <martin@martincostello.com>
* RunTests dotnet run --no-build
* Remove duplicate run
* Add to Build.props
* Treat CA2007 as a warning in RunTests
* NoWarn CA2007
* Ignore NU5104 for System.CommandLine prerelease package
* PR Feedback
* PR Feedback
* Generate .config/dotnet-tools.json
- add generation to GenerateFiles.csproj
- include all required versions in eng/Versions.props
- nit: bump tool versions slightly
- `dotnet-dump` move from `5.0.0-*` to `6.0.322601` is largest version bump
- have `git` ignore generated file
- nit: put `*.svclog` together w/ other extension exclusions
* Add tool packages to Helix correlation payloads
* Do not restore tools from network
- get tool packages from Helix correlation root
- to do this, save and restore NuGet.config file
- this removes `--version` from `dotnet-dump` and `dotnet-ef` installations
- will only have a single package for each tool in the correlation payload
* Do not pass `dotnet-ef` version to `RunTests`
- mostly cleanup; no longer needed
* Remove DotNetToolsInstaller.csproj
- mostly cleanup
- `dotnet-ef` tool now restored by Arcade's Tools.proj much earlier in our build because
most configured tool packages are needed in `RunTests` on Helix agents
* Add `--playwright` option in `Runtests`
- remove `INSTALLPLAYWRIGHT` define and `$env:INSTALLPLAYWRIGHT`
- always reference Microsoft.Playwright in `RunTests`
- nit: `InstallPlaywrightAsync()` wasn't `async`; fix it and rename to `InstallPlaywright()`
* Use Arcade SDK in `RunTests` and `Publish` project
- match most other projects in this repo
- remove empty Directory.Build.props and .targets files preventing Arcade imports
- exclude project build if `$(SkipTestBuild)` (though not a test project)
* Correct minor problems in `RunTests` source
* Use file-scoped namespaces in `RunTests` source
* Use VS code fixes in `RunTests`
* Use published `RunTests` output on Helix agents
* Move `RunTests` under eng/tools/
- don't need the project on Helix agents
- restore Directory.Build.* files removed when switching to Arcade
* Add `RunTests` to tools.slnf
* Rename `RunTests` project to `HelixTestRunner`
- less confusing given `RunTests` target and runtests.sh et cetera
* !fixup! Define `$(ArtifactsBinDir)` in helix.proj
* !fixup! Use `$(Configuration)` in helix.proj
* !fixup! Fix typo in property function
* !fixup! Fix `dotnet` syntax in runtests.sh
* !fixup! Correct `%(HelixCorrelationPayload.Destination)`
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
- Update InstallVisualStudio.ps1 to only support VS2022
- Add support for IntPreview (dogfood) channel, e.g. InstallVisualStudio.ps1 -Channel Dogfood
- Update the build from source docs to refer to VS2022
- Remove trailing whitespace in VS installer manifest files
- part of dotnet/aspnetcore-internal#3950
- also touches on #36032
- update Helix queues from Alpine 3.12 to 3.14, OSX 10.14 to 10.15, and (for Arm64) Debian 9 to 11
- use OSX 11.00 when testing PRs and rolling builds; reduce 10.15 usage to scheduled runs
- remove overlap (all 3 queues) between PRs / rolling builds and scheduled runs
- remove quarantined-pr / quarantined-tests overlap
- build source-index on `windows-latest` (not `vs2017-win2016`)
- update build and Helix Docker images to latest tags
- skip a test class on macOS 10.15
- #38542
nits:
- don't skip unused Helix queues
- remove versions from pipeline job display names
- some were already outdated; rest will be confusing in the future
- remove most comments about unused Helix queues
We've changed the way we do release planning this time around so I want to write it down to remember in the future and polish this process as we learn of new ways for doing so.
* feat (codespaces) - Add EditorConfig as pre-installed extension.
* feat (codespaces/vscode) - Add commonly performed tasks to tasks.json
* Addressed PR feedback.
1. Added C# XML documentation comments extension to suggested extension.
2. Added some more Omnisharp options to devcontainer based on our omnisharp.json file
3. Renamed tasks to Run all test projects.
* Removed extra space
* Formatted the Json file using inbuilt vs code formatter!
* indent issues
* Update build instruction
* Keep 8 tabs as previosuly!
* Update BuildFromSource.md
When following these steps, I noticed an error installing the JDK in the repo using the included script, so I had to follow these additional instructions to get past that.
Source for the instructions : https://stackoverflow.com/questions/4037939/powershell-says-execution-of-scripts-is-disabled-on-this-system
* Update BuildFromSource.md
Additional step to temporarily set environmental variable
* Update BuildFromSource.md
Wrong markdown
* Add troubleshooting suggestion
Add a note about deleting SDK and tools locally if restore.cmd fails.
* Move content to BuildErrors.md
Move the content to a catch-all "Miscellaneous other errors" section.
* Update docs/BuildErrors.md
Co-authored-by: Safia Abdalla <safia@safia.rocks>
- address a markdown accessibility issue
nits:
- accept most markdownlint fixes e.g. about using consistent list characters
- correct a few spelling errors
* Added instructions to the documentation for forking the main repo.
* Added a link to basic GitHub flow for forking repos.
* Fixed a broken section link.
* Added additional information and link for fetching upstream changes.
* Clean out Ubuntu 16.04 testing
- use Ubuntu 18.04 agents for testing in Docker containers on Helix
nits:
- clean up a few old mentions of Centos and Fedora testing
- fix `%(Platform)` metadata for OSX `@(HelixAvailableTargetQueue)` items
- don't mention unused internal queues in `$(TestDependsOnPlaywright)` update of `$(SkipHelixQueues)`
- sort remaining queues alphabetically in `$(SkipHelixQueues)`
* Added VSCode debugging support for MvcSandbox
* Added ignored vscode folders
* 1. Convered some more projects.
2. Added env variable for TargetFramework and used it in launch.json file rather than
hardcoding TFW.
* Addressed PR feedback.
1. Removed extensions.json
2. Updated BuildFromSource.md for Vscode instructions.
3. Added launch settings for BasicTestApp.
* Addressed PR feedback!
* Clean up verbiage on build scripts
* Update docs/BuildFromSource.md
Co-authored-by: Kevin Pilch <kevinpi@microsoft.com>
Co-authored-by: Kevin Pilch <kevinpi@microsoft.com>
* Remove top-level build scripts in favor of project specific scripts
* Add more build scripts and move top-level to eng
* Fix path in Powershell script
* Update BuildDirectory for CI jobs
* Fix paths in restore scripts and jobs
* Address feedback from peer review
* Fix references to Html.Abstractions
* Update baseline files with new project
* Fix a few more broken links
* !fixup! Correct Build.props and regen project references
* Update docs and fix public api modification check
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
* Fix API baseline files
Restore Shipped files to match release/5.0
Update Unshipped to reflect changed APIs
Add codecheck test for modified baseline files
Add documentation
- part of #29475
- primarily involves updating links to this repo
nit: Remove broken links to old Travis environments (that happen to mention 'master')
* Further centralize shared Fx and TFM transition workarounds
- make generated `Directory.Build.*` files more widely applicable
- warn if requested Microsoft.AspNetCore.App version does not exist in `$(DOTNET_ROOT)`
- add `$(UpdateAspNetCoreKnownFramework)` for Microsoft.AspNetCore.App `@(KnownFrameworkReference)` update
- remove central `$(BuildingTestAppsIndependently)` special case
- not needed because compiler toolset version is always available
- correct `$(KnownAppHostPackOrFrameworkReferenceTfm)` when not targeting the default TFM
- use MSBuild intrinsic functions for this and in framework projects; future-proofing
- correct `@(KnownFrameworkReference)` metadata when in servicing
- should not override default runtime and targeting pack versions
- use generated `Directory.Build.*` files in regular build
- remove now-duplicate property and item settings outside generated `Directory.Build.*` files
- use generated `Directory.Build.*` files for local Razor tests
- set `$(TargetLatestRuntimePatch)` instead of `$(RuntimeFrameworkVersion)`; simpler
- do not restore Razor SDK test asset projects until just before tests run
- depend on Microsoft.AspNetCore.App projects
- disable `$(TreatWarningsAsErrors)` for a few Razor SDK tests
- tests expect projects to build successfully despite a few warnings
- improve (widen) Microsoft.AspNetCore.App `Condition` in Blazor SDK tests
nit: do not pass `$(MicrosoftNetCompilersToolsetVersion)` into Razor test asset projects
- not needed because generated files already contain the right information
- even without that, the Directory.Build.props file imports eng/Versions.props
* Use generated `Directory.Build.*` files for local template tests
- move Infrastructure/ files to TestInfrastructure/
- Infrastructure/ sub-directories were functionally identical
- move shared parts of template test project files to PrepareForTest.targets
* Describe errors with missing generated files and the new warning in BuildFromSource.md
- address numerous Markdown lint warnings, typos, and spelling mistakes in this file
* Apply suggestions from code review
- thanks @captainsafia
* Move all troubleshooting information into BuildErrors.md
- some was already duplicated
- fix Markdown lint issues in BuildErrors.md too
* Reorder App.Runtime build slightly
- move `_InstallFrameworkIntoLocalDotNet` earlier because other builds depend on this part
- this target sometimes executes after dependent projects continue
- add `DependsOnTargets` attributes to further constrain ordering
nit: `IncludeFrameworkListFile` should run before `_ResolveSharedFrameworkContent`
* Add temporary workaround for `[AssemblyVersion]` changes
* Address @wtgodbe's nit from #27653
- https://github.com/dotnet/aspnetcore/pull/27653#pullrequestreview-529368502
Co-authored-by: Safia Abdalla <safia@microsoft.com>
* Shorten package version properties
- `$(...PackageVersion)` -> `$(...Version)`
- inspired by a similar dotnet/efcore change
- aligns names with Arcade SDK, meaning our values apply consistently
* Remove unused PublishSymbols.proj and related property
- restore Arcade's control of `$(MicrosoftSymbolUploaderBuildTaskVersion>)`
- would otherwise result in a version downgrade
* Update `$(MicrosoftNetCompilersToolsetVersion)` to match Arcade's value
- avoid using an older toolset
- now successfully overriding Arcade value
* Avoid an odd `CS8603` error
- delete the unused `GetOptionalProperty(...)` method
* Correct an unintentional change reading package metadata
- `%(ReferencePathWithRefAssemblies.NuGetPackageVersion)` is the correct name
build.cmd does not directly take MSBuild parameters (only after `-MSBuildArguments`)
But for configuration, there is already the `-Configuration` parameter.
Safia Abdalla
Sébastien Ros
Divyesh Bhandari
Sven Boemer
Daniel Roth
Dan Moseley
William Godbe
Anthony Tossell
Marsh Macy
Tanay Parikh
dotnet-maestro[bot]
Andrea Canciani
Eugene Ogongo
Artak
Surayya Huseyn Zada
Mackinnon Buck
Charles Emmanuel S. Ndiaye
Brennan
Daniel Genkin
Aditya Mandaleeka
Hao Kung
Hugo Woodiwiss
James Newton-King
Damian Edwards
Pavel Savara
Doug Bunting
Adrian Wright
Shreyas Jejurkar
Eries Trisnadi
Carl Sargunar
Martin Costello
LABADE Youval
Volodymyr S
Sweidan Omár
Sampath Dilhan
jacobslusser
Chris Ross
John Luo
Pranav K
TheCakeMonster
denvernaidoo
Ajay Bhargav B
M. Ali Iftikhar
Yuta-K19418
Mathias Lykkegaard Lorenzen
softworkz