70cbff64c5
Bump helix timeout for iis functionals ( #37942 )
2021-10-30 10:11:21 +00:00
e51f7d0daa
Quarantine HttpClientHttp2InteropTests.Echo ( #37944 )
2021-10-29 19:20:18 -07:00
83ea26b0ed
Use the RawConnectionId for HttpSys ( #37945 )
2021-10-29 23:04:15 +00:00
e9c0b93edf
Quarantine flaky tests ( #37933 )
2021-10-29 13:46:11 -07:00
718a1d9914
[Components] Unquarantine CanCacheRouteTable ( #37931 )
...
This test failed a single time and hasn't failed since.
There's nothing on the test that can induce flakiness and there's not enough data to try and reproduce the issue.
This was most likely caused by a "transient" bug on the runtime/clr that got fixed in subsequent releases, but its impossible to trace this down to the root.
2021-10-29 22:14:25 +02:00
0835032e86
Stop running Components E2E Tests in Quarantined Test Pipelines ( #37891 )
...
* Fixes https://github.com/dotnet/aspnetcore/issues/37443
* CI -> ContinuousIntegrationBuild
* Skip E2EMigration Tests in CI
* Exclude Migration Tests from Helix
2021-10-29 10:17:51 -07:00
e8200cbc3d
Add Server2022 to helix matrix & quarantine jobs ( #37745 )
...
* Add Server2022 to helix matrix & quarantine jobs
* Skip TLS1.1 test on 2022
* Off by 1
* Update src/Testing/src/xunit/WindowsVersions.cs
Co-authored-by: Chris Ross <chrross@microsoft.com>
* TLS test max versions
Co-authored-by: Chris Ross <chrross@microsoft.com>
2021-10-28 17:02:41 -07:00
5753b83563
Quarantine failing tests ( #37916 )
2021-10-28 23:52:18 +00:00
3af0e1f750
Unquarantine final E2E Tests ( #37897 )
...
Fixes: https://github.com/dotnet/aspnetcore/issues/34995
Extension of: https://github.com/dotnet/aspnetcore/pull/37890
2021-10-28 08:58:41 -07:00
deb6489649
Update LongPollingTransportTest.java ( #37894 )
2021-10-28 04:10:08 +00:00
4504ce5f8e
Remove quarantine attributes from Blazor e2e tests ( #37890 )
...
Removing quarantine attribute from tests in the aspnetcore-components-e2e pipeline with 100% success rates
over the lifetime of the pipeline.
This is primarily a cleanup activity as these tests are not run as part of the regular test pipeline and
unquarantining does not change the outcome of the build.
Fixes https://github.com/dotnet/aspnetcore/issues/23015
Fixes https://github.com/dotnet/aspnetcore/issues/31195
Fixes https://github.com/dotnet/aspnetcore/issues/34886
Fixes https://github.com/dotnet/aspnetcore/issues/34395
Fixes https://github.com/dotnet/aspnetcore/issues/33297
Fixes https://github.com/dotnet/aspnetcore/issues/33528
Fixes https://github.com/dotnet/aspnetcore/issues/32907
Fixes https://github.com/dotnet/aspnetcore/issues/34867
Fixes https://github.com/dotnet/aspnetcore/issues/33530
Fixes https://github.com/dotnet/aspnetcore/issues/33715
Fixes https://github.com/dotnet/aspnetcore/issues/34183
Fixes https://github.com/dotnet/aspnetcore/issues/33454
2021-10-28 00:45:13 +00:00
197a3d1881
Replace NoHotReloadListenersAreOrdinarilyRegistered with unit tests ( #37768 )
...
Fixes https://github.com/dotnet/aspnetcore/issues/35449
2021-10-27 16:34:50 -07:00
478c7bd9d4
Unquarantine tests ( #37877 )
2021-10-27 14:32:25 -07:00
e0803964b5
Missed lockfile freezing ( #37882 )
2021-10-27 21:28:53 +00:00
c27146719d
Quarantine StreamPool_Heartbeat_ExpiredStreamRemoved ( #37863 )
2021-10-27 18:31:16 +13:00
3d311cfc0a
Only dispose WindowsIdentity in LongPolling ( #37781 )
2021-10-26 20:45:43 -07:00
c9dda658d0
Strongly-typed SignalR hub proxies and callback handlers ( #33717 )
2021-10-26 16:47:51 -07:00
ecbf0fbc50
Ensure view caches are cleared when RazorHotReload.ClearCache is invoked ( #37854 ) ( #37856 )
2021-10-26 23:05:44 +00:00
f3b0c98117
34411 HTTP/2 and HTTP/3: Response trailers collection not reset ( #37627 )
2021-10-26 12:37:20 -07:00
7718950dfe
Use frozen lockfiles with Yarn ( #37834 )
2021-10-26 10:04:29 -07:00
09f37fea89
Add listener for QUIC logs to HTTP/3 sample ( #37837 )
2021-10-27 05:45:12 +13:00
41cf5722c4
[Helix] Switch to win11 for pr checks ( #37712 )
2021-10-25 22:03:23 -07:00
16f0df499c
Re-quarantine IHttpActivityFeatureIsPopulated ( #37830 )
2021-10-26 00:20:19 +00:00
926a11312a
Unquarantine ClientTimesoutWhenHandshakeResponseTakesTooLong ( #37820 )
2021-10-26 11:18:21 +13:00
327de1de24
Unquarantined IHttpActivity tests ( #37821 )
2021-10-26 11:15:43 +13:00
3c1b0677c0
Make tests for FileLoggerProcessor system time independent ( #37755 )
...
* Make FileLoggerProcessTests systemtime independent
* Added test case for rolling files based on date
* add summary & namespace
2021-10-25 16:50:28 +00:00
8802fec7c0
[main] (deps): Bump src/submodules/spa-templates ( #37807 )
...
Bumps [src/submodules/spa-templates](https://github.com/dotnet/spa-templates ) from `64a6ddc` to `a575301`.
- [Release notes](https://github.com/dotnet/spa-templates/releases )
- [Commits](64a6ddc501...a575301086
2021-10-25 09:16:35 -07:00
25a869a394
Unquarantine (most) HTTP3 tests ( #37756 )
2021-10-23 12:14:26 -07:00
d66da1f560
Quarantine `BlazorWasmHostedTemplate_AzureActiveDirectoryTemplate_Works` ( #37783 )
...
https://github.com/dotnet/aspnetcore/issues/37782
2021-10-23 11:20:28 -07:00
f2dc0bc734
Update ua-parser-js ( #37785 )
2021-10-22 20:00:18 -07:00
7997d57e7d
Reuse NegotiateMetadata ( #36184 )
2021-10-22 22:45:10 +00:00
03cae4e49c
Fix typo in Web API template option description ( #37780 )
2021-10-22 14:22:09 -07:00
adb591e362
Continue using HashCodeCombiner in Razor.Language ( #37725 )
...
* Continue using HashCodeCombiner in Razor.Language
References by Razor.Language end up getting loaded in VS and the source generator
* Use HashCodeCombiner.Start
2021-10-22 17:24:21 +00:00
66dc4ca26e
Enable retry for bind tests ( #37754 )
2021-10-22 09:11:20 -07:00
8700479997
Clean up remaining `net461` references ( #37731 )
...
- aspnet/AspNetCore-ManualTests#930
- main issue was JSON files for eng/scripts/InstallVisualStudio.ps1
- follow-up to 70c05f178a
2021-10-21 16:45:48 -07:00
439c211005
Fix Selenium Versions ( #37746 )
2021-10-21 14:57:17 -07:00
22237b3c89
Quarantine ConnectionClosedTokenFiresOnServerFIN ( #37752 )
...
Flaky test issue: https://github.com/dotnet/aspnetcore/issues/37750
2021-10-21 20:46:53 +00:00
2984e3bcd5
Fix AppHost pack prebuilt usage in source-build ( #37672 )
2021-10-21 15:35:36 -05:00
88c720f125
Fix test typos ( #37701 )
...
* Fix typo
paramter -> parameter
* Fix typo
Paramter -> NameParameterInfo
2021-10-20 23:44:38 -07:00
afda412c0f
Upgrade Selenium Versions ( #37726 )
...
* Update Selenium Versions
* Update Versions.props
2021-10-21 02:04:57 +00:00
96af635f22
Remove retries from BlazorWasm template tests & don't fail on restore errors ( #37715 )
...
* Remove retries from BlazorWasm template tests
* Don't error on restore failure for Blazor Template tests
2021-10-20 17:55:15 -07:00
1b07f2a1c4
Support setting ApiParameterRouetInfo for endpoints ( #37470 )
...
* Support setting ApiParameterRoutInfo for endpoints
* Address feedback from peer review
* Make constraints list read-only
* Address more feedback from peer review
2021-10-21 00:16:39 +00:00
c51d5b3130
Remove stale link for `RZ9992` Diagnostic ( #37716 )
...
* Remove stale link for `RZ9992` Diagnostic
* Update src/Razor/Microsoft.AspNetCore.Razor.Language/src/Components/ComponentDiagnosticFactory.cs
Co-authored-by: Pranav K <prkrishn@hotmail.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2021-10-20 20:05:45 +00:00
1aa3490043
Improve restore error reporting during dotnet new ( #37682 )
2021-10-19 21:13:05 -07:00
b06f3b7439
[main] (deps): Bump src/submodules/googletest ( #37640 )
...
Bumps [src/submodules/googletest](https://github.com/google/googletest ) from `075810f` to `16f637f`.
- [Release notes](https://github.com/google/googletest/releases )
- [Commits](075810f7a2...16f637fbf4
2021-10-20 00:26:13 +00:00
84e8313288
Reenable test ( #37594 )
2021-10-19 14:29:08 -07:00
4ff8165fb1
Enable targeting pack build during source-build ( #37652 )
2021-10-19 16:23:52 -05:00
4c194c5875
Avoid null args when RazorDiagnostic does not have a message ( #37648 )
...
* Avoid null args when RazorDiagnostic does not have a message
We've received tooling reports of the Razor compiler failing with a argument null exception
when trying to format a diagnostic message. Unfortunately dumps don't have enough details to indicate
what code path causes the badly formated argument to be used. Additonally, inspecting the code and turning
on nullability in this code path does not suggest any obvious candidates in Razor's codebase.
Tooling is working around this by try-catching the exception, but this results in squiggles / error items that do not
disappear. This PR introduces a temporary workaround that prints a generic error message so that it does not crash VS
/ require tooling workarounds while we try and figure out the root cause.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1405849
2021-10-19 12:47:36 -07:00
42a4a7330e
Unquarantine retry enabled test
2021-10-19 19:29:00 +00:00
ed26f13cee
[main] Update dependencies from dotnet/runtime dotnet/efcore ( #37552 )
...
Co-authored-by: Stephen Halter <halter73@gmail.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Hao Kung <HaoK@users.noreply.github.com>
2021-10-19 04:20:50 +00:00
c3df4fc426
Fix templates with Windows auth option ( #37607 )
...
Fixes #37556
2021-10-18 17:08:30 -07:00
5835efe71c
[AzureB2C] Fix missing sign in button ( #37601 )
2021-10-18 11:45:23 -07:00
537c171811
Specify the correct path for BlazorWASM project ( #37567 )
...
Fixes https://github.com/dotnet/aspnetcore/issues/36463
2021-10-18 10:20:07 -07:00
7cc5ad9331
Enable helix retry for a small set of tests ( #37137 )
2021-10-18 10:08:01 -07:00
21130fbc45
Fix virtualization horizontal scrolling ( #37585 )
2021-10-18 17:02:18 +01:00
e19d841d53
Added nullable overload for markupString ( #37265 )
2021-10-17 19:57:57 +00:00
70f5ea57c5
[Doc] Update readme files to the correct nodejs version ( #37605 )
...
Signed-off-by: Eries Trisnadi <lognus21@gmail.com>
2021-10-16 15:31:01 -07:00
207854d30d
Fix #37340 by guarding the initial ping for SignalR ( #37414 )
2021-10-15 20:26:09 -07:00
807e865dd1
HTTP/3: Fix failing client cert test ( #37578 )
2021-10-15 22:47:52 +00:00
393a86c0e7
Fix typo in documentation ( #37588 )
2021-10-15 08:16:47 -07:00
af08d5f75b
Set the aria-invalid attribute to "true" instead of true (v2) ( #37523 )
2021-10-15 13:25:45 +01:00
c78ad3f344
[Static web assets] Fixes an issue where patterns at the root were not being considered ( #37560 )
...
* [Static web assets] Fixes an issue where patterns at the root were not being considered
2021-10-15 01:45:52 -07:00
3749055910
Unquarantine tests ( #37572 )
2021-10-14 23:15:01 +00:00
fb72738c41
Replace HashCodeCombiner with HashCode ( #37558 )
2021-10-14 15:02:42 -07:00
0e5df998b5
HTTP headers enumerator move directly to next ( #37538 )
2021-10-14 20:50:44 +00:00
3239228949
Support generic value tuple parameters in components ( #34737 )
...
**PR Title**
Using generic value tuples as component parameters resulted in compilation failures which are now fixed.
**PR Description**
Value tuples need to be special cased when parsing type parameters.
Fixes https://github.com/dotnet/aspnetcore/issues/20838
2021-10-14 13:02:44 -07:00
b569ccf308
Only attempt to import blazor-hotreload.js is AspNetCore Browser tools middleware is present ( #37531 )
...
* Only attempt to import blazor-hotreload.js is AspNetCore Browser tools middleware is present
Contributes to https://github.com/dotnet/aspnetcore/issues/37357
2021-10-14 12:57:53 -07:00
e10b5cb2a2
Pass IJSVoidResult instead of object to Invoke to indicate void result ( #37532 )
...
* Pass IJSVoidResult to IJSInProcessObjectReference.Invoke from InvokeVoid
* Pass IJSVoidResult to IJSInProcessRuntime.Invoke from InvokeVoid
* Update src/Components/test/testassets/BasicTestApp/InteropComponent.razor
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
* Update src/JSInterop/Microsoft.JSInterop/test/JSInProcessObjectReferenceExtensionsTest.cs
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
* Update src/JSInterop/Microsoft.JSInterop/test/JSInProcessObjectReferenceExtensionsTest.cs
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
2021-10-14 12:51:12 -07:00
e341758a18
Bump url-parse from 1.5.1 to 1.5.3 in /src/SignalR/clients/ts/signalr ( #37313 )
...
Bumps [url-parse](https://github.com/unshiftio/url-parse ) from 1.5.1 to 1.5.3.
- [Release notes](https://github.com/unshiftio/url-parse/releases )
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.3 )
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-14 12:26:44 -07:00
b923cee18c
Remove FakeStartup classes ( #36988 )
...
Remove the FakeStartup classes from the functional tests and expose
the Program classes of the relevant applications using partial classes instead.
2021-10-14 10:50:13 -07:00
c8a3c224e7
Improve project reference consistency ( #37338 )
...
* Improve project reference consistency
- use `Private` and `SkipGetTargetFrameworkProperties` w/ `ReferenceOutputAssemblies="false"`
- correct meaningless `$(ReferenceOutputAssemblies)` settings; no such metadata
- `Private="false"` avoids unnecessary file copies
- `SkipGetTargetFrameworkProperties="true"` should reduce useless TFM negotiation
- that said, it can't be used everywhere due to multi-targeting restrictions
- do not use `PrivateAssets="All"` in `@(ProjectReference)` items or `@(Reference) items that become them
- has no meaning in `@(ProjectReference)` items
- add warnings about mixed-up application of `%(Private)` and `%(PrivateAssets)`
nit: make references _look_ consistent too e.g. use consistent attribute order and wrap lines
* Remove most `UndefineProperties` use
- should not be necessary
- but, keep using this metadata when referring to .npmproj projects
* !fixup! Fix build issues found on CI
- remove `SkipGetTargetFrameworkProperties="true"` from App.Ref reference to App.CodeFixes
- need TFM negotiation when App.Ref builds on at least some platforms
- firm up `net7.0` ➡️ `netstandard2.0` transition
- fix typo in Rpm.TargetingPack.rpmproj
- align Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj w/ Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj
- use same Microsoft.Web.Xdt.Extensions reference approach
nit: remove extra Microsoft.AspNetCore.App.Analyzers references; brought in by App.CodeFixes
2021-10-13 22:01:47 -07:00
b39d5c540a
Update node js version in container ( #37534 )
2021-10-14 01:00:27 +00:00
dc6bfe982c
Fix multiple dictionary add in polly ( #37533 )
2021-10-14 00:44:25 +00:00
952f6e1583
Wait for Redis to be ready in tests ( #37102 )
2021-10-14 00:40:39 +00:00
d02192f634
Accessibility fixes in templates ( #37479 )
...
* Color contrast changes. Fixes 1412465
* Add "lang" attribute to <html>. Fixes 1411915
* Instruct screen readers to read out server-side validation messages. Fixes 1411027
2021-10-13 19:18:00 +01:00
90c44f84f6
DefaultHealthCheckService uses CreateAsyncScope(). ( #37297 )
2021-10-13 11:16:09 -07:00
504c502b6b
Don't start the .NET webassembly app inside the auth iframe. Fixes #37355 ( #37515 )
2021-10-13 18:59:00 +01:00
8897997f3b
Fix IDE0059 suggestion ( #37430 )
...
Fix IDE0059 suggestion by using _ for the variable name.
2021-10-11 11:52:28 -07:00
fb253446b7
Support "-" in authority hosts ( #37429 )
2021-10-11 11:44:21 -07:00
974d6bcef3
HTTP/3: Abort connection on unexpected exception from AcceptStream ( #37432 )
2021-10-12 07:35:55 +13:00
28a14bf38b
HTTP/3: Fix tests failing because of new error code ( #37433 )
2021-10-12 07:34:10 +13:00
cdf12a688c
[main] (deps): Bump src/submodules/googletest ( #37444 )
...
Bumps [src/submodules/googletest](https://github.com/google/googletest ) from `3b49be0` to `075810f`.
- [Release notes](https://github.com/google/googletest/releases )
- [Commits](3b49be074d...075810f7a2
2021-10-11 11:33:38 -07:00
ac98d77385
[main] Update dependencies from dotnet/runtime dotnet/efcore ( #37353 )
...
[main] Update dependencies from dotnet/runtime dotnet/efcore
- Fixup nullability warnings
- Secret mission to make templates verbose again
- Update template tests to capture information (#37447 )
* Update template tests to capture information
* Remove unwanted files
* Update SPA submodule with nullability fixes
2021-10-11 17:28:14 +00:00
0199dcc4cd
Remove `SkipNonexistentProjects` settings ( #37372 )
...
- `SkipNonexistentTargets="false"` is the default and not worth mentioning
2021-10-08 15:52:41 -07:00
a06b39ebe5
Update SDK to 7.0.100-alpha.1.21480.20 ( #37192 )
...
* Update SDK to 7.0.100-alpha.1.21480.20
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2021-10-08 13:30:02 -07:00
a3565c498e
Honoring error information on OAuth Exchange Code ( #37224 )
2021-10-08 10:23:20 -07:00
a0b950fc51
Add WebApi-CSharp Template Toggle Description ( #37367 )
...
Partial fix for https://github.com/dotnet/aspnetcore/issues/37202
2021-10-07 23:52:14 +00:00
32898d26bb
Support struct IResults ( #37344 )
2021-10-06 22:17:04 -07:00
0fa7c01c94
Don't allow modifying WebRootPath after initialization ( #37147 ) ( #37325 )
...
* Don't allow modifying WebRootPath after initialization
* Address feedback from review
* Clean up directory handling in tests
* Add tests for WebRootPath resolution
2021-10-06 16:45:04 -07:00
b7d2f0ece0
Remove trace interfaces from Kestrel transports ( #37243 )
2021-10-06 20:11:14 +00:00
cec67a831f
Use WIX_NATIVE_MACHINE to detect native architecture of target machine ( #37318 )
...
* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property
2021-10-06 13:02:50 -07:00
6c5e668413
Remove IKestrelTrace ( #37242 )
2021-10-07 06:47:49 +13:00
7dffb0b386
Unquarantine BlazorWasmHostedTemplate_AzureActiveDirectoryTemplate_Works ( #37309 )
...
Fixes: https://github.com/dotnet/aspnetcore/issues/30851
2021-10-06 09:37:25 -07:00
a7d3a230a7
Use HMACSHA1.HashData() for Identity TOTP values ( #36724 )
2021-10-06 08:55:02 -07:00
a9450745e0
Merge pull request #36986 from slang25/fsharp6
...
Use F# task ce in worker template
2021-10-06 11:48:07 +01:00
1a4db562c4
Load IConfigurationProviders once in WebApplicationBuilder ( #37039 )
2021-10-05 23:45:54 +00:00
a547aa8f5a
Fix form key accumulator ( #37272 )
...
Fixes #36987
2021-10-05 15:37:18 -07:00
2168a8b8a3
Fixed typo in StackTraceHelper.cs ( #37280 )
2021-10-05 08:46:46 -07:00
9bb2afb8ee
Honor FromRoute parameter name when specified ( #37271 )
2021-10-05 08:38:36 -07:00
042217378e
Apply Linter & Update Yarn for `src/Components/Web.JS` ( #37203 )
...
* Apply Linter `src/Components/Web.JS`
* Upgrade Yarn Packages for Web.JS
* https://eslint.org/docs/rules/no-case-declarations
* Additional Fixes
2021-10-05 07:11:05 -07:00
fa946a82e9
Support EndpointGroupName metadata in MVC ApiExplorer ( #37264 )
...
* Support EndpointGroupName metadata in MVC ApiExplorer
* Address feedback from peer review
* Update src/Mvc/Mvc.ApiExplorer/src/DefaultApiDescriptionProvider.cs
Co-authored-by: Pranav K <prkrishn@hotmail.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2021-10-05 04:59:01 +00:00
0cff8a75a3
Set aria-current for manage nav ( #37110 )
2021-10-04 21:26:14 -07:00
d13f339b4f
Update Selenium dependencies ( #37183 )
...
* Update Selenium dependencies
* Update selenium-config.json
* Update selenium-config.json
2021-10-04 20:35:58 -07:00
9c81ee0fcc
Use Authorization header in WebSockets on Node ( #37205 )
2021-10-04 14:05:24 -07:00
5d185c4d83
Fix ambiguous BindAsync error ( #37142 )
2021-10-04 12:46:35 -07:00
047dde71e5
[main] (deps): Bump src/submodules/spa-templates ( #37251 )
...
Bumps [src/submodules/spa-templates](https://github.com/dotnet/spa-templates ) from `55da9ce` to `9251ef4`.
- [Release notes](https://github.com/dotnet/spa-templates/releases )
- [Commits](55da9ce020...9251ef405b
2021-10-04 11:10:29 -07:00
1227942bfc
[main] (deps): Bump src/submodules/googletest ( #37252 )
...
Bumps [src/submodules/googletest](https://github.com/google/googletest ) from `e4717df` to `3b49be0`.
- [Release notes](https://github.com/google/googletest/releases )
- [Commits](e4717df71a...3b49be074d
2021-10-04 11:09:33 -07:00
95806da9b5
Normalize the content root and improve errors ( #36990 ) ( #37226 )
...
* Normalize the content root and improve errors
- When trying to compare content root paths, make sure the paths are normalized before doing so. Today we throw too aggresively when libraries try to set the content root, even if that would have resulted in a noop. This change normalizes the initial path and the attempted path before doing the comparison.
- We also improve the error message when the user tries to change the host settings, directing them to the correct API to use instead.
2021-10-04 09:18:24 -07:00
284e122773
Update selenium-standalone ( #37184 )
2021-10-04 09:15:49 -07:00
fb05933145
Fix virtualization handling of large dataset length changes. Fixes #37245 ( #37247 )
2021-10-04 16:57:14 +01:00
97030589b6
Un-skip SetSecrets ( #37101 )
2021-10-04 07:56:20 -07:00
cb7a4ed8e8
Release JS Blob after BrowserFileStream is disposed. Fixes #35540 ( #37004 )
2021-10-04 11:52:47 +01:00
711bdcf96a
[main] Update dependencies from dotnet/runtime dotnet/efcore ( #37178 )
...
[main] Update dependencies from dotnet/runtime dotnet/efcore
- React to Vector128 conflicts
2021-10-01 19:37:10 +00:00
63f2fa056f
Razor Support `;` after `@typeparam` ( #37148 )
...
* Razor Support `;` after `@typeparam`
* Update ComponentDiscoveryIntegrationTest.cs
2021-10-01 09:29:46 -07:00
6d334ff395
Exclude additional types from being validated ( #37150 )
...
Prevent 'System.Delegate' and some reflection types from being validated.
Fixes https://github.com/dotnet/aspnetcore/issues/36919
2021-10-01 09:25:31 -07:00
21b7f2154a
Use existing principal for single scheme ( #37135 )
2021-09-30 11:32:28 -07:00
3d7a624cc7
Quarantine tests ( #37082 )
...
- #37080 and #37081
2021-09-29 15:18:47 -07:00
7db7c0c0d5
Harden another shadow copy test ( #37083 )
2021-09-29 09:19:09 -07:00
1ac4ccbd56
Fix error in startup test ( #37076 )
2021-09-29 09:17:47 -07:00
fc0a4087e8
Try out BuildProjectReferences=false in Components ( #37017 )
2021-09-29 07:55:24 -07:00
f2a8e7a893
Fix event name of RequestLog. ( #37043 )
2021-09-28 10:23:36 -07:00
3f682d4e05
Harden test to accept either shutdown message ( #37057 )
2021-09-28 09:44:27 -07:00
a96b058092
Quarantine WriteAfterConnectionCloseNoops on Libuv ( #36933 )
2021-09-28 09:08:12 -07:00
3456cb1ad2
Fix UI issues for org auth login nav ( #37056 )
2021-09-28 09:03:47 -07:00
59baa0d6f9
Bump tmpl from 1.0.4 to 1.0.5 in /src/Components/Web.JS ( #36766 )
...
* Bump tmpl from 1.0.4 to 1.0.5 in /src/Components/Web.JS
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl ) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases )
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5 )
---
updated-dependencies:
- dependency-name: tmpl
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* Apply suggestions from code review
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
2021-09-28 05:18:45 +00:00
9e80cb5a71
Fix http logging log typo ( #36871 )
2021-09-28 01:10:05 +00:00
60b48938c6
Revert consolidating DefaultViewCompilerProvider + DefaultViewCompiler ( #37035 )
...
As part of https://github.com/dotnet/aspnetcore/pull/35017 , I had consolidated the DefaultViewCompiler and DefaultViewCompilerProvider
types, largely as a clean up. The type DefaultViewCompilerProvider is looked up by the RuntimeCompilation package by name, and when making
this change, this code was also updated.
However, we've had two reports so far of users trying to use an 5.0 or earlier version of the runtime compilation package with a 6.0 app. In this case, the lookup
fails and the runtime compilation feature doesn't work as expected after this.
Fixes https://github.com/dotnet/aspnetcore/issues/35267
2021-09-27 23:57:31 +00:00
b122066032
Fix uncompressed scenarios with DisableBuffering #36960 ( #37022 )
2021-09-27 23:27:02 +00:00
bc0611939b
Bump ansi-regex from 5.0.0 to 5.0.1 in /src/Components/Web.JS ( #36863 )
...
* Bump ansi-regex from 5.0.0 to 5.0.1 in /src/Components/Web.JS
Bumps [ansi-regex](https://github.com/chalk/ansi-regex ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases )
- [Commits](https://github.com/chalk/ansi-regex/compare/v5.0.0...v5.0.1 )
---
updated-dependencies:
- dependency-name: ansi-regex
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* Apply suggestions from code review
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
2021-09-27 22:49:16 +00:00
69a594e3b4
Update http3 RequiresPreviewFeatures attrs with message/url. ( #36491 )
2021-09-27 15:08:48 -07:00
ecdf87dca9
sealed internal classes in default builder ( #36043 )
2021-09-27 13:46:18 -07:00
216c92b78b
[main] (deps): Bump src/submodules/googletest ( #37005 )
...
Bumps [src/submodules/googletest](https://github.com/google/googletest ) from `40dfd4b` to `e4717df`.
- [Release notes](https://github.com/google/googletest/releases )
- [Commits](40dfd4b775...e4717df71a
2021-09-27 10:07:32 -07:00
63a3be55f2
Make title prerendering not interfere with svg titles. Fixes #36380 . ( #37009 )
2021-09-27 17:40:16 +01:00
fc21f6ae1d
fix - Authority URL fix for blazor webassesmbly project ( #36460 )
2021-09-27 16:05:54 +00:00
6a172e3080
Use TryParse and BindAsync methods from interfaces ( #36955 )
2021-09-26 20:20:33 -07:00
7337369baa
Add MapPatch API to endpointRouteBuilderExtensions ( #36818 )
...
* add map-patch for requestDelegate/Delegate
* add mapPatch to unshipped.txt
add unit tests
* add comments
2021-09-26 19:52:23 -07:00
ff2f947ede
Use F# task ce in worker template
2021-09-26 17:19:02 +01:00
1c38d7ff02
Fix constant name typos ( #36984 )
...
Fix typos in constant names.
Also removes an unused local from a test.
2021-09-26 07:32:40 -07:00
2bf9db0c8e
Backport Fix Missing `RZ10012` diagnostic for components written in certain cultures ( #36949 )
...
* Fix Missing `RZ10012` diagnostic for components written in certain cultures (#36907 )
* Update test to account for localized component names
* Support Titlecase/OtherLetter
* Update ComponentChildContentIntegrationTest.cs
* Add SupportLocalizedComponentNames Configurable Property
* PR Feedback
* Test supportLocalizedComponentNames configuration
* PR Feedback
* Update PublicAPI.Unshipped.txt
* RC2 Tooling Support for Support Localized Component Names (#36936 )
* Update src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorIntermediateNodeLoweringPhase.cs
* Update src/Razor/Microsoft.AspNetCore.Razor.Language/src/RazorCodeGenerationOptionsBuilder.cs
2021-09-24 16:21:13 -07:00
fefe2769a2
Improve Results.Problem and Results.ValidationProblem APIs ( #36856 ) ( #36930 )
2021-09-24 13:27:41 -07:00
3589956216
Scope ActivityListener in test to not interfere with other tests ( #36908 )
2021-09-24 12:33:30 -07:00
b507fc27d9
Support more nonbubbling media events ( #36925 )
...
* Support more nonbubbling media events
* Update .js files
2021-09-24 17:02:06 +00:00
a5fbce06cf
[SPA] Update spa submodule to pick up fix for Manual-Tests/919 ( #36893 )
2021-09-24 04:16:32 -07:00
3f553258ef
Prevent creating list for single endpoint ( #36852 )
2021-09-23 21:32:34 +00:00
fa613b1d9f
Quarantine two tests ( #36889 )
2021-09-23 14:02:47 -07:00
bc171b9012
Fix returns documentation on GetRouteData() ( #36881 )
2021-09-23 13:20:02 -07:00
7b09459afb
Bump tmpl from 1.0.4 to 1.0.5 in /src/SignalR/clients/ts/common ( #36784 )
...
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl ) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases )
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5 )
---
updated-dependencies:
- dependency-name: tmpl
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-23 12:13:10 -07:00
87894e2590
Add the ConfigurationManager to the IServiceCollection ( #36832 ) ( #36864 )
...
- Add an IConfiguration to the service collection for scenarios where uses end up prematurely building the service provider or sniffing the IServiceCollection for it. We then remove the ConfigurationManager reference it from the final IServiceCollection to avoid cycles in the configuration graph that result in stack overflows (we link the configuration manager to the final configuration that has been built).
- Added tests
2021-09-23 10:10:31 -07:00
ac0a3873cf
Include SharedFx bundle in Hosting Bundle, instead of SharedFx .msi ( #36858 )
...
* Chain SharedFx Bundle into Hosting Bundle instead of .msi
* Fixup
* Move stuff around
* Try something
* Try something else
* AfterTargets
* Fix version
* Fixup
* Feedback
2021-09-23 09:56:32 -07:00
c17f75d34a
Blazor Server Add Console Warning if Long Polling ( #36764 )
...
* Blazor Server Add Console Error if Long Polling
* E2E Testing
* Fix tests
* Update Boot.Server.ts
2021-09-23 08:54:46 -07:00
24dacc2535
Remove System.Security.Permissions closure ( #36828 )
...
* [main] React to dotnet/runtime#57816 (#36155 )
- `cherry-pick` e58a6c2465https://github.com/dotnet/runtime/pull/57816#issuecomment-912755824
- also reacting to dotnet/runtime#58731
- undo much of 18a61fb96c#36248 )
- `cherry-pick` 888e03a418
2021-09-23 00:37:03 +00:00
e639f4e716
`<TargetFrameworks />` -> `<TargetFramework />` ( #36727 )
...
* `<TargetFrameworks />` -> `<TargetFramework />`
- avoid useless transitions to inner builds
* Remove most `$(BenchmarksTargetFramework)` use
Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
2021-09-22 16:06:54 -07:00
e927ab96a6
Update ModelMetadata.cs ( #36853 )
...
Corrected spelling error
2021-09-22 16:00:11 -07:00
076605d908
[main] Use Swagger defaults in web API controllers template ( #36826 )
...
* Use Swagger defaults in web API controllers template
* Add comment pointing at aspnetcore swagger docs to web api template
Co-authored-by: DamianEdwards <damian@damianedwards.com>
2021-09-22 10:54:40 -07:00
f4ee794adf
[release/6.0-rc2] Parse date types into UTC by default ( #36762 ) ( #36844 )
...
* Parse date types into UTC by default
* Clean up unit tests
* Update DateTimeStyles and tests
* Clean up test cases some more
* Fix up datetime tests for CI
* Fix up processing for DateTimeOffset
* Do not adjust DateTimeOffset to UTC
2021-09-22 17:54:15 +00:00
2b0e81f2ff
Blazor Stop Requiring `unsafe-inline` in CSP ( #36771 )
...
* Blazor Server Allow Unsafe Inline
For: https://github.com/dotnet/aspnetcore/issues/34428
* Update MonoPlatform.ts
* Fix DefaultReconnectDisplay.test
* PR Feedback
2021-09-21 17:40:58 +00:00
2b8b2dcf67
Upgrade Karma/Sauce-related packages to fix #36780 ( #36802 )
2021-09-21 17:28:05 +01:00
895a53e19b
Rename and consolidate "DelegateEndpoint" types ( #36768 )
2021-09-20 21:54:20 -07:00
70c05f178a
[main] Update dependencies from dotnet/runtime dotnet/efcore ( #36328 )
...
[main] Update dependencies from dotnet/runtime dotnet/efcore
- Update TFM to net7.0
- Fixup
- Update src/Shared/CodeAnalysis/DynamicallyAccessedMembersAttribute.cs
Co-authored-by: Chris Ross <chrross@microsoft.com>
- Update src/Shared/CodeAnalysis/DynamicallyAccessedMemberTypes.cs
Co-authored-by: Chris Ross <chrross@microsoft.com>
- Update netfx to 462
- Update more to net462
- Fix workaround
- Update ifdefs
- Add workaround for KnownRuntimePack
- Merge branch 'darc-main-c944b2c3-1c63-49a3-b9dd-98cda1a942e3' of https://github.com/dotnet/aspnetcore into darc-main-c944b2c3-1c63-49a3-b9dd-98cda1a942e3
- Merge branch 'main' into darc-main-c944b2c3-1c63-49a3-b9dd-98cda1a942e3
- Add SiteExtensions versions
- Fix RepoTasks assembly dir
- Update CreateFrameworkListFile to account for new analyzer path format introduced with https://github.com/dotnet/sdk/issues/20355
- Don't target latest runtime in razor tests
- Update Dependencies.props
- Update Helix.targets
- Fixup
- Move FrameworkReference update to GenerateFiles
- Have Helix tests import directory.build files
- Keep RunTests at net6
- Quarantine 2 tests
- revert spa-templates submodule downgrade
2021-09-21 02:28:35 +00:00
da06d1b507
Call AddEndpointsApiExplorer() in controllers Web API template ( #36752 )
2021-09-20 22:41:45 +00:00
574d3e390d
Use GetEndpoint extension method ( #35886 )
2021-09-20 22:15:02 +00:00
7f5529a3ef
Clear layout directories before copies ( #36719 )
...
- `<Copy />` task (well, most tasks though not `tar` commands) will create directories
- avoid leftover files from a previous build
- avoid confusing SDK with an empty targeting pack directory
- prevented ASP.NET targeting pack download when not building it (see #36718 )
2021-09-20 14:44:58 -07:00
9e489c6cea
Fix https://github.com/aspnet/AspNetCore-ManualTests/issues/828#issuecomment-916732011 ( #36467 )
...
Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
2021-09-20 19:02:24 +00:00
975769f8e9
onBoard package validation ( #35846 )
...
* setting properties for package validation
* add suppressions file
* add condition for not running package validation when excludeFromSourceBUild is set
2021-09-20 10:16:11 -07:00
37145c52f3
[main] (deps): Bump src/submodules/googletest ( #36743 )
...
Bumps [src/submodules/googletest](https://github.com/google/googletest ) from `955c7f8` to `40dfd4b`.
- [Release notes](https://github.com/google/googletest/releases )
- [Commits](955c7f837e...40dfd4b775
2021-09-20 09:35:57 -07:00
f2c7b53b32
Find inherited TryParse and BindAsync ( #36688 )
2021-09-20 09:00:59 -07:00
db4dc17779
Use SslApplicationProtocol.Http3 ( #36702 )
...
* Use SslApplicationProtocol.Http3
Use the new SslApplicationProtocol.Http3 field where relevant.
Addresses #36668 .
* Assert ConfirmEmailAsync() is successful
Assert that the email is confirmed successfully before continuing the test.
2021-09-18 22:47:14 +00:00
2347f90c73
Merge pull request #36683 from dotnet/halter73/open-di
2021-09-18 12:07:05 +02:00
493b4a2570
Pin analyzers that ship in the SDK ( #36690 )
...
* Pin analyzers that ship in the SDK
ASP.NET Core produces a few analyzer assemblies that are shipped as part of the .NET SDK. These analyzers are added to web projects targeting 3.1 and newer.
In 6.0, we (unintentionally) bumped the version of Microsoft.CodeAnalysis that these projects referenced to a 4.0 version. This causes warnings when opening
a 3.1 or 5.0 app in VS 2019 as it does not support these versions.
Additionally update the version of Microsoft.CodeAnalysis.* packages used in tests, Razor, and framework analyzers that are only expected to run with VS 2020 to a more recent build. This is largely book-keeping, but allows us
to write a test for file scoped namespaces.
Fixes https://github.com/dotnet/aspnetcore/issues/36552
2021-09-18 03:49:03 +00:00
f72785fbf7
Fix and test HttpSys delegation ( #36677 )
2021-09-18 02:53:40 +00:00
aebbd5c0b0
Update BlazorServerApp Sample Project ( #36684 )
...
Updated `Blazor.start` to match documented structure:
https://docs.microsoft.com/en-us/aspnet/core/blazor/fundamentals/startup?view=aspnetcore-6.0#chain-to-the-promise-that-results-from-a-manual-start
2021-09-18 00:37:36 +00:00
60721d45c1
Add test for BoundAttributDescriptor HashCode ( #36679 )
2021-09-17 16:25:16 -07:00
c4f330d24e
Improve documentation ( #36496 )
2021-09-17 23:17:27 +00:00
8392779338
Simplify Guid reading/writing code in DataProtection ( #36403 )
...
Simplify Guid reading/writing code in DataProtection.
2021-09-17 16:16:35 -07:00
bb0cde1935
Throw for invalid TryParse and BindAsync ( #36628 )
2021-09-17 15:41:25 -07:00
87d8180b24
open DI in F# webapi project template
2021-09-17 14:49:52 -07:00
f57c9e9429
[main] Revert Enforce WebSockets Transport for Blazor ( #36674 )
...
* Revert Enforce WebSockets Transport for Blazor
* Updated Release JS Files
Co-authored-by: Tanay Parikh <taparik@microsoft.com>
2021-09-17 20:58:56 +00:00
ba0242544a
Use minimal APIs for F# project templates ( #35833 )
2021-09-17 11:13:01 -07:00
a94189e39a
Handle JsonExceptions in RequestDelegateFactory ( #36589 )
2021-09-17 09:48:25 -07:00
d0465d864e
Use a fake clock in the test ( #36625 )
2021-09-16 21:46:21 +00:00
a18ae25f9f
Avoid using invalid content type for ValidationProblemDetails ( #36617 )
2021-09-16 20:58:25 +00:00
068797e16a
Merge pull request #36100 from ericstj/x64onARM64
...
Retarget DOTNETHOME when installing x64 on ARM64
2021-09-16 09:14:13 -07:00
f6efa13e71
Add support for BindAsync without ParameterInfo ( #36505 )
2021-09-15 20:31:10 -07:00
2e1573d367
Fixup OpenAPI displayed param type when using TryParse ( #36526 )
2021-09-15 18:02:02 -07:00
779db7f3e6
Dougbu/check.solution.filters ( #36449 )
...
* Check solution filters
- confirm all mentioned projects are in AspNetCore.sln
- clean up CodeCheck.ps1
- avoid aliases
- rework long lines
- avoid deprecated `dotnet run -p`
- improve output a bit
- correct whitespace
- there can be only one
- we have just one solution file
- solution file should mention projects _once_
* Add missing projects to AspNetCore.sln
- Middleware.slnf contained projects that no longer exist eg. NodeServices
- VS also sorted the file and VS 2019 added ARM64 configurations
- a few other solution filters still referenced removed and moved projects
- correct capitalization in some solution filters
Note: Unable to load some WiX projects in VS 2019 or _any_ in VS 2022 (WiX extension unavailable for 2022)
* Remove trailing comma in a solution filter
2021-09-15 17:03:48 -07:00
f1b907b4f0
Make DelegateEndpointConventionBuilder constructors public ( #36492 ) ( #36549 )
...
* Make DelegateEndpointConventionBuilder constructors public (#36492 )
* Make DelegateEndpointConventionBuilder constructors public
* Address API review feedback
* Only expose a single constructor
* Update src/Http/Routing/src/Builder/DelegateEndpointConventionBuilder.cs
Co-authored-by: Pranav K <prkrishn@hotmail.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2021-09-15 23:16:04 +00:00
3f93126eab
Revert setting endpoint name automatically ( #36518 ) ( #36548 )
2021-09-15 14:14:25 -07:00
3ae47296bf
Avoid building the configuration sources twice ( #36570 )
...
- When making the internal host builder, we copy the sources from the ConfigurationManager to the internal IConfigurationBuilder and the HostBuilder creates. This results in building configuration twice which can be problematic for performance reasons. Instead, we copy over the already built configuration providers in a custom IConfigurationSource implementation. This change does means the looking at the list of sources will not match the original list of sources though.
- Added a test
2021-09-15 14:09:45 -07:00
28a9fc21d5
Check for duplicate endpoint names on startup ( #36353 )
...
* Check for duplicate endpoint names on startup
* Add display name to exception message
* Always validate duplicate endpoints and add more info to error
2021-09-15 09:36:53 -07:00
5b7b97aecf
Avoid using TargetFramework in build targets ( #36512 )
...
Fixes https://github.com/dotnet/aspnetcore/issues/36510
2021-09-15 08:59:36 -07:00
e7bf642849
Expose ParameterInfo for Minimal Actions API Explorer ( #36439 )
...
* Expose ParameterInfo for Minimal Actions API Explorer
Populate the ParameterDescriptor for Minimal Actions parameters with
a type that implements IParameterInfoParameterDescriptor so that any
custom attributes on the parameter can be inspected.
Relates to #36438 .
* Remove file-scoped namespace
Addresses review feedback.
2021-09-15 08:52:25 -07:00
b705a55d0a
Don't ignore XML doc warnings for Polly ( #36485 )
2021-09-15 02:46:00 +00:00
240aed93a9
Quarantine failing test ( #36473 )
...
* Quarantine failing test
* Update src/Hosting/Hosting/test/HostingApplicationTests.cs
Co-authored-by: Chris Ross <chrross@microsoft.com>
Co-authored-by: Chris Ross <chrross@microsoft.com>
2021-09-14 19:26:40 -07:00
de27715451
Clarify InvokeHandlersAfterFailure ( #36501 )
2021-09-14 20:48:16 +00:00
9aff054563
[main] (deps): Bump src/submodules/spa-templates ( #36459 )
...
Bumps [src/submodules/spa-templates](https://github.com/dotnet/spa-templates ) from `796e436` to `a64c11d`.
- [Release notes](https://github.com/dotnet/spa-templates/releases )
- [Commits](796e436397...a64c11d491
2021-09-14 20:36:11 +00:00
d8a4abae19
Improve error message ( #36442 )
2021-09-14 19:03:55 +00:00
b156057319
Cherry-pick mismatched parameter optionality analyzer and clean up directories ( #36379 )
...
* Add analyzer for detecting mismatched endpoint parameter optionality (#36154 )
* Add analyzer for detecting mismatched endpoint parameter optionality
* Address feedback from code review
* Factor out CodeFixes and Analyzers to separate assemblies
* Address more feedback from review
* Address code checks
* Clean up folder structure
* Update solution file and address feedback
* Update src/Framework/Framework.slnf
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
* Add test project to solution file
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
2021-09-14 11:39:48 -07:00
ed864ce156
Fix Blazor Server Reconnection Mechanism ( #36126 )
...
* Fix Blazor Server Reconnection Mechanism
* Fix documentation
* Update yarn.lock
* Update release.js
2021-09-14 17:12:07 +00:00
4736d1c495
Honor sliding expiration in the security stamp validator ( #36394 )
2021-09-14 16:48:43 +00:00
a05221594f
Use HttpMethods.IsGet ( #36441 )
2021-09-14 04:25:44 +00:00
Hao Kung
Brennan
Chris Ross
Javier Calvarro Nelson
Tanay Parikh
William Godbe
Pranav K
James Newton-King
Mehmet Akbulut
ladeak
Benedikt
dependabot[bot]
Sébastien Ros
Kahbazi
Damian Edwards
Doug Bunting
Davis Goodin
Martin Costello
Safia Abdalla
dotnet-maestro[bot]
Steve Sanderson
bhupinderr8
Eries Trisnadi
TimTIM
Justin Baur
campersau
Egil Hansen
smichtch
Juan Barahona
Eric StJohn
Don Syme
Stephen Halter
Sviataslau Hankovich
David Fowler
Aditya Mandaleeka
Weihan Li
Shreyas Jejurkar
Noam Yogev
Stuart Lang
Elan Hasson
github-actions[bot]
Anirudh Agnihotry
Vlad Zarytovskii
Ryan Brandenburg
Jonathan