- When making the internal host builder, we copy the sources from the ConfigurationManager to the internal IConfigurationBuilder and the HostBuilder creates. This results in building configuration twice which can be problematic for performance reasons. Instead, we copy over the already built configuration providers in a custom IConfigurationSource implementation. This change does means the looking at the list of sources will not match the original list of sources though.
- Added a test
* Check for duplicate endpoint names on startup
* Add display name to exception message
* Always validate duplicate endpoints and add more info to error
* Expose ParameterInfo for Minimal Actions API Explorer
Populate the ParameterDescriptor for Minimal Actions parameters with
a type that implements IParameterInfoParameterDescriptor so that any
custom attributes on the parameter can be inspected.
Relates to #36438.
* Remove file-scoped namespace
Addresses review feedback.
* Quarantine failing test
* Update src/Hosting/Hosting/test/HostingApplicationTests.cs
Co-authored-by: Chris Ross <chrross@microsoft.com>
Co-authored-by: Chris Ross <chrross@microsoft.com>
* Use one-shot static hash methods
Use one-shot static hash methods for SHA1 and HMACSHA*.
Also a readability change to use Convert.ToHexString().
* Assert on appsecret_proof
Assert that the correct secret proof is added to the request URL.
* Update URL
Update URL that redirects.
* Fix invalid documentation link
Update link that resulted in a 404.
* Expand TwitterHandler coverage
Add test coverage for CreateTicketAsync(), ObtainAccessTokenAsync() and RetrieveUserDetailsAsync().
* wip
* fixups
* format
* fb
* try out fb and new option
* Other DI containers shouldn't regress
* fb
* init
* name
* Address feedback from API review
* Address feedback from peer review
* Disambiguate between Todo as service or body
Co-authored-by: Safia Abdalla <safia@microsoft.com>
* Handle shortened JSON file in `dotnet openapi`
- #35767
- an existing JSON file must be truncated
* !fixup! Address nits in changed file
- take VS suggestions
* Stop skipping `dotnet openapi` tests
- .NET SDKs and Visual Studio's `msbuild` avoid #32686 already
* !fixup! Address nits in `dotnet openapi` test files
- take VS suggestions
* Extend `dotnet openapi refresh` tests
- include regression test for #35767
* Fixed duplicate metadata in ModelDataSource
- Today when we make endpoints for the ModelDataSource, we apply the callbacks to the EndpointBuilder before creating the endpoint. This happens every time anyone accesses the endpoints property. Instead of re-applying the conventions, we do it once on Build. We also throw if more conventions are added after building.
- Added tests
* Add troubleshooting suggestion
Add a note about deleting SDK and tools locally if restore.cmd fails.
* Move content to BuildErrors.md
Move the content to a catch-all "Miscellaneous other errors" section.
* Update docs/BuildErrors.md
Co-authored-by: Safia Abdalla <safia@safia.rocks>
* Move OpenAPI extensions to routing assembly
* Address feedback from code and API review
* Clean up ReadResponseMetadata implementation
* Update IProducesResponseTypeMetadata to expose ContentTypes
* Address more feedback from review
* Update ContentTypes to IEnumerable
* Make IEnumerable non-nullable
* One more feedback
* Address feedback from review
* Do not use crossgen2 when targeting s390x (where it is not supported)
* Only reference "Microsoft.NETCore.App.Runtime.$(RuntimeIdentifier)"
and "Microsoft.NETCore.App.Crossgen2.$(BuildOsName)-$(Crossgen2BuildArchitecture)"
when actually using crossgen2.
Safia Abdalla
David Fowler
William Godbe
Pranav K
Martin Costello
Brennan
Hao Kung
dependabot[bot]
Tanay Parikh
Chris Ross
Kahbazi
Aditya Mandaleeka
Doug Bunting
Alexander Köplinger
Ikko Ashimine
dotnet-maestro[bot]
Javier Calvarro Nelson
Eilon Lipton
Ulrich Weigand