Граф коммитов

21 Коммитов

Автор SHA1 Сообщение Дата
Pranav K e3230e5372
Re-enable CA1305 (#35867)
* Re-enable CA1305
Fixes https://github.com/dotnet/aspnetcore/issues/34361
2021-08-28 06:50:54 -07:00
Kevin Pilch d71ceb649c Update license from Apache -> MIT
Fixes #18873.
2021-07-22 15:36:47 -07:00
Damian Edwards 25767dee39
Update templates to use file scoped namespace declarations (#34220)
* Update templates to use file-scoped namespace declarations
* Move to SDK version that supports file-scoped namespaces
* Make CA1305 a suggestion rather than error
  - New compiler now makes this appear when using a StringBuilder with string interpolation. Logged #34361 to follow up.

Contributes to #33947
2021-07-15 01:28:54 +00:00
Pranav K 10beca5a98
Enable build time warnings for IDE code analysis rules (#34215)
* Enable build time warnings for IDE code analysis rules

* Enables build time warnings for readonly, modifier ordering and const
* Fixes all of the warnings

Contributes to https://github.com/dotnet/aspnetcore/issues/24055
2021-07-09 18:21:45 +00:00
Brennan f3ae70fdbb
Cleanup IDE errors in SignalR (#33918) 2021-07-02 10:26:03 -07:00
Pranav K 78ab4bd673
Soft enable CA1810 (#33659)
A lot of the warnings for this rule appear from logging. Given this is going
to be replaced by a source generator, this change soft enables the rule while
fixing warnings that appear in non-logging code

Contributes to #24055
2021-06-23 07:56:06 -07:00
Pranav K 98a8d7a2be
Enable more code analysis rules (#33303)
Adds CA1842, CA1843, CA2008-CA2011, CA2013, CA2014, CA2016, CA2200, CA2208
2021-06-14 22:28:29 +00:00
Safia Abdalla 94cdf2c470
Move CA1845 analyzer back to warning level (#33444)
* Move CA1845 analyzer back to warning level
* Fix warnings in src/ProjectTemplates/Shared/AspNetProcess.cs
2021-06-10 16:07:21 -07:00
William Godbe 6a929c3796
Update SDK (#33187)
* Update SDK

* Add diagnostic for tracing in test

* Try disable publish trimming

* Revert "Try disable publish trimming"

This reverts commit 766ae32611.

* Add BuiltInComInteropSupport

* Update global.json

* Update global.json

* Fix analyzer warning and clean up workarounds

* Fix up more analyzer warnings

* Fix CA1846 issues in WebEncoders and Http

* Fix CA1845 warnings in Logging.AzureAppServices

* Fix CA1845 warning in RazorPagesRazorViewEngineOptionsSetup

* Fix warning in FileProviderRazorProjectFileSystem

* Disable span warnings in tests

* Re-ordering

* Downgrade CA1846 to suggestion for projects

Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
Co-authored-by: Safia Abdalla <safia@safia.rocks>
Co-authored-by: Safia Abdalla <safia@microsoft.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2021-06-09 19:47:20 -07:00
Pranav K ba6edfeab0
Enable CA1835-CA1841 (#33270)
* Enable CA1835-CA1841, CA1845, CA1846
2021-06-04 15:54:45 -07:00
Pranav K e4f7bfb435
Enable CA1821, CA1825-CA1834 (#33041)
* Enable CA1821, CA1825-CA1834

Contributes to https://github.com/dotnet/aspnetcore/issues/24055
2021-05-26 23:05:12 +00:00
Pranav K be5ba495b4
Enable CA1805 diagnostics (#32893)
* Enable CA1805 diagnostics
2021-05-21 13:35:20 -07:00
Pranav K af9bb41d62
Turn on some CodeAnalysis rules (#32837)
* Turn on some CodeAnalysis rules
2021-05-20 09:30:04 -07:00
Stephen Toub d86be87daa
Enable CA2012 (Use ValueTask Correctly) (#31221) 2021-03-26 13:31:10 +13:00
Youssef Victor 350ea5b181
Use NetAnalyzers from SDK instead of FxCopAnalyzers (#30138)
* Use analyzers from .NET SDK
2021-02-19 09:12:37 -08:00
Pranav K 8a81194f37
Enables code analysis rules about culture sensitive string operations (#26656)
* Enable string comparison FxCop rules
Co-authored-by: Kevin Pilch <me@pilchie.com>
2020-10-15 09:14:53 -07:00
Kevin Pilch 1da13e6501
Enable FxCop Analyzers for the repo (#23709)
All rules are currently disabled, except for one that I enabled for
src/Http via a new ".editorconfig" file I added there.

Other changes:

* Allow editorconfigs in MVC and Razor to flow to the root
* Consolidate a few editorconfig settings
* Tweak Ruleset config in Azure/AzureAD where it clashed.

Addresses the beginning of #9620, but it's a fair chunk of work to
enable most rules through the whole repo. That can be done directory by
directory and rule by rule by dropping .editorconfig files though.
2020-07-08 15:26:22 -07:00
Ajay Bhargav B 7f4b846e9f
Made the encodings of .razor and .cshtml files in the repo consistent (#23502)
* Added UTF8 BOMs to .razor and .cshtml files

* Fixes and unquarantined BOM tests

* Update .editorconfig
2020-06-30 12:03:01 -07:00
Ryan Nowak cb21edc500
Fix #7258 - remove components.server dependencies on blazor-specific plumbing (#7934)
* Removes a bunch of trivial usage of Blazor

... in names and comments where we don't specifically mean Blazor.

* Remove obsolete Startup from Components app

* Move UseBlazor into Blazor.Server

Moves UseBlazor and the related features in Blazor.Server - along with
some other general cleanup of misc shared files.

Now Components.Server has a much slimmer set of dependencies (MVC is
gone) and doesn't contain the "double startup" pattern that we
introduced (sorry).

We'll revisit UseBlazor and the dependencies there once the new
MapFallbackToFile support is available from static files.

* minor PR feedback

* Update reference assemblies

* fix broken test
2019-02-28 10:36:07 -08:00
Nate McMaster 968df9578b
Refactor shared framework projects targets and project layout (#3703)
This refactors the targets used to build the shared framework and its .zip files. There are lots of reasons motivating this: Arcade convergence, migration to VSTS, making it easier to build this locally, etc.

Changes:
* Moves move content of build/Sharedfx.{props/targets} into eng/targets/SharedFx.Common.{props/targets}
* Update the build to produce a `runtime.$rid.Microsoft.AspNetCore.App` package (not just the one with symbols in it)
* Refactor the targets which produce .tar.gz/.zip files into separate projects in `src/Installers/`
* Refactor installers, unit tests, and the framework projects to use ProjectReference to flow dependencies between different parts of the build.
* Makes it easier to build the shared framework locally (for the inner dev loop, you can run `dotnet build -p src/Framework/Microsoft.AspNetCore.App/src/ -r win-x64`)
2018-10-24 15:42:06 -07:00
Nate McMaster e841229782 Verify and mirror external dependencies and self-consistent package versions (#566)
Moves build logic from other infrastructure repos into aspnet/Universe.
2017-09-29 10:25:47 -07:00