* Further improve TESTGUIDE.md
* Added TOC
* fixed the lingering stuff still open since https://github.com/dotnet/fsharp/pull/10018 (it got merged a little too soon)
* added info for Linux
* added a table giving brief info for each test option
* added test running times
* improved wording in several places
* fix typo
* Improve info on running tests for contributors
(not finished yet)
Added/improved:
* Proper commands to run the tests
* Distinction for tests that can only run on Windows
* Removed outdated info (run as admin)
* Added prerequisites like Perl
* Added basic help for fixing common errors (like SOE, files in use, errors you see when "forgetting" `-ci`)
* Added expected runtimes
Question: should I link the files in the repo? They're now on github usercontent.
* Some more edits to TESTGUIDE.md
* migrate (as a separate copy) fsharpqa tests that are going to be impacted by #6596
the baseline files are empty on purpose, expecting CI failure reporting those tests, I intend to update the baseline and clean up the comments / xml tags from fsharpqa syntax in later commit, and then remove those specific tests altogether from fsharpqa if this is OK with the maintainers.
* update the .bsl files
* remove comments that are handled by baseline files, update baseline files
* remove the migrated tests from fsharpqa tests
* need to be more careful when migrating those
* testing if running the test with .fs instead of .fsx makes them work on .netcore
* exclude migrated fsharpqa from dotnet core run
* sample test in fsharpqa (can't run locally for now)
* trying to make it green now.
* checking if this path is covered by a test, trying to identify how to trigger this other overload related error message
* * [MethodCalls.fs] Defining CallerArgs<'T> in, this replaces passing of callerArgsCount, uncurriedCallerArgs and other variants in the overload resolution logic happening in ConstraintSolver & TypeChecker
* [TypeChecker.fs] pass CallerArgs instace at call sites for overload resolution + some commented code as we'll be building a list of given argument types (probably moving as a CallerArgs method or property)
* [ConstraintSolver.fs/fsi] pipe the overload resolution traced callback to `trace.CollectThenUndoOrCommit` as that expression is long and more important in that context
* bit of refactoring of error message building logic during failed overload resolution
[ConstraintSolver.fsi]
* define OverloadInformation and OverloadResolutionFailure, those replace workflow where `string * ((CalledMeth<_> * exn) list)` values were created at call site mixed with message building and matched later in non obvious fashion in `failOverloading` closure
* adjust UnresolvedOverloading and PossibleOverload exceptions
[ConstraintSolver.fs]
* get rid of `GetPossibleOverloads`, this was used only in `failOverloading` closure, and just being passed the same parameters at call site
* give `failOverloading` a more meaningful signature and consolidate the prefix message building logic there
* fix `failOverloading` call sites
[CompilerOps.fs] adjust pattern matching
Expecting behaviour of this code to be identical as before PR
`
* (buildfix) harmonizing .fsi/.fs right before commit doesn't always work with simple copy paste.
* trying to check what kind of things break loose when I change this
I'm trying to identify why we get `(CalledMeth<Expr> * exn list)`, I'm making a cartesian product through getMethodSlotsAndErrors for now, trying to figure out if we can get other than 0 or 1 exception in the list for a given method slot.
I may revert that one if it doesn't make sense make from a reviewer standpoint and/or breaks fsharpqa tests surounding overload resolution error messages.
* (minor) [ConstraintSolver.fs] revert space mishapps to reduce diff, put back comments where they were
* toward displaying the argument names properly (may fail some fsharpqa tests for now)
* missing Resharper's Ctrl+Alt+V "introduce variable" refactoring @auduchinok :)
* pretty print unresolved overloads without all the type submsumption per overload verbose messages
* Overload resolution error messages: things display like I want in fsi, almost like I want in VS2019, this is for the simple non generic method overload case.
I want to check if user experience changes wrt https://github.com/Microsoft/visualfsharp/issues/2503 and put some time to add tests.
* adjust message for candidates overload
* Hijack the split phase for UnresolvedOverloading, remove the match on PossibleOverload.
It consolidates some more of the string building logic, and it now shows as a single compact and exhaustive error message in VS
Thinking I'll change PossibleOverload to not be an exception if going this way is OK
* updating existing failing baseline files that looks correct to me
* quickfix for update.base.line.with.actuals.fsx so that it skips missing base line files in the loop
* (minor) minimize diff, typos, comments
* fix vsintegration tests affected by overload error message changes
* merge issue unused variable warning
* update the 12 fsharpqa migrated baseline with new error messages
* (minor) baseline update script
[update.base.line.with.actuals.fsx]
* add few directories
* error handling (when tests are running, the .err files are locked
* move System.Convert.ToString and System.Threading.Tasks.Task.Run tests from QA
* * moving 3 fsharpqa tests to new test suite
* bring back neg_System.Convert.ToString.OverloadList.fsx which I mistakenly removed during merge
* consolidate all string building logic in CompileOps.fs, fix remaining cases with missing \n (the end result code is less whack-a-mole-ish)
* update base lines
* remove the migrated tests from fsharpqa
* fix vstest error message
* fix env.lst, removed wrong one...
* update baselines of remaining tests
* adding one simple test with many overloads
* appropriate /// comments on `CalledMeth` constructor arguments
* minimize diff / formatting
* trim unused code
* add simple test, one message is interesting, mentioning parameter count for possible overloads
* comment flaky test for now
* code review on the `coerceExpr` function from @tihan, we can discard first `isOutArg` argument as the only hardcoded usage was guarded by `error` when the value is true, and passing an explicit false which is now guaranteed equivalent to `callerArg.IsOptional`
* code formatting remarks on ConstraintSolver.fs/fsi
* (minor) formatting
* format known argument type / updating .bsl
* update missing baseline
* update missing baselines
* update missing baseline
* minor: make TTrait better in debugger display
* [wip] pass TraitConstraintInfo around failed overload resolution error, and try to display some of it's info
* minimize diff
* signature file mismatch
* removing duplicate in fscomp.txt
* surfacing initial bits of TraitConstraintInfo, roughly for now
* formatting types of known argument in one go, the formatting is still wrong:
* unamed type arguments aren't relabelled (still show their numerical ids)
* SRTP constraints are dismissed, not sure how they should be lined up to pass to SimplifyTypes.CollectInfo
* rework of overload failure message to prettify *ALL* types in a single go, not only argument types, but return types and known generic argument types (this info was never displayed originally but is useful for scenario similar to FSharpPlus implementation)
added `PrettifyDiscriminantAndTypePairs` in TastOps, this allow to weave extra information with the complete list of types, to help reconstituting the several types from their origin (in the usage spot: argument types, return type, generic parameter types)
* fixup the tests and add two tests
* one checking on the new information of known return type and generic parameter types
* one checking we don't leak internal unammed Typar and that they don't all get named 'a despite being different
* updating baselines that got tighter.
* simplify handling of TraitConstraintInfo
* naming couple of fields and turning a property to a methods as it triggers an assert in debugger when inspecting variables
* comments in the assembling of overload resolution error message
* Add information about which argument doesn't match
Add couple of tests
Updating bunch of baselines
* minor updates to testguide and devguide
* fix PrimitiveConstraints.``Invalid object constructor`` test
* fix(?) salsa tests
* minimize diff
* put back tests under !FSHARP_SUITE_DRIVES_CORECLR_TESTS
* missing updated message
* minor adjustments to TESTGUIDE.md
* return type was missing prettifying in prettyLayoutsOfUnresolvedOverloading
* address code review nits / minimize diff / add comment on PrettifyDiscriminantAndTypePairs
* minimize diff
* proposed work around the flaky error message until https://github.com/dotnet/fsharp/issues/6725 has a fix
we keep the fsharpqa test around (but removing the overload error messages from what is asserted out of it) in the meantime
* fixing baselines of new tests from master
* sisyphus round of baseline update
* removing type which isn't in use and popped back up after rebase
* minimize diff
* tidy inconsistent tuple literal
* * removing TTrait properties that end up not being used
* renaming tys and returnTy fields to better match convention (`tys` is used, so no underscore prefix)
* minimizing diff
* minimize diff
* minimize diff
* minimize diff
* link to usage example in same file
* revert converting CallerArg single cased DU into Record
* minimize diff
* minimize diff
* minimize diff
* fix rebase glitches
* fix rebase glitch
* update baseline
* fix base lines / new tests base lines
* edge case: needs a new line after "A unique overload for method '%s' could not be determined based on type information prior to this program point. A type annotation may be needed." if there are no optional parts.
* updating base line for edge case of missing new line
* missing baseline
* removing comment
* Adjustments to TESTGUIDE.md relative to usage of fsharpqa tests
Tentative to add a .fsx test runner calling into perl, idea will be, once it is having tests pass, to make the script modify the test list file to tag arbitrary tests and run only those, and then revert the tagging. I'm not sure if this can be made to work consistently but it is worth trying.
* make run.fsharpqa.test.fsx work
* * add tests/fsharpqa/readme.md file, giving overview of the suite, description of file formats and describing a workflow when adding / fixing F# QA tests
* mention above readme.md in TESTGUIDE.md
* add helper project to FSharp.sln to navigate among the F# QA test files (find env.lst, source and log files, etc.)
* * helper script to update baseline files under tests/fsharp
* rework "Other Tips" section to expand on the system of baselines files used in FSharp Test Suite
* add the script to the project where it is most likely to be useful
As a result of struggling with running and adding to the compiler tests recently, hopefully this will make things clearer for future contributors.
* FSharpSuite are NUnit tests now.
* Move RunAll.pl specific test.lst stuff to FSharpQA paragraph.
* Add example of using build.cmd to run subset of FSharpQA tests.
commit 2a991b6c8e30c712640e2869972f02c6313cc7e3
Author: Don Syme <dsyme@users.noreply.github.com>
Date: Mon Oct 17 20:40:15 2016 +0100
Fix microbuild (#1629)
commit 169d366713
Author: Kevin Ransom (msft) <codecutter.fsharp@hotmail.com>
Date: Sun Oct 16 15:04:50 2016 -0700
Add missed file. (#1625)
* Ensure that portable libraries have correct hintpath for preview 5
* Replaced missed file
commit d64ff35398
Author: Don Syme <dsyme@users.noreply.github.com>
Date: Sun Oct 16 22:37:08 2016 +0100
cleanup build and test scripts (#1615)
* cleanup build and test scripts
commit 39480c4c40
Author: Kevin Ransom (msft) <codecutter.fsharp@hotmail.com>
Date: Sun Oct 16 10:19:03 2016 -0700
Ensure that portable libraries have correct hintpath for preview 5 (#1624)
commit 2fe5a3be82
Author: Kevin Ransom (msft) <codecutter@hotmail.com>
Date: Sat Oct 15 14:03:48 2016 -0700
Add support for generating sourcelink record in portable pdbs. Fixes#1585
commit e0318a8f65
Author: Kevin Ransom (msft) <codecutter.fsharp@hotmail.com>
Date: Sat Oct 15 13:32:44 2016 -0700
FSharp ms build task to support new xommand line options (#1616)
commit 749ba2dfbb
Author: Omar Tawfik <OmarTawfik@users.noreply.github.com>
Date: Sat Oct 15 13:27:14 2016 -0700
Don't match braces at the end of the caret (#1619)
commit 00bab9974f
Author: Kevin Ransom (msft) <codecutter.fsharp@hotmail.com>
Date: Sat Oct 15 13:25:15 2016 -0700
(Nugetize F# templates. Ensure value tuple installed on create template. (#1620)
commit 2a9b5ef818
Author: Omar Tawfik <OmarTawfik@users.noreply.github.com>
Date: Fri Oct 14 22:45:35 2016 -0700
Add fsx files to workspaces (#1612)
* Add fsx files to workspaces
* Stop passing project output paths to CPS
* Read script file contents from memory (on workspace initialization)
commit 8b434e0fed
Author: Kevin Ransom (msft) <codecutter.fsharp@hotmail.com>
Date: Fri Oct 14 10:32:59 2016 -0700
Don't try to deploy vsix during OSS build. Specify prereq in vsixmanifest (#1613)
commit 79430d298d
Author: Don Syme <dsyme@users.noreply.github.com>
Date: Fri Oct 14 15:58:08 2016 +0100
simplify use of if-defs (#1614)
commit b708921ebe
Author: Don Syme <dsyme@users.noreply.github.com>
Date: Fri Oct 14 10:25:28 2016 +0100
Always use FSharp.Core not fsharp.core (#1610)
Don Syme
Kevin Ransom (msft)
Vlad Zarytovskii
Abel Braaksma
Gauthier Segay
Brett V. Forsgren
ShalokShalom
Tom
Darío Hereñú
Kurt Schelfthout
Don Syme
Libo Zeng
Taylor Wood
Don Syme
Omar Tawfik
KevinRansom
mrange
enricosada