dotnet
/
maui
зеркало из
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Mop up enabling warnings as errors (#78)

This commit is contained in:
kingces95 2016-04-12 11:44:30 -07:00 коммит произвёл Jason Smith
Родитель 73defe491f
Коммит 10f6c08ceb
19 изменённых файлов: 79 добавлений и 27 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

2
Xamarin.Forms.Core/Cells/EntryCell.cs
Просмотреть файл

@ -74,7 +74,9 @@ namespace Xamarin.Forms
static void OnHorizontalTextAlignmentPropertyChanged(BindableObject bindable, object oldValue, object newValue)
{
var label = (EntryCell)bindable;
#pragma warning disable 0618 // retain until XAlign removed
label.OnPropertyChanged(nameof(XAlign));
#pragma warning restore
}
}
}

16
Xamarin.Forms.Core/Label.cs
Просмотреть файл

@ -176,11 +176,15 @@ namespace Xamarin.Forms
var family = (string)values[0];
if (family != null)
{
#pragma warning disable 0618 // retain until Font removed
label.Font = Font.OfSize(family, (double)values[1]).WithAttributes(attributes);
#pragma warning restore
}
else
{
#pragma warning disable 0618 // retain until Font removed
label.Font = Font.SystemFontOfSize((double)values[1], attributes);
#pragma warning restore
}
label._cancelEvents = false;
@ -201,11 +205,15 @@ namespace Xamarin.Forms
var family = (string)newValue;
if (family != null)
{
#pragma warning disable 0618 // retain until Font removed
label.Font = Font.OfSize(family, (double)values[0]).WithAttributes((FontAttributes)values[1]);
#pragma warning restore
}
else
{
#pragma warning disable 0618 // retain until Font removed
label.Font = Font.SystemFontOfSize((double)values[0], (FontAttributes)values[1]);
#pragma warning restore
}
label._cancelEvents = false;
@ -226,11 +234,15 @@ namespace Xamarin.Forms
var family = (string)values[0];
if (family != null)
{
#pragma warning disable 0618 // retain until Font removed
label.Font = Font.OfSize(family, size).WithAttributes((FontAttributes)values[1]);
#pragma warning restore
}
else
{
#pragma warning disable 0618 // retain until Font removed
label.Font = Font.SystemFontOfSize(size, (FontAttributes)values[1]);
#pragma warning restore
}
label._cancelEvents = false;
@ -246,7 +258,9 @@ namespace Xamarin.Forms
static void OnHorizontalTextAlignmentPropertyChanged(BindableObject bindable, object oldValue, object newValue)
{
var label = (Label)bindable;
#pragma warning disable 0618 // retain until XAlign removed
label.OnPropertyChanged(nameof(XAlign));
#pragma warning restore
}
static void OnTextPropertyChanged(BindableObject bindable, object oldvalue, object newvalue)
@ -264,7 +278,9 @@ namespace Xamarin.Forms
static void OnVerticalTextAlignmentPropertyChanged(BindableObject bindable, object oldValue, object newValue)
{
var label = (Label)bindable;
#pragma warning disable 0618 // retain until YAlign removed
label.OnPropertyChanged(nameof(YAlign));
#pragma warning restore
}
}
}

2
Xamarin.Forms.Core/Span.cs
Просмотреть файл

@ -126,6 +126,7 @@ namespace Xamarin.Forms
handler(this, new PropertyChangedEventArgs(propertyName));
}
#pragma warning disable 0618 // retain until Span.Font removed
void UpdateFontPropertiesFromStruct()
{
if (_inUpdate)
@ -166,4 +167,5 @@ namespace Xamarin.Forms
_inUpdate = false;
}
}
#pragma warning restore
}

2
Xamarin.Forms.Core/TapGestureRecognizer.cs
Просмотреть файл

@ -45,9 +45,11 @@ namespace Xamarin.Forms
if (handler != null)
handler(sender, new TappedEventArgs(CommandParameter));
#pragma warning disable 0618 // retain until TappedCallback removed
Action<View, object> callback = TappedCallback;
if (callback != null)
callback(sender, TappedCallbackParameter);
#pragma warning restore
}
#region obsolete cruft

2
Xamarin.Forms.Core/TypeConverter.cs
Просмотреть файл

@ -27,7 +27,9 @@ namespace Xamarin.Forms
public virtual object ConvertFromInvariantString(string value)
{
#pragma warning disable 0618 // retain until ConvertFrom removed
return ConvertFrom(CultureInfo.InvariantCulture, value);
#pragma warning restore
}
}
}

6
Xamarin.Forms.Core/VisualElement.cs
Просмотреть файл

@ -511,7 +511,9 @@ namespace Xamarin.Forms
public SizeRequest Measure(double widthConstraint, double heightConstraint, MeasureFlags flags = MeasureFlags.None)
{
#pragma warning disable 0618 // retain until GetSizeRequest removed
SizeRequest result = GetSizeRequest(widthConstraint, heightConstraint);
#pragma warning restore
if ((flags & MeasureFlags.IncludeMargins) != 0)
{
@ -577,11 +579,14 @@ namespace Xamarin.Forms
protected virtual SizeRequest OnMeasure(double widthConstraint, double heightConstraint)
{
#pragma warning disable 0618 // retain until OnSizeRequest removed
return OnSizeRequest(widthConstraint, heightConstraint);
#pragma warning restore
}
protected override void OnParentSet()
{
#pragma warning disable 0618 // retain until ParentView removed
base.OnParentSet();
if (ParentView != null)
@ -592,6 +597,7 @@ namespace Xamarin.Forms
{
NavigationProxy.Inner = null;
}
#pragma warning restore
}
protected virtual void OnSizeAllocated(double width, double height)

9
Xamarin.Forms.Core/Xamarin.Forms.Core.csproj
Просмотреть файл

@ -22,7 +22,8 @@
<WarningLevel>4</WarningLevel>
<ConsolePause>false</ConsolePause>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0618</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>full</DebugType>
@ -32,14 +33,16 @@
<WarningLevel>4</WarningLevel>
<ConsolePause>false</ConsolePause>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0618</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Turkey|AnyCPU'">
<DebugSymbols>true</DebugSymbols>
<OutputPath>bin\Turkey\</OutputPath>
<DefineConstants>DEBUG;</DefineConstants>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0618</NoWarn>
<NoWarn>
</NoWarn>
<DebugType>full</DebugType>
<PlatformTarget>AnyCPU</PlatformTarget>
<ErrorReport>prompt</ErrorReport>

2
Xamarin.Forms.Maps.Android/MapRenderer.cs
Просмотреть файл

@ -260,7 +260,7 @@ namespace Xamarin.Forms.Maps.Android
return;
foreach (Pin p in pins) {
var marker = _markers.FirstOrDefault (m => m.Id == p.Id);
var marker = _markers.FirstOrDefault (m => (object)m.Id == p.Id);
if (marker == null)
continue;
marker.Remove ();

9
Xamarin.Forms.Maps.Android/Xamarin.Forms.Maps.Android.csproj
Просмотреть файл

@ -28,7 +28,8 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0253</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>pdbonly</DebugType>
@ -38,7 +39,8 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0253</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Turkey|AnyCPU'">
<DebugSymbols>true</DebugSymbols>
@ -51,7 +53,8 @@
<WarningLevel>4</WarningLevel>
<Optimize>false</Optimize>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0253</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<ItemGroup>
<Reference Include="Mono.Android" />

2
Xamarin.Forms.Maps.UWP/MapRenderer.cs
Просмотреть файл

@ -133,7 +133,9 @@ namespace Xamarin.Forms.Maps.WinRT
void ClearPins()
{
Control.Children.Clear();
#pragma warning disable 4014 // don't wanna block UI thread
UpdateIsShowingUser();
#pragma warning restore
}
void RemovePin(Pin pinToRemove)

6
Xamarin.Forms.Maps.UWP/Xamarin.Forms.Maps.UWP.csproj
Просмотреть файл

@ -27,7 +27,8 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>4014</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<PlatformTarget>AnyCPU</PlatformTarget>
@ -38,7 +39,8 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>4014</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
<PlatformTarget>x86</PlatformTarget>

6
Xamarin.Forms.Maps.WinRT.Phone/Xamarin.Forms.Maps.WinRT.Phone.csproj
Просмотреть файл

@ -26,7 +26,8 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>4014</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>pdbonly</DebugType>
@ -36,7 +37,8 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>4014</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|ARM'">
<DebugSymbols>true</DebugSymbols>

2
Xamarin.Forms.Maps.WinRT.Tablet/MapRenderer.cs
Просмотреть файл

@ -110,7 +110,9 @@ namespace Xamarin.Forms.Maps.WinRT
void ClearPins()
{
Control.Children.Clear();
#pragma warning disable 4014 // don't wanna block UI thread
UpdateIsShowingUser();
#pragma warning restore
}
void RemovePin(Pin pinToRemove)

6
Xamarin.Forms.Maps.WinRT.Tablet/Xamarin.Forms.Maps.WinRT.Tablet.csproj
Просмотреть файл

@ -42,7 +42,8 @@
<DebugSymbols>true</DebugSymbols>
<OutputPath>bin\ARM\Debug\</OutputPath>
<DefineConstants>DEBUG;TRACE;NETFX_CORE;WINDOWS_APP</DefineConstants>
<NoWarn>2008;4014</NoWarn>
<NoWarn>
</NoWarn>
<DebugType>full</DebugType>
<PlatformTarget>ARM</PlatformTarget>
<UseVSHostingProcess>false</UseVSHostingProcess>
@ -54,7 +55,8 @@
<OutputPath>bin\ARM\Release\</OutputPath>
<DefineConstants>TRACE;NETFX_CORE;WINDOWS_APP</DefineConstants>
<Optimize>true</Optimize>
<NoWarn>2008;4014</NoWarn>
<NoWarn>
</NoWarn>
<DebugType>pdbonly</DebugType>
<PlatformTarget>ARM</PlatformTarget>
<UseVSHostingProcess>false</UseVSHostingProcess>

12
Xamarin.Forms.Maps.iOS/Xamarin.Forms.Maps.iOS.Classic.csproj
Просмотреть файл

@ -25,7 +25,8 @@
<MtouchDebug>true</MtouchDebug>
<CodesignKey>iPhone Developer</CodesignKey>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0414</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>none</DebugType>
@ -37,7 +38,8 @@
<ConsolePause>false</ConsolePause>
<CodesignKey>iPhone Developer</CodesignKey>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0414</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Turkey|AnyCPU'">
<DebugSymbols>true</DebugSymbols>
@ -49,11 +51,13 @@
<ErrorReport>prompt</ErrorReport>
<CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0414</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'AppStore|AnyCPU'">
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0414</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<ItemGroup>
<Compile Include="..\Xamarin.Forms.Core\Properties\GlobalAssemblyInfo.cs">

12
Xamarin.Forms.Maps.iOS/Xamarin.Forms.Maps.iOS.csproj
Просмотреть файл

@ -24,7 +24,8 @@
<MtouchDebug>true</MtouchDebug>
<CodesignKey>iPhone Developer</CodesignKey>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0414</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>none</DebugType>
@ -35,7 +36,8 @@
<ConsolePause>false</ConsolePause>
<CodesignKey>iPhone Developer</CodesignKey>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0414</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Turkey|AnyCPU'">
<DebugSymbols>true</DebugSymbols>
@ -47,11 +49,13 @@
<ErrorReport>prompt</ErrorReport>
<CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0414</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'AppStore|AnyCPU'">
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>0414</NoWarn>
<NoWarn>
</NoWarn>
</PropertyGroup>
<ItemGroup>
<Compile Include="..\Xamarin.Forms.Core\Properties\GlobalAssemblyInfo.cs">

4
Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj
Просмотреть файл

@ -27,7 +27,7 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>1998;0618;0169</NoWarn>
<NoWarn>1998</NoWarn>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<PlatformTarget>AnyCPU</PlatformTarget>
@ -38,7 +38,7 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>1998;0618;0169</NoWarn>
<NoWarn>1998</NoWarn>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|ARM'">
<PlatformTarget>ARM</PlatformTarget>

2
Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs
Просмотреть файл

@ -165,8 +165,6 @@ namespace Xamarin.Forms.Platform.WinRT
sealed class BrushedElement
{
bool _isBound;
public BrushedElement(FrameworkElement element, WBinding brushBinding = null, Brush brush = null)
{
Element = element;

4
Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj
Просмотреть файл

@ -37,7 +37,7 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>1998;0168;0169;0067;0618</NoWarn>
<NoWarn>1998</NoWarn>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>pdbonly</DebugType>
@ -47,7 +47,7 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>1998;0168;0169;0067;0618</NoWarn>
<NoWarn>1998</NoWarn>
</PropertyGroup>
<ItemGroup>
<!-- A reference to the entire .NET Framework is automatically included -->