### Description of Change
This fixes the toggle for including sample content in the template. In
#25419 some last-minute changes were made to not make the sample content
show up by default, but that introduced a bug where you couldn't get the
sample content to show up at all using Visual Studio.
With this change the sample content can optionally be included again in
Visual Studio by using the checkbox and through the CLI by specifying
either `--sample-content` or `-sc`.
Also the not used `Empty` switch was removed as well as the
`SampleContent` variable which did not serve any additional purpose.
Context: https://github.com/dotnet/maui/pull/25389
Context: https://github.com/jonathanpeppers/inclusive-heat-sensor/releases/tag/v0.1.1
The version of the action in #25389 had an issue where a non-zero exit
code could make the step fail. This would trigger a GitHub
notification for the commenter.
So, to avoid that, the v0.1.1 release:
* Uses `continue-on-error: true` in the step that runs the action.
* Explicitly `exit 0` in powershell, this was the true cause of the
non-zero exit code.
Note that we're still testing out this idea, our goal is to run this
silently to decide how useful this will be.
I also made this no longer run on `pull_request` reopen, as this event
doesn't make sense.
Microsoft.iOS.Sdk.net9.0_18.0 , Microsoft.MacCatalyst.Sdk.net9.0_18.0 , Microsoft.macOS.Sdk.net9.0_15.0 , Microsoft.tvOS.Sdk.net9.0_18.0
From Version 18.0.9614 -> To Version 18.0.9615
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This will make it easier for devs to intentionally revert the implied opt-out of android 35 edge to edge enforcement behaviour that this PR also adds to MAUI.
Now all that's needed is to apply the disable style like this:
```csharp
protected override void OnCreate(Bundle? savedInstanceState)
{
Theme?.ApplyStyle(Microsoft.Maui.Resource.Style.DisableOptOutEdgeToEdgeEnforcement, force: true);
base.OnCreate(savedInstanceState);
}
```
There are very few changes as this point, but recording a new profile
shows a few changes, and maybe improvement by a very small amount:
Before:
Average(ms): 450.1
Std Err(ms): 3.53537676760043
Std Dev(ms): 11.1798429724611
After:
Average(ms): 448.6
Std Err(ms): 2.54383787044519
Std Dev(ms): 8.04432166879912
This is an average of 10 runs on a `dotnet new maui` template on a Pixel 7 Pro.
It might be effectively *the same*, but it's worth updating I suppose.
See https://github.com/dotnet/maui/issues/24742 for details.
It seems to be a better compromise to disable this by default in MAUI apps. You can still opt out by including a similar style:
```xml
<style name="DisableOptOutEdgeToEdgeEnforcement">
<item name="android:windowOptOutEdgeToEdgeEnforcement">false</item>
</style>
```
And then applying it in a similar way, either by calling it before the `base.OnCreate(..)` in your activity subclass (in the OnCreate method override), or by registering for the ActivityOnCreate lifecycle callback.
Eg:
```csharp
protected override void OnCreate(Bundle? savedInstanceState)
{
// Disable Edge to Edge opt out by calling this before base.OnCreate()
Theme?.ApplyStyle(Resource.Style.DisableOptOutEdgeToEdgeEnforcement, force: true);
base.OnCreate(savedInstanceState);
}
```
Microsoft.Android.Sdk.Windows
From Version 35.0.3 -> To Version 35.0.7
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.Android.Sdk.Windows
From Version 35.0.1-rtm.61 -> To Version 35.0.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Rui Marinho
Gerald Versluis
Jonathan Dick
redth
Tamilarasan Paranthaman
Jonathan Peppers
dotnet-maestro[bot]
TJ Lambert
Javier Suárez
Paul Anderson
vishnumenon2684
github-actions[bot]
Jakub Florkowski
Shane Neuville
Vignesh-SF3580