This PR is a style-only clean up of our code actions handlers and
related code. Definitely could have gone further (more collection
pooling, returning concrete types etc.) but I wanted to try to have it
serve as an indication for what we consider our current idiomatic coding
style* and to avoid conflicts with the extract to component work.
<sub>* Current style is subject to change at any time, and are not well
documented. To quote a great Australian film, [it's just the
vibe](https://www.youtube.com/watch?v=nMuh33BMZYY).</sub>
* Removing unnecessary Razor Legacy Editor feature flag
AFAIK it was introduced for new LSP editor rollout several years ago before we had Tools/Options/HTML Editor/Advanced/Use legacy Razor Editor option. Now that rollout is over, and there is a public non-preview mechanism for users to switch to the old editor if needed, the feature flag is no longer necessary and creates confusion (and extra code to test/maintain).
* Fixing a unit test (test matrix)
* Fixing spacing per CR suggestion
Co-authored-by: David Wengier <david.wengier@microsoft.com>
---------
Co-authored-by: David Wengier <david.wengier@microsoft.com>
As discussed offline, Roslyn doesn't support the Uri or Text
presentation endpoints, and recent LSP client changes have caused
erroneous failure telemetry to be logged as a result. This PR fixes that
by just not calling Roslyn.
I've been meaning to do this for a long while now. This change removes
all of the IVTs from `AssemblyInfo.cs` files and places them in the
relevant project file. I've also added a target to process
`RestrictedInternalsVisibleTo`, though that's only used by
MS.ANC.Razor.LanguageServer to restrict the IVT to the
"Microsoft.AspNetCore.Razor.LanguageServer.Hosting" namespace.
* Update dependencies from https://github.com/dotnet/arcade build 20240624.7
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24324.7
* Update dependencies from https://github.com/dotnet/arcade build 20240624.7
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24324.7
* Update dependencies from https://github.com/dotnet/arcade build 20240624.7
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24324.7
* Update dependencies from https://github.com/dotnet/arcade build 20240624.7
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24324.7
* Update dependencies from https://github.com/dotnet/arcade build 20240626.4
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24326.4
* Update dependencies from https://github.com/dotnet/arcade build 20240626.4
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24326.4
* Update dependencies from https://github.com/dotnet/arcade build 20240628.2
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24328.2
* Update dependencies from https://github.com/dotnet/arcade build 20240628.2
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24328.2
* Update dependencies from https://github.com/dotnet/arcade build 20240702.1
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24352.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
David Wengier
Alex Gavrilov
Amadeusz Wieczorek
Andrew Hall
Dustin Campbell
dotnet-maestro[bot]