Removed Skip on tests that linked to issues that were marked Done. Noticed the pathing issue for dotnet-format, fixed it, and reenabled the CI job.

2024-06-19 13:21:35 -07:00 · 2024-06-19 13:21:35 -07:00 · 880e096f77
--- a/eng/dotnet-format/dotnet-format-integration.yml
+++ b/eng/dotnet-format/dotnet-format-integration.yml
@ -14,14 +14,13 @@ parameters:
    _branchName: "main"
    _sha: "a3bb37003aeccad012a6e7dd220977599e8b8e65"
    _useParentSdk: 0
-  # Formatting sdk fails: https://github.com/dotnet/sdk/issues/41060
-  # - Name: sdk
-  #   _repo: "https://github.com/dotnet/sdk"
-  #   _repoName: "dotnet/sdk"
-  #   _targetSolution: "sdk.sln"
-  #   _branchName: "main"
-  #   _sha: "be25db95c376bffd508a023399ddd34392fe6458"
-  #   _useParentSdk: 0
+  - Name: sdk
+    _repo: "https://github.com/dotnet/sdk"
+    _repoName: "dotnet/sdk"
+    _targetSolution: "sdk.sln"
+    _branchName: "main"
+    _sha: "be25db95c376bffd508a023399ddd34392fe6458"
+    _useParentSdk: 0
  - Name: project_system
    _repo: "https://github.com/dotnet/project-system"
    _repoName: "dotnet/project-system"
--- a/test/Microsoft.DotNet.GenAPI.Tests/CSharpFileBuilderTests.cs
+++ b/test/Microsoft.DotNet.GenAPI.Tests/CSharpFileBuilderTests.cs
@ -2125,7 +2125,7 @@ namespace Microsoft.DotNet.GenAPI.Tests
                includeInternalSymbols: false);
        }

-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/67019")]
+        [Fact]
        public void TestInterfaceWithOperatorGeneration()
        {
            RunTest(original: """
@ -2149,7 +2149,7 @@ namespace Microsoft.DotNet.GenAPI.Tests
                 includeInternalSymbols: false);
        }

-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/67019")]
+        [Fact]
        public void TestInterfaceWithCheckedOperatorGeneration()
        {
            RunTest(original: """
--- a/test/Microsoft.NET.Build.Tests/GenerateResourceTests.cs
+++ b/test/Microsoft.NET.Build.Tests/GenerateResourceTests.cs
@ -10,7 +10,7 @@ namespace Microsoft.NET.Build.Tests
        {
        }

-        [Theory(Skip = "https://github.com/microsoft/msbuild/issues/4488")]
+        [Theory]
        [InlineData(ToolsetInfo.CurrentTargetFramework, true)]
        public void DependentUponTest(string targetFramework, bool isExe)
        {
--- a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs
+++ b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs
@ -12,7 +12,7 @@ namespace Microsoft.NET.Build.Tests

        private readonly Lazy<TestAsset> _buildAsset;

-        [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/3785")]
+        [FullMSBuildOnlyFact]
        public void It_can_generate_correct_depsJson_file()
        {
            TestAsset testAsset = _buildAsset.Value;
@ -23,7 +23,7 @@ namespace Microsoft.NET.Build.Tests
            depsJsonContent.Should().Contain("NETCoreCppCliTestC.dll", "should contain transitive reference");
        }

-        [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/3785")]
+        [FullMSBuildOnlyFact]
        public void It_can_generate_all_runtimeconfig_files_to_output_folder()
        {
            TestAsset testAsset = _buildAsset.Value;
@ -35,7 +35,7 @@ namespace Microsoft.NET.Build.Tests
            });
        }

-        [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/3785")]
+        [FullMSBuildOnlyFact]
        public void It_can_generate_all_depsjson_files_to_output_folder()
        {
            TestAsset testAsset = _buildAsset.Value;
--- a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildADesktopExe.cs
+++ b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildADesktopExe.cs
@ -657,7 +657,7 @@ class Program
                .And.NotHaveStdOutContaining("Could not determine");
        }

-        [FullMSBuildOnlyTheory(Skip = "https://github.com/NuGet/Home/issues/8238")]
+        [FullMSBuildOnlyTheory]
        [InlineData("4.3.3")]
        [InlineData("4.1.0")]
        public void Aliases_are_preserved_if_inbox_assembly_wins_conflict_resolution(string httpPackageVersion)
--- a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAWindowsDesktopProject.cs
+++ b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAWindowsDesktopProject.cs
@ -186,7 +186,7 @@ namespace Microsoft.NET.Build.Tests
                .HaveStdOutContaining("NETSDK1140");
        }

-        [WindowsOnlyTheory(Skip = "https://github.com/dotnet/sdk/pull/29009")]
+        [WindowsOnlyTheory]
        [InlineData(true)]
        [InlineData(false)]
        public void It_succeeds_if_windows_target_platform_version_does_not_have_trailing_zeros(bool setInTargetframework)
--- a/test/Microsoft.NET.Build.Tests/WorkloadTests.cs
+++ b/test/Microsoft.NET.Build.Tests/WorkloadTests.cs
@ -109,7 +109,7 @@ namespace Microsoft.NET.Build.Tests
            //  .HaveStdOutContaining("android");
        }

-        [Fact(Skip = "https://github.com/dotnet/sdk/issues/19866")]
+        [Fact]
        public void It_should_fail_to_build_without_workload_when_multitargeted()
        {
            var testProject = new TestProject()
@ -229,7 +229,7 @@ namespace Microsoft.NET.Build.Tests
                .BeEquivalentTo("true");
        }

-        [Fact(Skip = "https://github.com/dotnet/sdk/issues/19866")]
+        [Fact]
        public void It_should_get_suggested_workload_by_GetRequiredWorkloads_target()
        {
            var mainProject = new TestProject()
@ -259,7 +259,7 @@ namespace Microsoft.NET.Build.Tests
                .BeEquivalentTo("android");
        }

-        [Theory(Skip = "https://github.com/dotnet/installer/issues/13361")]
+        [Theory]
        [InlineData($"{ToolsetInfo.CurrentTargetFramework}-android;{ToolsetInfo.CurrentTargetFramework}-ios", $"{ToolsetInfo.CurrentTargetFramework}-android;{ToolsetInfo.CurrentTargetFramework}-ios", "android;android-aot")]
        [InlineData(ToolsetInfo.CurrentTargetFramework, $"{ToolsetInfo.CurrentTargetFramework};{ToolsetInfo.CurrentTargetFramework}-android;{ToolsetInfo.CurrentTargetFramework}-ios", "macos;android-aot")]
        [InlineData($"{ToolsetInfo.CurrentTargetFramework};{ToolsetInfo.CurrentTargetFramework}-ios", $"{ToolsetInfo.CurrentTargetFramework};{ToolsetInfo.CurrentTargetFramework}-android", "macos;android-aot")]
--- a/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishASingleFileApp.cs
+++ b/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishASingleFileApp.cs
@ -307,7 +307,7 @@ namespace Microsoft.NET.Publish.Tests
        }


-        [RequiresMSBuildVersionTheory("17.0.0.32901", Skip = "https://github.com/dotnet/runtime/issues/60308")]
+        [RequiresMSBuildVersionTheory("17.0.0.32901")]
        [InlineData(true)]
        [InlineData(false)]
        public void It_supports_composite_r2r(bool extractAll)
--- a/test/Microsoft.NET.Sdk.Razor.Tests/DesignTimeBuildIntegrationTest.cs
+++ b/test/Microsoft.NET.Sdk.Razor.Tests/DesignTimeBuildIntegrationTest.cs
@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Razor.Design.IntegrationTests
            new FileInfo(Path.Combine(outputPath, "SimpleMvc.Views.pdb")).Should().NotExist();
        }

-        [Fact(Skip = "Skipping until https://github.com/dotnet/aspnetcore/issues/28825 is resolved.")]
+        [Fact]
        public void RazorGenerateDesignTime_ReturnsRazorGenerateWithTargetPath()
        {
            var testAsset = "RazorSimpleMvc";
--- a/test/Microsoft.NET.ToolPack.Tests/GivenThatWeWantToPackAToolProjectWithGeneratePackageOnBuild.cs
+++ b/test/Microsoft.NET.ToolPack.Tests/GivenThatWeWantToPackAToolProjectWithGeneratePackageOnBuild.cs
@ -71,7 +71,7 @@ namespace Microsoft.NET.ToolPack.Tests
            }
        }

-        [Theory(Skip = "https://github.com/dotnet/sdk/issues/3471")]
+        [Theory]
        [InlineData(false, false)]
        [InlineData(false, true)]
        [InlineData(true, false)]
--- a/test/Microsoft.TemplateEngine.Cli.UnitTests/ParserTests/TabCompletionTests.cs
+++ b/test/Microsoft.TemplateEngine.Cli.UnitTests/ParserTests/TabCompletionTests.cs
@ -341,9 +341,7 @@ namespace Microsoft.TemplateEngine.Cli.UnitTests.ParserTests
            Assert.DoesNotContain("--baseline", result);
        }

-#pragma warning disable xUnit1004 // Test methods should not be skipped
-        [Fact(Skip = "https://github.com/dotnet/templating/issues/4192")]
-#pragma warning restore xUnit1004 // Test methods should not be skipped
+        [Fact]
        public void CanCompleteParameters_StartsWith_AfterOption()
        {
            MockTemplateInfo template1 = new MockTemplateInfo("foo", identity: "foo.1", groupIdentity: "foo.group")
--- a/test/dotnet-format.Tests/tests/Utilities/TestProjectsPathHelper.cs
+++ b/test/dotnet-format.Tests/tests/Utilities/TestProjectsPathHelper.cs
@ -10,14 +10,14 @@ namespace Microsoft.CodeAnalysis.Tools.Tests.Utilities
        {
            if (s_projectsDirectory == null)
            {
-                var assetsDirectory = Path.Combine(TestContext.Current.TestAssetsDirectory, "dotnet-format.TestsProjects");
+                var assetsDirectory = Path.Combine(TestContext.Current.TestAssetsDirectory, "dotnet-format");
                if (Directory.Exists(assetsDirectory))
                {
                    s_projectsDirectory = assetsDirectory;
                    return assetsDirectory;
                }

-                throw new ArgumentException("Can't find the project asserts directory");
+                throw new ArgumentException("Can't find the project assets directory");
            }

            return s_projectsDirectory;
--- a/test/dotnet-sln.Tests/GivenDotnetSlnAdd.cs
+++ b/test/dotnet-sln.Tests/GivenDotnetSlnAdd.cs
@ -974,7 +974,7 @@ EndGlobal
                .Should().BeVisuallyEquivalentTo(contentBefore);
        }

-        [Fact(Skip = "https://github.com/dotnet/sdk/issues/522")]
+        [Fact]
        public void WhenPassedAnUnknownProjectTypeItFails()
        {
            var projectDirectory = _testAssetsManager
--- a/test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestfromCsproj.cs
+++ b/test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestfromCsproj.cs
@ -609,7 +609,7 @@ namespace Microsoft.DotNet.Cli.Test.Tests
            result.ExitCode.Should().Be(0);
        }

-        [PlatformSpecificFact(TestPlatforms.Linux, Skip = "https://github.com/dotnet/sdk/issues/22865")]
+        [PlatformSpecificFact(TestPlatforms.Linux)]
        public void ItShouldShowWarningMessageOnCollectCodeCoverageThatProfilerWasNotInitialized()
        {
            var testProjectDirectory = CopyAndRestoreVSTestDotNetCoreTestApp("13");
--- a/test/dotnet-watch.Tests/Watch/ProgramTests.cs
+++ b/test/dotnet-watch.Tests/Watch/ProgramTests.cs
@ -14,7 +14,7 @@ namespace Microsoft.DotNet.Watcher.Tests
        {
        }

-        [PlatformSpecificFact(TestPlatforms.Windows | TestPlatforms.Linux, Skip = "https://github.com/dotnet/aspnetcore/issues/23394")]
+        [PlatformSpecificFact(TestPlatforms.Windows | TestPlatforms.Linux)]
        public async Task ConsoleCancelKey()
        {
            var console = new TestConsole(Logger);